@codyswann/lisa 2.222.2 → 2.223.0

package/plugins/src/base/skills/lisa-linear-add-journey/SKILL.md

@@ -83,9 +83,10 @@ Compose the journey with typed `[EVIDENCE: <artifact-type>: <name>]` markers at
 2. **Concrete, runnable steps** — `Run \`curl -s localhost:3000/health | jq .status\`` not "Check the endpoint".
 3. **Include environment setup** — Database connection, running services, env vars.
 4. **Markers are typed artifacts, not assertion labels** — `[EVIDENCE: <artifact-type>: <kebab-name>]`. `[EVIDENCE: load-failure-handled-gracefully]` names a claim with nothing to capture; write `[EVIDENCE: screenshot: load-failure-error-state]` or `[EVIDENCE: perf-trace: pipeline-load-tti]`. Names are kebab-case and unique within the ticket.
-5. **Assertions are measurable** — "Returns 200 with `{status: ok}`" not "API works correctly".
-6. **Cover happy path and error path** — At minimum, one success and one failure evidence marker.
-7. **On a leaf work unit, the markers are binding** — For a Bug / Task / Sub-task / Improvement, every typed `[EVIDENCE: <artifact-type>: <name>]` here is the item's evidence manifest: validation gate S14 requires at least one, and the item cannot be closed until each named artifact is captured **in its declared type** and attached (see the "Per-Work-Unit Evidence Contract" in the `verification` rule). Name only evidence you intend to capture — and name all of it.
+5. **Cross-item references are non-binding** — If the journey needs to mention another item's artifact, use `[EVIDENCE-REF: <tracker-ref>: <artifact-type>: <kebab-name>]` (for example, `[EVIDENCE-REF: ENG-123: cli-output: upstream-contract-pass]`). Do not paste a sibling item's `[EVIDENCE: ...]` marker into this item; S14 treats `[EVIDENCE: ...]` as this item's own manifest and ignores `EVIDENCE-REF`.
+6. **Assertions are measurable** — "Returns 200 with `{status: ok}`" not "API works correctly".
+7. **Cover happy path and error path** — At minimum, one success and one failure evidence marker.
+8. **On a leaf work unit, the markers are binding** — For a Bug / Task / Sub-task / Improvement, every typed `[EVIDENCE: <artifact-type>: <name>]` here is the item's evidence manifest: validation gate S14 requires at least one, and the item cannot be closed until each named artifact is captured **in its declared type** and attached (see the "Per-Work-Unit Evidence Contract" in the `verification` rule). Name only evidence you intend to capture — and name all of it; `EVIDENCE-REF` never satisfies or extends the manifest.
 
 ### Step 6: Present to User for Approval
 

package/plugins/src/base/skills/lisa-linear-validate-issue/SKILL.md

@@ -209,9 +209,11 @@ Each marker must satisfy ALL of:
 - `<artifact-type>` is one of the fixed taxonomy: `screenshot`, `recording`, `http-transcript`, `cli-output`, `log-snippet`, `db-query-output`, `perf-trace`, `test-run-log`, `deploy-log`, `state-dump`. (The legacy `[SCREENSHOT: name]` form is accepted as `screenshot`.)
 - `<name>` is kebab-case and unique within the item.
 
+Non-binding cross-references use `[EVIDENCE-REF: <tracker-ref>: <artifact-type>: <name>]`, where `<tracker-ref>` is the owning item or issue (`ENG-123`, `PROJ-123`, `#123`, `owner/repo#123`, or a tracker URL). S14 MUST ignore `EVIDENCE-REF` markers when deriving this item's manifest, and a valid `EVIDENCE-REF` does not satisfy the "at least one marker" requirement. Agents must use `EVIDENCE-REF` instead of quoting a sibling item's `[EVIDENCE: ...]` marker in prose.
+
 **A marker names an artifact, not an assertion.** An untyped marker (`[EVIDENCE: load-failure-handled-gracefully]`) is an assertion label with nothing to capture and must FAIL, with a remediation that shows the typed transformation (e.g. → `[EVIDENCE: screenshot: load-failure-error-state]`, `[EVIDENCE: perf-trace: pipeline-load-tti]`).
 
-FAIL when the Validation Journey is present but declares zero markers, when any marker is untyped or uses a type outside the taxonomy, or when any name is empty, duplicated, or not kebab-case. A behavior-changing work unit SHOULD declare both a success marker and an error/edge marker; a journey with only one marker passes but the remediation should recommend adding the error/edge case.
+FAIL when the Validation Journey is present but declares zero binding `[EVIDENCE: ...]` markers, when any binding marker is untyped or uses a type outside the taxonomy, or when any binding name is empty, duplicated, or not kebab-case. A behavior-changing work unit SHOULD declare both a success marker and an error/edge marker; a journey with only one binding marker passes but the remediation should recommend adding the error/edge case.
 
 This gate depends on S11. It is `N/A` for containers — a **Project** (the Epic equivalent), or any item with open child work (coordination containers, not work units) — and for leaf units with `runtime_behavior_change = false` (doc-only / config-only / type-only). If S11 fails because the Validation Journey is absent, S14 also FAILs (there is no manifest to bind) with remediation pointing back to `lisa-linear-add-journey`.
 

package/scripts/copy-opencode-plugin-templates.mjs

@@ -15,6 +15,11 @@ import path from "node:path";
 const repoRoot = path.resolve(import.meta.dirname, "..");
 const sourceDir = path.join(repoRoot, "src", "opencode", "plugin-templates");
 const destDir = path.join(repoRoot, "dist", "opencode", "plugin-templates");
+const canonicalHookDir = path.join(repoRoot, "plugins", "src", "base", "hooks");
+const canonicalSupportFiles = [
+  "parity-safety-net.sh",
+  "parity-safety-net-heredoc.py",
+];
 
 fs.rmSync(destDir, { recursive: true, force: true });
 fs.mkdirSync(destDir, { recursive: true });
@@ -27,3 +32,10 @@ for (const entry of fs.readdirSync(sourceDir, { withFileTypes: true })) {
   const destPath = path.join(destDir, entry.name);
   fs.copyFileSync(sourcePath, destPath);
 }
+
+for (const filename of canonicalSupportFiles) {
+  fs.copyFileSync(
+    path.join(canonicalHookDir, filename),
+    path.join(destDir, filename)
+  );
+}

package/scripts/generate-agy-plugin-artifacts.mjs

@@ -18,8 +18,8 @@
  * hooks.json must be at root; the command points at the absolute installed path
  * via `$HOME`). Only events agy supports map: PreToolUse / PostToolUse /
  * PreInvocation / PostInvocation / Stop. SessionStart is NOT supported, so
- * install-pkgs / setup-jira-cli CANNOT ship as agy hooks — only block-no-verify
- * (PreToolUse) maps. Only the BASE plugin manifest carries the universal hooks,
+ * install-pkgs / setup-jira-cli CANNOT ship as agy hooks. Portable PreToolUse
+ * guards map through thin agy-protocol adapters. Only the BASE plugin manifest carries the universal hooks,
  * so only `lisa-agy` gets a hooks.json; stack variants emit none.
  *
  * MCP (user-global, NOT plugin-bundled): agy ignores plugin-bundled MCP and only
@@ -216,6 +216,15 @@ const AGY_PLUGIN_HOOKS = [
     event: "PreToolUse",
     matcher: "run_command",
     agyScript: "block-no-verify.agy.sh",
+    supportScripts: [],
+  },
+  {
+    sourceScript: "parity-safety-net.sh",
+    hookName: "lisa-parity-safety-net",
+    event: "PreToolUse",
+    matcher: "run_command",
+    agyScript: "parity-safety-net.agy.sh",
+    supportScripts: ["parity-safety-net.sh", "parity-safety-net-heredoc.py"],
   },
 ];
 
@@ -257,11 +266,13 @@ function sourceReferencesScript(sourceHooks, scriptName) {
 function emitAgyPluginHooks(srcDir, outDir, sourceHooks, installDirName) {
   const applicable = AGY_PLUGIN_HOOKS.filter(h => {
     if (!sourceReferencesScript(sourceHooks, h.sourceScript)) return false;
-    const scriptSource = path.join(srcDir, "hooks", h.agyScript);
-    if (!fs.existsSync(scriptSource)) {
-      throw new Error(
-        `Missing agy hook script for ${h.sourceScript}: ${scriptSource}`
-      );
+    for (const script of [h.agyScript, ...(h.supportScripts ?? [])]) {
+      const scriptSource = path.join(srcDir, "hooks", script);
+      if (!fs.existsSync(scriptSource)) {
+        throw new Error(
+          `Missing agy hook script for ${h.sourceScript}: ${scriptSource}`
+        );
+      }
     }
     return true;
   });
@@ -293,9 +304,12 @@ function emitAgyPluginHooks(srcDir, outDir, sourceHooks, installDirName) {
   // Copy the agy-protocol scripts into the variant's hooks/ subdir.
   const hooksDir = path.join(outDir, "hooks");
   fs.mkdirSync(hooksDir, { recursive: true });
-  for (const h of applicable) {
-    const scriptSource = path.join(srcDir, "hooks", h.agyScript);
-    const scriptDest = path.join(hooksDir, h.agyScript);
+  const scripts = new Set(
+    applicable.flatMap(h => [h.agyScript, ...(h.supportScripts ?? [])])
+  );
+  for (const script of scripts) {
+    const scriptSource = path.join(srcDir, "hooks", script);
+    const scriptDest = path.join(hooksDir, script);
     fs.copyFileSync(scriptSource, scriptDest);
     fs.chmodSync(scriptDest, 0o755);
   }