@codyswann/lisa 2.119.1 → 2.121.1

package/scripts/lib/per-agent-hook-filter.mjs

@@ -0,0 +1,249 @@
+/**
+ * Per-agent hook ship/strip filter for Pattern B plugin variant generators.
+ *
+ * Implements the per-agent ship-list from
+ * wiki/architecture/lisa-hook-per-agent-ship-list.md (Wave 1 audit).
+ *
+ * Each Pattern B per-agent plugin variant generator imports `filterHooksForAgent`
+ * to walk the source plugin's hook block and the on-disk hook scripts, returning
+ * an agent-appropriate filtered set.
+ *
+ * Agent strategies:
+ *   - Claude: keep everything (this module is not invoked for the Claude variant)
+ *   - Codex: ship universal + SubagentStart (handled by the Codex generator's own
+ *     ship list — this module is not invoked for Codex; Codex uses the existing
+ *     generate-codex-plugin-artifacts.mjs path)
+ *   - Cursor: strip inject-rules.sh (Cursor auto-loads rules/ natively), strip
+ *     Claude-team-specific scripts and `entire hooks claude-code *` calls
+ *   - agy: ship NOTHING (agy plugin hooks do not fire in -p mode per verified-by-run)
+ *   - Copilot: strip SubagentStart hooks (event missing), strip Claude-team-specific
+ *     scripts, conditionally strip inject-rules.sh if the rules-auto-load probe is
+ *     positive (caller passes copilotRulesAutoLoads via options)
+ *
+ * @module scripts/lib/per-agent-hook-filter
+ */
+
+/** Per-script applicability rules from the Wave 1 audit. */
+const SCRIPT_RULES = {
+  "block-no-verify.sh": {
+    claude: true,
+    codex: true,
+    cursor: true,
+    agy: false,
+    copilot: true,
+  },
+  "enforce-team-first.sh": {
+    claude: true,
+    codex: false,
+    cursor: false,
+    agy: false,
+    copilot: false,
+  },
+  "inject-rules.sh": {
+    claude: true,
+    codex: true,
+    cursor: false, // collision: Cursor auto-loads rules/ natively
+    agy: false, // hooks don't fire in -p
+    copilot: true, // conservative default; conditionally stripped if rules-auto-load probe positive
+  },
+  "inject-flow-context.sh": {
+    claude: true,
+    codex: true,
+    cursor: false, // SubagentStart unverified on Cursor; conservative default
+    agy: false,
+    copilot: false, // Copilot lacks SubagentStart event
+  },
+  "install-pkgs.sh": {
+    claude: true,
+    codex: true,
+    cursor: true,
+    agy: false,
+    copilot: true,
+  },
+  "notify-ntfy.sh": {
+    claude: true,
+    codex: true,
+    cursor: true,
+    agy: false,
+    copilot: true,
+  },
+  "setup-jira-cli.sh": {
+    claude: true,
+    codex: true,
+    cursor: true,
+    agy: false,
+    copilot: true,
+  },
+  // Unregistered scripts — exclude by default until classified.
+  "ticket-sync-reminder.sh": {
+    claude: false,
+    codex: false,
+    cursor: false,
+    agy: false,
+    copilot: false,
+  },
+  "track-plan-sessions.sh": {
+    claude: false,
+    codex: false,
+    cursor: false,
+    agy: false,
+    copilot: false,
+  },
+};
+
+/** Universal exclude pattern: development helpers. */
+const SCRIPT_EXCLUDE_PATTERNS = [/debug/i];
+
+/** Hook command shape: { type: "command", command: "..." } */
+const isEntireClaudeCodeCommand = cmd =>
+  typeof cmd === "string" &&
+  /^command -v entire >\/dev\/null 2>&1 && entire hooks claude-code /.test(cmd);
+
+const scriptNameFromCommand = cmd => {
+  if (typeof cmd !== "string") return null;
+  const match = /\$\{CLAUDE_PLUGIN_ROOT\}\/hooks\/([^/\s]+\.sh)/.exec(cmd);
+  return match ? match[1] : null;
+};
+
+/**
+ * Translate Claude PascalCase event names to a target agent's native casing.
+ *
+ * Per the Wave 1 audit's Wave 3 contract step 4 + step 6:
+ *   - Cursor: keep PascalCase (loader auto-normalizes)
+ *   - Codex: keep PascalCase
+ *   - Copilot: rewrite to lowercase / camelCase per Copilot's docs
+ *
+ * @param {string} eventName Claude event name (e.g. "PreToolUse")
+ * @param {"cursor"|"agy"|"copilot"} agent Target agent slug
+ * @returns {string} Translated event name
+ */
+export function translateEventName(eventName, agent) {
+  if (agent !== "copilot") return eventName;
+  const COPILOT_EVENTS = {
+    PreToolUse: "preToolUse",
+    PostToolUse: "postToolUse",
+    SessionStart: "sessionStart",
+    SessionEnd: "sessionEnd",
+    UserPromptSubmit: "userPromptSubmitted",
+    Stop: "agentStop",
+    SubagentStart: "subagentStart", // not supported but include for symmetry
+    SubagentStop: "subagentStop",
+  };
+  return COPILOT_EVENTS[eventName] ?? eventName;
+}
+
+/**
+ * Whether a script ships to the given agent under the Wave 1 audit ship-list.
+ *
+ * Falls through to true (ship) for scripts not in the rules table — the
+ * conservative default for unknown scripts is to include them; explicit
+ * exclusions live in SCRIPT_RULES.
+ *
+ * @param {string} scriptName e.g. "inject-rules.sh"
+ * @param {"claude"|"codex"|"cursor"|"agy"|"copilot"} agent
+ * @returns {boolean}
+ */
+export function shouldShipScript(scriptName, agent) {
+  // Universal exclude (debug helpers etc.)
+  if (SCRIPT_EXCLUDE_PATTERNS.some(re => re.test(scriptName))) return false;
+  const rules = SCRIPT_RULES[scriptName];
+  if (!rules) return true;
+  return Boolean(rules[agent]);
+}
+
+/**
+ * Whether a hook command entry ships to the given agent.
+ *
+ * Three classes of hook commands:
+ *   1. `entire hooks claude-code *` — Claude-only, strip for everyone else
+ *   2. `${CLAUDE_PLUGIN_ROOT}/hooks/<script>` — ship per script rules
+ *   3. Anything else — ship by default (rare; conservative)
+ *
+ * @param {{ type: string, command: string }} hook
+ * @param {string} eventName
+ * @param {"cursor"|"agy"|"copilot"|"codex"} agent
+ * @param {{ copilotRulesAutoLoads?: boolean }} [opts]
+ * @returns {boolean}
+ */
+export function shouldShipHook(hook, _eventName, agent, opts = {}) {
+  if (!hook || typeof hook.command !== "string") return false;
+  const { command } = hook;
+
+  // entire calls are Claude-only.
+  if (isEntireClaudeCodeCommand(command)) return false;
+
+  // Script reference: look up per-script rules.
+  const scriptName = scriptNameFromCommand(command);
+  if (scriptName) {
+    // Cursor collision rule for rules + Copilot conditional rules strip
+    if (scriptName === "inject-rules.sh") {
+      if (agent === "cursor") return false;
+      if (agent === "agy") return false;
+      if (agent === "copilot" && opts.copilotRulesAutoLoads === true)
+        return false;
+    }
+    return shouldShipScript(scriptName, agent);
+  }
+
+  // Anything else (rare) — ship by default
+  return true;
+}
+
+/**
+ * Filter the plugin's hook block for a target agent and translate event names.
+ *
+ * Returns the new hook block (or undefined when the block ends up empty after
+ * filtering, which means the manifest should omit the hooks field entirely).
+ *
+ * For agy this function returns undefined regardless of input because agy
+ * variants ship no hooks.
+ *
+ * @param {Record<string, Array<{ matcher?: string, hooks: Array<object> }>>} hookBlock
+ *   The Claude-format hook block from .claude-plugin/plugin.json.
+ * @param {"cursor"|"agy"|"copilot"|"codex"} agent
+ * @param {{ copilotRulesAutoLoads?: boolean }} [opts]
+ * @returns {Record<string, Array<{ matcher?: string, hooks: Array<object> }>> | undefined}
+ */
+export function filterHooksForAgent(hookBlock, agent, opts = {}) {
+  if (agent === "agy") return undefined;
+  if (!hookBlock || typeof hookBlock !== "object") return undefined;
+
+  /** @type {Record<string, Array<{ matcher?: string, hooks: Array<object> }>>} */
+  const out = {};
+
+  for (const [claudeEventName, entries] of Object.entries(hookBlock)) {
+    if (!Array.isArray(entries)) continue;
+    const filteredEntries = [];
+    for (const entry of entries) {
+      const handlerArray = entry?.hooks;
+      if (!Array.isArray(handlerArray)) continue;
+      const filteredHandlers = handlerArray.filter(h =>
+        shouldShipHook(h, claudeEventName, agent, opts)
+      );
+      if (filteredHandlers.length > 0) {
+        filteredEntries.push({ ...entry, hooks: filteredHandlers });
+      }
+    }
+    if (filteredEntries.length > 0) {
+      const translated = translateEventName(claudeEventName, agent);
+      out[translated] = filteredEntries;
+    }
+  }
+
+  return Object.keys(out).length > 0 ? out : undefined;
+}
+
+/**
+ * Walk a hooks/ directory and return the list of script filenames that should
+ * ship to the agent. Scripts referenced by no surviving hook entry are
+ * naturally excluded by callers (they should call this to enumerate files
+ * to keep AFTER filtering the manifest).
+ *
+ * @param {string[]} scriptFilenames Filenames found in hooks/
+ * @param {"cursor"|"agy"|"copilot"|"codex"} agent
+ * @returns {string[]}
+ */
+export function filterScriptsForAgent(scriptFilenames, agent) {
+  if (agent === "agy") return [];
+  return scriptFilenames.filter(name => shouldShipScript(name, agent));
+}

package/scripts/probes/wave3-verification.sh

@@ -0,0 +1,106 @@
+#!/usr/bin/env bash
+# Wave 3 per-cluster empirical verification probes.
+#
+# Runs end-to-end checks against each in-scope coding agent CLI that's
+# installed on the local machine. Output is captured under
+# `/tmp/wave3-e2e-<agent>.md` for attachment to the Wave 3 PR description.
+#
+# When an agent CLI is not on $PATH, the probe is skipped (not failed) — this
+# script must succeed on CI hosts that lack the runtime CLIs. Per the Wave 2
+# fan-out spec the probe cache (scripts/internal-<agent>-runtime-probe.json)
+# captures unverified state so the Pattern B generators can fall through to
+# conservative defaults.
+#
+# Usage: bash scripts/probes/wave3-verification.sh
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
+PLUGINS_DIR="$REPO_ROOT/plugins"
+
+mkdir -p /tmp/wave3-evidence
+
+probe_cursor() {
+  if ! command -v cursor-agent >/dev/null 2>&1; then
+    echo "[skip] cursor-agent not on PATH" | tee /tmp/wave3-evidence/cursor.md
+    return 0
+  fi
+  if [ ! -d "$PLUGINS_DIR/lisa-cursor" ]; then
+    echo "[skip] plugins/lisa-cursor not built — run \`bun run build:plugins\` first" \
+      | tee /tmp/wave3-evidence/cursor.md
+    return 0
+  fi
+  {
+    echo "# Cursor Wave 3 Verification"
+    echo
+    echo "Probe: \`cursor-agent -p --trust --plugin-dir plugins/lisa-cursor \"list Lisa skills\"\`"
+    echo
+    echo "## Result"
+    echo
+    echo '```'
+    cursor-agent -p --trust --plugin-dir "$PLUGINS_DIR/lisa-cursor" --model composer-2.5 \
+      "List the names of Lisa skills you can see. One per line." 2>&1 | head -40 || true
+    echo '```'
+  } > /tmp/wave3-evidence/cursor.md
+}
+
+probe_agy() {
+  if ! command -v agy >/dev/null 2>&1; then
+    echo "[skip] agy not on PATH" | tee /tmp/wave3-evidence/agy.md
+    return 0
+  fi
+  if [ ! -d "$PLUGINS_DIR/lisa-agy" ]; then
+    echo "[skip] plugins/lisa-agy not built" | tee /tmp/wave3-evidence/agy.md
+    return 0
+  fi
+  {
+    echo "# agy Wave 3 Verification"
+    echo
+    echo "Probe 1: \`agy plugin validate plugins/lisa-agy\` (schema gate)"
+    echo
+    echo '```'
+    agy plugin validate "$PLUGINS_DIR/lisa-agy" 2>&1 | head -10 || true
+    echo '```'
+    echo
+    echo "Probe 2: install + list"
+    echo
+    echo '```'
+    agy plugin install "$PLUGINS_DIR/lisa-agy" 2>&1 | head -10 || true
+    echo "---"
+    agy plugin list 2>&1 | head -20 || true
+    echo '```'
+  } > /tmp/wave3-evidence/agy.md
+}
+
+probe_copilot() {
+  if ! command -v copilot >/dev/null 2>&1; then
+    echo "[skip] copilot not on PATH" | tee /tmp/wave3-evidence/copilot.md
+    return 0
+  fi
+  if [ ! -d "$PLUGINS_DIR/lisa-copilot" ]; then
+    echo "[skip] plugins/lisa-copilot not built" | tee /tmp/wave3-evidence/copilot.md
+    return 0
+  fi
+  {
+    echo "# Copilot Wave 3 Verification"
+    echo
+    echo "Probe: \`copilot -p --allow-all-tools --plugin-dir plugins/lisa-copilot \"list Lisa agents\"\`"
+    echo
+    echo "## Result"
+    echo
+    echo '```'
+    copilot -p "List names of Lisa agents available. One per line, no prose." \
+      --allow-all-tools --model gpt-5.5 --effort medium \
+      --plugin-dir "$PLUGINS_DIR/lisa-copilot" 2>&1 | head -40 || true
+    echo '```'
+  } > /tmp/wave3-evidence/copilot.md
+}
+
+echo "[probing cursor]"
+probe_cursor
+echo "[probing agy]"
+probe_agy
+echo "[probing copilot]"
+probe_copilot
+echo
+echo "Evidence written to /tmp/wave3-evidence/{cursor,agy,copilot}.md"