@codyswann/lisa 2.119.0 → 2.121.0

package/plugins/lisa-cursor/skills/jira-evidence/scripts/post-evidence.sh

@@ -0,0 +1,163 @@
+#!/usr/bin/env bash
+# post-evidence.sh — Upload evidence and post to JIRA + GitHub PR description
+#
+# Usage:
+#   bash post-evidence.sh <TICKET_ID> <EVIDENCE_DIR> <PR_NUMBER>
+#
+# Prerequisites:
+#   - JIRA_API_TOKEN env var set
+#   - jira-cli configured (~/.config/.jira/.config.yml)
+#   - gh CLI authenticated
+#
+# What it does:
+#   1. Uploads evidence files to the 'pr-assets' GitHub release
+#   2. Updates the GitHub PR description with evidence/comment.md
+#   3. Uploads image evidence as JIRA attachments
+#   4. Posts/updates the JIRA comment with evidence/comment.txt
+#   5. Moves the JIRA ticket to "Code Review"
+
+set -euo pipefail
+
+TICKET_ID="${1:?Usage: post-evidence.sh <TICKET_ID> <EVIDENCE_DIR> <PR_NUMBER>}"
+EVIDENCE_DIR="${2:?Usage: post-evidence.sh <TICKET_ID> <EVIDENCE_DIR> <PR_NUMBER>}"
+PR_NUMBER="${3:?Usage: post-evidence.sh <TICKET_ID> <EVIDENCE_DIR> <PR_NUMBER>}"
+
+JIRA_CONFIG="${HOME}/.config/.jira/.config.yml"
+if [[ ! -f "$JIRA_CONFIG" ]]; then
+  echo "ERROR: jira-cli config not found at $JIRA_CONFIG — run 'jira init' first" >&2
+  exit 1
+fi
+JIRA_SERVER=$(grep '^server:' "$JIRA_CONFIG" | awk '{print $2}')
+JIRA_USER=$(grep '^login:' "$JIRA_CONFIG" | awk '{print $2}')
+GH_REPO=$(gh repo view --json nameWithOwner --jq '.nameWithOwner')
+RELEASE_TAG="pr-assets"
+
+if [[ -z "${JIRA_API_TOKEN:-}" ]]; then
+  echo "ERROR: JIRA_API_TOKEN environment variable is not set" >&2
+  exit 1
+fi
+
+# Collect numbered evidence files (images + text)
+SCREENSHOTS=()
+while IFS= read -r -d '' f; do
+  SCREENSHOTS+=("$f")
+done < <(find "$EVIDENCE_DIR" -maxdepth 1 -name '[0-9][0-9]-*.png' -print0 | sort -z)
+
+TEXT_EVIDENCE=()
+while IFS= read -r -d '' f; do
+  TEXT_EVIDENCE+=("$f")
+done < <(find "$EVIDENCE_DIR" -maxdepth 1 \( -name '[0-9][0-9]-*.txt' -o -name '[0-9][0-9]-*.json' \) ! -name 'comment.txt' -print0 | sort -z)
+
+ALL_EVIDENCE=("${SCREENSHOTS[@]}" "${TEXT_EVIDENCE[@]}")
+
+if [[ ${#ALL_EVIDENCE[@]} -eq 0 ]]; then
+  echo "ERROR: No numbered evidence files found in $EVIDENCE_DIR (expected NN-*.png, NN-*.txt, or NN-*.json)" >&2
+  exit 1
+fi
+
+echo "Found ${#SCREENSHOTS[@]} screenshots and ${#TEXT_EVIDENCE[@]} text evidence files to upload"
+
+# Compute JIRA auth early (used in steps 3 and 4)
+JIRA_AUTH=$(echo -n "$JIRA_USER:$JIRA_API_TOKEN" | base64)
+
+# ── Step 1: Upload to GitHub pr-assets release ──────────────────────────────
+echo ""
+echo "==> Uploading to GitHub release '$RELEASE_TAG'..."
+
+for FILE in "${ALL_EVIDENCE[@]}"; do
+  FILENAME=$(basename "$FILE")
+  echo "  ↑ $FILENAME"
+  gh release upload "$RELEASE_TAG" "$FILE" --repo "$GH_REPO" --clobber
+done
+
+echo "  ✓ GitHub release assets uploaded"
+
+# ── Step 2: Update GitHub PR description with evidence ──────────────────────
+COMMENT_MD="$EVIDENCE_DIR/comment.md"
+if [[ ! -f "$COMMENT_MD" ]]; then
+  echo "ERROR: $COMMENT_MD not found — run generate-templates.py first" >&2
+  exit 1
+fi
+
+echo ""
+echo "==> Updating GitHub PR #$PR_NUMBER description..."
+
+CURRENT_BODY=$(gh pr view "$PR_NUMBER" --json body --jq '.body')
+
+# Replace or append the Evidence section
+if echo "$CURRENT_BODY" | grep -q "^## Evidence"; then
+  # Replace from "## Evidence" to end of file
+  NEW_BODY=$(echo "$CURRENT_BODY" | sed '/^## Evidence/,$d')
+  EVIDENCE_SECTION=$(cat "$COMMENT_MD")
+  UPDATED_BODY="${NEW_BODY}
+${EVIDENCE_SECTION}"
+else
+  EVIDENCE_SECTION=$(cat "$COMMENT_MD")
+  UPDATED_BODY="${CURRENT_BODY}
+
+${EVIDENCE_SECTION}"
+fi
+
+gh pr edit "$PR_NUMBER" --body "$UPDATED_BODY"
+echo "  ✓ PR description updated with evidence"
+
+# ── Step 3: Upload image evidence as JIRA attachments ───────────────────────
+if [[ ${#SCREENSHOTS[@]} -gt 0 ]]; then
+  echo ""
+  echo "==> Uploading image attachments to JIRA $TICKET_ID..."
+
+  for IMG in "${SCREENSHOTS[@]}"; do
+    FILENAME=$(basename "$IMG")
+    echo "  ↑ $FILENAME"
+    RESP=$(curl -s -w "\nHTTP_CODE:%{http_code}" \
+      -X POST \
+      -H "Authorization: Basic $JIRA_AUTH" \
+      -H "X-Atlassian-Token: no-check" \
+      -F "file=@$IMG" \
+      "$JIRA_SERVER/rest/api/3/issue/$TICKET_ID/attachments")
+    HTTP_CODE=$(echo "$RESP" | grep "HTTP_CODE:" | cut -d: -f2)
+    if [[ "$HTTP_CODE" != "200" ]]; then
+      echo "  WARNING: Failed to upload $FILENAME (HTTP $HTTP_CODE)" >&2
+    fi
+  done
+
+  echo "  ✓ JIRA attachments uploaded"
+fi
+
+# ── Step 4: Post JIRA comment ────────────────────────────────────────────────
+COMMENT_TXT="$EVIDENCE_DIR/comment.txt"
+if [[ ! -f "$COMMENT_TXT" ]]; then
+  echo "ERROR: $COMMENT_TXT not found — run generate-templates.py first" >&2
+  exit 1
+fi
+
+echo ""
+echo "==> Posting JIRA comment on $TICKET_ID..."
+
+COMMENT_BODY=$(cat "$COMMENT_TXT")
+COMMENT_JSON=$(python3 -c "import sys, json; print(json.dumps(sys.stdin.read()))" <<< "$COMMENT_BODY")
+
+RESP=$(curl -s -w "\nHTTP_CODE:%{http_code}" \
+  -X POST \
+  -H "Authorization: Basic $JIRA_AUTH" \
+  -H "Content-Type: application/json" \
+  "$JIRA_SERVER/rest/api/2/issue/$TICKET_ID/comment" \
+  -d "{\"body\": $COMMENT_JSON}")
+HTTP_CODE=$(echo "$RESP" | grep "HTTP_CODE:" | cut -d: -f2)
+
+if [[ "$HTTP_CODE" == "201" ]]; then
+  echo "  ✓ JIRA comment posted"
+else
+  echo "  WARNING: JIRA comment returned HTTP $HTTP_CODE" >&2
+  echo "$RESP" | grep -v "HTTP_CODE:" | head -3
+fi
+
+# ── Step 5: Move ticket to Code Review ──────────────────────────────────────
+echo ""
+echo "==> Moving $TICKET_ID to Code Review..."
+jira issue move "$TICKET_ID" "Code Review" 2>&1 && echo "  ✓ Ticket moved to Code Review" || echo "  WARNING: Could not move ticket" >&2
+
+echo ""
+echo "==> Done!"
+echo "    JIRA:   $JIRA_SERVER/browse/$TICKET_ID"
+echo "    GitHub: https://github.com/$GH_REPO/pull/$PR_NUMBER"

package/plugins/lisa-cursor/skills/jira-journey/SKILL.md

@@ -0,0 +1,127 @@
+---
+name: jira-journey
+description: "Parse a JIRA ticket's Validation Journey section, execute the verification steps using appropriate tools (curl, test commands, database queries), capture evidence, and post to JIRA + GitHub PR using the jira-evidence skill."
+allowed-tools: ["Bash", "Read", "Glob", "Grep", "Skill"]
+---
+
+# JIRA Validation Journey (TypeScript)
+
+All Atlassian operations in this skill go through `lisa:atlassian-access`. Do not call MCP tools or `acli` directly. Note: the helper scripts (`scripts/parse-plan.py`, `scripts/jira-evidence/post-evidence.sh`) currently use direct API calls and are pending migration to route through `atlassian-access`.
+
+Parse a JIRA ticket's Validation Journey, execute the verification steps using the appropriate tools for the change type, capture evidence at each `[EVIDENCE: name]` marker, and post to JIRA + GitHub PR.
+
+## Arguments
+
+`$ARGUMENTS`: `<TICKET_ID> [PR_NUMBER]`
+
+- `TICKET_ID` (required): JIRA ticket key (e.g., `PROJ-123`)
+- `PR_NUMBER` (optional): GitHub PR number to update description
+
+## Prerequisites
+
+- `JIRA_API_TOKEN` environment variable set
+- `jira-cli` configured (`~/.config/.jira/.config.yml`)
+- `gh` CLI authenticated
+- Appropriate services running for the verification type (dev server, database, etc.)
+
+## Workflow
+
+### Step 1: Parse the Validation Journey
+
+Run the parser script to extract the Validation Journey from the JIRA ticket description:
+
+```bash
+python3 .claude/skills/jira-journey/scripts/parse-plan.py <TICKET_ID>
+```
+
+The script outputs JSON with: `ticket`, `prerequisites`, `steps`, `viewports`, `assertions`.
+
+Note: `viewports` may be empty for TypeScript tickets — that is expected.
+
+### Step 2: Satisfy Prerequisites
+
+Before starting the journey, verify each prerequisite:
+
+1. Check if required services are running
+2. Verify database connectivity if needed
+3. Ensure environment variables are set
+4. Run any setup commands mentioned in prerequisites
+
+### Step 3: Execute Steps and Capture Evidence
+
+Execute each step sequentially. For each step, determine the verification approach based on the step text and change type:
+
+- **API endpoints** → Run curl commands, capture HTTP response to `evidence/NN-name.txt`
+- **Database changes** → Run psql/migration commands, capture schema output to `evidence/NN-name.txt`
+- **Background jobs** → Trigger the job, check queue/state, capture logs to `evidence/NN-name.txt`
+- **Library/utility changes** → Run tests, capture output to `evidence/NN-name.txt`
+- **Security fixes** → Reproduce exploit attempt, verify fix, capture output to `evidence/NN-name.txt`
+
+At each `[EVIDENCE: name]` marker, capture stdout/stderr to a numbered file:
+
+#### Evidence Naming Convention
+
+Evidence files are named: `{NN}-{evidence-name}.txt` (or `.json` for structured data)
+
+- `NN`: zero-padded sequential number (01, 02, 03...)
+- `evidence-name`: the value from `[EVIDENCE: name]` in the JIRA step
+
+Example:
+
+```text
+evidence/
+  01-health-check.json
+  02-schema-after-migration.txt
+  03-rate-limit-response.txt
+  comment.txt
+  comment.md
+```
+
+### Step 4: Generate Evidence Templates
+
+After capturing all evidence, run the template generator:
+
+```bash
+python3 .claude/skills/jira-journey/scripts/generate-templates.py \
+  <TICKET_ID> \
+  <PR_NUMBER> \
+  <BRANCH_NAME> \
+  ./evidence
+```
+
+This generates `evidence/comment.txt` (JIRA wiki markup) and `evidence/comment.md` (GitHub markdown) with evidence formatted as code blocks.
+
+### Step 5: Post Evidence
+
+Use the jira-evidence skill to post everything:
+
+```bash
+bash .claude/skills/jira-evidence/scripts/post-evidence.sh <TICKET_ID> ./evidence <PR_NUMBER>
+```
+
+### Step 6: Verify
+
+Confirm evidence is posted to both the JIRA ticket and GitHub PR.
+
+## Verification Patterns Reference
+
+The agent should use patterns from the project's `verfication.md` when executing steps:
+
+| Change Type | Verification Method | Evidence Format |
+|---|---|---|
+| API endpoint | `curl -s localhost:PORT/endpoint` | JSON response |
+| Database migration | `psql -c "\d table"` or migration output | Schema text |
+| Background job | Trigger + check state | Log output |
+| Library/utility | `bun run test -- path/to/test` | Test output |
+| Security fix | Reproduce + verify fix | Request/response |
+| Auth/authz | Multi-role verification | Status codes per role |
+
+## Troubleshooting
+
+### Evidence file is empty
+
+Ensure the command succeeded and produced output. Use `2>&1` to capture both stdout and stderr.
+
+### Parser returns no steps
+
+The ticket may not have a Validation Journey section. Use `/jira-add-journey <TICKET_ID>` to add one.

package/plugins/lisa-cursor/skills/jira-journey/scripts/generate-templates.py

@@ -0,0 +1,233 @@
+#!/usr/bin/env python3
+"""Generate evidence comment templates from captured text evidence.
+
+Scans an evidence directory for text/JSON evidence files, reads the journey JSON,
+and produces comment.txt (JIRA wiki markup) and comment.md (GitHub markdown).
+
+Usage:
+    python3 generate-templates.py <TICKET_ID> <PR_NUMBER> <BRANCH_NAME> <EVIDENCE_DIR> [JOURNEY_JSON]
+
+Example:
+    python3 generate-templates.py PROJ-123 42 fix/PROJ-123-api ./evidence journey.json
+
+If JOURNEY_JSON is not provided, reads from stdin.
+"""
+
+import json
+import os
+import re
+import subprocess
+import sys
+from pathlib import Path
+
+
+def get_jira_server():
+    """Read JIRA server URL from jira-cli config."""
+    config_path = Path.home() / ".config" / ".jira" / ".config.yml"
+    if not config_path.exists():
+        return ""
+    with open(config_path) as f:
+        for line in f:
+            if line.startswith("server:"):
+                return line.split(":", 1)[1].strip()
+    return ""
+
+
+def get_github_repo():
+    """Detect GitHub repo from gh CLI."""
+    try:
+        result = subprocess.run(
+            ["gh", "repo", "view", "--json", "nameWithOwner", "--jq", ".nameWithOwner"],
+            capture_output=True, text=True, timeout=10,
+        )
+        return result.stdout.strip()
+    except (subprocess.SubprocessError, FileNotFoundError):
+        return ""
+
+
+def collect_evidence(evidence_dir):
+    """Collect evidence files (text, JSON, and images) sorted by name."""
+    evidence_path = Path(evidence_dir)
+    files = []
+    for pattern in ("[0-9][0-9]-*.txt", "[0-9][0-9]-*.json", "[0-9][0-9]-*.png"):
+        files.extend(evidence_path.glob(pattern))
+    # Exclude comment.txt
+    files = [f for f in files if f.name != "comment.txt"]
+    return sorted(files, key=lambda p: p.name)
+
+
+def detect_language(filename, content):
+    """Detect code block language from filename extension and content."""
+    if filename.endswith(".json"):
+        return "json"
+    if "HTTP/" in content or "curl" in content.lower():
+        return "http"
+    if "CREATE TABLE" in content or "ALTER TABLE" in content or "\\d " in content:
+        return "sql"
+    return "text"
+
+
+def generate_jira_wiki(ticket_id, pr_number, branch, evidence_files, journey, gh_repo):
+    """Generate JIRA wiki markup comment with code block evidence."""
+    lines = []
+    lines.append(f"h2. Evidence — PR #{pr_number}")
+    lines.append("")
+    lines.append(f"*Branch:* {{{{{branch}}}}}")
+    lines.append(f"*PR:* [PR #{pr_number}|https://github.com/{gh_repo}/pull/{pr_number}]")
+    lines.append("")
+
+    # Verification Results from assertions
+    if journey.get("assertions"):
+        lines.append("h3. Verification Results")
+        lines.append("")
+        for assertion in journey["assertions"]:
+            lines.append(f"* {assertion}")
+        lines.append("")
+
+    # Evidence
+    lines.append("h3. Evidence")
+    lines.append("")
+
+    for evidence_path in evidence_files:
+        filename = evidence_path.name
+        stem = evidence_path.stem
+        # Extract readable label: remove NN- prefix
+        label_parts = stem.split("-")[1:]
+        label = " ".join(label_parts).title() if label_parts else stem
+
+        if filename.endswith(".png"):
+            display_width = 700
+            lines.append(f"*{label}:*")
+            lines.append(f"!{filename}|width={display_width}!")
+            lines.append("")
+        else:
+            content = evidence_path.read_text().strip()
+            lang = detect_language(filename, content)
+            lines.append(f"*{label}:*")
+            lines.append(f"{{code:{lang}}}")
+            lines.append(content)
+            lines.append("{code}")
+            lines.append("")
+
+    # Verification Journey steps
+    if journey.get("steps"):
+        lines.append("h3. Verification Journey")
+        lines.append("")
+        for step in journey["steps"]:
+            text = step["text"]
+            clean_text = re.sub(r'\s*\[(SCREENSHOT|EVIDENCE):\s*[^\]]+\]', '', text).strip()
+            lines.append(f"# {clean_text}")
+        lines.append("")
+
+    return "\n".join(lines)
+
+
+def generate_github_md(ticket_id, pr_number, branch, evidence_files, journey, gh_repo, jira_server):
+    """Generate GitHub markdown comment with code block evidence."""
+    release_base = f"https://github.com/{gh_repo}/releases/download/pr-assets"
+
+    lines = []
+    lines.append(f"## Evidence — PR #{pr_number}")
+    lines.append("")
+    lines.append(f"**Branch:** `{branch}`")
+    if jira_server:
+        lines.append(f"**Ticket:** [{ticket_id}]({jira_server}/browse/{ticket_id})")
+    else:
+        lines.append(f"**Ticket:** {ticket_id}")
+    lines.append("")
+
+    # Verification Results
+    if journey.get("assertions"):
+        lines.append("### Verification Results")
+        lines.append("")
+        for assertion in journey["assertions"]:
+            lines.append(f"- {assertion}")
+        lines.append("")
+
+    # Evidence
+    lines.append("### Evidence")
+    lines.append("")
+
+    for evidence_path in evidence_files:
+        filename = evidence_path.name
+        stem = evidence_path.stem
+        label_parts = stem.split("-")[1:]
+        label = " ".join(label_parts).title() if label_parts else stem
+
+        if filename.endswith(".png"):
+            lines.append(f"**{label}:**")
+            lines.append("")
+            lines.append(f"![{label}]({release_base}/{filename})")
+            lines.append("")
+        else:
+            content = evidence_path.read_text().strip()
+            lang = detect_language(filename, content)
+            lines.append(f"**{label}:**")
+            lines.append("")
+            lines.append(f"```{lang}")
+            lines.append(content)
+            lines.append("```")
+            lines.append("")
+
+    # Verification Journey
+    if journey.get("steps"):
+        lines.append("### Verification Journey")
+        lines.append("")
+        for step in journey["steps"]:
+            text = step["text"]
+            clean_text = re.sub(r'\s*\[(SCREENSHOT|EVIDENCE):\s*[^\]]+\]', '', text).strip()
+            lines.append(f"{step['number']}. {clean_text}")
+        lines.append("")
+
+    return "\n".join(lines)
+
+
+def main():
+    if len(sys.argv) < 5:
+        print(
+            "Usage: generate-templates.py <TICKET_ID> <PR_NUMBER> <BRANCH_NAME> <EVIDENCE_DIR> [JOURNEY_JSON]",
+            file=sys.stderr,
+        )
+        sys.exit(1)
+
+    ticket_id = sys.argv[1]
+    pr_number = sys.argv[2]
+    branch = sys.argv[3]
+    evidence_dir = sys.argv[4]
+    journey_file = sys.argv[5] if len(sys.argv) > 5 else None
+
+    # Read journey JSON
+    if journey_file:
+        with open(journey_file) as f:
+            journey = json.load(f)
+    else:
+        journey = json.load(sys.stdin)
+
+    gh_repo = get_github_repo()
+    if not gh_repo:
+        print("ERROR: Could not detect GitHub repo — ensure gh CLI is authenticated", file=sys.stderr)
+        sys.exit(1)
+
+    jira_server = get_jira_server()
+
+    evidence_files = collect_evidence(evidence_dir)
+    if not evidence_files:
+        print(f"ERROR: No evidence files found in {evidence_dir}", file=sys.stderr)
+        sys.exit(1)
+
+    # Generate templates
+    jira_wiki = generate_jira_wiki(ticket_id, pr_number, branch, evidence_files, journey, gh_repo)
+    github_md = generate_github_md(ticket_id, pr_number, branch, evidence_files, journey, gh_repo, jira_server)
+
+    # Write templates
+    evidence_path = Path(evidence_dir)
+    (evidence_path / "comment.txt").write_text(jira_wiki)
+    (evidence_path / "comment.md").write_text(github_md)
+
+    print(f"Generated {evidence_path / 'comment.txt'} ({len(jira_wiki)} bytes)")
+    print(f"Generated {evidence_path / 'comment.md'} ({len(github_md)} bytes)")
+    print(f"Evidence files: {len(evidence_files)}")
+
+
+if __name__ == "__main__":
+    main()