@codyswann/lisa 1.76.5 → 1.77.0

package/plugins/src/rails/hooks/inject-rules.sh

@@ -0,0 +1,22 @@
+#!/usr/bin/env bash
+# Reads all .md files from the plugin's rules/ directory and injects them
+# into the session context via additionalContext.
+# Used by SessionStart and SubagentStart hooks.
+set -euo pipefail
+
+RULES_DIR="${CLAUDE_PLUGIN_ROOT}/rules"
+
+# Bail silently if no rules directory
+[ -d "$RULES_DIR" ] || exit 0
+
+CONTEXT=""
+for file in "$RULES_DIR"/*.md; do
+  [ -f "$file" ] || continue
+  CONTEXT+="$(cat "$file")"$'\n\n'
+done
+
+# Bail if no rules found
+[ -n "$CONTEXT" ] || exit 0
+
+# Output as JSON — jq handles escaping
+jq -n --arg ctx "$CONTEXT" '{"additionalContext": $ctx}'

package/plugins/src/rails/rules/rails-conventions.md

@@ -0,0 +1,176 @@
+# Rails Coding Conventions
+
+This rule enforces Rails-specific coding standards for consistency, maintainability, and performance.
+
+## Fat Models, Skinny Controllers
+
+Controllers handle HTTP concerns only. Business logic belongs in models or service objects.
+
+```ruby
+# Correct — controller delegates to model
+class OrdersController < ApplicationController
+  def create
+    @order = Order.place(order_params, current_user)
+    redirect_to @order
+  end
+end
+
+# Wrong — business logic in controller
+class OrdersController < ApplicationController
+  def create
+    @order = Order.new(order_params)
+    @order.user = current_user
+    @order.total = @order.line_items.sum(&:price)
+    @order.apply_discount(current_user.discount_rate)
+    @order.save!
+    OrderMailer.confirmation(@order).deliver_later
+    redirect_to @order
+  end
+end
+```
+
+## Service Objects
+
+Extract complex business logic into service objects when a model method would be too large or spans multiple models.
+
+```ruby
+# app/services/order_placement_service.rb
+class OrderPlacementService
+  def initialize(user:, params:)
+    @user = user
+    @params = params
+  end
+
+  def call
+    order = Order.new(@params)
+    order.user = @user
+    order.calculate_total
+    order.save!
+    OrderMailer.confirmation(order).deliver_later
+    order
+  end
+end
+```
+
+## Concerns
+
+Use concerns to share behavior across models or controllers. Keep concerns focused on a single responsibility.
+
+```ruby
+# app/models/concerns/searchable.rb
+module Searchable
+  extend ActiveSupport::Concern
+
+  included do
+    scope :search, ->(query) { where("name ILIKE ?", "%#{query}%") }
+  end
+end
+```
+
+## ActiveRecord Patterns
+
+### Scopes over class methods for chainable queries
+
+```ruby
+# Correct — scope
+scope :active, -> { where(active: true) }
+scope :recent, -> { order(created_at: :desc) }
+
+# Wrong — class method for simple query
+def self.active
+  where(active: true)
+end
+```
+
+### Validations
+
+```ruby
+# Use built-in validators
+validates :email, presence: true, uniqueness: true, format: { with: URI::MailTo::EMAIL_REGEXP }
+validates :age, numericality: { greater_than: 0 }
+```
+
+### Callbacks — use sparingly
+
+Prefer explicit service objects over callbacks for complex side effects. Callbacks are acceptable for simple data normalization.
+
+```ruby
+# Acceptable — simple normalization
+before_validation :normalize_email
+
+private
+
+def normalize_email
+  self.email = email&.downcase&.strip
+end
+```
+
+## N+1 Query Prevention
+
+Always use `includes`, `preload`, or `eager_load` to prevent N+1 queries. The Bullet gem is included to detect these in development.
+
+```ruby
+# Correct — eager loading
+@posts = Post.includes(:author, :comments).where(published: true)
+
+# Wrong — N+1 query
+@posts = Post.where(published: true)
+@posts.each { |post| post.author.name } # N+1!
+```
+
+## Strong Parameters
+
+Always use strong parameters in controllers. Never use `permit!`.
+
+```ruby
+# Correct
+def order_params
+  params.require(:order).permit(:product_id, :quantity, :notes)
+end
+
+# Wrong — permits everything
+def order_params
+  params.require(:order).permit!
+end
+```
+
+## Database Migrations
+
+- Use `strong_migrations` gem constraints (included via Gemfile.lisa)
+- Never modify `db/schema.rb` directly
+- Always add indexes for foreign keys and commonly queried columns
+- Use `change` method when the migration is reversible; use `up`/`down` when it is not
+
+```ruby
+class AddIndexToOrdersUserId < ActiveRecord::Migration[7.2]
+  def change
+    add_index :orders, :user_id
+  end
+end
+```
+
+## Testing with RSpec
+
+- Use `let` and `let!` for test setup
+- Use `described_class` instead of repeating the class name
+- Use `factory_bot` for test data, not fixtures
+- Use `shoulda-matchers` for model validation tests
+- Keep tests focused — one assertion concept per example
+
+```ruby
+RSpec.describe Order, type: :model do
+  describe "validations" do
+    it { is_expected.to validate_presence_of(:user) }
+    it { is_expected.to validate_numericality_of(:total).is_greater_than(0) }
+  end
+
+  describe ".recent" do
+    it "returns orders in descending creation order" do
+      old_order = create(:order, created_at: 1.day.ago)
+      new_order = create(:order, created_at: 1.hour.ago)
+
+      expect(described_class.recent).to eq([new_order, old_order])
+    end
+  end
+end
+```

package/plugins/src/typescript/hooks/lint-on-edit.sh

@@ -55,10 +55,12 @@ fi
 # Run ESLint with --fix --quiet --cache on the specific file
 # --quiet: suppress warnings, only show errors
 # --cache: use ESLint cache for performance
+# --rule: disable no-unused-vars auto-fix to prevent removing imports that Claude
+#         plans to use in a subsequent edit (pre-commit hook still catches them)
 echo "Running ESLint --fix on: $FILE_PATH"
 
 # First pass: attempt auto-fix
-OUTPUT=$($PKG_MANAGER eslint --fix --quiet --cache "$FILE_PATH" 2>&1)
+OUTPUT=$($PKG_MANAGER eslint --fix --quiet --cache --rule '@typescript-eslint/no-unused-vars: off' "$FILE_PATH" 2>&1)
 FIX_EXIT=$?
 
 if [ $FIX_EXIT -eq 0 ]; then

package/rails/deletions.json

@@ -8,6 +8,7 @@
     ".claude/skills/plan-fix-linter-error",
     ".claude/skills/plan-lower-code-complexity",
     ".claude/skills/plan-reduce-max-lines",
-    ".claude/skills/plan-reduce-max-lines-per-function"
+    ".claude/skills/plan-reduce-max-lines-per-function",
+    ".claude/rules/rails-conventions.md"
   ]
 }

package/plugins/lisa/hooks/enforce-plan-rules.sh

@@ -1,15 +0,0 @@
-#!/bin/bash
-# Reinjects plan-mode rules on every prompt when Claude is in plan mode.
-# Wired as a UserPromptSubmit hook in .claude/settings.json.
-
-INPUT=$(cat)
-PERMISSION_MODE=$(echo "$INPUT" | jq -r '.permission_mode // "default"')
-
-if [ "$PERMISSION_MODE" = "plan" ]; then
-  PLAN_RULES="$CLAUDE_PROJECT_DIR/.claude/rules/plan.md"
-  if [ -f "$PLAN_RULES" ]; then
-    echo "PLAN MODE RULES (reinforced):"
-    cat "$PLAN_RULES"
-  fi
-fi
-exit 0

package/plugins/lisa/hooks/sync-tasks.sh

@@ -1,107 +0,0 @@
-#!/usr/bin/env bash
-#
-# sync-tasks.sh - Syncs Claude Code tasks to project directories
-#
-# This hook is triggered on PostToolUse for TaskCreate and TaskUpdate.
-# It reads the task metadata to determine the project and syncs
-# task JSON files to ./projects/{project}/tasks/{session-id}/
-#
-# This session-based structure preserves task history across /clear commands,
-# preventing overwrites when new sessions create tasks with the same IDs.
-#
-# Input (via stdin): JSON with tool_name, tool_input, tool_response
-#
-
-# Temporarily disable this hook
-exit 0
-
-set -euo pipefail
-
-# Read JSON input from stdin
-INPUT=$(cat)
-
-# Extract tool name
-TOOL_NAME=$(echo "$INPUT" | jq -r '.tool_name // empty')
-
-# Only process TaskCreate and TaskUpdate
-if [[ "$TOOL_NAME" != "TaskCreate" && "$TOOL_NAME" != "TaskUpdate" ]]; then
-  exit 0
-fi
-
-# Try to get project from multiple sources:
-# 1. Task metadata (passed in tool_input)
-# 2. .claude-active-project marker file
-
-PROJECT=""
-
-# Check tool_input metadata for project
-PROJECT=$(echo "$INPUT" | jq -r '.tool_input.metadata.project // empty')
-
-# If no project in metadata, check marker file
-if [[ -z "$PROJECT" && -f ".claude-active-project" ]]; then
-  PROJECT=$(cat .claude-active-project | tr -d '[:space:]')
-fi
-
-# If still no project, skip syncing
-if [[ -z "$PROJECT" ]]; then
-  exit 0
-fi
-
-# Validate project name (kebab-case, no path traversal)
-if [[ ! "$PROJECT" =~ ^[a-z0-9-]+$ ]]; then
-  echo "Warning: Invalid project name '$PROJECT', skipping sync" >&2
-  exit 0
-fi
-
-# Get task ID
-TASK_ID=""
-if [[ "$TOOL_NAME" == "TaskCreate" ]]; then
-  # For TaskCreate, ID is in tool_response.task.id
-  TASK_ID=$(echo "$INPUT" | jq -r '.tool_response.task.id // empty')
-elif [[ "$TOOL_NAME" == "TaskUpdate" ]]; then
-  # For TaskUpdate, ID is in tool_input
-  TASK_ID=$(echo "$INPUT" | jq -r '.tool_input.taskId // empty')
-fi
-
-if [[ -z "$TASK_ID" ]]; then
-  exit 0
-fi
-
-# Find the task file in ~/.claude/tasks/
-# Tasks are stored in ~/.claude/tasks/{session-uuid}/{id}.json
-CLAUDE_TASKS_DIR="${HOME}/.claude/tasks"
-TASK_FILE=""
-
-# Get session ID from hook input (preferred - 100% accurate)
-SESSION_ID=$(echo "$INPUT" | jq -r '.session_id // empty')
-
-if [[ -n "$SESSION_ID" && -f "${CLAUDE_TASKS_DIR}/${SESSION_ID}/${TASK_ID}.json" ]]; then
-  # Use session ID directly - guaranteed correct session
-  TASK_FILE="${CLAUDE_TASKS_DIR}/${SESSION_ID}/${TASK_ID}.json"
-else
-  # Fallback: find most recently modified task file with this ID
-  # This handles edge cases where session_id isn't available
-  TASK_FILE=$(find "$CLAUDE_TASKS_DIR" -name "${TASK_ID}.json" -exec stat -f '%m %N' {} \; 2>/dev/null | sort -rn | head -1 | cut -d' ' -f2-)
-fi
-
-if [[ -z "$TASK_FILE" || ! -f "$TASK_FILE" ]]; then
-  exit 0
-fi
-
-# Require session ID for proper history tracking
-if [[ -z "$SESSION_ID" ]]; then
-  echo "Warning: No session_id available, skipping sync" >&2
-  exit 0
-fi
-
-# Ensure project tasks directory exists (includes session ID for history preservation)
-PROJECT_TASKS_DIR="./projects/${PROJECT}/tasks/${SESSION_ID}"
-mkdir -p "$PROJECT_TASKS_DIR"
-
-# Copy task file to project directory
-cp "$TASK_FILE" "${PROJECT_TASKS_DIR}/${TASK_ID}.json"
-
-# Optionally stage the file for git (non-blocking)
-git add "${PROJECT_TASKS_DIR}/${TASK_ID}.json" 2>/dev/null || true
-
-exit 0

package/plugins/src/base/hooks/enforce-plan-rules.sh

@@ -1,15 +0,0 @@
-#!/bin/bash
-# Reinjects plan-mode rules on every prompt when Claude is in plan mode.
-# Wired as a UserPromptSubmit hook in .claude/settings.json.
-
-INPUT=$(cat)
-PERMISSION_MODE=$(echo "$INPUT" | jq -r '.permission_mode // "default"')
-
-if [ "$PERMISSION_MODE" = "plan" ]; then
-  PLAN_RULES="$CLAUDE_PROJECT_DIR/.claude/rules/plan.md"
-  if [ -f "$PLAN_RULES" ]; then
-    echo "PLAN MODE RULES (reinforced):"
-    cat "$PLAN_RULES"
-  fi
-fi
-exit 0

package/plugins/src/base/hooks/sync-tasks.sh

@@ -1,107 +0,0 @@
-#!/usr/bin/env bash
-#
-# sync-tasks.sh - Syncs Claude Code tasks to project directories
-#
-# This hook is triggered on PostToolUse for TaskCreate and TaskUpdate.
-# It reads the task metadata to determine the project and syncs
-# task JSON files to ./projects/{project}/tasks/{session-id}/
-#
-# This session-based structure preserves task history across /clear commands,
-# preventing overwrites when new sessions create tasks with the same IDs.
-#
-# Input (via stdin): JSON with tool_name, tool_input, tool_response
-#
-
-# Temporarily disable this hook
-exit 0
-
-set -euo pipefail
-
-# Read JSON input from stdin
-INPUT=$(cat)
-
-# Extract tool name
-TOOL_NAME=$(echo "$INPUT" | jq -r '.tool_name // empty')
-
-# Only process TaskCreate and TaskUpdate
-if [[ "$TOOL_NAME" != "TaskCreate" && "$TOOL_NAME" != "TaskUpdate" ]]; then
-  exit 0
-fi
-
-# Try to get project from multiple sources:
-# 1. Task metadata (passed in tool_input)
-# 2. .claude-active-project marker file
-
-PROJECT=""
-
-# Check tool_input metadata for project
-PROJECT=$(echo "$INPUT" | jq -r '.tool_input.metadata.project // empty')
-
-# If no project in metadata, check marker file
-if [[ -z "$PROJECT" && -f ".claude-active-project" ]]; then
-  PROJECT=$(cat .claude-active-project | tr -d '[:space:]')
-fi
-
-# If still no project, skip syncing
-if [[ -z "$PROJECT" ]]; then
-  exit 0
-fi
-
-# Validate project name (kebab-case, no path traversal)
-if [[ ! "$PROJECT" =~ ^[a-z0-9-]+$ ]]; then
-  echo "Warning: Invalid project name '$PROJECT', skipping sync" >&2
-  exit 0
-fi
-
-# Get task ID
-TASK_ID=""
-if [[ "$TOOL_NAME" == "TaskCreate" ]]; then
-  # For TaskCreate, ID is in tool_response.task.id
-  TASK_ID=$(echo "$INPUT" | jq -r '.tool_response.task.id // empty')
-elif [[ "$TOOL_NAME" == "TaskUpdate" ]]; then
-  # For TaskUpdate, ID is in tool_input
-  TASK_ID=$(echo "$INPUT" | jq -r '.tool_input.taskId // empty')
-fi
-
-if [[ -z "$TASK_ID" ]]; then
-  exit 0
-fi
-
-# Find the task file in ~/.claude/tasks/
-# Tasks are stored in ~/.claude/tasks/{session-uuid}/{id}.json
-CLAUDE_TASKS_DIR="${HOME}/.claude/tasks"
-TASK_FILE=""
-
-# Get session ID from hook input (preferred - 100% accurate)
-SESSION_ID=$(echo "$INPUT" | jq -r '.session_id // empty')
-
-if [[ -n "$SESSION_ID" && -f "${CLAUDE_TASKS_DIR}/${SESSION_ID}/${TASK_ID}.json" ]]; then
-  # Use session ID directly - guaranteed correct session
-  TASK_FILE="${CLAUDE_TASKS_DIR}/${SESSION_ID}/${TASK_ID}.json"
-else
-  # Fallback: find most recently modified task file with this ID
-  # This handles edge cases where session_id isn't available
-  TASK_FILE=$(find "$CLAUDE_TASKS_DIR" -name "${TASK_ID}.json" -exec stat -f '%m %N' {} \; 2>/dev/null | sort -rn | head -1 | cut -d' ' -f2-)
-fi
-
-if [[ -z "$TASK_FILE" || ! -f "$TASK_FILE" ]]; then
-  exit 0
-fi
-
-# Require session ID for proper history tracking
-if [[ -z "$SESSION_ID" ]]; then
-  echo "Warning: No session_id available, skipping sync" >&2
-  exit 0
-fi
-
-# Ensure project tasks directory exists (includes session ID for history preservation)
-PROJECT_TASKS_DIR="./projects/${PROJECT}/tasks/${SESSION_ID}"
-mkdir -p "$PROJECT_TASKS_DIR"
-
-# Copy task file to project directory
-cp "$TASK_FILE" "${PROJECT_TASKS_DIR}/${TASK_ID}.json"
-
-# Optionally stage the file for git (non-blocking)
-git add "${PROJECT_TASKS_DIR}/${TASK_ID}.json" 2>/dev/null || true
-
-exit 0