@codyswann/lisa 1.48.0 → 1.49.0

package/plugins/lisa-expo/skills/plan-reduce-max-lines/SKILL.md

@@ -0,0 +1,45 @@
+---
+name: plan-reduce-max-lines
+description: This skill should be used when reducing the maximum file lines threshold and fixing all violations. It updates the eslint threshold configuration, identifies files exceeding the new limit, generates a brief with refactoring strategies, and creates a plan with tasks to split oversized files.
+allowed-tools: ["Read", "Bash", "Glob", "Grep"]
+
+---
+
+# Reduce Max Lines
+
+Target threshold: $ARGUMENTS lines per file
+
+If no argument provided, prompt the user for a target.
+
+## Step 1: Gather Requirements
+
+1. **Read current config** from eslint thresholds (eslint.thresholds.json or similar)
+2. **Run lint** with the new threshold to find violations:
+   ```bash
+   bun run lint 2>&1 | grep "max-lines"
+   ```
+3. **Note for each violation**:
+   - File path
+   - Current line count
+
+If no violations at $ARGUMENTS, report success and exit.
+
+## Step 2: Compile Brief and Delegate
+
+Compile the gathered information into a structured brief:
+
+```
+Reduce max file lines threshold to $ARGUMENTS.
+
+Files exceeding threshold (ordered by line count):
+1. [file] - [current] lines (target: $ARGUMENTS)
+2. ...
+
+Configuration change: eslint.thresholds.json, maxLines to $ARGUMENTS
+
+Refactoring strategies: extract modules, remove duplication, delete dead code, simplify logic
+
+Verification: `bun run lint 2>&1 | grep "max-lines" | wc -l` → Expected: 0
+```
+
+Invoke `/plan-execute` with this brief to create the implementation plan.

package/plugins/lisa-expo/skills/plan-reduce-max-lines-per-function/SKILL.md

@@ -0,0 +1,46 @@
+---
+name: plan-reduce-max-lines-per-function
+description: This skill should be used when reducing the maximum lines per function threshold and fixing all violations. It updates the eslint threshold configuration, identifies functions exceeding the new limit, generates a brief with refactoring strategies, and creates a plan with tasks to split oversized functions.
+allowed-tools: ["Read", "Bash", "Glob", "Grep"]
+
+---
+
+# Reduce Max Lines Per Function
+
+Target threshold: $ARGUMENTS lines per function
+
+If no argument provided, prompt the user for a target.
+
+## Step 1: Gather Requirements
+
+1. **Read current config** from eslint thresholds (eslint.thresholds.json or similar)
+2. **Run lint** with the new threshold to find violations:
+   ```bash
+   bun run lint 2>&1 | grep "max-lines-per-function"
+   ```
+3. **Note for each violation**:
+   - File path and line number
+   - Function name
+   - Current line count
+
+If no violations at $ARGUMENTS, report success and exit.
+
+## Step 2: Compile Brief and Delegate
+
+Compile the gathered information into a structured brief:
+
+```
+Reduce max lines per function threshold to $ARGUMENTS.
+
+Functions exceeding threshold (ordered by line count):
+1. [file:function] (lines: X, target: $ARGUMENTS) - Line Y
+2. ...
+
+Configuration change: eslint.thresholds.json, maxLinesPerFunction to $ARGUMENTS
+
+Refactoring strategies: extract functions, early returns, extract conditions, use lookup tables, consolidate logic
+
+Verification: `bun run lint 2>&1 | grep "max-lines-per-function" | wc -l` → Expected: 0
+```
+
+Invoke `/plan-execute` with this brief to create the implementation plan.

package/plugins/lisa-expo/skills/playwright-selectors/SKILL.md

@@ -0,0 +1,223 @@
+---
+name: playwright-selectors
+description: Best practices for adding testID and aria-label selectors for Playwright E2E testing in Expo web applications. This skill should be used when adding E2E test coverage, creating new components that need test selectors, or reviewing code for testability.
+---
+
+# Playwright Selectors Best Practices
+
+## Overview
+
+This skill provides guidance for adding effective selectors (testID, aria-labels) to Expo/React Native components for Playwright E2E testing. Proper selector strategy ensures tests are reliable, maintainable, and accessible.
+
+## Selector Priority
+
+Choose selectors based on their reliability and accessibility impact, in this priority order:
+
+| Priority | Selector Method | When to Use                               |
+| -------- | --------------- | ----------------------------------------- |
+| 1        | `getByRole`     | Interactive elements with semantic roles  |
+| 2        | `getByText`     | Visible text content                      |
+| 3        | `getByLabel`    | Form elements with labels                 |
+| 4        | `getByTestId`   | Fallback for elements without semantics   |
+
+### getByRole (Preferred)
+
+Use semantic roles when possible - they improve both accessibility and test resilience.
+
+```typescript
+// E2E test - preferred selector
+const submitButton = page.getByRole("button", { name: "Submit" });
+await expect(submitButton).toBeVisible();
+```
+
+### getByTestId (Fallback)
+
+Use testID when semantic selectors are not available, particularly for structural containers.
+
+```typescript
+// E2E test - fallback selector
+const container = page.getByTestId("home:container");
+await expect(container).toBeVisible();
+```
+
+## testID Naming Convention
+
+Use a namespaced pattern with colons as separators: `screen:element`
+
+### Format
+
+```
+{screen}:{element}
+```
+
+- **screen**: lowercase screen/feature name (e.g., `home`, `profile`, `settings`)
+- **element**: lowercase element identifier (e.g., `container`, `title`, `submit-button`)
+
+### Examples
+
+| testID                     | Description                      |
+| -------------------------- | -------------------------------- |
+| `home:container`           | Main container on home screen    |
+| `home:title`               | Title text on home screen        |
+| `profile:avatar`           | User avatar on profile screen    |
+| `settings:dark-mode-toggle`| Dark mode toggle in settings     |
+| `auth:login-button`        | Login button on auth screen      |
+
+### Rules
+
+1. Use lowercase only
+2. Use colons (`:`) to separate screen from element
+3. Use hyphens (`-`) for multi-word elements
+4. Be descriptive but concise
+5. Avoid redundant words (e.g., `home:home-title` should be `home:title`)
+
+## React Native to HTML Mapping
+
+Understanding how testID propagates from React Native to the web is essential.
+
+### How It Works
+
+1. React Native's `testID` prop is for native testing (XCUITest, Espresso)
+2. On web (via react-native-web), `testID` renders as `data-testid` in HTML
+3. Playwright's `getByTestId()` queries `data-testid` by default
+
+```typescript
+// React Native component
+<Box testID="home:container">...</Box>
+
+// Rendered HTML on web
+<div data-testid="home:container">...</div>
+
+// Playwright locator
+page.getByTestId("home:container")
+```
+
+### Gluestack UI Components
+
+Gluestack UI web components (Box, Text, etc.) require explicit testID handling because they use native HTML elements instead of react-native-web components. The web versions have been updated to:
+
+1. Accept a `testID` prop in the TypeScript type
+2. Map `testID` to `data-testid` on the rendered HTML element
+
+```typescript
+// Gluestack Box web implementation
+const Box = ({ testID, ...props }) => (
+  <div data-testid={testID} {...props} />
+);
+```
+
+## When to Add testID
+
+### Add testID To
+
+1. **Interactive elements** that E2E tests will click/interact with
+2. **Key structural containers** for page load verification
+3. **Dynamic content areas** that change based on state
+4. **Form elements** that lack semantic labels
+
+### Do Not Add testID To
+
+1. Every element (over-testing creates maintenance burden)
+2. Elements with good semantic selectors (use getByRole instead)
+3. Decorative elements not needed for testing
+4. Elements inside third-party components (may not propagate)
+
+## Accessibility Best Practices
+
+Prefer semantic selectors and aria-labels over testID when possible.
+
+### aria-label for Testing and Accessibility
+
+When adding labels for testing, use `aria-label` or `accessibilityLabel` to benefit screen reader users too.
+
+```typescript
+// Correct - benefits both testing and accessibility
+<Pressable
+  accessibilityLabel="Close dialog"
+  onPress={handleClose}
+>
+  <XIcon />
+</Pressable>
+
+// E2E test uses accessible name
+await page.getByRole("button", { name: "Close dialog" }).click();
+```
+
+### accessibilityRole for Semantic Elements
+
+Use `accessibilityRole` to provide semantic meaning on web.
+
+```typescript
+// Correct - semantic role for assistive technology
+<Box accessibilityRole="banner" testID="header:container">
+  <Text accessibilityRole="heading">Welcome</Text>
+</Box>
+
+// E2E test can use role
+await expect(page.getByRole("banner")).toBeVisible();
+await expect(page.getByRole("heading", { name: "Welcome" })).toBeVisible();
+```
+
+## Implementation Checklist
+
+When adding E2E test coverage to a component:
+
+- [ ] Identify elements that need selectors for testing
+- [ ] Prefer semantic selectors (role, text, label) when available
+- [ ] Use namespaced testID pattern for elements without semantics
+- [ ] Verify testID propagates to `data-testid` on web (check Gluestack components)
+- [ ] Add accessibility labels where beneficial
+- [ ] Document testIDs in component JSDoc preamble
+
+## Example Component
+
+```typescript
+/**
+ * Profile screen component.
+ *
+ * Test IDs for E2E testing:
+ * - `profile:container` - Main container
+ * - `profile:avatar` - User avatar image
+ * - `profile:name` - User display name
+ *
+ * @module features/profile/screens/Main
+ */
+export const ProfileScreen = () => (
+  <Box testID="profile:container" className="flex-1 p-4">
+    <Image
+      testID="profile:avatar"
+      source={{ uri: user.avatarUrl }}
+      accessibilityLabel={`${user.name}'s profile photo`}
+    />
+    <Text testID="profile:name" accessibilityRole="heading">
+      {user.name}
+    </Text>
+    <Pressable
+      accessibilityLabel="Edit profile"
+      onPress={handleEdit}
+    >
+      <Text>Edit</Text>
+    </Pressable>
+  </Box>
+);
+```
+
+## Corresponding E2E Test
+
+```typescript
+test.describe("Profile Screen", () => {
+  test("displays user information", async ({ page }) => {
+    await page.goto("/profile");
+
+    // Verify structural container
+    await expect(page.getByTestId("profile:container")).toBeVisible();
+
+    // Prefer accessible queries when available
+    await expect(page.getByRole("heading")).toHaveText("John Doe");
+    await expect(page.getByRole("button", { name: "Edit profile" })).toBeVisible();
+
+    // Use testID for elements without semantic roles
+    await expect(page.getByTestId("profile:avatar")).toBeVisible();
+  });
+});
+```

package/plugins/lisa-expo/skills/pull-request-review/SKILL.md

@@ -0,0 +1,68 @@
+---
+name: pull-request-review
+description: This skill should be used when checking for code review comments on a pull request and implementing them if required. It fetches PR metadata and comments, generates a brief from unresolved feedback, and bootstraps a project to address the review comments.
+allowed-tools: ["Read", "Bash", "Glob", "Grep"]
+---
+
+# Review PR Comments
+
+Target PR: $ARGUMENTS
+
+If no argument provided, prompt the user for a PR link or number.
+
+## Step 1: Gather Requirements
+
+1. **Fetch PR metadata and comments** using the GitHub CLI:
+   ```bash
+   gh pr view $ARGUMENTS --json number,title,body,reviews,comments
+   gh api repos/{owner}/{repo}/pulls/{pr_number}/comments
+   ```
+2. **Extract each unresolved review comment**:
+   - Comment ID
+   - File path
+   - Line number
+   - Comment body
+   - Author
+
+If no unresolved comments exist, report success and exit.
+
+## Step 2: Create Plan
+
+In plan mode, create a plan that includes the following details:
+
+```markdown
+Implement PR review feedback for $ARGUMENTS.
+
+## PR Overview
+- Title: [PR title]
+- Description: [PR description summary]
+
+## Review Comments to Address (ordered by file)
+
+### 1. [file_path]:[line_number] (Comment ID: [id])
+**Reviewer**: [author]
+**Comment**: [full comment body]
+**Action Required**: [brief description of what needs to change]
+
+### 2. [file_path]:[line_number] (Comment ID: [id])
+**Reviewer**: [author]
+**Comment**: [full comment body]
+**Action Required**: [brief description of what needs to change]
+
+...
+
+## Implementation Guidelines
+- Evaluate each comment for validity before implementing
+- If a comment is not valid, document the reasoning
+- Ensure changes follow project coding standards
+- Run relevant tests to verify changes work
+
+## Acceptance Criteria
+- All valid review comments addressed
+- Tests pass after changes
+- `bun run lint` passes
+
+## Verification
+Command: `bun run lint && bun run test`
+Expected: All checks pass
+```

package/plugins/lisa-expo/skills/security-zap-scan/SKILL.md

@@ -0,0 +1,33 @@
+---
+name: security-zap-scan
+description: "Run an OWASP ZAP baseline security scan locally using Docker. Checks for the ZAP baseline script, executes the scan, and summarizes findings by risk level with remediation recommendations."
+allowed-tools: ["Bash", "Read"]
+---
+
+# OWASP ZAP Baseline Security Scan
+
+Run a ZAP baseline security scan against the local application.
+
+## Workflow
+
+1. **Check prerequisites**:
+   - Verify Docker is installed and running: `docker info`
+   - Check if `scripts/zap-baseline.sh` exists in the project
+
+2. **Execute scan**:
+   - If the script exists, run: `bash scripts/zap-baseline.sh`
+   - If the script does not exist, inform the user that this project does not have a ZAP baseline scan configured
+
+3. **Analyze results**:
+   - After the scan completes, read `zap-report.html` (or `zap-report.md` for text)
+   - Summarize findings:
+     - Total number of alerts by risk level (High, Medium, Low, Informational)
+     - List each Medium+ finding with its rule ID, name, and recommended fix
+     - Categorize findings as "infrastructure-level" (fix at CDN/proxy) vs "application-level" (fix in code)
+
+4. **Handle failures**:
+   - If the scan failed, explain what failed and suggest concrete remediation steps
+
+## Execution
+
+Run the scan now.

package/plugins/lisa-expo/skills/skill-creator/LICENSE.txt

@@ -0,0 +1,202 @@
+
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity authorized by
+      the copyright owner that is granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" form shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" form shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based on (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to reproduce, prepare Derivative Works of,
+      publicly display, publicly perform, sublicense, and distribute the
+      Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for reasonable and customary use in describing the
+      origin of the Work and reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Additional Liability. While redistributing
+      the Work or Derivative Works thereof, You may choose to offer,
+      and charge a fee for, acceptance of support, warranty, indemnity,
+      or other liability obligations and/or rights consistent with this
+      License. However, in accepting such obligations, You may act only
+      on Your own behalf and on Your sole responsibility, not on behalf
+      of any other Contributor, and only if You agree to indemnify,
+      defend, and hold each Contributor harmless for any liability
+      incurred by, or claims asserted against, such Contributor by reason
+      of your accepting any such warranty or additional liability.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright [yyyy] [name of copyright owner]
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.