@codyswann/lisa 1.38.0 → 1.39.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/all/copy-overwrite/.claude/README.md +11 -5
- package/all/copy-overwrite/.claude/agents/agent-architect.md +0 -1
- package/all/copy-overwrite/.claude/agents/{architecture-planner.md → architecture-specialist.md} +7 -12
- package/all/copy-overwrite/.claude/agents/debug-specialist.md +204 -0
- package/all/copy-overwrite/.claude/agents/implementer.md +35 -23
- package/all/copy-overwrite/.claude/agents/learner.md +0 -1
- package/all/copy-overwrite/.claude/agents/performance-specialist.md +95 -0
- package/all/copy-overwrite/.claude/agents/{product-planner.md → product-specialist.md} +19 -14
- package/all/copy-overwrite/.claude/agents/{tech-reviewer.md → quality-specialist.md} +9 -11
- package/all/copy-overwrite/.claude/agents/{security-planner.md → security-specialist.md} +8 -13
- package/all/copy-overwrite/.claude/agents/{test-strategist.md → test-specialist.md} +20 -15
- package/all/copy-overwrite/.claude/agents/verification-specialist.md +189 -0
- package/all/copy-overwrite/.claude/commands/plan/create.md +1 -1
- package/all/copy-overwrite/.claude/commands/plan/execute.md +7 -0
- package/all/copy-overwrite/.claude/hooks/README.md +2 -2
- package/all/copy-overwrite/.claude/hooks/setup-jira-cli.sh +2 -2
- package/all/copy-overwrite/.claude/hooks/sync-tasks.sh +3 -0
- package/all/copy-overwrite/.claude/hooks/ticket-sync-reminder.sh +3 -0
- package/all/copy-overwrite/.claude/hooks/track-plan-sessions.sh +3 -0
- package/all/copy-overwrite/.claude/rules/lisa.md +2 -4
- package/all/copy-overwrite/.claude/rules/verfication.md +104 -1
- package/all/copy-overwrite/.claude/settings.json +219 -26
- package/all/copy-overwrite/.claude/skills/agent-design-best-practices/SKILL.md +219 -0
- package/all/copy-overwrite/.claude/skills/plan-add-test-coverage/SKILL.md +1 -1
- package/all/copy-overwrite/.claude/skills/plan-execute/SKILL.md +89 -0
- package/all/copy-overwrite/.claude/skills/plan-fix-linter-error/SKILL.md +1 -1
- package/all/copy-overwrite/.claude/skills/plan-lower-code-complexity/SKILL.md +1 -1
- package/all/copy-overwrite/.claude/skills/plan-reduce-max-lines/SKILL.md +1 -1
- package/all/copy-overwrite/.claude/skills/plan-reduce-max-lines-per-function/SKILL.md +1 -1
- package/all/copy-overwrite/README.md +6 -2
- package/dist/utils/fibonacci.d.ts +30 -22
- package/dist/utils/fibonacci.d.ts.map +1 -1
- package/dist/utils/fibonacci.js +40 -34
- package/dist/utils/fibonacci.js.map +1 -1
- package/package.json +1 -1
- package/rails/copy-overwrite/.claude/skills/plan-add-test-coverage/SKILL.md +1 -1
- package/rails/copy-overwrite/.claude/skills/plan-fix-linter-error/SKILL.md +1 -1
- package/rails/copy-overwrite/.claude/skills/plan-lower-code-complexity/SKILL.md +1 -1
- package/rails/copy-overwrite/.claude/skills/plan-reduce-max-lines/SKILL.md +1 -1
- package/rails/copy-overwrite/.claude/skills/plan-reduce-max-lines-per-function/SKILL.md +1 -1
- package/typescript/copy-contents/.husky/pre-push +1 -5
- package/typescript/copy-overwrite/.claude/settings.json +112 -78
- package/typescript/copy-overwrite/.github/workflows/quality.yml +1 -5
- package/all/copy-overwrite/.claude/REFERENCE.md +0 -519
- package/all/copy-overwrite/.claude/agents/codebase-analyzer.md +0 -146
- package/all/copy-overwrite/.claude/agents/codebase-locator.md +0 -125
- package/all/copy-overwrite/.claude/agents/codebase-pattern-finder.md +0 -237
- package/all/copy-overwrite/.claude/agents/consistency-checker.md +0 -58
- package/all/copy-overwrite/.claude/agents/product-reviewer.md +0 -47
- package/all/copy-overwrite/.claude/agents/spec-analyst.md +0 -41
- package/all/copy-overwrite/.claude/agents/test-coverage-agent.md +0 -17
- package/all/copy-overwrite/.claude/commands/plan/implement.md +0 -6
- package/all/copy-overwrite/.claude/rules/plan-governance.md +0 -96
- package/all/copy-overwrite/.claude/rules/plan.md +0 -79
- package/all/copy-overwrite/.claude/skills/plan-create/SKILL.md +0 -238
- package/all/copy-overwrite/.claude/skills/plan-implement/SKILL.md +0 -114
- /package/typescript/copy-overwrite/.claude/hooks/{install_pkgs.sh → install-pkgs.sh} +0 -0
|
@@ -1,79 +0,0 @@
|
|
|
1
|
-
# Plan Document Format
|
|
2
|
-
|
|
3
|
-
For governance rules (required tasks, branch/PR rules, git workflow), see `plan-governance.md`.
|
|
4
|
-
|
|
5
|
-
## Task Creation Specification
|
|
6
|
-
|
|
7
|
-
### Parameters
|
|
8
|
-
|
|
9
|
-
- **subject**: Imperative form (e.g., "Add logout button to header")
|
|
10
|
-
- **activeForm**: Present continuous form (e.g., "Adding logout button to header")
|
|
11
|
-
|
|
12
|
-
### Description Template
|
|
13
|
-
|
|
14
|
-
Every task description must be a markdown document with these sections:
|
|
15
|
-
|
|
16
|
-
**Type:** Bug | Task | Epic | Story
|
|
17
|
-
|
|
18
|
-
**Description:** Clear description based on type:
|
|
19
|
-
- Bug: symptoms and root cause
|
|
20
|
-
- Story: Gherkin Given/When/Then
|
|
21
|
-
- Task: clear goal
|
|
22
|
-
- Epic: goal with sub-tasks
|
|
23
|
-
|
|
24
|
-
### Type-Specific Requirements
|
|
25
|
-
|
|
26
|
-
#### Bug
|
|
27
|
-
- **Replication step** (mandatory): Reproduce the bug empirically before any fix
|
|
28
|
-
- **Root cause analysis**: Identify why the bug occurs
|
|
29
|
-
- **Regression test**: Write a test that fails without the fix and passes with it
|
|
30
|
-
- **Verification**: Run the replication step again to confirm the fix
|
|
31
|
-
|
|
32
|
-
#### Story/Feature
|
|
33
|
-
- **UX review**: Product-reviewer agent validates from user perspective
|
|
34
|
-
- **Feature flag consideration**: Should this be behind a flag?
|
|
35
|
-
- **Documentation**: User-facing docs if applicable
|
|
36
|
-
|
|
37
|
-
#### Task
|
|
38
|
-
- **Standard implementation** with empirical verification
|
|
39
|
-
|
|
40
|
-
#### Epic
|
|
41
|
-
- **Decompose into sub-tasks** (Stories/Tasks/Bugs)
|
|
42
|
-
- **Each sub-task gets its own type-specific requirements**
|
|
43
|
-
|
|
44
|
-
### Additional Description Sections
|
|
45
|
-
|
|
46
|
-
**Acceptance Criteria:** Checkbox list of completion criteria
|
|
47
|
-
|
|
48
|
-
**Relevant Research:** Code references, patterns, architecture constraints
|
|
49
|
-
|
|
50
|
-
**Skills to Invoke:** List applicable skills (coding-philosophy is auto-loaded as a rule)
|
|
51
|
-
|
|
52
|
-
**Implementation Details:** Files to modify, functions to implement, edge cases
|
|
53
|
-
|
|
54
|
-
**Testing Requirements:** Unit tests (with `describe/it` structure), integration tests, E2E tests (or "N/A")
|
|
55
|
-
|
|
56
|
-
**Verification:** Every task MUST have empirical verification (see `verfication.md` for types). Include: verification type, proof command, and expected output.
|
|
57
|
-
|
|
58
|
-
**Learnings:** On completion, use `TaskUpdate` to save discoveries: `metadata: { learnings: ["Learning 1", ...] }`
|
|
59
|
-
|
|
60
|
-
### Metadata
|
|
61
|
-
|
|
62
|
-
Every task MUST include this JSON metadata block. Do NOT omit `skills` (use `[]` if none) or `verification`.
|
|
63
|
-
|
|
64
|
-
```json
|
|
65
|
-
{
|
|
66
|
-
"plan": "<plan-name>",
|
|
67
|
-
"type": "bug|task|epic|story",
|
|
68
|
-
"skills": ["..."],
|
|
69
|
-
"verification": {
|
|
70
|
-
"type": "test|ui-recording|test-coverage|api-test|manual-check|documentation",
|
|
71
|
-
"command": "the proof command",
|
|
72
|
-
"expected": "what success looks like"
|
|
73
|
-
}
|
|
74
|
-
}
|
|
75
|
-
```
|
|
76
|
-
|
|
77
|
-
### Task Sizing
|
|
78
|
-
|
|
79
|
-
Each task must be small enough to have a **single, specific verification**. Ask: "Can I prove this is done with ONE command?" Split tasks that require multiple verifications.
|
|
@@ -1,238 +0,0 @@
|
|
|
1
|
-
---
|
|
2
|
-
name: plan-create
|
|
3
|
-
description: "Creates an implementation plan from a ticket URL, file path, or text description. Spawns an Agent Team for parallel research, review, and synthesis. Detects plan type (Bug/Task/Story/Epic) and applies type-specific requirements."
|
|
4
|
-
---
|
|
5
|
-
|
|
6
|
-
# Create Implementation Plan
|
|
7
|
-
|
|
8
|
-
Create an implementation plan for: $ARGUMENTS
|
|
9
|
-
|
|
10
|
-
All plans must follow the rules in @.claude/rules/plan-governance.md (required tasks, branch/PR rules, git workflow) and @.claude/rules/plan.md (task creation specification, metadata schema).
|
|
11
|
-
|
|
12
|
-
## Step 1: Parse Input
|
|
13
|
-
|
|
14
|
-
Determine the input type from `$ARGUMENTS`:
|
|
15
|
-
|
|
16
|
-
1. **Ticket URL/ID** -- Fetch ticket details with the appropriate CLI or MCP Server. Extract: title, description, acceptance criteria, priority, epic/parent. Note the ticket URL for later integration updates.
|
|
17
|
-
2. **File path** -- Read the file contents and use as context for the plan.
|
|
18
|
-
3. **Free text** -- Treat the entire argument as a text description of the work.
|
|
19
|
-
|
|
20
|
-
If no argument provided, prompt the user for input.
|
|
21
|
-
|
|
22
|
-
## Step 2: Detect Plan Type
|
|
23
|
-
|
|
24
|
-
| Type | Indicators |
|
|
25
|
-
|------|------------|
|
|
26
|
-
| **Bug** | Symptoms, errors, incorrect behavior, "broken", "fails", "crash", "regression" |
|
|
27
|
-
| **Story/Feature** | New capability, user-facing change, "add", "implement", "create", "as a user" |
|
|
28
|
-
| **Task** | Internal work, refactoring, configuration, maintenance, "update", "migrate", "refactor" |
|
|
29
|
-
| **Epic** | Large scope with multiple features/stories, "overhaul", "redesign", multiple deliverables |
|
|
30
|
-
|
|
31
|
-
If ambiguous, default to **Task**.
|
|
32
|
-
|
|
33
|
-
## Step 3: Assess Complexity
|
|
34
|
-
|
|
35
|
-
Evaluate the scope of work:
|
|
36
|
-
|
|
37
|
-
- **Trivial** (single file, config change, documentation update) → Skip to Step 8 (direct synthesis). No agent team needed.
|
|
38
|
-
- **Standard** (2-10 files, single feature or fix) → Proceed through all phases.
|
|
39
|
-
- **Epic** (10+ files, multiple features, cross-cutting changes) → Proceed through all phases with extra attention to dependency mapping.
|
|
40
|
-
|
|
41
|
-
## Step 4: Phase 1 - Research (parallel)
|
|
42
|
-
|
|
43
|
-
Create an Agent Team and spawn three research teammates simultaneously. **All agents spawned in Steps 4–7 must include the `team_name` parameter from the TeamCreate call.**
|
|
44
|
-
|
|
45
|
-
#### Researcher
|
|
46
|
-
- **Name**: `researcher`
|
|
47
|
-
- **Agent type**: `general-purpose`
|
|
48
|
-
- **Mode**: `bypassPermissions`
|
|
49
|
-
- **Team**: use the `team_name` from TeamCreate
|
|
50
|
-
- **Prompt**: Research the input (ticket, file, or description). If a ticket URL, fetch full details via JIRA MCP or GitHub CLI. If a bug, attempt to reproduce it empirically (Playwright, browser, direct API call, etc.). Extract requirements, acceptance criteria, and context.
|
|
51
|
-
|
|
52
|
-
#### Codebase Explorer
|
|
53
|
-
- **Name**: `explorer`
|
|
54
|
-
- **Agent type**: `Explore`
|
|
55
|
-
- **Team**: use the `team_name` from TeamCreate
|
|
56
|
-
- **Prompt**: Explore the codebase for relevant code, existing patterns, and reusable scripts. Read lint and format rules to understand project standards. Identify files that would need modification, existing utilities that can be reused, and architecture constraints. Check for existing scripts in `package.json` that could be used for replication or verification.
|
|
57
|
-
|
|
58
|
-
#### Spec Gap Analyst
|
|
59
|
-
- **Name**: `spec-analyst`
|
|
60
|
-
- **Agent type**: `spec-analyst`
|
|
61
|
-
- **Mode**: `bypassPermissions`
|
|
62
|
-
- **Team**: use the `team_name` from TeamCreate
|
|
63
|
-
- **Prompt**: Analyze the input for specification gaps. Read `package.json` and existing code for project context. Identify every ambiguity or unstated assumption that could lead to wrong architectural decisions. Report as a numbered list of clarifying questions, sorted by impact.
|
|
64
|
-
|
|
65
|
-
Wait for all three to report back via SendMessage.
|
|
66
|
-
|
|
67
|
-
## Step 5: Phase 1.5 - Research Brief & Gap Resolution (team lead)
|
|
68
|
-
|
|
69
|
-
Synthesize Phase 1 findings into a structured **Research Brief**:
|
|
70
|
-
|
|
71
|
-
- **Ticket/spec details**: requirements, acceptance criteria, constraints
|
|
72
|
-
- **Reproduction results**: (for bugs) steps attempted, outcome observed
|
|
73
|
-
- **Relevant files**: paths, line ranges, what they do
|
|
74
|
-
- **Existing patterns**: conventions found in the codebase
|
|
75
|
-
- **Architecture constraints**: dependencies, limitations, integration points
|
|
76
|
-
- **Reusable utilities**: existing code that applies to this work
|
|
77
|
-
|
|
78
|
-
### Gap Resolution
|
|
79
|
-
|
|
80
|
-
After synthesizing the Research Brief:
|
|
81
|
-
|
|
82
|
-
1. Collect gaps from the spec-analyst's findings
|
|
83
|
-
2. Present gaps to the user via AskUserQuestion -- group related questions and include why each matters
|
|
84
|
-
3. If no gaps identified, state "No specification gaps identified" and proceed to Phase 2
|
|
85
|
-
4. Incorporate answers into the Research Brief before Phase 2
|
|
86
|
-
|
|
87
|
-
## Step 6: Phase 2 - Domain Sub-Plans (parallel)
|
|
88
|
-
|
|
89
|
-
Spawn four domain planners simultaneously, passing each the Research Brief:
|
|
90
|
-
|
|
91
|
-
#### Architecture Planner
|
|
92
|
-
- **Name**: `arch-planner`
|
|
93
|
-
- **Agent type**: `architecture-planner`
|
|
94
|
-
- **Mode**: `bypassPermissions`
|
|
95
|
-
- **Team**: use the `team_name` from TeamCreate
|
|
96
|
-
- **Prompt**: [Research Brief] + Design the technical implementation approach. Identify files to create/modify, map dependencies, recommend patterns, flag risks.
|
|
97
|
-
|
|
98
|
-
#### Test Strategist
|
|
99
|
-
- **Name**: `test-strategist`
|
|
100
|
-
- **Agent type**: `test-strategist`
|
|
101
|
-
- **Mode**: `bypassPermissions`
|
|
102
|
-
- **Team**: use the `team_name` from TeamCreate
|
|
103
|
-
- **Prompt**: [Research Brief] + Design the test matrix. Identify edge cases, set coverage targets, define verification commands, plan TDD sequence.
|
|
104
|
-
|
|
105
|
-
#### Security Planner
|
|
106
|
-
- **Name**: `security-planner`
|
|
107
|
-
- **Agent type**: `security-planner`
|
|
108
|
-
- **Mode**: `bypassPermissions`
|
|
109
|
-
- **Team**: use the `team_name` from TeamCreate
|
|
110
|
-
- **Prompt**: [Research Brief] + Perform lightweight threat modeling (STRIDE). Identify auth/validation gaps, secrets exposure risks, and security measures needed.
|
|
111
|
-
|
|
112
|
-
#### Product Planner
|
|
113
|
-
- **Name**: `product-planner`
|
|
114
|
-
- **Agent type**: `product-planner`
|
|
115
|
-
- **Mode**: `bypassPermissions`
|
|
116
|
-
- **Team**: use the `team_name` from TeamCreate
|
|
117
|
-
- **Prompt**: [Research Brief] + Define user flows in Gherkin. Write acceptance criteria from user perspective. Identify UX concerns and error states.
|
|
118
|
-
|
|
119
|
-
Wait for all four to report back via SendMessage.
|
|
120
|
-
|
|
121
|
-
## Step 7: Phase 3 - Review (parallel)
|
|
122
|
-
|
|
123
|
-
Spawn two reviewers simultaneously, passing them all sub-plans:
|
|
124
|
-
|
|
125
|
-
#### Devil's Advocate
|
|
126
|
-
- **Name**: `devils-advocate`
|
|
127
|
-
- **Agent type**: `general-purpose`
|
|
128
|
-
- **Mode**: `bypassPermissions`
|
|
129
|
-
- **Team**: use the `team_name` from TeamCreate
|
|
130
|
-
- **Prompt**: [All sub-plans] + Review critically. Identify anti-patterns, N+1 queries, missing edge cases, security concerns, and performance issues. Do not assume anti-patterns are acceptable just because they exist in the codebase — undocumented anti-patterns should be flagged, not used as reference. Challenge assumptions and propose alternatives for weak points.
|
|
131
|
-
|
|
132
|
-
#### Consistency Checker
|
|
133
|
-
- **Name**: `consistency-checker`
|
|
134
|
-
- **Agent type**: `consistency-checker`
|
|
135
|
-
- **Mode**: `bypassPermissions`
|
|
136
|
-
- **Team**: use the `team_name` from TeamCreate
|
|
137
|
-
- **Prompt**: [All sub-plans] + Verify cross-plan consistency. Check that file lists align, test strategy covers architecture changes, security measures are reflected in acceptance criteria, and no sub-plans contradict each other.
|
|
138
|
-
|
|
139
|
-
Wait for both to report back via SendMessage.
|
|
140
|
-
|
|
141
|
-
## Step 8: Phase 4 - Synthesis (team lead)
|
|
142
|
-
|
|
143
|
-
Read governance and format rules, then merge everything into a unified plan:
|
|
144
|
-
|
|
145
|
-
1. Read `@.claude/rules/plan-governance.md` for governance rules
|
|
146
|
-
2. Read `@.claude/rules/plan.md` for task document format
|
|
147
|
-
3. Merge sub-plans + review feedback into a unified plan
|
|
148
|
-
4. Apply governance: Required Tasks, Branch/PR rules, Git Workflow
|
|
149
|
-
5. Create TaskCreate specs per plan.md format
|
|
150
|
-
6. Write plan to `plans/<name>.md`
|
|
151
|
-
7. Create branch, open draft PR
|
|
152
|
-
8. Update ticket if applicable
|
|
153
|
-
|
|
154
|
-
Apply the Type-Specific Requirements from @.claude/rules/plan.md based on the detected plan type. For Bugs, also include a replication task before any fix and a proof command for every fix task. For Epics, include dependency mapping between sub-tasks.
|
|
155
|
-
|
|
156
|
-
The plan file must include:
|
|
157
|
-
|
|
158
|
-
1. **Title and context** — What is being done and why
|
|
159
|
-
2. **Input source** — Ticket URL, file path, or description
|
|
160
|
-
3. **Plan type** — Bug, Task, Story/Feature, or Epic
|
|
161
|
-
4. **Branch and PR** — Following branch/PR rules from plan-governance.md
|
|
162
|
-
5. **Analysis** — Synthesized research findings from all teammates
|
|
163
|
-
6. **Implementation approach** — How the work will be done
|
|
164
|
-
7. **Tasks** — Following the Task Creation Specification from plan.md
|
|
165
|
-
8. **Implementation Team** — Instructions to spawn an Agent Team (see Step 10)
|
|
166
|
-
|
|
167
|
-
### Type-Specific Requirements
|
|
168
|
-
|
|
169
|
-
Apply these additional requirements based on the detected type:
|
|
170
|
-
|
|
171
|
-
#### Bug
|
|
172
|
-
- **Replication step** (mandatory): Include a task to reproduce the bug empirically before any fix
|
|
173
|
-
- **Root cause analysis**: Identify why the bug occurs, not just what triggers it
|
|
174
|
-
- **Regression test**: Write a test that fails without the fix and passes with it
|
|
175
|
-
- **Verification**: Run the replication step again after the fix to confirm resolution
|
|
176
|
-
- **Proof command**: Every fix task must include a proof command and expected output
|
|
177
|
-
|
|
178
|
-
#### Story/Feature
|
|
179
|
-
- **UX review**: Include a product-reviewer agent task to validate from user perspective
|
|
180
|
-
- **Feature flag consideration**: Note whether this should be behind a feature flag
|
|
181
|
-
- **Documentation**: Include user-facing documentation if applicable
|
|
182
|
-
|
|
183
|
-
#### Task
|
|
184
|
-
- **Standard implementation** with empirical verification
|
|
185
|
-
|
|
186
|
-
#### Epic
|
|
187
|
-
- **Decompose into sub-tasks**: Break into Stories, Tasks, and/or Bugs
|
|
188
|
-
- **Each sub-task gets its own type-specific requirements**
|
|
189
|
-
- **Dependency mapping**: Identify which sub-tasks depend on others
|
|
190
|
-
|
|
191
|
-
## Step 9: Include Required Tasks
|
|
192
|
-
|
|
193
|
-
Include all required tasks defined in `@.claude/rules/plan-governance.md` (Required Tasks section), including the archive task which must always be last.
|
|
194
|
-
|
|
195
|
-
## Step 10: Implementation Team Instructions
|
|
196
|
-
|
|
197
|
-
The plan must include explict instructions to "Create an agent team" for implementation and run the /plan-implement skill. Recommend these specialized agents:
|
|
198
|
-
|
|
199
|
-
| Agent | Use For |
|
|
200
|
-
|-------|---------|
|
|
201
|
-
| `implementer` | Code implementation (pre-loaded with project conventions, TDD enforcement) |
|
|
202
|
-
| `tech-reviewer` | Technical review (correctness, security, performance) |
|
|
203
|
-
| `product-reviewer` | Product/UX review (validates from non-technical perspective) |
|
|
204
|
-
| `learner` | Post-implementation learning (processes learnings into skills/rules) |
|
|
205
|
-
| `test-coverage-agent` | Writing comprehensive tests |
|
|
206
|
-
| `code-simplifier` | Code simplification and refinement |
|
|
207
|
-
| `coderabbit` | Automated AI code review |
|
|
208
|
-
|
|
209
|
-
The **team lead** handles git operations (commits, pushes, PR management) — teammates focus on their specialized work.
|
|
210
|
-
|
|
211
|
-
## Step 11: Ticket Integration
|
|
212
|
-
|
|
213
|
-
If the input was a ticket ID or URL:
|
|
214
|
-
|
|
215
|
-
1. Include the ticket URL in the plan metadata
|
|
216
|
-
2. Associate the branch and PR with the ticket
|
|
217
|
-
3. Post the approved plan as a comment on the ticket
|
|
218
|
-
4. Use `/jira-sync` at key milestones
|
|
219
|
-
5. If blocked, update the ticket before stopping
|
|
220
|
-
|
|
221
|
-
## Step 12: Present to User
|
|
222
|
-
|
|
223
|
-
Present the synthesized plan to the user for review. The user may approve, request modifications, or reject.
|
|
224
|
-
|
|
225
|
-
All decisions in the plan must include a recommendation. If a decision is left unresolved, use the recommended option.
|
|
226
|
-
|
|
227
|
-
## Step 13: Shutdown Team
|
|
228
|
-
|
|
229
|
-
Send `shutdown_request` to all teammates and clean up the team.
|
|
230
|
-
|
|
231
|
-
### Bug-Specific Rules
|
|
232
|
-
|
|
233
|
-
If the plan type is **Bug**:
|
|
234
|
-
|
|
235
|
-
- The bug **must** be empirically replicated (Playwright, browser, direct API call, etc.) — not guessed at
|
|
236
|
-
- If the research team cannot reproduce the bug, **STOP**. Update the ticket with findings and what additional information is needed, then end the session
|
|
237
|
-
- Do not attempt to fix a bug you cannot prove exists
|
|
238
|
-
- Never include solutions with obvious anti-patterns (e.g., N+1 queries). If unavoidable due to API limitations, **STOP** and update the ticket with what is needed
|
|
@@ -1,114 +0,0 @@
|
|
|
1
|
-
---
|
|
2
|
-
name: plan-implement
|
|
3
|
-
description: "Implements an existing plan file by reading its tasks and executing them. Spawns an Agent Team with specialized agents for parallel implementation."
|
|
4
|
-
---
|
|
5
|
-
|
|
6
|
-
# Implement Plan
|
|
7
|
-
|
|
8
|
-
Implement the requirements in $ARGUMENTS.
|
|
9
|
-
|
|
10
|
-
If no argument provided, search for plan files in the `plans/` directory and present them to the user for selection.
|
|
11
|
-
|
|
12
|
-
Critical: you must create an agent team to implement the plan. Do not try to skip this!
|
|
13
|
-
|
|
14
|
-
## Step 1: Parse Plan
|
|
15
|
-
|
|
16
|
-
1. **Read the plan file** specified in `$ARGUMENTS`
|
|
17
|
-
2. **Extract all tasks** with their dependencies, descriptions, verification requirements, and metadata
|
|
18
|
-
3. **Parse task metadata** -- extract the JSON metadata code fence from each task (see @.claude/rules/plan.md Metadata section for the required schema)
|
|
19
|
-
4. **Build a dependency graph** to determine which tasks can run in parallel
|
|
20
|
-
|
|
21
|
-
## Task Metadata Rules
|
|
22
|
-
|
|
23
|
-
Each task in the plan file contains a JSON metadata code fence (schema defined in @.claude/rules/plan.md Metadata section).
|
|
24
|
-
|
|
25
|
-
- Every TaskCreate call MUST include the full `metadata` object from the plan's JSON code fence
|
|
26
|
-
- If a task is missing `skills` or `verification`, flag it as an error and ask the user before proceeding
|
|
27
|
-
- Run `verification.command` before marking any task complete
|
|
28
|
-
|
|
29
|
-
## Step 2: Setup
|
|
30
|
-
|
|
31
|
-
1. Read `@.claude/rules/plan-governance.md` for governance rules (branch/PR, git workflow, required tasks)
|
|
32
|
-
2. Read `@.claude/rules/plan.md` for task document format
|
|
33
|
-
3. **Verify branch exists** -- create if needed following branch/PR rules from plan-governance.md
|
|
34
|
-
4. **Verify draft PR exists** -- create with `gh pr create --draft` if needed. No implementation before the draft PR exists
|
|
35
|
-
5. **Determine implementer count** based on the task dependency graph:
|
|
36
|
-
- 1-2 independent tasks → 1 implementer
|
|
37
|
-
- 3-5 independent tasks → 2 implementers
|
|
38
|
-
- 6+ independent tasks → 3 implementers (cap)
|
|
39
|
-
|
|
40
|
-
## Step 3: Create Agent Team
|
|
41
|
-
|
|
42
|
-
Spawn an Agent Team with:
|
|
43
|
-
|
|
44
|
-
- **Implementers** (named `implementer-1`, `implementer-2`, etc.) -- agent type: `implementer`, mode: `bypassPermissions`
|
|
45
|
-
- Create all tasks via TaskCreate with proper `blockedBy` relationships matching the plan's dependency graph
|
|
46
|
-
- Assign the first batch of independent tasks to implementers
|
|
47
|
-
|
|
48
|
-
Use the specialized agents per `@.claude/rules/plan-governance.md` (Implementation Team Guidance):
|
|
49
|
-
|
|
50
|
-
| Agent | Use For | Phase |
|
|
51
|
-
|-------|---------|-------|
|
|
52
|
-
| `implementer` | Code implementation with TDD (red-green-refactor) | Phase 2 |
|
|
53
|
-
| `tech-reviewer` | Technical review (correctness, security, performance) | Phase 3 |
|
|
54
|
-
| `product-reviewer` | Product/UX review (validates from non-technical perspective) | Phase 3 |
|
|
55
|
-
| `test-coverage-agent` | Writing comprehensive tests | Phase 4 |
|
|
56
|
-
| `code-simplifier` | Code simplification and refinement | Phase 4 |
|
|
57
|
-
| `coderabbit` | Automated AI code review | Phase 3 |
|
|
58
|
-
| `learner` | Post-implementation learning | Phase 5 |
|
|
59
|
-
|
|
60
|
-
The **team lead** handles git operations (commits, pushes, PR management) -- teammates focus on their specialized work.
|
|
61
|
-
|
|
62
|
-
## Compaction Resilience
|
|
63
|
-
|
|
64
|
-
Context compaction can cause the team lead to lose in-memory state (task assignments, owner fields). Follow these rules:
|
|
65
|
-
|
|
66
|
-
1. **Dual owner storage** -- on every TaskUpdate that sets `owner`, also store it in `metadata.owner`:
|
|
67
|
-
```
|
|
68
|
-
TaskUpdate({ taskId: "1", owner: "implementer-1", metadata: { owner: "implementer-1" } })
|
|
69
|
-
```
|
|
70
|
-
2. **Re-read after compaction** -- immediately call TaskList to reload all task state
|
|
71
|
-
3. **Restore missing owners** -- if any task has `metadata.owner` but no `owner` field, restore it via TaskUpdate
|
|
72
|
-
4. **Never rely on memory** -- always call TaskList before assigning new work
|
|
73
|
-
|
|
74
|
-
## Step 4: Phase 2 - Implementation
|
|
75
|
-
|
|
76
|
-
1. Implementers work on assigned tasks following TDD (red-green-refactor cycle)
|
|
77
|
-
2. Team lead monitors completion via messages from implementers
|
|
78
|
-
3. After each task completes: team lead runs `git add <specific files>` + `git commit` with conventional commit message
|
|
79
|
-
4. Team lead assigns next tasks as dependencies resolve
|
|
80
|
-
5. Continue until all implementation tasks are complete
|
|
81
|
-
|
|
82
|
-
## Step 5: Phase 3 - Reviews (parallel)
|
|
83
|
-
|
|
84
|
-
Spawn review agents simultaneously:
|
|
85
|
-
|
|
86
|
-
- **tech-reviewer** -- agent type: `tech-reviewer`, mode: `bypassPermissions`
|
|
87
|
-
- **product-reviewer** -- agent type: `product-reviewer`, mode: `bypassPermissions`
|
|
88
|
-
- Invoke `/plan-local-code-review` skill (team lead runs directly)
|
|
89
|
-
- **coderabbit** -- agent type: `coderabbit:code-reviewer`, mode: `bypassPermissions`
|
|
90
|
-
|
|
91
|
-
Wait for all reviews to complete.
|
|
92
|
-
|
|
93
|
-
## Step 6: Phase 4 - Post-Review (sequential)
|
|
94
|
-
|
|
95
|
-
1. **Fix review findings** -- re-spawn an implementer to address valid review suggestions
|
|
96
|
-
2. **Simplify code** -- spawn `code-simplifier` agent (agent type: `code-simplifier:code-simplifier`, mode: `bypassPermissions`)
|
|
97
|
-
3. **Update tests** -- spawn `test-coverage-agent` to update tests for post-review changes
|
|
98
|
-
4. **Verify all tasks** -- team lead runs ALL proof commands from all tasks to confirm everything still works
|
|
99
|
-
|
|
100
|
-
## Step 7: Phase 5 - Learning & Archive
|
|
101
|
-
|
|
102
|
-
1. **Collect learnings** -- spawn `learner` agent (agent type: `learner`, mode: `bypassPermissions`) to process task learnings
|
|
103
|
-
2. **Archive the plan** -- follow the Archive Procedure in @.claude/rules/plan-governance.md
|
|
104
|
-
3. **Finalize PR**:
|
|
105
|
-
```bash
|
|
106
|
-
git add . && git commit -m "chore: archive <plan-name> plan"
|
|
107
|
-
GIT_SSH_COMMAND="ssh -o ServerAliveInterval=30 -o ServerAliveCountMax=5" git push
|
|
108
|
-
gh pr ready
|
|
109
|
-
gh pr merge --auto --merge
|
|
110
|
-
```
|
|
111
|
-
|
|
112
|
-
## Step 8: Shutdown Team
|
|
113
|
-
|
|
114
|
-
Send `shutdown_request` to all teammates and clean up the team.
|
|
File without changes
|