@codingame/monaco-vscode-telemetry-service-override 23.2.2 → 24.1.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codingame/monaco-vscode-telemetry-service-override",
-  "version": "23.2.2",
+  "version": "24.1.0",
   "private": false,
   "description": "VSCode public API plugged on the monaco editor - telemetry service-override",
   "keywords": [],
@@ -15,8 +15,7 @@
   },
   "type": "module",
   "dependencies": {
-    "@codingame/monaco-vscode-4bf376c2-03c7-58cb-8303-c67aeefa3d3d-common": "23.2.2",
-    "@codingame/monaco-vscode-api": "23.2.2",
+    "@codingame/monaco-vscode-api": "24.1.0",
     "@microsoft/1ds-core-js": "3.2.18",
     "@microsoft/1ds-post-js": "3.2.18"
   },

package/vscode/src/vs/platform/telemetry/browser/1dsAppender.d.ts

@@ -1,6 +1,6 @@
 import { AbstractOneDataSystemAppender, IAppInsightsCore } from "../common/1dsAppender.js";
 export declare class OneDataSystemWebAppender extends AbstractOneDataSystemAppender {
     constructor(isInternalTelemetry: boolean, eventPrefix: string, defaultData: {
-        [key: string]: any;
+        [key: string]: unknown;
     } | null, iKeyOrClientFactory: string | (() => IAppInsightsCore));
 }

package/vscode/src/vs/platform/telemetry/common/1dsAppender.d.ts

@@ -16,10 +16,10 @@ export declare abstract class AbstractOneDataSystemAppender implements ITelemetr
     protected readonly endPointUrl = "https://mobile.events.data.microsoft.com/OneCollector/1.0";
     protected readonly endPointHealthUrl = "https://mobile.events.data.microsoft.com/ping";
     constructor(_isInternalTelemetry: boolean, _eventPrefix: string, _defaultData: {
-        [key: string]: any;
+        [key: string]: unknown;
     } | null, iKeyOrClientFactory: string | (() => IAppInsightsCore), // allow factory function for testing
     _xhrOverride?: IXHROverride | undefined);
     private _withAIClient;
-    log(eventName: string, data?: any): void;
+    log(eventName: string, data?: unknown): void;
     flush(): Promise<void>;
 }

package/vscode/src/vs/platform/telemetry/common/1dsAppender.js

@@ -86,14 +86,14 @@ class AbstractOneDataSystemAppender {
             return;
         }
         data = mixin(data, this._defaultData);
-        data = validateTelemetryData(data);
+        const validatedData = validateTelemetryData(data);
         const name = this._eventPrefix + '/' + eventName;
         try {
             this._withAIClient((aiClient) => {
-                aiClient.pluginVersionString = data?.properties.version ?? 'Unknown';
+                aiClient.pluginVersionString = validatedData?.properties.version ?? 'Unknown';
                 aiClient.track({
                     name,
-                    baseData: { name, properties: data?.properties, measurements: data?.measurements }
+                    baseData: { name, properties: validatedData?.properties, measurements: validatedData?.measurements }
                 });
             });
         }

package/vscode/src/vs/platform/telemetry/common/telemetryLogAppender.d.ts

@@ -8,5 +8,5 @@ export declare class TelemetryLogAppender extends Disposable implements ITelemet
     private readonly logger;
     constructor(prefix: string, remote: boolean, loggerService: ILoggerService, environmentService: IEnvironmentService, productService: IProductService);
     flush(): Promise<void>;
-    log(eventName: string, data: any): void;
+    log(eventName: string, data: unknown): void;
 }

package/vscode/src/vs/platform/telemetry/common/telemetryLogAppender.js

@@ -20,7 +20,7 @@ let TelemetryLogAppender = class TelemetryLogAppender extends Disposable {
             const justLoggingAndNotSending = isLoggingOnly(productService, environmentService);
             const logSuffix = justLoggingAndNotSending ? ' (Not Sent)' : '';
             this.logger = this._register(loggerService.createLogger(id, {
-                name: ( localize(2042, "Telemetry{0}", logSuffix)),
+                name: ( localize(2055, "Telemetry{0}", logSuffix)),
                 group: TelemetryLogGroup,
                 hidden: true
             }));

package/vscode/src/vs/platform/telemetry/common/telemetryService.js

@@ -34,7 +34,7 @@ let TelemetryService = class TelemetryService {
         this._piiPaths = config.piiPaths || [];
         this._telemetryLevel = TelemetryLevel.USAGE;
         this._sendErrorTelemetry = !!config.sendErrorTelemetry;
-        this._cleanupPatterns = [/(vscode-)?file:\/\/\/.*?\/resources\/app\//gi];
+        this._cleanupPatterns = [/(vscode-)?file:\/\/.*?\/resources\/app\//gi];
         for (const piiPath of this._piiPaths) {
             this._cleanupPatterns.push(( new RegExp(escapeRegExpCharacters(piiPath), 'gi')));
             if (piiPath.indexOf('\\') >= 0) {
@@ -80,7 +80,7 @@ let TelemetryService = class TelemetryService {
         data = mixin(data, this._experimentProperties);
         data = cleanData(data, this._cleanupPatterns);
         data = mixin(data, this._commonProperties);
-        this._appenders.forEach(a => a.log(eventName, data));
+        this._appenders.forEach(a => a.log(eventName, data ?? {}));
     }
     publicLog(eventName, data) {
         this._log(eventName, TelemetryLevel.USAGE, data);
@@ -104,30 +104,30 @@ TelemetryService = ( __decorate([
 ], TelemetryService));
 function getTelemetryLevelSettingDescription() {
     const telemetryText = ( localize(
-        2043,
+        2056,
         "Controls {0} telemetry, first-party extension telemetry, and participating third-party extension telemetry. Some third party extensions might not respect this setting. Consult the specific extension's documentation to be sure. Telemetry helps us better understand how {0} is performing, where improvements need to be made, and how features are being used.",
         product.nameLong
     ));
     const externalLinksStatement = !product.privacyStatementUrl ?
         ( localize(
-        2044,
+        2057,
         "Read more about the [data we collect]({0}).",
         'https://aka.ms/vscode-telemetry'
     )) :
         ( localize(
-        2045,
+        2058,
         "Read more about the [data we collect]({0}) and our [privacy statement]({1}).",
         'https://aka.ms/vscode-telemetry',
         product.privacyStatementUrl
     ));
     const restartString = !isWeb ? ( localize(
-        2046,
+        2059,
         'A full restart of the application is necessary for crash reporting changes to take effect.'
     )) : '';
-    const crashReportsHeader = ( localize(2047, "Crash Reports"));
-    const errorsHeader = ( localize(2048, "Error Telemetry"));
-    const usageHeader = ( localize(2049, "Usage Data"));
-    const telemetryTableDescription = ( localize(2050, "The following table outlines the data sent with each setting:"));
+    const crashReportsHeader = ( localize(2060, "Crash Reports"));
+    const errorsHeader = ( localize(2061, "Error Telemetry"));
+    const usageHeader = ( localize(2062, "Usage Data"));
+    const telemetryTableDescription = ( localize(2063, "The following table outlines the data sent with each setting:"));
     const telemetryTable = `
 |       | ${crashReportsHeader} | ${errorsHeader} | ${usageHeader} |
 |:------|:-------------:|:---------------:|:----------:|
@@ -137,7 +137,7 @@ function getTelemetryLevelSettingDescription() {
 | off   |       -       |        -        |     -      |
 `;
     const deprecatedSettingNote = ( localize(
-        2051,
+        2064,
         "****Note:*** If this setting is 'off', no telemetry will be sent regardless of other telemetry settings. If this setting is set to anything except 'off' and telemetry is disabled with deprecated settings, no telemetry will be sent.*"
     ));
     const telemetryDescription = `
@@ -159,16 +159,16 @@ configurationRegistry.registerConfiguration({
     'id': TELEMETRY_SECTION_ID,
     'order': 1,
     'type': 'object',
-    'title': ( localize(2052, "Telemetry")),
+    'title': ( localize(2065, "Telemetry")),
     'properties': {
         [TELEMETRY_SETTING_ID]: {
             'type': 'string',
             'enum': [TelemetryConfiguration.ON, TelemetryConfiguration.ERROR, TelemetryConfiguration.CRASH, TelemetryConfiguration.OFF],
             'enumDescriptions': [
-                ( localize(2053, "Sends usage data, errors, and crash reports.")),
-                ( localize(2054, "Sends general error telemetry and crash reports.")),
-                ( localize(2055, "Sends OS level crash reports.")),
-                ( localize(2056, "Disables all product telemetry."))
+                ( localize(2066, "Sends usage data, errors, and crash reports.")),
+                ( localize(2067, "Sends general error telemetry and crash reports.")),
+                ( localize(2068, "Sends OS level crash reports.")),
+                ( localize(2069, "Disables all product telemetry."))
             ],
             'markdownDescription': getTelemetryLevelSettingDescription(),
             'default': TelemetryConfiguration.ON,
@@ -182,24 +182,24 @@ configurationRegistry.registerConfiguration({
                 localization: {
                     description: {
                         key: 'telemetry.telemetryLevel.policyDescription',
-                        value: ( localize(2057, "Controls the level of telemetry.")),
+                        value: ( localize(2070, "Controls the level of telemetry.")),
                     },
                     enumDescriptions: [
                         {
                             key: 'telemetry.telemetryLevel.default',
-                            value: ( localize(2053, "Sends usage data, errors, and crash reports.")),
+                            value: ( localize(2066, "Sends usage data, errors, and crash reports.")),
                         },
                         {
                             key: 'telemetry.telemetryLevel.error',
-                            value: ( localize(2054, "Sends general error telemetry and crash reports.")),
+                            value: ( localize(2067, "Sends general error telemetry and crash reports.")),
                         },
                         {
                             key: 'telemetry.telemetryLevel.crash',
-                            value: ( localize(2055, "Sends OS level crash reports.")),
+                            value: ( localize(2068, "Sends OS level crash reports.")),
                         },
                         {
                             key: 'telemetry.telemetryLevel.off',
-                            value: ( localize(2056, "Disables all product telemetry.")),
+                            value: ( localize(2069, "Disables all product telemetry.")),
                         }
                     ]
                 }
@@ -209,7 +209,7 @@ configurationRegistry.registerConfiguration({
             type: 'boolean',
             default: true,
             description: ( localize(
-                2058,
+                2071,
                 "Enable feedback mechanisms such as the issue reporter, surveys, and other feedback options."
             )),
             policy: {
@@ -217,7 +217,7 @@ configurationRegistry.registerConfiguration({
                 category: PolicyCategory.Telemetry,
                 minimumVersion: '1.99',
                 localization: { description: { key: 'telemetry.feedback.enabled', value: ( localize(
-                    2058,
+                    2071,
                     "Enable feedback mechanisms such as the issue reporter, surveys, and other feedback options."
                 )) } },
             }
@@ -226,12 +226,12 @@ configurationRegistry.registerConfiguration({
             'type': 'boolean',
             'markdownDescription': !product.privacyStatementUrl ?
                 ( localize(
-                2059,
+                2072,
                 "Enable diagnostic data to be collected. This helps us to better understand how {0} is performing and where improvements need to be made.",
                 product.nameLong
             )) :
                 ( localize(
-                2060,
+                2073,
                 "Enable diagnostic data to be collected. This helps us to better understand how {0} is performing and where improvements need to be made. [Read more]({1}) about what we collect and our privacy statement.",
                 product.nameLong,
                 product.privacyStatementUrl
@@ -239,7 +239,7 @@ configurationRegistry.registerConfiguration({
             'default': true,
             'restricted': true,
             'markdownDeprecationMessage': ( localize(
-                2061,
+                2074,
                 "If this setting is false, no telemetry will be sent regardless of the new setting's value. Deprecated in favor of the {0} setting.",
                 `\`#${TELEMETRY_SETTING_ID}#\``
             )),

package/vscode/src/vs/workbench/contrib/telemetry/browser/telemetry.contribution.js

@@ -40,6 +40,7 @@ import { IOutputService } from '@codingame/monaco-vscode-api/vscode/vs/workbench
 import { LogLevel } from '@codingame/monaco-vscode-api/vscode/vs/platform/log/common/log';
 import { ILoggerService } from '@codingame/monaco-vscode-api/vscode/vs/platform/log/common/log.service';
 import { VerifyExtensionSignatureConfigKey } from '@codingame/monaco-vscode-api/vscode/vs/platform/extensionManagement/common/extensionManagement';
+import { TerminalContribSettingId } from '@codingame/monaco-vscode-api/vscode/vs/workbench/contrib/terminal/terminalContribExports';
 
 var TelemetryContribution_1;
 let TelemetryContribution = class TelemetryContribution extends Disposable {
@@ -137,7 +138,7 @@ let TelemetryContribution = class TelemetryContribution extends Disposable {
             constructor() {
                 super({
                     id: 'workbench.action.showTelemetry',
-                    title: ( localize2(11326, "Show Telemetry")),
+                    title: ( localize2(11459, "Show Telemetry")),
                     category: Categories.Developer,
                     f1: true
                 });
@@ -266,6 +267,12 @@ let ConfigurationTelemetryContribution = class ConfigurationTelemetryContributio
             case AutoRestartConfigurationKey:
                 this.telemetryService.publicLog2('extensions.autoRestart', { settingValue: this.getValueToReport(key, target), source });
                 return;
+            case TerminalContribSettingId.OutputLocation:
+                this.telemetryService.publicLog2('terminal.integrated.chatAgentTools.outputLocation', { settingValue: this.getValueToReport(key, target), source });
+                return;
+            case TerminalContribSettingId.SuggestEnabled:
+                this.telemetryService.publicLog2('terminal.integrated.suggest.enabled', { settingValue: this.getValueToReport(key, target), source });
+                return;
         }
     }
 };

package/vscode/src/vs/workbench/services/telemetry/browser/telemetryService.d.ts

@@ -7,7 +7,7 @@ import { IStorageService } from "@codingame/monaco-vscode-api/vscode/vs/platform
 import { ClassifiedEvent, IGDPRProperty, OmitMetadata, StrictPropertyCheck } from "@codingame/monaco-vscode-api/vscode/vs/platform/telemetry/common/gdprTypings";
 import { ITelemetryData, TelemetryLevel } from "@codingame/monaco-vscode-api/vscode/vs/platform/telemetry/common/telemetry";
 import { ITelemetryService } from "@codingame/monaco-vscode-api/vscode/vs/platform/telemetry/common/telemetry.service";
-import { IBrowserWorkbenchEnvironmentService } from "@codingame/monaco-vscode-4bf376c2-03c7-58cb-8303-c67aeefa3d3d-common/vscode/vs/workbench/services/environment/browser/environmentService.service";
+import { IBrowserWorkbenchEnvironmentService } from "@codingame/monaco-vscode-api/vscode/vs/workbench/services/environment/browser/environmentService.service";
 import { IRemoteAgentService } from "@codingame/monaco-vscode-api/vscode/vs/workbench/services/remote/common/remoteAgentService.service";
 export declare class TelemetryService extends Disposable implements ITelemetryService {
     readonly _serviceBrand: undefined;

package/vscode/src/vs/workbench/services/telemetry/browser/telemetryService.js

@@ -12,7 +12,7 @@ import '@codingame/monaco-vscode-api/vscode/vs/platform/instantiation/common/ins
 import { TelemetryLogAppender } from '../../../../platform/telemetry/common/telemetryLogAppender.js';
 import { TelemetryService as TelemetryService$1 } from '../../../../platform/telemetry/common/telemetryService.js';
 import { NullTelemetryService, supportsTelemetry, getTelemetryLevel, isInternalTelemetry, isLoggingOnly } from '@codingame/monaco-vscode-api/vscode/vs/platform/telemetry/common/telemetryUtils';
-import { IBrowserWorkbenchEnvironmentService } from '@codingame/monaco-vscode-4bf376c2-03c7-58cb-8303-c67aeefa3d3d-common/vscode/vs/workbench/services/environment/browser/environmentService.service';
+import { IBrowserWorkbenchEnvironmentService } from '@codingame/monaco-vscode-api/vscode/vs/workbench/services/environment/browser/environmentService.service';
 import { IRemoteAgentService } from '@codingame/monaco-vscode-api/vscode/vs/workbench/services/remote/common/remoteAgentService.service';
 import { resolveWorkbenchCommonProperties } from './workbenchCommonProperties.js';