@codingame/monaco-vscode-task-service-override 26.2.2 → 27.0.0

package/vscode/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.js

@@ -170,7 +170,7 @@ class TerminalTaskSystem extends Disposable {
         this._hasReconnected = false;
         this._terminalTabActions = [{
             id: RerunForActiveTerminalCommandId,
-            label: ( localize(11764, "Rerun Task")),
+            label: ( localize(12575, "Rerun Task")),
             icon: rerunTaskIcon
         }];
         this._taskStartTimes = ( new Map());
@@ -181,7 +181,7 @@ class TerminalTaskSystem extends Disposable {
         this._terminals = Object.create(null);
         this._idleTaskTerminals = ( new LinkedMap());
         this._sameTaskTerminals = Object.create(null);
-        this._onDidStateChange = ( new Emitter());
+        this._onDidStateChange = this._register(( new Emitter()));
         this._taskSystemInfoResolver = taskSystemInfoResolver;
         this._register(
             this._terminalStatusManager = instantiationService.createInstance(TaskTerminalStatus)
@@ -249,7 +249,7 @@ class TerminalTaskSystem extends Disposable {
             } else {
                 this._log(( error.toString()));
                 throw ( new TaskError(Severity.Error, ( localize(
-                    11765,
+                    12576,
                     "A unknown error has occurred while executing a task. See task output log for details."
                 )), TaskErrors.UnknownError));
             }
@@ -258,7 +258,7 @@ class TerminalTaskSystem extends Disposable {
     getTerminalsForTasks(tasks) {
         const results = [];
         for (const t of asArray(tasks)) {
-            for (const key in this._terminals) {
+            for (const key of ( Object.keys(this._terminals))) {
                 const value = this._terminals[key];
                 if (value.lastTask === t.getMapKey()) {
                     results.push(value.terminal.resource);
@@ -297,7 +297,7 @@ class TerminalTaskSystem extends Disposable {
             });
             const openOutput = "Show Output";
             this._notificationService.prompt(Severity.Warning, ( localize(
-                11766,
+                12577,
                 "There are issues with task \"{0}\". See the output for more details.",
                 task._label
             )), [{
@@ -420,9 +420,10 @@ class TerminalTaskSystem extends Disposable {
             });
         }
         return ( new Promise((resolve, reject) => {
-            this._register(terminal.onDisposed(terminal => {
+            const onDisposedListener = terminal.onDisposed(terminal => {
                 this._fireTaskEvent(TaskEvent.terminated(task, terminal.instanceId, terminal.exitReason));
-            }));
+                onDisposedListener.dispose();
+            });
             const onExit = terminal.onExit(() => {
                 const task = activeTerminal.task;
                 try {
@@ -464,7 +465,7 @@ class TerminalTaskSystem extends Disposable {
         return Promise.all(promises);
     }
     _showDependencyCycleMessage(task) {
-        this._log(( localize(11767, "There is a dependency cycle. See task \"{0}\".", task._label)));
+        this._log(( localize(12578, "There is a dependency cycle. See task \"{0}\".", task._label)));
         this._showOutput();
     }
     _executeTask(
@@ -527,7 +528,7 @@ class TerminalTaskSystem extends Disposable {
                         }
                     } else {
                         this._log(( localize(
-                            11768,
+                            12579,
                             "Couldn't resolve dependent task '{0}' in workspace folder '{1}'",
                             isString(dependency.task) ? dependency.task : JSON.stringify(dependency.task, undefined, 0),
                             (dependency.uri.toString())
@@ -825,7 +826,10 @@ class TerminalTaskSystem extends Disposable {
         this._collectTaskVariables(variables, task);
         let hasAllVariables = true;
         variables.forEach(value => {
-            if (value.substring(2, value.length - 1) in lastTask.getVerifiedTask().resolvedVariables) {
+            if (Object.hasOwn(
+                lastTask.getVerifiedTask().resolvedVariables,
+                value.substring(2, value.length - 1)
+            )) {
                 hasAllVariables = false;
             }
         });
@@ -873,11 +877,12 @@ class TerminalTaskSystem extends Disposable {
                 problemMatchers,
                 this._markerService,
                 this._modelService,
-                this._fileService
+                this._fileService,
+                this._logService
             ));
             if ((problemMatchers.length > 0) && !watchingProblemMatcher.isWatching()) {
                 this._appendOutput(( localize(
-                    11769,
+                    12580,
                     "Task {0} is a background task but uses a problem matcher without a background pattern",
                     task._label
                 )));
@@ -1044,11 +1049,12 @@ class TerminalTaskSystem extends Disposable {
                 this._markerService,
                 this._modelService,
                 ProblemHandlingStrategy.Clean,
-                this._fileService
+                this._fileService,
+                this._logService
             ));
             this._terminalStatusManager.addTerminal(task, terminal, startStopProblemMatcher);
             this._taskProblemMonitor.addTerminal(terminal, startStopProblemMatcher);
-            this._register(startStopProblemMatcher.onDidStateChange(event => {
+            const problemMatcherListener = startStopProblemMatcher.onDidStateChange(event => {
                 if (event.kind === ProblemCollectorEventKind.BackgroundProcessingBegins) {
                     this._fireTaskEvent(
                         TaskEvent.general(TaskEventKind.ProblemMatcherStarted, task, terminal?.instanceId)
@@ -1065,7 +1071,7 @@ class TerminalTaskSystem extends Disposable {
                         );
                     }
                 }
-            }));
+            });
             let processStartedSignaled = false;
             terminal.processReady.then(() => {
                 if (!processStartedSignaled) {
@@ -1108,6 +1114,7 @@ class TerminalTaskSystem extends Disposable {
                         onData.dispose();
                         startStopProblemMatcher.done();
                         startStopProblemMatcher.dispose();
+                        problemMatcherListener.dispose();
                     }, 100);
                     if (!processStartedSignaled && terminal) {
                         this._fireTaskEvent(TaskEvent.processStarted(task, terminal.instanceId, terminal.processId));
@@ -1306,12 +1313,12 @@ class TerminalTaskSystem extends Disposable {
             shellLaunchConfig.args = windowsShellArgs ? combinedShellArgs.join(" ") : combinedShellArgs;
             if (task.command.presentation && task.command.presentation.echo) {
                 if (needsFolderQualification && workspaceFolder) {
-                    const folder = cwd && typeof cwd === "object" && "path" in cwd ? basename(cwd.path) : workspaceFolder.name;
-                    shellLaunchConfig.initialText = this.taskShellIntegrationStartSequence(cwd) + formatMessageForTerminal(( localize(11770, "Executing task in folder {0}: {1}", folder, commandLine)), {
+                    const folder = cwd && typeof cwd === "object" && Object.hasOwn(cwd, "path") ? basename(cwd.path) : workspaceFolder.name;
+                    shellLaunchConfig.initialText = this.taskShellIntegrationStartSequence(cwd) + formatMessageForTerminal(( localize(12581, "Executing task in folder {0}: {1}", folder, commandLine)), {
                         excludeLeadingNewLine: true
                     }) + this.getTaskShellIntegrationOutputSequence(commandLineInfo);
                 } else {
-                    shellLaunchConfig.initialText = this.taskShellIntegrationStartSequence(cwd) + formatMessageForTerminal(( localize(11771, "Executing task: {0}", commandLine)), {
+                    shellLaunchConfig.initialText = this.taskShellIntegrationStartSequence(cwd) + formatMessageForTerminal(( localize(12582, "Executing task: {0}", commandLine)), {
                         excludeLeadingNewLine: true
                     }) + this.getTaskShellIntegrationOutputSequence(commandLineInfo);
                 }
@@ -1348,7 +1355,7 @@ class TerminalTaskSystem extends Disposable {
                 };
                 if (needsFolderQualification && workspaceFolder) {
                     shellLaunchConfig.initialText = this.taskShellIntegrationStartSequence(cwd) + formatMessageForTerminal(( localize(
-                        11770,
+                        12581,
                         "Executing task in folder {0}: {1}",
                         workspaceFolder.name,
                         `${shellLaunchConfig.executable} ${getArgsToEcho(shellLaunchConfig.args)}`
@@ -1357,7 +1364,7 @@ class TerminalTaskSystem extends Disposable {
                     }) + this.getTaskShellIntegrationOutputSequence(undefined);
                 } else {
                     shellLaunchConfig.initialText = this.taskShellIntegrationStartSequence(cwd) + formatMessageForTerminal(( localize(
-                        11772,
+                        12583,
                         "Executing task: {0}",
                         `${shellLaunchConfig.executable} ${getArgsToEcho(shellLaunchConfig.args)}`
                     )), {
@@ -1411,12 +1418,17 @@ class TerminalTaskSystem extends Disposable {
     }
     async _doCreateTerminal(task, group, launchConfigs) {
         const reconnectedTerminal = await this._reconnectToTerminal(task);
-        const onDisposed = terminal => this._fireTaskEvent(TaskEvent.terminated(task, terminal.instanceId, terminal.exitReason));
+        const registerOnDisposed = terminal => {
+            const listener = terminal.onDisposed(() => {
+                this._fireTaskEvent(TaskEvent.terminated(task, terminal.instanceId, terminal.exitReason));
+                listener.dispose();
+            });
+        };
         if (reconnectedTerminal) {
-            if ("command" in task && task.command.presentation) {
+            if ((CustomTask.is(task) || ContributedTask.is(task)) && task.command.presentation) {
                 reconnectedTerminal.waitOnExit = getWaitOnExitValue(task.command.presentation, task.configurationProperties);
             }
-            this._register(reconnectedTerminal.onDisposed(onDisposed));
+            registerOnDisposed(reconnectedTerminal);
             this._logService.trace("reconnected to task and terminal", task._id);
             return reconnectedTerminal;
         }
@@ -1431,7 +1443,7 @@ class TerminalTaskSystem extends Disposable {
                         },
                         config: launchConfigs
                     });
-                    this._register(result.onDisposed(onDisposed));
+                    registerOnDisposed(result);
                     if (result) {
                         return result;
                     }
@@ -1442,7 +1454,7 @@ class TerminalTaskSystem extends Disposable {
         const createdTerminal = await this._terminalService.createTerminal({
             config: launchConfigs
         });
-        this._register(createdTerminal.onDisposed(onDisposed));
+        registerOnDisposed(createdTerminal);
         return createdTerminal;
     }
     _reconnectToTerminals() {
@@ -1465,6 +1477,10 @@ class TerminalTaskSystem extends Disposable {
                         shellIntegrationNonce: data.shellIntegrationNonce
                     };
                     this._terminals[terminal.instanceId] = terminalData;
+                    const listener = terminal.onDisposed(() => {
+                        this._deleteTaskAndTerminal(terminal, terminalData);
+                        listener.dispose();
+                    });
                     this._logService.trace(
                         "Reconnecting to task terminal",
                         terminalData.lastTask,
@@ -1501,7 +1517,7 @@ class TerminalTaskSystem extends Disposable {
                 customPtyImplementation: (id, cols, rows) => ( new TerminalProcessExtHostProxy(id, cols, rows, this._terminalService)),
                 waitOnExit,
                 name: this._createTerminalName(task),
-                initialText: task.command.presentation && task.command.presentation.echo ? formatMessageForTerminal(( localize(11773, "Executing task: {0}", task._label)), {
+                initialText: task.command.presentation && task.command.presentation.echo ? formatMessageForTerminal(( localize(12584, "Executing task: {0}", task._label)), {
                     excludeLeadingNewLine: true
                 }) : undefined,
                 isFeatureTerminal: true,
@@ -1524,7 +1540,7 @@ class TerminalTaskSystem extends Disposable {
                 presentationOptions
             );
             if (launchConfigs === undefined) {
-                return [undefined, ( new TaskError(Severity.Error, ( localize(11774, "Can't execute a shell command on an UNC drive using cmd.exe.")), TaskErrors.UnknownError))];
+                return [undefined, ( new TaskError(Severity.Error, ( localize(12585, "Can't execute a shell command on an UNC drive using cmd.exe.")), TaskErrors.UnknownError))];
             }
         }
         const prefersSameTerminal = presentationOptions.panel === PanelKind.Dedicated;
@@ -1601,10 +1617,10 @@ class TerminalTaskSystem extends Disposable {
             group,
             shellIntegrationNonce: terminal.shellLaunchConfig.shellIntegrationNonce
         };
-        const onDisposedListener = this._register(terminal.onDisposed(() => {
+        const onDisposedListener = terminal.onDisposed(() => {
             this._deleteTaskAndTerminal(terminal, terminalData);
             onDisposedListener.dispose();
-        }));
+        });
         this._terminals[terminalKey] = terminalData;
         terminal.shellLaunchConfig.tabActions = this._terminalTabActions;
         return [terminal, undefined];
@@ -1722,7 +1738,7 @@ class TerminalTaskSystem extends Disposable {
         } else if (Array.isArray(definition)) {
             definition.forEach(element => this._collectDefinitionVariables(variables, element));
         } else if (isObject(definition)) {
-            for (const key in definition) {
+            for (const key of ( Object.keys(definition))) {
                 this._collectDefinitionVariables(variables, definition[key]);
             }
         }
@@ -1832,7 +1848,7 @@ class TerminalTaskSystem extends Disposable {
             }
             if (!matcher) {
                 this._appendOutput(( localize(
-                    11775,
+                    12586,
                     "Problem matcher {0} can't be resolved. The matcher will be ignored"
                 )));
                 continue;
@@ -1899,7 +1915,7 @@ class TerminalTaskSystem extends Disposable {
                 if (isString(value)) {
                     result.env[key] = await this._resolveVariable(resolver, value);
                 } else {
-                    result.env[key] = ( value.toString());
+                    result.env[key] = String(value);
                 }
             }
         }
@@ -1939,7 +1955,7 @@ class TerminalTaskSystem extends Disposable {
         return "other";
     }
     async getTaskForTerminal(instanceId) {
-        for (const key in this._activeTasks) {
+        for (const key of ( Object.keys(this._activeTasks))) {
             const activeTask = this._activeTasks[key];
             if (activeTask.terminal?.instanceId === instanceId) {
                 return activeTask.task;
@@ -1960,9 +1976,9 @@ function getWaitOnExitValue(presentationOptions, configurationProperties) {
     if ((presentationOptions.close === undefined) || (presentationOptions.close === false)) {
         if ((presentationOptions.reveal !== RevealKind.Never) || !configurationProperties.isBackground || (presentationOptions.close === false)) {
             if (presentationOptions.panel === PanelKind.New) {
-                return taskShellIntegrationWaitOnExitSequence(( localize(11776, "Press any key to close the terminal.")));
+                return taskShellIntegrationWaitOnExitSequence(( localize(12587, "Press any key to close the terminal.")));
             } else if (presentationOptions.showReuseMessage) {
-                return taskShellIntegrationWaitOnExitSequence(( localize(11777, "Terminal will be reused by tasks, press any key to close it.")));
+                return taskShellIntegrationWaitOnExitSequence(( localize(12588, "Terminal will be reused by tasks, press any key to close it.")));
             } else {
                 return true;
             }

package/vscode/src/vs/workbench/contrib/tasks/common/jsonSchemaCommon.js

@@ -10,12 +10,12 @@ const schema = {
         },
         options: {
             type: "object",
-            description: ( localize(11779, "Additional command options")),
+            description: ( localize(12590, "Additional command options")),
             properties: {
                 cwd: {
                     type: "string",
                     description: ( localize(
-                        11780,
+                        12591,
                         "The current working directory of the executed program or script. If omitted Code's current workspace root is used."
                     ))
                 },
@@ -25,7 +25,7 @@ const schema = {
                         type: "string"
                     },
                     description: ( localize(
-                        11781,
+                        12592,
                         "The environment of the executed program or shell. If omitted the parent process' environment is used."
                     ))
                 }
@@ -38,7 +38,7 @@ const schema = {
             oneOf: [{
                 type: "string",
                 errorMessage: ( localize(
-                    11782,
+                    12593,
                     "Unrecognized problem matcher. Is the extension that contributes this problem matcher installed?"
                 ))
             }, Schemas.LegacyProblemMatcher, {
@@ -47,7 +47,7 @@ const schema = {
                     anyOf: [{
                         type: "string",
                         errorMessage: ( localize(
-                            11782,
+                            12593,
                             "Unrecognized problem matcher. Is the extension that contributes this problem matcher installed?"
                         ))
                     }, Schemas.LegacyProblemMatcher]
@@ -57,15 +57,15 @@ const schema = {
         shellConfiguration: {
             type: "object",
             additionalProperties: false,
-            description: ( localize(11783, "Configures the shell to be used.")),
+            description: ( localize(12594, "Configures the shell to be used.")),
             properties: {
                 executable: {
                     type: "string",
-                    description: ( localize(11784, "The shell to be used."))
+                    description: ( localize(12595, "The shell to be used."))
                 },
                 args: {
                     type: "array",
-                    description: ( localize(11785, "The shell arguments.")),
+                    description: ( localize(12596, "The shell arguments.")),
                     items: {
                         type: "string"
                     }
@@ -79,13 +79,13 @@ const schema = {
                 command: {
                     type: "string",
                     description: ( localize(
-                        11786,
+                        12597,
                         "The command to be executed. Can be an external program or a shell command."
                     ))
                 },
                 args: {
                     type: "array",
-                    description: ( localize(11787, "Arguments passed to the command when this task is invoked.")),
+                    description: ( localize(12598, "Arguments passed to the command when this task is invoked.")),
                     items: {
                         type: "string"
                     }
@@ -102,18 +102,18 @@ const schema = {
             properties: {
                 taskName: {
                     type: "string",
-                    description: ( localize(11788, "The task's name"))
+                    description: ( localize(12599, "The task's name"))
                 },
                 command: {
                     type: "string",
                     description: ( localize(
-                        11786,
+                        12597,
                         "The command to be executed. Can be an external program or a shell command."
                     ))
                 },
                 args: {
                     type: "array",
-                    description: ( localize(11787, "Arguments passed to the command when this task is invoked.")),
+                    description: ( localize(12598, "Arguments passed to the command when this task is invoked.")),
                     items: {
                         type: "string"
                     }
@@ -124,13 +124,13 @@ const schema = {
                 windows: {
                     anyOf: [{
                         $ref: "#/definitions/commandConfiguration",
-                        description: ( localize(11789, "Windows specific command configuration"))
+                        description: ( localize(12600, "Windows specific command configuration"))
                     }, {
                         properties: {
                             problemMatcher: {
                                 $ref: "#/definitions/problemMatcherType",
                                 description: ( localize(
-                                    11790,
+                                    12601,
                                     "The problem matcher(s) to use. Can either be a string or a problem matcher definition or an array of strings and problem matchers."
                                 ))
                             }
@@ -140,13 +140,13 @@ const schema = {
                 osx: {
                     anyOf: [{
                         $ref: "#/definitions/commandConfiguration",
-                        description: ( localize(11791, "Mac specific command configuration"))
+                        description: ( localize(12602, "Mac specific command configuration"))
                     }, {
                         properties: {
                             problemMatcher: {
                                 $ref: "#/definitions/problemMatcherType",
                                 description: ( localize(
-                                    11790,
+                                    12601,
                                     "The problem matcher(s) to use. Can either be a string or a problem matcher definition or an array of strings and problem matchers."
                                 ))
                             }
@@ -156,13 +156,13 @@ const schema = {
                 linux: {
                     anyOf: [{
                         $ref: "#/definitions/commandConfiguration",
-                        description: ( localize(11792, "Linux specific command configuration"))
+                        description: ( localize(12603, "Linux specific command configuration"))
                     }, {
                         properties: {
                             problemMatcher: {
                                 $ref: "#/definitions/problemMatcherType",
                                 description: ( localize(
-                                    11790,
+                                    12601,
                                     "The problem matcher(s) to use. Can either be a string or a problem matcher definition or an array of strings and problem matchers."
                                 ))
                             }
@@ -172,7 +172,7 @@ const schema = {
                 suppressTaskName: {
                     type: "boolean",
                     description: ( localize(
-                        11793,
+                        12604,
                         "Controls whether the task name is added as an argument to the command. If omitted the globally defined value is used."
                     )),
                     default: true
@@ -180,23 +180,23 @@ const schema = {
                 showOutput: {
                     $ref: "#/definitions/showOutputType",
                     description: ( localize(
-                        11794,
+                        12605,
                         "Controls whether the output of the running task is shown or not. If omitted the globally defined value is used."
                     ))
                 },
                 echoCommand: {
                     type: "boolean",
                     description: ( localize(
-                        11795,
+                        12606,
                         "Controls whether the executed command is echoed to the output. Default is false."
                     )),
                     default: true
                 },
                 isWatching: {
                     type: "boolean",
-                    deprecationMessage: ( localize(11796, "Deprecated. Use isBackground instead.")),
+                    deprecationMessage: ( localize(12607, "Deprecated. Use isBackground instead.")),
                     description: ( localize(
-                        11797,
+                        12608,
                         "Whether the executed task is kept alive and is watching the file system."
                     )),
                     default: true
@@ -204,7 +204,7 @@ const schema = {
                 isBackground: {
                     type: "boolean",
                     description: ( localize(
-                        11798,
+                        12609,
                         "Whether the executed task is kept alive and is running in the background."
                     )),
                     default: true
@@ -212,25 +212,25 @@ const schema = {
                 promptOnClose: {
                     type: "boolean",
                     description: ( localize(
-                        11799,
+                        12610,
                         "Whether the user is prompted when VS Code closes with a running task."
                     )),
                     default: false
                 },
                 isBuildCommand: {
                     type: "boolean",
-                    description: ( localize(11800, "Maps this task to Code's default build command.")),
+                    description: ( localize(12611, "Maps this task to Code's default build command.")),
                     default: true
                 },
                 isTestCommand: {
                     type: "boolean",
-                    description: ( localize(11801, "Maps this task to Code's default test command.")),
+                    description: ( localize(12612, "Maps this task to Code's default test command.")),
                     default: true
                 },
                 problemMatcher: {
                     $ref: "#/definitions/problemMatcherType",
                     description: ( localize(
-                        11790,
+                        12601,
                         "The problem matcher(s) to use. Can either be a string or a problem matcher definition or an array of strings and problem matchers."
                     ))
                 }
@@ -243,13 +243,13 @@ const schema = {
                 command: {
                     type: "string",
                     description: ( localize(
-                        11786,
+                        12597,
                         "The command to be executed. Can be an external program or a shell command."
                     ))
                 },
                 args: {
                     type: "array",
-                    description: ( localize(11802, "Additional arguments passed to the command.")),
+                    description: ( localize(12613, "Additional arguments passed to the command.")),
                     items: {
                         type: "string"
                     }
@@ -260,15 +260,15 @@ const schema = {
                 showOutput: {
                     $ref: "#/definitions/showOutputType",
                     description: ( localize(
-                        11803,
+                        12614,
                         "Controls whether the output of the running task is shown or not. If omitted 'always' is used."
                     ))
                 },
                 isWatching: {
                     type: "boolean",
-                    deprecationMessage: ( localize(11804, "Deprecated. Use isBackground instead.")),
+                    deprecationMessage: ( localize(12615, "Deprecated. Use isBackground instead.")),
                     description: ( localize(
-                        11805,
+                        12616,
                         "Whether the executed task is kept alive and is watching the file system."
                     )),
                     default: true
@@ -276,7 +276,7 @@ const schema = {
                 isBackground: {
                     type: "boolean",
                     description: ( localize(
-                        11806,
+                        12617,
                         "Whether the executed task is kept alive and is running in the background."
                     )),
                     default: true
@@ -284,7 +284,7 @@ const schema = {
                 promptOnClose: {
                     type: "boolean",
                     description: ( localize(
-                        11807,
+                        12618,
                         "Whether the user is prompted when VS Code closes with a running background task."
                     )),
                     default: false
@@ -292,7 +292,7 @@ const schema = {
                 echoCommand: {
                     type: "boolean",
                     description: ( localize(
-                        11795,
+                        12606,
                         "Controls whether the executed command is echoed to the output. Default is false."
                     )),
                     default: true
@@ -300,26 +300,26 @@ const schema = {
                 suppressTaskName: {
                     type: "boolean",
                     description: ( localize(
-                        11808,
+                        12619,
                         "Controls whether the task name is added as an argument to the command. Default is false."
                     )),
                     default: true
                 },
                 taskSelector: {
                     type: "string",
-                    description: ( localize(11809, "Prefix to indicate that an argument is task."))
+                    description: ( localize(12620, "Prefix to indicate that an argument is task."))
                 },
                 problemMatcher: {
                     $ref: "#/definitions/problemMatcherType",
                     description: ( localize(
-                        11810,
+                        12621,
                         "The problem matcher(s) to use. Can either be a string or a problem matcher definition or an array of strings and problem matchers."
                     ))
                 },
                 tasks: {
                     type: "array",
                     description: ( localize(
-                        11811,
+                        12622,
                         "The task configurations. Usually these are enrichments of task already defined in the external task runner."
                     )),
                     items: {

package/vscode/src/vs/workbench/contrib/tasks/common/jsonSchema_v1.js

@@ -13,32 +13,32 @@ const schema = {
                 version: {
                     type: "string",
                     enum: ["0.1.0"],
-                    deprecationMessage: ( localize(11812, "Task version 0.1.0 is deprecated. Please use 2.0.0")),
-                    description: ( localize(11813, "The config's version number"))
+                    deprecationMessage: ( localize(12623, "Task version 0.1.0 is deprecated. Please use 2.0.0")),
+                    description: ( localize(12624, "The config's version number"))
                 },
                 _runner: {
-                    deprecationMessage: ( localize(11814, "The runner has graduated. Use the official runner property"))
+                    deprecationMessage: ( localize(12625, "The runner has graduated. Use the official runner property"))
                 },
                 runner: {
                     type: "string",
                     enum: ["process", "terminal"],
                     default: "process",
                     description: ( localize(
-                        11815,
+                        12626,
                         "Defines whether the task is executed as a process and the output is shown in the output window or inside the terminal."
                     ))
                 },
                 windows: {
                     $ref: "#/definitions/taskRunnerConfiguration",
-                    description: ( localize(11816, "Windows specific command configuration"))
+                    description: ( localize(12627, "Windows specific command configuration"))
                 },
                 osx: {
                     $ref: "#/definitions/taskRunnerConfiguration",
-                    description: ( localize(11817, "Mac specific command configuration"))
+                    description: ( localize(12628, "Mac specific command configuration"))
                 },
                 linux: {
                     $ref: "#/definitions/taskRunnerConfiguration",
-                    description: ( localize(11818, "Linux specific command configuration"))
+                    description: ( localize(12629, "Linux specific command configuration"))
                 }
             }
         }, {
@@ -50,7 +50,7 @@ const shellCommand = {
     type: "boolean",
     default: true,
     description: ( localize(
-        11819,
+        12630,
         "Specifies whether the command is a shell command or an external program. Defaults to false if omitted."
     ))
 };
@@ -66,7 +66,11 @@ Object.getOwnPropertyNames(definitions).forEach(key => {
 });
 function fixReferences(literal) {
     if (Array.isArray(literal)) {
-        literal.forEach(fixReferences);
+        literal.forEach(element => {
+            if (typeof element === "object" && element !== null) {
+                fixReferences(element);
+            }
+        });
     } else if (typeof literal === "object") {
         if (literal["$ref"]) {
             literal["$ref"] = literal["$ref"] + "1";