@codingame/monaco-vscode-remote-agent-service-override 8.0.4 → 9.0.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codingame/monaco-vscode-remote-agent-service-override",
-  "version": "8.0.4",
+  "version": "9.0.2",
   "keywords": [],
   "author": {
     "name": "CodinGame",
@@ -26,7 +26,7 @@
     }
   },
   "dependencies": {
-    "vscode": "npm:@codingame/monaco-vscode-api@8.0.4",
-    "@codingame/monaco-vscode-environment-service-override": "8.0.4"
+    "vscode": "npm:@codingame/monaco-vscode-api@9.0.2",
+    "@codingame/monaco-vscode-environment-service-override": "9.0.2"
   }
 }

package/remoteAgent.js

@@ -67,7 +67,7 @@ let CustomRemoteExtensionsScannerService = class CustomRemoteExtensionsScannerSe
         if (!this.scanRemoteExtensions) {
             return [];
         }
-        return super.scanExtensions();
+        return await super.scanExtensions();
     }
 };
 CustomRemoteExtensionsScannerService = __decorate([

package/vscode/src/vs/workbench/contrib/remote/browser/explorerViewItems.js

@@ -28,7 +28,7 @@ let SwitchRemoteViewItem = class SwitchRemoteViewItem extends Disposable {
         this.switchRemoteMenu = MenuId.for('workbench.remote.menu.switchRemoteMenu');
         this._register(MenuRegistry.appendMenuItem(MenuId.ViewContainerTitle, {
             submenu: this.switchRemoteMenu,
-            title: ( localize(10854, "Switch Remote")),
+            title: ( localize(10897, "Switch Remote")),
             group: 'navigation',
             when: ( (ContextKeyExpr.equals('viewContainer', VIEWLET_ID))),
             order: 1,

package/vscode/src/vs/workbench/contrib/remote/browser/remote.js

@@ -119,27 +119,27 @@ class HelpModel {
         const getStarted = this.viewModel.helpInformation.filter(info => info.getStarted);
         if (getStarted.length) {
             const helpItemValues = ( (getStarted.map((info) => this.createHelpItemValue(info, 'getStarted'))));
-            const getStartedHelpItem = this.items?.find(item => item.icon === getStartedIcon) ?? ( (new GetStartedHelpItem(getStartedIcon, ( localize(8686, "Get Started")), helpItemValues, this.quickInputService, this.environmentService, this.openerService, this.remoteExplorerService, this.workspaceContextService, this.commandService)));
+            const getStartedHelpItem = this.items?.find(item => item.icon === getStartedIcon) ?? ( (new GetStartedHelpItem(getStartedIcon, ( localize(8737, "Get Started")), helpItemValues, this.quickInputService, this.environmentService, this.openerService, this.remoteExplorerService, this.workspaceContextService, this.commandService)));
             getStartedHelpItem.values = helpItemValues;
             helpItems.push(getStartedHelpItem);
         }
         const documentation = this.viewModel.helpInformation.filter(info => info.documentation);
         if (documentation.length) {
             const helpItemValues = ( (documentation.map((info) => this.createHelpItemValue(info, 'documentation'))));
-            const documentationHelpItem = this.items?.find(item => item.icon === documentationIcon) ?? ( (new HelpItem(documentationIcon, ( localize(8687, "Read Documentation")), helpItemValues, this.quickInputService, this.environmentService, this.openerService, this.remoteExplorerService, this.workspaceContextService)));
+            const documentationHelpItem = this.items?.find(item => item.icon === documentationIcon) ?? ( (new HelpItem(documentationIcon, ( localize(8738, "Read Documentation")), helpItemValues, this.quickInputService, this.environmentService, this.openerService, this.remoteExplorerService, this.workspaceContextService)));
             documentationHelpItem.values = helpItemValues;
             helpItems.push(documentationHelpItem);
         }
         const issues = this.viewModel.helpInformation.filter(info => info.issues);
         if (issues.length) {
             const helpItemValues = ( (issues.map((info) => this.createHelpItemValue(info, 'issues'))));
-            const reviewIssuesHelpItem = this.items?.find(item => item.icon === reviewIssuesIcon) ?? ( (new HelpItem(reviewIssuesIcon, ( localize(8688, "Review Issues")), helpItemValues, this.quickInputService, this.environmentService, this.openerService, this.remoteExplorerService, this.workspaceContextService)));
+            const reviewIssuesHelpItem = this.items?.find(item => item.icon === reviewIssuesIcon) ?? ( (new HelpItem(reviewIssuesIcon, ( localize(8739, "Review Issues")), helpItemValues, this.quickInputService, this.environmentService, this.openerService, this.remoteExplorerService, this.workspaceContextService)));
             reviewIssuesHelpItem.values = helpItemValues;
             helpItems.push(reviewIssuesHelpItem);
         }
         if (helpItems.length) {
             const helpItemValues = ( (this.viewModel.helpInformation.map(info => this.createHelpItemValue(info, 'reportIssue'))));
-            const issueReporterItem = this.items?.find(item => item.icon === reportIssuesIcon) ?? ( (new IssueReporterItem(reportIssuesIcon, ( localize(8689, "Report Issue")), helpItemValues, this.quickInputService, this.environmentService, this.commandService, this.openerService, this.remoteExplorerService, this.workspaceContextService)));
+            const issueReporterItem = this.items?.find(item => item.icon === reportIssuesIcon) ?? ( (new IssueReporterItem(reportIssuesIcon, ( localize(8740, "Report Issue")), helpItemValues, this.quickInputService, this.environmentService, this.commandService, this.openerService, this.remoteExplorerService, this.workspaceContextService)));
             issueReporterItem.values = helpItemValues;
             helpItems.push(issueReporterItem);
         }
@@ -256,7 +256,7 @@ class HelpItemBase {
         if (this.values.length > 1) {
             const actions = await this.getActions();
             if (actions.length) {
-                const action = await this.quickInputService.pick(actions, { placeHolder: ( localize(8690, "Select url to open")) });
+                const action = await this.quickInputService.pick(actions, { placeHolder: ( localize(8741, "Select url to open")) });
                 if (action) {
                     await this.takeAction(action.extensionDescription, action.url);
                 }
@@ -317,7 +317,7 @@ class IssueReporterItem extends HelpItemBase {
 }
 let HelpPanel = class HelpPanel extends ViewPane {
     static { this.ID = '~remote.helpPanel'; }
-    static { this.TITLE = ( localize2(8691, "Help and feedback")); }
+    static { this.TITLE = ( localize2(8742, "Help and feedback")); }
     constructor(viewModel, options, keybindingService, contextMenuService, contextKeyService, configurationService, instantiationService, viewDescriptorService, openerService, quickInputService, commandService, remoteExplorerService, environmentService, themeService, telemetryService, hoverService, workspaceContextService, walkthroughsService) {
         super(options, keybindingService, contextMenuService, configurationService, contextKeyService, viewDescriptorService, instantiationService, openerService, themeService, telemetryService, hoverService);
         this.viewModel = viewModel;
@@ -339,7 +339,7 @@ let HelpPanel = class HelpPanel extends ViewPane {
                 getAriaLabel: (item) => {
                     return item.label;
                 },
-                getWidgetAriaLabel: () => ( localize(8692, "Remote Help"))
+                getWidgetAriaLabel: () => ( localize(8743, "Remote Help"))
             }
         });
         const model = ( (new HelpModel(
@@ -469,7 +469,7 @@ let RemoteViewPaneContainer = class RemoteViewPaneContainer extends FilterViewPa
         this.remoteExplorerService.targetType = isStringArray(viewDescriptor.remoteAuthority) ? viewDescriptor.remoteAuthority : [viewDescriptor.remoteAuthority];
     }
     getTitle() {
-        const title = ( localize(8693, "Remote Explorer"));
+        const title = ( localize(8744, "Remote Explorer"));
         return title;
     }
 };
@@ -488,7 +488,7 @@ RemoteViewPaneContainer = ( (__decorate([
 ], RemoteViewPaneContainer)));
 ( (Registry.as(Extensions.ViewContainersRegistry))).registerViewContainer({
     id: VIEWLET_ID,
-    title: ( localize2(8693, "Remote Explorer")),
+    title: ( localize2(8744, "Remote Explorer")),
     ctorDescriptor: ( (new SyncDescriptor(RemoteViewPaneContainer))),
     hideIfEmpty: true,
     viewOrderDelegate: {
@@ -594,10 +594,10 @@ class ReconnectionTimer {
         }
         const remainingTime = Math.ceil(remainingTimeMs / 1000);
         if (remainingTime === 1) {
-            this._parent.report(( localize(8694, "Attempting to reconnect in {0} second...", remainingTime)));
+            this._parent.report(( localize(8745, "Attempting to reconnect in {0} second...", remainingTime)));
         }
         else {
-            this._parent.report(( localize(8695, "Attempting to reconnect in {0} seconds...", remainingTime)));
+            this._parent.report(( localize(8746, "Attempting to reconnect in {0} seconds...", remainingTime)));
         }
     }
 }
@@ -609,8 +609,8 @@ let RemoteAgentConnectionStatusListener = class RemoteAgentConnectionStatusListe
         const connection = remoteAgentService.getConnection();
         if (connection) {
             let quickInputVisible = false;
-            quickInputService.onShow(() => quickInputVisible = true);
-            quickInputService.onHide(() => quickInputVisible = false);
+            this._register(quickInputService.onShow(() => quickInputVisible = true));
+            this._register(quickInputService.onHide(() => quickInputVisible = false));
             let visibleProgress = null;
             let reconnectWaitEvent = null;
             let disposableListener = null;
@@ -654,13 +654,13 @@ let RemoteAgentConnectionStatusListener = class RemoteAgentConnectionStatusListe
             let lastIncomingDataTime = 0;
             let reconnectionAttempts = 0;
             const reconnectButton = {
-                label: ( localize(8696, "Reconnect Now")),
+                label: ( localize(8747, "Reconnect Now")),
                 callback: () => {
                     reconnectWaitEvent?.skipWait();
                 }
             };
             const reloadButton = {
-                label: ( localize(8697, "Reload Window")),
+                label: ( localize(8748, "Reload Window")),
                 callback: () => {
                     telemetryService.publicLog2('remoteReconnectionReload', {
                         remoteName: getRemoteName(environmentService.remoteAuthority),
@@ -690,7 +690,7 @@ let RemoteAgentConnectionStatusListener = class RemoteAgentConnectionStatusListe
                             if (!visibleProgress) {
                                 visibleProgress = showProgress(null, [reconnectButton, reloadButton]);
                             }
-                            visibleProgress.report(( localize(8698, "Connection Lost")));
+                            visibleProgress.report(( localize(8749, "Connection Lost")));
                         }
                         break;
                     case PersistentConnectionEventType.ReconnectionWait:
@@ -712,7 +712,7 @@ let RemoteAgentConnectionStatusListener = class RemoteAgentConnectionStatusListe
                         });
                         if (visibleProgress || e.millisSinceLastIncomingData > DISCONNECT_PROMPT_TIME) {
                             visibleProgress = showProgress(null, [reloadButton]);
-                            visibleProgress.report(( localize(8699, "Disconnected. Attempting to reconnect...")));
+                            visibleProgress.report(( localize(8750, "Disconnected. Attempting to reconnect...")));
                             disposableListener = quickInputService.onShow(() => {
                                 if (visibleProgress && visibleProgress.location === ProgressLocation.Dialog) {
                                     visibleProgress = showProgress(ProgressLocation.Notification, [reloadButton], visibleProgress.lastReport);
@@ -740,8 +740,8 @@ let RemoteAgentConnectionStatusListener = class RemoteAgentConnectionStatusListe
                             this._reloadWindowShown = true;
                             dialogService.confirm({
                                 type: Severity$1.Error,
-                                message: ( localize(8700, "Cannot reconnect. Please reload the window.")),
-                                primaryButton: ( localize(8701, "&&Reload Window"))
+                                message: ( localize(8751, "Cannot reconnect. Please reload the window.")),
+                                primaryButton: ( localize(8752, "&&Reload Window"))
                             }).then(result => {
                                 if (result.confirmed) {
                                     commandService.executeCommand(ReloadWindowAction.ID);

package/vscode/src/vs/workbench/contrib/remote/browser/remoteConnectionHealth.js

@@ -43,17 +43,17 @@ let InitialRemoteConnectionHealthContribution = class InitialRemoteConnectionHea
         const { result, checkboxChecked } = await this.dialogService.prompt({
             type: Severity$1.Warning,
             message: ( localize(
-                8741,
+                8792,
                 "You are about to connect to an OS version that is unsupported by {0}.",
                 this.productService.nameLong
             )),
             buttons: [
                 {
-                    label: ( localize(8742, "&&Allow")),
+                    label: ( localize(8793, "&&Allow")),
                     run: () => ConnectionChoice.Allow
                 },
                 {
-                    label: ( localize(8743, "&&Learn More")),
+                    label: ( localize(8794, "&&Learn More")),
                     run: async () => { await this.openerService.open('https://aka.ms/vscode-remote/faq/old-linux'); return ConnectionChoice.LearnMore; }
                 }
             ],
@@ -61,7 +61,7 @@ let InitialRemoteConnectionHealthContribution = class InitialRemoteConnectionHea
                 run: () => ConnectionChoice.Cancel
             },
             checkbox: {
-                label: ( localize(8744, "Do not show again")),
+                label: ( localize(8795, "Do not show again")),
             }
         });
         if (result === ConnectionChoice.LearnMore) {
@@ -87,14 +87,14 @@ let InitialRemoteConnectionHealthContribution = class InitialRemoteConnectionHea
                     if (shouldShowBanner) {
                         const actions = [
                             {
-                                label: ( localize(8745, "Learn More")),
+                                label: ( localize(8796, "Learn More")),
                                 href: 'https://aka.ms/vscode-remote/faq/old-linux'
                             }
                         ];
                         this.bannerService.show({
                             id: 'unsupportedGlibcWarning.banner',
                             message: ( localize(
-                                8746,
+                                8797,
                                 "You are connected to an OS version that is unsupported by {0}.",
                                 this.productService.nameLong
                             )),

package/vscode/src/vs/workbench/contrib/remote/browser/remoteIndicator.js

@@ -4,7 +4,7 @@ import { remoteConnectionLatencyMeasurer } from '../../../services/remote/common
 import { IRemoteAgentService } from 'vscode/vscode/vs/workbench/services/remote/common/remoteAgentService.service';
 import { RunOnceScheduler, retry } from 'vscode/vscode/vs/base/common/async';
 import { Emitter, Event } from 'vscode/vscode/vs/base/common/event';
-import { Disposable } from 'vscode/vscode/vs/base/common/lifecycle';
+import { Disposable, DisposableStore } from 'vscode/vscode/vs/base/common/lifecycle';
 import { MenuId, registerAction2, Action2, MenuRegistry, MenuItemAction } from 'vscode/vscode/vs/platform/actions/common/actions';
 import { IMenuService } from 'vscode/vscode/vs/platform/actions/common/actions.service';
 import { StatusbarAlignment } from 'vscode/vscode/vs/workbench/services/statusbar/browser/statusbar';
@@ -132,14 +132,14 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
         this.updateRemoteStatusIndicator();
     }
     registerActions() {
-        const category = ( localize2(8702, "Remote"));
+        const category = ( localize2(8753, "Remote"));
         const that = this;
         this._register(registerAction2(class extends Action2 {
             constructor() {
                 super({
                     id: RemoteStatusIndicator_1.REMOTE_ACTIONS_COMMAND_ID,
                     category,
-                    title: ( localize2(8703, "Show Remote Menu")),
+                    title: ( localize2(8754, "Show Remote Menu")),
                     f1: true,
                     keybinding: {
                         weight: KeybindingWeight.WorkbenchContrib,
@@ -155,7 +155,7 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
                     super({
                         id: RemoteStatusIndicator_1.CLOSE_REMOTE_COMMAND_ID,
                         category,
-                        title: ( localize2(8704, "Close Remote Connection")),
+                        title: ( localize2(8755, "Close Remote Connection")),
                         f1: true,
                         precondition: ( (ContextKeyExpr.or(RemoteNameContext, VirtualWorkspaceContext)))
                     });
@@ -167,7 +167,7 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
                     group: '6_close',
                     command: {
                         id: RemoteStatusIndicator_1.CLOSE_REMOTE_COMMAND_ID,
-                        title: ( localize(8705, "Close Re&&mote Connection"))
+                        title: ( localize(8756, "Close Re&&mote Connection"))
                     },
                     order: 3.5
                 });
@@ -179,7 +179,7 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
                     super({
                         id: RemoteStatusIndicator_1.INSTALL_REMOTE_EXTENSIONS_ID,
                         category,
-                        title: ( localize2(8706, "Install Remote Development Extensions")),
+                        title: ( localize2(8757, "Install Remote Development Extensions")),
                         f1: true
                     });
                     this.run = (accessor, input) => {
@@ -392,18 +392,18 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
             const hostLabel = this.labelService.getHostLabel(Schemas.vscodeRemote, this.remoteAuthority) || this.remoteAuthority;
             switch (this.connectionState) {
                 case 'initializing':
-                    this.renderRemoteStatusIndicator(( localize(8707, "Opening Remote...")), ( localize(8707, "Opening Remote...")), undefined, true );
+                    this.renderRemoteStatusIndicator(( localize(8758, "Opening Remote...")), ( localize(8758, "Opening Remote...")), undefined, true );
                     break;
                 case 'reconnecting':
                     this.renderRemoteStatusIndicator(`${( localize(
-                        8708,
+                        8759,
                         "Reconnecting to {0}...",
                         truncate(hostLabel, RemoteStatusIndicator_1.REMOTE_STATUS_LABEL_MAX_LENGTH)
                     ))}`, undefined, undefined, true );
                     break;
                 case 'disconnected':
                     this.renderRemoteStatusIndicator(`$(alert) ${( localize(
-                        8709,
+                        8760,
                         "Disconnected from {0}",
                         truncate(hostLabel, RemoteStatusIndicator_1.REMOTE_STATUS_LABEL_MAX_LENGTH)
                     ))}`);
@@ -415,7 +415,7 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
                         tooltip.appendMarkdown(hostNameTooltip);
                     }
                     else {
-                        tooltip.appendText(( localize(8710, "Editing on {0}", hostLabel)));
+                        tooltip.appendText(( localize(8761, "Editing on {0}", hostLabel)));
                     }
                     this.renderRemoteStatusIndicator(`$(remote) ${truncate(hostLabel, RemoteStatusIndicator_1.REMOTE_STATUS_LABEL_MAX_LENGTH)}`, tooltip);
                 }
@@ -431,12 +431,12 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
                     tooltip.appendMarkdown(hostNameTooltip);
                 }
                 else {
-                    tooltip.appendText(( localize(8711, "Editing on {0}", workspaceLabel)));
+                    tooltip.appendText(( localize(8762, "Editing on {0}", workspaceLabel)));
                 }
                 if (!isWeb || this.remoteAuthority) {
                     tooltip.appendMarkdown('\n\n');
                     tooltip.appendMarkdown(( localize(
-                        8712,
+                        8763,
                         "Some [features are not available]({0}) for resources located on a virtual file system.",
                         `command:${LIST_WORKSPACE_UNSUPPORTED_EXTENSIONS_COMMAND_ID}`
                     )));
@@ -445,13 +445,13 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
                 return;
             }
         }
-        this.renderRemoteStatusIndicator(`$(remote)`, ( localize(8713, "Open a Remote Window")));
+        this.renderRemoteStatusIndicator(`$(remote)`, ( localize(8764, "Open a Remote Window")));
         return;
     }
     renderRemoteStatusIndicator(initialText, initialTooltip, command, showProgress) {
         const { text, tooltip, ariaLabel } = this.withNetworkStatus(initialText, initialTooltip, showProgress);
         const properties = {
-            name: ( localize(8714, "Remote Host")),
+            name: ( localize(8765, "Remote Host")),
             kind: this.networkState === 'offline' ? 'offline' : 'remote',
             ariaLabel,
             text,
@@ -479,7 +479,7 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
         switch (this.networkState) {
             case 'offline': {
                 const offlineMessage = ( localize(
-                    8715,
+                    8766,
                     "Network appears to be offline, certain features might be unavailable."
                 ));
                 text = textWithAlert();
@@ -490,7 +490,7 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
             case 'high-latency':
                 text = textWithAlert();
                 tooltip = this.appendTooltipLine(tooltip, ( localize(
-                    8716,
+                    8767,
                     "Network appears to have high latency ({0}ms last, {1}ms average), certain features may be slow to respond.",
                     remoteConnectionLatencyMeasurer.latency?.current?.toFixed(2),
                     remoteConnectionLatencyMeasurer.latency?.average?.toFixed(2)
@@ -606,13 +606,13 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
                         const label = metadata.startConnectLabel;
                         const buttons = [{
                                 iconClass: ThemeIcon.asClassName(infoIcon),
-                                tooltip: ( localize(8717, "Learn More"))
+                                tooltip: ( localize(8768, "Learn More"))
                             }];
                         notInstalledItems.push({ type: 'item', id: metadata.id, label: label, buttons: buttons });
                     }
                 }
                 items.push({
-                    type: 'separator', label: ( localize(8718, 'Install'))
+                    type: 'separator', label: ( localize(8769, 'Install'))
                 });
                 items.push(...notInstalledItems);
             }
@@ -625,13 +625,13 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
                     items.push({
                         type: 'item',
                         id: RemoteStatusIndicator_1.CLOSE_REMOTE_COMMAND_ID,
-                        label: ( localize(8719, 'Close Remote Connection'))
+                        label: ( localize(8770, 'Close Remote Connection'))
                     });
                     if (this.connectionState === 'disconnected') {
                         items.push({
                             type: 'item',
                             id: ReloadWindowAction.ID,
-                            label: ( localize(8720, 'Reload Window'))
+                            label: ( localize(8771, 'Reload Window'))
                         });
                     }
                 }
@@ -639,7 +639,7 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
                     items.push({
                         type: 'item',
                         id: RemoteStatusIndicator_1.CLOSE_REMOTE_COMMAND_ID,
-                        label: ( localize(8721, 'Close Remote Workspace'))
+                        label: ( localize(8772, 'Close Remote Workspace'))
                     });
                 }
             }
@@ -648,12 +648,13 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
             }
             return items;
         };
-        const quickPick = this.quickInputService.createQuickPick();
-        quickPick.placeholder = ( localize(8722, "Select an option to open a Remote Window"));
+        const disposables = ( (new DisposableStore()));
+        const quickPick = disposables.add(this.quickInputService.createQuickPick({ useSeparators: true }));
+        quickPick.placeholder = ( localize(8773, "Select an option to open a Remote Window"));
         quickPick.items = computeItems();
         quickPick.sortByLabel = false;
         quickPick.canSelectMany = false;
-        Event.once(quickPick.onDidAccept)((async (_) => {
+        disposables.add(Event.once(quickPick.onDidAccept)((async (_) => {
             const selectedItems = quickPick.selectedItems;
             if (selectedItems.length === 1) {
                 const commandId = selectedItems[0].id;
@@ -661,7 +662,7 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
                 if (remoteExtension) {
                     quickPick.items = [];
                     quickPick.busy = true;
-                    quickPick.placeholder = ( localize(8723, 'Installing extension... '));
+                    quickPick.placeholder = ( localize(8774, 'Installing extension... '));
                     await this.installExtension(remoteExtension.id);
                     quickPick.hide();
                     await this.runRemoteStartCommand(remoteExtension.id, remoteExtension.startCommand);
@@ -675,17 +676,16 @@ let RemoteStatusIndicator = class RemoteStatusIndicator extends Disposable {
                     quickPick.hide();
                 }
             }
-        }));
-        Event.once(quickPick.onDidTriggerItemButton)(async (e) => {
+        })));
+        disposables.add(Event.once(quickPick.onDidTriggerItemButton)(async (e) => {
             const remoteExtension = this.remoteExtensionMetadata.find(value => ExtensionIdentifier.equals(value.id, e.item.id));
             if (remoteExtension) {
                 await this.openerService.open(( (URI.parse(remoteExtension.helpLink))));
             }
-        });
-        const legacyItemUpdater = this.legacyIndicatorMenu.onDidChange(() => quickPick.items = computeItems());
-        quickPick.onDidHide(legacyItemUpdater.dispose);
-        const itemUpdater = this.remoteIndicatorMenu.onDidChange(() => quickPick.items = computeItems());
-        quickPick.onDidHide(itemUpdater.dispose);
+        }));
+        disposables.add(this.legacyIndicatorMenu.onDidChange(() => quickPick.items = computeItems()));
+        disposables.add(this.remoteIndicatorMenu.onDidChange(() => quickPick.items = computeItems()));
+        disposables.add(quickPick.onDidHide(() => disposables.dispose()));
         if (!this.remoteMetadataInitialized) {
             quickPick.busy = true;
             this._register(this.onDidChangeEntries(() => {
@@ -724,7 +724,7 @@ RemoteStatusIndicator = RemoteStatusIndicator_1 = ( (__decorate([
         'workbench.remoteIndicator.showExtensionRecommendations': {
             type: 'boolean',
             markdownDescription: ( localize(
-                8724,
+                8775,
                 "When enabled, remote extensions recommendations will be shown in the Remote Indicator menu."
             )),
             default: true

package/vscode/src/vs/workbench/contrib/remote/browser/remoteStartEntry.js

@@ -32,14 +32,14 @@ let RemoteStartEntry = class RemoteStartEntry extends Disposable {
         this.registerListeners();
     }
     registerActions() {
-        const category = ( localize2(8747, "Remote"));
+        const category = ( localize2(8798, "Remote"));
         const startEntry = this;
         this._register(registerAction2(class extends Action2 {
             constructor() {
                 super({
                     id: RemoteStartEntry_1.REMOTE_WEB_START_ENTRY_ACTIONS_COMMAND_ID,
                     category,
-                    title: ( localize2(8748, "Show Remote Start Entry for web")),
+                    title: ( localize2(8799, "Show Remote Start Entry for web")),
                     f1: false
                 });
             }

package/vscode/src/vs/workbench/contrib/remote/browser/tunnelFactory.js

@@ -25,12 +25,12 @@ let TunnelFactoryContribution = class TunnelFactoryContribution extends Disposab
                 privacyOptions = [
                     {
                         id: 'private',
-                        label: ( localize(8684, "Private")),
+                        label: ( localize(8735, "Private")),
                         themeIcon: 'lock'
                     },
                     {
                         id: 'public',
-                        label: ( localize(8685, "Public")),
+                        label: ( localize(8736, "Public")),
                         themeIcon: 'eye'
                     }
                 ];

package/vscode/src/vs/workbench/contrib/remote/common/remote.contribution.js

@@ -100,9 +100,9 @@ let RemoteInvalidWorkspaceDetector = class RemoteInvalidWorkspaceDetector extend
         }
         const res = await this.dialogService.confirm({
             type: 'warning',
-            message: ( localize(3569, "Workspace does not exist")),
-            detail: ( localize(3570, "Please select another workspace to open.")),
-            primaryButton: ( localize(3571, "&&Open Workspace..."))
+            message: ( localize(3567, "Workspace does not exist")),
+            detail: ( localize(3568, "Please select another workspace to open.")),
+            primaryButton: ( localize(3569, "&&Open Workspace..."))
         });
         if (res.confirmed) {
             if (workspace.configuration) {
@@ -129,7 +129,7 @@ registerWorkbenchContribution2(RemoteInvalidWorkspaceDetector.ID, RemoteInvalidW
         constructor() {
             super({
                 id: 'workbench.action.triggerReconnect',
-                title: ( localize2(3572, 'Connection: Trigger Reconnect')),
+                title: ( localize2(3570, 'Connection: Trigger Reconnect')),
                 category: Categories.Developer,
                 f1: true,
             });
@@ -142,7 +142,7 @@ registerWorkbenchContribution2(RemoteInvalidWorkspaceDetector.ID, RemoteInvalidW
         constructor() {
             super({
                 id: 'workbench.action.pauseSocketWriting',
-                title: ( localize2(3573, 'Connection: Pause socket writing')),
+                title: ( localize2(3571, 'Connection: Pause socket writing')),
                 category: Categories.Developer,
                 f1: true,
             });
@@ -162,11 +162,11 @@ const extensionKindSchema = {
     ],
     enumDescriptions: [
         ( localize(
-            3574,
+            3572,
             "UI extension kind. In a remote window, such extensions are enabled only when available on the local machine."
         )),
         ( localize(
-            3575,
+            3573,
             "Workspace extension kind. In a remote window, such extensions are enabled only when available on the remote."
         ))
     ],
@@ -174,13 +174,13 @@ const extensionKindSchema = {
 ( (Registry.as(Extensions$1.Configuration)))
     .registerConfiguration({
     id: 'remote',
-    title: ( localize(3576, "Remote")),
+    title: ( localize(3574, "Remote")),
     type: 'object',
     properties: {
         'remote.extensionKind': {
             type: 'object',
             markdownDescription: ( localize(
-                3577,
+                3575,
                 "Override the kind of an extension. `ui` extensions are installed and run on the local machine while `workspace` extensions are run on the remote. By overriding an extension's default kind using this setting, you specify if that extension should be installed and enabled locally or remotely."
             )),
             patternProperties: {
@@ -195,13 +195,13 @@ const extensionKindSchema = {
         },
         'remote.restoreForwardedPorts': {
             type: 'boolean',
-            markdownDescription: ( localize(3578, "Restores the ports you forwarded in a workspace.")),
+            markdownDescription: ( localize(3576, "Restores the ports you forwarded in a workspace.")),
             default: true
         },
         'remote.autoForwardPorts': {
             type: 'boolean',
             markdownDescription: ( localize(
-                3579,
+                3577,
                 "When enabled, new running processes are detected and ports that they listen on are automatically forwarded. Disabling this setting will not prevent all ports from being forwarded. Even when disabled, extensions will still be able to cause ports to be forwarded, and opening some URLs will still cause ports to forwarded."
             )),
             default: true
@@ -209,22 +209,22 @@ const extensionKindSchema = {
         'remote.autoForwardPortsSource': {
             type: 'string',
             markdownDescription: ( localize(
-                3580,
+                3578,
                 "Sets the source from which ports are automatically forwarded when {0} is true. On Windows and macOS remotes, the `process` and `hybrid` options have no effect and `output` will be used.",
                 '`#remote.autoForwardPorts#`'
             )),
             enum: ['process', 'output', 'hybrid'],
             enumDescriptions: [
                 ( localize(
-                    3581,
+                    3579,
                     "Ports will be automatically forwarded when discovered by watching for processes that are started and include a port."
                 )),
                 ( localize(
-                    3582,
+                    3580,
                     "Ports will be automatically forwarded when discovered by reading terminal and debug output. Not all processes that use ports will print to the integrated terminal or debug console, so some ports will be missed. Ports forwarded based on output will not be \"un-forwarded\" until reload or until the port is closed by the user in the Ports view."
                 )),
                 ( localize(
-                    3583,
+                    3581,
                     "Ports will be automatically forwarded when discovered by reading terminal and debug output. Not all processes that use ports will print to the integrated terminal or debug console, so some ports will be missed. Ports will be \"un-forwarded\" by watching for processes that listen on that port to be terminated."
                 ))
             ],
@@ -234,14 +234,14 @@ const extensionKindSchema = {
             type: 'number',
             default: 20,
             markdownDescription: ( localize(
-                3584,
+                3582,
                 "The number of auto forwarded ports that will trigger the switch from `process` to `hybrid` when automatically forwarding ports and `remote.autoForwardPortsSource` is set to `process` by default. Set to `0` to disable the fallback. When `remote.autoForwardPortsFallback` hasn't been configured, but `remote.autoForwardPortsSource` has, `remote.autoForwardPortsFallback` will be treated as though it's set to `0`."
             ))
         },
         'remote.forwardOnOpen': {
             type: 'boolean',
             description: ( localize(
-                3585,
+                3583,
                 "Controls whether local URLs with a port will be forwarded when opened from the terminal and the debug console."
             )),
             default: true
@@ -252,7 +252,7 @@ const extensionKindSchema = {
                 '(^\\d+(-\\d+)?$)|(.+)': {
                     type: 'object',
                     description: ( localize(
-                        3586,
+                        3584,
                         "A port, range of ports (ex. \"40000-55000\"), host and port (ex. \"db:1234\"), or regular expression (ex. \".+\\\\/server.js\").  For a port number or range, the attributes will apply to that port number or range of port numbers. Attributes which use a regular expression will apply to ports whose associated process command line matches the expression."
                     )),
                     properties: {
@@ -260,27 +260,27 @@ const extensionKindSchema = {
                             type: 'string',
                             enum: ['notify', 'openBrowser', 'openBrowserOnce', 'openPreview', 'silent', 'ignore'],
                             enumDescriptions: [
-                                ( localize(3587, "Shows a notification when a port is automatically forwarded.")),
+                                ( localize(3585, "Shows a notification when a port is automatically forwarded.")),
                                 ( localize(
-                                    3588,
+                                    3586,
                                     "Opens the browser when the port is automatically forwarded. Depending on your settings, this could open an embedded browser."
                                 )),
                                 ( localize(
-                                    3589,
+                                    3587,
                                     "Opens the browser when the port is automatically forwarded, but only the first time the port is forward during a session. Depending on your settings, this could open an embedded browser."
                                 )),
                                 ( localize(
-                                    3590,
+                                    3588,
                                     "Opens a preview in the same window when the port is automatically forwarded."
                                 )),
                                 ( localize(
-                                    3591,
+                                    3589,
                                     "Shows no notification and takes no action when this port is automatically forwarded."
                                 )),
-                                ( localize(3592, "This port will not be automatically forwarded."))
+                                ( localize(3590, "This port will not be automatically forwarded."))
                             ],
                             description: ( localize(
-                                3593,
+                                3591,
                                 "Defines the action that occurs when the port is discovered for automatic forwarding"
                             )),
                             default: 'notify'
@@ -288,20 +288,20 @@ const extensionKindSchema = {
                         'elevateIfNeeded': {
                             type: 'boolean',
                             description: ( localize(
-                                3594,
+                                3592,
                                 "Automatically prompt for elevation (if needed) when this port is forwarded. Elevate is required if the local port is a privileged port."
                             )),
                             default: false
                         },
                         'label': {
                             type: 'string',
-                            description: ( localize(3595, "Label that will be shown in the UI for this port.")),
-                            default: ( localize(3596, "Application"))
+                            description: ( localize(3593, "Label that will be shown in the UI for this port.")),
+                            default: ( localize(3594, "Application"))
                         },
                         'requireLocalPort': {
                             type: 'boolean',
                             markdownDescription: ( localize(
-                                3597,
+                                3595,
                                 "When true, a modal dialog will show if the chosen local port isn't used for forwarding."
                             )),
                             default: false
@@ -309,22 +309,22 @@ const extensionKindSchema = {
                         'protocol': {
                             type: 'string',
                             enum: ['http', 'https'],
-                            description: ( localize(3598, "The protocol to use when forwarding this port."))
+                            description: ( localize(3596, "The protocol to use when forwarding this port."))
                         }
                     },
                     default: {
-                        'label': ( localize(3596, "Application")),
+                        'label': ( localize(3594, "Application")),
                         'onAutoForward': 'notify'
                     }
                 }
             },
             markdownDescription: ( localize(
-                3599,
+                3597,
                 "Set properties that are applied when a specific port number is forwarded. For example:\n\n```\n\"3000\": {\n  \"label\": \"Application\"\n},\n\"40000-55000\": {\n  \"onAutoForward\": \"ignore\"\n},\n\".+\\\\/server.js\": {\n \"onAutoForward\": \"openPreview\"\n}\n```"
             )),
             defaultSnippets: [{ body: { '${1:3000}': { label: '${2:Application}', onAutoForward: 'openPreview' } } }],
             errorMessage: ( localize(
-                3600,
+                3598,
                 "Must be a port number, range of port numbers, or regular expression."
             )),
             additionalProperties: false,
@@ -344,23 +344,23 @@ const extensionKindSchema = {
                     type: 'string',
                     enum: ['notify', 'openBrowser', 'openPreview', 'silent', 'ignore'],
                     enumDescriptions: [
-                        ( localize(3587, "Shows a notification when a port is automatically forwarded.")),
+                        ( localize(3585, "Shows a notification when a port is automatically forwarded.")),
                         ( localize(
-                            3588,
+                            3586,
                             "Opens the browser when the port is automatically forwarded. Depending on your settings, this could open an embedded browser."
                         )),
                         ( localize(
-                            3590,
+                            3588,
                             "Opens a preview in the same window when the port is automatically forwarded."
                         )),
                         ( localize(
-                            3591,
+                            3589,
                             "Shows no notification and takes no action when this port is automatically forwarded."
                         )),
-                        ( localize(3592, "This port will not be automatically forwarded."))
+                        ( localize(3590, "This port will not be automatically forwarded."))
                     ],
                     description: ( localize(
-                        3593,
+                        3591,
                         "Defines the action that occurs when the port is discovered for automatic forwarding"
                     )),
                     default: 'notify'
@@ -368,20 +368,20 @@ const extensionKindSchema = {
                 'elevateIfNeeded': {
                     type: 'boolean',
                     description: ( localize(
-                        3594,
+                        3592,
                         "Automatically prompt for elevation (if needed) when this port is forwarded. Elevate is required if the local port is a privileged port."
                     )),
                     default: false
                 },
                 'label': {
                     type: 'string',
-                    description: ( localize(3595, "Label that will be shown in the UI for this port.")),
-                    default: ( localize(3596, "Application"))
+                    description: ( localize(3593, "Label that will be shown in the UI for this port.")),
+                    default: ( localize(3594, "Application"))
                 },
                 'requireLocalPort': {
                     type: 'boolean',
                     markdownDescription: ( localize(
-                        3597,
+                        3595,
                         "When true, a modal dialog will show if the chosen local port isn't used for forwarding."
                     )),
                     default: false
@@ -389,12 +389,12 @@ const extensionKindSchema = {
                 'protocol': {
                     type: 'string',
                     enum: ['http', 'https'],
-                    description: ( localize(3598, "The protocol to use when forwarding this port."))
+                    description: ( localize(3596, "The protocol to use when forwarding this port."))
                 }
             },
             defaultSnippets: [{ body: { onAutoForward: 'ignore' } }],
             markdownDescription: ( localize(
-                3601,
+                3599,
                 "Set default properties that are applied to all ports that don't get properties from the setting {0}. For example:\n\n```\n{\n  \"onAutoForward\": \"ignore\"\n}\n```",
                 '`#remote.portsAttributes#`'
             )),
@@ -405,7 +405,7 @@ const extensionKindSchema = {
             enum: ['localhost', 'allInterfaces'],
             default: 'localhost',
             description: ( localize(
-                3602,
+                3600,
                 "Specifies the local host name that will be used for port forwarding."
             ))
         }

package/vscode/src/vs/workbench/services/remote/browser/remoteAgentService.js

@@ -45,15 +45,15 @@ let RemoteConnectionFailureNotificationContribution = class RemoteConnectionFail
     async _presentConnectionError(err) {
         await this._dialogService.prompt({
             type: Severity$1.Error,
-            message: ( localize(3554, "An unexpected error occurred that requires a reload of this page.")),
+            message: ( localize(3552, "An unexpected error occurred that requires a reload of this page.")),
             detail: ( localize(
-                3555,
+                3553,
                 "The workbench failed to connect to the server (Error: {0})",
                 err ? err.message : ''
             )),
             buttons: [
                 {
-                    label: ( localize(3556, "&&Reload")),
+                    label: ( localize(3554, "&&Reload")),
                     run: () => this._hostService.reload()
                 }
             ]

package/vscode/src/vs/workbench/services/remote/common/abstractRemoteAgentService.js

@@ -1,16 +1,16 @@
 import { __decorate, __param } from 'vscode/external/tslib/tslib.es6.js';
-import { Emitter } from 'vscode/vscode/vs/base/common/event';
 import { Disposable } from 'vscode/vscode/vs/base/common/lifecycle';
 import { getDelayedChannel } from 'vscode/vscode/vs/base/parts/ipc/common/ipc';
-import { ILogService } from 'vscode/vscode/vs/platform/log/common/log.service';
-import { IProductService } from 'vscode/vscode/vs/platform/product/common/productService.service';
+import { IWorkbenchEnvironmentService } from 'vscode/vscode/vs/workbench/services/environment/common/environmentService.service';
 import { connectRemoteAgentManagement } from 'vscode/vscode/vs/platform/remote/common/remoteAgentConnection';
 import { IRemoteAuthorityResolverService } from 'vscode/vscode/vs/platform/remote/common/remoteAuthorityResolver.service';
-import { IRemoteSocketFactoryService } from 'vscode/vscode/vs/platform/remote/common/remoteSocketFactoryService.service';
-import { ISignService } from 'vscode/vscode/vs/platform/sign/common/sign.service';
-import { IWorkbenchEnvironmentService } from 'vscode/vscode/vs/workbench/services/environment/common/environmentService.service';
 import { RemoteExtensionEnvironmentChannelClient } from './remoteAgentEnvironmentChannel.js';
+import { Emitter } from 'vscode/vscode/vs/base/common/event';
+import { ISignService } from 'vscode/vscode/vs/platform/sign/common/sign.service';
+import { ILogService } from 'vscode/vscode/vs/platform/log/common/log.service';
+import { IProductService } from 'vscode/vscode/vs/platform/product/common/productService.service';
 import { IUserDataProfileService } from 'vscode/vscode/vs/workbench/services/userDataProfile/common/userDataProfile.service';
+import { IRemoteSocketFactoryService } from 'vscode/vscode/vs/platform/remote/common/remoteSocketFactoryService.service';
 
 let AbstractRemoteAgentService = class AbstractRemoteAgentService extends Disposable {
     constructor(remoteSocketFactoryService, userDataProfileService, _environmentService, productService, _remoteAuthorityResolverService, signService, logService) {