@codingame/monaco-vscode-notifications-service-override 37.6.1 → 38.0.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codingame/monaco-vscode-notifications-service-override",
-  "version": "37.6.1",
+  "version": "38.0.0",
   "private": false,
   "description": "VSCode public API plugged on the monaco editor - notifications service-override",
   "keywords": [],
@@ -15,7 +15,7 @@
   },
   "type": "module",
   "dependencies": {
-    "@codingame/monaco-vscode-api": "37.6.1"
+    "@codingame/monaco-vscode-api": "38.0.0"
   },
   "main": "index.js",
   "module": "index.js",

package/vscode/src/vs/workbench/services/notification/common/notificationService.d.ts

@@ -28,6 +28,6 @@ export declare class NotificationService extends Disposable implements INotifica
     error(message: NotificationMessage | NotificationMessage[]): void;
     notify(notification: INotification): INotificationHandle;
     private toStorageScope;
-    prompt(severity: Severity, message: string, choices: IPromptChoice[], options?: IPromptOptions): INotificationHandle;
+    prompt(severity: Severity, message: NotificationMessage, choices: IPromptChoice[], options?: IPromptOptions): INotificationHandle;
     status(message: NotificationMessage, options?: IStatusMessageOptions): IStatusHandle;
 }

package/vscode/src/vs/workbench/services/notification/common/notificationService.js

@@ -10,6 +10,7 @@ import '@codingame/monaco-vscode-api/vscode/vs/platform/instantiation/common/ext
 import { Action } from '@codingame/monaco-vscode-api/vscode/vs/base/common/actions';
 import { StorageScope, StorageTarget } from '@codingame/monaco-vscode-api/vscode/vs/platform/storage/common/storage';
 import { IStorageService } from '@codingame/monaco-vscode-api/vscode/vs/platform/storage/common/storage.service';
+import { withNotificationActionTelemetry, NotificationActionTelemetryId } from '@codingame/monaco-vscode-api/vscode/vs/platform/notification/common/notificationTelemetry';
 import Severity from '@codingame/monaco-vscode-api/vscode/vs/base/common/severity';
 
 var NotificationService_1;
@@ -185,12 +186,14 @@ let NotificationService = class NotificationService extends Disposable {
             const scope = this.toStorageScope(notification.neverShowAgain);
             const id = notification.neverShowAgain.id;
             if (this.storageService.getBoolean(id, scope)) {
+                toDispose.dispose();
                 return ( new NoOpNotification());
             }
-            const neverShowAgainAction = toDispose.add(( new Action("workbench.notification.neverShowAgain", ( localize(22182, "Don't Show Again")), undefined, true, async () => {
+            const neverShowAgainAction = toDispose.add(( new Action("workbench.notification.neverShowAgain", ( localize(24766, "Don't Show Again")), undefined, true, async () => {
                 handle.close();
                 this.storageService.store(id, true, scope, StorageTarget.USER);
             })));
+            withNotificationActionTelemetry(neverShowAgainAction, NotificationActionTelemetryId.NeverShowAgain);
             const actions = {
                 primary: notification.actions?.primary || [],
                 secondary: notification.actions?.secondary || []
@@ -226,7 +229,8 @@ let NotificationService = class NotificationService extends Disposable {
                 return ( new NoOpNotification());
             }
             const neverShowAgainChoice = {
-                label: ( localize(22182, "Don't Show Again")),
+                telemetryId: NotificationActionTelemetryId.NeverShowAgain,
+                label: ( localize(24766, "Don't Show Again")),
                 run: () => this.storageService.store(id, true, scope, StorageTarget.USER),
                 isSecondary: options.neverShowAgain.isSecondary
             };
@@ -263,8 +267,10 @@ let NotificationService = class NotificationService extends Disposable {
             severity,
             message,
             actions,
+            telemetry: options?.telemetry,
             sticky: options?.sticky,
-            priority: options?.priority
+            priority: options?.priority,
+            legacyExtensionLinkParsing: options?.legacyExtensionLinkParsing
         });
         Event.once(handle.onDidClose)(() => {
             toDispose.dispose();