@codingame/monaco-vscode-extension-gallery-service-override 16.1.0 → 17.0.0

package/index.js

@@ -4,7 +4,7 @@ import { SyncDescriptor } from '@codingame/monaco-vscode-api/vscode/vs/platform/
 import { IAllowedExtensionsService, IExtensionTipsService, IGlobalExtensionEnablementService, IExtensionGalleryService } from '@codingame/monaco-vscode-api/vscode/vs/platform/extensionManagement/common/extensionManagement.service';
 import { GlobalExtensionEnablementService } from '@codingame/monaco-vscode-a2719803-af40-5ae9-a29f-8a2231c33056-common/vscode/vs/platform/extensionManagement/common/extensionEnablementService';
 import { IExtensionsWorkbenchService } from '@codingame/monaco-vscode-api/vscode/vs/workbench/contrib/extensions/common/extensions.service';
-import { getLocale } from '@codingame/monaco-vscode-7ba0af96-90c2-5e11-ad7f-befdbbf246c8-common/vscode/vs/platform/languagePacks/common/languagePacks';
+import { getLocale } from '@codingame/monaco-vscode-912ff6c1-e6aa-58cf-bd7f-50cf27bdb591-common/vscode/vs/platform/languagePacks/common/languagePacks';
 import { ExtensionsWorkbenchService } from './vscode/src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.js';
 import { IWorkbenchExtensionEnablementService, IWorkbenchExtensionManagementService, IWebExtensionsScannerService, IExtensionManagementServerService } from '@codingame/monaco-vscode-api/vscode/vs/workbench/services/extensionManagement/common/extensionManagement.service';
 import { ExtensionManagementServerService } from './vscode/src/vs/workbench/services/extensionManagement/common/extensionManagementServerService.js';
@@ -18,7 +18,7 @@ import { ExtensionManifestPropertiesService } from '@codingame/monaco-vscode-d7f
 import { IExtensionManifestPropertiesService } from '@codingame/monaco-vscode-api/vscode/vs/workbench/services/extensions/common/extensionManifestPropertiesService.service';
 import { IBuiltinExtensionsScannerService } from '@codingame/monaco-vscode-api/vscode/vs/platform/extensions/common/extensions.service';
 import { ExtensionIgnoredRecommendationsService } from './vscode/src/vs/workbench/services/extensionRecommendations/common/extensionIgnoredRecommendationsService.js';
-import { WorkspaceExtensionsConfigService } from '@codingame/monaco-vscode-805e9c2f-56b6-5a43-8b5b-d2dc2d3805fc-common/vscode/vs/workbench/services/extensionRecommendations/common/workspaceExtensionsConfig';
+import { WorkspaceExtensionsConfigService } from '@codingame/monaco-vscode-ecf3436d-6064-5fbd-a760-37a211ce79c7-common/vscode/vs/workbench/services/extensionRecommendations/common/workspaceExtensionsConfig';
 import { IWorkspaceExtensionsConfigService } from '@codingame/monaco-vscode-api/vscode/vs/workbench/services/extensionRecommendations/common/workspaceExtensionsConfig.service';
 import { ExtensionRecommendationNotificationService } from './vscode/src/vs/workbench/contrib/extensions/browser/extensionRecommendationNotificationService.js';
 import { ExtensionTipsService } from './vscode/src/vs/platform/extensionManagement/common/extensionTipsService.js';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codingame/monaco-vscode-extension-gallery-service-override",
-  "version": "16.1.0",
+  "version": "17.0.0",
   "private": false,
   "description": "VSCode public API plugged on the monaco editor - extension-gallery service-override",
   "keywords": [],
@@ -15,26 +15,23 @@
   },
   "type": "module",
   "dependencies": {
-    "@codingame/monaco-vscode-039b5553-0838-562a-97c2-30d6e54a7b42-common": "16.1.0",
-    "@codingame/monaco-vscode-0f5ced28-abde-558b-8652-db8e7d4d64aa-common": "16.1.0",
-    "@codingame/monaco-vscode-10418ae3-ee63-5700-a757-89cbe6564ee4-common": "16.1.0",
-    "@codingame/monaco-vscode-12c5f9eb-72d3-57ca-babd-5bef7aa9de3b-common": "16.1.0",
-    "@codingame/monaco-vscode-3a00040f-b81b-50bc-88da-35f611c0bd1e-common": "16.1.0",
-    "@codingame/monaco-vscode-3e369455-cc41-54c6-86fb-8b7cd999a5da-common": "16.1.0",
-    "@codingame/monaco-vscode-411e0589-fa79-504b-b32c-80a88847b23a-common": "16.1.0",
-    "@codingame/monaco-vscode-4893679b-56e5-52c5-a8fb-c366cce9660f-common": "16.1.0",
-    "@codingame/monaco-vscode-5e324391-11e3-5ceb-93ee-938e4098e4ad-common": "16.1.0",
-    "@codingame/monaco-vscode-65619f8f-0eab-5d8b-855a-43b6353fe527-common": "16.1.0",
-    "@codingame/monaco-vscode-68b3311c-eb96-5711-8f72-f5f4b2e31932-common": "16.1.0",
-    "@codingame/monaco-vscode-7559b0be-bfa5-5fe6-b731-1973fe9fffa1-common": "16.1.0",
-    "@codingame/monaco-vscode-7ba0af96-90c2-5e11-ad7f-befdbbf246c8-common": "16.1.0",
-    "@codingame/monaco-vscode-805e9c2f-56b6-5a43-8b5b-d2dc2d3805fc-common": "16.1.0",
-    "@codingame/monaco-vscode-8c844347-a703-5de1-9eeb-5e0c7f503a58-common": "16.1.0",
-    "@codingame/monaco-vscode-a2719803-af40-5ae9-a29f-8a2231c33056-common": "16.1.0",
-    "@codingame/monaco-vscode-a7c9ae3c-16d2-5d17-86b2-981be7094566-common": "16.1.0",
-    "@codingame/monaco-vscode-api": "16.1.0",
-    "@codingame/monaco-vscode-d7f659f5-da33-5ea8-a3b8-9b94f2cf5f33-common": "16.1.0",
-    "@codingame/monaco-vscode-e67a0dae-5b2c-54e6-8d61-90102c78362d-common": "16.1.0"
+    "@codingame/monaco-vscode-0f5ced28-abde-558b-8652-db8e7d4d64aa-common": "17.0.0",
+    "@codingame/monaco-vscode-10418ae3-ee63-5700-a757-89cbe6564ee4-common": "17.0.0",
+    "@codingame/monaco-vscode-2cbab29e-9393-5de6-b701-9a9555360b6b-common": "17.0.0",
+    "@codingame/monaco-vscode-324f9a6e-6231-5bfc-af17-e147abd2dfd2-common": "17.0.0",
+    "@codingame/monaco-vscode-34a0ffd3-b9f5-5699-b43b-38af5732f38a-common": "17.0.0",
+    "@codingame/monaco-vscode-3a00040f-b81b-50bc-88da-35f611c0bd1e-common": "17.0.0",
+    "@codingame/monaco-vscode-5e324391-11e3-5ceb-93ee-938e4098e4ad-common": "17.0.0",
+    "@codingame/monaco-vscode-8c844347-a703-5de1-9eeb-5e0c7f503a58-common": "17.0.0",
+    "@codingame/monaco-vscode-912ff6c1-e6aa-58cf-bd7f-50cf27bdb591-common": "17.0.0",
+    "@codingame/monaco-vscode-a2719803-af40-5ae9-a29f-8a2231c33056-common": "17.0.0",
+    "@codingame/monaco-vscode-a7c9ae3c-16d2-5d17-86b2-981be7094566-common": "17.0.0",
+    "@codingame/monaco-vscode-api": "17.0.0",
+    "@codingame/monaco-vscode-b4efa70b-52b9-5670-ab5c-f10b10b6834e-common": "17.0.0",
+    "@codingame/monaco-vscode-d0fb86d3-2a47-594e-955b-9a24631a7124-common": "17.0.0",
+    "@codingame/monaco-vscode-d7f659f5-da33-5ea8-a3b8-9b94f2cf5f33-common": "17.0.0",
+    "@codingame/monaco-vscode-e67a0dae-5b2c-54e6-8d61-90102c78362d-common": "17.0.0",
+    "@codingame/monaco-vscode-ecf3436d-6064-5fbd-a760-37a211ce79c7-common": "17.0.0"
   },
   "main": "index.js",
   "module": "index.js",

package/vscode/src/vs/platform/extensionManagement/common/abstractExtensionManagementService.d.ts

@@ -47,6 +47,7 @@ export declare abstract class CommontExtensionManagementService extends Disposab
     protected readonly productService: IProductService;
     protected readonly allowedExtensionsService: IAllowedExtensionsService;
     _serviceBrand: undefined;
+    readonly preferPreReleases: boolean;
     constructor(productService: IProductService, allowedExtensionsService: IAllowedExtensionsService);
     canInstall(extension: IGalleryExtension): Promise<true | IMarkdownString>;
     protected isExtensionPlatformCompatible(extension: IGalleryExtension): Promise<boolean>;
@@ -59,7 +60,7 @@ export declare abstract class CommontExtensionManagementService extends Disposab
     abstract installGalleryExtensions(extensions: InstallExtensionInfo[]): Promise<InstallExtensionResult[]>;
     abstract uninstall(extension: ILocalExtension, options?: UninstallOptions): Promise<void>;
     abstract uninstallExtensions(extensions: UninstallExtensionInfo[]): Promise<void>;
-    abstract toggleAppliationScope(extension: ILocalExtension, fromProfileLocation: URI): Promise<ILocalExtension>;
+    abstract toggleApplicationScope(extension: ILocalExtension, fromProfileLocation: URI): Promise<ILocalExtension>;
     abstract getExtensionsControlManifest(): Promise<IExtensionsControlManifest>;
     abstract resetPinnedStateForAllUserExtensions(pinned: boolean): Promise<void>;
     abstract registerParticipant(pariticipant: IExtensionManagementParticipant): void;
@@ -101,7 +102,7 @@ export declare abstract class AbstractExtensionManagementService extends Commont
     installFromGallery(extension: IGalleryExtension, options?: InstallOptions): Promise<ILocalExtension>;
     installGalleryExtensions(extensions: InstallExtensionInfo[]): Promise<InstallExtensionResult[]>;
     uninstall(extension: ILocalExtension, options?: UninstallOptions): Promise<void>;
-    toggleAppliationScope(extension: ILocalExtension, fromProfileLocation: URI): Promise<ILocalExtension>;
+    toggleApplicationScope(extension: ILocalExtension, fromProfileLocation: URI): Promise<ILocalExtension>;
     getExtensionsControlManifest(): Promise<IExtensionsControlManifest>;
     registerParticipant(participant: IExtensionManagementParticipant): void;
     resetPinnedStateForAllUserExtensions(pinned: boolean): Promise<void>;

package/vscode/src/vs/platform/extensionManagement/common/abstractExtensionManagementService.js

@@ -27,12 +27,13 @@ let CommontExtensionManagementService = class CommontExtensionManagementService
         super();
         this.productService = productService;
         this.allowedExtensionsService = allowedExtensionsService;
+        this.preferPreReleases = this.productService.quality !== 'stable';
     }
     async canInstall(extension) {
         const allowedToInstall = this.allowedExtensionsService.isAllowed({ id: extension.identifier.id, publisherDisplayName: extension.publisherDisplayName });
         if (allowedToInstall !== true) {
             return (new MarkdownString(localize(
-                1749,
+                1748,
                 "This extension cannot be installed because {0}",
                 allowedToInstall.value
             )));
@@ -40,12 +41,12 @@ let CommontExtensionManagementService = class CommontExtensionManagementService
         if (!(await this.isExtensionPlatformCompatible(extension))) {
             const learnLink = isWeb ? 'https://aka.ms/vscode-web-extensions-guide' : 'https://aka.ms/vscode-platform-specific-extensions';
             return (new MarkdownString(`${( localize(
-                1750,
+                1749,
                 "The '{0}' extension is not available in {1} for the {2}.",
                 extension.displayName ?? extension.identifier.id,
                 this.productService.nameLong,
                 TargetPlatformToString(await this.getTargetPlatform())
-            ))} [${( localize(1751, "Learn Why"))}](${learnLink})`));
+            ))} [${( localize(1750, "Learn Why"))}](${learnLink})`));
         }
         return true;
     }
@@ -110,7 +111,7 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
     }
     async installGalleryExtensions(extensions) {
         if (!this.galleryService.isEnabled()) {
-            throw ( new ExtensionManagementError(( localize(1752, "Marketplace is not enabled")), ExtensionManagementErrorCode.NotAllowed));
+            throw ( new ExtensionManagementError(( localize(1751, "Marketplace is not enabled")), ExtensionManagementErrorCode.NotAllowed));
         }
         const results = [];
         const installableExtensions = [];
@@ -132,7 +133,7 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
         this.logService.trace('ExtensionManagementService#uninstall', extension.identifier.id);
         return this.uninstallExtensions([{ extension, options }]);
     }
-    async toggleAppliationScope(extension, fromProfileLocation) {
+    async toggleApplicationScope(extension, fromProfileLocation) {
         if (isApplicationScopedExtension(extension.manifest) || extension.isBuiltin) {
             return extension;
         }
@@ -248,9 +249,16 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
                 }
                 else {
                     try {
-                        const allDepsAndPackExtensionsToInstall = await this.getAllDepsAndPackExtensions(task.identifier, task.manifest, !!task.options.installPreReleaseVersion, task.options.productVersion);
+                        let preferPreRelease = this.preferPreReleases;
+                        if (task.options.installPreReleaseVersion) {
+                            preferPreRelease = true;
+                        }
+                        else if (!URI.isUri(task.source) && task.source.hasPreReleaseVersion) {
+                            preferPreRelease = false;
+                        }
+                        const allDepsAndPackExtensionsToInstall = await this.getAllDepsAndPackExtensions(task.identifier, task.manifest, preferPreRelease, task.options.productVersion);
                         const installed = await this.getInstalled(undefined, task.options.profileLocation, task.options.productVersion);
-                        const options = { ...task.options, context: { ...task.options.context, [EXTENSION_INSTALL_DEP_PACK_CONTEXT]: true } };
+                        const options = { ...task.options, pinned: false, installGivenVersion: false, context: { ...task.options.context, [EXTENSION_INSTALL_DEP_PACK_CONTEXT]: true } };
                         for (const { gallery, manifest } of distinct(allDepsAndPackExtensionsToInstall, ({ gallery }) => gallery.identifier.id)) {
                             const existing = installed.find(e => areSameExtensions(e.identifier, gallery.identifier));
                             if (existing && existing.isApplicationScoped === !!options.isApplicationScoped) {
@@ -471,7 +479,7 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
         }
         throw error;
     }
-    async getAllDepsAndPackExtensions(extensionIdentifier, manifest, installPreRelease, productVersion) {
+    async getAllDepsAndPackExtensions(extensionIdentifier, manifest, preferPreRelease, productVersion) {
         if (!this.galleryService.isEnabled()) {
             return [];
         }
@@ -491,7 +499,7 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
             if (dependenciesAndPackExtensions.length) {
                 const ids = dependenciesAndPackExtensions.filter(id => knownIdentifiers.every(galleryIdentifier => !areSameExtensions(galleryIdentifier, { id })));
                 if (ids.length) {
-                    const galleryExtensions = await this.galleryService.getExtensions(( ids.map(id => ({ id, preRelease: installPreRelease }))), CancellationToken.None);
+                    const galleryExtensions = await this.galleryService.getExtensions(( ids.map(id => ({ id, preRelease: preferPreRelease }))), CancellationToken.None);
                     for (const galleryExtension of galleryExtensions) {
                         if (knownIdentifiers.find(identifier => areSameExtensions(identifier, galleryExtension.identifier))) {
                             continue;
@@ -499,7 +507,7 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
                         const isDependency = ( dependecies.some(id => areSameExtensions({ id }, galleryExtension.identifier)));
                         let compatible;
                         try {
-                            compatible = await this.checkAndGetCompatibleVersion(galleryExtension, false, installPreRelease, productVersion);
+                            compatible = await this.checkAndGetCompatibleVersion(galleryExtension, false, preferPreRelease, productVersion);
                         }
                         catch (error) {
                             if (!isDependency) {
@@ -524,7 +532,7 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
         const extensionsControlManifest = await this.getExtensionsControlManifest();
         if (isMalicious(extension.identifier, extensionsControlManifest.malicious)) {
             throw ( new ExtensionManagementError(( localize(
-                1753,
+                1752,
                 "Can't install '{0}' extension since it was reported to be problematic.",
                 extension.identifier.id
             )), ExtensionManagementErrorCode.Malicious));
@@ -535,7 +543,7 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
             compatibleExtension = (await this.galleryService.getExtensions([{ id: deprecationInfo.extension.id, preRelease: deprecationInfo.extension.preRelease }], { targetPlatform: await this.getTargetPlatform(), compatible: true, productVersion }, CancellationToken.None))[0];
             if (!compatibleExtension) {
                 throw ( new ExtensionManagementError(( localize(
-                    1754,
+                    1753,
                     "Can't install '{0}' extension since it was deprecated and the replacement extension '{1}' can't be found.",
                     extension.identifier.id,
                     deprecationInfo.extension.id
@@ -546,7 +554,7 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
             if ((await this.canInstall(extension)) !== true) {
                 const targetPlatform = await this.getTargetPlatform();
                 throw ( new ExtensionManagementError(( localize(
-                    1750,
+                    1749,
                     "The '{0}' extension is not available in {1} for the {2}.",
                     extension.identifier.id,
                     this.productService.nameLong,
@@ -558,21 +566,21 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
                 const incompatibleApiProposalsMessages = [];
                 if (!areApiProposalsCompatible(extension.properties.enabledApiProposals ?? [], incompatibleApiProposalsMessages)) {
                     throw ( new ExtensionManagementError(( localize(
-                        1755,
+                        1754,
                         "Can't install '{0}' extension. {1}",
                         extension.displayName ?? extension.identifier.id,
                         incompatibleApiProposalsMessages[0]
                     )), ExtensionManagementErrorCode.IncompatibleApi));
                 }
-                if (!installPreRelease && extension.properties.isPreReleaseVersion && (await this.galleryService.getExtensions([extension.identifier], CancellationToken.None))[0]) {
+                if (!installPreRelease && extension.hasPreReleaseVersion && extension.properties.isPreReleaseVersion && (await this.galleryService.getExtensions([extension.identifier], CancellationToken.None))[0]) {
                     throw ( new ExtensionManagementError(( localize(
-                        1756,
+                        1755,
                         "Can't install release version of '{0}' extension because it has no release version.",
                         extension.displayName ?? extension.identifier.id
                     )), ExtensionManagementErrorCode.ReleaseVersionNotFound));
                 }
                 throw ( new ExtensionManagementError(( localize(
-                    1757,
+                    1756,
                     "Can't install '{0}' extension because it is not compatible with the current version of {1} (version {2}).",
                     extension.identifier.id,
                     this.productService.nameLong,
@@ -775,7 +783,7 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
         if (extensionToUninstall === dependingExtension) {
             if (dependents.length === 1) {
                 return localize(
-                    1758,
+                    1757,
                     "Cannot uninstall '{0}' extension. '{1}' extension depends on this.",
                     extensionToUninstall.manifest.displayName || extensionToUninstall.manifest.name,
                     dependents[0].manifest.displayName || dependents[0].manifest.name
@@ -783,7 +791,7 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
             }
             if (dependents.length === 2) {
                 return localize(
-                    1759,
+                    1758,
                     "Cannot uninstall '{0}' extension. '{1}' and '{2}' extensions depend on this.",
                     extensionToUninstall.manifest.displayName || extensionToUninstall.manifest.name,
                     dependents[0].manifest.displayName || dependents[0].manifest.name,
@@ -791,7 +799,7 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
                 );
             }
             return localize(
-                1760,
+                1759,
                 "Cannot uninstall '{0}' extension. '{1}', '{2}' and other extension depend on this.",
                 extensionToUninstall.manifest.displayName || extensionToUninstall.manifest.name,
                 dependents[0].manifest.displayName || dependents[0].manifest.name,
@@ -800,7 +808,7 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
         }
         if (dependents.length === 1) {
             return localize(
-                1761,
+                1760,
                 "Cannot uninstall '{0}' extension . It includes uninstalling '{1}' extension and '{2}' extension depends on this.",
                 extensionToUninstall.manifest.displayName || extensionToUninstall.manifest.name,
                 dependingExtension.manifest.displayName
@@ -810,7 +818,7 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
         }
         if (dependents.length === 2) {
             return localize(
-                1762,
+                1761,
                 "Cannot uninstall '{0}' extension. It includes uninstalling '{1}' extension and '{2}' and '{3}' extensions depend on this.",
                 extensionToUninstall.manifest.displayName || extensionToUninstall.manifest.name,
                 dependingExtension.manifest.displayName
@@ -820,7 +828,7 @@ let AbstractExtensionManagementService = class AbstractExtensionManagementServic
             );
         }
         return localize(
-            1763,
+            1762,
             "Cannot uninstall '{0}' extension. It includes uninstalling '{1}' extension and '{2}', '{3}' and other extensions depend on this.",
             extensionToUninstall.manifest.displayName || extensionToUninstall.manifest.name,
             dependingExtension.manifest.displayName

package/vscode/src/vs/platform/extensionManagement/common/allowedExtensionsService.js

@@ -80,14 +80,14 @@ let AllowedExtensionsService = class AllowedExtensionsService extends Disposable
             `command:workbench.action.openSettings?${encodeURIComponent(JSON.stringify({ query: `@id:${AllowedExtensionsConfigKey}` }))}`
         )).toString());
         const extensionValue = this._allowedExtensionsConfigValue[id];
-        const extensionReason = ( new MarkdownString(( localize(1764, "it is not in the [allowed list]({0})", settingsCommandLink))));
+        const extensionReason = ( new MarkdownString(( localize(1763, "it is not in the [allowed list]({0})", settingsCommandLink))));
         if (!isUndefined(extensionValue)) {
             if (isBoolean(extensionValue)) {
                 return extensionValue ? true : extensionReason;
             }
             if (extensionValue === 'stable' && prerelease) {
                 return (new MarkdownString(localize(
-                    1765,
+                    1764,
                     "the pre-release versions of this extension are not in the [allowed list]({0})",
                     settingsCommandLink
                 )));
@@ -107,7 +107,7 @@ let AllowedExtensionsService = class AllowedExtensionsService extends Disposable
                 return false;
             }))) {
                 return (new MarkdownString(localize(
-                    1766,
+                    1765,
                     "the version {0} of this extension is not in the [allowed list]({1})",
                     version,
                     settingsCommandLink
@@ -120,7 +120,7 @@ let AllowedExtensionsService = class AllowedExtensionsService extends Disposable
         if (!isUndefined(publisherValue)) {
             if (isBoolean(publisherValue)) {
                 return publisherValue ? true : ( new MarkdownString(( localize(
-                    1767,
+                    1766,
                     "the extensions from this publisher are not in the [allowed list]({1})",
                     publisherKey,
                     settingsCommandLink
@@ -128,7 +128,7 @@ let AllowedExtensionsService = class AllowedExtensionsService extends Disposable
             }
             if (publisherValue === 'stable' && prerelease) {
                 return (new MarkdownString(localize(
-                    1768,
+                    1767,
                     "the pre-release versions from this publisher are not in the [allowed list]({1})",
                     publisherKey,
                     settingsCommandLink

package/vscode/src/vs/platform/extensionManagement/common/extensionGalleryManifestService.js

@@ -46,11 +46,11 @@ let ExtensionGalleryManifestService = class ExtensionGalleryManifestService exte
         }
         if (extensionsGallery.itemUrl) {
             resources.push({
-                id: `${extensionsGallery.itemUrl}/?itemName={publisher}.{name}`,
+                id: `${extensionsGallery.itemUrl}?itemName={publisher}.{name}`,
                 type: ExtensionGalleryResourceType.ExtensionDetailsViewUri
             });
             resources.push({
-                id: `${extensionsGallery.itemUrl}/?itemName={publisher}.{name}&ssr=false#review-details`,
+                id: `${extensionsGallery.itemUrl}?itemName={publisher}.{name}&ssr=false#review-details`,
                 type: ExtensionGalleryResourceType.ExtensionRatingViewUri
             });
         }
@@ -196,7 +196,7 @@ let ExtensionGalleryManifestService = class ExtensionGalleryManifestService exte
                     flags,
                 },
                 signing: {
-                    allRepositorySigned: true,
+                    allPublicRepositorySigned: true,
                 }
             }
         };

package/vscode/src/vs/platform/extensionManagement/common/extensionGalleryService.d.ts

@@ -1,5 +1,5 @@
 import { CancellationToken } from "@codingame/monaco-vscode-api/vscode/vs/base/common/cancellation";
-import { IPager } from "../../../base/common/paging.js";
+import { IPager } from "@codingame/monaco-vscode-ecf3436d-6064-5fbd-a760-37a211ce79c7-common/vscode/vs/base/common/paging";
 import { URI } from "@codingame/monaco-vscode-api/vscode/vs/base/common/uri";
 import { IConfigurationService } from "@codingame/monaco-vscode-api/vscode/vs/platform/configuration/common/configuration.service";
 import { IEnvironmentService } from "@codingame/monaco-vscode-api/vscode/vs/platform/environment/common/environment.service";
@@ -59,8 +59,9 @@ export declare abstract class AbstractExtensionGalleryService implements IExtens
     private getLatestGalleryExtension;
     getCompatibleExtension(extension: IGalleryExtension, includePreRelease: boolean, targetPlatform: TargetPlatform, productVersion?: IProductVersion): Promise<IGalleryExtension | null>;
     isExtensionCompatible(extension: IGalleryExtension, includePreRelease: boolean, targetPlatform: TargetPlatform, productVersion?: IProductVersion): Promise<boolean>;
-    private areApiProposalsCompatible;
     private isValidVersion;
+    private areApiProposalsCompatible;
+    private isEngineValid;
     query(options: IQueryOptions, token: CancellationToken): Promise<IPager<IGalleryExtension>>;
     private queryGalleryExtensions;
     private queryGalleryExtensionsWithAllVersionsAsFallback;
@@ -74,12 +75,10 @@ export declare abstract class AbstractExtensionGalleryService implements IExtens
     downloadSignatureArchive(extension: IGalleryExtension, location: URI): Promise<void>;
     getReadme(extension: IGalleryExtension, token: CancellationToken): Promise<string>;
     getManifest(extension: IGalleryExtension, token: CancellationToken): Promise<IExtensionManifest | null>;
-    private getManifestFromRawExtensionVersion;
     getCoreTranslation(extension: IGalleryExtension, languageId: string): Promise<ITranslation | null>;
     getChangelog(extension: IGalleryExtension, token: CancellationToken): Promise<string>;
     getAllCompatibleVersions(extensionIdentifier: IExtensionIdentifier, includePreRelease: boolean, targetPlatform: TargetPlatform): Promise<IGalleryExtensionVersion[]>;
     private getAsset;
-    private getEngine;
     getExtensionsControlManifest(): Promise<IExtensionsControlManifest>;
 }
 export declare class ExtensionGalleryService extends AbstractExtensionGalleryService {