@codingame/monaco-vscode-comments-service-override 13.1.7 → 14.0.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codingame/monaco-vscode-comments-service-override",
-  "version": "13.1.7",
+  "version": "14.0.0",
   "private": false,
   "description": "VSCode public API plugged on the monaco editor - comments service-override",
   "keywords": [],
@@ -15,12 +15,12 @@
   },
   "type": "module",
   "dependencies": {
-    "@codingame/monaco-vscode-219d9a5f-b446-507b-a188-1178a0867c75-common": "13.1.7",
-    "@codingame/monaco-vscode-65619f8f-0eab-5d8b-855a-43b6353fe527-common": "13.1.7",
-    "@codingame/monaco-vscode-9ee79c1a-3f03-568b-8eac-b02513a98b68-common": "13.1.7",
-    "@codingame/monaco-vscode-a7c9ae3c-16d2-5d17-86b2-981be7094566-common": "13.1.7",
-    "@codingame/monaco-vscode-api": "13.1.7",
-    "@codingame/monaco-vscode-eb7d5efd-2e60-59f8-9ba4-9a8ae8cb2957-common": "13.1.7"
+    "@codingame/monaco-vscode-4a28f637-7c3c-5e48-a77c-1b7538b38850-common": "14.0.0",
+    "@codingame/monaco-vscode-65619f8f-0eab-5d8b-855a-43b6353fe527-common": "14.0.0",
+    "@codingame/monaco-vscode-9ee79c1a-3f03-568b-8eac-b02513a98b68-common": "14.0.0",
+    "@codingame/monaco-vscode-a7c9ae3c-16d2-5d17-86b2-981be7094566-common": "14.0.0",
+    "@codingame/monaco-vscode-api": "14.0.0",
+    "@codingame/monaco-vscode-eb7d5efd-2e60-59f8-9ba4-9a8ae8cb2957-common": "14.0.0"
   },
   "main": "index.js",
   "module": "index.js",

package/vscode/src/vs/workbench/contrib/comments/browser/commentService.d.ts

@@ -7,7 +7,7 @@ import { Range, IRange } from "@codingame/monaco-vscode-api/vscode/vs/editor/com
 import { CancellationToken } from "@codingame/monaco-vscode-api/vscode/vs/base/common/cancellation";
 import { ICommentThreadChangedEvent } from "@codingame/monaco-vscode-eb7d5efd-2e60-59f8-9ba4-9a8ae8cb2957-common/vscode/vs/workbench/contrib/comments/common/commentModel";
 import { CommentMenus } from "./commentMenus.js";
-import { ICellRange } from "@codingame/monaco-vscode-271a23cd-c7d7-5761-ae35-a923a42987b8-common/vscode/vs/workbench/contrib/notebook/common/notebookRange";
+import { ICellRange } from "@codingame/monaco-vscode-api/vscode/vs/workbench/contrib/notebook/common/notebookRange";
 import { IWorkbenchLayoutService } from "@codingame/monaco-vscode-api/vscode/vs/workbench/services/layout/browser/layoutService.service";
 import { IConfigurationService } from "@codingame/monaco-vscode-api/vscode/vs/platform/configuration/common/configuration.service";
 import { IContextKeyService } from "@codingame/monaco-vscode-api/vscode/vs/platform/contextkey/common/contextkey.service";
@@ -106,6 +106,7 @@ export declare class CommentService extends Disposable implements ICommentServic
     private _commentMenus;
     private _isCommentingEnabled;
     private _workspaceHasCommenting;
+    private _commentingEnabled;
     private _continueOnComments;
     private _continueOnCommentProviders;
     private readonly _commentsModel;

package/vscode/src/vs/workbench/contrib/comments/browser/commentService.js

@@ -61,6 +61,7 @@ let CommentService = class CommentService extends Disposable {
         this._handleConfiguration();
         this._handleZenMode();
         this._workspaceHasCommenting = CommentContextKeys.WorkspaceHasCommenting.bindTo(contextKeyService);
+        this._commentingEnabled = CommentContextKeys.commentingEnabled.bindTo(contextKeyService);
         const storageListener = this._register(( new DisposableStore()));
         const storageEvent = Event.debounce(this.storageService.onDidChangeValue(StorageScope.WORKSPACE, CONTINUE_ON_COMMENTS, storageListener), (last, event) => last?.external ? last : event, 500);
         storageListener.add(storageEvent(v => {
@@ -140,6 +141,7 @@ let CommentService = class CommentService extends Disposable {
     enableCommenting(enable) {
         if (enable !== this._isCommentingEnabled) {
             this._isCommentingEnabled = enable;
+            this._commentingEnabled.set(enable);
             this._onDidChangeCommentingEnabled.fire(enable);
         }
     }

package/vscode/src/vs/workbench/contrib/comments/browser/comments.contribution.js

@@ -33,7 +33,7 @@ registerAction2(class Collapse extends ViewAction {
         super({
             viewId: COMMENTS_VIEW_ID,
             id: 'comments.collapse',
-            title: ( localize(4835, "Collapse All")),
+            title: ( localize(4973, "Collapse All")),
             f1: false,
             icon: Codicon.collapseAll,
             menu: {
@@ -53,7 +53,7 @@ registerAction2(class Expand extends ViewAction {
         super({
             viewId: COMMENTS_VIEW_ID,
             id: 'comments.expand',
-            title: ( localize(4836, "Expand All")),
+            title: ( localize(4974, "Expand All")),
             f1: false,
             icon: Codicon.expandAll,
             menu: {
@@ -72,7 +72,7 @@ registerAction2(class Reply extends Action2 {
     constructor() {
         super({
             id: 'comments.reply',
-            title: ( localize(4837, "Reply")),
+            title: ( localize(4975, "Reply")),
             icon: Codicon.reply,
             precondition: ( ContextKeyExpr.equals('canReply', true)),
             menu: [{
@@ -95,34 +95,34 @@ registerAction2(class Reply extends Action2 {
 ( Registry.as(Extensions.Configuration)).registerConfiguration({
     id: 'comments',
     order: 20,
-    title: ( localize(4838, "Comments")),
+    title: ( localize(4976, "Comments")),
     type: 'object',
     properties: {
         'comments.openPanel': {
             enum: ['neverOpen', 'openOnSessionStart', 'openOnSessionStartWithComments'],
             default: 'openOnSessionStartWithComments',
-            description: ( localize(4839, "Controls when the comments panel should open.")),
+            description: ( localize(4977, "Controls when the comments panel should open.")),
             restricted: false,
-            markdownDeprecationMessage: ( localize(4840, "This setting is deprecated in favor of `comments.openView`."))
+            markdownDeprecationMessage: ( localize(4978, "This setting is deprecated in favor of `comments.openView`."))
         },
         'comments.openView': {
             enum: ['never', 'file', 'firstFile', 'firstFileUnresolved'],
-            enumDescriptions: [( localize(4841, "The comments view will never be opened.")), ( localize(4842, "The comments view will open when a file with comments is active.")), ( localize(
-                4843,
+            enumDescriptions: [( localize(4979, "The comments view will never be opened.")), ( localize(4980, "The comments view will open when a file with comments is active.")), ( localize(
+                4981,
                 "If the comments view has not been opened yet during this session it will open the first time during a session that a file with comments is active."
             )), ( localize(
-                4844,
+                4982,
                 "If the comments view has not been opened yet during this session and the comment is not resolved, it will open the first time during a session that a file with comments is active."
             ))],
             default: 'firstFile',
-            description: ( localize(4845, "Controls when the comments view should open.")),
+            description: ( localize(4983, "Controls when the comments view should open.")),
             restricted: false
         },
         'comments.useRelativeTime': {
             type: 'boolean',
             default: true,
             description: ( localize(
-                4846,
+                4984,
                 "Determines if relative time will be used in comment timestamps (ex. '1 day ago')."
             ))
         },
@@ -130,22 +130,35 @@ registerAction2(class Reply extends Action2 {
             type: 'boolean',
             default: true,
             description: ( localize(
-                4847,
+                4985,
                 "Controls the visibility of the comments bar and comment threads in editors that have commenting ranges and comments. Comments are still accessible via the Comments view and will cause commenting to be toggled on in the same way running the command \"Comments: Toggle Editor Commenting\" toggles comments."
             ))
         },
         'comments.maxHeight': {
             type: 'boolean',
             default: true,
-            description: ( localize(4848, "Controls whether the comments widget scrolls or expands."))
+            description: ( localize(4986, "Controls whether the comments widget scrolls or expands."))
         },
         'comments.collapseOnResolve': {
             type: 'boolean',
             default: true,
             description: ( localize(
-                4849,
+                4987,
                 "Controls whether the comment thread should collapse when the thread is resolved."
             ))
+        },
+        'comments.thread.confirmOnCollapse': {
+            type: 'string',
+            enum: ['whenHasUnsubmittedComments', 'never'],
+            enumDescriptions: [( localize(
+                4988,
+                "Show a confirmation dialog when collapsing a comment thread with unsubmitted comments."
+            )), ( localize(4989, "Never show a confirmation dialog when collapsing a comment thread."))],
+            default: 'whenHasUnsubmittedComments',
+            description: ( localize(
+                4990,
+                "Controls whether a confirmation dialog is shown when collapsing a comment thread."
+            ))
         }
     }
 });
@@ -184,7 +197,7 @@ let UnresolvedCommentsBadge = class UnresolvedCommentsBadge extends Disposable {
             return;
         }
         this.totalUnresolved = unresolved;
-        const message = ( localize(4850, '{0} Unresolved Comments', this.totalUnresolved));
+        const message = ( localize(4991, '{0} Unresolved Comments', this.totalUnresolved));
         this.activity.value = this.activityService.showViewActivity(COMMENTS_VIEW_ID, { badge: ( new NumberBadge(this.totalUnresolved, () => message)) });
     }
 };

package/vscode/src/vs/workbench/contrib/comments/browser/commentsAccessibleView.d.ts

@@ -1,14 +1,14 @@
 import { Disposable } from "@codingame/monaco-vscode-api/vscode/vs/base/common/lifecycle";
 import { ServicesAccessor } from "@codingame/monaco-vscode-api/vscode/vs/editor/browser/editorExtensions";
 import { AccessibleViewProviderId, AccessibleViewType, IAccessibleViewContentProvider } from "@codingame/monaco-vscode-api/vscode/vs/platform/accessibility/browser/accessibleView";
-import { IAccessibleViewImplentation } from "@codingame/monaco-vscode-api/vscode/vs/platform/accessibility/browser/accessibleViewRegistry";
+import { IAccessibleViewImplementation } from "@codingame/monaco-vscode-api/vscode/vs/platform/accessibility/browser/accessibleViewRegistry";
 import { AccessibilityVerbositySettingId } from "@codingame/monaco-vscode-api/vscode/vs/workbench/contrib/accessibility/browser/accessibilityConfiguration";
 import { CommentsMenus } from "@codingame/monaco-vscode-eb7d5efd-2e60-59f8-9ba4-9a8ae8cb2957-common/vscode/vs/workbench/contrib/comments/browser/commentsTreeViewer";
 import { CommentsPanel } from "@codingame/monaco-vscode-eb7d5efd-2e60-59f8-9ba4-9a8ae8cb2957-common/vscode/vs/workbench/contrib/comments/browser/commentsView";
 import { ICommentService } from "@codingame/monaco-vscode-api/vscode/vs/workbench/contrib/comments/browser/commentService.service";
 import { IEditorService } from "@codingame/monaco-vscode-api/vscode/vs/workbench/services/editor/common/editorService.service";
 import { IUriIdentityService } from "@codingame/monaco-vscode-api/vscode/vs/platform/uriIdentity/common/uriIdentity.service";
-export declare class CommentsAccessibleView extends Disposable implements IAccessibleViewImplentation {
+export declare class CommentsAccessibleView extends Disposable implements IAccessibleViewImplementation {
     readonly priority = 90;
     readonly name = "comment";
     readonly when: import("@codingame/monaco-vscode-api/vscode/vs/platform/contextkey/common/contextkey").RawContextKey<boolean>;
@@ -16,7 +16,7 @@ export declare class CommentsAccessibleView extends Disposable implements IAcces
     getProvider(accessor: ServicesAccessor): CommentsAccessibleContentProvider | undefined;
     constructor();
 }
-export declare class CommentThreadAccessibleView extends Disposable implements IAccessibleViewImplentation {
+export declare class CommentThreadAccessibleView extends Disposable implements IAccessibleViewImplementation {
     readonly priority = 85;
     readonly name = "commentThread";
     readonly when: import("@codingame/monaco-vscode-api/vscode/vs/platform/contextkey/common/contextkey").RawContextKey<boolean>;

package/vscode/src/vs/workbench/contrib/comments/browser/commentsEditorContribution.js

@@ -23,6 +23,7 @@ import { registerWorkbenchContribution2, WorkbenchPhase } from '@codingame/monac
 import { CommentsInputContentProvider } from './commentsInputContentProvider.js';
 import { AccessibleViewProviderId } from '@codingame/monaco-vscode-api/vscode/vs/platform/accessibility/browser/accessibleView';
 import { CommentWidgetFocus } from '@codingame/monaco-vscode-eb7d5efd-2e60-59f8-9ba4-9a8ae8cb2957-common/vscode/vs/workbench/contrib/comments/browser/commentThreadZoneWidget';
+import { IKeybindingService } from '@codingame/monaco-vscode-api/vscode/vs/platform/keybinding/common/keybinding.service';
 
 registerEditorContribution(ID, CommentController, EditorContributionInstantiation.AfterFirstRender);
 registerWorkbenchContribution2(CommentsInputContentProvider.ID, CommentsInputContentProvider, WorkbenchPhase.BlockRestore);
@@ -63,11 +64,11 @@ registerAction2(class extends Action2 {
         super({
             id: CommentCommandId.NextCommentedRange,
             title: {
-                value: ( localize(4869, "Go to Next Commented Range")),
+                value: ( localize(5012, "Go to Next Commented Range")),
                 original: 'Go to Next Commented Range'
             },
             category: {
-                value: ( localize(4870, "Comments")),
+                value: ( localize(5013, "Comments")),
                 original: 'Comments'
             },
             menu: [{
@@ -98,11 +99,11 @@ registerAction2(class extends Action2 {
         super({
             id: CommentCommandId.PreviousCommentedRange,
             title: {
-                value: ( localize(4871, "Go to Previous Commented Range")),
+                value: ( localize(5014, "Go to Previous Commented Range")),
                 original: 'Go to Previous Commented Range'
             },
             category: {
-                value: ( localize(4870, "Comments")),
+                value: ( localize(5013, "Comments")),
                 original: 'Comments'
             },
             menu: [{
@@ -133,11 +134,11 @@ registerAction2(class extends Action2 {
         super({
             id: CommentCommandId.NextRange,
             title: {
-                value: ( localize(4872, "Go to Next Commenting Range")),
+                value: ( localize(5015, "Go to Next Commenting Range")),
                 original: 'Go to Next Commenting Range'
             },
             category: {
-                value: ( localize(4870, "Comments")),
+                value: ( localize(5013, "Comments")),
                 original: 'Comments'
             },
             menu: [{
@@ -168,11 +169,11 @@ registerAction2(class extends Action2 {
         super({
             id: CommentCommandId.PreviousRange,
             title: {
-                value: ( localize(4873, "Go to Previous Commenting Range")),
+                value: ( localize(5016, "Go to Previous Commenting Range")),
                 original: 'Go to Previous Commenting Range'
             },
             category: {
-                value: ( localize(4870, "Comments")),
+                value: ( localize(5013, "Comments")),
                 original: 'Comments'
             },
             menu: [{
@@ -203,11 +204,11 @@ registerAction2(class extends Action2 {
         super({
             id: CommentCommandId.ToggleCommenting,
             title: {
-                value: ( localize(4874, "Toggle Editor Commenting")),
+                value: ( localize(5017, "Toggle Editor Commenting")),
                 original: 'Toggle Editor Commenting'
             },
             category: {
-                value: ( localize(4870, "Comments")),
+                value: ( localize(5013, "Comments")),
                 original: 'Comments'
             },
             menu: [{
@@ -227,11 +228,11 @@ registerAction2(class extends Action2 {
         super({
             id: CommentCommandId.Add,
             title: {
-                value: ( localize(4875, "Add Comment on Current Selection")),
+                value: ( localize(5018, "Add Comment on Current Selection")),
                 original: 'Add Comment on Current Selection'
             },
             category: {
-                value: ( localize(4870, "Comments")),
+                value: ( localize(5013, "Comments")),
                 original: 'Comments'
             },
             menu: [{
@@ -261,13 +262,7 @@ registerAction2(class extends Action2 {
             args.range.endColumn
         ))
             : (args?.fileComment ? undefined : activeEditor.getSelection());
-        const notificationService = accessor.get(INotificationService);
-        try {
-            await controller.addOrToggleCommentAtLine(position, undefined);
-        }
-        catch (e) {
-            notificationService.error(( localize(4876, "The cursor must be within a commenting range to add a comment")));
-        }
+        await controller.addOrToggleCommentAtLine(position, undefined);
     }
 });
 registerAction2(class extends Action2 {
@@ -275,11 +270,11 @@ registerAction2(class extends Action2 {
         super({
             id: CommentCommandId.FocusCommentOnCurrentLine,
             title: {
-                value: ( localize(4877, "Focus Comment on Current Line")),
+                value: ( localize(5019, "Focus Comment on Current Line")),
                 original: 'Focus Comment on Current Line'
             },
             category: {
-                value: ( localize(4870, "Comments")),
+                value: ( localize(5013, "Comments")),
                 original: 'Comments'
             },
             f1: true,
@@ -311,7 +306,7 @@ registerAction2(class extends Action2 {
             error = true;
         }
         if (error) {
-            notificationService.error(( localize(4878, "The cursor must be on a line with a comment to focus the comment")));
+            notificationService.error(( localize(5020, "The cursor must be on a line with a comment to focus the comment")));
         }
     }
 });
@@ -320,11 +315,11 @@ registerAction2(class extends Action2 {
         super({
             id: CommentCommandId.CollapseAll,
             title: {
-                value: ( localize(4879, "Collapse All Comments")),
+                value: ( localize(5021, "Collapse All Comments")),
                 original: 'Collapse All Comments'
             },
             category: {
-                value: ( localize(4870, "Comments")),
+                value: ( localize(5013, "Comments")),
                 original: 'Comments'
             },
             menu: [{
@@ -342,11 +337,11 @@ registerAction2(class extends Action2 {
         super({
             id: CommentCommandId.ExpandAll,
             title: {
-                value: ( localize(4880, "Expand All Comments")),
+                value: ( localize(5022, "Expand All Comments")),
                 original: 'Expand All Comments'
             },
             category: {
-                value: ( localize(4870, "Comments")),
+                value: ( localize(5013, "Comments")),
                 original: 'Comments'
             },
             menu: [{
@@ -364,11 +359,11 @@ registerAction2(class extends Action2 {
         super({
             id: CommentCommandId.ExpandUnresolved,
             title: {
-                value: ( localize(4881, "Expand Unresolved Comments")),
+                value: ( localize(5023, "Expand Unresolved Comments")),
                 original: 'Expand Unresolved Comments'
             },
             category: {
-                value: ( localize(4870, "Comments")),
+                value: ( localize(5013, "Comments")),
                 original: 'Comments'
             },
             menu: [{
@@ -399,8 +394,10 @@ KeybindingsRegistry.registerCommandAndKeybindingRule({
     primary: KeyCode.Escape,
     secondary: [KeyMod.Shift | KeyCode.Escape],
     when: ( ContextKeyExpr.or(ctxCommentEditorFocused, CommentContextKeys.commentFocused)),
-    handler: (accessor, args) => {
+    handler: async (accessor, args) => {
         const activeCodeEditor = accessor.get(ICodeEditorService).getFocusedCodeEditor();
+        const keybindingService = accessor.get(IKeybindingService);
+        await keybindingService.enableKeybindingHoldMode(CommentCommandId.Hide);
         if (activeCodeEditor instanceof SimpleCommentEditor) {
             activeCodeEditor.getParentThread().collapse();
         }
@@ -425,7 +422,7 @@ KeybindingsRegistry.registerCommandAndKeybindingRule({
                 error = true;
             }
             if (error) {
-                notificationService.error(( localize(4878, "The cursor must be on a line with a comment to focus the comment")));
+                notificationService.error(( localize(5020, "The cursor must be on a line with a comment to focus the comment")));
             }
         }
     }

package/vscode/src/vs/workbench/contrib/comments/browser/commentsInputContentProvider.js

@@ -7,7 +7,7 @@ import { ScrollType } from '@codingame/monaco-vscode-api/vscode/vs/editor/common
 import { ILanguageService } from '@codingame/monaco-vscode-api/vscode/vs/editor/common/languages/language';
 import { IModelService } from '@codingame/monaco-vscode-api/vscode/vs/editor/common/services/model';
 import { ITextModelService } from '@codingame/monaco-vscode-api/vscode/vs/editor/common/services/resolverService';
-import { applyTextEditorOptions } from '@codingame/monaco-vscode-219d9a5f-b446-507b-a188-1178a0867c75-common/vscode/vs/workbench/common/editor/editorOptions';
+import { applyTextEditorOptions } from '@codingame/monaco-vscode-4a28f637-7c3c-5e48-a77c-1b7538b38850-common/vscode/vs/workbench/common/editor/editorOptions';
 import { SimpleCommentEditor } from '@codingame/monaco-vscode-api/vscode/vs/workbench/contrib/comments/browser/simpleCommentEditor';
 
 let CommentsInputContentProvider = class CommentsInputContentProvider extends Disposable {