@codingame/monaco-vscode-chat-service-override 28.4.0 → 29.0.0

package/vscode/src/vs/workbench/contrib/chat/browser/agentPluginEditor/agentPluginEditor.js

@@ -19,6 +19,7 @@ import { generateTokensCSSForColorMap } from '@codingame/monaco-vscode-api/vscod
 import { localize } from '@codingame/monaco-vscode-api/vscode/vs/nls';
 import { IFileService } from '@codingame/monaco-vscode-api/vscode/vs/platform/files/common/files.service';
 import { IInstantiationService } from '@codingame/monaco-vscode-api/vscode/vs/platform/instantiation/common/instantiation';
+import { IContextMenuService } from '@codingame/monaco-vscode-api/vscode/vs/platform/contextview/browser/contextView.service';
 import { ILabelService } from '@codingame/monaco-vscode-api/vscode/vs/platform/label/common/label.service';
 import { IOpenerService } from '@codingame/monaco-vscode-api/vscode/vs/platform/opener/common/opener.service';
 import { asText } from '@codingame/monaco-vscode-api/vscode/vs/platform/request/common/request';
@@ -32,11 +33,17 @@ import { renderMarkdownDocument, DEFAULT_MARKDOWN_STYLES } from '@codingame/mona
 import { IWebviewService } from '@codingame/monaco-vscode-api/vscode/vs/workbench/contrib/webview/browser/webview.service';
 import { IAgentPluginService } from '@codingame/monaco-vscode-api/vscode/vs/workbench/contrib/chat/common/plugins/agentPluginService.service';
 import { IPluginInstallService } from '@codingame/monaco-vscode-api/vscode/vs/workbench/contrib/chat/common/plugins/pluginInstallService.service';
+import { hasSourceChanged } from '../../common/plugins/pluginMarketplaceService.js';
+import { IPluginMarketplaceService } from '@codingame/monaco-vscode-api/vscode/vs/workbench/contrib/chat/common/plugins/pluginMarketplaceService.service';
 import { AgentPluginItemKind } from './agentPluginItems.js';
+import { IWorkspaceContextService } from '@codingame/monaco-vscode-api/vscode/vs/platform/workspace/common/workspace.service';
+import { EnablementStatusWidget, pluginEnablementLabels } from '../enablementStatusWidget.js';
+import { EnablementDropDownAction, EnablementDropdownActionViewItem, InstallPluginAction, createEnablePluginDropDown, createDisablePluginDropDown, UninstallPluginAction } from '../agentPluginActions.js';
 import * as agentPluginEditor from './media/agentPluginEditor.css';
+import { derived } from '@codingame/monaco-vscode-api/vscode/vs/base/common/observableInternal/observables/derived';
 import { autorun } from '@codingame/monaco-vscode-api/vscode/vs/base/common/observableInternal/reactions/autorun';
 
-var AgentPluginEditor_1, InstallPluginEditorAction_1, EnablePluginEditorAction_1, DisablePluginEditorAction_1;
+var AgentPluginEditor_1, UpdatePluginEditorAction_1;
 registerCss(agentPluginEditor);
 var WebviewIndex;
 (function(WebviewIndex) {
@@ -63,7 +70,9 @@ let AgentPluginEditor = class AgentPluginEditor extends EditorPane {
         requestService,
         agentPluginService,
         pluginInstallService,
-        labelService
+        pluginMarketplaceService,
+        labelService,
+        contextMenuService
     ) {
         super(
             AgentPluginEditor_1.ID,
@@ -81,7 +90,9 @@ let AgentPluginEditor = class AgentPluginEditor extends EditorPane {
         this.requestService = requestService;
         this.agentPluginService = agentPluginService;
         this.pluginInstallService = pluginInstallService;
+        this.pluginMarketplaceService = pluginMarketplaceService;
         this.labelService = labelService;
+        this.contextMenuService = contextMenuService;
         this.pluginReadme = null;
         this.initialScrollProgress = ( new Map());
         this.currentIdentifier = "";
@@ -110,9 +121,24 @@ let AgentPluginEditor = class AgentPluginEditor extends EditorPane {
         const marketplace = append(subtitle, $("span.subtitle-entry"));
         const actionsAndStatusContainer = append(details, $(".actions-status-container"));
         const actionBar = this._register(( new ActionBar(actionsAndStatusContainer, {
+            actionViewItemProvider: (action, options) => {
+                if (action instanceof EnablementDropDownAction) {
+                    return ( new EnablementDropdownActionViewItem(action, {
+                        ...options,
+                        icon: true,
+                        label: true,
+                        menuActionsOrProvider: {
+                            getActions: () => action.menuActions
+                        },
+                        menuActionClassNames: action.menuActionClassNames
+                    }, this.contextMenuService));
+                }
+                return undefined;
+            },
             focusOnlyEnabledItems: true
         })));
         actionBar.setFocusable(true);
+        const statusContainer = append(actionsAndStatusContainer, $(".status"));
         const body = append(root, $(".body"));
         const content = append(body, $(".content"));
         content.id = generateUuid();
@@ -122,7 +148,8 @@ let AgentPluginEditor = class AgentPluginEditor extends EditorPane {
             header,
             name,
             marketplace,
-            actionBar
+            actionBar,
+            statusContainer
         };
     }
     async setInput(input, options, context, token) {
@@ -163,11 +190,8 @@ let AgentPluginEditor = class AgentPluginEditor extends EditorPane {
         } else {
             reset(template.marketplace, marketplaceLabel);
         }
-        const actionDisposables = this.transientDisposables.add(( new DisposableStore()));
-        this.transientDisposables.add(autorun(reader => {
-            actionDisposables.clear();
-            template.actionBar.clear();
-            const allPlugins = this.agentPluginService.allPlugins.read(reader);
+        const currentItem = derived(reader => {
+            const allPlugins = this.agentPluginService.plugins.read(reader);
             let currentItem = item;
             if (item.kind === AgentPluginItemKind.Marketplace) {
                 const expectedUri = this.pluginInstallService.getPluginInstallUri({
@@ -204,11 +228,28 @@ let AgentPluginEditor = class AgentPluginEditor extends EditorPane {
                         return;
                     }
                 } else {
-                    stillInstalled.enabled.read(reader);
+                    stillInstalled.enablement.read(reader);
                     currentItem = this.installedPluginToItem(stillInstalled);
                 }
             }
-            const actions = this.getItemActions(currentItem);
+            return currentItem;
+        });
+        const storedPlugin = ( currentItem.map((item, r) => {
+            if (!item || item.kind === AgentPluginItemKind.Marketplace) {
+                return undefined;
+            }
+            return this.pluginMarketplaceService.installedPlugins.read(r).find(e => ( e.pluginUri.toString()) === ( item.plugin.uri.toString()))?.plugin ?? item.plugin.fromMarketplace;
+        }));
+        const actionDisposables = this.transientDisposables.add(( new DisposableStore()));
+        this.transientDisposables.add(autorun(reader => {
+            actionDisposables.clear();
+            template.actionBar.clear();
+            const current = currentItem.read(reader);
+            if (!current) {
+                return;
+            }
+            this.pluginMarketplaceService.lastFetchedPlugins.read(reader);
+            const actions = this.getItemActions(current, storedPlugin.read(reader));
             if (actions.length > 0) {
                 template.actionBar.push(actions, {
                     icon: true,
@@ -218,26 +259,40 @@ let AgentPluginEditor = class AgentPluginEditor extends EditorPane {
             for (const action of actions) {
                 actionDisposables.add(action);
             }
+            if (current.kind === AgentPluginItemKind.Installed) {
+                actionDisposables.add(this.instantiationService.createInstance(
+                    EnablementStatusWidget,
+                    template.statusContainer,
+                    current.plugin.enablement,
+                    pluginEnablementLabels
+                ));
+            }
         }));
         this.activeElement = await this.openDetails(item, template, token);
     }
-    getItemActions(item) {
+    getItemActions(item, storedPlugin) {
         if (item.kind === AgentPluginItemKind.Marketplace) {
-            return [this.instantiationService.createInstance(InstallPluginEditorAction, item)];
+            return [this.instantiationService.createInstance(InstallPluginAction, item)];
         }
+        const workspaceService = this.instantiationService.invokeFunction(a => a.get(IWorkspaceContextService));
         const actions = [];
-        if (item.plugin.enabled.get()) {
-            actions.push(
-                this.instantiationService.createInstance(DisablePluginEditorAction, item.plugin)
-            );
-        } else {
-            actions.push(
-                this.instantiationService.createInstance(EnablePluginEditorAction, item.plugin)
-            );
+        if (storedPlugin) {
+            const cachedMarketplace = this.pluginMarketplaceService.lastFetchedPlugins.get();
+            const key = `${storedPlugin.marketplaceReference.canonicalId}::${storedPlugin.name}`;
+            const livePlugin = cachedMarketplace.find(mp => `${mp.marketplaceReference.canonicalId}::${mp.name}` === key);
+            if (livePlugin && hasSourceChanged(storedPlugin.sourceDescriptor, livePlugin.sourceDescriptor)) {
+                actions.push(
+                    this.instantiationService.createInstance(UpdatePluginEditorAction, item.plugin, livePlugin)
+                );
+            }
         }
         actions.push(
-            this.instantiationService.createInstance(UninstallPluginEditorAction, item.plugin)
+            createEnablePluginDropDown(item.plugin, this.agentPluginService.enablementModel, workspaceService)
+        );
+        actions.push(
+            createDisablePluginDropDown(item.plugin, this.agentPluginService.enablementModel, workspaceService)
         );
+        actions.push(( new UninstallPluginAction(item.plugin)));
         return actions;
     }
     installedPluginToItem(plugin) {
@@ -283,7 +338,8 @@ let AgentPluginEditor = class AgentPluginEditor extends EditorPane {
             try {
                 const context = await this.requestService.request({
                     type: "GET",
-                    url: rawUrl
+                    url: rawUrl,
+                    callSite: "agentPluginEditor.fetchReadme"
                 }, token);
                 const text = await asText(context);
                 return text ?? "";
@@ -301,7 +357,7 @@ let AgentPluginEditor = class AgentPluginEditor extends EditorPane {
         this.contentDisposables.add(toDisposable(insert(this.layoutParticipants, {
             layout
         })));
-        return this.openMarkdown(this.pluginReadme.get(), ( localize(5011, "No README available.")), readmeContainer, WebviewIndex.Readme, ( localize(5012, "Readme")), token);
+        return this.openMarkdown(this.pluginReadme.get(), ( localize(5058, "No README available.")), readmeContainer, WebviewIndex.Readme, ( localize(5059, "Readme")), token);
     }
     async openMarkdown(cacheResult, noContentCopy, container, webviewIndex, title, token) {
         try {
@@ -459,79 +515,32 @@ let AgentPluginEditor = class AgentPluginEditor extends EditorPane {
         this.layoutParticipants.forEach(p => p.layout());
     }
 };
-AgentPluginEditor = AgentPluginEditor_1 = ( __decorate([( __param(1, ITelemetryService)), ( __param(2, IInstantiationService)), ( __param(3, IThemeService)), ( __param(4, IOpenerService)), ( __param(5, IStorageService)), ( __param(6, IExtensionService)), ( __param(7, IWebviewService)), ( __param(8, ILanguageService)), ( __param(9, IFileService)), ( __param(10, IRequestService)), ( __param(11, IAgentPluginService)), ( __param(12, IPluginInstallService)), ( __param(13, ILabelService))], AgentPluginEditor));
-let InstallPluginEditorAction = class InstallPluginEditorAction extends Action {
-    static {
-        InstallPluginEditorAction_1 = this;
-    }
-    static {
-        this.ID = "agentPlugin.editor.install";
-    }
-    constructor(item, pluginInstallService) {
-        super(InstallPluginEditorAction_1.ID, ( localize(5013, "Install")), "extension-action label prominent install");
-        this.item = item;
-        this.pluginInstallService = pluginInstallService;
-    }
-    async run() {
-        await this.pluginInstallService.installPlugin({
-            name: this.item.name,
-            description: this.item.description,
-            version: "",
-            source: this.item.source,
-            sourceDescriptor: this.item.sourceDescriptor,
-            marketplace: this.item.marketplace,
-            marketplaceReference: this.item.marketplaceReference,
-            marketplaceType: this.item.marketplaceType,
-            readmeUri: this.item.readmeUri
-        });
-    }
-};
-InstallPluginEditorAction = InstallPluginEditorAction_1 = ( __decorate([( __param(1, IPluginInstallService))], InstallPluginEditorAction));
-let EnablePluginEditorAction = class EnablePluginEditorAction extends Action {
-    static {
-        EnablePluginEditorAction_1 = this;
-    }
-    static {
-        this.ID = "agentPlugin.editor.enable";
-    }
-    constructor(plugin, agentPluginService) {
-        super(EnablePluginEditorAction_1.ID, ( localize(5014, "Enable")), "extension-action label prominent");
-        this.plugin = plugin;
-        this.agentPluginService = agentPluginService;
-    }
-    async run() {
-        this.agentPluginService.setPluginEnabled(this.plugin.uri, true);
-    }
-};
-EnablePluginEditorAction = EnablePluginEditorAction_1 = ( __decorate([( __param(1, IAgentPluginService))], EnablePluginEditorAction));
-let DisablePluginEditorAction = class DisablePluginEditorAction extends Action {
+AgentPluginEditor = AgentPluginEditor_1 = ( __decorate([( __param(1, ITelemetryService)), ( __param(2, IInstantiationService)), ( __param(3, IThemeService)), ( __param(4, IOpenerService)), ( __param(5, IStorageService)), ( __param(6, IExtensionService)), ( __param(7, IWebviewService)), ( __param(8, ILanguageService)), ( __param(9, IFileService)), ( __param(10, IRequestService)), ( __param(11, IAgentPluginService)), ( __param(12, IPluginInstallService)), ( __param(13, IPluginMarketplaceService)), ( __param(14, ILabelService)), ( __param(15, IContextMenuService))], AgentPluginEditor));
+let UpdatePluginEditorAction = class UpdatePluginEditorAction extends Action {
     static {
-        DisablePluginEditorAction_1 = this;
+        UpdatePluginEditorAction_1 = this;
     }
     static {
-        this.ID = "agentPlugin.editor.disable";
+        this.ID = "agentPlugin.editor.update";
     }
-    constructor(plugin, agentPluginService) {
-        super(DisablePluginEditorAction_1.ID, ( localize(5015, "Disable")), "extension-action label disable");
+    constructor(
+        plugin,
+        liveMarketplacePlugin,
+        pluginInstallService,
+        pluginMarketplaceService
+    ) {
+        super(UpdatePluginEditorAction_1.ID, ( localize(5060, "Update")), "extension-action label prominent install");
         this.plugin = plugin;
-        this.agentPluginService = agentPluginService;
+        this.liveMarketplacePlugin = liveMarketplacePlugin;
+        this.pluginInstallService = pluginInstallService;
+        this.pluginMarketplaceService = pluginMarketplaceService;
     }
     async run() {
-        this.agentPluginService.setPluginEnabled(this.plugin.uri, false);
+        if (await this.pluginInstallService.updatePlugin(this.liveMarketplacePlugin)) {
+            this.pluginMarketplaceService.addInstalledPlugin(this.plugin.uri, this.liveMarketplacePlugin);
+        }
     }
 };
-DisablePluginEditorAction = DisablePluginEditorAction_1 = ( __decorate([( __param(1, IAgentPluginService))], DisablePluginEditorAction));
-class UninstallPluginEditorAction extends Action {
-    static {
-        this.ID = "agentPlugin.editor.uninstall";
-    }
-    constructor(plugin) {
-        super(UninstallPluginEditorAction.ID, ( localize(5016, "Uninstall")), "extension-action label uninstall");
-        this.plugin = plugin;
-    }
-    async run() {
-        this.plugin.remove();
-    }
-}
+UpdatePluginEditorAction = UpdatePluginEditorAction_1 = ( __decorate([( __param(2, IPluginInstallService)), ( __param(3, IPluginMarketplaceService))], UpdatePluginEditorAction));
 
 export { AgentPluginEditor };

package/vscode/src/vs/workbench/contrib/chat/browser/agentPluginEditor/agentPluginEditorInput.js

@@ -8,7 +8,7 @@ import { EditorInputCapabilities } from '@codingame/monaco-vscode-api/vscode/vs/
 import { EditorInput } from '@codingame/monaco-vscode-api/vscode/vs/workbench/common/editor/editorInput';
 import { AgentPluginItemKind } from './agentPluginItems.js';
 
-const AgentPluginEditorIcon = registerIcon("agent-plugin-editor-icon", Codicon.extensions, ( localize(5017, "Icon of the Agent Plugin editor.")));
+const AgentPluginEditorIcon = registerIcon("agent-plugin-editor-icon", Codicon.extensions, ( localize(5061, "Icon of the Agent Plugin editor.")));
 function getPluginId(item) {
     if (item.kind === AgentPluginItemKind.Installed) {
         return ( item.plugin.uri.toString());
@@ -23,7 +23,7 @@ class AgentPluginEditorInput extends EditorInput {
         return AgentPluginEditorInput.ID;
     }
     get capabilities() {
-        return EditorInputCapabilities.Readonly | EditorInputCapabilities.Singleton;
+        return super.capabilities | EditorInputCapabilities.Singleton | EditorInputCapabilities.RequiresModal;
     }
     get resource() {
         return ( URI.from({
@@ -39,7 +39,7 @@ class AgentPluginEditorInput extends EditorInput {
         return this._item;
     }
     getName() {
-        return localize(5018, "Plugin: {0}", this._item.name);
+        return localize(5062, "Plugin: {0}", this._item.name);
     }
     getIcon() {
         return AgentPluginEditorIcon;

package/vscode/src/vs/workbench/contrib/chat/browser/agentPluginEditor/agentPluginItems.d.ts

@@ -1,6 +1,7 @@
+import { IObservable } from "@codingame/monaco-vscode-api/vscode/vs/base/common/observable";
 import { URI } from "@codingame/monaco-vscode-api/vscode/vs/base/common/uri";
 import type { IAgentPlugin } from "../../common/plugins/agentPluginService.js";
-import type { IMarketplaceReference, IPluginSourceDescriptor, MarketplaceType } from "../../common/plugins/pluginMarketplaceService.js";
+import type { IMarketplacePlugin, IMarketplaceReference, IPluginSourceDescriptor, MarketplaceType } from "../../common/plugins/pluginMarketplaceService.js";
 export declare enum AgentPluginItemKind {
     Installed = "installed",
     Marketplace = "marketplace"
@@ -11,6 +12,8 @@ export interface IInstalledPluginItem {
     readonly description: string;
     readonly marketplace?: string;
     readonly plugin: IAgentPlugin;
+    /** When set, indicates the plugin has a newer version in the marketplace. */
+    readonly outdated?: IObservable<IMarketplacePlugin | undefined>;
 }
 export interface IMarketplacePluginItem {
     readonly kind: AgentPluginItemKind.Marketplace;

package/vscode/src/vs/workbench/contrib/chat/browser/agentPluginRepositoryService.d.ts

@@ -22,12 +22,13 @@ export declare class AgentPluginRepositoryService implements IAgentPluginReposit
     private readonly _cacheRoot;
     private readonly _marketplaceIndex;
     private readonly _pluginSources;
+    private readonly _cloneSequencer;
     constructor(_commandService: ICommandService, environmentService: IEnvironmentService, _fileService: IFileService, instantiationService: IInstantiationService, _logService: ILogService, _notificationService: INotificationService, _progressService: IProgressService, _storageService: IStorageService);
     getPluginSource(kind: PluginSourceKind): IPluginSource;
     getRepositoryUri(marketplace: IMarketplaceReference, marketplaceType?: MarketplaceType): URI;
     getPluginInstallUri(plugin: IMarketplacePlugin): URI;
     ensureRepository(marketplace: IMarketplaceReference, options?: IEnsureRepositoryOptions): Promise<URI>;
-    pullRepository(marketplace: IMarketplaceReference, options?: IPullRepositoryOptions): Promise<void>;
+    pullRepository(marketplace: IMarketplaceReference, options?: IPullRepositoryOptions): Promise<boolean>;
     private _getRepoCacheDirForReference;
     private _loadMarketplaceIndex;
     private _updateMarketplaceIndex;
@@ -36,8 +37,9 @@ export declare class AgentPluginRepositoryService implements IAgentPluginReposit
     private _getPluginDir;
     getPluginSourceInstallUri(sourceDescriptor: IPluginSourceDescriptor): URI;
     ensurePluginSource(plugin: IMarketplacePlugin, options?: IEnsureRepositoryOptions): Promise<URI>;
-    updatePluginSource(plugin: IMarketplacePlugin, options?: IPullRepositoryOptions): Promise<void>;
-    cleanupPluginSource(plugin: IMarketplacePlugin): Promise<void>;
+    updatePluginSource(plugin: IMarketplacePlugin, options?: IPullRepositoryOptions): Promise<boolean>;
+    fetchRepository(marketplace: IMarketplaceReference): Promise<boolean>;
+    cleanupPluginSource(plugin: IMarketplacePlugin, otherInstalledDescriptors?: readonly IPluginSourceDescriptor[]): Promise<void>;
     /**
      * Walk from {@link child}'s parent toward {@link _cacheRoot}, removing
      * each directory that is empty. Stops as soon as a non-empty directory

package/vscode/src/vs/workbench/contrib/chat/browser/agentPluginRepositoryService.js

@@ -1,6 +1,7 @@
 
 import { __decorate, __param } from '@codingame/monaco-vscode-api/external/tslib/tslib.es6';
 import { Action } from '@codingame/monaco-vscode-api/vscode/vs/base/common/actions';
+import { SequencerByKey } from '@codingame/monaco-vscode-api/vscode/vs/base/common/async';
 import { Lazy } from '@codingame/monaco-vscode-api/vscode/vs/base/common/lazy';
 import { revive } from '@codingame/monaco-vscode-api/vscode/vs/base/common/marshalling';
 import { joinPath, dirname, isEqualOrParent, isEqual } from '@codingame/monaco-vscode-api/vscode/vs/base/common/resources';
@@ -16,8 +17,9 @@ import { ProgressLocation } from '@codingame/monaco-vscode-api/vscode/vs/platfor
 import { IProgressService } from '@codingame/monaco-vscode-api/vscode/vs/platform/progress/common/progress.service';
 import { StorageScope, StorageTarget } from '@codingame/monaco-vscode-api/vscode/vs/platform/storage/common/storage';
 import { IStorageService } from '@codingame/monaco-vscode-api/vscode/vs/platform/storage/common/storage.service';
-import { PluginSourceKind, MarketplaceReferenceKind } from '../common/plugins/pluginMarketplaceService.js';
+import { PluginSourceKind } from '../common/plugins/pluginMarketplaceService.js';
 import { RelativePathPluginSource, GitHubPluginSource, GitUrlPluginSource, NpmPluginSource, PipPluginSource } from './pluginSources.js';
+import { MarketplaceReferenceKind } from '../common/plugins/marketplaceReference.js';
 import Severity from '@codingame/monaco-vscode-api/vscode/vs/base/common/severity';
 
 const MARKETPLACE_INDEX_STORAGE_KEY = "chat.plugins.marketplaces.index.v1";
@@ -39,6 +41,7 @@ let AgentPluginRepositoryService = class AgentPluginRepositoryService {
         this._progressService = _progressService;
         this._storageService = _storageService;
         this._marketplaceIndex = ( new Lazy(() => this._loadMarketplaceIndex()));
+        this._cloneSequencer = ( new SequencerByKey());
         this._cacheRoot = joinPath(environmentService.cacheHome, "agentPlugins");
         this._pluginSources = ( new Map([[PluginSourceKind.RelativePath, ( new RelativePathPluginSource())], [
             PluginSourceKind.GitHub,
@@ -71,19 +74,21 @@ let AgentPluginRepositoryService = class AgentPluginRepositoryService {
     }
     async ensureRepository(marketplace, options) {
         const repoDir = this.getRepositoryUri(marketplace, options?.marketplaceType);
-        const repoExists = await this._fileService.exists(repoDir);
-        if (repoExists) {
+        return this._cloneSequencer.queue(repoDir.fsPath, async () => {
+            const repoExists = await this._fileService.exists(repoDir);
+            if (repoExists) {
+                this._updateMarketplaceIndex(marketplace, repoDir, options?.marketplaceType);
+                return repoDir;
+            }
+            if (marketplace.kind === MarketplaceReferenceKind.LocalFileUri) {
+                throw ( new Error(`Local marketplace repository does not exist: ${repoDir.fsPath}`));
+            }
+            const progressTitle = options?.progressTitle ?? ( localize(5063, "Preparing plugin marketplace '{0}'...", marketplace.displayLabel));
+            const failureLabel = options?.failureLabel ?? marketplace.displayLabel;
+            await this._cloneRepository(repoDir, marketplace.cloneUrl, progressTitle, failureLabel);
             this._updateMarketplaceIndex(marketplace, repoDir, options?.marketplaceType);
             return repoDir;
-        }
-        if (marketplace.kind === MarketplaceReferenceKind.LocalFileUri) {
-            throw ( new Error(`Local marketplace repository does not exist: ${repoDir.fsPath}`));
-        }
-        const progressTitle = options?.progressTitle ?? ( localize(5019, "Preparing plugin marketplace '{0}'...", marketplace.displayLabel));
-        const failureLabel = options?.failureLabel ?? marketplace.displayLabel;
-        await this._cloneRepository(repoDir, marketplace.cloneUrl, progressTitle, failureLabel);
-        this._updateMarketplaceIndex(marketplace, repoDir, options?.marketplaceType);
-        return repoDir;
+        });
     }
     async pullRepository(marketplace, options) {
         const repoDir = this.getRepositoryUri(marketplace, options?.marketplaceType);
@@ -92,36 +97,43 @@ let AgentPluginRepositoryService = class AgentPluginRepositoryService {
             this._logService.warn(
                 `[AgentPluginRepositoryService] Cannot update plugin '${options?.pluginName ?? marketplace.displayLabel}': repository not cloned`
             );
-            return;
+            return false;
         }
         const updateLabel = options?.pluginName ?? marketplace.displayLabel;
         try {
-            await this._progressService.withProgress({
+            const doPull = async () => {
+                return !!(await this._commandService.executeCommand("_git.pull", repoDir.fsPath));
+            };
+            if (options?.silent) {
+                return await doPull();
+            }
+            return await this._progressService.withProgress({
                 location: ProgressLocation.Notification,
-                title: ( localize(5020, "Updating plugin '{0}'...", updateLabel)),
+                title: ( localize(5064, "Updating plugin '{0}'...", updateLabel)),
                 cancellable: false
-            }, async () => {
-                await this._commandService.executeCommand("_git.pull", repoDir.fsPath);
-            });
+            }, doPull);
         } catch (err) {
             this._logService.error(
                 `[AgentPluginRepositoryService] Failed to update ${marketplace.displayLabel}:`,
                 err
             );
-            this._notificationService.notify({
-                severity: Severity.Error,
-                message: ( localize(
-                    5021,
-                    "Failed to update plugin '{0}': {1}",
-                    options?.failureLabel ?? updateLabel,
-                    err?.message ?? String(err)
-                )),
-                actions: {
-                    primary: [( new Action("showGitOutput", ( localize(5022, "Show Git Output")), undefined, true, () => {
-                        this._commandService.executeCommand("git.showOutput");
-                    }))]
-                }
-            });
+            if (!options?.silent) {
+                this._notificationService.notify({
+                    severity: Severity.Error,
+                    message: ( localize(
+                        5065,
+                        "Failed to update plugin '{0}': {1}",
+                        options?.failureLabel ?? updateLabel,
+                        err?.message ?? String(err)
+                    )),
+                    actions: {
+                        primary: [( new Action("showGitOutput", ( localize(5066, "Show Git Output")), undefined, true, () => {
+                            this._commandService.executeCommand("git.showOutput");
+                        }))]
+                    }
+                });
+            }
+            throw err;
         }
     }
     _getRepoCacheDirForReference(reference) {
@@ -193,13 +205,13 @@ let AgentPluginRepositoryService = class AgentPluginRepositoryService {
             this._notificationService.notify({
                 severity: Severity.Error,
                 message: ( localize(
-                    5023,
+                    5067,
                     "Failed to install plugin '{0}': {1}",
                     failureLabel,
                     err?.message ?? String(err)
                 )),
                 actions: {
-                    primary: [( new Action("showGitOutput", ( localize(5022, "Show Git Output")), undefined, true, () => {
+                    primary: [( new Action("showGitOutput", ( localize(5066, "Show Git Output")), undefined, true, () => {
                         this._commandService.executeCommand("git.showOutput");
                     }))]
                 }
@@ -232,12 +244,43 @@ let AgentPluginRepositoryService = class AgentPluginRepositoryService {
         }
         return repo.update(this._cacheRoot, plugin, options);
     }
-    async cleanupPluginSource(plugin) {
+    async fetchRepository(marketplace) {
+        const repoDir = this.getRepositoryUri(marketplace);
+        const repoExists = await this._fileService.exists(repoDir);
+        if (!repoExists) {
+            return false;
+        }
+        try {
+            await this._commandService.executeCommand("_git.fetchRepository", repoDir.fsPath);
+            const behindCount = (await this._commandService.executeCommand("_git.revListCount", repoDir.fsPath, "HEAD", "@{u}")) ?? 0;
+            return behindCount > 0;
+        } catch (err) {
+            this._logService.debug(
+                `[AgentPluginRepositoryService] Silent fetch failed for ${marketplace.displayLabel}:`,
+                err
+            );
+            return false;
+        }
+    }
+    async cleanupPluginSource(plugin, otherInstalledDescriptors) {
         const repo = this.getPluginSource(plugin.sourceDescriptor.kind);
         const cleanupDir = repo.getCleanupTarget(this._cacheRoot, plugin.sourceDescriptor);
         if (!cleanupDir) {
             return;
         }
+        if (otherInstalledDescriptors) {
+            const shared = ( otherInstalledDescriptors.some(other => {
+                const otherRepo = this.getPluginSource(other.kind);
+                const otherTarget = otherRepo.getCleanupTarget(this._cacheRoot, other);
+                return otherTarget && isEqual(otherTarget, cleanupDir);
+            }));
+            if (shared) {
+                this._logService.info(
+                    `[${plugin.sourceDescriptor.kind}] Skipping cleanup of shared cache: ${( cleanupDir.toString())}`
+                );
+                return;
+            }
+        }
         try {
             const exists = await this._fileService.exists(cleanupDir);
             if (exists) {

package/vscode/src/vs/workbench/contrib/chat/browser/agentPluginsView.d.ts

@@ -44,8 +44,14 @@ export declare class AgentPluginsListView extends AbstractExtensionsListView<IAg
     private getContextMenuActions;
     protected layoutBody(height: number, width: number): void;
     show(query: string): Promise<IPagedModel<IAgentPluginItem>>;
+    /**
+     * Builds the installed plugin list using only cached marketplace data
+     * (no IO). The cached data is populated by {@link fetchMarketplacePlugins}
+     * and exposed via the {@link IPluginMarketplaceService.lastFetchedPlugins}
+     * observable, which the view's autorun subscribes to for reactivity.
+     */
     private queryInstalled;
-    private queryMarketplace;
+    private queryMarketplacePlugins;
     private updateBody;
 }
 export declare class AgentPluginsViewsContribution extends Disposable implements IWorkbenchContribution {