@codingame/monaco-vscode-api 5.3.0 → 6.0.0

package/vscode/src/vs/base/browser/ui/scrollbar/scrollbarVisibilityController.js

@@ -1,5 +1,6 @@
 import { TimeoutTimer } from '../../../common/async.js';
 import { Disposable } from '../../../common/lifecycle.js';
+import { ScrollbarVisibility } from '../../../common/scrollable.js';
 class ScrollbarVisibilityController extends Disposable {
     constructor(visibility, visibleClassName, invisibleClassName) {
         super();
@@ -24,10 +25,10 @@ class ScrollbarVisibilityController extends Disposable {
         this._updateShouldBeVisible();
     }
     _applyVisibilitySetting() {
-        if (this._visibility === 2 ) {
+        if (this._visibility === ScrollbarVisibility.Hidden) {
             return false;
         }
-        if (this._visibility === 3 ) {
+        if (this._visibility === ScrollbarVisibility.Visible) {
             return true;
         }
         return this._rawShouldBeVisible;

package/vscode/src/vs/base/browser/ui/scrollbar/verticalScrollbar.js

@@ -3,6 +3,7 @@ import { AbstractScrollbar } from './abstractScrollbar.js';
 import { ARROW_IMG_SIZE } from './scrollbarArrow.js';
 import { ScrollbarState } from './scrollbarState.js';
 import { Codicon } from '../../../common/codicons.js';
+import { ScrollbarVisibility } from '../../../common/scrollable.js';
 class VerticalScrollbar extends AbstractScrollbar {
     constructor(scrollable, options, host) {
         const scrollDimensions = scrollable.getScrollDimensions();
@@ -12,7 +13,7 @@ class VerticalScrollbar extends AbstractScrollbar {
             host: host,
             scrollbarState: ( new ScrollbarState(
                 (options.verticalHasArrows ? options.arrowSize : 0),
-                (options.vertical === 2  ? 0 : options.verticalScrollbarSize),
+                (options.vertical === ScrollbarVisibility.Hidden ? 0 : options.verticalScrollbarSize),
                 0,
                 scrollDimensions.height,
                 scrollDimensions.scrollHeight,
@@ -83,7 +84,7 @@ class VerticalScrollbar extends AbstractScrollbar {
         target.scrollTop = scrollPosition;
     }
     updateOptions(options) {
-        this.updateScrollbarSize(options.vertical === 2  ? 0 : options.verticalScrollbarSize);
+        this.updateScrollbarSize(options.vertical === ScrollbarVisibility.Hidden ? 0 : options.verticalScrollbarSize);
         this._scrollbarState.setOppositeScrollbarSize(0);
         this._visibilityController.setVisibility(options.vertical);
         this._scrollByPage = options.scrollByPage;

package/vscode/src/vs/base/browser/ui/selectBox/selectBox.js

@@ -36,6 +36,9 @@ class SelectBox extends Widget {
     setFocusable(focusable) {
         this.selectBoxDelegate.setFocusable(focusable);
     }
+    setEnabled(enabled) {
+        this.selectBoxDelegate.setEnabled(enabled);
+    }
     render(container) {
         this.selectBoxDelegate.render(container);
     }

package/vscode/src/vs/base/browser/ui/selectBox/selectBoxCustom.js

@@ -2,14 +2,16 @@ import { $ as $$1, append, createStyleSheet, addDisposableListener, addStandardD
 import { DomEmitter } from '../../event.js';
 import { StandardKeyboardEvent } from '../../keyboardEvent.js';
 import { renderMarkdown } from '../../markdownRenderer.js';
+import { AnchorPosition } from '../contextview/contextview.js';
 import { getBaseLayerHoverDelegate } from '../hover/hoverDelegate2.js';
 import { getDefaultHoverDelegate } from '../hover/hoverDelegateFactory.js';
 import { List } from '../list/listWidget.js';
 import { equals } from '../../../common/arrays.js';
 import { Emitter, Event } from '../../../common/event.js';
-import { KeyCodeUtils } from '../../../common/keyCodes.js';
+import { KeyCode, KeyCodeUtils } from '../../../common/keyCodes.js';
 import { Disposable } from '../../../common/lifecycle.js';
 import { isMacintosh } from '../../../common/platform.js';
+import { ScrollbarVisibility } from '../../../common/scrollable.js';
 import './selectBoxCustom.css.js';
 import { localizeWithPath } from '../../../../nls.js';
 const _moduleId = "vs/base/browser/ui/selectBox/selectBoxCustom";
@@ -106,7 +108,7 @@ class SelectBoxList extends Disposable {
         this.widthControlElement = document.createElement('span');
         this.widthControlElement.className = 'option-text-width-control';
         append(widthControlInnerDiv, this.widthControlElement);
-        this._dropDownPosition = 0 ;
+        this._dropDownPosition = AnchorPosition.BELOW;
         this.styleElement = createStyleSheet(this.selectDropDownContainer);
         this.selectDropDownContainer.setAttribute('draggable', 'true');
         this._register(addDisposableListener(this.selectDropDownContainer, EventType.DRAG_START, (e) => {
@@ -153,12 +155,12 @@ class SelectBoxList extends Disposable {
             const event = ( (new StandardKeyboardEvent(e)));
             let showDropDown = false;
             if (isMacintosh) {
-                if (event.keyCode === 18  || event.keyCode === 16  || event.keyCode === 10  || event.keyCode === 3 ) {
+                if (event.keyCode === KeyCode.DownArrow || event.keyCode === KeyCode.UpArrow || event.keyCode === KeyCode.Space || event.keyCode === KeyCode.Enter) {
                     showDropDown = true;
                 }
             }
             else {
-                if (event.keyCode === 18  && event.altKey || event.keyCode === 16  && event.altKey || event.keyCode === 10  || event.keyCode === 3 ) {
+                if (event.keyCode === KeyCode.DownArrow && event.altKey || event.keyCode === KeyCode.UpArrow && event.altKey || event.keyCode === KeyCode.Space || event.keyCode === KeyCode.Enter) {
                     showDropDown = true;
                 }
             }
@@ -189,6 +191,9 @@ class SelectBoxList extends Disposable {
             this._currentSelection = this.selected;
         }
     }
+    setEnabled(enable) {
+        this.selectElement.disabled = !enable;
+    }
     setOptionsList() {
         this.selectList?.splice(0, this.selectList.length, this.options);
     }
@@ -397,7 +402,7 @@ class SelectBoxList extends Disposable {
                 if (maxVisibleOptionsBelow < SelectBoxList.DEFAULT_MINIMUM_VISIBLE_OPTIONS
                     && maxVisibleOptionsAbove > maxVisibleOptionsBelow
                     && this.options.length > maxVisibleOptionsBelow) {
-                    this._dropDownPosition = 1 ;
+                    this._dropDownPosition = AnchorPosition.ABOVE;
                     this.selectDropDownContainer.removeChild(this.selectDropDownListContainer);
                     this.selectDropDownContainer.removeChild(this.selectionDetailsPane);
                     this.selectDropDownContainer.appendChild(this.selectionDetailsPane);
@@ -406,7 +411,7 @@ class SelectBoxList extends Disposable {
                     this.selectionDetailsPane.classList.add('border-bottom');
                 }
                 else {
-                    this._dropDownPosition = 0 ;
+                    this._dropDownPosition = AnchorPosition.BELOW;
                     this.selectDropDownContainer.removeChild(this.selectDropDownListContainer);
                     this.selectDropDownContainer.removeChild(this.selectionDetailsPane);
                     this.selectDropDownContainer.appendChild(this.selectDropDownListContainer);
@@ -418,12 +423,12 @@ class SelectBoxList extends Disposable {
             }
             if ((selectPosition.top + selectPosition.height) > (window.innerHeight - 22)
                 || selectPosition.top < SelectBoxList.DEFAULT_DROPDOWN_MINIMUM_TOP_MARGIN
-                || (this._dropDownPosition === 0  && maxVisibleOptionsBelow < 1)
-                || (this._dropDownPosition === 1  && maxVisibleOptionsAbove < 1)) {
+                || (this._dropDownPosition === AnchorPosition.BELOW && maxVisibleOptionsBelow < 1)
+                || (this._dropDownPosition === AnchorPosition.ABOVE && maxVisibleOptionsAbove < 1)) {
                 this.hideSelectDropDown(true);
                 return false;
             }
-            if (this._dropDownPosition === 0 ) {
+            if (this._dropDownPosition === AnchorPosition.BELOW) {
                 if (this._isVisible && maxVisibleOptionsBelow + maxVisibleOptionsAbove < 1) {
                     this.hideSelectDropDown(true);
                     return false;
@@ -493,7 +498,7 @@ class SelectBoxList extends Disposable {
             [this.listRenderer],
             {
                 useShadows: false,
-                verticalScrollMode: 3 ,
+                verticalScrollMode: ScrollbarVisibility.Visible,
                 keyboardSupport: false,
                 mouseSupport: false,
                 accessibilityProvider: {
@@ -522,16 +527,16 @@ class SelectBoxList extends Disposable {
         const onKeyDown = this._register(( (new DomEmitter(this.selectDropDownListContainer, 'keydown'))));
         const onSelectDropDownKeyDown = Event.chain(onKeyDown.event, $ => ( ($.filter(() => this.selectList.length > 0)
             .map(e => ( (new StandardKeyboardEvent(e)))))));
-        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === 3 ))(this.onEnter, this));
-        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === 2 ))(this.onEnter, this));
-        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === 9 ))(this.onEscape, this));
-        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === 16 ))(this.onUpArrow, this));
-        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === 18 ))(this.onDownArrow, this));
-        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === 12 ))(this.onPageDown, this));
-        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === 11 ))(this.onPageUp, this));
-        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === 14 ))(this.onHome, this));
-        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === 13 ))(this.onEnd, this));
-        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => ((e.keyCode >= 21  && e.keyCode <= 56) ) || ((e.keyCode >= 85  && e.keyCode <= 113) )))(this.onCharacter, this));
+        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === KeyCode.Enter))(this.onEnter, this));
+        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === KeyCode.Tab))(this.onEnter, this));
+        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === KeyCode.Escape))(this.onEscape, this));
+        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === KeyCode.UpArrow))(this.onUpArrow, this));
+        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === KeyCode.DownArrow))(this.onDownArrow, this));
+        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === KeyCode.PageDown))(this.onPageDown, this));
+        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === KeyCode.PageUp))(this.onPageUp, this));
+        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === KeyCode.Home))(this.onHome, this));
+        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => e.keyCode === KeyCode.End))(this.onEnd, this));
+        this._register(Event.chain(onSelectDropDownKeyDown, $ => $.filter(e => (e.keyCode >= KeyCode.Digit0 && e.keyCode <= KeyCode.KeyZ) || (e.keyCode >= KeyCode.Semicolon && e.keyCode <= KeyCode.NumpadDivide)))(this.onCharacter, this));
         this._register(addDisposableListener(this.selectList.getHTMLElement(), EventType.POINTER_UP, e => this.onPointerUp(e)));
         this._register(this.selectList.onMouseOver(e => typeof e.index !== 'undefined' && this.selectList.setFocus([e.index])));
         this._register(this.selectList.onDidChangeFocus(e => this.onListFocus(e)));

package/vscode/src/vs/base/browser/ui/selectBox/selectBoxNative.js

@@ -2,6 +2,7 @@ import { addDisposableListener, addStandardDisposableListener, EventHelper } fro
 import { Gesture, EventType } from '../../touch.js';
 import { equals } from '../../../common/arrays.js';
 import { Emitter } from '../../../common/event.js';
+import { KeyCode } from '../../../common/keyCodes.js';
 import { Disposable } from '../../../common/lifecycle.js';
 import { isMacintosh } from '../../../common/platform.js';
 class SelectBoxNative extends Disposable {
@@ -43,12 +44,12 @@ class SelectBoxNative extends Disposable {
         this._register(addStandardDisposableListener(this.selectElement, 'keydown', (e) => {
             let showSelect = false;
             if (isMacintosh) {
-                if (e.keyCode === 18  || e.keyCode === 16  || e.keyCode === 10 ) {
+                if (e.keyCode === KeyCode.DownArrow || e.keyCode === KeyCode.UpArrow || e.keyCode === KeyCode.Space) {
                     showSelect = true;
                 }
             }
             else {
-                if (e.keyCode === 18  && e.altKey || e.keyCode === 10  || e.keyCode === 3 ) {
+                if (e.keyCode === KeyCode.DownArrow && e.altKey || e.keyCode === KeyCode.Space || e.keyCode === KeyCode.Enter) {
                     showSelect = true;
                 }
             }
@@ -109,6 +110,9 @@ class SelectBoxNative extends Disposable {
             this.selectElement.blur();
         }
     }
+    setEnabled(enable) {
+        this.selectElement.disabled = !enable;
+    }
     setFocusable(focusable) {
         this.selectElement.tabIndex = focusable ? 0 : -1;
     }

package/vscode/src/vs/base/browser/ui/splitview/paneview.js

@@ -1,11 +1,13 @@
 import { isFirefox } from '../../browser.js';
 import { DataTransfers } from '../../dnd.js';
-import { $, getWindow, append, EventType, addDisposableListener, EventHelper, trackFocus, clearNode } from '../../dom.js';
+import { $, getWindow, append, EventType, addDisposableListener, EventHelper, trackFocus, isHTMLElement, clearNode } from '../../dom.js';
 import { DomEmitter } from '../../event.js';
 import { StandardKeyboardEvent } from '../../keyboardEvent.js';
 import { Gesture, EventType as EventType$1 } from '../../touch.js';
+import { Orientation } from '../sash/sash.js';
 import { Color, RGBA } from '../../../common/color.js';
 import { Emitter, Event } from '../../../common/event.js';
+import { KeyCode } from '../../../common/keyCodes.js';
 import { Disposable, DisposableStore } from '../../../common/lifecycle.js';
 import './paneview.css.js';
 import { localizeWithPath } from '../../../../nls.js';
@@ -78,9 +80,9 @@ class Pane extends Disposable {
         this.onDidChangeExpansionState = this._onDidChangeExpansionState.event;
         this.orthogonalSize = 0;
         this._expanded = typeof options.expanded === 'undefined' ? true : !!options.expanded;
-        this._orientation = typeof options.orientation === 'undefined' ? 0  : options.orientation;
+        this._orientation = typeof options.orientation === 'undefined' ? Orientation.VERTICAL : options.orientation;
         this._ariaHeaderLabel = ( localizeWithPath(_moduleId, 0, "{0} Section", options.title));
-        this._minimumBodySize = typeof options.minimumBodySize === 'number' ? options.minimumBodySize : this._orientation === 1  ? 200 : 120;
+        this._minimumBodySize = typeof options.minimumBodySize === 'number' ? options.minimumBodySize : this._orientation === Orientation.HORIZONTAL ? 200 : 120;
         this._maximumBodySize = typeof options.maximumBodySize === 'number' ? options.maximumBodySize : Number.POSITIVE_INFINITY;
         this.element = $('.pane');
     }
@@ -146,8 +148,8 @@ class Pane extends Disposable {
         }
         this._orientation = orientation;
         if (this.element) {
-            this.element.classList.toggle('horizontal', this.orientation === 1 );
-            this.element.classList.toggle('vertical', this.orientation === 0 );
+            this.element.classList.toggle('horizontal', this.orientation === Orientation.HORIZONTAL);
+            this.element.classList.toggle('vertical', this.orientation === Orientation.VERTICAL);
         }
         if (this.header) {
             this.updateHeader();
@@ -155,8 +157,8 @@ class Pane extends Disposable {
     }
     render() {
         this.element.classList.toggle('expanded', this.isExpanded());
-        this.element.classList.toggle('horizontal', this.orientation === 1 );
-        this.element.classList.toggle('vertical', this.orientation === 0 );
+        this.element.classList.toggle('horizontal', this.orientation === Orientation.HORIZONTAL);
+        this.element.classList.toggle('vertical', this.orientation === Orientation.VERTICAL);
         this.header = $('.pane-header');
         append(this.element, this.header);
         this.header.setAttribute('tabindex', '0');
@@ -175,9 +177,9 @@ class Pane extends Disposable {
             e => ( (new StandardKeyboardEvent(e))),
             eventDisposables
         )));
-        this._register(Event.filter(onHeaderKeyDown, e => e.keyCode === 3  || e.keyCode === 10 , eventDisposables)(() => this.setExpanded(!this.isExpanded()), null));
-        this._register(Event.filter(onHeaderKeyDown, e => e.keyCode === 15 , eventDisposables)(() => this.setExpanded(false), null));
-        this._register(Event.filter(onHeaderKeyDown, e => e.keyCode === 17 , eventDisposables)(() => this.setExpanded(true), null));
+        this._register(Event.filter(onHeaderKeyDown, e => e.keyCode === KeyCode.Enter || e.keyCode === KeyCode.Space, eventDisposables)(() => this.setExpanded(!this.isExpanded()), null));
+        this._register(Event.filter(onHeaderKeyDown, e => e.keyCode === KeyCode.LeftArrow, eventDisposables)(() => this.setExpanded(false), null));
+        this._register(Event.filter(onHeaderKeyDown, e => e.keyCode === KeyCode.RightArrow, eventDisposables)(() => this.setExpanded(true), null));
         this._register(Gesture.addTarget(this.header));
         [EventType.CLICK, EventType$1.Tap].forEach(eventType => {
             this._register(addDisposableListener(this.header, eventType, e => {
@@ -197,8 +199,8 @@ class Pane extends Disposable {
     }
     layout(size) {
         const headerSize = this.headerVisible ? Pane.HEADER_SIZE : 0;
-        const width = this._orientation === 0  ? this.orthogonalSize : size;
-        const height = this._orientation === 0  ? size - headerSize : this.orthogonalSize - headerSize;
+        const width = this._orientation === Orientation.VERTICAL ? this.orthogonalSize : size;
+        const height = this._orientation === Orientation.VERTICAL ? size - headerSize : this.orthogonalSize - headerSize;
         if (this.isExpanded()) {
             this.body.classList.toggle('wide', width >= 600);
             this.layoutBody(height, width);
@@ -229,8 +231,8 @@ class Pane extends Disposable {
         this.header.setAttribute('aria-expanded', String(expanded));
         this.header.style.color = this.collapsible ? this.styles.headerForeground ?? '' : '';
         this.header.style.backgroundColor = (this.collapsible ? this.styles.headerBackground : 'transparent') ?? '';
-        this.header.style.borderTop = this.styles.headerBorder && this.orientation === 0  ? `1px solid ${this.styles.headerBorder}` : '';
-        this.element.style.borderLeft = this.styles.leftBorder && this.orientation === 1  ? `1px solid ${this.styles.leftBorder}` : '';
+        this.header.style.borderTop = this.styles.headerBorder && this.orientation === Orientation.VERTICAL ? `1px solid ${this.styles.headerBorder}` : '';
+        this.element.style.borderLeft = this.styles.leftBorder && this.orientation === Orientation.HORIZONTAL ? `1px solid ${this.styles.leftBorder}` : '';
     }
 }
 class PaneDraggable extends Disposable {
@@ -326,7 +328,7 @@ class PaneView extends Disposable {
         this._onDidDrop = this._register(( (new Emitter())));
         this.onDidDrop = this._onDidDrop.event;
         this.dnd = options.dnd;
-        this.orientation = options.orientation ?? 0 ;
+        this.orientation = options.orientation ?? Orientation.VERTICAL;
         this.element = append(container, $('.monaco-pane-view'));
         this.splitview = this._register(( (new SplitView(this.element, { orientation: this.orientation }))));
         this.onDidSashReset = this.splitview.onDidSashReset;
@@ -335,12 +337,12 @@ class PaneView extends Disposable {
         const eventDisposables = this._register(( (new DisposableStore())));
         const onKeyDown = this._register(( (new DomEmitter(this.element, 'keydown'))));
         const onHeaderKeyDown = ( (Event.map(
-            Event.filter(onKeyDown.event, e => e.target instanceof HTMLElement && e.target.classList.contains('pane-header'), eventDisposables),
+            Event.filter(onKeyDown.event, e => isHTMLElement(e.target) && e.target.classList.contains('pane-header'), eventDisposables),
             e => ( (new StandardKeyboardEvent(e))),
             eventDisposables
         )));
-        this._register(Event.filter(onHeaderKeyDown, e => e.keyCode === 16 , eventDisposables)(() => this.focusPrevious()));
-        this._register(Event.filter(onHeaderKeyDown, e => e.keyCode === 18 , eventDisposables)(() => this.focusNext()));
+        this._register(Event.filter(onHeaderKeyDown, e => e.keyCode === KeyCode.UpArrow, eventDisposables)(() => this.focusPrevious()));
+        this._register(Event.filter(onHeaderKeyDown, e => e.keyCode === KeyCode.DownArrow, eventDisposables)(() => this.focusNext()));
     }
     addPane(pane, size, index = this.splitview.length) {
         const disposables = ( (new DisposableStore()));
@@ -390,8 +392,8 @@ class PaneView extends Disposable {
         return this.splitview.getViewSize(index);
     }
     layout(height, width) {
-        this.orthogonalSize = this.orientation === 0  ? width : height;
-        this.size = this.orientation === 1  ? width : height;
+        this.orthogonalSize = this.orientation === Orientation.VERTICAL ? width : height;
+        this.size = this.orientation === Orientation.HORIZONTAL ? width : height;
         for (const paneItem of this.paneItems) {
             paneItem.pane.orthogonalSize = this.orthogonalSize;
         }
@@ -402,7 +404,7 @@ class PaneView extends Disposable {
         this.updateSplitviewOrthogonalSashes(sashes);
     }
     updateSplitviewOrthogonalSashes(sashes) {
-        if (this.orientation === 0 ) {
+        if (this.orientation === Orientation.VERTICAL) {
             this.splitview.orthogonalStartSash = sashes?.left;
             this.splitview.orthogonalEndSash = sashes?.right;
         }
@@ -411,14 +413,14 @@ class PaneView extends Disposable {
         }
     }
     flipOrientation(height, width) {
-        this.orientation = this.orientation === 0  ? 1  : 0 ;
+        this.orientation = this.orientation === Orientation.VERTICAL ? Orientation.HORIZONTAL : Orientation.VERTICAL;
         const paneSizes = ( (this.paneItems.map(pane => this.getPaneSize(pane.pane))));
         this.splitview.dispose();
         clearNode(this.element);
         this.splitview = this._register(( (new SplitView(this.element, { orientation: this.orientation }))));
         this.updateSplitviewOrthogonalSashes(this.boundarySashes);
-        const newOrthogonalSize = this.orientation === 0  ? width : height;
-        const newSize = this.orientation === 1  ? width : height;
+        const newOrthogonalSize = this.orientation === Orientation.VERTICAL ? width : height;
+        const newSize = this.orientation === Orientation.HORIZONTAL ? width : height;
         this.paneItems.forEach((pane, index) => {
             pane.pane.orthogonalSize = newOrthogonalSize;
             pane.pane.orientation = this.orientation;

package/vscode/src/vs/base/browser/ui/splitview/splitview.js

@@ -1,18 +1,24 @@
 import { append, $, scheduleAtNextAnimationFrame, getWindow, addDisposableListener } from '../../dom.js';
 import { DomEmitter } from '../../event.js';
-import { Sash } from '../sash/sash.js';
+import { Orientation, SashState, Sash } from '../sash/sash.js';
 import { SmoothScrollableElement } from '../scrollbar/scrollableElement.js';
 import { range, pushToStart, pushToEnd } from '../../../common/arrays.js';
 import { Color } from '../../../common/color.js';
 import { Emitter, Event } from '../../../common/event.js';
 import { Disposable, combinedDisposable, dispose, toDisposable } from '../../../common/lifecycle.js';
 import { clamp } from '../../../common/numbers.js';
-import { Scrollable } from '../../../common/scrollable.js';
+import { Scrollable, ScrollbarVisibility } from '../../../common/scrollable.js';
 import { isUndefined } from '../../../common/types.js';
 import './splitview.css.js';
 const defaultStyles = {
     separatorBorder: Color.transparent
 };
+var LayoutPriority;
+( (function(LayoutPriority) {
+    LayoutPriority[LayoutPriority["Normal"] = 0] = "Normal";
+    LayoutPriority[LayoutPriority["Low"] = 1] = "Low";
+    LayoutPriority[LayoutPriority["High"] = 2] = "High";
+})(LayoutPriority || (LayoutPriority = {})));
 class ViewItem {
     set size(size) {
         this._size = size;
@@ -169,13 +175,13 @@ class SplitView extends Disposable {
         this._endSnappingEnabled = true;
         this.onDidSashChange = this._onDidSashChange.event;
         this.onDidSashReset = this._onDidSashReset.event;
-        this.orientation = options.orientation ?? 0 ;
+        this.orientation = options.orientation ?? Orientation.VERTICAL;
         this.inverseAltBehavior = options.inverseAltBehavior ?? false;
         this.proportionalLayout = options.proportionalLayout ?? true;
         this.getSashOrthogonalSize = options.getSashOrthogonalSize;
         this.el = document.createElement('div');
         this.el.classList.add('monaco-split-view2');
-        this.el.classList.add(this.orientation === 0  ? 'vertical' : 'horizontal');
+        this.el.classList.add(this.orientation === Orientation.VERTICAL ? 'vertical' : 'horizontal');
         container.appendChild(this.el);
         this.sashContainer = append(this.el, $('.sash-container'));
         this.viewContainer = $('.split-view-container');
@@ -185,8 +191,8 @@ class SplitView extends Disposable {
             scheduleAtNextAnimationFrame: callback => scheduleAtNextAnimationFrame(getWindow(this.el), callback),
         })));
         this.scrollableElement = this._register(( new SmoothScrollableElement(this.viewContainer, {
-            vertical: this.orientation === 0  ? ((options.scrollbarVisibility ?? 1) ) : 2 ,
-            horizontal: this.orientation === 1  ? ((options.scrollbarVisibility ?? 1) ) : 2
+            vertical: this.orientation === Orientation.VERTICAL ? (options.scrollbarVisibility ?? ScrollbarVisibility.Auto) : ScrollbarVisibility.Hidden,
+            horizontal: this.orientation === Orientation.HORIZONTAL ? (options.scrollbarVisibility ?? ScrollbarVisibility.Auto) : ScrollbarVisibility.Hidden
         }, this.scrollable)));
         const onDidScrollViewContainer = this._register(( new DomEmitter(this.viewContainer, 'scroll'))).event;
         this._register(onDidScrollViewContainer(_ => {
@@ -345,8 +351,8 @@ class SplitView extends Disposable {
         this.layoutContext = layoutContext;
         if (!this.proportions) {
             const indexes = range(this.viewItems.length);
-            const lowPriorityIndexes = indexes.filter(i => this.viewItems[i].priority === 1 );
-            const highPriorityIndexes = indexes.filter(i => this.viewItems[i].priority === 2 );
+            const lowPriorityIndexes = indexes.filter(i => this.viewItems[i].priority === LayoutPriority.Low);
+            const highPriorityIndexes = indexes.filter(i => this.viewItems[i].priority === LayoutPriority.High);
             this.resize(this.viewItems.length - 1, size - previousSize, undefined, lowPriorityIndexes, highPriorityIndexes);
         }
         else {
@@ -494,8 +500,8 @@ class SplitView extends Disposable {
         this.state = State.Busy;
         try {
             const indexes = range(this.viewItems.length).filter(i => i !== index);
-            const lowPriorityIndexes = [...indexes.filter(i => this.viewItems[i].priority === 1 ), index];
-            const highPriorityIndexes = indexes.filter(i => this.viewItems[i].priority === 2 );
+            const lowPriorityIndexes = [...indexes.filter(i => this.viewItems[i].priority === LayoutPriority.Low), index];
+            const highPriorityIndexes = indexes.filter(i => this.viewItems[i].priority === LayoutPriority.High);
             const item = this.viewItems[index];
             size = Math.round(size);
             size = clamp(size, item.minimumSize, Math.min(item.maximumSize, this.size));
@@ -531,8 +537,8 @@ class SplitView extends Disposable {
             item.size = clamp(size, item.minimumSize, item.maximumSize);
         }
         const indexes = range(this.viewItems.length);
-        const lowPriorityIndexes = indexes.filter(i => this.viewItems[i].priority === 1 );
-        const highPriorityIndexes = indexes.filter(i => this.viewItems[i].priority === 2 );
+        const lowPriorityIndexes = indexes.filter(i => this.viewItems[i].priority === LayoutPriority.Low);
+        const highPriorityIndexes = indexes.filter(i => this.viewItems[i].priority === LayoutPriority.High);
         this.relayout(lowPriorityIndexes, highPriorityIndexes);
     }
     getViewSize(index) {
@@ -580,24 +586,24 @@ class SplitView extends Disposable {
                     viewSize = view.minimumSize;
                 }
             }
-            const item = this.orientation === 0
+            const item = this.orientation === Orientation.VERTICAL
                 ? ( new VerticalViewItem(container, view, viewSize, disposable))
                 : ( new HorizontalViewItem(container, view, viewSize, disposable));
             this.viewItems.splice(index, 0, item);
             if (this.viewItems.length > 1) {
                 const opts = { orthogonalStartSash: this.orthogonalStartSash, orthogonalEndSash: this.orthogonalEndSash };
-                const sash = this.orientation === 0
+                const sash = this.orientation === Orientation.VERTICAL
                     ? ( new Sash(
                     this.sashContainer,
                     { getHorizontalSashTop: s => this.getSashPosition(s), getHorizontalSashWidth: this.getSashOrthogonalSize },
-                    { ...opts, orientation: 1  }
+                    { ...opts, orientation: Orientation.HORIZONTAL }
                 ))
                     : ( new Sash(
                     this.sashContainer,
                     { getVerticalSashLeft: s => this.getSashPosition(s), getVerticalSashHeight: this.getSashOrthogonalSize },
-                    { ...opts, orientation: 0  }
+                    { ...opts, orientation: Orientation.VERTICAL }
                 ));
-                const sashEventMapper = this.orientation === 0
+                const sashEventMapper = this.orientation === Orientation.VERTICAL
                     ? (e) => ({ sash, start: e.startY, current: e.currentY, alt: e.altKey })
                     : (e) => ({ sash, start: e.startX, current: e.currentX, alt: e.altKey });
                 const onStart = ( Event.map(sash.onDidStart, sashEventMapper));
@@ -712,8 +718,8 @@ class SplitView extends Disposable {
         const contentSize = this.viewItems.reduce((r, i) => r + i.size, 0);
         let emptyDelta = this.size - contentSize;
         const indexes = range(this.viewItems.length - 1, -1);
-        const lowPriorityIndexes = indexes.filter(i => this.viewItems[i].priority === 1 );
-        const highPriorityIndexes = indexes.filter(i => this.viewItems[i].priority === 2 );
+        const lowPriorityIndexes = indexes.filter(i => this.viewItems[i].priority === LayoutPriority.Low);
+        const highPriorityIndexes = indexes.filter(i => this.viewItems[i].priority === LayoutPriority.High);
         for (const index of highPriorityIndexes) {
             pushToStart(indexes, index);
         }
@@ -743,7 +749,7 @@ class SplitView extends Disposable {
         this.updateScrollableElement();
     }
     updateScrollableElement() {
-        if (this.orientation === 0 ) {
+        if (this.orientation === Orientation.VERTICAL) {
             this.scrollableElement.setScrollDimensions({
                 height: this.size,
                 scrollHeight: this._contentSize
@@ -781,23 +787,23 @@ class SplitView extends Disposable {
                 const snappedBefore = typeof snapBeforeIndex === 'number' && !this.viewItems[snapBeforeIndex].visible;
                 const snappedAfter = typeof snapAfterIndex === 'number' && !this.viewItems[snapAfterIndex].visible;
                 if (snappedBefore && collapsesUp[index] && (position > 0 || this.startSnappingEnabled)) {
-                    sash.state = 1 ;
+                    sash.state = SashState.AtMinimum;
                 }
                 else if (snappedAfter && collapsesDown[index] && (position < this._contentSize || this.endSnappingEnabled)) {
-                    sash.state = 2 ;
+                    sash.state = SashState.AtMaximum;
                 }
                 else {
-                    sash.state = 0 ;
+                    sash.state = SashState.Disabled;
                 }
             }
             else if (min && !max) {
-                sash.state = 1 ;
+                sash.state = SashState.AtMinimum;
             }
             else if (!min && max) {
-                sash.state = 2 ;
+                sash.state = SashState.AtMaximum;
             }
             else {
-                sash.state = 3 ;
+                sash.state = SashState.Enabled;
             }
         }
     }
@@ -852,4 +858,4 @@ class SplitView extends Disposable {
         super.dispose();
     }
 }
-export { Sizing, SplitView };
+export { LayoutPriority, Orientation, Sizing, SplitView };

package/vscode/src/vs/base/browser/ui/table/tableWidget.js

@@ -1,11 +1,13 @@
-import { append, $, clearNode, createStyleSheet, getContentHeight, getContentWidth } from '../../dom.js';
+import { append, $, createStyleSheet, getContentHeight, getContentWidth, clearNode } from '../../dom.js';
 import { getBaseLayerHoverDelegate } from '../hover/hoverDelegate2.js';
 import { getDefaultHoverDelegate } from '../hover/hoverDelegateFactory.js';
 import { List, unthemedListStyles } from '../list/listWidget.js';
 import { SplitView } from '../splitview/splitview.js';
 import { Event, Emitter } from '../../../common/event.js';
 import { DisposableStore, Disposable } from '../../../common/lifecycle.js';
+import { ScrollbarVisibility } from '../../../common/scrollable.js';
 import './table.css.js';
+import { Orientation } from '../sash/sash.js';
 class TableListRenderer {
     static { this.TemplateId = 'row'; }
     constructor(columns, renderers, getColumnSize) {
@@ -134,8 +136,8 @@ class Table {
             views: ( headers.map(view => ({ size: view.column.weight, view })))
         };
         this.splitview = this.disposables.add(( new SplitView(this.domNode, {
-            orientation: 1 ,
-            scrollbarVisibility: 2 ,
+            orientation: Orientation.HORIZONTAL,
+            scrollbarVisibility: ScrollbarVisibility.Hidden,
             getSashOrthogonalSize: () => this.cachedHeight,
             descriptor
         })));

package/vscode/src/vs/base/browser/ui/toggle/toggle.js

@@ -3,6 +3,7 @@ import { Widget } from '../widget.js';
 import { Codicon } from '../../../common/codicons.js';
 import { ThemeIcon } from '../../../common/themables.js';
 import { Emitter } from '../../../common/event.js';
+import { KeyCode } from '../../../common/keyCodes.js';
 import './toggle.css.js';
 import { isActiveElement, $, addDisposableListener, EventType } from '../../dom.js';
 import { getDefaultHoverDelegate } from '../hover/hoverDelegateFactory.js';
@@ -95,7 +96,7 @@ class Toggle extends Widget {
         });
         this._register(this.ignoreGesture(this.domNode));
         this.onkeydown(this.domNode, (keyboardEvent) => {
-            if (keyboardEvent.keyCode === 10  || keyboardEvent.keyCode === 3 ) {
+            if (keyboardEvent.keyCode === KeyCode.Space || keyboardEvent.keyCode === KeyCode.Enter) {
                 this.checked = !this._checked;
                 this._onChange.fire(true);
                 keyboardEvent.preventDefault();
@@ -157,6 +158,7 @@ class Toggle extends Widget {
     }
 }
 class Checkbox extends Widget {
+    static { this.CLASS_NAME = 'monaco-checkbox'; }
     constructor(title, isChecked, styles) {
         super();
         this.title = title;
@@ -164,7 +166,7 @@ class Checkbox extends Widget {
         this._onChange = this._register(( new Emitter()));
         this.onChange = this._onChange.event;
         this.checkbox = this._register(( new Toggle(
-            { title: this.title, isChecked: this.isChecked, icon: Codicon.check, actionClassName: 'monaco-checkbox', ...unthemedToggleStyles }
+            { title: this.title, isChecked: this.isChecked, icon: Codicon.check, actionClassName: Checkbox.CLASS_NAME, ...unthemedToggleStyles }
         )));
         this.domNode = this.checkbox.domNode;
         this.styles = styles;

package/vscode/src/vs/base/browser/ui/toolbar/toolbar.js

@@ -1,4 +1,4 @@
-import { ActionBar } from '../actionbar/actionbar.js';
+import { ActionBar, ActionsOrientation } from '../actionbar/actionbar.js';
 import { DropdownMenuActionViewItem } from '../dropdown/dropdownActionViewItem.js';
 import { Action, SubmenuAction } from '../../../common/actions.js';
 import { Codicon } from '../../../common/codicons.js';
@@ -10,7 +10,7 @@ import { localizeWithPath } from '../../../../nls.js';
 import { createInstantHoverDelegate } from '../hover/hoverDelegateFactory.js';
 const _moduleId = "vs/base/browser/ui/toolbar/toolbar";
 class ToolBar extends Disposable {
-    constructor(container, contextMenuProvider, options = { orientation: 0  }) {
+    constructor(container, contextMenuProvider, options = { orientation: ActionsOrientation.HORIZONTAL }) {
         super();
         this.submenuActionViewItems = [];
         this.hasSecondaryActions = false;