@codingame/monaco-vscode-api 5.2.0 → 6.0.0

package/vscode/src/vs/workbench/contrib/files/browser/views/explorerView.js

@@ -4,13 +4,15 @@ import { mark } from '../../../../../base/common/performance.js';
 import { memoize } from '../../../../../base/common/decorators.js';
 import { ExplorerFolderContext, ExplorerResourceReadonlyContext, ExplorerResourceAvailableEditorIdsContext, ExplorerRootContext, ExplorerResourceMoveableToTrash, ExplorerCompressedFocusContext, ExplorerCompressedFirstFocusContext, ExplorerCompressedLastFocusContext, ViewHasSomeCollapsibleRootItemContext, FoldersViewVisibleContext, ExplorerResourceCut, FilesExplorerFocusedContext, ExplorerFocusedContext, ExplorerResourceNotReadonlyContext, VIEW_ID } from '../../common/files.js';
 import { FileCopiedContext, NEW_FILE_COMMAND_ID, NEW_FOLDER_COMMAND_ID } from '../fileActions.js';
-import { append, $, addDisposableListener, getWindow, isAncestorOfActiveElement, isKeyboardEvent, getLargestChildWidth, EventType } from '../../../../../base/browser/dom.js';
+import { append, $, addDisposableListener, getWindow, isAncestorOfActiveElement, isKeyboardEvent, isHTMLElement, getLargestChildWidth, EventType } from '../../../../../base/browser/dom.js';
 import { IWorkbenchLayoutService } from '../../../../services/layout/browser/layoutService.service.js';
 import { ExplorerDecorationsProvider } from './explorerDecorationsProvider.js';
+import { WorkbenchState } from '../../../../../platform/workspace/common/workspace.js';
 import { IWorkspaceContextService } from '../../../../../platform/workspace/common/workspace.service.js';
 import { IConfigurationService } from '../../../../../platform/configuration/common/configuration.service.js';
 import { IKeybindingService } from '../../../../../platform/keybinding/common/keybinding.service.js';
 import { IInstantiationService } from '../../../../../platform/instantiation/common/instantiation.js';
+import { ProgressLocation } from '../../../../../platform/progress/common/progress.js';
 import { IProgressService } from '../../../../../platform/progress/common/progress.service.js';
 import { IContextMenuService } from '../../../../../platform/contextview/browser/contextView.service.js';
 import { ContextKeyExpr } from '../../../../../platform/contextkey/common/contextkey.js';
@@ -25,12 +27,15 @@ import { ViewPane } from '../../../../browser/parts/views/viewPane.js';
 import { ILabelService } from '../../../../../platform/label/common/label.service.js';
 import { FilesFilter, FilesRenderer, ExplorerDelegate, ExplorerCompressionDelegate, ExplorerDataSource, FileSorter, FileDragAndDrop, isCompressedFolderName } from './explorerViewer.js';
 import { IThemeService } from '../../../../../platform/theme/common/themeService.service.js';
+import { TreeVisibility } from '../../../../../base/browser/ui/tree/tree.js';
 import { MenuId, registerAction2, Action2 } from '../../../../../platform/actions/common/actions.js';
 import { ITelemetryService } from '../../../../../platform/telemetry/common/telemetry.service.js';
 import { ExplorerItem, NewExplorerItem } from '../../common/explorerModel.js';
 import { ResourceLabels } from '../../../../browser/labels.js';
+import { StorageScope, StorageTarget } from '../../../../../platform/storage/common/storage.js';
 import { IStorageService } from '../../../../../platform/storage/common/storage.service.js';
 import { IClipboardService } from '../../../../../platform/clipboard/common/clipboardService.service.js';
+import { FileSystemProviderCapabilities } from '../../../../../platform/files/common/files.js';
 import { IFileService } from '../../../../../platform/files/common/files.service.js';
 import { Event } from '../../../../../base/common/event.js';
 import { IViewDescriptorService } from '../../../../common/views.service.js';
@@ -45,6 +50,7 @@ import { IEditorResolverService } from '../../../../services/editor/common/edito
 import { EditorOpenSource } from '../../../../../platform/editor/common/editor.js';
 import { ResourceMap } from '../../../../../base/common/map.js';
 import { isInputElement } from '../../../../../base/browser/ui/list/listWidget.js';
+import { AbstractTreePart } from '../../../../../base/browser/ui/tree/abstractTree.js';
 import { IHoverService } from '../../../../../platform/hover/browser/hover.service.js';
 var ExplorerView_1;
 const _moduleId = "vs/workbench/contrib/files/browser/views/explorerView";
@@ -223,7 +229,7 @@ let ExplorerView = class ExplorerView extends ViewPane {
     focus() {
         super.focus();
         this.tree.domFocus();
-        if (this.tree.getFocusedPart() === 0 ) {
+        if (this.tree.getFocusedPart() === AbstractTreePart.Tree) {
             const focused = this.tree.getFocus();
             if (focused.length === 1 && this._autoReveal) {
                 this.tree.reveal(focused[0], 0.5);
@@ -243,7 +249,7 @@ let ExplorerView = class ExplorerView extends ViewPane {
         this.tree.focusLast();
     }
     getContext(respectMultiSelection) {
-        const focusedItems = this.tree.getFocusedPart() === 1  ?
+        const focusedItems = this.tree.getFocusedPart() === AbstractTreePart.StickyScroll ?
             this.tree.getStickyScrollFocus() :
             this.tree.getFocus();
         return getContext(focusedItems, this.tree.getSelection(), respectMultiSelection, this.renderer);
@@ -252,7 +258,7 @@ let ExplorerView = class ExplorerView extends ViewPane {
         if (!this.filter) {
             return false;
         }
-        return this.filter.filter(item, 1 );
+        return this.filter.filter(item, TreeVisibility.Visible);
     }
     isItemCollapsed(item) {
         return this.tree.isCollapsed(item);
@@ -415,7 +421,7 @@ let ExplorerView = class ExplorerView extends ViewPane {
         }
     }
     storeTreeViewState() {
-        this.storageService.store(ExplorerView_1.TREE_VIEW_STATE_STORAGE_KEY, JSON.stringify(this.tree.getViewState()), 1 , 1 );
+        this.storageService.store(ExplorerView_1.TREE_VIEW_STATE_STORAGE_KEY, JSON.stringify(this.tree.getViewState()), StorageScope.WORKSPACE, StorageTarget.MACHINE);
     }
     setContextKeys(stat) {
         const folders = this.contextService.getWorkspace().folders;
@@ -439,7 +445,7 @@ let ExplorerView = class ExplorerView extends ViewPane {
         }
         const stat = e.element;
         let anchor = e.anchor;
-        if (anchor instanceof HTMLElement) {
+        if (isHTMLElement(anchor)) {
             if (stat) {
                 const controllers = this.renderer.getCompressedNavigationController(stat);
                 if (controllers && controllers.length > 0) {
@@ -484,7 +490,7 @@ let ExplorerView = class ExplorerView extends ViewPane {
         this.setContextKeys(stat);
         if (stat) {
             const enableTrash = this.configurationService.getValue().files.enableTrash;
-            const hasCapability = this.fileService.hasCapability(stat.resource, 4096 );
+            const hasCapability = this.fileService.hasCapability(stat.resource, FileSystemProviderCapabilities.Trash);
             this.resourceMoveableToTrash.set(enableTrash && hasCapability);
         }
         else {
@@ -528,7 +534,7 @@ let ExplorerView = class ExplorerView extends ViewPane {
         }
         const roots = this.explorerService.roots;
         let input = roots[0];
-        if (this.contextService.getWorkbenchState() !== 2  || roots[0].error) {
+        if (this.contextService.getWorkbenchState() !== WorkbenchState.FOLDER || roots[0].error) {
             input = roots;
         }
         let viewState;
@@ -536,7 +542,7 @@ let ExplorerView = class ExplorerView extends ViewPane {
             viewState = this.tree.getViewState();
         }
         else {
-            const rawViewState = this.storageService.get(ExplorerView_1.TREE_VIEW_STATE_STORAGE_KEY, 1 );
+            const rawViewState = this.storageService.get(ExplorerView_1.TREE_VIEW_STATE_STORAGE_KEY, StorageScope.WORKSPACE);
             if (rawViewState) {
                 viewState = JSON.parse(rawViewState);
             }
@@ -573,7 +579,7 @@ let ExplorerView = class ExplorerView extends ViewPane {
             }
         });
         this.progressService.withProgress({
-            location: 1 ,
+            location: ProgressLocation.Explorer,
             delay: this.layoutService.isRestored() ? 800 : 1500
         }, _progress => promise);
         await promise;

package/vscode/src/vs/workbench/contrib/files/browser/views/explorerViewer.js

@@ -1,20 +1,25 @@
 import { __decorate, __param } from '../../../../../../../../external/tslib/tslib.es6.js';
-import { addDisposableListener, addStandardDisposableListener, getWindow, EventType, isActiveElement, hasParentWithClass } from '../../../../../base/browser/dom.js';
+import { addDisposableListener, addStandardDisposableListener, getWindow, isHTMLElement, EventType, isActiveElement, hasParentWithClass } from '../../../../../base/browser/dom.js';
 import { parse } from '../../../../../base/common/glob.js';
+import { ListDragOverEffectType, ListDragOverEffectPosition } from '../../../../../base/browser/ui/list/list.js';
+import { ProgressLocation } from '../../../../../platform/progress/common/progress.js';
 import { IProgressService } from '../../../../../platform/progress/common/progress.service.js';
 import '../../../../../platform/notification/common/notification.js';
 import { INotificationService } from '../../../../../platform/notification/common/notification.service.js';
-import { FileKind } from '../../../../../platform/files/common/files.js';
+import { FileKind, FileOperationResult, FileChangeType } from '../../../../../platform/files/common/files.js';
 import { IFileService } from '../../../../../platform/files/common/files.service.js';
 import { IWorkbenchLayoutService } from '../../../../services/layout/browser/layoutService.service.js';
-import { isTemporaryWorkspace } from '../../../../../platform/workspace/common/workspace.js';
+import { WorkbenchState, isTemporaryWorkspace } from '../../../../../platform/workspace/common/workspace.js';
 import { IWorkspaceContextService } from '../../../../../platform/workspace/common/workspace.service.js';
 import { DisposableStore, toDisposable, Disposable, dispose } from '../../../../../base/common/lifecycle.js';
+import { KeyCode } from '../../../../../base/common/keyCodes.js';
+import { TreeDragOverBubble, TreeVisibility } from '../../../../../base/browser/ui/tree/tree.js';
 import { IContextViewService, IContextMenuService } from '../../../../../platform/contextview/browser/contextView.service.js';
 import { IThemeService } from '../../../../../platform/theme/common/themeService.service.js';
 import { IConfigurationService } from '../../../../../platform/configuration/common/configuration.service.js';
+import { UndoConfirmLevel } from '../../common/files.js';
 import { dirname, joinPath, distinctParents } from '../../../../../base/common/resources.js';
-import { InputBox } from '../../../../../base/browser/ui/inputbox/inputBox.js';
+import { InputBox, MessageType } from '../../../../../base/browser/ui/inputbox/inputBox.js';
 import { localizeWithPath } from '../../../../../nls.js';
 import { createSingleCallFunction } from '../../../../../base/common/functional.js';
 import { equals, deepClone } from '../../../../../base/common/objects.js';
@@ -26,7 +31,7 @@ import { fillEditorsDragData } from '../../../../browser/dnd.js';
 import { IInstantiationService } from '../../../../../platform/instantiation/common/instantiation.js';
 import { DataTransfers } from '../../../../../base/browser/dnd.js';
 import { Schemas } from '../../../../../base/common/network.js';
-import { ExternalElementsDragAndDropData, NativeDragAndDropData } from '../../../../../base/browser/ui/list/listView.js';
+import { ExternalElementsDragAndDropData, NativeDragAndDropData, ListViewTargetSector } from '../../../../../base/browser/ui/list/listView.js';
 import { isWeb, isMacintosh } from '../../../../../base/common/platform.js';
 import { getFileNamesMessage } from '../../../../../platform/dialogs/common/dialogs.js';
 import { IDialogService } from '../../../../../platform/dialogs/common/dialogs.service.js';
@@ -34,9 +39,9 @@ import { IWorkspaceEditingService } from '../../../../services/workspaces/common
 import { IEditorService } from '../../../../services/editor/common/editorService.service.js';
 import { findValidPasteFileTarget } from '../fileActions.js';
 import { createMatches } from '../../../../../base/common/filters.js';
-import { EventMultiplexer, Event, Emitter } from '../../../../../base/common/event.js';
+import { Emitter, EventMultiplexer, Event } from '../../../../../base/common/event.js';
 import { ILabelService } from '../../../../../platform/label/common/label.service.js';
-import { isStringArray, isNumber } from '../../../../../base/common/types.js';
+import { isNumber } from '../../../../../base/common/types.js';
 import { IUriIdentityService } from '../../../../../platform/uriIdentity/common/uriIdentity.service.js';
 import { ResourceFileEdit } from '../../../../../editor/browser/services/bulkEditService.js';
 import { IExplorerService } from '../files.service.js';
@@ -48,7 +53,6 @@ import { ResourceSet } from '../../../../../base/common/map.js';
 import { TernarySearchTree } from '../../../../../base/common/ternarySearchTree.js';
 import { defaultInputBoxStyles } from '../../../../../platform/theme/browser/defaultStyles.js';
 import { timeout } from '../../../../../base/common/async.js';
-import { IHoverService } from '../../../../../platform/hover/browser/hover.service.js';
 import { IFilesConfigurationService } from '../../../../services/filesConfiguration/common/filesConfigurationService.service.js';
 import { mainWindow } from '../../../../../base/browser/window.js';
 import { explorerFileContribRegistry } from '../explorerFileContrib.js';
@@ -78,7 +82,7 @@ let ExplorerDataSource = class ExplorerDataSource {
         this.filesConfigService = filesConfigService;
     }
     hasChildren(element) {
-        return Array.isArray(element) || element.hasChildren((stat) => this.fileFilter.filter(stat, 1 ));
+        return Array.isArray(element) || element.hasChildren((stat) => this.fileFilter.filter(stat, TreeVisibility.Visible));
     }
     getChildren(element) {
         if (Array.isArray(element)) {
@@ -91,13 +95,13 @@ let ExplorerDataSource = class ExplorerDataSource {
             return children;
         }
         const promise = children.then(children => {
-            if (element instanceof ExplorerItem && element.isRoot && !element.error && hasError && this.contextService.getWorkbenchState() !== 2 ) {
+            if (element instanceof ExplorerItem && element.isRoot && !element.error && hasError && this.contextService.getWorkbenchState() !== WorkbenchState.FOLDER) {
                 explorerRootErrorEmitter.fire(element.resource);
             }
             return children;
         }, e => {
             if (element instanceof ExplorerItem && element.isRoot) {
-                if (this.contextService.getWorkbenchState() === 2 ) {
+                if (this.contextService.getWorkbenchState() === WorkbenchState.FOLDER) {
                     const placeholder = ( (new ExplorerItem(
                         element.resource,
                         this.fileService,
@@ -120,7 +124,7 @@ let ExplorerDataSource = class ExplorerDataSource {
             return [];
         });
         this.progressService.withProgress({
-            location: 1 ,
+            location: ProgressLocation.Explorer,
             delay: this.layoutService.isRestored() ? 800 : 1500
         }, _progress => promise);
         return promise;
@@ -215,7 +219,7 @@ class CompressedNavigationController {
 let FilesRenderer = class FilesRenderer {
     static { FilesRenderer_1 = this; }
     static { this.ID = 'file'; }
-    constructor(container, labels, updateWidth, contextViewService, themeService, configurationService, explorerService, labelService, contextService, contextMenuService, hoverService, instantiationService) {
+    constructor(container, labels, updateWidth, contextViewService, themeService, configurationService, explorerService, labelService, contextService, contextMenuService, instantiationService) {
         this.labels = labels;
         this.updateWidth = updateWidth;
         this.contextViewService = contextViewService;
@@ -225,71 +229,10 @@ let FilesRenderer = class FilesRenderer {
         this.labelService = labelService;
         this.contextService = contextService;
         this.contextMenuService = contextMenuService;
-        this.hoverService = hoverService;
         this.instantiationService = instantiationService;
         this.compressedNavigationControllers = ( (new Map()));
         this._onDidChangeActiveDescendant = ( (new EventMultiplexer()));
         this.onDidChangeActiveDescendant = this._onDidChangeActiveDescendant.event;
-        this.hoverDelegate = new (class {
-            get delay() {
-                if (Date.now() - this.lastHoverHideTime < 500) {
-                    return 0;
-                }
-                return this.configurationService.getValue('workbench.hover.delay');
-            }
-            constructor(configurationService, hoverService) {
-                this.configurationService = configurationService;
-                this.hoverService = hoverService;
-                this.lastHoverHideTime = 0;
-                this.hiddenFromClick = false;
-                this.placement = 'element';
-            }
-            showHover(options, focus) {
-                let element;
-                if (options.target instanceof HTMLElement) {
-                    element = options.target;
-                }
-                else {
-                    element = options.target.targetElements[0];
-                }
-                const tlRow = element.closest('.monaco-tl-row');
-                const listRow = tlRow?.closest('.monaco-list-row');
-                const child = element.querySelector('div.monaco-icon-label-container');
-                const childOfChild = child?.querySelector('span.monaco-icon-name-container');
-                let overflowed = false;
-                if (childOfChild && child) {
-                    const width = child.clientWidth;
-                    const childWidth = childOfChild.offsetWidth;
-                    overflowed = width <= childWidth;
-                }
-                const hasDecoration = ( (options.content.toString())).includes('•');
-                overflowed = overflowed || hasDecoration;
-                const indentGuideElement = tlRow?.querySelector('.monaco-tl-indent');
-                if (!indentGuideElement) {
-                    return;
-                }
-                return overflowed ? this.hoverService.showHover({
-                    ...options,
-                    target: indentGuideElement,
-                    container: listRow,
-                    additionalClasses: ['explorer-item-hover'],
-                    position: {
-                        hoverPosition: 1 ,
-                    },
-                    appearance: {
-                        compact: true,
-                        skipFadeInAnimation: true,
-                        showPointer: false,
-                    }
-                }, focus) : undefined;
-            }
-            onDidHideHover() {
-                if (!this.hiddenFromClick) {
-                    this.lastHoverHideTime = Date.now();
-                }
-                this.hiddenFromClick = false;
-            }
-        })(this.configurationService, this.hoverService);
         this.config = this.configurationService.getValue();
         const updateOffsetStyles = () => {
             const indent = this.configurationService.getValue('workbench.tree.indent');
@@ -314,8 +257,7 @@ let FilesRenderer = class FilesRenderer {
     }
     renderTemplate(container) {
         const templateDisposables = ( (new DisposableStore()));
-        const experimentalHover = this.configurationService.getValue('explorer.experimental.hover');
-        const label = templateDisposables.add(this.labels.create(container, { supportHighlights: true, hoverDelegate: experimentalHover ? this.hoverDelegate : undefined }));
+        const label = templateDisposables.add(this.labels.create(container, { supportHighlights: true }));
         templateDisposables.add(label.onDidRender(() => {
             try {
                 if (templateData.currentContext) {
@@ -326,6 +268,11 @@ let FilesRenderer = class FilesRenderer {
             }
         }));
         const contribs = explorerFileContribRegistry.create(this.instantiationService, container, templateDisposables);
+        templateDisposables.add(explorerFileContribRegistry.onDidRegisterDescriptor(d => {
+            const contr = d.create(this.instantiationService, container);
+            contribs.push(templateDisposables.add(contr));
+            contr.setResource(templateData.currentContext?.resource);
+        }));
         const templateData = { templateDisposables, elementDisposables: templateDisposables.add(( (new DisposableStore()))), label, container, contribs };
         return templateData;
     }
@@ -398,10 +345,8 @@ let FilesRenderer = class FilesRenderer {
         twistieContainer?.classList.toggle('force-twistie', stat.hasNests && theme.hidesExplorerArrows);
         const themeIsUnhappyWithNesting = theme.hasFileIcons && (theme.hidesExplorerArrows || !theme.hasFolderIcons);
         const realignNestedChildren = stat.nestedParent && themeIsUnhappyWithNesting;
-        const experimentalHover = this.configurationService.getValue('explorer.experimental.hover');
         templateData.contribs.forEach(c => c.setResource(stat.resource));
         templateData.label.setResource({ resource: stat.resource, name: label }, {
-            title: experimentalHover ? isStringArray(label) ? label[0] : label : undefined,
             fileKind: stat.isRoot ? FileKind.ROOT_FOLDER : stat.isDirectory ? FileKind.FOLDER : FileKind.FILE,
             extraClasses: realignNestedChildren ? [...extraClasses, 'align-nest-icon-with-parent-icon'] : extraClasses,
             fileDecorations: this.config.explorer.decorations,
@@ -437,7 +382,7 @@ let FilesRenderer = class FilesRenderer {
                     return {
                         content: message.content,
                         formatContent: true,
-                        type: 3
+                        type: MessageType.ERROR
                     };
                 }
             },
@@ -469,7 +414,7 @@ let FilesRenderer = class FilesRenderer {
                     inputBox.showMessage({
                         content: message.content,
                         formatContent: true,
-                        type: message.severity === Severity$1.Info ? 1  : message.severity === Severity$1.Warning ? 2  : 3
+                        type: message.severity === Severity$1.Info ? MessageType.INFO : message.severity === Severity$1.Warning ? MessageType.WARNING : MessageType.ERROR
                     });
                 }
                 else {
@@ -484,7 +429,7 @@ let FilesRenderer = class FilesRenderer {
                 label.setFile(joinPath(parent, value || ' '), labelOptions);
             }),
             addStandardDisposableListener(inputBox.inputElement, EventType.KEY_DOWN, (e) => {
-                if (e.equals(60 )) {
+                if (e.equals(KeyCode.F2)) {
                     const dotIndex = inputBox.value.lastIndexOf('.');
                     if (stat.isDirectory || dotIndex === -1) {
                         return;
@@ -502,12 +447,12 @@ let FilesRenderer = class FilesRenderer {
                         inputBox.select({ start: 0, end: dotIndex });
                     }
                 }
-                else if (e.equals(3 )) {
+                else if (e.equals(KeyCode.Enter)) {
                     if (!inputBox.validate()) {
                         done(true, true);
                     }
                 }
-                else if (e.equals(9 )) {
+                else if (e.equals(KeyCode.Escape)) {
                     done(false, true);
                 }
             }),
@@ -524,7 +469,7 @@ let FilesRenderer = class FilesRenderer {
                     if (isActiveElement(inputBox.inputElement)) {
                         return;
                     }
-                    else if (ownerDocument.activeElement instanceof HTMLElement && hasParentWithClass(ownerDocument.activeElement, 'context-view')) {
+                    else if (isHTMLElement(ownerDocument.activeElement) && hasParentWithClass(ownerDocument.activeElement, 'context-view')) {
                         await Event.toPromise(this.contextMenuService.onDidHideContextMenu);
                     }
                     else {
@@ -563,7 +508,7 @@ let FilesRenderer = class FilesRenderer {
             parent = parent.parent;
             depth++;
         }
-        if (this.contextService.getWorkbenchState() === 3 ) {
+        if (this.contextService.getWorkbenchState() === WorkbenchState.WORKSPACE) {
             depth = depth + 1;
         }
         return depth;
@@ -583,8 +528,7 @@ FilesRenderer = FilesRenderer_1 = ( (__decorate([
     ( (__param(7, ILabelService))),
     ( (__param(8, IWorkspaceContextService))),
     ( (__param(9, IContextMenuService))),
-    ( (__param(10, IHoverService))),
-    ( (__param(11, IInstantiationService)))
+    ( (__param(10, IInstantiationService)))
 ], FilesRenderer)));
 let FilesFilter = class FilesFilter {
     constructor(contextService, configurationService, explorerService, editorService, uriIdentityService, fileService) {
@@ -609,10 +553,10 @@ let FilesFilter = class FilesFilter {
         this.toDispose.push(this.fileService.onDidFilesChange(e => {
             for (const [root, ignoreFileResourceSet] of this.ignoreFileResourcesPerRoot.entries()) {
                 ignoreFileResourceSet.forEach(async (ignoreResource) => {
-                    if (e.contains(ignoreResource, 0 )) {
+                    if (e.contains(ignoreResource, FileChangeType.UPDATED)) {
                         await this.processIgnoreFile(root, ignoreResource, true);
                     }
-                    if (e.contains(ignoreResource, 2 )) {
+                    if (e.contains(ignoreResource, FileChangeType.DELETED)) {
                         this.ignoreTreesPerRoot.get(root)?.delete(dirname(ignoreResource));
                         ignoreFileResourceSet.delete(ignoreResource);
                         this._onDidChange.fire();
@@ -711,7 +655,7 @@ let FilesFilter = class FilesFilter {
     }
     isVisible(stat, parentVisibility) {
         stat.isExcluded = false;
-        if (parentVisibility === 0 ) {
+        if (parentVisibility === TreeVisibility.Hidden) {
             stat.isExcluded = true;
             return false;
         }
@@ -905,8 +849,8 @@ let FileDragAndDrop = class FileDragAndDrop {
     handleDragOver(data, target, targetIndex, targetSector, originalEvent) {
         const isCopy = originalEvent && ((originalEvent.ctrlKey && !isMacintosh) || (originalEvent.altKey && isMacintosh));
         const isNative = data instanceof NativeDragAndDropData;
-        const effectType = (isNative || isCopy) ? 0  : 1 ;
-        const effect = { type: effectType, position: "drop-target"  };
+        const effectType = (isNative || isCopy) ? ListDragOverEffectType.Copy : ListDragOverEffectType.Move;
+        const effect = { type: effectType, position: ListDragOverEffectPosition.Over };
         if (isNative) {
             if (!containsDragType(originalEvent, DataTransfers.FILES, CodeDataTransfers.FILES, DataTransfers.RESOURCES)) {
                 return false;
@@ -923,9 +867,9 @@ let FileDragAndDrop = class FileDragAndDrop {
                     return false;
                 }
                 if (isRootsReorder) {
-                    return { accept: true, effect: { type: 1 , position: "drop-target-after"  } };
+                    return { accept: true, effect: { type: ListDragOverEffectType.Move, position: ListDragOverEffectPosition.After } };
                 }
-                return { accept: true, bubble: 0 , effect, autoExpand: false };
+                return { accept: true, bubble: TreeDragOverBubble.Down, effect, autoExpand: false };
             }
             if (!Array.isArray(items)) {
                 return false;
@@ -956,30 +900,30 @@ let FileDragAndDrop = class FileDragAndDrop {
                 }
                 let dropEffectPosition = undefined;
                 switch (targetSector) {
-                    case 0 :
-                    case 1 :
-                        dropEffectPosition = "drop-target-before" ;
+                    case ListViewTargetSector.TOP:
+                    case ListViewTargetSector.CENTER_TOP:
+                        dropEffectPosition = ListDragOverEffectPosition.Before;
                         break;
-                    case 2 :
-                    case 3 :
-                        dropEffectPosition = "drop-target-after" ;
+                    case ListViewTargetSector.CENTER_BOTTOM:
+                    case ListViewTargetSector.BOTTOM:
+                        dropEffectPosition = ListDragOverEffectPosition.After;
                         break;
                 }
-                return { accept: true, effect: { type: 1 , position: dropEffectPosition } };
+                return { accept: true, effect: { type: ListDragOverEffectType.Move, position: dropEffectPosition } };
             }
         }
         if (!target) {
-            return { accept: true, bubble: 0 , effect };
+            return { accept: true, bubble: TreeDragOverBubble.Down, effect };
         }
         else {
             if (target.isDirectory) {
                 if (target.isReadonly) {
                     return false;
                 }
-                return { accept: true, bubble: 0 , effect, autoExpand: true };
+                return { accept: true, bubble: TreeDragOverBubble.Down, effect, autoExpand: true };
             }
             if (this.contextService.getWorkspace().folders.every(folder => ( (folder.uri.toString())) !== ( (target.resource.toString())))) {
-                return { accept: true, bubble: 1 , effect };
+                return { accept: true, bubble: TreeDragOverBubble.Up, effect };
             }
         }
         return false;
@@ -1019,7 +963,7 @@ let FileDragAndDrop = class FileDragAndDrop {
         }
         if (!target) {
             target = this.explorerService.roots[this.explorerService.roots.length - 1];
-            targetSector = 3 ;
+            targetSector = ListViewTargetSector.BOTTOM;
         }
         if (!target.isDirectory && target.parent) {
             target = target.parent;
@@ -1152,8 +1096,8 @@ let FileDragAndDrop = class FileDragAndDrop {
         }
         else {
             switch (targetSector) {
-                case 3 :
-                case 2 :
+                case ListViewTargetSector.BOTTOM:
+                case ListViewTargetSector.CENTER_BOTTOM:
                     targetIndex++;
                     break;
             }
@@ -1180,7 +1124,7 @@ let FileDragAndDrop = class FileDragAndDrop {
         }
         const labelSuffix = getFileOrFolderLabelSuffix(sources);
         await this.explorerService.applyBulkEdit(resourceFileEdits, {
-            confirmBeforeUndo: explorerConfig.confirmUndo === "default"  || explorerConfig.confirmUndo === "verbose" ,
+            confirmBeforeUndo: explorerConfig.confirmUndo === UndoConfirmLevel.Default || explorerConfig.confirmUndo === UndoConfirmLevel.Verbose,
             undoLabel: ( localizeWithPath(_moduleId, 8, "Copy {0}", labelSuffix)),
             progressLabel: ( localizeWithPath(_moduleId, 9, "Copying {0}", labelSuffix)),
         });
@@ -1196,7 +1140,7 @@ let FileDragAndDrop = class FileDragAndDrop {
         )));
         const labelSuffix = getFileOrFolderLabelSuffix(sources);
         const options = {
-            confirmBeforeUndo: this.configurationService.getValue().explorer.confirmUndo === "verbose" ,
+            confirmBeforeUndo: this.configurationService.getValue().explorer.confirmUndo === UndoConfirmLevel.Verbose,
             undoLabel: ( localizeWithPath(_moduleId, 10, "Move {0}", labelSuffix)),
             progressLabel: ( localizeWithPath(_moduleId, 11, "Moving {0}", labelSuffix))
         };
@@ -1204,7 +1148,7 @@ let FileDragAndDrop = class FileDragAndDrop {
             await this.explorerService.applyBulkEdit(resourceFileEdits, options);
         }
         catch (error) {
-            if (error.fileOperationResult === 4 ) {
+            if (error.fileOperationResult === FileOperationResult.FILE_MOVE_CONFLICT) {
                 const overwrites = [];
                 for (const edit of resourceFileEdits) {
                     if (edit.newResource && (await this.fileService.exists(edit.newResource))) {
@@ -1267,7 +1211,7 @@ FileDragAndDrop = FileDragAndDrop_1 = ( (__decorate([
     ( (__param(9, IUriIdentityService)))
 ], FileDragAndDrop)));
 function getIconLabelNameFromHTMLElement(target) {
-    if (!(target instanceof HTMLElement)) {
+    if (!(isHTMLElement(target))) {
         return null;
     }
     let element = target;