@codingame/monaco-vscode-api 28.4.1 → 29.1.0

package/vscode/src/vs/workbench/browser/parts/editor/editorCommands.js

@@ -143,11 +143,11 @@ function registerEditorMoveCopyCommand() {
         primary: 0,
         handler: (accessor, args) => moveCopySelectedEditors(true, args, accessor),
         metadata: {
-            description: ( localize(3432, "Move the active editor by tabs or groups")),
+            description: ( localize(3440, "Move the active editor by tabs or groups")),
             args: [{
-                name: ( localize(3433, "Active editor move argument")),
+                name: ( localize(3441, "Active editor move argument")),
                 description: ( localize(
-                    3434,
+                    3442,
                     "Argument Properties:\n\t* 'to': String value providing where to move.\n\t* 'by': String value providing the unit for move (by tab or by group).\n\t* 'value': Number value providing how many positions or an absolute position to move."
                 )),
                 constraint: isSelectedEditorsMoveCopyArg,
@@ -162,11 +162,11 @@ function registerEditorMoveCopyCommand() {
         primary: 0,
         handler: (accessor, args) => moveCopySelectedEditors(false, args, accessor),
         metadata: {
-            description: ( localize(3435, "Copy the active editor by groups")),
+            description: ( localize(3443, "Copy the active editor by groups")),
             args: [{
-                name: ( localize(3436, "Active editor copy argument")),
+                name: ( localize(3444, "Active editor copy argument")),
                 description: ( localize(
-                    3437,
+                    3445,
                     "Argument Properties:\n\t* 'to': String value providing where to copy.\n\t* 'value': Number value providing how many positions or an absolute position to copy."
                 )),
                 constraint: isSelectedEditorsMoveCopyArg,
@@ -376,7 +376,7 @@ function registerEditorGroupsLayoutCommands() {
                             "default": 0,
                             "description": `The orientation of the root group in the layout. 0 for horizontal, 1 for vertical.`,
                             "enum": [0, 1],
-                            "enumDescriptions": [( localize(3438, "Horizontal")), ( localize(3439, "Vertical"))]
+                            "enumDescriptions": [( localize(3446, "Horizontal")), ( localize(3447, "Vertical"))]
                         },
                         "groups": {
                             "$ref": "#/definitions/editorGroupsSchema",
@@ -1119,7 +1119,7 @@ function registerSplitEditorInGroupCommands() {
         constructor() {
             super({
                 id: SPLIT_EDITOR_IN_GROUP,
-                title: ( localize2(3440, "Split Editor in Group")),
+                title: ( localize2(3448, "Split Editor in Group")),
                 category: Categories.View,
                 precondition: ActiveEditorCanSplitInGroupContext,
                 f1: true,
@@ -1182,7 +1182,7 @@ function registerSplitEditorInGroupCommands() {
         constructor() {
             super({
                 id: JOIN_EDITOR_IN_GROUP,
-                title: ( localize2(3441, "Join Editor in Group")),
+                title: ( localize2(3449, "Join Editor in Group")),
                 category: Categories.View,
                 precondition: SideBySideEditorActiveContext,
                 f1: true,
@@ -1209,7 +1209,7 @@ function registerSplitEditorInGroupCommands() {
         constructor() {
             super({
                 id: TOGGLE_SPLIT_EDITOR_IN_GROUP,
-                title: ( localize2(3442, "Toggle Split Editor in Group")),
+                title: ( localize2(3450, "Toggle Split Editor in Group")),
                 category: Categories.View,
                 precondition: ( ContextKeyExpr.or(ActiveEditorCanSplitInGroupContext, SideBySideEditorActiveContext)),
                 f1: true
@@ -1239,7 +1239,7 @@ function registerSplitEditorInGroupCommands() {
         constructor() {
             super({
                 id: TOGGLE_SPLIT_EDITOR_IN_GROUP_LAYOUT,
-                title: ( localize2(3443, "Toggle Layout of Split Editor in Group")),
+                title: ( localize2(3451, "Toggle Layout of Split Editor in Group")),
                 category: Categories.View,
                 precondition: SideBySideEditorActiveContext,
                 f1: true
@@ -1263,7 +1263,7 @@ function registerFocusSideEditorsCommands() {
         constructor() {
             super({
                 id: FOCUS_FIRST_SIDE_EDITOR,
-                title: ( localize2(3444, "Focus First Side in Active Editor")),
+                title: ( localize2(3452, "Focus First Side in Active Editor")),
                 category: Categories.View,
                 precondition: ( ContextKeyExpr.or(SideBySideEditorActiveContext, TextCompareEditorActiveContext)),
                 f1: true
@@ -1284,7 +1284,7 @@ function registerFocusSideEditorsCommands() {
         constructor() {
             super({
                 id: FOCUS_SECOND_SIDE_EDITOR,
-                title: ( localize2(3445, "Focus Second Side in Active Editor")),
+                title: ( localize2(3453, "Focus Second Side in Active Editor")),
                 category: Categories.View,
                 precondition: ( ContextKeyExpr.or(SideBySideEditorActiveContext, TextCompareEditorActiveContext)),
                 f1: true
@@ -1305,7 +1305,7 @@ function registerFocusSideEditorsCommands() {
         constructor() {
             super({
                 id: FOCUS_OTHER_SIDE_EDITOR,
-                title: ( localize2(3446, "Focus Other Side in Active Editor")),
+                title: ( localize2(3454, "Focus Other Side in Active Editor")),
                 category: Categories.View,
                 precondition: ( ContextKeyExpr.or(SideBySideEditorActiveContext, TextCompareEditorActiveContext)),
                 f1: true
@@ -1373,7 +1373,7 @@ function registerOtherEditorCommands() {
         constructor() {
             super({
                 id: TOGGLE_LOCK_GROUP_COMMAND_ID,
-                title: ( localize2(3447, "Toggle Editor Group Lock")),
+                title: ( localize2(3455, "Toggle Editor Group Lock")),
                 category: Categories.View,
                 f1: true
             });
@@ -1386,7 +1386,7 @@ function registerOtherEditorCommands() {
         constructor() {
             super({
                 id: LOCK_GROUP_COMMAND_ID,
-                title: ( localize2(3448, "Lock Editor Group")),
+                title: ( localize2(3456, "Lock Editor Group")),
                 category: Categories.View,
                 precondition: ( ActiveEditorGroupLockedContext.toNegated()),
                 f1: true
@@ -1400,7 +1400,7 @@ function registerOtherEditorCommands() {
         constructor() {
             super({
                 id: UNLOCK_GROUP_COMMAND_ID,
-                title: ( localize2(3449, "Unlock Editor Group")),
+                title: ( localize2(3457, "Unlock Editor Group")),
                 precondition: ActiveEditorGroupLockedContext,
                 category: Categories.View,
                 f1: true
@@ -1481,7 +1481,7 @@ function registerModalEditorCommands() {
         constructor() {
             super({
                 id: MOVE_MODAL_EDITOR_TO_MAIN_COMMAND_ID,
-                title: ( localize2(3450, "Open Modal Editor in Main Window")),
+                title: ( localize2(3458, "Open Modal Editor in Main Window")),
                 category: Categories.View,
                 f1: true,
                 icon: Codicon.openInProduct,
@@ -1494,11 +1494,11 @@ function registerModalEditorCommands() {
                 }
             });
         }
-        run(accessor) {
+        async run(accessor) {
             const editorGroupsService = accessor.get(IEditorGroupsService);
             for (const part of editorGroupsService.parts) {
                 if (isModalEditorPart(part)) {
-                    part.close({
+                    await part.close({
                         mergeAllEditorsToMainPart: true
                     });
                     break;
@@ -1510,7 +1510,7 @@ function registerModalEditorCommands() {
         constructor() {
             super({
                 id: MOVE_MODAL_EDITOR_TO_WINDOW_COMMAND_ID,
-                title: ( localize2(3451, "Open Modal Editor in New Window")),
+                title: ( localize2(3459, "Open Modal Editor in New Window")),
                 category: Categories.View,
                 f1: true,
                 icon: Codicon.emptyWindow,
@@ -1537,7 +1537,7 @@ function registerModalEditorCommands() {
                         }))), auxiliaryEditorPart.activeGroup);
                     }
                     auxiliaryEditorPart.activeGroup.focus();
-                    part.close();
+                    await part.close();
                     break;
                 }
             }
@@ -1547,14 +1547,14 @@ function registerModalEditorCommands() {
         constructor() {
             super({
                 id: TOGGLE_MODAL_EDITOR_MAXIMIZED_COMMAND_ID,
-                title: ( localize2(3452, "Maximize Modal Editor")),
+                title: ( localize2(3460, "Maximize Modal Editor")),
                 category: Categories.View,
                 f1: true,
                 precondition: EditorPartModalContext,
                 icon: Codicon.screenFull,
                 toggled: {
                     condition: EditorPartModalMaximizedContext,
-                    title: ( localize(3453, "Restore Modal Editor"))
+                    title: ( localize(3461, "Restore Modal Editor"))
                 },
                 menu: {
                     id: MenuId.ModalEditorTitle,
@@ -1577,7 +1577,7 @@ function registerModalEditorCommands() {
         constructor() {
             super({
                 id: CLOSE_MODAL_EDITOR_COMMAND_ID,
-                title: ( localize2(3454, "Close Modal Editor")),
+                title: ( localize2(3462, "Close Modal Editor")),
                 category: Categories.View,
                 f1: true,
                 icon: Codicon.close,
@@ -1602,7 +1602,7 @@ function registerModalEditorCommands() {
             const editorGroupsService = accessor.get(IEditorGroupsService);
             for (const part of editorGroupsService.parts) {
                 if (isModalEditorPart(part)) {
-                    part.close();
+                    await part.close();
                     break;
                 }
             }
@@ -1612,7 +1612,7 @@ function registerModalEditorCommands() {
         constructor() {
             super({
                 id: NAVIGATE_MODAL_EDITOR_PREVIOUS_COMMAND_ID,
-                title: ( localize2(3455, "Navigate to Previous Item in Modal Editor")),
+                title: ( localize2(3463, "Navigate to Previous Item in Modal Editor")),
                 category: Categories.View,
                 precondition: ( ContextKeyExpr.and(EditorPartModalContext, EditorPartModalNavigationContext)),
                 keybinding: {
@@ -1639,7 +1639,7 @@ function registerModalEditorCommands() {
         constructor() {
             super({
                 id: NAVIGATE_MODAL_EDITOR_NEXT_COMMAND_ID,
-                title: ( localize2(3456, "Navigate to Next Item in Modal Editor")),
+                title: ( localize2(3464, "Navigate to Next Item in Modal Editor")),
                 category: Categories.View,
                 precondition: ( ContextKeyExpr.and(EditorPartModalContext, EditorPartModalNavigationContext)),
                 keybinding: {

package/vscode/src/vs/workbench/browser/parts/editor/editorDropTarget.js

@@ -97,7 +97,7 @@ let DropOverlay = class DropOverlay extends Themable {
         this.overlay = $(".editor-group-overlay-indicator");
         container.appendChild(this.overlay);
         if (this.enableDropIntoEditor) {
-            this.dropIntoPromptElement = renderFormattedText(( localize(3465, "Hold __{0}__ to drop into editor", isMacintosh ? "⇧" : "Shift")), {});
+            this.dropIntoPromptElement = renderFormattedText(( localize(3473, "Hold __{0}__ to drop into editor", isMacintosh ? "⇧" : "Shift")), {});
             this.dropIntoPromptElement.classList.add("editor-group-overlay-drop-into-prompt");
             this.overlay.appendChild(this.dropIntoPromptElement);
         }

package/vscode/src/vs/workbench/browser/parts/editor/editorGroupView.js

@@ -409,7 +409,7 @@ let EditorGroupView = EditorGroupView_1 = class EditorGroupView extends Themable
         const toolbarContainer = $(".editor-group-container-toolbar");
         this.element.appendChild(toolbarContainer);
         const containerToolbar = this._register(( new ActionBar(toolbarContainer, {
-            ariaLabel: ( localize(3466, "Empty editor group actions")),
+            ariaLabel: ( localize(3474, "Empty editor group actions")),
             highlightToggledItems: true
         })));
         const containerToolbarMenu = this._register(
@@ -500,7 +500,7 @@ let EditorGroupView = EditorGroupView_1 = class EditorGroupView extends Themable
         if (this.isEmpty) {
             this.element.classList.add("empty");
             this.element.tabIndex = 0;
-            this.element.setAttribute("aria-label", ( localize(3467, "{0} (empty)", this.ariaLabel)));
+            this.element.setAttribute("aria-label", ( localize(3475, "{0} (empty)", this.ariaLabel)));
         }
         else {
             this.element.classList.remove("empty");
@@ -743,15 +743,15 @@ let EditorGroupView = EditorGroupView_1 = class EditorGroupView extends Themable
     }
     get label() {
         if (this.groupsLabel) {
-            return localize(3468, "{0}: Group {1}", this.groupsLabel, this._index + 1);
+            return localize(3476, "{0}: Group {1}", this.groupsLabel, this._index + 1);
         }
-        return localize(3469, "Group {0}", this._index + 1);
+        return localize(3477, "Group {0}", this._index + 1);
     }
     get ariaLabel() {
         if (this.groupsLabel) {
-            return localize(3470, "{0}: Editor Group {1}", this.groupsLabel, this._index + 1);
+            return localize(3478, "{0}: Editor Group {1}", this.groupsLabel, this._index + 1);
         }
-        return localize(3471, "Editor Group {0}", this._index + 1);
+        return localize(3479, "Editor Group {0}", this._index + 1);
     }
     get disposed() {
         return this._disposed;
@@ -1131,7 +1131,7 @@ let EditorGroupView = EditorGroupView_1 = class EditorGroupView extends Themable
         if (!keepCopy || editor.hasCapability(EditorInputCapabilities.Singleton) ) {
             const canMoveVeto = editor.canMove(this.id, target.id);
             if (typeof canMoveVeto === "string") {
-                this.dialogService.error(canMoveVeto, ( localize(3472, "Try saving or reverting the editor first and then try again.")));
+                this.dialogService.error(canMoveVeto, ( localize(3480, "Try saving or reverting the editor first and then try again.")));
                 return false;
             }
         }

package/vscode/src/vs/workbench/browser/parts/editor/editorGroupWatermark.js

@@ -20,7 +20,7 @@ import { IWorkspaceContextService } from '../../../../platform/workspace/common/
 var EditorGroupWatermark_1;
 const showChatContextKey = ( ContextKeyExpr.and(( ContextKeyExpr.equals("chatSetupHidden", false)), ( ContextKeyExpr.equals("chatSetupDisabled", false))));
 const openChat = {
-    text: ( localize(3473, "Open Chat")),
+    text: ( localize(3481, "Open Chat")),
     id: "workbench.action.chat.open",
     when: {
         native: showChatContextKey,
@@ -28,53 +28,53 @@ const openChat = {
     }
 };
 const showCommands = {
-    text: ( localize(3474, "Show All Commands")),
+    text: ( localize(3482, "Show All Commands")),
     id: "workbench.action.showCommands"
 };
 const gotoFile = {
-    text: ( localize(3475, "Go to File")),
+    text: ( localize(3483, "Go to File")),
     id: "workbench.action.quickOpen"
 };
 const openFile = {
-    text: ( localize(3476, "Open File")),
+    text: ( localize(3484, "Open File")),
     id: "workbench.action.files.openFile"
 };
 const openFolder = {
-    text: ( localize(3477, "Open Folder")),
+    text: ( localize(3485, "Open Folder")),
     id: "workbench.action.files.openFolder"
 };
 const openFileOrFolder = {
-    text: ( localize(3478, "Open File or Folder")),
+    text: ( localize(3486, "Open File or Folder")),
     id: "workbench.action.files.openFileFolder"
 };
 const openRecent = {
-    text: ( localize(3479, "Open Recent")),
+    text: ( localize(3487, "Open Recent")),
     id: "workbench.action.openRecent"
 };
 const newUntitledFile = {
-    text: ( localize(3480, "New Untitled Text File")),
+    text: ( localize(3488, "New Untitled Text File")),
     id: "workbench.action.files.newUntitledFile"
 };
 const findInFiles = {
-    text: ( localize(3481, "Find in Files")),
+    text: ( localize(3489, "Find in Files")),
     id: "workbench.action.findInFiles"
 };
 const toggleTerminal = {
-    text: ( localize(3482, "Toggle Terminal")),
+    text: ( localize(3490, "Toggle Terminal")),
     id: "workbench.action.terminal.toggleTerminal",
     when: {
         web: ( ContextKeyExpr.equals("terminalProcessSupported", true))
     }
 };
 const startDebugging = {
-    text: ( localize(3483, "Start Debugging")),
+    text: ( localize(3491, "Start Debugging")),
     id: "workbench.action.debug.start",
     when: {
         web: ( ContextKeyExpr.equals("terminalProcessSupported", true))
     }
 };
 const openSettings = {
-    text: ( localize(3484, "Open Settings")),
+    text: ( localize(3492, "Open Settings")),
     id: "workbench.action.openSettings"
 };
 const baseEntries = [openChat, showCommands];

package/vscode/src/vs/workbench/browser/parts/editor/editorPanes.js

@@ -144,7 +144,7 @@ let EditorPanes = class EditorPanes extends Disposable {
             }
         }
         if (!message) {
-            message = ( localize(3485, "Unable to open '{0}'", editor.getName()));
+            message = ( localize(3493, "Unable to open '{0}'", editor.getName()));
         }
         const buttons = [];
         if (errorActions && errorActions.length > 0) {
@@ -156,7 +156,7 @@ let EditorPanes = class EditorPanes extends Disposable {
             }
         } else {
             buttons.push({
-                label: ( localize(3486, "&&OK")),
+                label: ( localize(3494, "&&OK")),
                 run: () => undefined
             });
         }

package/vscode/src/vs/workbench/browser/parts/editor/editorPart.d.ts

@@ -30,7 +30,7 @@ export declare class EditorPart extends Part<IEditorPartMemento> implements IEdi
     private readonly groupsLabel;
     readonly windowId: number;
     private readonly instantiationService;
-    private readonly configurationService;
+    protected readonly configurationService: IConfigurationService;
     private readonly hostService;
     private readonly contextKeyService;
     private static readonly EDITOR_PART_UI_STATE_STORAGE_KEY;

package/vscode/src/vs/workbench/browser/parts/editor/editorPart.js

@@ -162,11 +162,17 @@ let EditorPart = class EditorPart extends Part {
         this.top = 0;
         this.left = 0;
         this.sideGroup = {
-            openEditor: (editor, options) => {
-                const [group] = this.scopedInstantiationService.invokeFunction(accessor => findGroup(accessor, {
+            openEditor: async (editor, options) => {
+                const findGroupResult = this.scopedInstantiationService.invokeFunction(accessor => findGroup(accessor, {
                     editor,
                     options
                 }, SIDE_GROUP));
+                let group;
+                if (findGroupResult instanceof Promise) {
+                    ([group] = await findGroupResult);
+                } else {
+                    ([group] = findGroupResult);
+                }
                 return group.openEditor(editor, options);
             }
         };

package/vscode/src/vs/workbench/browser/parts/editor/editorParts.d.ts

@@ -22,8 +22,20 @@ interface IEditorPartsUIState {
 interface IAuxiliaryEditorPartState extends IAuxiliaryWindowOpenOptions {
     readonly state: IEditorPartUIState;
 }
+interface IModalEditorPartState {
+    readonly maximized: boolean;
+    readonly size?: {
+        readonly width: number;
+        readonly height: number;
+    };
+    readonly position?: {
+        readonly left: number;
+        readonly top: number;
+    };
+}
 interface IEditorPartsMemento {
     "editorparts.state"?: IEditorPartsUIState;
+    "editorparts.modalState"?: IModalEditorPartState;
 }
 export declare class EditorParts extends MultiWindowParts<EditorPart, IEditorPartsMemento> implements IEditorGroupsService, IEditorPartsView {
     protected readonly instantiationService: IInstantiationService;
@@ -45,6 +57,8 @@ export declare class EditorParts extends MultiWindowParts<EditorPart, IEditorPar
     private modalEditorPart;
     get activeModalEditorPart(): IModalEditorPart | undefined;
     private modalEditorMaximized;
+    private modalEditorSize;
+    private modalEditorPosition;
     createModalEditorPart(options?: IModalEditorPartOptions): Promise<IModalEditorPart>;
     registerPart(part: EditorPart): IDisposable;
     protected unregisterPart(part: EditorPart): void;
@@ -55,7 +69,9 @@ export declare class EditorParts extends MultiWindowParts<EditorPart, IEditorPar
     getPart(group: IEditorGroupView | GroupIdentifier): EditorPart;
     getPart(element: HTMLElement): EditorPart;
     private static readonly EDITOR_PARTS_UI_STATE_STORAGE_KEY;
+    private static readonly MODAL_EDITOR_STATE_STORAGE_KEY;
     private readonly workspaceMemento;
+    private readonly profileMemento;
     private _isReady;
     get isReady(): boolean;
     private readonly whenReadyPromise;
@@ -65,6 +81,7 @@ export declare class EditorParts extends MultiWindowParts<EditorPart, IEditorPar
     private restoreParts;
     private loadState;
     protected saveState(): void;
+    private saveModalState;
     private createState;
     private restoreState;
     get hasRestorableState(): boolean;

package/vscode/src/vs/workbench/browser/parts/editor/editorParts.js

@@ -46,6 +46,7 @@ let EditorParts = class EditorParts extends MultiWindowParts {
         this.onDidCreateAuxiliaryEditorPart = this._onDidCreateAuxiliaryEditorPart.event;
         this.modalEditorMaximized = false;
         this.workspaceMemento = this.getMemento(StorageScope.WORKSPACE, StorageTarget.USER);
+        this.profileMemento = this.getMemento(StorageScope.PROFILE, StorageTarget.MACHINE);
         this._isReady = false;
         this.whenReadyPromise = ( new DeferredPromise());
         this.whenReady = this.whenReadyPromise.p;
@@ -79,6 +80,12 @@ let EditorParts = class EditorParts extends MultiWindowParts {
             }
             return [];
         })();
+        const modalState = this.profileMemento[EditorParts_1.MODAL_EDITOR_STATE_STORAGE_KEY];
+        if (modalState) {
+            this.modalEditorMaximized = modalState.maximized;
+            this.modalEditorSize = modalState.size;
+            this.modalEditorPosition = modalState.position;
+        }
         this.mainPart = this._register(this.createMainEditorPart());
         this._register(this.registerPart(this.mainPart));
         this.mostRecentActiveParts = [this.mainPart];
@@ -147,17 +154,19 @@ let EditorParts = class EditorParts extends MultiWindowParts {
             disposables
         } = await this.instantiationService.createInstance(ModalEditorPart, this).create({
             ...options,
-            maximized: options?.maximized ?? this.modalEditorMaximized
+            maximized: options?.maximized ?? this.modalEditorMaximized,
+            size: options?.size ?? this.modalEditorSize,
+            position: options?.position ?? this.modalEditorPosition
         });
         this.modalEditorPart = part;
         this.modalPartInstantiationService = instantiationService;
         disposables.add(toDisposable(() => {
+            this.modalEditorMaximized = part.maximized;
+            this.modalEditorSize = part.size;
+            this.modalEditorPosition = part.position;
             this.modalPartInstantiationService = undefined;
             this.modalEditorPart = undefined;
         }));
-        disposables.add(part.onDidChangeMaximized(maximized => {
-            this.modalEditorMaximized = maximized;
-        }));
         this._onDidAddGroup.fire(part.activeGroup);
         return part;
     }
@@ -216,7 +225,7 @@ let EditorParts = class EditorParts extends MultiWindowParts {
         }
     }
     getGroupsLabel(index) {
-        return localize(3487, "Window {0}", index + 1);
+        return localize(3495, "Window {0}", index + 1);
     }
     getPartByDocument(document) {
         if (this._parts.size > 1) {
@@ -257,6 +266,9 @@ let EditorParts = class EditorParts extends MultiWindowParts {
     static {
         this.EDITOR_PARTS_UI_STATE_STORAGE_KEY = "editorparts.state";
     }
+    static {
+        this.MODAL_EDITOR_STATE_STORAGE_KEY = "editorparts.modalState";
+    }
     get isReady() {
         return this._isReady;
     }
@@ -285,6 +297,26 @@ let EditorParts = class EditorParts extends MultiWindowParts {
         } else {
             this.workspaceMemento[EditorParts_1.EDITOR_PARTS_UI_STATE_STORAGE_KEY] = state;
         }
+        this.saveModalState();
+    }
+    saveModalState() {
+        if (this.modalEditorPart) {
+            this.modalEditorMaximized = this.modalEditorPart.maximized;
+            this.modalEditorSize = this.modalEditorPart.size;
+            this.modalEditorPosition = this.modalEditorPart.position;
+        }
+        if (this.modalEditorMaximized || this.modalEditorSize || this.modalEditorPosition) {
+            this.profileMemento[EditorParts_1.MODAL_EDITOR_STATE_STORAGE_KEY] = {
+                maximized: this.modalEditorMaximized,
+                size: this.modalEditorSize ? {
+                    width: this.modalEditorSize.width,
+                    height: this.modalEditorSize.height
+                } : undefined,
+                position: this.modalEditorPosition
+            };
+        } else {
+            delete this.profileMemento[EditorParts_1.MODAL_EDITOR_STATE_STORAGE_KEY];
+        }
     }
     createState() {
         return {

package/vscode/src/vs/workbench/browser/parts/editor/editorPlaceholder.js

@@ -132,7 +132,7 @@ let WorkspaceTrustRequiredPlaceholderEditor = class WorkspaceTrustRequiredPlaceh
         this.ID = "workbench.editors.workspaceTrustRequiredEditor";
     }
     static {
-        this.LABEL = ( localize(3488, "Workspace Trust Required"));
+        this.LABEL = ( localize(3496, "Workspace Trust Required"));
     }
     static {
         this.DESCRIPTOR = EditorPaneDescriptor.create(this, this.ID, this.LABEL);
@@ -162,14 +162,14 @@ let WorkspaceTrustRequiredPlaceholderEditor = class WorkspaceTrustRequiredPlaceh
         return {
             icon: "$(workspace-untrusted)",
             label: isSingleFolderWorkspaceIdentifier(toWorkspaceIdentifier(this.workspaceService.getWorkspace())) ? ( localize(
-                3489,
+                3497,
                 "The file is not displayed in the editor because trust has not been granted to the folder."
             )) : ( localize(
-                3490,
+                3498,
                 "The file is not displayed in the editor because trust has not been granted to the workspace."
             )),
             actions: [{
-                label: ( localize(3491, "Manage Workspace Trust")),
+                label: ( localize(3499, "Manage Workspace Trust")),
                 run: () => this.commandService.executeCommand("workbench.trust.manage")
             }]
         };
@@ -184,7 +184,7 @@ let ErrorPlaceholderEditor = class ErrorPlaceholderEditor extends EditorPlacehol
         this.ID = "workbench.editors.errorEditor";
     }
     static {
-        this.LABEL = ( localize(3492, "Error Editor"));
+        this.LABEL = ( localize(3500, "Error Editor"));
     }
     static {
         this.DESCRIPTOR = EditorPaneDescriptor.create(this, this.ID, this.LABEL);
@@ -215,16 +215,16 @@ let ErrorPlaceholderEditor = class ErrorPlaceholderEditor extends EditorPlacehol
         const isFileNotFound = error?.fileOperationResult === FileOperationResult.FILE_NOT_FOUND;
         let label;
         if (isFileNotFound) {
-            label = ( localize(3493, "The editor could not be opened because the file was not found."));
+            label = ( localize(3501, "The editor could not be opened because the file was not found."));
         } else if (isEditorOpenError(error) && error.forceMessage) {
             label = error.message;
         } else if (error) {
             label = ( localize(
-                3494,
+                3502,
                 "The editor could not be opened due to an unexpected error. Please consult the log for more details."
             ));
         } else {
-            label = ( localize(3495, "The editor could not be opened due to an unexpected error."));
+            label = ( localize(3503, "The editor could not be opened due to an unexpected error."));
         }
         let icon = "$(error)";
         if (isEditorOpenError(error)) {
@@ -249,13 +249,13 @@ let ErrorPlaceholderEditor = class ErrorPlaceholderEditor extends EditorPlacehol
             }));
         } else {
             actions = [{
-                label: ( localize(3496, "Try Again")),
+                label: ( localize(3504, "Try Again")),
                 run: () => this.group.openEditor(input, {
                     ...options,
                     source: EditorOpenSource.USER
                 })
             }, {
-                label: ( localize(3497, "Show Logs")),
+                label: ( localize(3505, "Show Logs")),
                 run: () => this.commandService.executeCommand(showWindowLogActionId)
             }];
         }

package/vscode/src/vs/workbench/browser/parts/editor/editorQuickAccess.js

@@ -23,7 +23,7 @@ let BaseEditorQuickAccessProvider = class BaseEditorQuickAccessProvider extends
         super(prefix, {
             canAcceptInBackground: true,
             noResultsPick: {
-                label: ( localize(3498, "No matching editors")),
+                label: ( localize(3506, "No matching editors")),
                 groupId: -1
             }
         });
@@ -139,18 +139,18 @@ let BaseEditorQuickAccessProvider = class BaseEditorQuickAccessProvider extends
                 ariaLabel: (() => {
                     if (mapGroupIdToGroupAriaLabel.size > 1) {
                         return isDirty ? ( localize(
-                            3499,
+                            3507,
                             "{0}, unsaved changes, {1}",
                             nameAndDescription,
                             mapGroupIdToGroupAriaLabel.get(groupId)
                         )) : ( localize(
-                            3500,
+                            3508,
                             "{0}, {1}",
                             nameAndDescription,
                             mapGroupIdToGroupAriaLabel.get(groupId)
                         ));
                     }
-                    return isDirty ? ( localize(3501, "{0}, unsaved changes", nameAndDescription)) : nameAndDescription;
+                    return isDirty ? ( localize(3509, "{0}, unsaved changes", nameAndDescription)) : nameAndDescription;
                 })(),
                 description,
                 iconClasses: getIconClasses(
@@ -164,7 +164,7 @@ let BaseEditorQuickAccessProvider = class BaseEditorQuickAccessProvider extends
                 buttons: (() => {
                     return [{
                         iconClass: isDirty ? ("dirty-editor " + ThemeIcon.asClassName(Codicon.closeDirty)) : ThemeIcon.asClassName(Codicon.close),
-                        tooltip: ( localize(3502, "Close Editor")),
+                        tooltip: ( localize(3510, "Close Editor")),
                         alwaysVisible: isDirty
                     }];
                 })(),