@codingame/monaco-vscode-api 2.0.3-improve-modularity.1 → 2.1.0-update-vscode-1.86.1

package/vscode/src/vs/platform/extensionManagement/common/extensionManagement.js

@@ -1,4 +1,4 @@
-import { localizeWithPath } from '../../../nls.js';
+import { localize2WithPath, localizeWithPath } from '../../../nls.js';
 import { createDecorator } from '../../instantiation/common/instantiation.js';
 const EXTENSION_IDENTIFIER_PATTERN = '^([a-z0-9A-Z][a-z0-9-A-Z]*)\\.([a-z0-9A-Z][a-z0-9-A-Z]*)$';
 const EXTENSION_IDENTIFIER_REGEX = ( new RegExp(EXTENSION_IDENTIFIER_PATTERN));
@@ -111,12 +111,18 @@ var ExtensionManagementErrorCode;
     ExtensionManagementErrorCode["ReleaseVersionNotFound"] = "ReleaseVersionNotFound";
     ExtensionManagementErrorCode["Invalid"] = "Invalid";
     ExtensionManagementErrorCode["Download"] = "Download";
+    ExtensionManagementErrorCode["DownloadSignature"] = "DownloadSignature";
+    ExtensionManagementErrorCode["UpdateMetadata"] = "UpdateMetadata";
     ExtensionManagementErrorCode["Extract"] = "Extract";
+    ExtensionManagementErrorCode["Scanning"] = "Scanning";
     ExtensionManagementErrorCode["Delete"] = "Delete";
     ExtensionManagementErrorCode["Rename"] = "Rename";
     ExtensionManagementErrorCode["CorruptZip"] = "CorruptZip";
     ExtensionManagementErrorCode["IncompleteZip"] = "IncompleteZip";
     ExtensionManagementErrorCode["Signature"] = "Signature";
+    ExtensionManagementErrorCode["NotAllowed"] = "NotAllowed";
+    ExtensionManagementErrorCode["Gallery"] = "Gallery";
+    ExtensionManagementErrorCode["Unknown"] = "Unknown";
     ExtensionManagementErrorCode["Internal"] = "Internal";
 })(ExtensionManagementErrorCode || (ExtensionManagementErrorCode = {})));
 class ExtensionManagementError extends Error {
@@ -126,6 +132,19 @@ class ExtensionManagementError extends Error {
         this.name = code;
     }
 }
+var ExtensionGalleryErrorCode;
+( (function(ExtensionGalleryErrorCode) {
+    ExtensionGalleryErrorCode["Timeout"] = "Timeout";
+    ExtensionGalleryErrorCode["Cancelled"] = "Cancelled";
+    ExtensionGalleryErrorCode["Failed"] = "Failed";
+})(ExtensionGalleryErrorCode || (ExtensionGalleryErrorCode = {})));
+class ExtensionGalleryError extends Error {
+    constructor(message, code) {
+        super(message);
+        this.code = code;
+        this.name = code;
+    }
+}
 const IExtensionManagementService = ( createDecorator('extensionManagementService'));
 const DISABLED_EXTENSIONS_STORAGE_PATH = 'extensionsIdentifiers/disabled';
 const ENABLED_EXTENSIONS_STORAGE_PATH = 'extensionsIdentifiers/enabled';
@@ -137,9 +156,9 @@ const ExtensionsLabel = ( localizeWithPath(
     "Extensions"
 ));
 const ExtensionsLocalizedLabel = { value: ExtensionsLabel, original: 'Extensions' };
-const PreferencesLocalizedLabel = { value: ( localizeWithPath(
+const PreferencesLocalizedLabel = ( localize2WithPath(
     'vs/platform/extensionManagement/common/extensionManagement',
     'preferences',
-    "Preferences"
-)), original: 'Preferences' };
-export { DISABLED_EXTENSIONS_STORAGE_PATH, ENABLED_EXTENSIONS_STORAGE_PATH, EXTENSION_IDENTIFIER_PATTERN, EXTENSION_IDENTIFIER_REGEX, EXTENSION_INSTALL_DEP_PACK_CONTEXT, EXTENSION_INSTALL_SKIP_WALKTHROUGH_CONTEXT, EXTENSION_INSTALL_SYNC_CONTEXT, ExtensionManagementError, ExtensionManagementErrorCode, ExtensionsLabel, ExtensionsLocalizedLabel, IExtensionGalleryService, IExtensionManagementService, IExtensionTipsService, IGlobalExtensionEnablementService, PreferencesLocalizedLabel, TargetPlatformToString, WEB_EXTENSION_TAG, getTargetPlatform, isNotWebExtensionInWebTargetPlatform, isTargetPlatformCompatible, toTargetPlatform };
+    'Preferences'
+));
+export { DISABLED_EXTENSIONS_STORAGE_PATH, ENABLED_EXTENSIONS_STORAGE_PATH, EXTENSION_IDENTIFIER_PATTERN, EXTENSION_IDENTIFIER_REGEX, EXTENSION_INSTALL_DEP_PACK_CONTEXT, EXTENSION_INSTALL_SKIP_WALKTHROUGH_CONTEXT, EXTENSION_INSTALL_SYNC_CONTEXT, ExtensionGalleryError, ExtensionGalleryErrorCode, ExtensionManagementError, ExtensionManagementErrorCode, ExtensionsLabel, ExtensionsLocalizedLabel, IExtensionGalleryService, IExtensionManagementService, IExtensionTipsService, IGlobalExtensionEnablementService, PreferencesLocalizedLabel, TargetPlatformToString, WEB_EXTENSION_TAG, getTargetPlatform, isNotWebExtensionInWebTargetPlatform, isTargetPlatformCompatible, toTargetPlatform };

package/vscode/src/vs/platform/extensions/common/extensions.d.ts

@@ -630,6 +630,10 @@ interface INotebookRendererContribution {
         readonly path: string;
     };
 }
+interface IDebugVisualizationContribution {
+    readonly id: string;
+    readonly when: string;
+}
 interface ITranslation {
     /**
      * Id of VS Code or Extension for which this translation is contributed to. Id of VS Code is always `vscode` and of extension should be in format `publisherId.extensionName`.
@@ -1105,6 +1109,7 @@ interface IExtensionContributions {
      * Contributes notebook output renderer provider.
      */
     readonly notebookRenderer?: INotebookRendererContribution[];
+    readonly debugVisualizers?: IDebugVisualizationContribution[];
     /**
      * Contributes notebook preloads.
      */
@@ -1309,4 +1314,4 @@ interface IRelaxedExtensionDescription extends IRelaxedExtensionManifest {
 }
 type IExtensionDescription = Readonly<IRelaxedExtensionDescription>;
 
-export { ExtensionIdentifier, ExtensionIdentifierMap, ExtensionType, type ExtensionUntrustedWorkspaceSupport, type ExtensionUntrustedWorkspaceSupportType, type ExtensionVirtualWorkspaceSupport, type ExtensionVirtualWorkspaceSupportType, type IAuthenticationContribution, type IBreakpoint, type ICodeActionContribution, type ICodeActionContributionAction, type IColor, type IColorTheme, type ICommand, type IConfiguration, type IDebugger, type IDocumentation, type IDocumentationRefactoring, type IExtension, type IExtensionCapabilities, type IExtensionContributions, type IExtensionDescription, type IExtensionIdentifier, type IExtensionManifest, type IGrammar, type IIcon, type IIconTheme, type IInteractiveSession, type IJSONValidation, type IKeyBinding, type ILanguage, type ILocalizationContribution, type IMenu, type INotebookEntry, type INotebookRendererContribution, type IProductTheme, type IRelaxedExtensionDescription, type IRelaxedExtensionManifest, type IRemoteHelp, type ISemanticTokenModifiers, type ISemanticTokenScopes, type ISemanticTokenTypes, type ISnippet, type IStartEntry, type IStatusBarItem, type ISubMenu, type ITaskDefinitions, type ITerminal, type ITerminalQuickFix, type ITranslation, type IView, type IViewContainer, type IViewsWelcome, type IWalkthrough, type IWalkthroughStep, type LimitedWorkspaceSupportType, type NotebookPreload, TargetPlatform };
+export { ExtensionIdentifier, ExtensionIdentifierMap, ExtensionType, type ExtensionUntrustedWorkspaceSupport, type ExtensionUntrustedWorkspaceSupportType, type ExtensionVirtualWorkspaceSupport, type ExtensionVirtualWorkspaceSupportType, type IAuthenticationContribution, type IBreakpoint, type ICodeActionContribution, type ICodeActionContributionAction, type IColor, type IColorTheme, type ICommand, type IConfiguration, type IDebugVisualizationContribution, type IDebugger, type IDocumentation, type IDocumentationRefactoring, type IExtension, type IExtensionCapabilities, type IExtensionContributions, type IExtensionDescription, type IExtensionIdentifier, type IExtensionManifest, type IGrammar, type IIcon, type IIconTheme, type IInteractiveSession, type IJSONValidation, type IKeyBinding, type ILanguage, type ILocalizationContribution, type IMenu, type INotebookEntry, type INotebookRendererContribution, type IProductTheme, type IRelaxedExtensionDescription, type IRelaxedExtensionManifest, type IRemoteHelp, type ISemanticTokenModifiers, type ISemanticTokenScopes, type ISemanticTokenTypes, type ISnippet, type IStartEntry, type IStatusBarItem, type ISubMenu, type ITaskDefinitions, type ITerminal, type ITerminalQuickFix, type ITranslation, type IView, type IViewContainer, type IViewsWelcome, type IWalkthrough, type IWalkthroughStep, type LimitedWorkspaceSupportType, type NotebookPreload, TargetPlatform };

package/vscode/src/vs/{workbench/services → platform}/hover/browser/hover.d.ts

@@ -1,7 +1,8 @@
-import { ServiceIdentifier } from '../../../../platform/instantiation/common/instantiation.js';
-import { IDisposable } from '../../../../base/common/lifecycle.js';
-import { IMarkdownString } from '../../../../base/common/htmlContent.js';
-import { HoverPosition } from '../../../../base/browser/ui/hover/hoverWidget.js';
+import { ServiceIdentifier } from '../../instantiation/common/instantiation.js';
+import { IDisposable } from '../../../base/common/lifecycle.js';
+import { IMarkdownString } from '../../../base/common/htmlContent.js';
+import { HoverPosition } from '../../../base/browser/ui/hover/hoverWidget.js';
+import { IHoverWidget } from '../../../base/browser/ui/iconLabel/iconHoverDelegate.js';
 
 declare const IHoverService: ServiceIdentifier<IHoverService>;
 /**
@@ -35,9 +36,6 @@ interface IHoverService {
      */
     showAndFocusLastHover(): void;
 }
-interface IHoverWidget extends IDisposable {
-    readonly isDisposed: boolean;
-}
 interface IHoverOptions {
     /**
      * The content to display in the primary section of the hover. The type of text determines the
@@ -190,4 +188,4 @@ interface IHoverTarget extends IDisposable {
     y?: number;
 }
 
-export { type IHoverAction, type IHoverAppearanceOptions, type IHoverOptions, type IHoverPersistenceOptions, type IHoverPositionOptions, IHoverService, type IHoverTarget, type IHoverWidget };
+export { type IHoverAction, type IHoverAppearanceOptions, type IHoverOptions, type IHoverPersistenceOptions, type IHoverPositionOptions, IHoverService, type IHoverTarget };

package/vscode/src/vs/platform/hover/browser/hover.js

@@ -0,0 +1,3 @@
+import { createDecorator } from '../../instantiation/common/instantiation.js';
+const IHoverService = ( createDecorator('hoverService'));
+export { IHoverService };

package/vscode/src/vs/platform/instantiation/common/instantiationService.js

@@ -199,8 +199,8 @@ class InstantiationService {
                 for (const [key, values] of earlyListeners) {
                     const candidate = result[key];
                     if (typeof candidate === 'function') {
-                        for (const listener of values) {
-                            candidate.apply(result, listener);
+                        for (const value of values) {
+                            value.disposable = candidate.apply(result, value.listener);
                         }
                     }
                 }
@@ -217,8 +217,18 @@ class InstantiationService {
                                 earlyListeners.set(key, list);
                             }
                             const event = (callback, thisArg, disposables) => {
-                                const rm = list.push([callback, thisArg, disposables]);
-                                return toDisposable(rm);
+                                if (idle.isInitialized) {
+                                    return idle.value[key](callback, thisArg, disposables);
+                                }
+                                else {
+                                    const entry = { listener: [callback, thisArg, disposables], disposable: undefined };
+                                    const rm = list.push(entry);
+                                    const result = toDisposable(() => {
+                                        rm();
+                                        entry.disposable?.dispose();
+                                    });
+                                    return result;
+                                }
                             };
                             return event;
                         }

package/vscode/src/vs/platform/keybinding/common/abstractKeybindingService.js

@@ -28,6 +28,7 @@ class AbstractKeybindingService extends Disposable {
         this._ignoreSingleModifiers = KeybindingModifierSet.EMPTY;
         this._currentSingleModifier = null;
         this._currentSingleModifierClearTimeout = ( new TimeoutTimer());
+        this._currentlyDispatchingCommandId = null;
         this._logging = false;
     }
     dispose() {
@@ -260,11 +261,17 @@ class AbstractKeybindingService extends Disposable {
                         shouldPreventDefault = true;
                     }
                     this._log(`+ Invoking command ${resolveResult.commandId}.`);
-                    if (typeof resolveResult.commandArgs === 'undefined') {
-                        this._commandService.executeCommand(resolveResult.commandId).then(undefined, err => this._notificationService.warn(err));
+                    this._currentlyDispatchingCommandId = resolveResult.commandId;
+                    try {
+                        if (typeof resolveResult.commandArgs === 'undefined') {
+                            this._commandService.executeCommand(resolveResult.commandId).then(undefined, err => this._notificationService.warn(err));
+                        }
+                        else {
+                            this._commandService.executeCommand(resolveResult.commandId, resolveResult.commandArgs).then(undefined, err => this._notificationService.warn(err));
+                        }
                     }
-                    else {
-                        this._commandService.executeCommand(resolveResult.commandId, resolveResult.commandArgs).then(undefined, err => this._notificationService.warn(err));
+                    finally {
+                        this._currentlyDispatchingCommandId = null;
                     }
                     if (!HIGH_FREQ_COMMANDS.test(resolveResult.commandId)) {
                         this._telemetryService.publicLog2('workbenchActionExecuted', { id: resolveResult.commandId, from: 'keybinding', detail: userKeypress.getUserSettingsLabel() ?? undefined });

package/vscode/src/vs/platform/keybinding/common/keybinding.d.ts

@@ -46,6 +46,13 @@ interface IKeybindingService {
      * Resolve and dispatch `keyboardEvent`, but do not invoke the command or change inner state.
      */
     softDispatch(keyboardEvent: IKeyboardEvent, target: IContextKeyServiceTarget): ResolutionResult;
+    /**
+     * Enable hold mode for this command. This is only possible if the command is current being dispatched, meaning
+     * we are after its keydown and before is keyup event.
+     *
+     * @returns A promise that resolves when hold stops, returns undefined if hold mode could not be enabled.
+     */
+    enableKeybindingHoldMode(commandId: string): Promise<void> | undefined;
     dispatchByUserSettingsLabel(userSettingsLabel: string, target: IContextKeyServiceTarget): void;
     /**
      * Look up keybindings for a command.

package/vscode/src/vs/platform/layout/browser/layoutService.d.ts

@@ -77,6 +77,12 @@ interface ILayoutService {
      * An offset to use for positioning elements inside the container.
      */
     readonly activeContainerOffset: ILayoutOffsetInfo;
+    /**
+     * A promise resolved when the stylesheets for the active container have been
+     * loaded. Aux windows load their styles asynchronously, so there may be
+     * an initial delay before resolution happens.
+     */
+    readonly whenActiveContainerStylesLoaded: Promise<void>;
     /**
      * Focus the primary component of the active container.
      */

package/vscode/src/vs/platform/list/browser/listService.js

@@ -17,7 +17,6 @@ import { InputFocusedContextKey } from '../../contextkey/common/contextkeys.js';
 import { IContextViewService } from '../../contextview/browser/contextView.js';
 import { createDecorator, IInstantiationService } from '../../instantiation/common/instantiation.js';
 import { IKeybindingService } from '../../keybinding/common/keybinding.js';
-import product$1 from '../../product/common/product.js';
 import { Registry } from '../../registry/common/platform.js';
 import { getListStyles, defaultListStyles, defaultFindWidgetStyles } from '../../theme/browser/defaultStyles.js';
 const IListService = ( createDecorator('listService'));
@@ -68,10 +67,12 @@ const RawWorkbenchListScrollAtBoundaryContextKey = ( new RawContextKey('listScro
 const WorkbenchListScrollAtTopContextKey = ( ContextKeyExpr.or(( RawWorkbenchListScrollAtBoundaryContextKey.isEqualTo('top')), ( RawWorkbenchListScrollAtBoundaryContextKey.isEqualTo('both'))));
 const WorkbenchListScrollAtBottomContextKey = ( ContextKeyExpr.or(( RawWorkbenchListScrollAtBoundaryContextKey.isEqualTo('bottom')), ( RawWorkbenchListScrollAtBoundaryContextKey.isEqualTo('both'))));
 const RawWorkbenchListFocusContextKey = ( new RawContextKey('listFocus', true));
+const WorkbenchTreeStickyScrollFocused = ( new RawContextKey('treestickyScrollFocused', false));
 const WorkbenchListSupportsMultiSelectContextKey = ( new RawContextKey('listSupportsMultiselect', true));
 const WorkbenchListFocusContextKey = ( ContextKeyExpr.and(
     RawWorkbenchListFocusContextKey,
-    ContextKeyExpr.not(InputFocusedContextKey)
+    ContextKeyExpr.not(InputFocusedContextKey),
+    ( WorkbenchTreeStickyScrollFocused.negate())
 ));
 const WorkbenchListHasSelectionOrFocus = ( new RawContextKey('listHasSelectionOrFocus', false));
 const WorkbenchListDoubleSelection = ( new RawContextKey('listDoubleSelection', false));
@@ -828,6 +829,7 @@ let WorkbenchTreeInternals = class WorkbenchTreeInternals {
         this.treeElementCanExpand = WorkbenchTreeElementCanExpand.bindTo(this.contextKeyService);
         this.treeElementHasChild = WorkbenchTreeElementHasChild.bindTo(this.contextKeyService);
         this.treeFindOpen = WorkbenchTreeFindOpen.bindTo(this.contextKeyService);
+        this.treeStickyScrollFocused = WorkbenchTreeStickyScrollFocused.bindTo(this.contextKeyService);
         this._useAltAsMultipleSelectionModifier = useAltAsMultipleSelectionModifier(configurationService);
         this.updateStyleOverrides(overrideStyles);
         const updateCollapseContextKeys = () => {
@@ -857,7 +859,7 @@ let WorkbenchTreeInternals = class WorkbenchTreeInternals {
             const focus = tree.getFocus();
             this.hasSelectionOrFocus.set(selection.length > 0 || focus.length > 0);
             updateCollapseContextKeys();
-        }), tree.onDidChangeCollapseState(updateCollapseContextKeys), tree.onDidChangeModel(updateCollapseContextKeys), tree.onDidChangeFindOpenState(enabled => this.treeFindOpen.set(enabled)), configurationService.onDidChangeConfiguration(e => {
+        }), tree.onDidChangeCollapseState(updateCollapseContextKeys), tree.onDidChangeModel(updateCollapseContextKeys), tree.onDidChangeFindOpenState(enabled => this.treeFindOpen.set(enabled)), tree.onDidChangeStickyScrollFocused(focused => this.treeStickyScrollFocused.set(focused)), configurationService.onDidChangeConfiguration(e => {
             let newOptions = {};
             if (e.affectsConfiguration(multiSelectModifierSettingKey)) {
                 this._useAltAsMultipleSelectionModifier = useAltAsMultipleSelectionModifier(configurationService);
@@ -1143,7 +1145,7 @@ configurationRegistry.registerConfiguration({
         },
         [treeStickyScroll]: {
             type: 'boolean',
-            default: typeof product$1.quality === 'string' && product$1.quality !== 'stable',
+            default: true,
             description: ( localizeWithPath(
                 'vs/platform/list/browser/listService',
                 'sticky scroll',
@@ -1172,4 +1174,4 @@ configurationRegistry.registerConfiguration({
         }
     }
 });
-export { IListService, ListService, RawWorkbenchListFocusContextKey, RawWorkbenchListScrollAtBoundaryContextKey, WorkbenchAsyncDataTree, WorkbenchCompressibleAsyncDataTree, WorkbenchCompressibleObjectTree, WorkbenchDataTree, WorkbenchList, WorkbenchListDoubleSelection, WorkbenchListFocusContextKey, WorkbenchListHasSelectionOrFocus, WorkbenchListMultiSelection, WorkbenchListScrollAtBottomContextKey, WorkbenchListScrollAtTopContextKey, WorkbenchListSelectionNavigation, WorkbenchListSupportsFind, WorkbenchListSupportsMultiSelectContextKey, WorkbenchObjectTree, WorkbenchPagedList, WorkbenchTable, WorkbenchTreeElementCanCollapse, WorkbenchTreeElementCanExpand, WorkbenchTreeElementHasChild, WorkbenchTreeElementHasParent, WorkbenchTreeFindOpen, getSelectionKeyboardEvent };
+export { IListService, ListService, RawWorkbenchListFocusContextKey, RawWorkbenchListScrollAtBoundaryContextKey, WorkbenchAsyncDataTree, WorkbenchCompressibleAsyncDataTree, WorkbenchCompressibleObjectTree, WorkbenchDataTree, WorkbenchList, WorkbenchListDoubleSelection, WorkbenchListFocusContextKey, WorkbenchListHasSelectionOrFocus, WorkbenchListMultiSelection, WorkbenchListScrollAtBottomContextKey, WorkbenchListScrollAtTopContextKey, WorkbenchListSelectionNavigation, WorkbenchListSupportsFind, WorkbenchListSupportsMultiSelectContextKey, WorkbenchObjectTree, WorkbenchPagedList, WorkbenchTable, WorkbenchTreeElementCanCollapse, WorkbenchTreeElementCanExpand, WorkbenchTreeElementHasChild, WorkbenchTreeElementHasParent, WorkbenchTreeFindOpen, WorkbenchTreeStickyScrollFocused, getSelectionKeyboardEvent };

package/vscode/src/vs/platform/log/common/bufferLog.js

@@ -26,6 +26,7 @@ class BufferLogger extends AbstractMessageLogger {
     }
     dispose() {
         this._logger?.dispose();
+        super.dispose();
     }
     flush() {
         this._logger?.flush();

package/vscode/src/vs/platform/log/common/log.d.ts

@@ -169,7 +169,6 @@ declare class ConsoleLogger extends AbstractLogger implements ILogger {
     info(message: string, ...args: any[]): void;
     warn(message: string | Error, ...args: any[]): void;
     error(message: string, ...args: any[]): void;
-    dispose(): void;
     flush(): void;
 }
 

package/vscode/src/vs/platform/log/common/log.js

@@ -179,8 +179,6 @@ class ConsoleLogger extends AbstractLogger {
             }
         }
     }
-    dispose() {
-    }
     flush() {
     }
 }
@@ -232,6 +230,7 @@ class MultiplexLogger extends AbstractLogger {
         for (const logger of this.loggers) {
             logger.dispose();
         }
+        super.dispose();
     }
 }
 class AbstractLoggerService extends Disposable {

package/vscode/src/vs/platform/notification/common/notification.d.ts

@@ -72,6 +72,16 @@ interface INeverShowAgainOptions {
      */
     readonly scope?: NeverShowAgainScope;
 }
+interface INotificationSource {
+    /**
+     * The id of the source.
+     */
+    readonly id: string;
+    /**
+     * The label of the source.
+     */
+    readonly label: string;
+}
 interface INotification extends INotificationProperties {
     /**
      * The id of the notification. If provided, will be used to compare
@@ -91,10 +101,7 @@ interface INotification extends INotificationProperties {
     /**
      * The source of the notification appears as additional information.
      */
-    readonly source?: string | {
-        label: string;
-        id: string;
-    };
+    readonly source?: string | INotificationSource;
     /**
      * Actions to show as part of the notification. Primary actions show up as
      * buttons as part of the message and will close the notification once clicked.
@@ -252,15 +259,13 @@ declare enum NotificationsFilter {
      * No filter is enabled.
      */
     OFF = 0,
-    /**
-     * All notifications are configured as silent. See
-     * `INotificationProperties.silent` for more info.
-     */
-    SILENT = 1,
     /**
      * All notifications are silent except error notifications.
     */
-    ERROR = 2
+    ERROR = 1
+}
+interface INotificationSourceFilter extends INotificationSource {
+    readonly filter: NotificationsFilter;
 }
 declare const INotificationService: ServiceIdentifier<INotificationService>;
 /**
@@ -270,12 +275,6 @@ declare const INotificationService: ServiceIdentifier<INotificationService>;
  */
 interface INotificationService {
     readonly _serviceBrand: undefined;
-    /**
-     * The DND mode can be enabled or disabled
-     * and will result in all info and warning
-     * notifications to be silent.
-     */
-    doNotDisturbMode: boolean;
     /**
      * Emitted when a new notification is added.
      */
@@ -285,9 +284,27 @@ interface INotificationService {
      */
     readonly onDidRemoveNotification: Event<INotification>;
     /**
-     * Emitted when a do not disturb mode has changed.
+     * Emitted when the notifications filter changed.
+     */
+    readonly onDidChangeFilter: Event<void>;
+    /**
+     * Sets a notification filter either for all notifications
+     * or for a specific source.
+     */
+    setFilter(filter: NotificationsFilter | INotificationSourceFilter): void;
+    /**
+     * Gets the notification filter either for all notifications
+     * or for a specific source.
+     */
+    getFilter(source?: INotificationSource): NotificationsFilter;
+    /**
+     * Returns all filters with their sources.
+     */
+    getFilters(): INotificationSourceFilter[];
+    /**
+     * Removes a filter for a specific source.
      */
-    readonly onDidChangeDoNotDisturbMode: Event<void>;
+    removeFilter(sourceId: string): void;
     /**
      * Show the provided notification to the user. The returned `INotificationHandle`
      * can be used to control the notification afterwards.
@@ -352,4 +369,4 @@ declare class NoOpProgress implements INotificationProgress {
     worked(value: number): void;
 }
 
-export { type INeverShowAgainOptions, type INotification, type INotificationActions, type INotificationHandle, type INotificationProgress, type INotificationProgressProperties, type INotificationProperties, INotificationService, type IPromptChoice, type IPromptChoiceWithMenu, type IPromptOptions, type IStatusMessageOptions, NeverShowAgainScope, NoOpNotification, NoOpProgress, type NotificationMessage, NotificationPriority, NotificationsFilter, type Severity };
+export { type INeverShowAgainOptions, type INotification, type INotificationActions, type INotificationHandle, type INotificationProgress, type INotificationProgressProperties, type INotificationProperties, INotificationService, type INotificationSource, type INotificationSourceFilter, type IPromptChoice, type IPromptChoiceWithMenu, type IPromptOptions, type IStatusMessageOptions, NeverShowAgainScope, NoOpNotification, NoOpProgress, type NotificationMessage, NotificationPriority, NotificationsFilter, type Severity };

package/vscode/src/vs/platform/notification/common/notification.js

@@ -15,11 +15,17 @@ var NeverShowAgainScope;
     NeverShowAgainScope[NeverShowAgainScope["PROFILE"] = 1] = "PROFILE";
     NeverShowAgainScope[NeverShowAgainScope["APPLICATION"] = 2] = "APPLICATION";
 })(NeverShowAgainScope || (NeverShowAgainScope = {})));
+function isNotificationSource(thing) {
+    if (thing) {
+        const candidate = thing;
+        return typeof candidate.id === 'string' && typeof candidate.label === 'string';
+    }
+    return false;
+}
 var NotificationsFilter;
 ( (function(NotificationsFilter) {
     NotificationsFilter[NotificationsFilter["OFF"] = 0] = "OFF";
-    NotificationsFilter[NotificationsFilter["SILENT"] = 1] = "SILENT";
-    NotificationsFilter[NotificationsFilter["ERROR"] = 2] = "ERROR";
+    NotificationsFilter[NotificationsFilter["ERROR"] = 1] = "ERROR";
 })(NotificationsFilter || (NotificationsFilter = {})));
 class NoOpNotification {
     constructor() {
@@ -38,4 +44,4 @@ class NoOpProgress {
     total(value) { }
     worked(value) { }
 }
-export { INotificationService, NeverShowAgainScope, NoOpNotification, NoOpProgress, NotificationPriority, NotificationsFilter, Severity };
+export { INotificationService, NeverShowAgainScope, NoOpNotification, NoOpProgress, NotificationPriority, NotificationsFilter, Severity, isNotificationSource };

package/vscode/src/vs/platform/quickinput/browser/pickerQuickAccess.js

@@ -35,7 +35,10 @@ class PickerQuickAccessProvider extends Disposable {
             picker.busy = false;
             picksCts = ( new CancellationTokenSource(token));
             const picksToken = picksCts.token;
-            const picksFilter = picker.value.substr(this.prefix.length).trim();
+            let picksFilter = picker.value.substring(this.prefix.length);
+            if (!this.options?.shouldSkipTrimPickFilter) {
+                picksFilter = picksFilter.trim();
+            }
             const providedPicks = this._getPicks(picksFilter, picksDisposables, picksToken, runOptions);
             const applyPicks = (picks, skipEmpty) => {
                 let items;

package/vscode/src/vs/platform/quickinput/browser/quickInput.js

@@ -1,7 +1,6 @@
 import { reset, EventHelper, isMouseEvent, addDisposableListener, EventType } from '../../../base/browser/dom.js';
 import { StandardKeyboardEvent } from '../../../base/browser/keyboardEvent.js';
 import { Toggle } from '../../../base/browser/ui/toggle/toggle.js';
-import { Action } from '../../../base/common/actions.js';
 import { equals } from '../../../base/common/arrays.js';
 import { TimeoutTimer } from '../../../base/common/async.js';
 import { Codicon } from '../../../base/common/codicons.js';
@@ -14,7 +13,7 @@ import './media/quickInput.css.js';
 import { localizeWithPath } from '../../../nls.js';
 import { QuickInputHideReason, ItemActivation, NO_KEY_MODS } from '../common/quickInput.js';
 import { QuickInputListFocus } from './quickInputList.js';
-import { getIconClass, renderQuickInputDescription } from './quickInputUtils.js';
+import { renderQuickInputDescription, quickInputButtonToAction } from './quickInputUtils.js';
 const backButton = {
     iconClass: ThemeIcon.asClassName(Codicon.quickInputBack),
     tooltip: ( localizeWithPath('vs/platform/quickinput/browser/quickInput', 'quickInput.back', "Back")),
@@ -225,35 +224,19 @@ class QuickInput extends Disposable {
         if (this.buttonsUpdated) {
             this.buttonsUpdated = false;
             this.ui.leftActionBar.clear();
-            const leftButtons = this.buttons.filter(button => button === backButton);
-            this.ui.leftActionBar.push(( leftButtons.map((button, index) => {
-                const action = ( new Action(
-                    `id-${index}`,
-                    '',
-                    button.iconClass || getIconClass(button.iconPath),
-                    true,
-                    async () => {
-                        this.onDidTriggerButtonEmitter.fire(button);
-                    }
-                ));
-                action.tooltip = button.tooltip || '';
-                return action;
-            })), { icon: true, label: false });
+            const leftButtons = ( this.buttons
+                .filter(button => button === backButton)
+                .map(
+                (button, index) => quickInputButtonToAction(button, `id-${index}`, async () => this.onDidTriggerButtonEmitter.fire(button))
+            ));
+            this.ui.leftActionBar.push(leftButtons, { icon: true, label: false });
             this.ui.rightActionBar.clear();
-            const rightButtons = this.buttons.filter(button => button !== backButton);
-            this.ui.rightActionBar.push(( rightButtons.map((button, index) => {
-                const action = ( new Action(
-                    `id-${index}`,
-                    '',
-                    button.iconClass || getIconClass(button.iconPath),
-                    true,
-                    async () => {
-                        this.onDidTriggerButtonEmitter.fire(button);
-                    }
-                ));
-                action.tooltip = button.tooltip || '';
-                return action;
-            })), { icon: true, label: false });
+            const rightButtons = ( this.buttons
+                .filter(button => button !== backButton)
+                .map(
+                (button, index) => quickInputButtonToAction(button, `id-${index}`, async () => this.onDidTriggerButtonEmitter.fire(button))
+            ));
+            this.ui.rightActionBar.push(rightButtons, { icon: true, label: false });
         }
         if (this.togglesUpdated) {
             this.togglesUpdated = false;
@@ -348,7 +331,6 @@ class QuickPick extends QuickInput {
         this._matchOnLabel = true;
         this._matchOnLabelMode = 'fuzzy';
         this._sortByLabel = true;
-        this._autoFocusOnList = true;
         this._keepScrollPosition = false;
         this._itemActivation = ItemActivation.FIRST;
         this._activeItems = [];
@@ -483,13 +465,6 @@ class QuickPick extends QuickInput {
         this._sortByLabel = sortByLabel;
         this.update();
     }
-    get autoFocusOnList() {
-        return this._autoFocusOnList;
-    }
-    set autoFocusOnList(autoFocusOnList) {
-        this._autoFocusOnList = autoFocusOnList;
-        this.update();
-    }
     get keepScrollPosition() {
         return this._keepScrollPosition;
     }
@@ -585,10 +560,8 @@ class QuickPick extends QuickInput {
         this.update();
     }
     trySelectFirst() {
-        if (this.autoFocusOnList) {
-            if (!this.canSelectMany) {
-                this.ui.list.focus(QuickInputListFocus.First);
-            }
+        if (!this.canSelectMany) {
+            this.ui.list.focus(QuickInputListFocus.First);
         }
     }
     show() {
@@ -596,11 +569,6 @@ class QuickPick extends QuickInput {
             this.visibleDisposables.add(this.ui.inputBox.onDidChange(value => {
                 this.doSetValue(value, true );
             }));
-            this.visibleDisposables.add(this.ui.inputBox.onMouseDown(event => {
-                if (!this.autoFocusOnList) {
-                    this.ui.list.clearFocus();
-                }
-            }));
             this.visibleDisposables.add((this._hideInput ? this.ui.list : this.ui.inputBox).onKeyDown((event) => {
                 switch (event.keyCode) {
                     case 18 :
@@ -990,4 +958,38 @@ class QuickWidget extends QuickInput {
         super.update();
     }
 }
-export { InputBox, QuickPick, QuickWidget, backButton };
+class QuickInputHoverDelegate {
+    get delay() {
+        if (Date.now() - this.lastHoverHideTime < 200) {
+            return 0;
+        }
+        return this.configurationService.getValue('workbench.hover.delay');
+    }
+    constructor(configurationService, hoverService) {
+        this.configurationService = configurationService;
+        this.hoverService = hoverService;
+        this.lastHoverHideTime = 0;
+        this.placement = 'element';
+    }
+    showHover(options, focus) {
+        const showHoverHint = (options.content instanceof HTMLElement
+            ? options.content.textContent ?? ''
+            : typeof options.content === 'string'
+                ? options.content
+                : options.content.value).length > 20;
+        return this.hoverService.showHover({
+            ...options,
+            persistence: {
+                hideOnKeyDown: false,
+            },
+            appearance: {
+                showHoverHint,
+                skipFadeInAnimation: true,
+            },
+        }, focus);
+    }
+    onDidHideHover() {
+        this.lastHoverHideTime = Date.now();
+    }
+}
+export { InputBox, QuickInputHoverDelegate, QuickPick, QuickWidget, backButton };

package/vscode/src/vs/platform/quickinput/browser/quickInputController.js

@@ -66,11 +66,10 @@ class QuickInputController extends Disposable {
         container.style.display = 'none';
         const styleSheet = createStyleSheet(container);
         const titleBar = append(container, $('.quick-input-titlebar'));
-        const actionBarOption = this.options.hoverDelegate ? { hoverDelegate: this.options.hoverDelegate } : undefined;
-        const leftActionBar = this._register(( new ActionBar(titleBar, actionBarOption)));
+        const leftActionBar = this._register(( new ActionBar(titleBar, { hoverDelegate: this.options.hoverDelegate })));
         leftActionBar.domNode.classList.add('quick-input-left-action-bar');
         const title = append(titleBar, $('.quick-input-title'));
-        const rightActionBar = this._register(( new ActionBar(titleBar, actionBarOption)));
+        const rightActionBar = this._register(( new ActionBar(titleBar, { hoverDelegate: this.options.hoverDelegate })));
         rightActionBar.domNode.classList.add('quick-input-right-action-bar');
         const headerContainer = append(container, $('.quick-input-header'));
         const checkAll = append(headerContainer, $('input.quick-input-check-all'));
@@ -116,7 +115,7 @@ class QuickInputController extends Disposable {
             this.onDidAcceptEmitter.fire();
         }));
         const customButtonContainer = append(headerContainer, $('.quick-input-action'));
-        const customButton = this._register(( new Button(customButtonContainer, this.styles.button)));
+        const customButton = this._register(( new Button(customButtonContainer, { ...this.styles.button, supportIcons: true })));
         customButton.label = ( localizeWithPath('vs/platform/quickinput/browser/quickInputController', 'custom', "Custom"));
         this._register(customButton.onDidClick(e => {
             this.onDidCustomEmitter.fire();
@@ -354,7 +353,6 @@ class QuickInputController extends Disposable {
             input.matchOnDescription = !!options.matchOnDescription;
             input.matchOnDetail = !!options.matchOnDetail;
             input.matchOnLabel = (options.matchOnLabel === undefined) || options.matchOnLabel;
-            input.autoFocusOnList = (options.autoFocusOnList === undefined) || options.autoFocusOnList;
             input.quickNavigate = options.quickNavigate;
             input.hideInput = !!options.hideInput;
             input.contextKey = options.contextKey;