@codihaus/claude-skills 1.6.1 → 1.6.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codihaus/claude-skills",
-  "version": "1.6.1",
+  "version": "1.6.3",
   "description": "Claude Code skills for software development workflow",
   "main": "src/index.js",
   "bin": {

package/src/commands/init.js

@@ -79,16 +79,22 @@ export async function init(options) {
 
     // Offer to install missing Python packages (only if Python is installed)
     const missingPython = globalDeps.python?.filter(p => !p.installed) || [];
-    if (hasPython && hasPip && missingPython.length > 0 && !options.yes) {
-      const { installPython } = await inquirer.prompt([{
-        type: 'confirm',
-        name: 'installPython',
-        message: `Install missing Python packages (${missingPython.map(p => p.name).join(', ')})? (will try --user first, then sudo if needed)`,
-        default: true
-      }]);
-
-      if (installPython) {
+    if (hasPython && hasPip && missingPython.length > 0) {
+      if (options.yes) {
+        // Auto-install when --yes flag is used
+        console.log(chalk.cyan(`\nAuto-installing Python packages: ${missingPython.map(p => p.name).join(', ')}`));
         await installPythonDeps(missingPython);
+      } else {
+        const { installPython } = await inquirer.prompt([{
+          type: 'confirm',
+          name: 'installPython',
+          message: `Install missing Python packages (${missingPython.map(p => p.name).join(', ')})? (will try --user first, then sudo if needed)`,
+          default: true
+        }]);
+
+        if (installPython) {
+          await installPythonDeps(missingPython);
+        }
       }
     } else if (missingPython.length > 0 && (!hasPython || !hasPip)) {
       console.log(chalk.yellow('\n⚠️  Python packages are needed but Python/pip is not available.'));

package/src/utils/config.js

@@ -41,70 +41,86 @@ const DEFAULT_SETTINGS = {
       "Edit(*)"
     ],
     deny: []
+  },
+  hooks: {
+    PostToolUse: [
+      {
+        matcher: "Write|Edit",
+        hooks: [
+          {
+            type: "command",
+            command: "jq -r '.tool_input.file_path // empty' | xargs -I {} bash .claude/scripts/safe-graph-update.sh '{}'"
+          }
+        ]
+      }
+    ]
   }
 };
 
-/**
- * Hooks for automatic graph updates
- *
- * IMPORTANT: Hooks should be resilient and fail gracefully.
- * - Use `|| true` to prevent hook failures from blocking Claude
- * - Add retry limits to prevent infinite loops
- * - Keep hooks fast (< 2 seconds) to avoid slowing down workflow
- */
-const DEFAULT_HOOKS = {
-  postToolUse: [
-    {
-      matcher: {
-        toolName: "Write|Edit",
-        path: "plans/**/*.md"     // Only trigger on .md files in plans/
-      },
-      command: "bash .claude/scripts/safe-graph-update.sh $PATH",
-      // Retry configuration (Claude Code built-in support)
-      retries: {
-        maxAttempts: 3,           // Max 3 attempts total
-        backoff: "exponential",    // Wait longer between retries
-        failureAction: "warn"      // Show warning but don't block
-      },
-      timeout: 5000  // 5 second timeout per attempt
-    }
-  ]
-};
+// Hooks are now configured in settings.json (see DEFAULT_SETTINGS)
 
 /**
  * Set up Claude Code settings
+ * Creates TWO files:
+ * - settings.json (with hooks, checked into git)
+ * - settings.local.json (with permissions, gitignored)
  */
 export async function setupSettings(projectPath, options = {}) {
   const claudePath = path.join(projectPath, '.claude');
-  const settingsPath = path.join(claudePath, 'settings.local.json');
+  const settingsPath = path.join(claudePath, 'settings.json');
+  const settingsLocalPath = path.join(claudePath, 'settings.local.json');
 
   await fs.ensureDir(claudePath);
 
-  let settings = DEFAULT_SETTINGS;
+  // Create settings.json with hooks (for team, checked in)
+  const settingsJsonContent = {
+    hooks: DEFAULT_SETTINGS.hooks
+  };
+
+  await fs.writeJson(settingsPath, settingsJsonContent, { spaces: 2 });
+
+  // Create/update settings.local.json with permissions (personal, gitignored)
+  let localSettings = {
+    permissions: DEFAULT_SETTINGS.permissions
+  };
 
   // Merge with existing if present
-  if (await fs.pathExists(settingsPath)) {
+  if (await fs.pathExists(settingsLocalPath)) {
     try {
-      const existing = await fs.readJson(settingsPath);
-      settings = mergeSettings(existing, settings);
+      const existing = await fs.readJson(settingsLocalPath);
+      localSettings = {
+        permissions: {
+          allow: [...new Set([
+            ...(existing.permissions?.allow || []),
+            ...(DEFAULT_SETTINGS.permissions?.allow || [])
+          ])],
+          deny: [...new Set([
+            ...(existing.permissions?.deny || []),
+            ...(DEFAULT_SETTINGS.permissions?.deny || [])
+          ])]
+        }
+      };
     } catch (e) {
       // Invalid JSON, use defaults
     }
   }
 
-  await fs.writeJson(settingsPath, settings, { spaces: 2 });
+  await fs.writeJson(settingsLocalPath, localSettings, { spaces: 2 });
 
-  return { path: settingsPath, settings };
+  return {
+    settingsPath,
+    settingsLocalPath,
+    settings: { ...settingsJsonContent, ...localSettings }
+  };
 }
 
 /**
- * Set up hooks
+ * Set up hook scripts (hooks config is in settings.json)
  */
 export async function setupHooks(projectPath, options = {}) {
   if (options.noHooks) return null;
 
   const claudePath = path.join(projectPath, '.claude');
-  const hooksPath = path.join(claudePath, 'hooks.json');
   const claudeScriptsPath = path.join(claudePath, 'scripts');
 
   await fs.ensureDir(claudePath);
@@ -124,27 +140,14 @@ export async function setupHooks(projectPath, options = {}) {
     }
   }
 
-  let hooks = DEFAULT_HOOKS;
-
-  // Merge with existing if present
-  if (await fs.pathExists(hooksPath)) {
-    try {
-      const existing = await fs.readJson(hooksPath);
-      hooks = mergeHooks(existing, hooks);
-    } catch (e) {
-      // Invalid JSON, use defaults
-    }
-  }
+  // Copy graph.py to .claude/scripts/ (for docs-graph hook)
+  const graphSource = path.join(__dirname, '../../project-scripts/graph.py');
+  const graphDest = path.join(claudeScriptsPath, 'graph.py');
 
-  // Update command to use safe wrapper if it exists
-  if (hooks.postToolUse && hooks.postToolUse[0]) {
-    if (await fs.pathExists(wrapperDest)) {
-      hooks.postToolUse[0].command = "bash .claude/scripts/safe-graph-update.sh $PATH";
-    }
+  if (await fs.pathExists(graphSource)) {
+    await fs.copy(graphSource, graphDest);
   }
 
-  await fs.writeJson(hooksPath, hooks, { spaces: 2 });
-
   // Copy hooks guide documentation
   const hooksGuideSource = path.join(TEMPLATES_PATH, 'hooks-guide.md');
   const hooksGuideDest = path.join(claudePath, 'hooks-guide.md');
@@ -153,7 +156,7 @@ export async function setupHooks(projectPath, options = {}) {
     await fs.copy(hooksGuideSource, hooksGuideDest);
   }
 
-  return { path: hooksPath, hooks };
+  return { scriptsPath: claudeScriptsPath };
 }
 
 /**
@@ -292,32 +295,4 @@ export async function updateGitignore(projectPath) {
   return { action: 'created' };
 }
 
-/**
- * Merge settings objects
- */
-function mergeSettings(existing, defaults) {
-  return {
-    permissions: {
-      allow: [...new Set([
-        ...(existing.permissions?.allow || []),
-        ...(defaults.permissions?.allow || [])
-      ])],
-      deny: [...new Set([
-        ...(existing.permissions?.deny || []),
-        ...(defaults.permissions?.deny || [])
-      ])]
-    }
-  };
-}
-
-/**
- * Merge hooks objects
- */
-function mergeHooks(existing, defaults) {
-  // For now, just use defaults if hooks exist
-  // More sophisticated merging could be added
-  return {
-    ...defaults,
-    ...existing
-  };
-}
+// mergeSettings and mergeHooks removed - settings split into settings.json and settings.local.json

package/templates/hooks-guide.md

@@ -52,10 +52,10 @@ Always append `|| true` to prevent hook failures from blocking:
 
 ```bash
 # Good - fails gracefully
-python3 scripts/graph.py --check-path $PATH || true
+python3 .claude/scripts/graph.py --check-path $PATH || true
 
 # Bad - failure blocks Claude
-python3 scripts/graph.py --check-path $PATH
+python3 .claude/scripts/graph.py --check-path $PATH
 ```
 
 ### 3. Add Timeout Guards
@@ -64,7 +64,7 @@ Protect against hanging commands:
 
 ```json
 {
-  "command": "timeout 10s python3 scripts/graph.py --check-path $PATH || true",
+  "command": "timeout 10s python3 .claude/scripts/graph.py --check-path $PATH || true",
   "timeout": 15000
 }
 ```
@@ -138,7 +138,7 @@ Check if required tools exist before running:
 
 ```json
 {
-  "command": "command -v python3 >/dev/null 2>&1 && python3 scripts/graph.py --check-path $PATH || true"
+  "command": "command -v python3 >/dev/null 2>&1 && python3 .claude/scripts/graph.py --check-path $PATH || true"
 }
 ```
 
@@ -153,12 +153,12 @@ if ! command -v python3 &> /dev/null; then
   exit 0
 fi
 
-if [ ! -f "scripts/graph.py" ]; then
+if [ ! -f ".claude/scripts/graph.py" ]; then
   echo "graph.py not found, skipping"
   exit 0
 fi
 
-timeout 10s python3 scripts/graph.py --check-path "$1" || true
+timeout 10s python3 .claude/scripts/graph.py --check-path "$1" || true
 ```
 
 Then in hooks.json:
@@ -182,7 +182,7 @@ Choose the right `failureAction` based on hook criticality:
 **Example - Non-critical hook:**
 ```json
 {
-  "command": "python3 scripts/graph.py --check-path $PATH || true",
+  "command": "python3 .claude/scripts/graph.py --check-path $PATH || true",
   "retries": {
     "maxAttempts": 3,
     "failureAction": "warn"
@@ -209,7 +209,7 @@ If a hook keeps failing:
 
 Claude Code logs hook output. Look for:
 ```
-[Hook Failed] postToolUse: python3 scripts/graph.py
+[Hook Failed] postToolUse: python3 .claude/scripts/graph.py
 Exit code: 1
 Stderr: ModuleNotFoundError: No module named 'networkx'
 ```
@@ -219,7 +219,7 @@ Stderr: ModuleNotFoundError: No module named 'networkx'
 Run the hook command directly:
 ```bash
 cd /path/to/project
-python3 scripts/graph.py --check-path plans/brd/README.md
+python3 .claude/scripts/graph.py --check-path plans/brd/README.md
 ```
 
 ### 3. Common Issues
@@ -244,7 +244,7 @@ To temporarily disable a problematic hook:
         "toolName": "Write|Edit",
         "path": "plans/**/*"
       },
-      "command": "python3 scripts/graph.py --check-path $PATH || true",
+      "command": "python3 .claude/scripts/graph.py --check-path $PATH || true",
       "enabled": false
     }
   ]
@@ -287,10 +287,10 @@ set -e
 command -v python3 >/dev/null 2>&1 || exit 0
 
 # Exit early if script missing
-[ -f "scripts/graph.py" ] || exit 0
+[ -f ".claude/scripts/graph.py" ] || exit 0
 
 # Run with timeout and graceful failure
-timeout 10s python3 scripts/graph.py --check-path "$1" || {
+timeout 10s python3 .claude/scripts/graph.py --check-path "$1" || {
   echo "Graph update failed (non-critical), continuing..."
   exit 0
 }
@@ -304,7 +304,7 @@ timeout 10s python3 scripts/graph.py --check-path "$1" || {
 {
   "postToolUse": [{
     "matcher": { "toolName": "Write|Edit", "path": "plans/**/*" },
-    "command": "python3 scripts/graph.py --check-path $PATH"
+    "command": "python3 .claude/scripts/graph.py --check-path $PATH"
   }]
 }
 ```

package/templates/scripts/safe-graph-update.sh

@@ -13,7 +13,7 @@ set -e
 
 # Configuration
 TIMEOUT_SECONDS=10
-GRAPH_SCRIPT="scripts/graph.py"
+GRAPH_SCRIPT=".claude/scripts/graph.py"
 MAX_RETRIES=0  # Let Claude Code handle retries
 
 # Colors for output (optional)