@codfish/actions 1.1.0 → 2.0.0

package/tests/integration/comment/basic.bats

@@ -17,13 +17,13 @@ teardown() {
     # Test tag generation logic from action
     TAG_INPUT="test-tag"
     MESSAGE_INPUT="Hello, World!"
-    
+
     bash -c "
         tag=\"<!-- codfish/actions/comment $TAG_INPUT -->\"
         echo \"Generated tag: \$tag\"
         echo \"tag=\$tag\"
     " > output.txt
-    
+
     assert_output_contains "tag=<!-- codfish/actions/comment test-tag -->" "$(cat output.txt)"
 }
 
@@ -32,13 +32,13 @@ teardown() {
     MESSAGE_INPUT="Line 1
 Line 2
 Line 3"
-    
+
     bash -c '
         body=$(printf "$1")
         echo "Processed message:"
         echo "$body"
     ' -- "$MESSAGE_INPUT" > output.txt
-    
+
     assert_output_contains "Line 1" "$(cat output.txt)"
     assert_output_contains "Line 2" "$(cat output.txt)"
     assert_output_contains "Line 3" "$(cat output.txt)"
@@ -52,13 +52,13 @@ Line 3"
 - Item 2
 
 **Bold text** and *italic text*"
-    
+
     bash -c '
         body=$(printf "$1")
         echo "Markdown message:"
         echo "$body"
     ' -- "$MESSAGE_INPUT" > output.txt
-    
+
     assert_output_contains "## Test Header" "$(cat output.txt)"
     assert_output_contains "- Item 1" "$(cat output.txt)"
     assert_output_contains "**Bold text**" "$(cat output.txt)"
@@ -68,7 +68,7 @@ Line 3"
     # Test complete body generation
     TAG_INPUT="build-status"
     MESSAGE_INPUT="✅ Build successful!"
-    
+
     bash -c "
         tag=\"<!-- codfish/actions/comment $TAG_INPUT -->\"
         body=\$(printf '$MESSAGE_INPUT')
@@ -76,7 +76,7 @@ Line 3"
         echo \"\$body\"
         echo \"\$tag\"
     " > output.txt
-    
+
     assert_output_contains "✅ Build successful!" "$(cat output.txt)"
     assert_output_contains "<!-- codfish/actions/comment build-status -->" "$(cat output.txt)"
 }
@@ -85,11 +85,11 @@ Line 3"
     # Test with empty tag
     TAG_INPUT=""
     MESSAGE_INPUT="Message without tag"
-    
+
     bash -c "
         tag=\"<!-- codfish/actions/comment $TAG_INPUT -->\"
         echo \"Tag with empty input: \$tag\"
     " > output.txt
-    
+
     assert_output_contains "<!-- codfish/actions/comment  -->" "$(cat output.txt)"
-}
+}

package/tests/integration/npm-pr-version/basic.bats

@@ -16,32 +16,32 @@ teardown() {
 @test "npm-pr-version: generates correct PR version format" {
     # Setup test repo
     cp "$BATS_TEST_DIRNAME/../../../tests/fixtures/package-json/valid.json" package.json
-    
+
     # Mock npm command
     mock_npm_publish
-    
+
     # Set PR and SHA environment variables
     export PR=123
     export SHA="abcdef1234567890"
-    
+
     # Test version generation logic
     bash -c '
         version="0.0.0-PR-${PR}--$(echo ${SHA} | cut -c -7)"
         echo "Generated version: $version"
         echo "version=$version"
     ' > output.txt
-    
+
     assert_output_contains "version=0.0.0-PR-123--abcdef1" "$(cat output.txt)"
 }
 
 @test "npm-pr-version: updates package.json version" {
     # Setup test repo
     cp "$BATS_TEST_DIRNAME/../../../tests/fixtures/package-json/valid.json" package.json
-    
+
     # Set environment variables
     export PR=456
     export SHA="fedcba0987654321"
-    
+
     # Test version update in package.json
     bash -c '
         version="0.0.0-PR-${PR}--$(echo ${SHA} | cut -c -7)"
@@ -49,7 +49,7 @@ teardown() {
         echo "Updated package.json:"
         cat package.json | grep "\"version\""
     ' > output.txt 2>/dev/null || echo "npm version failed" > output.txt
-    
+
     # Check if version was updated (npm version command may not be available in test env)
     if grep -q "npm version failed" output.txt; then
         # Fallback: test with manual JSON update
@@ -60,17 +60,17 @@ teardown() {
             cat package.json | grep "\"version\""
         ' > output.txt
     fi
-    
+
     assert_output_contains "0.0.0-PR-456--fedcba0" "$(cat output.txt)"
 }
 
 @test "npm-pr-version: handles scoped packages" {
     # Setup test repo with scoped package
     cp "$BATS_TEST_DIRNAME/../../../tests/fixtures/package-json/scoped.json" package.json
-    
+
     export PR=789
     export SHA="1234567890abcdef"
-    
+
     # Test with scoped package
     bash -c '
         version="0.0.0-PR-${PR}--$(echo ${SHA} | cut -c -7)"
@@ -78,7 +78,7 @@ teardown() {
         echo "Testing scoped package:"
         cat package.json | grep "\"name\""
     ' > output.txt
-    
+
     assert_output_contains "version=0.0.0-PR-789--1234567" "$(cat output.txt)"
     assert_output_contains "@test-org/scoped-package" "$(cat output.txt)"
 }
@@ -87,10 +87,10 @@ teardown() {
     # Setup test repo with yarn lockfile
     cp "$BATS_TEST_DIRNAME/../../../tests/fixtures/package-json/valid.json" package.json
     cp "$BATS_TEST_DIRNAME/../../../tests/fixtures/lockfiles/yarn.lock" .
-    
+
     export PR=456
     export SHA="fedcba0987654321"
-    
+
     # Test package manager detection
     bash -c '
         if [ -f "./yarn.lock" ]; then
@@ -105,7 +105,7 @@ teardown() {
         fi
         echo "package-manager=$package_manager"
     ' > output.txt
-    
+
     assert_output_contains "package-manager=yarn" "$(cat output.txt)"
     assert_output_contains "Detected package manager: yarn" "$(cat output.txt)"
 }
@@ -114,10 +114,10 @@ teardown() {
     # Setup test repo with pnpm lockfile
     cp "$BATS_TEST_DIRNAME/../../../tests/fixtures/package-json/valid.json" package.json
     cp "$BATS_TEST_DIRNAME/../../../tests/fixtures/lockfiles/pnpm-lock.yaml" .
-    
+
     export PR=789
     export SHA="1234567890abcdef"
-    
+
     # Test package manager detection
     bash -c '
         if [ -f "./yarn.lock" ]; then
@@ -132,7 +132,7 @@ teardown() {
         fi
         echo "package-manager=$package_manager"
     ' > output.txt
-    
+
     assert_output_contains "package-manager=pnpm" "$(cat output.txt)"
     assert_output_contains "Detected package manager: pnpm" "$(cat output.txt)"
 }
@@ -141,7 +141,7 @@ teardown() {
     # Test without package.json
     export PR=999
     export SHA="testsha123456789"
-    
+
     # This should fail
     bash -c '
         if [ ! -f "package.json" ]; then
@@ -149,7 +149,7 @@ teardown() {
             exit 1
         fi
     ' > output.txt 2>&1 || echo "exit-code=$?" >> output.txt
-    
+
     assert_output_contains "ERROR: package.json not found" "$(cat output.txt)"
 }
 
@@ -162,7 +162,7 @@ teardown() {
         fi
         echo "comment=$comment_input"
     ' > output.txt
-    
+
     assert_output_contains "comment=true" "$(cat output.txt)"
 }
 
@@ -171,7 +171,7 @@ teardown() {
     bash -c '
         comment_input="false"
         echo "comment=$comment_input"
-        
+
         # Simulate conditional comment step
         if [ "$comment_input" = "true" ]; then
             echo "Would create comment"
@@ -179,7 +179,7 @@ teardown() {
             echo "Skipping comment creation"
         fi
     ' > output.txt
-    
+
     assert_output_contains "comment=false" "$(cat output.txt)"
     assert_output_contains "Skipping comment creation" "$(cat output.txt)"
 }
@@ -193,7 +193,7 @@ teardown() {
         fi
         echo "comment-tag=$comment_tag_input"
     ' > output.txt
-    
+
     assert_output_contains "comment-tag=npm-publish-pr" "$(cat output.txt)"
 }
 
@@ -202,11 +202,11 @@ teardown() {
     bash -c '
         comment_tag_input="my-custom-tag"
         echo "comment-tag=$comment_tag_input"
-        
+
         # Simulate using custom tag in comment action
         echo "Using tag: $comment_tag_input for PR comment"
     ' > output.txt
-    
+
     assert_output_contains "comment-tag=my-custom-tag" "$(cat output.txt)"
     assert_output_contains "Using tag: my-custom-tag for PR comment" "$(cat output.txt)"
 }
@@ -216,10 +216,10 @@ teardown() {
     bash -c '
         comment_input="false"
         comment_tag_input="custom-npm-publish"
-        
+
         echo "comment=$comment_input"
         echo "comment-tag=$comment_tag_input"
-        
+
         # Simulate the conditional logic from action.yml
         if [ "$comment_input" = "true" ]; then
             echo "Would use codfish/actions/comment@main with tag: $comment_tag_input"
@@ -227,7 +227,7 @@ teardown() {
             echo "Comment step skipped due to comment=false"
         fi
     ' > output.txt
-    
+
     assert_output_contains "comment=false" "$(cat output.txt)"
     assert_output_contains "comment-tag=custom-npm-publish" "$(cat output.txt)"
     assert_output_contains "Comment step skipped due to comment=false" "$(cat output.txt)"
@@ -239,21 +239,21 @@ teardown() {
         comment_input="true"
         comment_tag_input="npm-publish-pr"
         publish_success="true"
-        
+
         echo "comment=$comment_input"
         echo "comment-tag=$comment_tag_input"
-        
+
         # Simulate before comment
         if [ "$comment_input" = "true" ]; then
             echo "Before: Publishing PR version..."
         fi
-        
+
         # Simulate publish step
         if [ "$publish_success" = "true" ]; then
             echo "Publish: SUCCESS"
             package_name="test-package"
             version="0.0.0-PR-123--abc1234"
-            
+
             # Simulate success comment
             if [ "$comment_input" = "true" ]; then
                 echo "After: PR package published successfully! Install with: npm install $package_name@$version"
@@ -261,14 +261,14 @@ teardown() {
         else
             echo "Publish: FAILED"
             error_message="Failed to publish"
-            
+
             # Simulate error comment
             if [ "$comment_input" = "true" ]; then
                 echo "After: PR package publish failed! Error: $error_message"
             fi
         fi
     ' > output.txt
-    
+
     assert_output_contains "Before: Publishing PR version..." "$(cat output.txt)"
     assert_output_contains "Publish: SUCCESS" "$(cat output.txt)"
     assert_output_contains "After: PR package published successfully!" "$(cat output.txt)"
@@ -281,29 +281,29 @@ teardown() {
         comment_input="true"
         comment_tag_input="npm-publish-pr"
         publish_success="false"
-        
+
         echo "comment=$comment_input"
         echo "comment-tag=$comment_tag_input"
-        
+
         # Simulate before comment
         if [ "$comment_input" = "true" ]; then
             echo "Before: Publishing PR version..."
         fi
-        
+
         # Simulate publish step failure
         if [ "$publish_success" = "true" ]; then
             echo "Publish: SUCCESS"
         else
             echo "Publish: FAILED"
             error_message="Failed to publish package with npm. Error: E403 Forbidden"
-            
+
             # Simulate error comment
             if [ "$comment_input" = "true" ]; then
                 echo "After: PR package publish failed! Error: $error_message"
             fi
         fi
     ' > output.txt
-    
+
     assert_output_contains "Before: Publishing PR version..." "$(cat output.txt)"
     assert_output_contains "Publish: FAILED" "$(cat output.txt)"
     assert_output_contains "After: PR package publish failed!" "$(cat output.txt)"
@@ -313,20 +313,20 @@ teardown() {
 @test "npm-pr-version: error handling with package name extraction" {
     # Setup test repo with package.json
     cp "$BATS_TEST_DIRNAME/../../../tests/fixtures/package-json/valid.json" package.json
-    
+
     # Test error message generation with package name
     bash -c '
         # Simulate package name extraction
         if [ -f "package.json" ]; then
             package_name=$(jq -r ".name // empty" package.json)
             echo "package-name=$package_name"
-            
+
             # Simulate error scenario
             error_message="❌ ERROR: Failed to publish package with npm. Error: E403 Forbidden - you must be logged in"
             echo "error-message=$error_message"
         fi
     ' > output.txt
-    
+
     assert_output_contains "package-name=test-package" "$(cat output.txt)"
     assert_output_contains "error-message=❌ ERROR: Failed to publish package with npm" "$(cat output.txt)"
     assert_output_contains "E403 Forbidden" "$(cat output.txt)"
@@ -336,18 +336,103 @@ teardown() {
     # Test npm version error handling with output capture
     bash -c '
         version="invalid-version"
-        
+
         # Simulate npm version command failure with output
         version_output="npm ERR! Invalid version: \"invalid-version\""
         version_exit_code=1
-        
+
         if [ $version_exit_code -ne 0 ]; then
             error_message="❌ ERROR: Failed to update package version. Check if the version format is valid. Error: $version_output"
             echo "error-message=$error_message"
         fi
     ' > output.txt
-    
+
     assert_output_contains "error-message=❌ ERROR: Failed to update package version" "$(cat output.txt)"
     assert_output_contains "Check if the version format is valid" "$(cat output.txt)"
     assert_output_contains "npm ERR! Invalid version" "$(cat output.txt)"
-}
+}
+
+@test "npm-pr-version: error message sanitization" {
+    # Test that multi-line error messages are properly sanitized
+    bash -c '
+        # Define sanitize_error function
+        sanitize_error() {
+          local message="$1"
+          echo "$message" | tr '"'"'\n'"'"' '"'"' '"'"' | tr -s '"'"' '"'"' | cut -c1-500
+        }
+
+        # Simulate multi-line pnpm error
+        publish_output="ERR_PNPM_GIT_UNCLEAN  Unclean working tree. Commit or stash changes first.
+If you want to disable Git checks on publish, set the \"git-checks\" setting to \"false\", or run again with \"--no-git-checks\"."
+
+        error_message="❌ ERROR: Failed to publish package with pnpm. Error: $publish_output"
+        sanitized=$(sanitize_error "$error_message")
+
+        echo "raw-error=$error_message"
+        echo "sanitized-error=$sanitized"
+    ' > output.txt
+
+    # Check that sanitized version has no newlines and is truncated
+    sanitized_line=$(grep "^sanitized-error=" output.txt)
+
+    # Should not contain literal newlines in the sanitized output
+    assert_output_contains "sanitized-error=❌ ERROR: Failed to publish package with pnpm" "$(cat output.txt)"
+    assert_output_contains "ERR_PNPM_GIT_UNCLEAN" "$(cat output.txt)"
+
+    # Verify no newlines in sanitized version (count lines should be 1)
+    newline_count=$(echo "$sanitized_line" | wc -l)
+    [ "$newline_count" -eq 1 ]
+}
+
+@test "npm-pr-version: workflow link in error comment" {
+    # Test that error comment includes workflow link
+    bash -c '
+        # Simulate GitHub environment variables
+        GITHUB_SERVER_URL="https://github.com"
+        GITHUB_REPOSITORY="owner/repo"
+        GITHUB_RUN_ID="12345678"
+
+        # Simulate error comment with workflow link
+        error_message="Failed to publish"
+
+        # Generate comment like the action would
+        comment_message="❌ **PR package publish failed!**
+
+Error: $error_message
+
+📋 [View workflow logs]($GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID) for more details."
+
+        echo "comment-message=$comment_message"
+    ' > output.txt
+
+    assert_output_contains "📋 [View workflow logs]" "$(cat output.txt)"
+    assert_output_contains "https://github.com/owner/repo/actions/runs/12345678" "$(cat output.txt)"
+    assert_output_contains "for more details." "$(cat output.txt)"
+}
+
+@test "npm-pr-version: commits package.json after version update" {
+    # Test that package.json is committed after npm version to keep git clean
+    bash -c '
+        # Simulate the version update and git commit workflow
+        echo "Simulating npm version update..."
+        echo "package.json modified"
+
+        # Simulate git configuration and commit (as per action.yml)
+        echo "Configuring git user..."
+        echo "git config user.name github-actions[bot]"
+        echo "git config user.email github-actions[bot]@users.noreply.github.com"
+        echo "Committing package.json changes..."
+        echo "git add package.json"
+        echo "git commit -m ci: update package version"
+        echo "working-tree=clean"
+
+        # This prevents pnpm/yarn git checks from failing
+        echo "pnpm-ready=true"
+    ' > output.txt
+
+    assert_output_contains "git config user.name github-actions[bot]" "$(cat output.txt)"
+    assert_output_contains "git add package.json" "$(cat output.txt)"
+    assert_output_contains "git commit -m ci: update package version" "$(cat output.txt)"
+    assert_output_contains "working-tree=clean" "$(cat output.txt)"
+    assert_output_contains "pnpm-ready=true" "$(cat output.txt)"
+}