@codeyam/codeyam-cli 0.1.20 → 0.1.22

package/codeyam-cli/src/utils/__tests__/editorAudit.test.js

@@ -1,6 +1,6 @@
 import Database from 'better-sqlite3';
 import { Kysely, SqliteDialect } from 'kysely';
-import { isComponent, classifyGlossaryEntries, computeAudit, filterGlossaryByChangeStatus, resolveAuditSessionScope, queryScenarioCounts, queryPageScenarioCounts, queryIncompleteEntities, queryMiscategorizedScenarios, queryUnassociatedScenarios, isOnlyIncompleteEntities, isAutoRemediable, identifyScenariosNeedingRecapture, detectDuplicateNames, } from "../editorAudit.js";
+import { isComponent, classifyGlossaryEntries, computeAudit, filterGlossaryByChangeStatus, resolveAuditSessionScope, queryScenarioCounts, queryPageScenarioCounts, queryIncompleteEntities, queryMiscategorizedScenarios, queryUnassociatedScenarios, isOnlyIncompleteEntities, isOnlyPreExistingIncomplete, isAutoRemediable, identifyScenariosNeedingRecapture, detectDuplicateNames, aggregateClientErrorsByComponent, } from "../editorAudit.js";
 describe('editorAudit', () => {
     describe('isComponent', () => {
         it('should return true for JSX.Element return type', () => {
@@ -1466,6 +1466,279 @@ describe('editorAudit', () => {
             expect(auditResult.summary.incompleteEntities).toBeUndefined();
         });
     });
+    // ── filterToIncompleteFilePaths ──────────────────────────────────────
+    describe('filterToIncompleteFilePaths', () => {
+        // analyze-imports processes ALL file paths (~120 files) even when only
+        // a few need analysis. This function filters to files that have no
+        // entity with an analysis record.
+        let db;
+        let rawDb;
+        const projectId = 'test-project-id';
+        beforeEach(async () => {
+            rawDb = new Database(':memory:');
+            db = new Kysely({ dialect: new SqliteDialect({ database: rawDb }) });
+            await db.schema
+                .createTable('analyses')
+                .addColumn('id', 'varchar', (col) => col.primaryKey())
+                .addColumn('entity_sha', 'varchar')
+                .addColumn('entity_name', 'varchar')
+                .addColumn('project_id', 'varchar')
+                .execute();
+            await db.schema
+                .createTable('entities')
+                .addColumn('sha', 'varchar', (col) => col.primaryKey())
+                .addColumn('name', 'varchar')
+                .addColumn('entity_type', 'varchar')
+                .addColumn('file_path', 'varchar')
+                .execute();
+        });
+        afterEach(async () => {
+            await db.destroy();
+        });
+        it('should exclude files that have an entity with an analysis', async () => {
+            const { filterToIncompleteFilePaths } = require('../editorAudit');
+            // Entity with analysis — skip
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-header',
+                name: 'Header',
+                entity_type: 'visual',
+                file_path: 'app/components/Header.tsx',
+            })
+                .execute();
+            await db
+                .insertInto('analyses')
+                .values({
+                id: 'a-1',
+                entity_sha: 'sha-header',
+                entity_name: 'Header',
+                project_id: projectId,
+            })
+                .execute();
+            // Entity without analysis — needs analysis
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-rule',
+                name: 'RuleBuilder',
+                entity_type: 'visual',
+                file_path: 'app/components/RuleBuilder.tsx',
+            })
+                .execute();
+            const allFilePaths = [
+                'app/components/Header.tsx',
+                'app/components/RuleBuilder.tsx',
+                'app/components/Footer.tsx', // no entity — needs analysis
+            ];
+            const result = await filterToIncompleteFilePaths(db, projectId, allFilePaths);
+            expect(result).toContain('app/components/RuleBuilder.tsx');
+            expect(result).toContain('app/components/Footer.tsx');
+            expect(result).not.toContain('app/components/Header.tsx');
+        });
+        it('should return all file paths when no entities exist yet', async () => {
+            const { filterToIncompleteFilePaths } = require('../editorAudit');
+            const filePaths = ['app/Foo.tsx', 'app/Bar.tsx'];
+            const result = await filterToIncompleteFilePaths(db, projectId, filePaths);
+            expect(result).toEqual(filePaths);
+        });
+        it('should return empty when all files have analyzed entities', async () => {
+            const { filterToIncompleteFilePaths } = require('../editorAudit');
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-a',
+                name: 'CompA',
+                entity_type: 'visual',
+                file_path: 'app/CompA.tsx',
+            })
+                .execute();
+            await db
+                .insertInto('analyses')
+                .values({
+                id: 'a-1',
+                entity_sha: 'sha-a',
+                entity_name: 'CompA',
+                project_id: projectId,
+            })
+                .execute();
+            const result = await filterToIncompleteFilePaths(db, projectId, [
+                'app/CompA.tsx',
+            ]);
+            expect(result).toEqual([]);
+        });
+        it('should skip files with analysis even without scenarios', async () => {
+            const { filterToIncompleteFilePaths } = require('../editorAudit');
+            // Entity with analysis but NO scenarios — still complete
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-util',
+                name: 'utils',
+                entity_type: 'library',
+                file_path: 'app/lib/utils.ts',
+            })
+                .execute();
+            await db
+                .insertInto('analyses')
+                .values({
+                id: 'a-1',
+                entity_sha: 'sha-util',
+                entity_name: 'utils',
+                project_id: projectId,
+            })
+                .execute();
+            const result = await filterToIncompleteFilePaths(db, projectId, [
+                'app/lib/utils.ts',
+            ]);
+            expect(result).toEqual([]);
+        });
+    });
+    // ── phantom entity SHAs ─────────────────────────────────────────────
+    describe('queryIncompleteEntities with phantom entity SHAs', () => {
+        // Root cause of the Margo/reader step-blocking bug:
+        // Scenarios registered without component_path got a phantom entity_sha
+        // computed from component_name alone. These SHAs have NO entity record
+        // in the entities table and NO analyses. syncScenarioEntityShas can't
+        // fix them (it skips scenarios without component_path). So they remain
+        // "incomplete" forever, blocking step progression.
+        //
+        // Fix: queryIncompleteEntities should not report scenarios whose
+        // entity_sha has no entity record — these are orphaned data, not
+        // fixable by running analyze-imports.
+        let db;
+        let rawDb;
+        const projectId = 'test-project-id';
+        beforeEach(async () => {
+            rawDb = new Database(':memory:');
+            db = new Kysely({ dialect: new SqliteDialect({ database: rawDb }) });
+            await db.schema
+                .createTable('editor_scenarios')
+                .addColumn('id', 'varchar', (col) => col.primaryKey())
+                .addColumn('project_id', 'varchar', (col) => col.notNull())
+                .addColumn('name', 'varchar', (col) => col.notNull())
+                .addColumn('component_name', 'varchar')
+                .addColumn('component_path', 'varchar')
+                .addColumn('entity_sha', 'varchar')
+                .addColumn('display_name', 'varchar')
+                .addColumn('page_file_path', 'varchar')
+                .addColumn('url', 'varchar')
+                .addColumn('created_at', 'datetime')
+                .addColumn('updated_at', 'datetime')
+                .execute();
+            await db.schema
+                .createTable('analyses')
+                .addColumn('id', 'varchar', (col) => col.primaryKey())
+                .addColumn('entity_sha', 'varchar')
+                .addColumn('entity_name', 'varchar')
+                .addColumn('project_id', 'varchar')
+                .execute();
+            await db.schema
+                .createTable('entities')
+                .addColumn('sha', 'varchar', (col) => col.primaryKey())
+                .addColumn('name', 'varchar')
+                .addColumn('entity_type', 'varchar')
+                .addColumn('file_path', 'varchar')
+                .execute();
+        });
+        afterEach(async () => {
+            await db.destroy();
+        });
+        it('should not report scenarios with phantom entity SHAs (no entity record exists)', async () => {
+            // Real entity — has an entity record, analyses, and scenarios. Complete.
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-real',
+                name: 'RuleBuilder',
+                entity_type: 'visual',
+                file_path: 'app/components/RuleBuilder.tsx',
+            })
+                .execute();
+            await db
+                .insertInto('analyses')
+                .values({
+                id: 'a-1',
+                entity_sha: 'sha-real',
+                entity_name: 'RuleBuilder',
+                project_id: projectId,
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-good',
+                project_id: projectId,
+                name: 'RuleBuilder - Empty',
+                component_name: 'RuleBuilder',
+                component_path: 'app/components/RuleBuilder.tsx',
+                entity_sha: 'sha-real',
+                created_at: '2026-03-16 23:00:00',
+            })
+                .execute();
+            // Phantom entity — scenario points to a SHA that doesn't exist
+            // in the entities table (registered without component_path).
+            // No entity record, no analyses, unfixable by analyze-imports.
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-phantom',
+                project_id: projectId,
+                name: 'Empty',
+                component_name: 'RuleBuilder',
+                component_path: null,
+                entity_sha: 'sha-phantom-no-entity-record',
+                created_at: '2026-03-16 22:00:00',
+            })
+                .execute();
+            const incomplete = await queryIncompleteEntities(db, projectId, null);
+            // Should NOT report phantom SHAs as incomplete — they can't be fixed
+            // by running analyze-imports (no entity record exists to resolve).
+            expect(incomplete).toHaveLength(0);
+        });
+        it('should still report real incomplete entities (entity exists but no analysis)', async () => {
+            // Real entity without analysis — this IS a legitimate incomplete entity
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-noanalysis',
+                name: 'Footer',
+                entity_type: 'visual',
+                file_path: 'app/components/Footer.tsx',
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'Footer - Default',
+                component_name: 'Footer',
+                component_path: 'app/components/Footer.tsx',
+                entity_sha: 'sha-noanalysis',
+                created_at: '2026-03-16 23:00:00',
+            })
+                .execute();
+            // Phantom scenario (shouldn't affect results)
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-phantom',
+                project_id: projectId,
+                name: 'Footer - Alt',
+                component_name: 'Footer',
+                component_path: null,
+                entity_sha: 'sha-phantom-does-not-exist',
+                created_at: '2026-03-16 22:00:00',
+            })
+                .execute();
+            const incomplete = await queryIncompleteEntities(db, projectId, null);
+            // Should report Footer (real entity, no analysis) but NOT the phantom
+            expect(incomplete).toHaveLength(1);
+            expect(incomplete[0].name).toBe('Footer');
+            expect(incomplete[0].entitySha).toBe('sha-noanalysis');
+        });
+    });
     // ── queryMiscategorizedScenarios ─────────────────────────────────────
     describe('queryMiscategorizedScenarios', () => {
         let db;
@@ -1714,10 +1987,31 @@ describe('editorAudit', () => {
                 allPassing: false,
             })).toBe(true);
         });
+        it('should return false when there are also runner errors', () => {
+            // functionsRunnerError means the test runner crashed — a real failure
+            // that cannot be fixed by entity SHA backfill or analyze-imports.
+            // If this returns true, checkAuditGate would attempt a useless backfill
+            // instead of reporting the runner error, and isOnlyPreExistingIncomplete
+            // could let the gate pass entirely.
+            expect(isOnlyIncompleteEntities({
+                componentsMissing: 0,
+                componentsWithErrors: 0,
+                functionsFailing: 0,
+                functionsRunnerError: 2,
+                functionsNameMismatch: 0,
+                functionsMissing: 0,
+                missingFromGlossary: 0,
+                incompleteEntities: 1,
+                allPassing: false,
+            })).toBe(false);
+        });
     });
     // ── isAutoRemediable ─────────────────────────────────────────────────
     describe('isAutoRemediable', () => {
-        it('should return true on first attempt when only incomplete entities', () => {
+        // isAutoRemediable always returns false — the audit never triggers
+        // full analyze-imports inline. It takes minutes on large projects.
+        // Only lightweight backfill is acceptable during audit.
+        it('should return false even on first attempt with only incomplete entities', () => {
             const result = isAutoRemediable({
                 componentsMissing: 0,
                 componentsWithErrors: 0,
@@ -1729,11 +2023,9 @@ describe('editorAudit', () => {
                 incompleteEntities: 3,
                 allPassing: false,
             }, false);
-            expect(result).toBe(true);
+            expect(result).toBe(false);
         });
-        it('should return false on second attempt (already tried once)', () => {
-            // This is the key fix: if we already tried analyze-imports and
-            // entities are STILL incomplete, don't try again — report the failure
+        it('should return false on second attempt', () => {
             const result = isAutoRemediable({
                 componentsMissing: 0,
                 componentsWithErrors: 0,
@@ -2187,8 +2479,11 @@ describe('editorAudit', () => {
                 },
             ]);
         });
-        it('should use entity name from entities table, falling back to component_name', async () => {
-            // Scenario has entity_sha but entity record doesn't exist
+        it('should skip phantom SHAs (entity_sha with no entity record)', async () => {
+            // Scenario has entity_sha but entity record doesn't exist.
+            // These are "phantom SHAs" created when scenarios were registered
+            // without component_path — they can never be fixed by analyze-imports
+            // and should not block audit progression.
             await db
                 .insertInto('editor_scenarios')
                 .values({
@@ -2201,14 +2496,8 @@ describe('editorAudit', () => {
             })
                 .execute();
             const result = await queryIncompleteEntities(db, projectId, null);
-            expect(result).toEqual([
-                {
-                    entitySha: 'sha-ghost',
-                    name: 'GhostComponent',
-                    scenarioCount: 1,
-                    preExisting: false,
-                },
-            ]);
+            // Phantom SHAs are excluded — not reportable as incomplete
+            expect(result).toEqual([]);
         });
         it('should detect incomplete entity whose scenario predates the session', async () => {
             // Entity with no analyses, scenario created BEFORE session
@@ -2508,6 +2797,25 @@ describe('editorAudit', () => {
             });
             expect(result).toHaveLength(0);
         });
+        it('should NOT flag scenarios for new entities (they need creation, not recapture)', () => {
+            // "new" entities are being seen for the first time. Their scenarios need
+            // initial creation, not recapture of old screenshots. Flagging them as
+            // "needs_recapture" sends the wrong remediation signal to Claude.
+            const entityChangeStatus = {
+                NewComponent: { status: 'new' },
+            };
+            const result = identifyScenariosNeedingRecapture({
+                scenarios: [
+                    {
+                        name: 'NewComponent - Default',
+                        entityName: 'NewComponent',
+                        updatedInSession: false,
+                    },
+                ],
+                entityChangeStatus,
+            });
+            expect(result).toHaveLength(0);
+        });
     });
     // ── detectDuplicateNames ──────────────────────────────────────────
     describe('detectDuplicateNames', () => {
@@ -2675,6 +2983,28 @@ describe('editorAudit', () => {
             expect(result.components[0].status).toBe('missing');
             expect(result.summary.componentsMissing).toBe(1);
         });
+        it('should not count needs_recapture components as componentsOk', () => {
+            // A needs_recapture component is not "ok" — it needs action. Counting it
+            // in componentsOk is misleading: if totalComponents=2, componentsOk=2,
+            // and componentsNeedingRecapture=1, the numbers don't add up (2+1 > 2).
+            const result = computeAudit({
+                components: [
+                    { name: 'Library', filePath: 'app/library/page.tsx' },
+                    { name: 'DrinkCard', filePath: 'app/components/DrinkCard.tsx' },
+                ],
+                functions: [],
+                scenarioCounts: { DrinkCard: 2 },
+                testFileExistence: {},
+                totalScenarioCounts: { Library: 3 },
+                entityChangeStatus: { Library: { status: 'impacted' } },
+            });
+            expect(result.components[0].status).toBe('needs_recapture');
+            expect(result.components[1].status).toBe('ok');
+            // needs_recapture is not "ok" — should be counted separately
+            expect(result.summary.componentsOk).toBe(1);
+            expect(result.summary.componentsNeedingRecapture).toBe(1);
+            expect(result.summary.totalComponents).toBe(2);
+        });
     });
     // ── queryUnassociatedScenarios ──────────────────────────────────────
     describe('queryUnassociatedScenarios', () => {
@@ -2923,29 +3253,659 @@ describe('editorAudit', () => {
         });
     });
     // ── isAutoRemediable with unassociatedScenarios ────────────────────
-    describe('isAutoRemediable with unassociatedScenarios', () => {
-        it('should return true when unassociatedScenarios is the only failure', () => {
-            expect(isAutoRemediable({ unassociatedScenarios: 3 }, false)).toBe(true);
+    describe('isAutoRemediable always returns false (no inline full analysis)', () => {
+        // Full analyze-imports takes minutes on large projects. The audit should
+        // never trigger it — only the lightweight backfill path is acceptable.
+        it('should return false for unassociatedScenarios only', () => {
+            expect(isAutoRemediable({ unassociatedScenarios: 3 }, false)).toBe(false);
         });
-        it('should return true when both incompleteEntities and unassociatedScenarios are the only failures', () => {
-            expect(isAutoRemediable({ incompleteEntities: 1, unassociatedScenarios: 2 }, false)).toBe(true);
+        it('should return false for incompleteEntities + unassociatedScenarios', () => {
+            expect(isAutoRemediable({ incompleteEntities: 1, unassociatedScenarios: 2 }, false)).toBe(false);
         });
-        it('should return false when unassociatedScenarios exist alongside other failures', () => {
-            expect(isAutoRemediable({ unassociatedScenarios: 2, componentsMissing: 1 }, false)).toBe(false);
+        it('should return false even with no other failures', () => {
+            expect(isAutoRemediable({ unassociatedScenarios: 2 }, false)).toBe(false);
         });
         it('should return false when already attempted', () => {
             expect(isAutoRemediable({ unassociatedScenarios: 3 }, true)).toBe(false);
         });
     });
-    describe('isOnlyIncompleteEntities with unassociatedScenarios', () => {
-        it('should return true when only unassociatedScenarios present', () => {
-            expect(isOnlyIncompleteEntities({ unassociatedScenarios: 5 })).toBe(true);
+    describe('suggestedTestFile for functions without testFile', () => {
+        it('should suggest conventional .test.ts path when testFile is undefined', () => {
+            const result = computeAudit({
+                components: [],
+                functions: [
+                    { name: 'useLibraryShell', filePath: 'app/library/context.tsx' },
+                ],
+                scenarioCounts: {},
+                testFileExistence: {},
+            });
+            expect(result.functions[0].suggestedTestFile).toBe('app/library/context.test.ts');
+            expect(result.functions[0].status).toBe('missing');
         });
-        it('should return false when unassociatedScenarios present with other failures', () => {
-            expect(isOnlyIncompleteEntities({
-                unassociatedScenarios: 5,
-                functionsMissing: 1,
-            })).toBe(false);
+        it('should suggest .test.ts for .ts files', () => {
+            const result = computeAudit({
+                components: [],
+                functions: [{ name: 'calculatePrice', filePath: 'app/lib/pricing.ts' }],
+                scenarioCounts: {},
+                testFileExistence: {},
+            });
+            expect(result.functions[0].suggestedTestFile).toBe('app/lib/pricing.test.ts');
+        });
+        it('should not set suggestedTestFile when testFile is already specified', () => {
+            const result = computeAudit({
+                components: [],
+                functions: [
+                    {
+                        name: 'calculatePrice',
+                        filePath: 'app/lib/pricing.ts',
+                        testFile: 'app/lib/pricing.test.ts',
+                    },
+                ],
+                scenarioCounts: {},
+                testFileExistence: { 'app/lib/pricing.test.ts': true },
+            });
+            expect(result.functions[0].suggestedTestFile).toBeUndefined();
+        });
+    });
+    describe('hint for function audit entries', () => {
+        it('should include a hint for name_mismatch functions explaining the fix', () => {
+            // Claude sees "name mismatch" with no guidance on what it means or how
+            // to fix it. The hint should explain that a top-level describe block
+            // matching the function name is required for the CodeYam UI.
+            const result = computeAudit({
+                components: [],
+                functions: [
+                    {
+                        name: 'useDrinks',
+                        filePath: 'app/hooks/useDrinks.ts',
+                        testFile: 'app/hooks/useDrinks.test.ts',
+                    },
+                ],
+                scenarioCounts: {},
+                testFileExistence: { 'app/hooks/useDrinks.test.ts': true },
+                testResults: {
+                    'app/hooks/useDrinks.test.ts': {
+                        passing: true,
+                        hasEntityNameDescribe: false,
+                    },
+                },
+            });
+            expect(result.functions[0].status).toBe('name_mismatch');
+            expect(result.functions[0].hint).toBeDefined();
+            expect(result.functions[0].hint).toContain('describe');
+            expect(result.functions[0].hint).toContain('useDrinks');
+        });
+        it('should include a hint for runner_error functions showing the error', () => {
+            // When the test runner crashes, Claude needs to see WHY it crashed
+            // to fix the underlying issue. Without this, Claude loops re-running audit.
+            const result = computeAudit({
+                components: [],
+                functions: [
+                    {
+                        name: 'getTimeAgo',
+                        filePath: 'src/lib/format.ts',
+                        testFile: 'src/lib/format.test.ts',
+                    },
+                ],
+                scenarioCounts: {},
+                testFileExistence: { 'src/lib/format.test.ts': true },
+                testResults: {
+                    'src/lib/format.test.ts': {
+                        passing: false,
+                        hasEntityNameDescribe: false,
+                        errorMessage: 'Cannot find module "@/lib/format"',
+                    },
+                },
+            });
+            expect(result.functions[0].status).toBe('runner_error');
+            expect(result.functions[0].hint).toBeDefined();
+            expect(result.functions[0].hint).toContain('Cannot find module');
+        });
+    });
+    describe('hint for missing components', () => {
+        it('should hint that layout files need app-level scenarios', () => {
+            const result = computeAudit({
+                components: [
+                    { name: 'LibraryLayout', filePath: 'app/library/layout.tsx' },
+                ],
+                functions: [],
+                scenarioCounts: {},
+                testFileExistence: {},
+            });
+            expect(result.components[0].hint).toContain('layout');
+            expect(result.components[0].hint).toContain('pageFilePath');
+        });
+        it('should hint that page files need app-level scenarios', () => {
+            const result = computeAudit({
+                components: [
+                    { name: 'InboxPage', filePath: 'app/library/inbox/page.tsx' },
+                ],
+                functions: [],
+                scenarioCounts: {},
+                testFileExistence: {},
+            });
+            expect(result.components[0].hint).toContain('page');
+            expect(result.components[0].hint).toContain('pageFilePath');
+        });
+        it('should hint that regular components need isolation routes', () => {
+            const result = computeAudit({
+                components: [
+                    { name: 'DrinkCard', filePath: 'app/components/DrinkCard.tsx' },
+                ],
+                functions: [],
+                scenarioCounts: {},
+                testFileExistence: {},
+            });
+            expect(result.components[0].hint).toContain('isolated-components');
+        });
+        it('should not set hint when component has scenarios', () => {
+            const result = computeAudit({
+                components: [
+                    { name: 'DrinkCard', filePath: 'app/components/DrinkCard.tsx' },
+                ],
+                functions: [],
+                scenarioCounts: { DrinkCard: 2 },
+                testFileExistence: {},
+            });
+            expect(result.components[0].hint).toBeUndefined();
+        });
+        it('should provide a hint for needs_recapture components', () => {
+            // Components with needs_recapture status need guidance on what to do.
+            // Without a hint, Claude has no instructions for fixing the issue.
+            const result = computeAudit({
+                components: [{ name: 'Library', filePath: 'app/library/page.tsx' }],
+                functions: [],
+                scenarioCounts: {},
+                testFileExistence: {},
+                totalScenarioCounts: { Library: 3 },
+                entityChangeStatus: { Library: { status: 'impacted' } },
+            });
+            expect(result.components[0].status).toBe('needs_recapture');
+            expect(result.components[0].hint).toBeDefined();
+            expect(result.components[0].hint).toContain('recapture');
+        });
+    });
+    describe('formatIncompleteEntityGuidance', () => {
+        it('should include the entity name and scenario count', () => {
+            const { formatIncompleteEntityGuidance } = require('../editorAudit');
+            const result = formatIncompleteEntityGuidance({
+                entitySha: 'abc123',
+                name: 'RuleBuilder',
+                scenarioCount: 5,
+                preExisting: false,
+            });
+            expect(result).toContain('RuleBuilder');
+            expect(result).toContain('5');
+        });
+        it('should tell Claude the exact fix command', () => {
+            const { formatIncompleteEntityGuidance } = require('../editorAudit');
+            const result = formatIncompleteEntityGuidance({
+                entitySha: 'abc123',
+                name: 'RuleBuilder',
+                scenarioCount: 5,
+                preExisting: false,
+            });
+            expect(result).toContain('codeyam editor analyze-imports');
+        });
+        it('should flag pre-existing issues as non-blocking', () => {
+            const { formatIncompleteEntityGuidance } = require('../editorAudit');
+            const result = formatIncompleteEntityGuidance({
+                entitySha: 'abc123',
+                name: 'RuleBuilder',
+                scenarioCount: 5,
+                preExisting: true,
+            });
+            expect(result).toContain('pre-existing');
+        });
+        it('should explain what incomplete means', () => {
+            const { formatIncompleteEntityGuidance } = require('../editorAudit');
+            const result = formatIncompleteEntityGuidance({
+                entitySha: 'abc123',
+                name: 'RuleBuilder',
+                scenarioCount: 5,
+                preExisting: false,
+            });
+            // Should explain the root cause, not just the symptom
+            expect(result).toMatch(/scenario.*without.*import graph|import graph.*not.*built/i);
+        });
+    });
+    describe('formatManualAnalysisGuidance', () => {
+        it('should include entity name, scenario count, and error message', () => {
+            const { formatManualAnalysisGuidance } = require('../editorAudit');
+            const result = formatManualAnalysisGuidance({
+                name: 'Header',
+                filePath: 'src/components/Header.tsx',
+                scenarioCount: 3,
+                error: 'TypeScript parsing error: unexpected token',
+            });
+            expect(result).toContain('Header');
+            expect(result).toContain('3 scenario(s)');
+            expect(result).toContain('TypeScript parsing error');
+        });
+        it('should include MANUAL ANALYSIS REQUIRED header', () => {
+            const { formatManualAnalysisGuidance } = require('../editorAudit');
+            const result = formatManualAnalysisGuidance({
+                name: 'Header',
+                filePath: 'src/components/Header.tsx',
+                scenarioCount: 2,
+                error: 'Parse error',
+            });
+            expect(result).toContain('MANUAL ANALYSIS REQUIRED');
+        });
+        it('should tell Claude to read the source file', () => {
+            const { formatManualAnalysisGuidance } = require('../editorAudit');
+            const result = formatManualAnalysisGuidance({
+                name: 'Header',
+                filePath: 'src/components/Header.tsx',
+                scenarioCount: 2,
+                error: 'Parse error',
+            });
+            expect(result).toContain('Read src/components/Header.tsx');
+        });
+        it('should include the manual-entity command', () => {
+            const { formatManualAnalysisGuidance } = require('../editorAudit');
+            const result = formatManualAnalysisGuidance({
+                name: 'Header',
+                filePath: 'src/components/Header.tsx',
+                scenarioCount: 2,
+                error: 'Parse error',
+            });
+            expect(result).toContain('codeyam editor manual-entity');
+        });
+        it('should tell Claude to check glossary for imports', () => {
+            const { formatManualAnalysisGuidance } = require('../editorAudit');
+            const result = formatManualAnalysisGuidance({
+                name: 'Header',
+                filePath: 'src/components/Header.tsx',
+                scenarioCount: 2,
+                error: 'Parse error',
+            });
+            expect(result).toContain('glossary');
+        });
+    });
+    describe('getIncompleteEntityFilePaths', () => {
+        // The audit should auto-fix incomplete entities by running analysis on
+        // just their specific file paths, not all 117+ files. This function
+        // resolves entity SHAs to file paths for targeted analysis.
+        let db;
+        let rawDb;
+        beforeEach(async () => {
+            rawDb = new Database(':memory:');
+            db = new Kysely({ dialect: new SqliteDialect({ database: rawDb }) });
+            await db.schema
+                .createTable('entities')
+                .addColumn('sha', 'varchar', (col) => col.primaryKey())
+                .addColumn('name', 'varchar')
+                .addColumn('file_path', 'varchar')
+                .addColumn('project_id', 'varchar')
+                .addColumn('entity_type', 'varchar')
+                .execute();
+        });
+        afterEach(() => {
+            rawDb.close();
+        });
+        it('should resolve entity SHAs to file paths from the entities table', async () => {
+            const { getIncompleteEntityFilePaths } = require('../editorAudit');
+            await db
+                .insertInto('entities')
+                .values([
+                {
+                    sha: 'sha-rule',
+                    name: 'RuleBuilder',
+                    file_path: 'app/components/RuleBuilder.tsx',
+                    project_id: 'p1',
+                    entity_type: 'component',
+                },
+                {
+                    sha: 'sha-row',
+                    name: 'ArticleTableRow',
+                    file_path: 'app/components/ArticleTableRow.tsx',
+                    project_id: 'p1',
+                    entity_type: 'component',
+                },
+            ])
+                .execute();
+            const result = await getIncompleteEntityFilePaths(db, [
+                {
+                    entitySha: 'sha-rule',
+                    name: 'RuleBuilder',
+                    scenarioCount: 5,
+                    preExisting: false,
+                },
+                {
+                    entitySha: 'sha-row',
+                    name: 'ArticleTableRow',
+                    scenarioCount: 2,
+                    preExisting: false,
+                },
+            ]);
+            expect(result).toContain('app/components/RuleBuilder.tsx');
+            expect(result).toContain('app/components/ArticleTableRow.tsx');
+            expect(result).toHaveLength(2);
+        });
+        it('should skip entities whose SHA is not in the entities table', async () => {
+            const { getIncompleteEntityFilePaths } = require('../editorAudit');
+            const result = await getIncompleteEntityFilePaths(db, [
+                {
+                    entitySha: 'nonexistent-sha',
+                    name: 'Ghost',
+                    scenarioCount: 1,
+                    preExisting: false,
+                },
+            ]);
+            expect(result).toHaveLength(0);
+        });
+        it('should deduplicate file paths', async () => {
+            const { getIncompleteEntityFilePaths } = require('../editorAudit');
+            await db
+                .insertInto('entities')
+                .values([
+                {
+                    sha: 'sha-v1',
+                    name: 'Foo',
+                    file_path: 'app/Foo.tsx',
+                    project_id: 'p1',
+                    entity_type: 'component',
+                },
+                {
+                    sha: 'sha-v2',
+                    name: 'Foo',
+                    file_path: 'app/Foo.tsx',
+                    project_id: 'p1',
+                    entity_type: 'component',
+                },
+            ])
+                .execute();
+            const result = await getIncompleteEntityFilePaths(db, [
+                {
+                    entitySha: 'sha-v1',
+                    name: 'Foo',
+                    scenarioCount: 3,
+                    preExisting: false,
+                },
+                {
+                    entitySha: 'sha-v2',
+                    name: 'Foo',
+                    scenarioCount: 1,
+                    preExisting: false,
+                },
+            ]);
+            expect(result).toEqual(['app/Foo.tsx']);
+        });
+    });
+    describe('isAutoRemediable never triggers full analysis', () => {
+        // The audit must NEVER run handleAnalyzeImports inline — it takes minutes
+        // for large projects. Auto-remediation should only do the lightweight
+        // entity SHA backfill. isAutoRemediable is now always false; the callers
+        // use needsBackfillOnly for the fast path instead.
+        it('should always return false regardless of summary state', () => {
+            expect(isAutoRemediable({ incompleteEntities: 5 }, false)).toBe(false);
+            expect(isAutoRemediable({ unassociatedScenarios: 3 }, false)).toBe(false);
+            expect(isAutoRemediable({ incompleteEntities: 1, unassociatedScenarios: 2 }, false)).toBe(false);
+        });
+    });
+    // ── isOnlyPreExistingIncomplete ─────────────────────────────────────
+    describe('isOnlyPreExistingIncomplete', () => {
+        it('should return true when all incomplete entities are pre-existing and no other failures', () => {
+            expect(isOnlyPreExistingIncomplete({
+                incompleteEntities: 2,
+                preExistingIncompleteEntities: 2,
+                componentsMissing: 0,
+                componentsWithErrors: 0,
+                functionsFailing: 0,
+                functionsNameMismatch: 0,
+                functionsMissing: 0,
+                missingFromGlossary: 0,
+                miscategorizedScenarios: 0,
+                scenariosNeedingRecapture: 0,
+            }, [
+                {
+                    entitySha: 'a',
+                    name: 'RuleBuilder',
+                    scenarioCount: 5,
+                    preExisting: true,
+                },
+                {
+                    entitySha: 'b',
+                    name: 'ArticleTableRow',
+                    scenarioCount: 2,
+                    preExisting: true,
+                },
+            ])).toBe(true);
+        });
+        it('should return false when there are runner errors even if all incompletes are pre-existing', () => {
+            // Safety net: runner errors (crashed test runner) must NEVER bypass the gate.
+            // Without this test, a regression removing functionsRunnerError from
+            // isOnlyIncompleteEntities would silently let broken test infrastructure through.
+            expect(isOnlyPreExistingIncomplete({
+                incompleteEntities: 1,
+                preExistingIncompleteEntities: 1,
+                componentsMissing: 0,
+                componentsWithErrors: 0,
+                functionsFailing: 0,
+                functionsRunnerError: 1,
+                functionsNameMismatch: 0,
+                functionsMissing: 0,
+                missingFromGlossary: 0,
+            }, [
+                {
+                    entitySha: 'a',
+                    name: 'OldComponent',
+                    scenarioCount: 1,
+                    preExisting: true,
+                },
+            ])).toBe(false);
+        });
+        it('should return false when some incomplete entities are NOT pre-existing', () => {
+            expect(isOnlyPreExistingIncomplete({
+                incompleteEntities: 2,
+                preExistingIncompleteEntities: 1,
+                componentsMissing: 0,
+                componentsWithErrors: 0,
+                functionsFailing: 0,
+                functionsNameMismatch: 0,
+                functionsMissing: 0,
+                missingFromGlossary: 0,
+                miscategorizedScenarios: 0,
+                scenariosNeedingRecapture: 0,
+            }, [
+                {
+                    entitySha: 'a',
+                    name: 'RuleBuilder',
+                    scenarioCount: 5,
+                    preExisting: true,
+                },
+                {
+                    entitySha: 'b',
+                    name: 'NewComponent',
+                    scenarioCount: 1,
+                    preExisting: false,
+                },
+            ])).toBe(false);
+        });
+        it('should return false when there are other failures besides incomplete entities', () => {
+            expect(isOnlyPreExistingIncomplete({
+                incompleteEntities: 2,
+                preExistingIncompleteEntities: 2,
+                componentsMissing: 1,
+            }, [
+                {
+                    entitySha: 'a',
+                    name: 'RuleBuilder',
+                    scenarioCount: 5,
+                    preExisting: true,
+                },
+                {
+                    entitySha: 'b',
+                    name: 'ArticleTableRow',
+                    scenarioCount: 2,
+                    preExisting: true,
+                },
+            ])).toBe(false);
+        });
+        it('should return false when incomplete entities array is empty', () => {
+            expect(isOnlyPreExistingIncomplete({ incompleteEntities: 0 }, [])).toBe(false);
+        });
+        it('should return false when incomplete entities array is missing', () => {
+            expect(isOnlyPreExistingIncomplete({ incompleteEntities: 2, preExistingIncompleteEntities: 2 }, undefined)).toBe(false);
+        });
+    });
+    describe('isOnlyIncompleteEntities with unassociatedScenarios', () => {
+        it('should return true when only unassociatedScenarios present', () => {
+            expect(isOnlyIncompleteEntities({ unassociatedScenarios: 5 })).toBe(true);
+        });
+        it('should return false when unassociatedScenarios present with other failures', () => {
+            expect(isOnlyIncompleteEntities({
+                unassociatedScenarios: 5,
+                functionsMissing: 1,
+            })).toBe(false);
+        });
+    });
+    // ── aggregateClientErrorsByComponent ─────────────────────────────────
+    describe('aggregateClientErrorsByComponent', () => {
+        it('should attribute errors to component using componentName from metadata', () => {
+            const result = aggregateClientErrorsByComponent({
+                'scenario-1': {
+                    scenarioName: 'DrinkCard - Default',
+                    errors: ['TypeError: Cannot read property "price"'],
+                },
+            }, [
+                {
+                    name: 'DrinkCard - Default',
+                    componentName: 'DrinkCard',
+                },
+            ]);
+            expect(result['DrinkCard']).toEqual([
+                'TypeError: Cannot read property "price"',
+            ]);
+        });
+        it('should attribute app-level scenario errors using pageFilePath', () => {
+            // App-level scenarios have componentName=null. The old approach
+            // parsed the scenario name "Full Page with Library" and got
+            // "Full Page with Library" as the component — which matches nothing.
+            // With metadata, we derive the entity name from pageFilePath.
+            const result = aggregateClientErrorsByComponent({
+                'scenario-1': {
+                    scenarioName: 'Full Page with Library',
+                    errors: ['TypeError: Cannot read property "title"'],
+                },
+            }, [
+                {
+                    name: 'Full Page with Library',
+                    componentName: null,
+                    pageFilePath: 'app/library/page.tsx',
+                },
+            ]);
+            // Should be keyed by the canonical entity name from scenarioEntityName()
+            expect(result['Library']).toEqual([
+                'TypeError: Cannot read property "title"',
+            ]);
+        });
+        it('should fall back to scenario name parsing when no metadata match exists', () => {
+            // If the scenario is not in the metadata list (e.g., metadata not yet loaded),
+            // fall back to the "ComponentName - Variant" convention
+            const result = aggregateClientErrorsByComponent({
+                'scenario-1': {
+                    scenarioName: 'Header - Dark Mode',
+                    errors: ['ReferenceError: theme is not defined'],
+                },
+            }, []);
+            expect(result['Header']).toEqual([
+                'ReferenceError: theme is not defined',
+            ]);
+        });
+        it('should handle non-route file paths via scenarioEntityName', () => {
+            // Non-route files (src/...) are treated as app entry points by
+            // scenarioEntityName → buildRoutePattern returns '/' → 'Home'.
+            // When a url is available, it provides a better entity name.
+            const result = aggregateClientErrorsByComponent({
+                'scenario-1': {
+                    scenarioName: 'LibraryApp - Rich',
+                    errors: ['Error: fetch failed'],
+                },
+            }, [
+                {
+                    name: 'LibraryApp - Rich',
+                    componentName: null,
+                    pageFilePath: 'src/library/LibraryApp.tsx',
+                    url: '/library',
+                },
+            ]);
+            // scenarioEntityName uses url fallback when pageFilePath is a non-route file
+            // pageFilePath 'src/...' → buildRoutePattern → '/' → routeDisplayName → 'Home'
+            // But componentName takes priority, and with url '/library' as final fallback
+            // scenarioEntityName({ pageFilePath: 'src/library/LibraryApp.tsx' }) → 'Home'
+            // because pageFilePath is checked before url
+            expect(result['Home']).toEqual(['Error: fetch failed']);
+        });
+        it('should skip scenarios with no errors', () => {
+            const result = aggregateClientErrorsByComponent({
+                'scenario-1': {
+                    scenarioName: 'DrinkCard - Default',
+                    errors: [],
+                },
+            }, [
+                {
+                    name: 'DrinkCard - Default',
+                    componentName: 'DrinkCard',
+                },
+            ]);
+            expect(result).toEqual({});
+        });
+        it('should aggregate errors from multiple scenarios for same component', () => {
+            const result = aggregateClientErrorsByComponent({
+                'scenario-1': {
+                    scenarioName: 'DrinkCard - Default',
+                    errors: ['Error A'],
+                },
+                'scenario-2': {
+                    scenarioName: 'DrinkCard - Hover',
+                    errors: ['Error B', 'Error C'],
+                },
+            }, [
+                { name: 'DrinkCard - Default', componentName: 'DrinkCard' },
+                { name: 'DrinkCard - Hover', componentName: 'DrinkCard' },
+            ]);
+            expect(result['DrinkCard']).toEqual(['Error A', 'Error B', 'Error C']);
+        });
+        it('should use capitalized display name for page file paths, not lowercase directory', () => {
+            // aggregateClientErrorsByComponent must produce keys matching scenarioEntityName().
+            // scenarioEntityName({ pageFilePath: 'app/library/page.tsx' }) returns 'Library',
+            // so the key must be 'Library' — not 'library' (the raw directory name).
+            // computeAudit checks clientErrors[glossaryEntryName], so a lowercase key
+            // will never match, silently dropping all client errors for page-level scenarios.
+            const result = aggregateClientErrorsByComponent({
+                'sc-1': {
+                    scenarioName: 'Library - Default',
+                    errors: ['TypeError: fetch failed'],
+                },
+            }, [
+                {
+                    name: 'Library - Default',
+                    componentName: null,
+                    pageFilePath: 'app/library/page.tsx',
+                },
+            ]);
+            expect(result).toHaveProperty('Library');
+            expect(result['Library']).toEqual(['TypeError: fetch failed']);
+        });
+        it('should use "Home" for root page app/page.tsx, not "app"', () => {
+            // Root page: scenarioEntityName returns 'Home', not 'app'.
+            // Custom path parsing incorrectly pops the parent dir ('app').
+            const result = aggregateClientErrorsByComponent({
+                'sc-1': {
+                    scenarioName: 'Home - Default',
+                    errors: ['ReferenceError: window is not defined'],
+                },
+            }, [
+                {
+                    name: 'Home - Default',
+                    componentName: null,
+                    pageFilePath: 'app/page.tsx',
+                },
+            ]);
+            expect(result).toHaveProperty('Home');
+            expect(result['Home']).toEqual(['ReferenceError: window is not defined']);
         });
     });
 });