@codeyam/codeyam-cli 0.1.18 → 0.1.20

package/codeyam-cli/src/utils/__tests__/editorAudit.test.js

@@ -1,6 +1,6 @@
 import Database from 'better-sqlite3';
 import { Kysely, SqliteDialect } from 'kysely';
-import { isComponent, classifyGlossaryEntries, computeAudit, filterGlossaryByChangeStatus, resolveAuditSessionScope, queryScenarioCounts, queryPageScenarioCounts, queryIncompleteEntities, queryMiscategorizedScenarios, isOnlyIncompleteEntities, isAutoRemediable, identifyScenariosNeedingRecapture, detectDuplicateNames, } from "../editorAudit.js";
+import { isComponent, classifyGlossaryEntries, computeAudit, filterGlossaryByChangeStatus, resolveAuditSessionScope, queryScenarioCounts, queryPageScenarioCounts, queryIncompleteEntities, queryMiscategorizedScenarios, queryUnassociatedScenarios, isOnlyIncompleteEntities, isAutoRemediable, identifyScenariosNeedingRecapture, detectDuplicateNames, } from "../editorAudit.js";
 describe('editorAudit', () => {
     describe('isComponent', () => {
         it('should return true for JSX.Element return type', () => {
@@ -2676,5 +2676,277 @@ describe('editorAudit', () => {
             expect(result.summary.componentsMissing).toBe(1);
         });
     });
+    // ── queryUnassociatedScenarios ──────────────────────────────────────
+    describe('queryUnassociatedScenarios', () => {
+        let db;
+        let rawDb;
+        const projectId = 'test-project-id';
+        beforeEach(async () => {
+            rawDb = new Database(':memory:');
+            db = new Kysely({ dialect: new SqliteDialect({ database: rawDb }) });
+            await db.schema
+                .createTable('editor_scenarios')
+                .addColumn('id', 'varchar', (col) => col.primaryKey())
+                .addColumn('project_id', 'varchar', (col) => col.notNull())
+                .addColumn('name', 'varchar', (col) => col.notNull())
+                .addColumn('component_name', 'varchar')
+                .addColumn('component_path', 'varchar')
+                .addColumn('entity_sha', 'varchar')
+                .addColumn('display_name', 'varchar')
+                .addColumn('page_file_path', 'varchar')
+                .addColumn('url', 'varchar')
+                .addColumn('type', 'varchar')
+                .addColumn('created_at', 'datetime')
+                .addColumn('updated_at', 'datetime')
+                .execute();
+        });
+        afterEach(async () => {
+            await db.destroy();
+        });
+        it('should return empty when all scenarios have entity_sha', async () => {
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'Header - Default',
+                component_name: 'Header',
+                component_path: 'src/components/Header.tsx',
+                entity_sha: 'sha-header',
+                created_at: '2026-03-16 23:00:00',
+                updated_at: '2026-03-16 23:00:00',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, null);
+            expect(result).toEqual([]);
+        });
+        it('should find component scenarios with NULL entity_sha', async () => {
+            // This reproduces the Margo testapp bug: subagent registered scenarios
+            // but entity records didn't exist yet, so entity_sha was never set
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'SearchBar - Default',
+                component_name: 'SearchBar',
+                component_path: 'src/components/SearchBar.tsx',
+                entity_sha: null,
+                created_at: '2026-03-20 18:45:00',
+                updated_at: '2026-03-20 18:45:00',
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-2',
+                project_id: projectId,
+                name: 'SearchBar - With Results',
+                component_name: 'SearchBar',
+                component_path: 'src/components/SearchBar.tsx',
+                entity_sha: null,
+                created_at: '2026-03-20 18:45:05',
+                updated_at: '2026-03-20 18:45:05',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, null);
+            expect(result).toHaveLength(1);
+            expect(result[0].name).toBe('SearchBar');
+            expect(result[0].filePath).toBe('src/components/SearchBar.tsx');
+            expect(result[0].scenarioCount).toBe(2);
+            expect(result[0].scenarioNames).toEqual(expect.arrayContaining([
+                'SearchBar - Default',
+                'SearchBar - With Results',
+            ]));
+        });
+        it('should find page scenarios with NULL entity_sha', async () => {
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'Full Page — Rich Library',
+                component_name: null,
+                component_path: null,
+                page_file_path: 'src/library/LibraryApp.tsx',
+                entity_sha: null,
+                created_at: '2026-03-20 18:50:00',
+                updated_at: '2026-03-20 18:50:00',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, null);
+            expect(result).toHaveLength(1);
+            expect(result[0].name).toBe('LibraryApp');
+            expect(result[0].filePath).toBe('src/library/LibraryApp.tsx');
+            expect(result[0].scenarioCount).toBe(1);
+        });
+        it('should ignore scenarios without any file path (orphans without component_path or page_file_path)', async () => {
+            // Scenarios with no file path at all can't be associated — they're not
+            // actionable, so don't report them as unassociated
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'Some Orphan',
+                component_name: null,
+                component_path: null,
+                page_file_path: null,
+                entity_sha: null,
+                created_at: '2026-03-20 18:50:00',
+                updated_at: '2026-03-20 18:50:00',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, null);
+            expect(result).toEqual([]);
+        });
+        it('should group multiple components separately', async () => {
+            // Two different components both missing entity_sha
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'FullPageHeader - Default',
+                component_name: 'FullPageHeader',
+                component_path: 'src/components/FullPageHeader.tsx',
+                entity_sha: null,
+                created_at: '2026-03-20 18:45:00',
+                updated_at: '2026-03-20 18:45:00',
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-2',
+                project_id: projectId,
+                name: 'SaveConfirmation - Visible',
+                component_name: 'SaveConfirmation',
+                component_path: 'src/components/SaveConfirmation.tsx',
+                entity_sha: null,
+                created_at: '2026-03-20 19:00:00',
+                updated_at: '2026-03-20 19:00:00',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, null);
+            expect(result).toHaveLength(2);
+            const names = result.map((r) => r.name).sort();
+            expect(names).toEqual(['FullPageHeader', 'SaveConfirmation']);
+        });
+        it('should only include scenarios from the specified project', async () => {
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: 'other-project',
+                name: 'SearchBar - Default',
+                component_name: 'SearchBar',
+                component_path: 'src/components/SearchBar.tsx',
+                entity_sha: null,
+                created_at: '2026-03-20 18:45:00',
+                updated_at: '2026-03-20 18:45:00',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, null);
+            expect(result).toEqual([]);
+        });
+        it('should scope to feature session when featureStartedAt is provided', async () => {
+            // Pre-existing unassociated scenario (before session)
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-old',
+                project_id: projectId,
+                name: 'OldComponent - Default',
+                component_name: 'OldComponent',
+                component_path: 'src/components/OldComponent.tsx',
+                entity_sha: null,
+                created_at: '2026-03-19 10:00:00',
+                updated_at: '2026-03-19 10:00:00',
+            })
+                .execute();
+            // New unassociated scenario (during session)
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-new',
+                project_id: projectId,
+                name: 'NewComponent - Default',
+                component_name: 'NewComponent',
+                component_path: 'src/components/NewComponent.tsx',
+                entity_sha: null,
+                created_at: '2026-03-20 18:45:00',
+                updated_at: '2026-03-20 18:45:00',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, '2026-03-20T18:00:00.000Z');
+            // Should only find the session-scoped one
+            expect(result).toHaveLength(1);
+            expect(result[0].name).toBe('NewComponent');
+        });
+        it('should include re-registered scenarios (updated_at in session) even if created before', async () => {
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'SearchBar - Default',
+                component_name: 'SearchBar',
+                component_path: 'src/components/SearchBar.tsx',
+                entity_sha: null,
+                created_at: '2026-03-19 10:00:00',
+                updated_at: '2026-03-20 18:45:00', // re-registered during session
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, '2026-03-20T18:00:00.000Z');
+            expect(result).toHaveLength(1);
+            expect(result[0].name).toBe('SearchBar');
+        });
+        it('should not include scenarios with entity_sha set (even if stale)', async () => {
+            // This scenario has an entity_sha — even if it's stale, that's a
+            // different problem (handled by queryIncompleteEntities)
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'Header - Default',
+                component_name: 'Header',
+                component_path: 'src/components/Header.tsx',
+                entity_sha: 'sha-old-version',
+                created_at: '2026-03-20 18:45:00',
+                updated_at: '2026-03-20 18:45:00',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, null);
+            expect(result).toEqual([]);
+        });
+    });
+    // ── isAutoRemediable with unassociatedScenarios ────────────────────
+    describe('isAutoRemediable with unassociatedScenarios', () => {
+        it('should return true when unassociatedScenarios is the only failure', () => {
+            expect(isAutoRemediable({ unassociatedScenarios: 3 }, false)).toBe(true);
+        });
+        it('should return true when both incompleteEntities and unassociatedScenarios are the only failures', () => {
+            expect(isAutoRemediable({ incompleteEntities: 1, unassociatedScenarios: 2 }, false)).toBe(true);
+        });
+        it('should return false when unassociatedScenarios exist alongside other failures', () => {
+            expect(isAutoRemediable({ unassociatedScenarios: 2, componentsMissing: 1 }, false)).toBe(false);
+        });
+        it('should return false when already attempted', () => {
+            expect(isAutoRemediable({ unassociatedScenarios: 3 }, true)).toBe(false);
+        });
+    });
+    describe('isOnlyIncompleteEntities with unassociatedScenarios', () => {
+        it('should return true when only unassociatedScenarios present', () => {
+            expect(isOnlyIncompleteEntities({ unassociatedScenarios: 5 })).toBe(true);
+        });
+        it('should return false when unassociatedScenarios present with other failures', () => {
+            expect(isOnlyIncompleteEntities({
+                unassociatedScenarios: 5,
+                functionsMissing: 1,
+            })).toBe(false);
+        });
+    });
 });
 //# sourceMappingURL=editorAudit.test.js.map