@codeyam/codeyam-cli 0.1.16 → 0.1.18

package/codeyam-cli/src/utils/__tests__/editorAudit.test.js

@@ -1873,7 +1873,12 @@ describe('editorAudit', () => {
                 .execute();
             const result = await queryIncompleteEntities(db, projectId, null);
             expect(result).toEqual([
-                { entitySha: 'sha-chips', name: 'CollectionChips', scenarioCount: 2 },
+                {
+                    entitySha: 'sha-chips',
+                    name: 'CollectionChips',
+                    scenarioCount: 2,
+                    preExisting: false,
+                },
             ]);
         });
         it('should only return entities without analyses, not those with analyses', async () => {
@@ -1930,10 +1935,15 @@ describe('editorAudit', () => {
                 .execute();
             const result = await queryIncompleteEntities(db, projectId, null);
             expect(result).toEqual([
-                { entitySha: 'sha-picker', name: 'CollectionPicker', scenarioCount: 1 },
+                {
+                    entitySha: 'sha-picker',
+                    name: 'CollectionPicker',
+                    scenarioCount: 1,
+                    preExisting: false,
+                },
             ]);
         });
-        it('should scope to session when featureStartedAt is provided', async () => {
+        it('should return both pre-session and in-session entities with preExisting flags', async () => {
             // Entity without analysis, scenario created BEFORE session
             await db
                 .insertInto('entities')
@@ -1977,12 +1987,24 @@ describe('editorAudit', () => {
             })
                 .execute();
             const result = await queryIncompleteEntities(db, projectId, '2026-03-16T23:07:12.698Z');
-            // Only NewComponent should be flagged (created in session)
-            expect(result).toEqual([
-                { entitySha: 'sha-new', name: 'NewComponent', scenarioCount: 1 },
-            ]);
+            // Both should be returned — OldComponent is preExisting, NewComponent is not
+            expect(result).toEqual(expect.arrayContaining([
+                {
+                    entitySha: 'sha-old',
+                    name: 'OldComponent',
+                    scenarioCount: 1,
+                    preExisting: true,
+                },
+                {
+                    entitySha: 'sha-new',
+                    name: 'NewComponent',
+                    scenarioCount: 1,
+                    preExisting: false,
+                },
+            ]));
+            expect(result).toHaveLength(2);
         });
-        it('should include scenarios updated in session even if created before', async () => {
+        it('should flag preExisting: false when scenario was updated in session even if created before', async () => {
             await db
                 .insertInto('entities')
                 .values({
@@ -2010,6 +2032,7 @@ describe('editorAudit', () => {
                     entitySha: 'sha-updated',
                     name: 'UpdatedComponent',
                     scenarioCount: 1,
+                    preExisting: false,
                 },
             ]);
         });
@@ -2077,6 +2100,60 @@ describe('editorAudit', () => {
             const result = await queryIncompleteEntities(db, projectId, null);
             expect(result).toEqual([]);
         });
+        it('should flag entity when sibling has analyses but different filePath (extracted component)', async () => {
+            // Old entity version WITH analysis at ORIGINAL file path
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-card-v1',
+                name: 'TaskCard',
+                entity_type: 'visual',
+                file_path: 'app/page.tsx',
+            })
+                .execute();
+            await db
+                .insertInto('analyses')
+                .values({
+                id: 'a-card-v1',
+                entity_sha: 'sha-card-v1',
+                entity_name: 'TaskCard',
+                project_id: projectId,
+            })
+                .execute();
+            // New entity version WITHOUT analysis at EXTRACTED file path
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-card-v2',
+                name: 'TaskCard',
+                entity_type: 'visual',
+                file_path: 'app/components/TaskCard.tsx',
+            })
+                .execute();
+            // Scenario points to the new version (synced by syncScenarioEntityShas)
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-card',
+                project_id: projectId,
+                name: 'TaskCard - Default',
+                component_name: 'TaskCard',
+                entity_sha: 'sha-card-v2',
+                created_at: '2026-03-16 23:00:00',
+            })
+                .execute();
+            // SHOULD flag as incomplete — sibling has analyses but at a different filePath,
+            // so getAllEntities() won't inherit (it matches by name+filePath)
+            const result = await queryIncompleteEntities(db, projectId, null);
+            expect(result).toEqual([
+                {
+                    entitySha: 'sha-card-v2',
+                    name: 'TaskCard',
+                    scenarioCount: 1,
+                    preExisting: false,
+                },
+            ]);
+        });
         it('should still flag entities when no sibling version has analyses', async () => {
             // Only one version, no analyses
             await db
@@ -2106,6 +2183,7 @@ describe('editorAudit', () => {
                     entitySha: 'sha-icon',
                     name: 'ExternalLinkIcon',
                     scenarioCount: 1,
+                    preExisting: false,
                 },
             ]);
         });
@@ -2124,7 +2202,124 @@ describe('editorAudit', () => {
                 .execute();
             const result = await queryIncompleteEntities(db, projectId, null);
             expect(result).toEqual([
-                { entitySha: 'sha-ghost', name: 'GhostComponent', scenarioCount: 1 },
+                {
+                    entitySha: 'sha-ghost',
+                    name: 'GhostComponent',
+                    scenarioCount: 1,
+                    preExisting: false,
+                },
+            ]);
+        });
+        it('should detect incomplete entity whose scenario predates the session', async () => {
+            // Entity with no analyses, scenario created BEFORE session
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-preexisting',
+                name: 'PreExistingComponent',
+                entity_type: 'visual',
+                file_path: 'src/PreExistingComponent.tsx',
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-preexisting',
+                project_id: projectId,
+                name: 'PreExistingComponent - Default',
+                component_name: 'PreExistingComponent',
+                entity_sha: 'sha-preexisting',
+                created_at: '2026-03-16 20:00:00',
+                updated_at: '2026-03-16 20:00:00',
+            })
+                .execute();
+            // Session started well after scenario was created/updated
+            const result = await queryIncompleteEntities(db, projectId, '2026-03-16T23:07:12.698Z');
+            // Should still be detected — the old time filter would have excluded it
+            expect(result).toEqual([
+                {
+                    entitySha: 'sha-preexisting',
+                    name: 'PreExistingComponent',
+                    scenarioCount: 1,
+                    preExisting: true,
+                },
+            ]);
+        });
+        it('should flag preExisting: true when all scenarios predate the session', async () => {
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-old-entity',
+                name: 'OldEntity',
+                entity_type: 'visual',
+                file_path: 'src/OldEntity.tsx',
+            })
+                .execute();
+            // Two scenarios, both before session
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-old-1',
+                project_id: projectId,
+                name: 'OldEntity - Default',
+                component_name: 'OldEntity',
+                entity_sha: 'sha-old-entity',
+                created_at: '2026-03-16 19:00:00',
+                updated_at: '2026-03-16 19:00:00',
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-old-2',
+                project_id: projectId,
+                name: 'OldEntity - Hover',
+                component_name: 'OldEntity',
+                entity_sha: 'sha-old-entity',
+                created_at: '2026-03-16 19:30:00',
+                updated_at: '2026-03-16 19:30:00',
+            })
+                .execute();
+            const result = await queryIncompleteEntities(db, projectId, '2026-03-16T23:07:12.698Z');
+            expect(result).toEqual([
+                {
+                    entitySha: 'sha-old-entity',
+                    name: 'OldEntity',
+                    scenarioCount: 2,
+                    preExisting: true,
+                },
+            ]);
+        });
+        it('should flag preExisting: false when scenario is from the current session', async () => {
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-session-entity',
+                name: 'SessionEntity',
+                entity_type: 'visual',
+                file_path: 'src/SessionEntity.tsx',
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-session',
+                project_id: projectId,
+                name: 'SessionEntity - Default',
+                component_name: 'SessionEntity',
+                entity_sha: 'sha-session-entity',
+                created_at: '2026-03-16 23:30:00',
+                updated_at: '2026-03-16 23:30:00',
+            })
+                .execute();
+            const result = await queryIncompleteEntities(db, projectId, '2026-03-16T23:07:12.698Z');
+            expect(result).toEqual([
+                {
+                    entitySha: 'sha-session-entity',
+                    name: 'SessionEntity',
+                    scenarioCount: 1,
+                    preExisting: false,
+                },
             ]);
         });
     });
@@ -2375,5 +2570,111 @@ describe('editorAudit', () => {
             expect(result.size).toBe(0);
         });
     });
+    // ── computeAudit: impacted components with stale scenarios ──────────
+    describe('computeAudit — impacted components with stale scenarios', () => {
+        it('should mark impacted component as needs_recapture when it has total scenarios but none in session', () => {
+            // Library page has 3 scenarios from Feature 1 (totalScenarioCounts),
+            // 0 in the current session (scenarioCounts), and is "impacted" in entityChangeStatus.
+            // It should NOT be marked "missing" — it needs recapture, not new scenarios.
+            const result = computeAudit({
+                components: [
+                    {
+                        name: 'Library',
+                        filePath: 'app/library/page.tsx',
+                        returnType: 'JSX.Element',
+                    },
+                    {
+                        name: 'ArticleTable',
+                        filePath: 'app/components/ArticleTable.tsx',
+                        returnType: 'JSX.Element',
+                    },
+                ],
+                functions: [],
+                scenarioCounts: { ArticleTable: 2 },
+                testFileExistence: {},
+                totalScenarioCounts: { Library: 3 },
+                entityChangeStatus: {
+                    Library: { status: 'impacted' },
+                    ArticleTable: { status: 'edited' },
+                },
+            });
+            // Library: impacted + has total scenarios but 0 in session → needs_recapture
+            expect(result.components[0].status).toBe('needs_recapture');
+            expect(result.components[0].scenarioCount).toBe(3);
+            // ArticleTable: edited + has session scenarios → ok
+            expect(result.components[1].status).toBe('ok');
+            // needs_recapture should NOT count as missing
+            expect(result.summary.componentsMissing).toBe(0);
+            expect(result.summary.componentsNeedingRecapture).toBe(1);
+            // should NOT fail the audit (scenariosNeedingRecapture handles it)
+            expect(result.summary.allPassing).toBe(true);
+        });
+        it('should still mark component as missing when impacted but has zero total scenarios', () => {
+            // New page added to glossary but never had scenarios — truly missing
+            const result = computeAudit({
+                components: [
+                    {
+                        name: 'NewPage',
+                        filePath: 'app/new/page.tsx',
+                        returnType: 'JSX.Element',
+                    },
+                ],
+                functions: [],
+                scenarioCounts: {},
+                testFileExistence: {},
+                totalScenarioCounts: {},
+                entityChangeStatus: {
+                    NewPage: { status: 'impacted' },
+                },
+            });
+            expect(result.components[0].status).toBe('missing');
+            expect(result.summary.componentsMissing).toBe(1);
+        });
+        it('should use needs_recapture for edited entities with existing scenarios from prior sessions', () => {
+            // Edited entities that already have scenarios from prior sessions
+            // need recapture, not re-registration. The code changed, but the
+            // scenarios exist — they just need fresh screenshots.
+            const result = computeAudit({
+                components: [
+                    {
+                        name: 'EditedComp',
+                        filePath: 'app/components/Edited.tsx',
+                        returnType: 'JSX.Element',
+                    },
+                ],
+                functions: [],
+                scenarioCounts: {},
+                testFileExistence: {},
+                totalScenarioCounts: { EditedComp: 2 },
+                entityChangeStatus: {
+                    EditedComp: { status: 'edited' },
+                },
+            });
+            expect(result.components[0].status).toBe('needs_recapture');
+            expect(result.summary.componentsMissing).toBe(0);
+            expect(result.summary.componentsNeedingRecapture).toBe(1);
+        });
+        it('should still mark as missing when new entity has zero total scenarios', () => {
+            // Truly new component with no scenarios ever — needs scenarios created
+            const result = computeAudit({
+                components: [
+                    {
+                        name: 'BrandNew',
+                        filePath: 'app/components/BrandNew.tsx',
+                        returnType: 'JSX.Element',
+                    },
+                ],
+                functions: [],
+                scenarioCounts: {},
+                testFileExistence: {},
+                totalScenarioCounts: {},
+                entityChangeStatus: {
+                    BrandNew: { status: 'new' },
+                },
+            });
+            expect(result.components[0].status).toBe('missing');
+            expect(result.summary.componentsMissing).toBe(1);
+        });
+    });
 });
 //# sourceMappingURL=editorAudit.test.js.map