@codeyam/codeyam-cli 0.1.0-staging.dbc742d → 0.1.0-staging.df25827

package/codeyam-cli/src/utils/__tests__/entityChangeStatus.test.js

@@ -1,5 +1,5 @@
-import { buildReverseDependencyGraph, classifyDirectChanges, computeEntityChangeStatus, buildChangedFilesMap, pageNameFromUrl, scenarioEntityName, buildEntityInfosFromScenarios, buildEntityInfosFromGlossary, filterGroupsByChangeStatus, filterGlossaryByChangeStatus, filterScenarioScreenshotsByChangeStatus, } from "../entityChangeStatus.js";
-import { scanPageFilePaths, detectFirstFeature, readFeatureStartedAt, } from "../entityChangeStatus.server.js";
+import { buildReverseDependencyGraph, classifyDirectChanges, computeEntityChangeStatus, buildChangedFilesMap, pageNameFromUrl, isIsolationUrl, scenarioEntityName, buildEntityInfosFromScenarios, buildEntityInfosFromGlossary, filterGroupsByChangeStatus, filterGlossaryByChangeStatus, filterScenarioScreenshotsByChangeStatus, } from "../entityChangeStatus.js";
+import { scanPageFilePaths, detectFirstFeature, readFeatureStartedAt, readEditorStep, readEditorSessionId, readSavedActiveScenarioId, } from "../entityChangeStatus.server.js";
 import * as fsModule from 'fs';
 import * as pathModule from 'path';
 import * as os from 'os';
@@ -137,6 +137,11 @@ describe('entityChangeStatus', () => {
             expect(pageNameFromUrl('/drinks/[id]')).toBe('Drinks');
             expect(pageNameFromUrl('/users/[userId]/posts')).toBe('Users');
         });
+        it('should strip file extensions from URL segments', () => {
+            expect(pageNameFromUrl('/library.html')).toBe('Library');
+            expect(pageNameFromUrl('/about.htm')).toBe('About');
+            expect(pageNameFromUrl('/library.html?article=a1')).toBe('Library');
+        });
     });
     // ── buildEntityInfosFromScenarios ─────────────────────────────────────
     describe('buildEntityInfosFromScenarios', () => {
@@ -1049,6 +1054,34 @@ describe('entityChangeStatus', () => {
             expect(result).toHaveLength(1);
             expect(result[0].importedBy).toBeDefined();
         });
+        it('should use displayName for non-app/ pageFilePath instead of collapsing to Home', () => {
+            // Margo bug: Chrome extension has two entry points:
+            //   "/" → src/popup/App.tsx (Home)
+            //   "/library.html" → src/library/FullPageLibrary.tsx (Library)
+            // Without displayName, buildRoutePattern('src/library/FullPageLibrary.tsx')
+            // returns '/' since it doesn't start with 'app/', collapsing both to "Home".
+            const scenarios = [
+                {
+                    componentName: null,
+                    componentPath: null,
+                    url: '/',
+                    pageFilePath: 'src/popup/App.tsx',
+                    displayName: 'Home',
+                },
+                {
+                    componentName: null,
+                    componentPath: null,
+                    url: '/library.html',
+                    pageFilePath: 'src/library/FullPageLibrary.tsx',
+                    displayName: 'Library',
+                },
+            ];
+            const result = buildEntityInfosFromScenarios(scenarios, {}, []);
+            expect(result).toHaveLength(2);
+            expect(result.map((e) => e.name).sort()).toEqual(['Home', 'Library']);
+            expect(result.find((e) => e.name === 'Home')?.filePath).toBe('src/popup/App.tsx');
+            expect(result.find((e) => e.name === 'Library')?.filePath).toBe('src/library/FullPageLibrary.tsx');
+        });
     });
     // ── Full pipeline regression tests ───────────────────────────────
     describe('full pipeline regression tests', () => {
@@ -1596,7 +1629,7 @@ describe('entityChangeStatus', () => {
             });
             fsModule.writeFileSync(pathModule.join(appDir, 'settings', 'profile', 'page.tsx'), '');
             const result = scanPageFilePaths(tempDir);
-            expect(result).toEqual({
+            expect(result.map).toEqual({
                 Home: 'app/page.tsx',
                 Drinks: 'app/drinks/page.tsx',
                 Settings: 'app/settings/profile/page.tsx',
@@ -1607,7 +1640,7 @@ describe('entityChangeStatus', () => {
             fsModule.mkdirSync(appDir, { recursive: true });
             fsModule.writeFileSync(pathModule.join(appDir, 'page.js'), '');
             const result = scanPageFilePaths(tempDir);
-            expect(result).toEqual({ Home: 'app/page.js' });
+            expect(result.map).toEqual({ Home: 'app/page.js' });
         });
         it('should skip isolated-components directories', () => {
             const appDir = pathModule.join(tempDir, 'app');
@@ -1616,11 +1649,11 @@ describe('entityChangeStatus', () => {
             });
             fsModule.writeFileSync(pathModule.join(appDir, 'isolated-components', 'test', 'page.tsx'), '');
             const result = scanPageFilePaths(tempDir);
-            expect(result).toEqual({});
+            expect(result.map).toEqual({});
         });
         it('should return empty map when app/ does not exist', () => {
             const result = scanPageFilePaths(tempDir);
-            expect(result).toEqual({});
+            expect(result.map).toEqual({});
         });
         // ── Expo Router support ──────────────────────────────────────────────
         it('should find index.tsx as Home page (Expo Router)', () => {
@@ -1628,7 +1661,7 @@ describe('entityChangeStatus', () => {
             fsModule.mkdirSync(appDir, { recursive: true });
             fsModule.writeFileSync(pathModule.join(appDir, 'index.tsx'), '');
             const result = scanPageFilePaths(tempDir);
-            expect(result).toEqual({ Home: 'app/index.tsx' });
+            expect(result.map).toEqual({ Home: 'app/index.tsx' });
         });
         it('should find named route files as pages (Expo Router)', () => {
             const appDir = pathModule.join(tempDir, 'app');
@@ -1638,7 +1671,7 @@ describe('entityChangeStatus', () => {
             fsModule.mkdirSync(pathModule.join(appDir, 'tea'), { recursive: true });
             fsModule.writeFileSync(pathModule.join(appDir, 'tea', '[id].tsx'), '');
             const result = scanPageFilePaths(tempDir);
-            expect(result).toEqual({
+            expect(result.map).toEqual({
                 Home: 'app/index.tsx',
                 'Add-tea': 'app/add-tea.tsx',
                 Tea: 'app/tea/[id].tsx',
@@ -1650,7 +1683,7 @@ describe('entityChangeStatus', () => {
             fsModule.writeFileSync(pathModule.join(appDir, '_layout.tsx'), '');
             fsModule.writeFileSync(pathModule.join(appDir, 'index.tsx'), '');
             const result = scanPageFilePaths(tempDir);
-            expect(result).toEqual({ Home: 'app/index.tsx' });
+            expect(result.map).toEqual({ Home: 'app/index.tsx' });
         });
         it('should handle route groups like (tabs) transparently (Expo Router)', () => {
             const appDir = pathModule.join(tempDir, 'app');
@@ -1660,7 +1693,7 @@ describe('entityChangeStatus', () => {
             fsModule.writeFileSync(pathModule.join(tabsDir, 'index.tsx'), '');
             fsModule.writeFileSync(pathModule.join(tabsDir, 'settings.tsx'), '');
             const result = scanPageFilePaths(tempDir);
-            expect(result).toEqual({
+            expect(result.map).toEqual({
                 Home: 'app/(tabs)/index.tsx',
                 Settings: 'app/(tabs)/settings.tsx',
             });
@@ -1671,7 +1704,32 @@ describe('entityChangeStatus', () => {
             fsModule.writeFileSync(pathModule.join(appDir, 'page.tsx'), '');
             fsModule.writeFileSync(pathModule.join(appDir, 'index.tsx'), '');
             const result = scanPageFilePaths(tempDir);
-            expect(result).toEqual({ Home: 'app/page.tsx' });
+            expect(result.map).toEqual({ Home: 'app/page.tsx' });
+        });
+        it('should include all page files in allFiles when multiple routes share a page name', () => {
+            const appDir = pathModule.join(tempDir, 'app');
+            fsModule.mkdirSync(appDir, { recursive: true });
+            fsModule.writeFileSync(pathModule.join(appDir, 'page.tsx'), '');
+            fsModule.mkdirSync(pathModule.join(appDir, 'feedback', '[id]', 'edit'), {
+                recursive: true,
+            });
+            fsModule.mkdirSync(pathModule.join(appDir, 'feedback', 'new'), {
+                recursive: true,
+            });
+            fsModule.writeFileSync(pathModule.join(appDir, 'feedback', '[id]', 'page.tsx'), '');
+            fsModule.writeFileSync(pathModule.join(appDir, 'feedback', '[id]', 'edit', 'page.tsx'), '');
+            fsModule.writeFileSync(pathModule.join(appDir, 'feedback', 'new', 'page.tsx'), '');
+            const result = scanPageFilePaths(tempDir);
+            // Map picks one canonical file per page name
+            expect(result.map['Home']).toBe('app/page.tsx');
+            expect(result.map['Feedback']).toBeDefined();
+            // allFiles includes ALL page files, even those that collided on page name
+            expect(result.allFiles.sort()).toEqual([
+                'app/feedback/[id]/edit/page.tsx',
+                'app/feedback/[id]/page.tsx',
+                'app/feedback/new/page.tsx',
+                'app/page.tsx',
+            ]);
         });
     });
     // ── detectFirstFeature ─────────────────────────────────────────────────
@@ -1738,5 +1796,326 @@ describe('entityChangeStatus', () => {
             expect(readFeatureStartedAt(tempDir)).toBeNull();
         });
     });
+    // ── readEditorStep ──────────────────────────────────────────────────────
+    describe('readEditorStep', () => {
+        let tempDir;
+        beforeEach(() => {
+            tempDir = fsModule.mkdtempSync(pathModule.join(os.tmpdir(), 'editorstep-test-'));
+            fsModule.mkdirSync(pathModule.join(tempDir, '.codeyam'), {
+                recursive: true,
+            });
+        });
+        afterEach(() => {
+            fsModule.rmSync(tempDir, { recursive: true, force: true });
+        });
+        it('should return step and label from editor-step.json', () => {
+            fsModule.writeFileSync(pathModule.join(tempDir, '.codeyam', 'editor-step.json'), JSON.stringify({ step: 3, label: 'Confirm', feature: 'Add login' }));
+            expect(readEditorStep(tempDir)).toEqual({ step: 3, label: 'Confirm' });
+        });
+        it('should return null when file does not exist', () => {
+            expect(readEditorStep(tempDir)).toBeNull();
+        });
+        it('should return null when step field is missing', () => {
+            fsModule.writeFileSync(pathModule.join(tempDir, '.codeyam', 'editor-step.json'), JSON.stringify({ feature: 'Add login' }));
+            expect(readEditorStep(tempDir)).toBeNull();
+        });
+        it('should return null for invalid JSON', () => {
+            fsModule.writeFileSync(pathModule.join(tempDir, '.codeyam', 'editor-step.json'), 'not json');
+            expect(readEditorStep(tempDir)).toBeNull();
+        });
+    });
+    // ── readEditorSessionId ─────────────────────────────────────────────────
+    describe('readEditorSessionId', () => {
+        let tempDir;
+        beforeEach(() => {
+            tempDir = fsModule.mkdtempSync(pathModule.join(os.tmpdir(), 'sessionid-test-'));
+            fsModule.mkdirSync(pathModule.join(tempDir, '.codeyam'), {
+                recursive: true,
+            });
+        });
+        afterEach(() => {
+            fsModule.rmSync(tempDir, { recursive: true, force: true });
+        });
+        it('should return session ID from claude-session-id.txt', () => {
+            const uuid = '550e8400-e29b-41d4-a716-446655440000';
+            fsModule.writeFileSync(pathModule.join(tempDir, '.codeyam', 'claude-session-id.txt'), uuid);
+            expect(readEditorSessionId(tempDir)).toBe(uuid);
+        });
+        it('should trim whitespace from session ID', () => {
+            fsModule.writeFileSync(pathModule.join(tempDir, '.codeyam', 'claude-session-id.txt'), '  abc-123  \n');
+            expect(readEditorSessionId(tempDir)).toBe('abc-123');
+        });
+        it('should return null when file does not exist', () => {
+            expect(readEditorSessionId(tempDir)).toBeNull();
+        });
+        it('should return null when file is empty', () => {
+            fsModule.writeFileSync(pathModule.join(tempDir, '.codeyam', 'claude-session-id.txt'), '');
+            expect(readEditorSessionId(tempDir)).toBeNull();
+        });
+    });
+    describe('isIsolationUrl', () => {
+        it('should return true for /isolated-components/ URLs', () => {
+            expect(isIsolationUrl('/isolated-components/Foo')).toBe(true);
+            expect(isIsolationUrl('/isolated-components/Foo?s=Default')).toBe(true);
+        });
+        it('should return true for /codeyam-isolate/ URLs', () => {
+            expect(isIsolationUrl('/codeyam-isolate/Foo')).toBe(true);
+            expect(isIsolationUrl('/codeyam-isolate/Foo?s=Default')).toBe(true);
+        });
+        it('should return false for regular page URLs', () => {
+            expect(isIsolationUrl('/library')).toBe(false);
+            expect(isIsolationUrl('/drinks/1')).toBe(false);
+            expect(isIsolationUrl('/')).toBe(false);
+        });
+        it('should return false for null/undefined', () => {
+            expect(isIsolationUrl(null)).toBe(false);
+            expect(isIsolationUrl(undefined)).toBe(false);
+        });
+    });
+    // ── buildReverseDependencyGraph: filePath-based importer resolution ────
+    describe('buildReverseDependencyGraph — filePath-based resolution', () => {
+        it('should resolve importer via filePath when DB name differs from display name', () => {
+            // In Margo Reader: ArticleTable's importedBy lists "LibraryPage" as importer name
+            // under filePath "app/library/page.tsx". But the entity list has name "Library"
+            // with filePath "app/library/page.tsx". The reverse graph should map
+            // ArticleTable → {"Library"} (not "LibraryPage").
+            const entities = [
+                {
+                    name: 'ArticleTable',
+                    filePath: 'app/components/ArticleTable.tsx',
+                    importedBy: {
+                        'app/library/page.tsx': {
+                            LibraryPage: { shas: ['sha1'] },
+                        },
+                    },
+                },
+                {
+                    name: 'Library',
+                    filePath: 'app/library/page.tsx',
+                },
+            ];
+            const graph = buildReverseDependencyGraph(entities);
+            expect(graph.get('ArticleTable')).toEqual(new Set(['Library']));
+        });
+        it('should fall back to DB importer name when filePath has no matching entity', () => {
+            // When the importer filePath doesn't match any entity in the list,
+            // fall back to the DB's importer name.
+            const entities = [
+                {
+                    name: 'Button',
+                    filePath: 'components/Button.tsx',
+                    importedBy: {
+                        'components/UnknownPage.tsx': {
+                            SomeComponent: { shas: ['sha1'] },
+                        },
+                    },
+                },
+            ];
+            const graph = buildReverseDependencyGraph(entities);
+            expect(graph.get('Button')).toEqual(new Set(['SomeComponent']));
+        });
+        it('should resolve multiple importers via filePath correctly', () => {
+            const entities = [
+                {
+                    name: 'ArticleTableRow',
+                    filePath: 'app/components/ArticleTableRow.tsx',
+                    importedBy: {
+                        'app/components/ArticleTable.tsx': {
+                            ArticleTable: { shas: ['sha1'] },
+                        },
+                        'app/library/page.tsx': {
+                            LibraryPage: { shas: ['sha2'] },
+                        },
+                    },
+                },
+                {
+                    name: 'ArticleTable',
+                    filePath: 'app/components/ArticleTable.tsx',
+                },
+                {
+                    name: 'Library',
+                    filePath: 'app/library/page.tsx',
+                },
+            ];
+            const graph = buildReverseDependencyGraph(entities);
+            expect(graph.get('ArticleTableRow')).toEqual(new Set(['ArticleTable', 'Library']));
+        });
+    });
+    // ── buildEntityInfosFromScenarios: filePath-based metadata matching ────
+    describe('buildEntityInfosFromScenarios — filePath-based metadata matching', () => {
+        it('should attach importedBy metadata when entity names differ but filePaths match', () => {
+            // Page scenario with displayName "Library" but DB entity named "LibraryPage"
+            // with filePath "app/library/page.tsx". The metadata lookup should match by
+            // filePath and attach importedBy.
+            const scenarios = [
+                {
+                    componentName: null,
+                    componentPath: null,
+                    pageFilePath: 'app/library/page.tsx',
+                    url: '/library',
+                    displayName: 'Library',
+                },
+            ];
+            const entitiesWithMetadata = [
+                {
+                    name: 'LibraryPage',
+                    filePath: 'app/library/page.tsx',
+                    metadata: {
+                        importedBy: {
+                            'app/layout.tsx': {
+                                RootLayout: { shas: ['sha1'] },
+                            },
+                        },
+                    },
+                },
+            ];
+            const result = buildEntityInfosFromScenarios(scenarios, {}, entitiesWithMetadata);
+            expect(result).toHaveLength(1);
+            expect(result[0].name).toBe('Library');
+            expect(result[0].importedBy).toEqual({
+                'app/layout.tsx': {
+                    RootLayout: { shas: ['sha1'] },
+                },
+            });
+        });
+        it('should prefer name match over filePath match in multi-entity files', () => {
+            // Bug: app/components/ArticleTable.tsx exports both Props (rowid 33) and
+            // ArticleTable (rowid 34). find() with OR condition matches Props first
+            // via filePath, so ArticleTable gets Props' importedBy (missing the
+            // critical ArticleTable → LibraryPage edge). Fix: try name match first.
+            const scenarios = [
+                {
+                    componentName: 'ArticleTable',
+                    componentPath: 'app/components/ArticleTable.tsx',
+                },
+            ];
+            const entitiesWithMetadata = [
+                {
+                    name: 'Props',
+                    filePath: 'app/components/ArticleTable.tsx',
+                    metadata: {
+                        importedBy: {
+                            'app/components/ArticleTable.tsx': {
+                                ArticleTable: { shas: ['sha-internal'] },
+                            },
+                        },
+                    },
+                },
+                {
+                    name: 'ArticleTable',
+                    filePath: 'app/components/ArticleTable.tsx',
+                    metadata: {
+                        importedBy: {
+                            'app/library/page.tsx': {
+                                LibraryPage: { shas: ['sha1'] },
+                            },
+                        },
+                    },
+                },
+            ];
+            const result = buildEntityInfosFromScenarios(scenarios, {}, entitiesWithMetadata);
+            expect(result).toHaveLength(1);
+            expect(result[0].name).toBe('ArticleTable');
+            // Must get ArticleTable's importedBy (LibraryPage), NOT Props' importedBy
+            expect(result[0].importedBy).toEqual({
+                'app/library/page.tsx': {
+                    LibraryPage: { shas: ['sha1'] },
+                },
+            });
+        });
+        it('should still match by name when names are identical', () => {
+            const scenarios = [
+                {
+                    componentName: 'ArticleTable',
+                    componentPath: 'app/components/ArticleTable.tsx',
+                },
+            ];
+            const entitiesWithMetadata = [
+                {
+                    name: 'ArticleTable',
+                    filePath: 'app/components/ArticleTable.tsx',
+                    metadata: {
+                        importedBy: {
+                            'app/library/page.tsx': {
+                                LibraryPage: { shas: ['sha1'] },
+                            },
+                        },
+                    },
+                },
+            ];
+            const result = buildEntityInfosFromScenarios(scenarios, {}, entitiesWithMetadata);
+            expect(result[0].importedBy).toBeDefined();
+        });
+    });
+    // ── End-to-end: filePath resolution enables impact propagation ────
+    describe('end-to-end: filePath resolution enables page impact detection', () => {
+        it('should detect Library page as impacted when ArticleTable is edited', () => {
+            // This is the Margo Reader bug: ArticleTable is edited, Library page
+            // should be detected as impacted because ArticleTable's importedBy
+            // metadata shows it's imported by "app/library/page.tsx" → "Library".
+            const changedFiles = new Map([
+                ['app/components/ArticleTable.tsx', 'edited'],
+            ]);
+            const entities = [
+                {
+                    name: 'ArticleTable',
+                    filePath: 'app/components/ArticleTable.tsx',
+                    importedBy: {
+                        'app/library/page.tsx': {
+                            LibraryPage: { shas: ['sha1'] },
+                        },
+                    },
+                },
+                {
+                    name: 'Library',
+                    filePath: 'app/library/page.tsx',
+                },
+            ];
+            const result = computeEntityChangeStatus(changedFiles, entities);
+            expect(result['ArticleTable']).toEqual({ status: 'edited' });
+            expect(result['Library']).toEqual({
+                status: 'impacted',
+                impactedBy: [
+                    {
+                        name: 'ArticleTable',
+                        filePath: 'app/components/ArticleTable.tsx',
+                        changeType: 'edited',
+                    },
+                ],
+            });
+        });
+    });
+    // ── readSavedActiveScenarioId ─────────────────────────────────────────
+    describe('readSavedActiveScenarioId', () => {
+        let tempDir;
+        beforeEach(() => {
+            tempDir = fsModule.mkdtempSync(pathModule.join(os.tmpdir(), 'activescenario-test-'));
+            fsModule.mkdirSync(pathModule.join(tempDir, '.codeyam'), {
+                recursive: true,
+            });
+        });
+        afterEach(() => {
+            fsModule.rmSync(tempDir, { recursive: true, force: true });
+        });
+        it('should return scenarioId from valid active-scenario.json', () => {
+            fsModule.writeFileSync(pathModule.join(tempDir, '.codeyam', 'active-scenario.json'), JSON.stringify({
+                scenarioSlug: 'my-scenario',
+                scenarioId: 'abc-123',
+                type: 'application',
+            }));
+            expect(readSavedActiveScenarioId(tempDir)).toBe('abc-123');
+        });
+        it('should return null when file does not exist', () => {
+            expect(readSavedActiveScenarioId(tempDir)).toBeNull();
+        });
+        it('should return null when scenarioId field is missing', () => {
+            fsModule.writeFileSync(pathModule.join(tempDir, '.codeyam', 'active-scenario.json'), JSON.stringify({ scenarioSlug: 'my-scenario', type: 'application' }));
+            expect(readSavedActiveScenarioId(tempDir)).toBeNull();
+        });
+        it('should return null for malformed JSON', () => {
+            fsModule.writeFileSync(pathModule.join(tempDir, '.codeyam', 'active-scenario.json'), 'not json{{');
+            expect(readSavedActiveScenarioId(tempDir)).toBeNull();
+        });
+    });
 });
 //# sourceMappingURL=entityChangeStatus.test.js.map