@codeyam/codeyam-cli 0.1.0-staging.da5baf5 → 0.1.0-staging.e38f7bd

package/packages/ai/src/lib/dataStructure/ScopeDataStructure.js

@@ -138,6 +138,7 @@ const ALLOWED_EQUIVALENCY_REASONS = new Set([
     'Array.from() equivalency',
     'propagated sub-property equivalency',
     'propagated function call return sub-property equivalency',
+    'propagated parent-variable equivalency', // Added: propagate child scope equivalencies to parent scope when variable is defined in parent
     'where was this function called from', // Added: tracks which scope called an external function
 ]);
 const SILENTLY_IGNORED_EQUIVALENCY_REASONS = new Set([
@@ -583,6 +584,31 @@ export class ScopeDataStructure {
                 return;
             }
         }
+        // Skip self-referential equivalencies that would create infinite loops.
+        // Case 1: Direct self-reference (path === equivalentPath)
+        // FunctionCallManager adds equivalency(subPath, subPath, externalFunctionName, ...)
+        // For simple calls like buildBranchFileMap(), this is fine.
+        // But for chained calls like query.where().where().where(), each method call adds
+        // a .functionCallReturnValue segment, and the equivalency processing creates an infinite loop.
+        // We detect chained calls by counting .functionCallReturnValue occurrences in the path.
+        if (path === equivalentPath &&
+            equivalencyReason === 'equivalency to external function call') {
+            // Count how many .functionCallReturnValue segments are in the path
+            const functionCallReturnValueCount = (path.match(/\.functionCallReturnValue/g) || []).length;
+            // Skip if there are multiple chained calls (2+ .functionCallReturnValue segments)
+            if (functionCallReturnValueCount >= 2) {
+                return;
+            }
+        }
+        // Case 2: Circular reference where equivalentPath contains path as a prefix
+        // e.g., path="query" and equivalentPath="query.where(...).functionCallReturnValue"
+        // This happens with method chaining patterns where a variable is reassigned to
+        // the result of a method call on itself: query = query.where(...)
+        // Resolving this equivalency would require resolving query first, creating infinite recursion.
+        if (equivalentPath.startsWith(path + '.') ||
+            equivalentPath.startsWith(path + '(')) {
+            return;
+        }
         if (!equivalentScopeName) {
             console.warn('Debug Propagation: missing equivalent scope name', {
                 path,
@@ -720,6 +746,15 @@ export class ScopeDataStructure {
                     ...existingFunctionCall.equivalencies,
                     ...functionCallInfo.equivalencies,
                 };
+                // Track all call signatures that get merged (e.g., logger.info, logger.debug, etc.)
+                if (!existingFunctionCall.allCallSignatures) {
+                    existingFunctionCall.allCallSignatures = [
+                        existingFunctionCall.callSignature,
+                    ];
+                }
+                if (!existingFunctionCall.allCallSignatures.includes(functionCallInfo.callSignature)) {
+                    existingFunctionCall.allCallSignatures.push(functionCallInfo.callSignature);
+                }
             }
             else {
                 const functionCallInfoNameParts = this.splitPath(functionCallInfo.name);
@@ -837,6 +872,22 @@ export class ScopeDataStructure {
     joinPathParts(pathParts) {
         return this.pathManager.joinPathParts(pathParts);
     }
+    /**
+     * Extracts the root variable name from a path.
+     * E.g., "collected[]" -> "collected", "foo.bar" -> "foo", "collected[0]" -> "collected"
+     */
+    extractRootVariable(path) {
+        const parts = this.splitPath(path);
+        if (parts.length === 0)
+            return null;
+        const firstPart = parts[0];
+        // Strip array notation: "collected[]" -> "collected", "collected[0]" -> "collected"
+        const bracketIndex = firstPart.indexOf('[');
+        if (bracketIndex > 0) {
+            return firstPart.substring(0, bracketIndex);
+        }
+        return firstPart;
+    }
     // PRIVATE METHODS //
     uniqueId(params) {
         return uniqueId(params);
@@ -891,6 +942,21 @@ export class ScopeDataStructure {
     }
     determineEquivalenciesAndBuildSchema(scopeNode) {
         const { isolatedStructure, isolatedEquivalentVariables } = scopeNode.analysis;
+        // DEBUG: Log all equivalencies related to useFetcher
+        if (Object.keys(isolatedEquivalentVariables || {}).some((k) => k.includes('Fetcher') || k.includes('fetcher'))) {
+            console.log('CodeYam DEBUG determineEquivalenciesAndBuildSchema:', JSON.stringify({
+                scopeNodeName: scopeNode.name,
+                fetcherEquivalencies: Object.entries(isolatedEquivalentVariables || {})
+                    .filter(([k, v]) => k.includes('Fetcher') ||
+                    k.includes('fetcher') ||
+                    String(v).includes('Fetcher') ||
+                    String(v).includes('fetcher'))
+                    .reduce((acc, [k, v]) => {
+                    acc[k] = v;
+                    return acc;
+                }, {}),
+            }, null, 2));
+        }
         const allPaths = Array.from(new Set([
             ...Object.keys(isolatedStructure || {}),
             ...Object.keys(isolatedEquivalentVariables || {}),
@@ -902,6 +968,36 @@ export class ScopeDataStructure {
                 path = cleanPath(path.replace(/::cyDuplicateKey\d+::/g, ''), allPaths);
                 equivalentValue = cleanPath(equivalentValue.replace(/::cyDuplicateKey\d+::/g, ''), allPaths);
                 this.addEquivalency(path, equivalentValue, scopeNode.name, scopeNode, 'original equivalency');
+                // Propagate equivalencies involving parent-scope variables to those parent scopes.
+                // This handles patterns like: collected.push({...entity}) where 'collected' is defined
+                // in a parent scope. The equivalency collected[] -> push().signature[0] needs to be
+                // visible when tracing from the parent scope.
+                const rootVariable = this.extractRootVariable(path);
+                const equivalentRootVariable = this.extractRootVariable(equivalentValue);
+                // Skip propagation for self-referential reassignment patterns like:
+                //   x = x.method().functionCallReturnValue
+                // where the path IS the variable itself (not a sub-path like x[] or x.prop).
+                // These create circular references since both sides reference the same variable.
+                //
+                // But DO propagate for patterns like collected[] -> collected.push(...).signature[0]
+                // where the path has additional segments beyond the root variable.
+                const pathIsJustRootVariable = path === rootVariable;
+                const isSelfReferentialReassignment = pathIsJustRootVariable && rootVariable === equivalentRootVariable;
+                if (rootVariable &&
+                    !isSelfReferentialReassignment &&
+                    scopeNode.parentInstantiatedVariables?.includes(rootVariable)) {
+                    // Find the parent scope where this variable is defined
+                    for (const parentScopeName of scopeNode.tree || []) {
+                        const parentScope = this.scopeNodes[parentScopeName];
+                        if (parentScope?.instantiatedVariables?.includes(rootVariable)) {
+                            // Add the equivalency to the parent scope as well
+                            this.addEquivalency(path, equivalentValue, scopeNode.name, // The equivalent path's scope remains the child scope
+                            parentScope, // But store it in the parent scope's equivalencies
+                            'propagated parent-variable equivalency');
+                            break;
+                        }
+                    }
+                }
                 // Propagate sub-property equivalencies when the equivalentValue is a simple variable
                 // that has sub-properties defined in the isolatedEquivalentVariables.
                 // This handles cases like: dataItem={{ structure: completeDataStructure }}
@@ -947,6 +1043,14 @@ export class ScopeDataStructure {
                 // from the callback scope to the usage path
                 if (equivalentValue.endsWith('.functionCallReturnValue')) {
                     this.propagateFunctionCallReturnSubProperties(path, equivalentValue, scopeNode, allPaths);
+                    // Track which variable receives the return value of each function call
+                    // This enables generating separate mock data for each call site
+                    this.trackReceivingVariable(path, equivalentValue);
+                }
+                // Also track variables that receive destructured properties from function call return values
+                // e.g., "userData" -> "db.query('users').functionCallReturnValue.data"
+                if (equivalentValue.includes('.functionCallReturnValue.')) {
+                    this.trackReceivingVariable(path, equivalentValue);
                 }
             }
         }
@@ -1004,6 +1108,67 @@ export class ScopeDataStructure {
             });
         }
     }
+    /**
+     * Tracks which variable receives the return value of a function call.
+     *
+     * When we encounter an equivalency like:
+     *   result1 -> db.select(query1).functionCallReturnValue
+     *
+     * This method extracts the call signature (db.select(query1)) and maps it
+     * to the receiving variable (result1) on the corresponding FunctionCallInfo.
+     *
+     * This enables generating separate mock data for each call site when the same
+     * function is called multiple times with different arguments.
+     */
+    trackReceivingVariable(receivingVariable, equivalentValue) {
+        // Extract the call signature by finding the .functionCallReturnValue part
+        // and taking everything before it
+        // Handles both:
+        //   "db.select(query1).functionCallReturnValue" -> "db.select(query1)"
+        //   "db.query('users').functionCallReturnValue.data" -> "db.query('users')"
+        const funcReturnIdx = equivalentValue.indexOf('.functionCallReturnValue');
+        if (funcReturnIdx === -1) {
+            return;
+        }
+        const callSignature = equivalentValue.substring(0, funcReturnIdx);
+        // Skip if the receiving variable is not a simple identifier
+        // (e.g., skip if it's a path like "obj.property" or contains array access)
+        if (receivingVariable.includes('.') || receivingVariable.includes('[')) {
+            return;
+        }
+        // Find the FunctionCallInfo that matches this call signature
+        const searchKey = getFunctionCallRoot(callSignature);
+        const functionCallInfo = this.getExternalFunctionCallsIndex().get(searchKey);
+        // DEBUG: Track useFetcher calls
+        if (searchKey === 'useFetcher' || callSignature.includes('useFetcher')) {
+            console.log('CodeYam DEBUG trackReceivingVariable:', JSON.stringify({
+                receivingVariable,
+                equivalentValue,
+                callSignature,
+                searchKey,
+                foundFunctionCallInfo: !!functionCallInfo,
+                existingRecvVars: functionCallInfo?.receivingVariableNames,
+                existingCallSigToVar: functionCallInfo?.callSignatureToVariable,
+            }, null, 2));
+        }
+        if (!functionCallInfo) {
+            return;
+        }
+        // Initialize arrays if needed
+        if (!functionCallInfo.receivingVariableNames) {
+            functionCallInfo.receivingVariableNames = [];
+        }
+        if (!functionCallInfo.callSignatureToVariable) {
+            functionCallInfo.callSignatureToVariable = {};
+        }
+        // Add the receiving variable to the list (if not already present)
+        if (!functionCallInfo.receivingVariableNames.includes(receivingVariable)) {
+            functionCallInfo.receivingVariableNames.push(receivingVariable);
+        }
+        // Map the call signature to its receiving variable
+        // Use the full call signature (not the search key) for precise mapping
+        functionCallInfo.callSignatureToVariable[callSignature] = receivingVariable;
+    }
     /**
      * Propagates returnValue.* sub-properties from a callback scope to the usage path.
      *
@@ -1954,6 +2119,35 @@ export class ScopeDataStructure {
         }
         this.validateSchema(scopeNode, true, fillInUnknowns);
         const { schema } = scopeNode;
+        // For root scope, merge in external function call schemas
+        // This ensures that imported objects used as method call targets (like logger.error())
+        // appear in the schema as objects with function properties
+        if (scopeName === undefined ||
+            scopeName === this.scopeTreeManager.getRootName()) {
+            const mergedSchema = { ...schema };
+            for (const efc of this.externalFunctionCalls) {
+                // Add the base object name (e.g., "logger") as an object
+                const baseName = this.splitPath(efc.name)[0];
+                if (!mergedSchema[baseName]) {
+                    mergedSchema[baseName] = 'object';
+                }
+                // Get all call signatures (use allCallSignatures if available, otherwise just the single callSignature)
+                const signatures = efc.allCallSignatures ?? [efc.callSignature];
+                for (const signature of signatures) {
+                    // Add the method as a function (e.g., "logger.error")
+                    // Extract method name from callSignature like "logger.error(args...)"
+                    // Get everything before the first '(' to get "logger.error"
+                    const parenIndex = signature.indexOf('(');
+                    if (parenIndex > 0) {
+                        const methodPath = signature.substring(0, parenIndex);
+                        if (methodPath.includes('.') && !mergedSchema[methodPath]) {
+                            mergedSchema[methodPath] = 'function';
+                        }
+                    }
+                }
+            }
+            return mergedSchema;
+        }
         return schema;
     }
     getEquivalencies(scopeName) {
@@ -2283,6 +2477,9 @@ export class ScopeDataStructure {
                     return acc;
                 }, {})
                 : undefined,
+            allCallSignatures: efc.allCallSignatures,
+            receivingVariableNames: efc.receivingVariableNames,
+            callSignatureToVariable: efc.callSignatureToVariable,
         }));
         // Get root function result
         const rootFunction = getFunctionResult();