@codeyam/codeyam-cli 0.1.0-staging.da5baf5 → 0.1.0-staging.dd216e0

package/background/src/lib/virtualized/project/constructMockCode.js

@@ -1,4 +1,35 @@
-import { joinParenthesesAndArrays, splitOutsideParenthesesAndArrays, functionArguments, cleanOutBoundary, fillInDirectSchemaGapsAndUnknowns, } from "../../../../../packages/ai/index.js";
+import { joinParenthesesAndArrays, splitOutsideParenthesesAndArrays, functionArguments, cleanOutBoundary, fillInDirectSchemaGapsAndUnknowns, removeDuplicateFunctionCalls, } from "../../../../../packages/ai/index.js";
+/**
+ * Converts a variable qualifier to a safe identifier for use in function/const names.
+ * Handles indexed format like "data[1]" -> "data_1"
+ */
+function safeVariableQualifier(qualifier) {
+    // Replace brackets with underscores for valid JS identifier
+    // "data[1]" -> "data_1"
+    return qualifier.replace(/\[(\d+)\]/g, '_$1');
+}
+/**
+ * Extract property names that are jsx-components and should be preserved from original.
+ * These are paths like "MockName.Provider()" where the value or functionCallReturnValue is 'jsx-component'.
+ */
+function getJsxComponentProperties(mockName, schema) {
+    const jsxProperties = [];
+    for (const [path, value] of Object.entries(schema ?? {})) {
+        // Look for paths like "MockName.PropertyName()" that are jsx-components
+        // Skip paths that have deeper nesting (e.g., "MockName.Foo.Bar()")
+        const match = path.match(new RegExp(`^${mockName}\\.([^.()]+)\\(\\)$`));
+        if (!match)
+            continue;
+        const propertyName = match[1];
+        // Check if this is a jsx-component (either directly or via functionCallReturnValue)
+        const isJsxComponent = value === 'jsx-component' ||
+            schema[path + '.functionCallReturnValue'] === 'jsx-component';
+        if (isJsxComponent && !jsxProperties.includes(propertyName)) {
+            jsxProperties.push(propertyName);
+        }
+    }
+    return jsxProperties;
+}
 /**
  * Check if a string is a literal (quoted string or number).
  * Returns the unquoted value if it's a literal, null otherwise.
@@ -109,15 +140,54 @@ function isValidKey(key) {
     const keyWithOutArguments = key.split('(')[0];
     return !/\s/.test(keyWithOutArguments);
 }
-export default function constructMockCode(mockName, dependencySchemas) {
-    const mockNameParts = splitOutsideParenthesesAndArrays(mockName);
+export default function constructMockCode(mockName, dependencySchemas, entityType, options) {
+    // Check for variable-qualified mock name (e.g., "entityDiffFetcher <- useFetcher")
+    // Format: "variableName <- functionName" which reads naturally as "variableName receives from functionName"
+    // Also handles indexed format: "data[1] <- useFetch" for disambiguating reused variable names
+    const variableQualifierMatch = mockName.match(/^([a-zA-Z_][a-zA-Z0-9_]*(?:\[\d+\])?)\s*<-\s*/);
+    let variableQualifier = variableQualifierMatch
+        ? variableQualifierMatch[1]
+        : null;
+    const baseMockName = variableQualifier
+        ? mockName.slice(variableQualifierMatch[0].length)
+        : mockName;
+    const mockNameParts = splitOutsideParenthesesAndArrays(baseMockName);
     let relevantReturnValueSchema;
     let dataStructurePath;
     let dataStructureValue;
+    let foundEntityWithSignature = false;
+    let signatureSchema;
     for (const filePath in dependencySchemas) {
         for (const entityName in dependencySchemas[filePath]) {
-            if (entityName !== mockNameParts[0])
+            // For variable-qualified mocks, look for the full qualified name first
+            // Format: "variableName <- functionName" (e.g., "entityDiffFetcher <- useFetcher")
+            const targetEntityName = variableQualifier
+                ? `${variableQualifier} <- ${baseMockName}`
+                : mockNameParts[0];
+            // Check for direct match
+            let matches = entityName === targetEntityName || entityName === mockNameParts[0];
+            // If no direct match and no qualifier was provided, check if the entity
+            // is stored under a variable-qualified key (e.g., "stateBadge <- getStateBadge")
+            // This handles the case where gatherDataForMocks stored the entity with a variable
+            // qualifier but writeScenarioComponents called constructMockCode without one.
+            if (!matches && !variableQualifier) {
+                const qualifiedKeyMatch = entityName.match(new RegExp(`^([a-zA-Z_][a-zA-Z0-9_]*)\\s*<-\\s*${mockNameParts[0]}$`));
+                if (qualifiedKeyMatch) {
+                    matches = true;
+                    // Extract the variable qualifier from the entity name so we can use
+                    // it for the data lookup key later
+                    variableQualifier = qualifiedKeyMatch[1];
+                }
+            }
+            if (!matches)
                 continue;
+            // Track if we found the entity and it has a signature (is a function)
+            const entitySchema = dependencySchemas[filePath][entityName];
+            if (entitySchema?.signatureSchema &&
+                Object.keys(entitySchema.signatureSchema).length > 0) {
+                foundEntityWithSignature = true;
+                signatureSchema = entitySchema.signatureSchema;
+            }
             dataStructurePath = Object.keys(dependencySchemas[filePath][entityName]?.returnValueSchema ?? {}).find((path) => {
                 if (path === 'returnValue')
                     return true;
@@ -131,16 +201,61 @@ export default function constructMockCode(mockName, dependencySchemas) {
                 relevantReturnValueSchema = fillInDirectSchemaGapsAndUnknowns({
                     schema: dependencySchemas[filePath][entityName]?.returnValueSchema,
                 });
-                // NOTE: Temporarily disabled clearAttributesFromMapping as it deletes
+                // NOTE: clearAttributesFromMapping is disabled because it deletes
                 // method calls on arrays (like .eq() after functionCallReturnValue: 'array')
-                // clearAttributesFromMapping(relevantReturnValueSchema)
+                // However, we still need to remove duplicate function calls that create invalid syntax
+                removeDuplicateFunctionCalls(relevantReturnValueSchema);
                 dataStructureValue = relevantReturnValueSchema?.[dataStructurePath];
                 break;
             }
         }
     }
-    if (!relevantReturnValueSchema || !dataStructurePath)
+    // Check if the return value schema only contains function type markers
+    // (e.g., "validateInputs()": "function") without actual return data
+    // (no functionCallReturnValue entries)
+    const hasMeaningfulReturnData = (schema) => {
+        if (!schema)
+            return false;
+        const keys = Object.keys(schema);
+        // Check if there are any functionCallReturnValue entries
+        // which indicate actual mock data, not just type markers
+        return keys.some((key) => key.includes('functionCallReturnValue') || key === 'returnValue');
+    };
+    // If we found the entity with a signature but no return value schema,
+    // OR the schema only has function type markers without actual return data,
+    // generate an empty mock function. This handles validation functions like
+    // validateInputs that are marked for mocking but have no meaningful return value.
+    // EXCEPTION: If entityType is 'class', we still need to generate the class.
+    // EXCEPTION: If no signature was found, let the normal code path handle it.
+    if (!relevantReturnValueSchema || !dataStructurePath) {
+        if (foundEntityWithSignature && signatureSchema) {
+            // Count the number of arguments from signature schema
+            const argCount = Object.keys(signatureSchema).filter((key) => key.startsWith('signature[')).length;
+            const args = Array.from({ length: argCount }, (_, i) => `arg${i + 1}`);
+            const argsString = args.join(', ');
+            // Generate empty mock function
+            return `function ${mockName}(${argsString}) {
+  // Empty mock - original function mocked out
+}`;
+        }
         return;
+    }
+    // Check if the schema only has function type markers without actual return data.
+    // Only apply this when we have a signature (i.e., it's explicitly a function)
+    // and it's not a class. This handles validation functions that should be
+    // empty mocks rather than returning meaningless "function" strings.
+    if (foundEntityWithSignature &&
+        signatureSchema &&
+        entityType !== 'class' &&
+        !hasMeaningfulReturnData(relevantReturnValueSchema)) {
+        const argCount = Object.keys(signatureSchema).filter((key) => key.startsWith('signature[')).length;
+        const args = Array.from({ length: argCount }, (_, i) => `arg${i + 1}`);
+        const argsString = args.join(', ');
+        // Generate empty mock function
+        return `function ${mockName}(${argsString}) {
+  // Empty mock - original function mocked out
+}`;
+    }
     const dataStructureName = dataStructurePath === 'returnValue'
         ? mockName
         : joinParenthesesAndArrays(splitOutsideParenthesesAndArrays(dataStructurePath).slice(0, mockNameParts.length));
@@ -165,14 +280,24 @@ export default function constructMockCode(mockName, dependencySchemas) {
         if (root) {
             basePaths[0] = 'scenarios().data()';
         }
-        const optionalAccess = (name, stripArguments = false) => {
+        const optionalAccess = (name, stripArguments = false, isRootAccess = false) => {
             if (stripArguments && name.includes('(')) {
                 name = name.split('(')[0] + '()';
             }
             // Strip type parameters like <typeof loader> from function names
             // so "useLoaderData<typeof loader>()" becomes "useLoaderData()"
             name = cleanOutTypes(name);
-            if (name.match(/\[\d+\]/)) {
+            // For variable-qualified mocks at root level, use the "variableName <- functionName" format
+            // This matches the format generated by gatherDataForMocks and is more intuitive for LLMs
+            // e.g., "useFetcher()" becomes "entityDiffFetcher <- useFetcher"
+            if (isRootAccess && variableQualifier) {
+                // Remove trailing () from the function name to match gatherDataForMocks key format
+                const baseName = name.replace(/\(\)$/, '');
+                name = `${variableQualifier} <- ${baseName}`;
+            }
+            // Only use unquoted array access syntax for pure array indices like [0], [1]
+            // NOT for variable-qualified names like "fetcher[1] <- useFetcher" which need quotes
+            if (name.match(/^\[\d+\]$/) && !name.includes(' <- ')) {
                 return `?.${name}`;
             }
             return `?.["${name.replace(/\n/g, '\\n')}"]`;
@@ -204,7 +329,8 @@ export default function constructMockCode(mockName, dependencySchemas) {
             return basePaths
                 .flatMap((basePath) => {
                 if (!returnValue.args) {
-                    let dataPath = `${basePath}${optionalAccess(safeString(returnValue.name))}`;
+                    // Pass root as both stripArguments and isRootAccess for non-function paths
+                    let dataPath = `${basePath}${optionalAccess(safeString(returnValue.name), false, root)}`;
                     dataPath = addReturnValueFunctionAccessor(dataPath);
                     return dataPath;
                 }
@@ -212,7 +338,8 @@ export default function constructMockCode(mockName, dependencySchemas) {
                     const signature = returnValue.name.match(/\[\d*\]$/)
                         ? returnValue.name
                         : `${returnValue.name}(${argSet.join(', ')})`;
-                    let dataPath = `${basePath}${optionalAccess(safeString(signature), root)}`;
+                    // Pass root as both stripArguments and isRootAccess
+                    let dataPath = `${basePath}${optionalAccess(safeString(signature), root, root)}`;
                     dataPath = addReturnValueFunctionAccessor(dataPath);
                     return dataPath;
                 });
@@ -372,9 +499,17 @@ export default function constructMockCode(mockName, dependencySchemas) {
                     // When GENERIC array (using []) has nested content (like functions that need wrapping),
                     // use .map() to transform ALL elements instead of just creating [0]
                     // For DIFFERENTIATED arrays (using [0], [1], etc.), keep the static array structure
+                    //
+                    // IMPORTANT: If the nested content contains differentiated indices like [0], [1],
+                    // we MUST use static array pattern, not .map(). The presence of differentiated
+                    // indices means the array elements have different types/structures, so .map()
+                    // would generate invalid code trying to treat them uniformly.
+                    const hasDifferentiatedIndices = nested &&
+                        nested.some((n) => n.name.match(/^\[\d+\]$/) && n.name !== '[0]');
                     if (isGenericArray &&
                         nestedContent.length > 0 &&
-                        dataPaths.length > 0) {
+                        dataPaths.length > 0 &&
+                        !hasDifferentiatedIndices) {
                         // Get the array base path (without the [0])
                         const arrayBasePath = dataPaths[0].replace(/\?\.\[0\]$/, '');
                         // Replace [0] references with [__idx__] in level contents
@@ -404,6 +539,12 @@ export default function constructMockCode(mockName, dependencySchemas) {
             if (args && args.length > 0) {
                 if (!isValidKey(name))
                     return;
+                // Skip array index patterns like [], [0], [1] when they have args
+                // These represent function calls on array elements, not property keys
+                // e.g., customSizes[].(args) means each array element is callable, not a property named "[]"
+                if (name.match(/^\[\d*\]$/)) {
+                    return;
+                }
                 const mostArgs = args.sort((a, b) => b.length - a.length)[0];
                 const argsString = mostArgs
                     .map((_, index) => `arg${index + 1}`)
@@ -443,8 +584,19 @@ export default function constructMockCode(mockName, dependencySchemas) {
                         fallbackContent = `return ${returnValueContents}`;
                     }
                     else {
-                        // Use all paths as fallback for unknown arguments
-                        fallbackContent = `return ${returnValueContents}`;
+                        // No explicit fallback paths - return the first literal's value as default
+                        // Returning spread of all values is dangerous because if values are primitives (strings),
+                        // spreading them creates objects with numeric keys like {0:'a', 1:'b', ...}
+                        // which causes "Objects are not valid as React child" errors
+                        const firstLiteralValue = literalKeys[0];
+                        const firstGroupPaths = argGroups.get(firstLiteralValue);
+                        if (firstGroupPaths && firstGroupPaths.length === 1) {
+                            fallbackContent = `return ${firstGroupPaths[0]}`;
+                        }
+                        else {
+                            // Multiple paths for first literal - return undefined as safe fallback
+                            fallbackContent = `return undefined`;
+                        }
                     }
                     const funcContents = conditionalBranches.join('\n') +
                         '\n// Fallback for unmatched arguments\n' +
@@ -526,7 +678,9 @@ export default function constructMockCode(mockName, dependencySchemas) {
                 parts.splice(i, 1);
             }
         }
-        if (parts[0].split('(')[0] !== mockName)
+        // For variable-qualified mocks like "revalidator <- useRevalidator",
+        // compare against baseMockName ("useRevalidator"), not the full mockName
+        if (parts[0].split('(')[0] !== baseMockName)
             continue;
         // Include paths with functionCallReturnValue OR function-typed paths that need mocking
         const hasFunctionCallReturnValue = parts.some((p) => isFunctionCallReturnValue(p));
@@ -537,10 +691,49 @@ export default function constructMockCode(mockName, dependencySchemas) {
         // Exclude paths with functionCallReturnValue - those are handled by existing logic
         // Also check if there's a functionCallReturnValue path that extends this path
         const hasSignaturePath = parts.some((p) => p.startsWith('signature['));
+        // Skip signature paths entirely - they describe INPUT structure (function arguments),
+        // not OUTPUT (return values). This applies even if they contain functionCallReturnValue
+        // nested inside (e.g., methods on array elements passed as arguments).
+        if (hasSignaturePath)
+            continue;
         const hasExtendedFunctionCallReturnValue = Object.keys(relevantReturnValueSchema).some((k) => k.startsWith(key + '.') && k.includes(`.${RETURN_VALUE}`));
+        // Skip JSX components - they look like function calls (e.g., Context.Provider())
+        // but they're React components used in JSX, not functions that need mocking
+        // Check both the value type and whether the functionCallReturnValue is jsx-component
+        const isJsxComponent = value === 'jsx-component' ||
+            relevantReturnValueSchema[key + '.functionCallReturnValue'] ===
+                'jsx-component';
+        if (isJsxComponent)
+            continue;
+        // Skip paths that bypass .functionCallReturnValue when there's a corresponding path with it.
+        // Example: If we have both:
+        //   - trpc.customer.useQuery(...).data (incorrect - no .functionCallReturnValue)
+        //   - trpc.customer.useQuery(...).functionCallReturnValue.data (correct)
+        // We should skip the first path because the second one properly captures the return value.
+        // This can happen when the analyzer sees both the raw property access and the return value structure.
+        if (!hasFunctionCallReturnValue) {
+            // This path has no .functionCallReturnValue. Check if any function call in this path
+            // has a corresponding .functionCallReturnValue path in the schema.
+            let shouldSkipKey = false;
+            for (let i = 0; i < parts.length - 1; i++) {
+                const part = parts[i];
+                if (part.endsWith(')') && !isFunctionCallReturnValue(parts[i + 1])) {
+                    // This part is a function call, and the next part is NOT .functionCallReturnValue
+                    // Check if there's any path with .functionCallReturnValue for this function call
+                    const functionCallPath = joinParenthesesAndArrays(parts.slice(0, i + 1));
+                    const hasProperFunctionCallPath = Object.keys(relevantReturnValueSchema).some((k) => k.startsWith(functionCallPath + '.functionCallReturnValue'));
+                    if (hasProperFunctionCallPath) {
+                        // Skip this path - the .functionCallReturnValue path will handle it correctly
+                        shouldSkipKey = true;
+                        break;
+                    }
+                }
+            }
+            if (shouldSkipKey)
+                continue;
+        }
         const isFunctionPath = ['function', 'async-function'].includes(value) &&
             parts[parts.length - 1].endsWith(')') &&
-            !hasSignaturePath &&
             !hasAnyFunctionCallReturnValue &&
             !hasExtendedFunctionCallReturnValue;
         if (!hasFunctionCallReturnValue && !isFunctionPath)
@@ -692,6 +885,11 @@ export default function constructMockCode(mockName, dependencySchemas) {
                         if (['function', 'async-function'].includes(nextValue)) {
                             continue; // Continue to process the function property
                         }
+                        // If the next part is an object with nested content, continue processing
+                        // This handles paths like functionCallReturnValue.selectedOptions.elementOptions[]
+                        if (nextValue === 'object' || nextValue === 'array') {
+                            continue;
+                        }
                     }
                     break;
                 }
@@ -699,8 +897,29 @@ export default function constructMockCode(mockName, dependencySchemas) {
             else if (isKeyWord) {
                 continue;
             }
+            // Handle parts that end with [] (e.g., "elementOptions[]")
+            // These should be treated as the base part + array accessor
+            const endsWithArrayAccessor = part.endsWith('[]') && part !== '[]';
+            const basePart = endsWithArrayAccessor ? part.slice(0, -2) : part;
             const withoutArgs = (p) => p.name.split('(')[0];
-            let relevantPart = returnValueSection.nested?.find((p) => withoutArgs(p) === withoutArgs({ name: part }));
+            let relevantPart = returnValueSection.nested?.find((p) => withoutArgs(p) === withoutArgs({ name: basePart }));
+            // If part ends with [], update the existing part to be an array
+            if (endsWithArrayAccessor && relevantPart) {
+                relevantPart.isArray = true;
+                relevantPart.isGenericArray = true;
+                // Create structural [0] element for nested content
+                relevantPart.nested || (relevantPart.nested = []);
+                if (!relevantPart.nested.find((p) => p.name === '[0]')) {
+                    relevantPart.nested.push({
+                        name: '[0]',
+                        nested: [],
+                        isStructural: true,
+                    });
+                }
+                // Move to the [0] element for processing subsequent parts
+                returnValueSection = relevantPart.nested.find((p) => p.name === '[0]');
+                continue;
+            }
             if (!relevantPart) {
                 const hasArguments = part.includes('(') && part.endsWith(')');
                 if (part === '[]') {
@@ -721,6 +940,29 @@ export default function constructMockCode(mockName, dependencySchemas) {
                     }
                     continue;
                 }
+                // Handle parts that end with [] (e.g., "elementOptions[]") when base part doesn't exist
+                if (endsWithArrayAccessor) {
+                    // Create the base part with array properties
+                    relevantPart = {
+                        name: basePart,
+                        isArray: true,
+                        isGenericArray: true,
+                        nested: [],
+                    };
+                    returnValueSection.nested || (returnValueSection.nested = []);
+                    returnValueSection.nested.push(relevantPart);
+                    // Create structural [0] element for nested content
+                    if (partValue === 'object' && !isLastPart) {
+                        relevantPart.nested.push({
+                            name: '[0]',
+                            nested: [],
+                            isStructural: true,
+                        });
+                        // Move to the [0] element for processing subsequent parts
+                        returnValueSection = relevantPart.nested.find((p) => p.name === '[0]');
+                    }
+                    continue;
+                }
                 if (isLastPart &&
                     ['function', 'async-function'].includes(value) &&
                     !hasArguments) {
@@ -756,13 +998,25 @@ export default function constructMockCode(mockName, dependencySchemas) {
                     returnValueSection.nested.push(relevantPart);
                 }
             }
-            else if (funcArgs(part).join(',') !== funcArgs(relevantPart.name).join(',')) {
-                const existingArgs = relevantPart.args.find((args) => args.join(',') === funcArgs(part).join(','));
-                if (!existingArgs) {
-                    relevantPart.args || (relevantPart.args = []);
-                    relevantPart.args.push(funcArgs(part));
+            else {
+                // Add args to existing entry if current part has function arguments
+                // This handles the case where bare `t` is processed first (creating {name: 't', args: undefined})
+                // and then `t("common.close")` is processed - we need to add its args to the existing entry
+                const currentArgs = funcArgs(part);
+                const hasNewArgs = currentArgs.length > 0 || part.includes('(');
+                if (hasNewArgs) {
+                    const existingArgs = relevantPart.args?.find((args) => args.join(',') === currentArgs.join(','));
+                    if (!existingArgs) {
+                        relevantPart.args || (relevantPart.args = []);
+                        relevantPart.args.push(currentArgs);
+                    }
                 }
             }
+            // If nextPart is [], update existing part to be a generic array
+            if (relevantPart && nextPart === '[]') {
+                relevantPart.isArray = true;
+                relevantPart.isGenericArray = true;
+            }
             if (!hasNestedFunction) {
                 // Before breaking, check if this function returns an array
                 // by looking for a functionCallReturnValue: 'array' entry in the schema
@@ -831,10 +1085,101 @@ export default function constructMockCode(mockName, dependencySchemas) {
             // Insert before the closing brace (handle trailing whitespace)
             enhancedContents = contents.replace(/\}\s*$/, iteratorMethods + '\n}');
         }
-        return `const ${mockName}ReturnValue = ${enhancedContents};\n\n${isRootAsyncFunction ? 'async ' : ''}function ${mockName}() {\n${indent(`return ${mockName}ReturnValue;`)}\n}`;
+        // Classes need to be mocked as classes, not functions.
+        // They're used with `new ClassName(args)` which requires a proper constructor.
+        // A function mock like `function ClassName() { return value; }` doesn't work because
+        // `new ClassName("arg")` wouldn't create the expected instance.
+        // For Error subclasses (detected by name ending in "Error"), extend Error for proper error handling.
+        if (entityType === 'class') {
+            const isErrorSubclass = mockName.endsWith('Error');
+            const baseClass = isErrorSubclass ? 'Error' : 'Object';
+            const superCall = isErrorSubclass ? 'super(message);' : '';
+            const nameAssignment = isErrorSubclass
+                ? `this.name = '${mockName}';`
+                : '';
+            return `class ${mockName}${isErrorSubclass ? ' extends Error' : ''} {
+  constructor(message) {
+    ${superCall}
+    ${nameAssignment}
+    Object.assign(this, scenarios().data()?.["${mockName}()"] || {});
+  }
+}`;
+        }
+        // For variable-qualified mocks, use underscore separator in the function name
+        // e.g., "entityDiffFetcher <- useFetcher" becomes "useFetcher_entityDiffFetcher"
+        // For indexed qualifiers like "data[1]", convert to safe identifier: "useFetcher_data_1"
+        // EXCEPTION: When keepOriginalFunctionName is true (for single-call cases), use the base name
+        const safeFunctionName = variableQualifier && !options?.keepOriginalFunctionName
+            ? `${baseMockName}_${safeVariableQualifier(variableQualifier)}`
+            : baseMockName;
+        // Check if this function returns a function (detected by double-call pattern: mockName(args)())
+        // This happens when the schema has keys like "wrapThrows(() => JSON.parse(savedFilters))()"
+        // where the function call is immediately followed by another call.
+        // Example usage: const result = wrapThrows(() => JSON.parse(x))(); // double call
+        const isHigherOrderFunction = Object.keys(relevantReturnValueSchema ?? {}).some((key) => {
+            if (!key.startsWith(baseMockName))
+                return false;
+            // Find the first ( after baseMockName (the start of the function call)
+            const firstOpenParen = key.indexOf('(', baseMockName.length);
+            if (firstOpenParen === -1)
+                return false;
+            // Skip if the ( is not immediately after the mock name
+            // (there might be type params like func<T>() - handle by checking for < or ()
+            const between = key.slice(baseMockName.length, firstOpenParen);
+            if (between.length > 0 && !between.startsWith('<'))
+                return false;
+            // Find the matching ) for the first ( using depth counting
+            let depth = 1;
+            let i = firstOpenParen + 1;
+            while (i < key.length && depth > 0) {
+                if (key[i] === '(')
+                    depth++;
+                if (key[i] === ')')
+                    depth--;
+                i++;
+            }
+            if (depth !== 0)
+                return false; // Unbalanced parentheses
+            // Now i points just after the matching )
+            // Check if there's another ( immediately (indicating double call)
+            const remaining = key.slice(i);
+            if (remaining.startsWith('('))
+                return true;
+            return false;
+        });
+        // For higher-order functions, wrap the return in an arrow function
+        // so that mockFunc(arg)() works correctly (outer call returns a function, inner call gets the data)
+        const returnValue = isHigherOrderFunction
+            ? `() => ${safeFunctionName}ReturnValue`
+            : `${safeFunctionName}ReturnValue`;
+        return `const ${safeFunctionName}ReturnValue = ${enhancedContents};\n\n${isRootAsyncFunction ? 'async ' : ''}function ${safeFunctionName}() {\n${indent(`return ${returnValue};`)}\n}`;
     }
     else {
-        return `const ${mockName} = ${contents}`;
+        // For variable-qualified mocks, use underscore separator in the const name
+        // For indexed qualifiers like "data[1]", convert to safe identifier: "useFetcher_data_1"
+        // EXCEPTION: When keepOriginalFunctionName is true (for single-call cases), use the base name
+        const safeName = variableQualifier && !options?.keepOriginalFunctionName
+            ? `${baseMockName}_${safeVariableQualifier(variableQualifier)}`
+            : baseMockName;
+        // Get any jsx-component properties that need to be preserved from the original
+        const jsxProperties = getJsxComponentProperties(mockName, relevantReturnValueSchema);
+        // If there are jsx-component properties, add them as references to the original
+        if (jsxProperties.length > 0) {
+            const jsxPreservations = jsxProperties
+                .map((prop) => `${prop}: ${mockName}__cyOriginal.${prop}`)
+                .join(',\n');
+            if (contents.trim().startsWith('{')) {
+                // Contents is already an object - insert jsx preservations before the closing brace
+                const enhancedContents = contents.replace(/\}\s*$/, `,\n${indent(jsxPreservations)}\n}`);
+                return `const ${safeName} = ${enhancedContents}`;
+            }
+            else {
+                // Contents is a simple accessor (e.g., scenarios().data()?.["MockName"])
+                // Wrap it in an object with the jsx preservations
+                return `const ${safeName} = {\n${indent(`...${contents}`)},\n${indent(jsxPreservations)}\n}`;
+            }
+        }
+        return `const ${safeName} = ${contents}`;
     }
 }
 //# sourceMappingURL=constructMockCode.js.map