@codeyam/codeyam-cli 0.1.0-staging.d0ad4ae → 0.1.0-staging.d57a578

package/analyzer-template/packages/ai/src/lib/generateEntityKeyAttributes.ts

@@ -1,495 +0,0 @@
-import completionCall from './completionCall';
-import { saveLlmCall } from '~codeyam/aws/dynamodb';
-import { DataStructure, Entity, SourceLocation } from '~codeyam/types';
-import generateEntityKeyAttributesGenerator from './promptGenerators/generateEntityKeyAttributesGenerator';
-import { awsLog } from '~codeyam/utils';
-import { DEFAULT_LARGER_MODEL } from './aiConfig';
-import { gatherAttributesMap } from './promptGenerators/gatherAttributesMap';
-import { fillInDirectSchemaGapsAndUnknowns } from './dataStructure/helpers/fillInSchemaGapsAndUnknowns';
-import { clearAttributesFromMapping } from './dataStructure/helpers/cleanNonObjectFunctions';
-import isFrontend from './isFrontend';
-import { AI } from '~codeyam/ai';
-import { formatConditionalUsagesForPrompt } from './getConditionalUsagesFromCode';
-import type { CompoundConditional, ConditionalUsage } from '~codeyam/types';
-
-interface GenerateEntityKeyAttributesArgs {
-  entity: Pick<Entity, 'sha' | 'name' | 'filePath' | 'code' | 'metadata'>;
-  mergedDataStructure: Omit<DataStructure, 'equivalentSignatureVariables'>;
-  model?: AI.Model;
-}
-
-export default async function generateEntityKeyAttributes({
-  entity,
-  mergedDataStructure,
-  model,
-}: GenerateEntityKeyAttributesArgs) {
-  awsLog(`CodeYam: Generating entity key attributes`, {
-    filePath: entity.filePath,
-    entityName: entity.name,
-  });
-
-  const isolatedDataStructure = entity.metadata?.isolatedDataStructure;
-  const equivalentSignatureVariables =
-    isolatedDataStructure?.equivalentSignatureVariables ?? {};
-  const { attributesMap, associationMap, dataStructurePathMap } =
-    gatherAttributesMap(
-      isolatedDataStructure ?? mergedDataStructure,
-      mergedDataStructure,
-      equivalentSignatureVariables,
-      true,
-    );
-
-  // Clean the attributes map to remove primitive-returning array method paths
-  // like .includes().functionCallReturnValue, .indexOf().functionCallReturnValue, etc.
-  // These paths are not mockable and should not be presented as key attributes.
-  clearAttributesFromMapping(attributesMap);
-
-  if (Object.keys(attributesMap).length === 0) {
-    console.log(
-      `CodeYam Error: No valid attributes found for ${entity.filePath} ${entity.name}`,
-    );
-    return {
-      keyAttributes: [],
-      llmCall: null,
-    };
-  }
-
-  // Build merged schema for type inference (has more complete nested paths)
-  // Strip signature[N] prefix to match attributesMap format
-  const mergedSchemaForTypeLookup = Object.fromEntries(
-    Object.entries(mergedDataStructure.signatureSchema ?? {})
-      .filter(([k]) => k.startsWith('signature['))
-      .map(([k, v]) => [k.replace(/^signature\[\d+\]\./, ''), v]),
-  );
-
-  // Resolve unknown types using heuristics (e.g., "unknown | undefined" -> "string | undefined")
-  // Pass mergedSchema so checkIfObjectOrFunction can detect nested paths that prove a type is an object
-  const resolvedAttributesMap = fillInDirectSchemaGapsAndUnknowns({
-    scopeName: entity.name,
-    schema: { ...attributesMap },
-    mergedSchema: mergedSchemaForTypeLookup,
-  });
-
-  // Use pre-computed conditional usages from metadata, or compute on-the-fly as fallback
-  const conditionalUsages: Record<string, ConditionalUsage[]> =
-    entity.metadata?.isolatedDataStructure?.conditionalUsages ?? {};
-  const compoundConditionals: CompoundConditional[] =
-    entity.metadata?.isolatedDataStructure?.compoundConditionals ?? [];
-  const staticAnalysisContext = formatConditionalUsagesForPrompt(
-    conditionalUsages,
-    compoundConditionals,
-  );
-
-  const prompt = generateEntityKeyAttributesGenerator({
-    code: entity.code,
-    attributesMap: resolvedAttributesMap,
-    associationMap,
-    staticAnalysisContext,
-  });
-
-  console.log('Generated prompt for generateEntityKeyAttributes:');
-  console.log(prompt);
-
-  const response = await completionCall({
-    type: `generateEntityKeyAttributes`,
-    systemMessage: isFrontend(entity.filePath)
-      ? FRONTEND_SYSTEM_MESSAGE
-      : BACKEND_SYSTEM_MESSAGE,
-    prompt,
-    model: model ?? DEFAULT_LARGER_MODEL,
-  });
-
-  const llmCall = await saveLlmCall({
-    object_type: 'entity',
-    object_id: entity.sha,
-    propsJson: {
-      entity: {
-        name: entity.name,
-        filePath: entity.filePath,
-        code: entity.code,
-        metadata: {
-          isolatedDataStructure: entity.metadata.isolatedDataStructure,
-        },
-      },
-      model,
-    },
-    ...response.stats,
-  });
-
-  const { completion: keyAttributesString } = response;
-  if (!keyAttributesString) {
-    console.log(
-      `CodeYam Error: Error Generating entity key attributes failed: No response from AI`,
-    );
-    return null;
-  }
-
-  console.log(
-    `LLMCall ${llmCall ? llmCall.id : 'N/A'}: ${entity.filePath} ${entity.name} key attributes :>> `,
-  );
-  console.log(keyAttributesString);
-
-  let keyAttributes = undefined;
-  try {
-    const parsed = JSON.parse(keyAttributesString);
-    keyAttributes = parsed?.keyAttributes;
-  } catch (error) {
-    console.log(
-      `CodeYam Error: Invalid JSON response in generateEntityKeyAttributes for ${entity.filePath} ${entity.name}:`,
-      error,
-    );
-  }
-
-  if (!keyAttributes || !Array.isArray(keyAttributes)) {
-    return { keyAttributes: [], llmCall };
-  }
-
-  // Create reverse lookup: fullPath → internalPath
-  // associationMap is keyed by internalPath with value fullPath (when reverse=true)
-  const fullPathToInternalPath = Object.fromEntries(
-    Object.entries(associationMap).map(([internalPath, fullPath]) => [
-      fullPath,
-      internalPath,
-    ]),
-  );
-
-  // Helper to extract source locations from conditional usages for a given path
-  const getSourceLocationsForPath = (path: string): SourceLocation[] => {
-    const usages = conditionalUsages[path] || [];
-    const locations: SourceLocation[] = [];
-
-    for (const usage of usages.slice(0, 5)) {
-      // Limit to 5 locations
-      if (usage.sourceLocation) {
-        locations.push({
-          entityName: entity.name,
-          filePath: entity.filePath,
-          lineNumber: usage.sourceLocation.lineNumber,
-          column: usage.sourceLocation.column,
-          codeSnippet: usage.sourceLocation.codeSnippet,
-          usageType: 'conditional',
-          description: `Used in ${usage.location} statement (${usage.conditionType} check)`,
-        });
-      }
-    }
-
-    return locations;
-  };
-
-  // Helper to find source locations by matching sourceDataPath
-  // This handles cases where local variables (e.g., displayState.hasError) trace back
-  // to data structure paths (e.g., getScenarioDisplayState().functionCallReturnValue.hasError)
-  const getSourceLocationsBySourceDataPath = (
-    targetPath: string,
-  ): SourceLocation[] => {
-    const locations: SourceLocation[] = [];
-
-    // Search all conditional usages for ones whose sourceDataPath matches
-    for (const [, usages] of Object.entries(conditionalUsages)) {
-      for (const usage of usages) {
-        const sourceDataPath = (usage as { sourceDataPath?: string })
-          .sourceDataPath;
-        if (!sourceDataPath || !usage.sourceLocation) continue;
-
-        // Check if sourceDataPath ends with the target path
-        // e.g., "LibraryFunctionPreview.signature[0].isOutdated" ends with "isOutdated"
-        // or "getScenarioDisplayState.getScenarioDisplayState(...).functionCallReturnValue.hasError" ends with "hasError"
-        const normalizedSourcePath = sourceDataPath
-          .replace(/\.functionCallReturnValue/g, '')
-          .replace(/\([^)]*\)/g, '()');
-
-        if (
-          normalizedSourcePath.endsWith('.' + targetPath) ||
-          normalizedSourcePath.endsWith('.' + targetPath.replace(/\./g, '.'))
-        ) {
-          locations.push({
-            entityName: entity.name,
-            filePath: entity.filePath,
-            lineNumber: usage.sourceLocation.lineNumber,
-            column: usage.sourceLocation.column,
-            codeSnippet: usage.sourceLocation.codeSnippet,
-            usageType: 'conditional',
-            description: `Used in ${usage.location} statement (${usage.conditionType} check)`,
-          });
-        }
-      }
-    }
-
-    return locations.slice(0, 5); // Limit to 5
-  };
-
-  // Helper to find source locations from LLM-provided code snippets
-  const getSourceLocationsFromSnippets = (
-    codeSnippets: string[] | undefined,
-  ): SourceLocation[] => {
-    if (!codeSnippets || !Array.isArray(codeSnippets)) return [];
-
-    const locations: SourceLocation[] = [];
-    const codeLines = entity.code.split('\n');
-
-    for (const snippet of codeSnippets.slice(0, 3)) {
-      // Limit to 3 snippets
-      if (!snippet || typeof snippet !== 'string') continue;
-
-      // Normalize whitespace for matching
-      const normalizedSnippet = snippet.trim().replace(/\s+/g, ' ');
-
-      for (let i = 0; i < codeLines.length; i++) {
-        const normalizedLine = codeLines[i].replace(/\s+/g, ' ');
-        if (normalizedLine.includes(normalizedSnippet)) {
-          locations.push({
-            entityName: entity.name,
-            filePath: entity.filePath,
-            lineNumber: i + 1, // 1-based line numbers
-            codeSnippet: codeLines[i].trim(),
-            usageType: 'conditional',
-            description: `Key usage identified by analysis`,
-          });
-          break; // Only find first occurrence of each snippet
-        }
-      }
-    }
-
-    return locations;
-  };
-
-  const fullKeyAttributes = keyAttributes
-    .filter(Boolean)
-    .filter(
-      (keyAttribute, index, self) =>
-        keyAttribute?.fullPath &&
-        self.findIndex((ka) => ka?.fullPath === keyAttribute.fullPath) ===
-          index,
-    )
-    .filter((keyAttribute) => fullPathToInternalPath[keyAttribute.fullPath])
-    .map((keyAttribute) => {
-      const internalPath = fullPathToInternalPath[keyAttribute.fullPath];
-
-      // Get source locations from conditional usages
-      // Try multiple path formats since conditionalUsages might use different formats:
-      // - internalPath: the short path like "status"
-      // - fullPath: the LLM's path like "signature[0].status"
-      // - dataStructurePath: the external path like "useStatus().status"
-      // - Also try stripping signature[N] prefix since conditional usages use AST paths
-      let sourceLocations = getSourceLocationsForPath(internalPath);
-      if (sourceLocations.length === 0) {
-        sourceLocations = getSourceLocationsForPath(keyAttribute.fullPath);
-      }
-      if (sourceLocations.length === 0) {
-        const dataStructurePath =
-          dataStructurePathMap[internalPath] || keyAttribute.fullPath;
-        sourceLocations = getSourceLocationsForPath(dataStructurePath);
-      }
-      // Also try the path without signature[N] prefix since AST uses local variable names
-      if (sourceLocations.length === 0) {
-        const pathWithoutSignature = internalPath.replace(
-          /^signature\[\d+\]\./,
-          '',
-        );
-        if (pathWithoutSignature !== internalPath) {
-          sourceLocations = getSourceLocationsForPath(pathWithoutSignature);
-        }
-      }
-      // Finally, search by sourceDataPath which traces local variables back to data sources
-      // This handles cases like displayState.hasError → getScenarioDisplayState().hasError
-      if (sourceLocations.length === 0) {
-        sourceLocations = getSourceLocationsBySourceDataPath(internalPath);
-      }
-
-      // Last resort: use LLM-provided code snippets to find source locations
-      // This ensures every key attribute the LLM identifies has a source location
-      if (sourceLocations.length === 0 && keyAttribute.codeSnippets) {
-        sourceLocations = getSourceLocationsFromSnippets(
-          keyAttribute.codeSnippets,
-        );
-      }
-
-      return {
-        internalPath,
-        externalPath: associationMap[internalPath],
-        dataStructurePath:
-          dataStructurePathMap[internalPath] || keyAttribute.fullPath,
-        description: keyAttribute.description,
-        validValueOptions: keyAttribute.validValueOptions,
-        errorValueOptions: keyAttribute.errorValueOptions,
-        // Preserve new fields from LLM response
-        valueType: keyAttribute.valueType,
-        dependencies: keyAttribute.dependencies,
-        // Add source locations from static analysis or LLM snippets
-        sourceLocations:
-          sourceLocations.length > 0 ? sourceLocations : undefined,
-      };
-    });
-
-  return {
-    keyAttributes: fullKeyAttributes,
-    llmCall,
-  };
-}
-
-const FRONTEND_SYSTEM_MESSAGE = `You analyze frontend components to identify key data attributes that significantly impact rendering.
-
-## What Makes a Key Attribute
-
-A key attribute is a data path from "Attributes and Value Types" that dramatically changes how the component renders:
-
-- Controls a conditional that shows/hides significant UI sections
-- Changes the component's primary visual state (not just minor text differences)
-- Determines which branch of rendering logic executes
-
-NOT key attributes:
-- Values that only affect non-visible behavior (hrefs, image srcs)
-- Fallback values that won't be used if primary values exist
-- Values that would cause errors if changed
-- Guard clauses that render literally nothing
-
-## Conditional Key Attributes
-
-We've provided a list of variables that are used in conditional statements in the code. These are very likely key attributes.
-
-Each conditional lists its source and how it is used. This should help you identify which attributes to include and what values to suggest.
-
-**IMPORTANT**: Only include attributes with explicit evidence of impact in THIS code:
-- Used directly in a conditional statement (if/ternary/switch)
-- Displayed or rendered directly (e.g., text content, list length)
-- Used in a computation that affects rendering
-
-Do NOT include attributes that are only passed as arguments to other functions without direct usage here. We analyze those functions separately and merge their key attributes automatically.
-
-## Path Format
-
-Only return attributes from the "Attributes and Value Types" list — these are the only values we can control. Use the exact \`fullPath\` provided. Use \`functionCallReturnValue\` for function return values. Use \`[]\` for array items (e.g., \`items[]\`).
-
-## Dependencies and Compound Conditionals
-
-When attributes are used in && chains (compound conditionals), they form dependencies on each other:
-- Each attribute in the chain only has effect when ALL other conditions in the chain are satisfied
-- Include these as dependencies with the required value for the code path to execute
-
-Example: For \`a && b && !c\`:
-- \`a\` has dependencies: \`b\` must be truthy, \`c\` must be falsy
-- \`b\` has dependencies: \`a\` must be truthy, \`c\` must be falsy
-- \`c\` has dependencies: \`a\` must be truthy, \`b\` must be truthy (for the falsy check to matter)
-
-The static analysis section may show "Compound Conditionals" that list which conditions must be true together. Use this to populate the \`dependencies\` array with \`{ "path": "...", "requiredValue": "..." }\` entries.
-
-## Value Type
-
-Should reiterate the type of the attribute (e.g., "string", "object", "array", "boolean", etc.) based on the "Attributes and Value Types" list.
-
-All validValueOptions must be of this type.
-
-## Valid Value Options
-
-- For \`validValueOptions\`, include boundary/extreme values that trigger different behavior
-- Each of the \`validValueOptions\` must be the exact type that we provide in "Attributes and Value Types".
-- Be very specific with values. Do not make them ambiguous in any way
-— Do NOT include values that would cause unexpected/unhandled errors.
-- Ensure all values or value ranges that will trigger different rendering behavior are included
-
-## Response Format
-
-List all key attributes in order from most impactful to least impactful regarding how dramatically they will change the rendering of the component using the following format:
-
-\`\`\`json
-{
-  "keyAttributes": [
-    {
-      "fullPath": "signature[0].user",
-      "description": "Controls whether the main form or redirect screen displays",
-      "codeSnippets": ["if (!user) return <Redirect />", "user.name"],
-      "dependencies": [
-        { "path": "signature[0].projectId", "requiredValue": "truthy", "description": "must be a valid project ID for 'user' to have effect" }
-      ],
-      "valueType": "object",
-      "validValueOptions": ["an empty object {}", "null/undefined"]
-    }
-  ]
-}
-\`\`\`
-
-The \`codeSnippets\` field is required - provide 1-3 short code excerpts (under 80 chars each) showing exactly where and how this attribute is used. These snippets must appear verbatim in the code.
-`;
-
-const BACKEND_SYSTEM_MESSAGE = `You analyze backend functions to identify key data attributes that significantly impact behavior.
-
-## What Makes a Key Attribute
-
-A key attribute is a data path from "Attributes and Value Types" that dramatically changes the function's behavior:
-
-- Controls a conditional that significantly alters execution flow or return value
-- Determines which branch of logic executes
-- For side-effect functions: changes how external systems are called (database, email, etc.)
-
-NOT key attributes:
-- Fallback values that won't be used if primary values exist
-- Values that would cause errors if changed
-- Guard clauses that return nothing/minimal data
-
-## Conditional Key Attributes
-
-We've provided a list of variables that are used in conditional statements in the code. These are very likely key attributes.
-
-Each conditional lists its source and how it is used. This should help you identify which attributes to include and what values to suggest.
-
-**IMPORTANT**: Only include attributes with explicit evidence of impact in THIS code:
-- Used directly in a conditional statement (if/ternary/switch)
-- Displayed or rendered directly (e.g., text content, list length)
-- Used in a computation that affects rendering
-
-Do NOT include attributes that are only passed as arguments to other functions without direct usage here. We analyze those functions separately and merge their key attributes automatically.
-
-## Path Format
-
-Only return attributes from the "Attributes and Value Types" list — these are the only values we can control. Use the exact \`fullPath\` provided. Use \`functionCallReturnValue\` for function return values. Use \`[]\` for array items (e.g., \`items[]\`).
-
-## Dependencies and Compound Conditionals
-
-When attributes are used in && chains (compound conditionals), they form dependencies on each other:
-- Each attribute in the chain only has effect when ALL other conditions in the chain are satisfied
-- Include these as dependencies with the required value for the code path to execute
-
-Example: For \`a && b && !c\`:
-- \`a\` has dependencies: \`b\` must be truthy, \`c\` must be falsy
-- \`b\` has dependencies: \`a\` must be truthy, \`c\` must be falsy
-- \`c\` has dependencies: \`a\` must be truthy, \`b\` must be truthy (for the falsy check to matter)
-
-The static analysis section may show "Compound Conditionals" that list which conditions must be true together. Use this to populate the \`dependencies\` array with \`{ "path": "...", "requiredValue": "..." }\` entries.
-
-## Value Type
-
-Should reiterate the type of the attribute (e.g., "string", "object", "array", "boolean", etc.) based on the "Attributes and Value Types" list.
-
-All validValueOptions must be of this type.
-
-## Valid Value Options
-
-- For \`validValueOptions\`, include boundary/extreme values that trigger different behavior
-- Each of the \`validValueOptions\` must be the exact type that we provide in "Attributes and Value Types".
-- Be very specific with values. Do not make them ambiguous in any way
-— Do NOT include values that would cause unexpected/unhandled errors.
-- Ensure all values or value ranges that will trigger different rendering behavior are included
-
-## Response Format
-
-List all key attributes in order from most impactful to least impactful using the following format:
-
-\`\`\`json
-{
-  "keyAttributes": [
-    {
-      "fullPath": "signature[0].config.enabled",
-      "description": "Controls whether the main processing logic runs",
-      "codeSnippets": ["if (!config.enabled) return", "enabled && processData()"],
-      "dependencies": [
-        { "path": "signature[0].analysisMode", "requiredValue": "full", "description": "must be 'full' for 'enabled' to have effect" }
-      ],
-      "valueType": "boolean",
-      "validValueOptions": ["true", "false"]
-    }
-  ]
-}
-\`\`\`
-
-The \`codeSnippets\` field is required - provide 1-3 short code excerpts (under 80 chars each) showing exactly where and how this attribute is used. These snippets must appear verbatim in the code.
-`;

package/analyzer-template/packages/ai/src/lib/promptGenerators/generateEntityKeyAttributesGenerator.ts

@@ -1,67 +0,0 @@
-import { Analysis } from '~codeyam/types';
-
-interface GenerateEntityKeyAttributesGeneratorArgs {
-  code: string;
-  attributesMap: Record<string, string>;
-  associationMap?: Record<string, string>;
-  existingKeyAttributes?: Analysis['metadata']['keyAttributes'];
-  commitDiff?: string;
-  /** Pre-formatted static analysis context showing attributes used in conditionals */
-  staticAnalysisContext?: string;
-}
-
-export default function generateEntityKeyAttributesGenerator({
-  code,
-  attributesMap,
-  associationMap = {},
-  existingKeyAttributes,
-  commitDiff,
-  staticAnalysisContext,
-}: GenerateEntityKeyAttributesGeneratorArgs) {
-  // Build the new format: "fullPath": { variableName: "name", type: "type" }
-  const formattedAttributes = Object.entries(attributesMap)
-    .sort((a, b) => a[0].localeCompare(b[0]))
-    .map(([variableName, type]) => {
-      const fullPath = associationMap[variableName] || variableName;
-      return `"${variableName}":\n  {\n    fullPath: "${fullPath}",\n    type: "${type}"\n  }`;
-    })
-    .join('\n');
-
-  return `Attributes and Value Types:
-
-\`\`\`
-${formattedAttributes}
-\`\`\`
-${staticAnalysisContext ? `\n\nConditional Key Attributes:\n\`\`\`${staticAnalysisContext}\`\`\`\n\n` : ''}
-${
-  existingKeyAttributes
-    ? `
-Existing Key Attributes:
-\`\`\`
-${JSON.stringify(
-  existingKeyAttributes.filter((attr) => attributesMap[attr.internalPath]),
-  null,
-  2,
-)}
-\`\`\`
-
-`
-    : ``
-}
-${
-  commitDiff
-    ? `
-Code Change:
-\`\`\`
-${commitDiff}
-\`\`\`
-
-`
-    : ''
-}
-Code:
-\`\`\`
-${code}
-\`\`\`
-`;
-}

package/analyzer-template/packages/analyze/src/lib/files/scenarios/generateKeyAttributes.ts

@@ -1,120 +0,0 @@
-import {
-  Analysis,
-  Entity,
-  DEFAULT_SCENARIO_NAME,
-  ReadonlyAnalysisMap,
-} from '~codeyam/types';
-import measureAndReportExecutionTime from '../../utils/measureAndReportExecutionTime';
-import { AI, generateEntityKeyAttributes } from '~codeyam/ai';
-import { awsLog } from '~codeyam/utils';
-import { gatherRelevantDependentKeyAttributes } from '~codeyam/ai';
-import { gatherDataForMocks } from './generateScenarioData';
-
-export interface GenerateEntityKeyAttributesArgs {
-  entity: Entity;
-  analysis: Analysis;
-  dependentAnalyses: ReadonlyAnalysisMap;
-  error?: boolean;
-  model: AI.Model;
-  updateProgress?: (detail: string) => void;
-}
-
-export default async function generateKeyAttributes({
-  entity,
-  analysis,
-  dependentAnalyses,
-  error,
-  model,
-  updateProgress,
-}: GenerateEntityKeyAttributesArgs): Promise<void> {
-  if (!['visual', 'library'].includes(entity.entityType)) return;
-
-  // Gather all mock data, consolidated under the root entity name
-  const structure = {
-    arguments: analysis.metadata.scenariosDataStructure?.arguments ?? [],
-    dataForMocks: gatherDataForMocks(analysis, dependentAnalyses, entity.name),
-  };
-
-  awsLog(`🔮 Generating ${error ? 'error ' : ''}scenarios for`, {
-    filePath: entity.filePath,
-    entityName: entity.name,
-    structure,
-  });
-
-  if (
-    !structure ||
-    (Object.keys(structure.dataForMocks ?? {}).length === 0 &&
-      (structure.arguments ?? []).length === 0)
-  ) {
-    if (!error) {
-      analysis.scenarios = [
-        {
-          projectId: analysis.projectId,
-          analysisId: analysis.id,
-          name: DEFAULT_SCENARIO_NAME,
-          description: 'The only external state the component can be in.',
-          metadata: {
-            testName: 'it("renders correctly")',
-            keyAttributeInstructions: {},
-          },
-        },
-      ];
-    }
-
-    return;
-  }
-
-  if (!analysis.metadata.keyAttributes) {
-    const {
-      result: { keyAttributes, llmCall: keyAttributesLLMCall },
-    } = await measureAndReportExecutionTime(
-      () =>
-        generateEntityKeyAttributes({
-          entity,
-          mergedDataStructure: analysis.metadata.mergedDataStructure,
-          model,
-        }),
-      `Generating entity key attributes`,
-      updateProgress,
-    );
-
-    const relevantDependentKeyAttributes = gatherRelevantDependentKeyAttributes(
-      entity,
-      analysis.metadata.mergedDataStructure,
-      dependentAnalyses,
-    );
-
-    analysis.metadata.keyAttributes = [
-      ...keyAttributes,
-      ...relevantDependentKeyAttributes.map((ka) => ({
-        ...ka,
-        // Spread to convert readonly arrays to mutable arrays (with fallback for undefined)
-        validValueOptions: [...(ka.validValueOptions ?? [])],
-        errorValueOptions: [...(ka.errorValueOptions ?? [])],
-        // Convert readonly dependencies array to mutable if present
-        ...(ka.dependencies && {
-          dependencies: ka.dependencies.map((dep) => ({ ...dep })),
-        }),
-        // Convert readonly sourceLocations array to mutable if present
-        ...(ka.sourceLocations && {
-          sourceLocations: ka.sourceLocations.map((loc) => ({ ...loc })),
-        }),
-        // Convert readonly compoundConditionalIds array to mutable if present
-        ...(ka.compoundConditionalIds && {
-          compoundConditionalIds: [...ka.compoundConditionalIds],
-        }),
-      })),
-    ].filter(
-      (ka, index, self) =>
-        self.findIndex((k) => k.internalPath === ka.internalPath) === index,
-    );
-
-    if (keyAttributesLLMCall) {
-      analysis.metadata.llmCalls ||= [];
-      analysis.metadata.llmCalls.push({
-        name: `generateEntityKeyAttributes`,
-        id: keyAttributesLLMCall.id,
-      });
-    }
-  }
-}