@codeyam/codeyam-cli 0.1.0-staging.d0ad4ae → 0.1.0-staging.d52b24f

package/analyzer-template/packages/analyze/src/lib/files/scenarios/generateChangesScenarios.ts

@@ -6,14 +6,10 @@ import {
   DEFAULT_SCENARIO_NAME,
 } from '~codeyam/types';
 import measureAndReportExecutionTime from '../../utils/measureAndReportExecutionTime';
-import {
-  AI,
-  generateChangesEntityScenarios,
-  generateChangesEntityKeyAttributes,
-  gatherRelevantDependentKeyAttributes,
-} from '~codeyam/ai';
+import { AI, generateChangesEntityScenarios } from '~codeyam/ai';
 import { awsLog } from '~codeyam/utils';
 import detectChangedDataStructureFields from './detectChangedDataStructureFields';
+import generateExecutionFlows from './generateExecutionFlows';
 
 export interface GenerateChangesScenariosArgs {
   previousAnalysis: Analysis;
@@ -40,8 +36,8 @@ export default async function generateChangesScenarios({
 
   const existingScenarios = (previousAnalysis.scenarios ?? []).filter(
     (s) =>
-      (error ? s.metadata.error : !s.metadata.error) &&
-      !s.metadata.sameAsDefault,
+      (error ? s.metadata?.error : !s.metadata?.error) &&
+      !s.metadata?.sameAsDefault,
   );
   const commitDiff = commit.files.find(
     (f) => f.fileName === entity.filePath,
@@ -87,8 +83,7 @@ export default async function generateChangesScenarios({
           name: DEFAULT_SCENARIO_NAME,
           description: 'The only external state the component can be in.',
           metadata: {
-            dataMapping: {},
-            keyAttributeInstructions: {},
+            coveredFlows: [],
           },
         },
       ];
@@ -96,178 +91,20 @@ export default async function generateChangesScenarios({
     return;
   }
 
-  // if (!analysis.metadata.keyAttributes) {
-  const existingKeyAttributes = (
-    previousAnalysis.metadata?.keyAttributes ?? []
-  ).filter(
-    (keyAttribute, index, self) =>
-      self.findIndex((ka) => ka.internalPath === keyAttribute.internalPath) ===
-      index,
-  );
-
-  const {
-    result: { keyAttributes, llmCall: keyAttributesLLMCall },
-  } = await measureAndReportExecutionTime(
-    () =>
-      generateChangesEntityKeyAttributes({
-        entity,
-        existingKeyAttributes,
-        analysis,
-        commitDiff,
-        model,
-      }),
-    `Generating changes entity key attributes`,
-    updateProgress,
-  );
-
-  // Merge in dependent key attributes (same as initial flow)
-  // This ensures dependent entity key attributes aren't incorrectly seen as "removed"
-  const relevantDependentKeyAttributes = gatherRelevantDependentKeyAttributes(
-    entity,
-    analysis.metadata.mergedDataStructure,
-    dependentAnalyses,
-  );
-
-  // Log dependent key attributes gathered
-  awsLog(`CodeYam: Dependent key attributes gathered for ${entity.name}`, {
-    dependentKeyAttributeCount: relevantDependentKeyAttributes.length,
-    dependentKeyAttributes: relevantDependentKeyAttributes.map((ka) => ({
-      internalPath: ka.internalPath,
-      externalPath: ka.externalPath,
-      dependentEntityName: (ka as any).dependentEntityName,
-      originalEntityName: (ka as any).originalEntityName,
-      filePath: (ka as any).filePath,
-    })),
-    dependentAnalysesEntities: Object.entries(dependentAnalyses).flatMap(
-      ([path, entities]) =>
-        Object.keys(entities).map((name) => ({ path, name })),
-    ),
-  });
-
-  analysis.metadata.keyAttributes = [
-    ...keyAttributes,
-    ...relevantDependentKeyAttributes.map((ka) => ({
-      ...ka,
-      // Spread to convert readonly arrays to mutable arrays (with fallback for undefined)
-      validValueOptions: [...(ka.validValueOptions ?? [])],
-      errorValueOptions: [...(ka.errorValueOptions ?? [])],
-      // Convert readonly dependencies array to mutable if present
-      ...(ka.dependencies && {
-        dependencies: ka.dependencies.map((dep) => ({ ...dep })),
-      }),
-      // Convert readonly sourceLocations array to mutable if present
-      ...(ka.sourceLocations && {
-        sourceLocations: ka.sourceLocations.map((loc) => ({ ...loc })),
-      }),
-      // Convert readonly compoundConditionalIds array to mutable if present
-      ...(ka.compoundConditionalIds && {
-        compoundConditionalIds: [...ka.compoundConditionalIds],
-      }),
-    })),
-  ].filter(
-    (ka, index, self) =>
-      self.findIndex((k) => k.internalPath === ka.internalPath) === index,
-  );
-
-  if (keyAttributesLLMCall) {
-    analysis.metadata.llmCalls ||= [];
-    analysis.metadata.llmCalls.push({
-      name: `generateChangesEntityKeyAttributes`,
-      id: keyAttributesLLMCall.id,
+  // Generate execution flows if not already present
+  if (!analysis.metadata.executionFlows) {
+    await generateExecutionFlows({
+      entity,
+      analysis,
+      model,
+      updateProgress,
+      dependentAnalyses,
     });
   }
-  // }
-
-  const addedKeyAttributes = analysis.metadata.keyAttributes?.filter(
-    (ka) =>
-      !previousAnalysis.metadata.keyAttributes?.find(
-        (ka2) => ka.internalPath === ka2.internalPath,
-      ),
-  );
-  const removedKeyAttributes = previousAnalysis.metadata.keyAttributes?.filter(
-    (ka) =>
-      !analysis.metadata.keyAttributes.find(
-        (ka2) => ka.internalPath === ka2.internalPath,
-      ),
-  );
-
-  // Log key attribute changes for debugging
-  awsLog(`CodeYam: Key attribute comparison for ${entity.name}`, {
-    previousKeyAttributePaths: previousAnalysis.metadata.keyAttributes?.map(
-      (ka) => ({
-        internalPath: ka.internalPath,
-        isDependentAttr: !!(ka as any).dependentEntityName,
-        dependentEntityName: (ka as any).dependentEntityName,
-      }),
-    ),
-    currentKeyAttributePaths: analysis.metadata.keyAttributes?.map((ka) => ({
-      internalPath: ka.internalPath,
-      isDependentAttr: !!(ka as any).dependentEntityName,
-      dependentEntityName: (ka as any).dependentEntityName,
-    })),
-    addedKeyAttributePaths: addedKeyAttributes?.map((ka) => ({
-      internalPath: ka.internalPath,
-      isDependentAttr: !!(ka as any).dependentEntityName,
-      dependentEntityName: (ka as any).dependentEntityName,
-      filePath: (ka as any).filePath,
-    })),
-    removedKeyAttributePaths: removedKeyAttributes?.map((ka) => ({
-      internalPath: ka.internalPath,
-      isDependentAttr: !!(ka as any).dependentEntityName,
-      dependentEntityName: (ka as any).dependentEntityName,
-      filePath: (ka as any).filePath,
-    })),
-  });
-
-  // Detect key attributes with NEW source locations (usages)
-  // These are existing attributes that gained new conditional usages in the code
-  const modifiedKeyAttributes = analysis.metadata.keyAttributes
-    ?.filter((ka) => {
-      // Only consider attributes that existed before (not newly added)
-      const previousAttr = previousAnalysis.metadata.keyAttributes?.find(
-        (ka2) => ka.internalPath === ka2.internalPath,
-      );
-      if (!previousAttr) return false;
-
-      // Check if there are new source locations
-      const previousSnippets = new Set(
-        previousAttr.sourceLocations?.map((loc) => loc.codeSnippet) ?? [],
-      );
-      const newSourceLocations = ka.sourceLocations?.filter(
-        (loc) => !previousSnippets.has(loc.codeSnippet),
-      );
-
-      return newSourceLocations && newSourceLocations.length > 0;
-    })
-    .map((ka) => {
-      const previousAttr = previousAnalysis.metadata.keyAttributes?.find(
-        (ka2) => ka.internalPath === ka2.internalPath,
-      );
-      const previousSnippets = new Set(
-        previousAttr?.sourceLocations?.map((loc) => loc.codeSnippet) ?? [],
-      );
-      const newSourceLocations = ka.sourceLocations?.filter(
-        (loc) => !previousSnippets.has(loc.codeSnippet),
-      );
-
-      return {
-        keyAttribute: ka,
-        newSourceLocations,
-      };
-    });
 
-  // Log modified key attributes
-  if (modifiedKeyAttributes && modifiedKeyAttributes.length > 0) {
-    awsLog(`CodeYam: Modified key attributes for ${entity.name}`, {
-      modifiedKeyAttributePaths: modifiedKeyAttributes.map((mod) => ({
-        internalPath: mod.keyAttribute.internalPath,
-        isDependentAttr: !!(mod.keyAttribute as any).dependentEntityName,
-        dependentEntityName: (mod.keyAttribute as any).dependentEntityName,
-        newUsageCount: mod.newSourceLocations?.length ?? 0,
-        newUsages: mod.newSourceLocations?.map((loc) => loc.codeSnippet),
-      })),
-    });
-  }
+  // Get previous execution flows for comparison
+  const previousExecutionFlows =
+    previousAnalysis.metadata?.executionFlows ?? [];
 
   // Detect which specific data structure fields changed
   const changedDataStructureFields = detectChangedDataStructureFields(
@@ -281,11 +118,8 @@ export default async function generateChangesScenarios({
     () =>
       generateChangesEntityScenarios({
         entity,
-        keyAttributes: analysis.metadata.keyAttributes,
-        addedKeyAttributes,
-        removedKeyAttributes,
-        modifiedKeyAttributes,
-        dependentAnalyses,
+        executionFlows: analysis.metadata.executionFlows,
+        previousExecutionFlows,
         existingScenarios,
         commitDiff,
         analysis,
@@ -301,10 +135,13 @@ export default async function generateChangesScenarios({
   for (const scenario of scenarios) {
     if (
       scenario.previousVersionId &&
-      !scenario.metadata.revisedFromPreviousVersion
+      !scenario.metadata?.revisedFromPreviousVersion
     ) {
       if (dataStructureChanged) {
-        scenario.metadata.revisedFromPreviousVersion = true;
+        scenario.metadata = {
+          ...scenario.metadata,
+          revisedFromPreviousVersion: true,
+        };
         continue;
       }
 
@@ -312,7 +149,10 @@ export default async function generateChangesScenarios({
         (s) => s.name === scenario.name,
       );
       if (!existingScenarioStatus || existingScenarioStatus.error) {
-        scenario.metadata.revisedFromPreviousVersion = true;
+        scenario.metadata = {
+          ...scenario.metadata,
+          revisedFromPreviousVersion: true,
+        };
       }
     }
   }
@@ -336,7 +176,7 @@ export default async function generateChangesScenarios({
 
     if (analysis.scenarios) {
       for (const existingScenario of analysis.scenarios.filter((s) =>
-        error ? !!s.metadata.error : !s.metadata.error,
+        error ? !!s.metadata?.error : !s.metadata?.error,
       )) {
         const scenarioIndex = scenarios.findIndex(
           (s) => s.name === existingScenario.name,