@codeyam/codeyam-cli 0.1.0-staging.bd4126b → 0.1.0-staging.c276166

package/analyzer-template/project/writeMockDataTsx.ts

@@ -8,6 +8,7 @@ import type { AnyNode } from 'domhandler';
 import { safeFileName } from '~codeyam/utils';
 import { cleanOutBoundary } from '~codeyam/ai';
 import { reconcileMockDataKeys } from './reconcileMockDataKeys';
+import coerceObjectsToPrimitivesBySchema from '~codeyam/ai/src/lib/dataStructure/helpers/coerceObjectsToPrimitivesBySchema';
 
 /**
  * Normalize useParams mock data by fixing the React Router splat param (*).
@@ -1029,6 +1030,14 @@ export default async function writeMockDataTsx(
     expectedKeys,
   );
 
+  // Coerce objects/arrays to primitives when the schema expects a primitive type.
+  // Defense-in-depth: the generation pipeline already runs this coercion, but
+  // data in the DB may have wrong types from older code versions or edge cases.
+  // This prevents runtime errors like "TypeError: body.match is not a function".
+  if (dataForMocks) {
+    coerceObjectsToPrimitivesBySchema(reconciledMockData, dataForMocks);
+  }
+
   // Convert comma-separated strings to arrays for fields that should be arrays
   // This handles cases where LLM generates "color,size" instead of ["color", "size"]
   const defaultMockData =
@@ -1076,6 +1085,14 @@ import React from 'react';
       expectedKeys,
     );
 
+    // Coerce objects/arrays to primitives for non-default scenario data too
+    if (dataForMocks) {
+      coerceObjectsToPrimitivesBySchema(
+        reconciledScenarioMockData,
+        dataForMocks,
+      );
+    }
+
     // Convert comma-separated strings to arrays for scenario data
     const scenarioMockData = convertCommaSeparatedStringsToArrays(
       reconciledScenarioMockData,

package/analyzer-template/project/writeScenarioComponents.ts

@@ -1055,11 +1055,17 @@ function addMockToContent(
       // use the base name (e.g., "trpc") when calling constructMockCode. This ensures
       // constructMockCode generates a complete nested mock from the schema without
       // referencing __cyOriginal variables.
+      // NOTE: Only check for dots BEFORE the first open paren. Function calls with
+      // dotted arguments like "getSurveyWithMetadata(params.surveyId)" have dots
+      // INSIDE parens — these are NOT method chains and should keep the full signature.
       const dataKeyBaseName = dataKey.split(/[.<(]/)[0];
+      const firstParenIndex = dataKey.indexOf('(');
+      const partBeforeFirstParen =
+        firstParenIndex >= 0 ? dataKey.substring(0, firstParenIndex) : dataKey;
       const isMethodChainDataKey =
         dataKeyBaseName === importedExport.name &&
         dataKey !== importedExport.name &&
-        dataKey.includes('.');
+        partBeforeFirstParen.includes('.');
       const mockNameToUse = isMethodChainDataKey
         ? importedExport.name
         : dataKey;
@@ -1145,12 +1151,20 @@ function ${importedExport.name}(...args) {
       // referencing __cyOriginal variables. The __cyOriginal pattern is only needed
       // for partial mocking where we preserve some original methods, not for complete
       // method-chain mocks where we provide all implementations.
+      // NOTE: Only check for dots BEFORE the first open paren. Function calls with
+      // dotted arguments like "getSurveyWithMetadata(params.surveyId)" have dots
+      // INSIDE parens — these are NOT method chains and should keep the full signature.
       const dataKeyBaseName = dataKey?.split(/[.<(]/)[0];
+      const elseFirstParenIndex = dataKey?.indexOf('(') ?? -1;
+      const elsePartBeforeFirstParen =
+        dataKey && elseFirstParenIndex >= 0
+          ? dataKey.substring(0, elseFirstParenIndex)
+          : dataKey;
       const isMethodChainDataKey =
         dataKey &&
         dataKeyBaseName === importedExport.name &&
         dataKey !== importedExport.name &&
-        dataKey.includes('.');
+        (elsePartBeforeFirstParen?.includes('.') ?? false);
       const mockNameToUse = isMethodChainDataKey
         ? importedExport.name
         : (dataKey ?? importedExport.calls?.[0] ?? `${importedExport.name}()`);
@@ -1920,6 +1934,17 @@ export default async function writeScenarioComponents({
               dataFileContent = stripServerOnlyImport(dataFileContent);
               dataFileContent = applyServerOnlyMocks(dataFileContent);
 
+              // Process transitive imports: if the data entity file imports from files
+              // that have `import "server-only"`, rewrite those imports to transitive
+              // copies with server-only stripped. Without this, data entity files that
+              // end up in a client bundle (e.g., via a stripped "use server" boundary)
+              // would pull in server-only code and cause build failures.
+              dataFileContent = await processTransitiveImportsRecursively(
+                dataFileContent,
+                fileNotMocked.path,
+                dataScenarioPath,
+              );
+
               // Write the transformed data entity file
               await writeFile(dataScenarioPath, dataFileContent);
               scenarioComponentPaths.push(dataScenarioPath);
@@ -1945,9 +1970,9 @@ export default async function writeScenarioComponents({
               importedExport.name,
             );
 
-            // Don't recurse - data entities don't need their dependencies processed
-            // The import rewriting will happen later in this same loop iteration
-            // (at lines ~1590-1702) to point imports to this transformed file
+            // Don't recurse into full writeScenarioComponents - data entities don't
+            // need mock generation for their dependencies. Transitive server-only
+            // import processing is already handled above via processTransitiveImportsRecursively.
           } else {
             // For visual/library entities, recurse to process their dependencies
 
@@ -3062,10 +3087,14 @@ ${exportKeyword}const ${functionName} = new Proxy(() => scenarios().data()?.["${
           fileContent = `import { scenarios } from "${mockDataPath}";\n\n${fileContent}`;
         }
 
-        // Add wrapper default export that injects argumentsData as props
+        // Add wrapper default export that injects argumentsData as props.
+        // Filter null values: the LLM uses null to mean "don't pass this prop"
+        // but spreading { prop: null } explicitly passes null, which differs from
+        // undefined (absent) and crashes components that check `prop !== undefined`.
         fileContent += `\n\nexport default function _CYRouteWrapper(props: any) {
   const _cyArgs = scenarios().data()?.['arguments']?.[0] ?? {};
-  return <${funcName} {...props} {..._cyArgs} />;
+  const _cyCleanArgs = Object.fromEntries(Object.entries(_cyArgs).filter(([_, v]) => v !== null));
+  return <${funcName} {...props} {..._cyCleanArgs} />;
 }\n`;
       }
     }

package/analyzer-template/tsconfig.json

@@ -15,6 +15,18 @@
       "~codeyam/*": ["./packages/*"]
     },
     "sourceMap": true,
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "types": [
+      "node",
+      "jest",
+      "jsdom",
+      "better-sqlite3",
+      "yargs",
+      "pg",
+      "ws",
+      "react",
+      "react-dom",
+      "react-resizable"
+    ]
   }
 }

package/background/src/lib/virtualized/project/constructMockCode.js

@@ -257,6 +257,7 @@ options) {
     let dataStructureValue;
     let foundEntityWithSignature = false;
     let signatureSchema;
+    let baseSchemaHasMethodCalls = false;
     entitySearch: for (const filePath in dependencySchemas) {
         for (const entityName in dependencySchemas[filePath]) {
             // Match entity by base name (without generics/args)
@@ -281,8 +282,44 @@ options) {
                     pathParts[mockNameParts.length - 1].startsWith(mockNameParts[mockNameParts.length - 1]));
             });
             if (dataStructurePath) {
+                // Start with the base entity's return value schema
+                const baseReturnValueSchema = dependencySchemas[filePath][entityName]?.returnValueSchema;
+                const mergedSchema = {
+                    ...baseReturnValueSchema,
+                };
+                // Check if the base schema has method-call entries (e.g., .map().functionCallReturnValue)
+                // When it does, the scenario data is stored as an object with method keys, and
+                // array prototype methods need mock implementations. When it doesn't, the data
+                // is a raw array and native methods like .includes() work directly.
+                if (baseReturnValueSchema) {
+                    baseSchemaHasMethodCalls = Object.keys(baseReturnValueSchema).some((k) => k.startsWith(baseMockName + '.') &&
+                        k.includes('(') &&
+                        k.includes('.functionCallReturnValue'));
+                }
+                // Merge in method-call dependencies that are separate entries.
+                // e.g., "activityTypes.find((a) => a.value === type)" is a separate dependency
+                // for a .find() call on activityTypes. We need to include these with a
+                // .functionCallReturnValue path so constructMockCode generates callable mock methods.
+                for (const otherEntityName in dependencySchemas[filePath]) {
+                    if (otherEntityName === entityName)
+                        continue;
+                    if (otherEntityName.startsWith(baseMockName + '.') &&
+                        otherEntityName.includes('(')) {
+                        // Add a functionCallReturnValue entry for this method call.
+                        // This ensures constructMockCode treats it as a function that returns data,
+                        // generating a proper mock method with data lookup.
+                        const fcrvPath = `${otherEntityName}.functionCallReturnValue`;
+                        if (!mergedSchema[fcrvPath]) {
+                            // Infer the return type from the method-call dependency's schema
+                            const otherSchema = dependencySchemas[filePath][otherEntityName]?.returnValueSchema;
+                            // Look for element type (baseMockName[]) or fall back to 'unknown'
+                            const elementType = otherSchema?.[`${baseMockName}[]`];
+                            mergedSchema[fcrvPath] = elementType || 'unknown';
+                        }
+                    }
+                }
                 relevantReturnValueSchema = fillInDirectSchemaGapsAndUnknowns({
-                    schema: dependencySchemas[filePath][entityName]?.returnValueSchema,
+                    schema: mergedSchema,
                 });
                 // NOTE: clearAttributesFromMapping is disabled because it deletes
                 // method calls on arrays (like .eq() after functionCallReturnValue: 'array')
@@ -352,7 +389,10 @@ options) {
             args.push('...rest');
             const argsString = args.join(', ');
             // Generate empty mock function
-            return `function ${mockName}(${argsString}) {
+            // Use baseMockName (not mockName) because mockName may contain a full call
+            // signature with argument expressions (e.g., "logSignOutAction(sessionUser.id, ...)")
+            // which would produce invalid syntax as function parameter names.
+            return `function ${baseMockName}(${argsString}) {
   // Empty mock - original function mocked out
 }`;
         }
@@ -391,12 +431,12 @@ options) {
             : false;
         if (firstArgIsFunctionOrUnknown && returnsFunction) {
             // HOC pattern detected - return the first argument
-            return `function ${mockName}(${argsString}) {
+            return `function ${baseMockName}(${argsString}) {
   return arg1;
 }`;
         }
         // Generate empty mock function
-        return `function ${mockName}(${argsString}) {
+        return `function ${baseMockName}(${argsString}) {
   // Empty mock - original function mocked out
 }`;
     }
@@ -536,17 +576,23 @@ options) {
                 return [];
             }
             const addReturnValueFunctionAccessor = (dataPath) => {
-                // Add function call accessor if:
-                // - There are actual arguments, OR
-                // - This is a callable (not a method that returns an array directly)
-                // For methods like getAll() that return arrays, the data is at ["getAll()"] not ["getAll()"]["()"]
                 if (returnValue.returnsFunctionArgs &&
                     (returnValue.returnsFunctionArgs.length > 0 ||
                         !returnValue.returnsFunctionArray)) {
                     if (returnValue.isArray) {
                         dataPath = `${dataPath}${optionalAccess('[0]')}`;
                     }
-                    dataPath = `${dataPath}${optionalAccess(`(${safeString(returnValue.returnsFunctionArgs.join(', '))})`)}`;
+                    // Only add the function call accessor ?.["(args)"] when there are actual
+                    // arguments. When returnsFunctionArgs is empty [] (function-returns-function
+                    // with no specific arg patterns), skip the ?.["()"] because:
+                    // 1. preprocessSchemaForMocks collapses nested functionCallReturnValue chains
+                    //    into flat entries (e.g., getTranslate() = string, not {(): string})
+                    // 2. The mock data is a flat value, so ?.["()"] on a string returns undefined
+                    // 3. constructContent still wraps the return in a function (via returnsFunctionArgs)
+                    //    so the function-returns-function behavior is preserved without data nesting
+                    if (returnValue.returnsFunctionArgs.length > 0) {
+                        dataPath = `${dataPath}${optionalAccess(`(${safeString(returnValue.returnsFunctionArgs.join(', '))})`)}`;
+                    }
                 }
                 return dataPath;
             };
@@ -572,20 +618,6 @@ options) {
         };
         const constructContent = (dataPaths) => {
             const { name, args, nested, isArray, isGenericArray, returnsFunctionArgs, returnsFunctionArray, isAsyncFunction, hasNoReturnData, } = returnValue;
-            // When an array has differentiated indices ([0], [1], etc.), filter out any
-            // non-index items from nested. These non-index items come from generic [] paths
-            // like [].filter or [].sort, which describe element properties, not array elements.
-            // Including them would generate invalid syntax like "sort: ..." inside an array literal.
-            const hasDifferentiatedIndices = isArray &&
-                nested &&
-                nested.some((n) => n.name.match(/^\[\d+\]$/) && n.name !== '[0]');
-            const filteredNested = hasDifferentiatedIndices && nested
-                ? nested.filter((n) => n.name.match(/^\[\d+\]$/))
-                : nested;
-            const nestedContent = (filteredNested ?? []).map((nestedItem) => {
-                const nestedContent = constructReturnValueString(nestedItem, dataPaths);
-                return nestedContent;
-            });
             // Array prototype methods that should be ignored when building mocks
             // (these work on any array - we don't need to mock them)
             const ARRAY_PROTOTYPE_METHODS = new Set([
@@ -629,6 +661,36 @@ options) {
                 'with',
                 'length',
             ]);
+            // When an array has differentiated indices ([0], [1], etc.), filter out any
+            // non-index items from nested. These non-index items come from generic [] paths
+            // like [].filter or [].sort, which describe element properties, not array elements.
+            // Including them would generate invalid syntax like "sort: ..." inside an array literal.
+            const hasDifferentiatedIndices = isArray &&
+                nested &&
+                nested.some((n) => n.name.match(/^\[\d+\]$/) && n.name !== '[0]');
+            let filteredNested = hasDifferentiatedIndices && nested
+                ? nested.filter((n) => n.name.match(/^\[\d+\]$/))
+                : nested;
+            // When a variable IS an array (not a function returning an array),
+            // filter out array prototype methods like .includes(), .filter(), etc.
+            // ONLY when the base schema has no method-call entries. When the base
+            // schema has methods (e.g., .map().functionCallReturnValue), the scenario
+            // data is stored as an object with method-call keys, and ALL methods
+            // need mock implementations. When the base schema has no methods, the
+            // data is a raw array and native methods like .includes() work directly.
+            if (isArray &&
+                !returnsFunctionArray &&
+                !baseSchemaHasMethodCalls &&
+                filteredNested) {
+                filteredNested = filteredNested.filter((n) => {
+                    const methodName = n.name.replace(/[<(].*$/, '');
+                    return !ARRAY_PROTOTYPE_METHODS.has(methodName);
+                });
+            }
+            const nestedContent = (filteredNested ?? []).map((nestedItem) => {
+                const nestedContent = constructReturnValueString(nestedItem, dataPaths);
+                return nestedContent;
+            });
             const levelContentItems = [];
             // Add spread for data paths when:
             // - Not a function returning an array, OR function returns array with custom methods
@@ -1360,20 +1422,39 @@ options) {
                     content = `${cleanOutTypes(name)}: ${isAsyncFunction ? 'async ' : ''}(${argsString}) => {\n${indent(funcContents)}\n}`;
                 }
                 else {
-                    // No argument variants - use existing behavior
-                    // But if there's nested content, we need to include it in the return object
-                    // (similar to how argument variant branches handle this at line 1070-1072)
-                    const hasNestedContent = validNestedContent.length > 0;
-                    let funcReturnContents;
-                    if (hasNestedContent && levelContentItems.length > 1) {
-                        // Include both spread and nested content in the return
-                        funcReturnContents = `{\n${indent(levelContents)}\n}`;
+                    // No argument variants
+                    // Check if this is an array method callback containing JSX.
+                    // JSX can't be serialized to JSON, so the LLM generates [{}] as data.
+                    // Instead of returning that unusable data, generate a passthrough that
+                    // calls the real callback on the best available array data from siblings.
+                    const containsJsx = dataPaths.some((p) => /<[A-Z]/.test(p));
+                    const isArrayMethod = ARRAY_PROTOTYPE_METHODS.has(name);
+                    if (containsJsx && isArrayMethod && dataPaths.length > 0) {
+                        // Extract parent data path by removing the last ?.["..."] segment
+                        const parentPath = dataPaths[0].replace(/\?\.\["[^"]*"\]$/, '');
+                        const funcLines = [
+                            `const _d = ${parentPath};`,
+                            `const _a = Object.values(_d || {}).filter(v => Array.isArray(v) && v.length > 0 && v.some(i => i && typeof i === "object" && Object.keys(i).length > 0)).sort((a, b) => b.length - a.length);`,
+                            `return _a[0] ? _a[0].${name}(${argsString}) : []`,
+                        ];
+                        const funcContents = funcLines.join('\n');
+                        content = `${cleanOutTypes(name)}: ${isAsyncFunction ? 'async ' : ''}(${argsString}) => {\n${indent(funcContents)}\n}`;
                     }
                     else {
-                        funcReturnContents = returnValueContents;
+                        // But if there's nested content, we need to include it in the return object
+                        // (similar to how argument variant branches handle this at line 1070-1072)
+                        const hasNestedContent = validNestedContent.length > 0;
+                        let funcReturnContents;
+                        if (hasNestedContent && levelContentItems.length > 1) {
+                            // Include both spread and nested content in the return
+                            funcReturnContents = `{\n${indent(levelContents)}\n}`;
+                        }
+                        else {
+                            funcReturnContents = returnValueContents;
+                        }
+                        const funcContents = `return ${funcReturnContents}`;
+                        content = `${cleanOutTypes(name)}: ${isAsyncFunction ? 'async ' : ''}(${argsString}) => {\n${indent(funcContents)}\n}`;
                     }
-                    const funcContents = `return ${funcReturnContents}`;
-                    content = `${cleanOutTypes(name)}: ${isAsyncFunction ? 'async ' : ''}(${argsString}) => {\n${indent(funcContents)}\n}`;
                 }
             }
             else {