@codeyam/codeyam-cli 0.1.0-staging.bbe4da9 → 0.1.0-staging.d0ad4ae

package/packages/ai/src/lib/dataStructure/ScopeDataStructure.js

@@ -138,7 +138,12 @@ const ALLOWED_EQUIVALENCY_REASONS = new Set([
     'Array.from() equivalency',
     'propagated sub-property equivalency',
     'propagated function call return sub-property equivalency',
+    'propagated parent-variable equivalency', // Added: propagate child scope equivalencies to parent scope when variable is defined in parent
     'where was this function called from', // Added: tracks which scope called an external function
+    'MUI DataGrid renderCell params.row equivalency', // Added: links DataGrid renderCell params.row to rows array elements
+    'MUI Autocomplete getOptionLabel option equivalency', // Added: links Autocomplete getOptionLabel callback param to options array
+    'MUI Autocomplete renderOption option equivalency', // Added: links Autocomplete renderOption callback param to options array
+    'MUI Autocomplete option property equivalency', // Added: propagates property accesses from Autocomplete callbacks
 ]);
 const SILENTLY_IGNORED_EQUIVALENCY_REASONS = new Set([
     'signature of functionCall',
@@ -182,6 +187,9 @@ export class ScopeDataStructure {
         // Index for O(1) lookup of external function calls by name
         // Invalidated by setting to null; rebuilt lazily on next access
         this.externalFunctionCallsIndex = null;
+        // Tracks internal functions that have been filtered out during captureCompleteSchema
+        // Prevents re-adding them via subsequent equivalency propagation (e.g., from getReturnValue)
+        this.filteredInternalFunctions = new Set();
         // Debug tracer for selective path/scope tracing
         // Enable via: CODEYAM_DEBUG=true CODEYAM_DEBUG_PATHS="user.*,signature" npm test
         this.tracer = new DebugTracer({
@@ -300,6 +308,8 @@ export class ScopeDataStructure {
             const efcName = this.pathManager.stripGenerics(efc.name);
             for (const manager of this.equivalencyManagers) {
                 if (manager.internalFunctions.has(efcName)) {
+                    // Track this so we don't re-add it via subsequent finalize calls
+                    this.filteredInternalFunctions.add(efcName);
                     return false;
                 }
             }
@@ -320,11 +330,42 @@ export class ScopeDataStructure {
             });
             entry.sourceCandidates = entry.sourceCandidates.filter((candidate) => {
                 const baseName = this.pathManager.stripGenerics(candidate.scopeNodeName);
+                // Check if this is a local variable path (doesn't contain function call pattern)
+                // Local variables like "surveys[]" or "items[]" are important for tracing data flow
+                // from parent to child components (e.g., surveys[] -> SurveyCard().signature[0].survey)
+                const isLocalVariablePath = !candidate.schemaPath.includes('()') &&
+                    !candidate.schemaPath.startsWith('signature[') &&
+                    !candidate.schemaPath.startsWith('returnValue');
                 return (validExternalFacingScopeNames.has(baseName) &&
                     (candidate.schemaPath.startsWith('signature[') ||
-                        candidate.schemaPath.startsWith(baseName)) &&
+                        candidate.schemaPath.startsWith(baseName) ||
+                        isLocalVariablePath) &&
                     !containsArrayMethod(candidate.schemaPath));
             });
+            // If all sourceCandidates were filtered out (e.g., because they belonged to
+            // internal functions like useState), look for the highest-order intermediate
+            // that belongs to a valid external-facing scope
+            if (entry.sourceCandidates.length === 0 &&
+                Object.keys(entry.intermediatesOrder).length > 0) {
+                // Find intermediates that belong to valid external-facing scopes
+                const validIntermediates = Object.entries(entry.intermediatesOrder)
+                    .filter(([pathId]) => {
+                    const [scopeNodeName, schemaPath] = pathId.split('::');
+                    if (!scopeNodeName || !schemaPath)
+                        return false;
+                    const baseName = this.pathManager.stripGenerics(scopeNodeName);
+                    return (validExternalFacingScopeNames.has(baseName) &&
+                        !containsArrayMethod(schemaPath));
+                })
+                    .sort((a, b) => b[1] - a[1]); // Sort by order descending (highest first)
+                if (validIntermediates.length > 0) {
+                    const [pathId] = validIntermediates[0];
+                    const [scopeNodeName, schemaPath] = pathId.split('::');
+                    if (scopeNodeName && schemaPath) {
+                        entry.sourceCandidates.push({ scopeNodeName, schemaPath });
+                    }
+                }
+            }
         }
         this.propagateSourceAndUsageEquivalencies(this.scopeNodes[this.scopeTreeManager.getRootName()]);
         for (const externalFunctionCall of this.externalFunctionCalls) {
@@ -583,13 +624,54 @@ export class ScopeDataStructure {
                 return;
             }
         }
+        // Skip self-referential equivalencies that would create infinite loops.
+        // Case 1: Direct self-reference (path === equivalentPath)
+        // FunctionCallManager adds equivalency(subPath, subPath, externalFunctionName, ...)
+        // For simple calls like buildBranchFileMap(), this is fine.
+        // But for chained calls like query.where().where().where(), each method call adds
+        // a .functionCallReturnValue segment, and the equivalency processing creates an infinite loop.
+        // We detect chained calls by counting .functionCallReturnValue occurrences in the path.
+        if (path === equivalentPath &&
+            equivalencyReason === 'equivalency to external function call') {
+            // Count how many .functionCallReturnValue segments are in the path
+            const functionCallReturnValueCount = (path.match(/\.functionCallReturnValue/g) || []).length;
+            // Skip if there are multiple chained calls (2+ .functionCallReturnValue segments)
+            if (functionCallReturnValueCount >= 2) {
+                return;
+            }
+        }
+        // Case 2: Circular reference where equivalentPath contains path as a prefix
+        // e.g., path="query" and equivalentPath="query.where(...).functionCallReturnValue"
+        // This happens with method chaining patterns where a variable is reassigned to
+        // the result of a method call on itself: query = query.where(...)
+        // Resolving this equivalency would require resolving query first, creating infinite recursion.
+        if (equivalentPath.startsWith(path + '.') ||
+            equivalentPath.startsWith(path + '(')) {
+            return;
+        }
         if (!equivalentScopeName) {
-            console.warn('Debug Propagation: missing equivalent scope name', {
+            console.error('CodeYam Error: Missing equivalent scope name - FULL CONTEXT:', JSON.stringify({
                 path,
                 equivalentPath,
                 equivalentScopeName,
                 scopeNodeName: scopeNode.name,
-            });
+                equivalencyReason,
+                tree: scopeNode.tree,
+                equivalencyValueChain: equivalencyValueChain?.map((ev) => ({
+                    id: ev.id,
+                    source: ev.source,
+                    reason: ev.reason,
+                    currentPath: ev.currentPath,
+                    previousPath: ev.previousPath,
+                })),
+                scopeNodeFunctionCalls: scopeNode.functionCalls?.map((fc) => ({
+                    name: fc.name,
+                    callSignature: fc.callSignature,
+                    callScope: fc.callScope,
+                })),
+                instantiatedVariables: scopeNode.instantiatedVariables,
+                parentInstantiatedVariables: scopeNode.parentInstantiatedVariables,
+            }, null, 2));
             throw new Error('CodeYam Error: Missing equivalent scope name');
         }
         (_a = scopeNode.equivalencies)[path] || (_a[path] = []);
@@ -712,10 +794,31 @@ export class ScopeDataStructure {
             const searchKey = getFunctionCallRoot(functionCallInfo.callSignature);
             const existingFunctionCall = this.getExternalFunctionCallsIndex().get(searchKey);
             if (existingFunctionCall) {
-                existingFunctionCall.schema = {
+                // Preserve per-call schemas BEFORE merging to enable per-variable mock data.
+                // This is critical for hooks like useFetcher<UserData>() vs useFetcher<ReportData>()
+                // where each call returns different typed data.
+                if (!existingFunctionCall.perCallSignatureSchemas) {
+                    // First merge - save the existing call's schema
+                    existingFunctionCall.perCallSignatureSchemas = {
+                        [existingFunctionCall.callSignature]: {
+                            ...existingFunctionCall.schema,
+                        },
+                    };
+                }
+                // Save the new call's schema before it gets merged
+                existingFunctionCall.perCallSignatureSchemas[functionCallInfo.callSignature] = { ...functionCallInfo.schema };
+                // Merge schemas using selectBestValue to preserve specific types like 'null'
+                // over generic types like 'unknown'. This ensures ref variables detected
+                // earlier (marked as 'null') aren't overwritten by later 'unknown' values.
+                const mergedSchema = {
                     ...existingFunctionCall.schema,
-                    ...functionCallInfo.schema,
                 };
+                for (const key in functionCallInfo.schema) {
+                    const existingValue = existingFunctionCall.schema[key];
+                    const newValue = functionCallInfo.schema[key];
+                    mergedSchema[key] = selectBestValue(existingValue, newValue, newValue);
+                }
+                existingFunctionCall.schema = mergedSchema;
                 existingFunctionCall.equivalencies = {
                     ...existingFunctionCall.equivalencies,
                     ...functionCallInfo.equivalencies,
@@ -735,8 +838,13 @@ export class ScopeDataStructure {
                 const isExternal = !callingScopeNode.instantiatedVariables?.includes(functionCallInfoNameParts[0]) &&
                     !callingScopeNode.parentInstantiatedVariables?.includes(functionCallInfoNameParts[0]);
                 if (isExternal) {
-                    this.externalFunctionCalls.push(functionCallInfo);
-                    this.invalidateExternalFunctionCallsIndex();
+                    // Check if this function was already filtered out as an internal function
+                    // (e.g., useState was filtered in captureCompleteSchema but finalize is trying to re-add it)
+                    const strippedName = this.pathManager.stripGenerics(functionCallInfo.name);
+                    if (!this.filteredInternalFunctions.has(strippedName)) {
+                        this.externalFunctionCalls.push(functionCallInfo);
+                        this.invalidateExternalFunctionCallsIndex();
+                    }
                 }
             }
         }
@@ -805,6 +913,17 @@ export class ScopeDataStructure {
                 const remainingKey = remainingSchemaPathParts.join('|');
                 const equivalentSchemaPath = equivalentSchemaPathMap.get(remainingKey);
                 if (equivalentSchemaPath) {
+                    // Skip propagation when there's a structural mismatch:
+                    // - schemaPath ends with [] (array element, represents an object)
+                    // - equivalentSchemaPath doesn't end with [] (non-array prop, usually a scalar)
+                    // This prevents incorrectly typing array elements as strings when they're
+                    // equivalent to scalar props like JSX keys (e.g., workouts[] ↔ Card().key)
+                    const schemaPathEndsWithArray = schemaPath.endsWith('[]');
+                    const equivalentEndsWithArray = equivalentSchemaPath.endsWith('[]');
+                    if (schemaPathEndsWithArray !== equivalentEndsWithArray) {
+                        // Don't propagate between array element paths and non-array paths
+                        continue;
+                    }
                     const value1 = scopeNode.schema[schemaPath];
                     const value2 = equivalentScopeNode.schema[equivalentSchemaPath];
                     const bestValue = selectBestValue(value1, value2);
@@ -846,6 +965,22 @@ export class ScopeDataStructure {
     joinPathParts(pathParts) {
         return this.pathManager.joinPathParts(pathParts);
     }
+    /**
+     * Extracts the root variable name from a path.
+     * E.g., "collected[]" -> "collected", "foo.bar" -> "foo", "collected[0]" -> "collected"
+     */
+    extractRootVariable(path) {
+        const parts = this.splitPath(path);
+        if (parts.length === 0)
+            return null;
+        const firstPart = parts[0];
+        // Strip array notation: "collected[]" -> "collected", "collected[0]" -> "collected"
+        const bracketIndex = firstPart.indexOf('[');
+        if (bracketIndex > 0) {
+            return firstPart.substring(0, bracketIndex);
+        }
+        return firstPart;
+    }
     // PRIVATE METHODS //
     uniqueId(params) {
         return uniqueId(params);
@@ -900,6 +1035,21 @@ export class ScopeDataStructure {
     }
     determineEquivalenciesAndBuildSchema(scopeNode) {
         const { isolatedStructure, isolatedEquivalentVariables } = scopeNode.analysis;
+        // DEBUG: Log all equivalencies related to useFetcher
+        if (Object.keys(isolatedEquivalentVariables || {}).some((k) => k.includes('Fetcher') || k.includes('fetcher'))) {
+            console.log('CodeYam DEBUG determineEquivalenciesAndBuildSchema:', JSON.stringify({
+                scopeNodeName: scopeNode.name,
+                fetcherEquivalencies: Object.entries(isolatedEquivalentVariables || {})
+                    .filter(([k, v]) => k.includes('Fetcher') ||
+                    k.includes('fetcher') ||
+                    String(v).includes('Fetcher') ||
+                    String(v).includes('fetcher'))
+                    .reduce((acc, [k, v]) => {
+                    acc[k] = v;
+                    return acc;
+                }, {}),
+            }, null, 2));
+        }
         const allPaths = Array.from(new Set([
             ...Object.keys(isolatedStructure || {}),
             ...Object.keys(isolatedEquivalentVariables || {}),
@@ -911,6 +1061,36 @@ export class ScopeDataStructure {
                 path = cleanPath(path.replace(/::cyDuplicateKey\d+::/g, ''), allPaths);
                 equivalentValue = cleanPath(equivalentValue.replace(/::cyDuplicateKey\d+::/g, ''), allPaths);
                 this.addEquivalency(path, equivalentValue, scopeNode.name, scopeNode, 'original equivalency');
+                // Propagate equivalencies involving parent-scope variables to those parent scopes.
+                // This handles patterns like: collected.push({...entity}) where 'collected' is defined
+                // in a parent scope. The equivalency collected[] -> push().signature[0] needs to be
+                // visible when tracing from the parent scope.
+                const rootVariable = this.extractRootVariable(path);
+                const equivalentRootVariable = this.extractRootVariable(equivalentValue);
+                // Skip propagation for self-referential reassignment patterns like:
+                //   x = x.method().functionCallReturnValue
+                // where the path IS the variable itself (not a sub-path like x[] or x.prop).
+                // These create circular references since both sides reference the same variable.
+                //
+                // But DO propagate for patterns like collected[] -> collected.push(...).signature[0]
+                // where the path has additional segments beyond the root variable.
+                const pathIsJustRootVariable = path === rootVariable;
+                const isSelfReferentialReassignment = pathIsJustRootVariable && rootVariable === equivalentRootVariable;
+                if (rootVariable &&
+                    !isSelfReferentialReassignment &&
+                    scopeNode.parentInstantiatedVariables?.includes(rootVariable)) {
+                    // Find the parent scope where this variable is defined
+                    for (const parentScopeName of scopeNode.tree || []) {
+                        const parentScope = this.scopeNodes[parentScopeName];
+                        if (parentScope?.instantiatedVariables?.includes(rootVariable)) {
+                            // Add the equivalency to the parent scope as well
+                            this.addEquivalency(path, equivalentValue, scopeNode.name, // The equivalent path's scope remains the child scope
+                            parentScope, // But store it in the parent scope's equivalencies
+                            'propagated parent-variable equivalency');
+                            break;
+                        }
+                    }
+                }
                 // Propagate sub-property equivalencies when the equivalentValue is a simple variable
                 // that has sub-properties defined in the isolatedEquivalentVariables.
                 // This handles cases like: dataItem={{ structure: completeDataStructure }}
@@ -956,6 +1136,14 @@ export class ScopeDataStructure {
                 // from the callback scope to the usage path
                 if (equivalentValue.endsWith('.functionCallReturnValue')) {
                     this.propagateFunctionCallReturnSubProperties(path, equivalentValue, scopeNode, allPaths);
+                    // Track which variable receives the return value of each function call
+                    // This enables generating separate mock data for each call site
+                    this.trackReceivingVariable(path, equivalentValue);
+                }
+                // Also track variables that receive destructured properties from function call return values
+                // e.g., "userData" -> "db.query('users').functionCallReturnValue.data"
+                if (equivalentValue.includes('.functionCallReturnValue.')) {
+                    this.trackReceivingVariable(path, equivalentValue);
                 }
             }
         }
@@ -1013,6 +1201,67 @@ export class ScopeDataStructure {
             });
         }
     }
+    /**
+     * Tracks which variable receives the return value of a function call.
+     *
+     * When we encounter an equivalency like:
+     *   result1 -> db.select(query1).functionCallReturnValue
+     *
+     * This method extracts the call signature (db.select(query1)) and maps it
+     * to the receiving variable (result1) on the corresponding FunctionCallInfo.
+     *
+     * This enables generating separate mock data for each call site when the same
+     * function is called multiple times with different arguments.
+     */
+    trackReceivingVariable(receivingVariable, equivalentValue) {
+        // Extract the call signature by finding the .functionCallReturnValue part
+        // and taking everything before it
+        // Handles both:
+        //   "db.select(query1).functionCallReturnValue" -> "db.select(query1)"
+        //   "db.query('users').functionCallReturnValue.data" -> "db.query('users')"
+        const funcReturnIdx = equivalentValue.indexOf('.functionCallReturnValue');
+        if (funcReturnIdx === -1) {
+            return;
+        }
+        const callSignature = equivalentValue.substring(0, funcReturnIdx);
+        // Skip if the receiving variable is not a simple identifier
+        // (e.g., skip if it's a path like "obj.property" or contains array access)
+        if (receivingVariable.includes('.') || receivingVariable.includes('[')) {
+            return;
+        }
+        // Find the FunctionCallInfo that matches this call signature
+        const searchKey = getFunctionCallRoot(callSignature);
+        const functionCallInfo = this.getExternalFunctionCallsIndex().get(searchKey);
+        // DEBUG: Track useFetcher calls
+        if (searchKey === 'useFetcher' || callSignature.includes('useFetcher')) {
+            console.log('CodeYam DEBUG trackReceivingVariable:', JSON.stringify({
+                receivingVariable,
+                equivalentValue,
+                callSignature,
+                searchKey,
+                foundFunctionCallInfo: !!functionCallInfo,
+                existingRecvVars: functionCallInfo?.receivingVariableNames,
+                existingCallSigToVar: functionCallInfo?.callSignatureToVariable,
+            }, null, 2));
+        }
+        if (!functionCallInfo) {
+            return;
+        }
+        // Initialize arrays if needed
+        if (!functionCallInfo.receivingVariableNames) {
+            functionCallInfo.receivingVariableNames = [];
+        }
+        if (!functionCallInfo.callSignatureToVariable) {
+            functionCallInfo.callSignatureToVariable = {};
+        }
+        // Add the receiving variable to the list (if not already present)
+        if (!functionCallInfo.receivingVariableNames.includes(receivingVariable)) {
+            functionCallInfo.receivingVariableNames.push(receivingVariable);
+        }
+        // Map the call signature to its receiving variable
+        // Use the full call signature (not the search key) for precise mapping
+        functionCallInfo.callSignatureToVariable[callSignature] = receivingVariable;
+    }
     /**
      * Propagates returnValue.* sub-properties from a callback scope to the usage path.
      *
@@ -1961,7 +2210,12 @@ export class ScopeDataStructure {
                 return acc;
             }, {});
         }
+        // CRITICAL: Set onlyEquivalencies to true to prevent database modifications
+        // during this "getter" method. See comment in getFunctionSignature.
+        const wasOnlyEquivalencies = this.onlyEquivalencies;
+        this.onlyEquivalencies = true;
         this.validateSchema(scopeNode, true, fillInUnknowns);
+        this.onlyEquivalencies = wasOnlyEquivalencies;
         const { schema } = scopeNode;
         // For root scope, merge in external function call schemas
         // This ensures that imported objects used as method call targets (like logger.error())
@@ -2058,11 +2312,12 @@ export class ScopeDataStructure {
             return acc;
         }, {});
         const equivalencies = this.getEquivalencies(functionName);
+        const scopeName = functionName ?? this.scopeTreeManager.getRootName();
         for (const equivalenceKey in equivalencies ?? {}) {
             for (const equivalenceValue of equivalencies[equivalenceKey]) {
                 const schemaPath = equivalenceValue.schemaPath;
                 if (schemaPath.startsWith('signature[') &&
-                    equivalenceValue.scopeNodeName === functionName &&
+                    equivalenceValue.scopeNodeName === scopeName &&
                     !signatureInSchema[schemaPath]) {
                     signatureInSchema[schemaPath] = 'unknown';
                 }
@@ -2070,9 +2325,60 @@ export class ScopeDataStructure {
         }
         const tempScopeNode = this.createTempScopeNode(functionName ?? this.scopeTreeManager.getRootName(), signatureInSchema, equivalencies);
         this.validateSchema(tempScopeNode, true, fillInUnknowns);
+        // After validateSchema has filled in types, propagate nested paths from
+        // variables to their signature equivalents.
+        // e.g., workouts[].activity_type -> signature[0].workouts[].activity_type
+        //
+        // Build a map of variable names that are equivalent to signature paths
+        // e.g., { 'workouts': 'signature[0].workouts' }
+        const variableToSignatureMap = {};
+        for (const equivalenceKey in equivalencies ?? {}) {
+            for (const equivalenceValue of equivalencies[equivalenceKey]) {
+                const schemaPath = equivalenceValue.schemaPath;
+                // Track which variables map to signature paths
+                // equivalenceKey is the variable name (e.g., 'workouts')
+                // schemaPath is where it comes from (e.g., 'signature[0].workouts')
+                if (schemaPath.startsWith('signature[') &&
+                    equivalenceValue.scopeNodeName === scopeName) {
+                    variableToSignatureMap[equivalenceKey] = schemaPath;
+                }
+            }
+        }
+        // Propagate nested paths from variables to their signature equivalents
+        // e.g., if workouts = signature[0].workouts, then workouts[].title becomes
+        // signature[0].workouts[].title
+        for (const schemaKey in schema) {
+            // Skip keys that already start with signature[
+            if (schemaKey.startsWith('signature['))
+                continue;
+            // Check if this key starts with a variable that maps to a signature path
+            for (const [variableName, signaturePath] of Object.entries(variableToSignatureMap)) {
+                // Check if schemaKey starts with variableName followed by a property accessor
+                // e.g., 'workouts[]' starts with 'workouts'
+                if (schemaKey === variableName ||
+                    schemaKey.startsWith(variableName + '.') ||
+                    schemaKey.startsWith(variableName + '[')) {
+                    // Transform the path: replace the variable prefix with the signature path
+                    const suffix = schemaKey.slice(variableName.length);
+                    const signatureKey = signaturePath + suffix;
+                    // Add to schema if not already present
+                    if (!tempScopeNode.schema[signatureKey]) {
+                        tempScopeNode.schema[signatureKey] = schema[schemaKey];
+                    }
+                }
+            }
+        }
         return tempScopeNode.schema;
     }
     getReturnValue({ functionName, fillInUnknowns, }) {
+        // Trigger finalization on all managers to apply any pending updates
+        // (e.g., ref type propagation to external function call schemas)
+        const rootScope = this.scopeNodes[this.scopeTreeManager.getRootName()];
+        if (rootScope) {
+            for (const manager of this.equivalencyManagers) {
+                manager.finalize(rootScope, this);
+            }
+        }
         const scopeName = functionName ?? this.scopeTreeManager.getRootName();
         const scopeNode = this.scopeNodes[scopeName];
         let schema = {};
@@ -2083,7 +2389,8 @@ export class ScopeDataStructure {
             });
         }
         else {
-            for (const externalFunctionCall of this.externalFunctionCalls) {
+            // Use getExternalFunctionCalls() which cleans cyScope from schemas
+            for (const externalFunctionCall of this.getExternalFunctionCalls()) {
                 const functionNameParts = this.splitPath(functionName).map((p) => this.functionOrScopeName(p));
                 const nameParts = this.splitPath(externalFunctionCall.name).map((p) => this.functionOrScopeName(p));
                 if (functionNameParts.every((part, index) => part === nameParts[index])) {
@@ -2119,12 +2426,19 @@ export class ScopeDataStructure {
         // Replace cyScope placeholders with actual callback text
         const resolvedSchema = this.replaceCyScopePlaceholders(returnValueSchema);
         const tempScopeNode = this.createTempScopeNode(scopeName, resolvedSchema);
+        // CRITICAL: Set onlyEquivalencies to true to prevent database modifications
+        // during this "getter" method. See comment in getFunctionSignature.
+        const wasOnlyEquivalencies = this.onlyEquivalencies;
+        this.onlyEquivalencies = true;
         this.validateSchema(tempScopeNode, true, fillInUnknowns);
+        this.onlyEquivalencies = wasOnlyEquivalencies;
         return tempScopeNode.schema;
     }
     /**
      * Replaces cyScope placeholder references (e.g., cyScope10()) in schema keys
      * with the actual callback function text from the corresponding scope node.
+     * If the scope text can't be found, uses a generic fallback to avoid leaking
+     * internal cyScope names into stored data.
      */
     replaceCyScopePlaceholders(schema) {
         const cyScopePattern = /cyScope(\d+)\(\)/g;
@@ -2136,10 +2450,10 @@ export class ScopeDataStructure {
             for (const match of matches) {
                 const cyScopeName = `cyScope${match[1]}`;
                 const scopeText = this.findCyScopeText(cyScopeName);
-                if (scopeText) {
-                    // Replace cyScope10() with the actual callback text
-                    newKey = newKey.replace(match[0], scopeText);
-                }
+                // Always replace cyScope references - use actual text if available,
+                // otherwise use a generic callback placeholder
+                const replacement = scopeText || '() => {}';
+                newKey = newKey.replace(match[0], replacement);
             }
             result[newKey] = value;
         }
@@ -2227,7 +2541,12 @@ export class ScopeDataStructure {
             return { ...acc, ...filterdSchema };
         }, {});
         const tempScopeNode = this.createTempScopeNode(scopeName ?? this.scopeTreeManager.getRootName(), relevantSchema);
+        // CRITICAL: Set onlyEquivalencies to true to prevent database modifications
+        // during this "getter" method. See comment in getFunctionSignature.
+        const wasOnlyEquivalencies = this.onlyEquivalencies;
+        this.onlyEquivalencies = true;
         this.validateSchema(tempScopeNode, true, final);
+        this.onlyEquivalencies = wasOnlyEquivalencies;
         return {
             name: variableName,
             equivalentTo: equivalents,
@@ -2235,7 +2554,96 @@ export class ScopeDataStructure {
         };
     }
     getExternalFunctionCalls() {
-        return this.externalFunctionCalls;
+        // Replace cyScope placeholders in all external function call data
+        // This ensures call signatures and schema paths use actual callback text
+        // instead of internal cyScope names, preventing mock data merge conflicts.
+        return this.externalFunctionCalls.map((efc) => this.cleanCyScopeFromFunctionCallInfo(efc));
+    }
+    /**
+     * Cleans cyScope placeholder references from a FunctionCallInfo.
+     * Replaces cyScopeN() with the actual callback text in:
+     * - callSignature
+     * - allCallSignatures
+     * - schema keys
+     */
+    cleanCyScopeFromFunctionCallInfo(efc) {
+        const cyScopePattern = /cyScope\d+\(\)/g;
+        // Check if any cleaning is needed
+        const hasCyScope = cyScopePattern.test(efc.callSignature) ||
+            (efc.allCallSignatures &&
+                efc.allCallSignatures.some((sig) => /cyScope\d+\(\)/.test(sig))) ||
+            (efc.schema &&
+                Object.keys(efc.schema).some((key) => /cyScope\d+\(\)/.test(key)));
+        if (!hasCyScope) {
+            return efc;
+        }
+        // Create cleaned copy
+        const cleaned = { ...efc };
+        // Clean callSignature
+        cleaned.callSignature = this.replaceCyScopeInString(efc.callSignature);
+        // Clean allCallSignatures
+        if (efc.allCallSignatures) {
+            cleaned.allCallSignatures = efc.allCallSignatures.map((sig) => this.replaceCyScopeInString(sig));
+        }
+        // Clean schema keys
+        if (efc.schema) {
+            cleaned.schema = this.replaceCyScopePlaceholders(efc.schema);
+        }
+        // Clean callSignatureToVariable keys
+        if (efc.callSignatureToVariable) {
+            cleaned.callSignatureToVariable = Object.entries(efc.callSignatureToVariable).reduce((acc, [key, value]) => {
+                acc[this.replaceCyScopeInString(key)] = value;
+                return acc;
+            }, {});
+        }
+        return cleaned;
+    }
+    /**
+     * Replaces cyScope placeholder references in a single string.
+     * If the scope text can't be found, uses a generic fallback to avoid leaking
+     * internal cyScope names into stored data.
+     *
+     * Handles two patterns:
+     * 1. Function call style: cyScope7() - matched by cyScope(\d+)\(\)
+     * 2. Scope name style: parentName____cyScopeXX or cyScopeXX - matched by (\w+____)?cyScope([0-9A-Fa-f]+)
+     */
+    replaceCyScopeInString(str) {
+        let result = str;
+        // Pattern 1: Function call style - cyScope7()
+        const functionCallPattern = /cyScope(\d+)\(\)/g;
+        const functionCallMatches = [...str.matchAll(functionCallPattern)];
+        for (const match of functionCallMatches) {
+            const cyScopeName = `cyScope${match[1]}`;
+            const scopeText = this.findCyScopeText(cyScopeName);
+            // Always replace cyScope references - use actual text if available,
+            // otherwise use a generic callback placeholder
+            const replacement = scopeText || '() => {}';
+            result = result.replace(match[0], replacement);
+        }
+        // Pattern 2: Scope name style - parentName____cyScopeXX or just cyScopeXX
+        // This handles hex-encoded scope IDs like cyScope1F
+        const scopeNamePattern = /(\w+____)?cyScope([0-9A-Fa-f]+)/g;
+        const scopeNameMatches = [...result.matchAll(scopeNamePattern)];
+        for (const match of scopeNameMatches) {
+            const fullMatch = match[0];
+            const prefix = match[1] || ''; // e.g., "getTitleColor____"
+            const cyScopeId = match[2]; // e.g., "1F"
+            const cyScopeName = `cyScope${cyScopeId}`;
+            // Try to find the scope text, checking both with and without prefix
+            let scopeText = this.findCyScopeText(cyScopeName);
+            if (!scopeText && prefix) {
+                // Try looking up with the full prefixed name
+                scopeText = this.findCyScopeText(`${prefix}${cyScopeName}`);
+            }
+            if (scopeText) {
+                result = result.replace(fullMatch, scopeText);
+            }
+            else {
+                // Replace with a generic identifier to avoid leaking internal names
+                result = result.replace(fullMatch, 'callback');
+            }
+        }
+        return result;
     }
     getEnvironmentVariables() {
         return this.environmentVariables;
@@ -2285,48 +2693,356 @@ export class ScopeDataStructure {
         return enriched;
     }
     toSerializable() {
-        // Helper to convert ScopeVariable to SerializableScopeVariable
+        // Helper to clean cyScope from a string
+        const cleanCyScope = (str) => this.replaceCyScopeInString(str);
+        // Helper to convert ScopeVariable to SerializableScopeVariable (with cyScope cleaned)
         const toSerializableVariable = (vars) => vars.map((v) => ({
-            scopeNodeName: v.scopeNodeName,
-            schemaPath: v.schemaPath,
+            scopeNodeName: cleanCyScope(v.scopeNodeName),
+            schemaPath: cleanCyScope(v.schemaPath),
         }));
+        // Helper to clean cyScope from all keys in a schema
+        const cleanSchemaKeys = (schema) => {
+            return Object.entries(schema).reduce((acc, [key, value]) => {
+                acc[cleanCyScope(key)] = value;
+                return acc;
+            }, {});
+        };
         // Helper to get function result for a given function name
         const getFunctionResult = (functionName) => {
             return {
-                signature: this.getFunctionSignature({ functionName }) ?? {},
-                signatureWithUnknowns: this.getFunctionSignature({ functionName, fillInUnknowns: true }) ??
-                    {},
-                returnValue: this.getReturnValue({ functionName }) ?? {},
-                returnValueWithUnknowns: this.getReturnValue({ functionName, fillInUnknowns: true }) ?? {},
+                signature: cleanSchemaKeys(this.getFunctionSignature({ functionName }) ?? {}),
+                signatureWithUnknowns: cleanSchemaKeys(this.getFunctionSignature({ functionName, fillInUnknowns: true }) ??
+                    {}),
+                returnValue: cleanSchemaKeys(this.getReturnValue({ functionName }) ?? {}),
+                returnValueWithUnknowns: cleanSchemaKeys(this.getReturnValue({ functionName, fillInUnknowns: true }) ?? {}),
                 usageEquivalencies: Object.entries(this.getUsageEquivalencies(functionName) ?? {}).reduce((acc, [key, vars]) => {
-                    acc[key] = toSerializableVariable(vars);
+                    // Clean cyScope from the key as well as variable properties
+                    acc[cleanCyScope(key)] = toSerializableVariable(vars);
                     return acc;
                 }, {}),
                 sourceEquivalencies: Object.entries(this.getSourceEquivalencies(functionName) ?? {}).reduce((acc, [key, vars]) => {
-                    acc[key] = toSerializableVariable(vars);
+                    // Clean cyScope from the key as well as variable properties
+                    acc[cleanCyScope(key)] = toSerializableVariable(vars);
                     return acc;
                 }, {}),
                 environmentVariables: this.getEnvironmentVariables(),
             };
         };
-        // Convert external function calls
-        const externalFunctionCalls = this.externalFunctionCalls.map((efc) => ({
-            name: efc.name,
-            callSignature: efc.callSignature,
-            callScope: efc.callScope,
-            schema: efc.schema,
-            equivalencies: efc.equivalencies
-                ? Object.entries(efc.equivalencies).reduce((acc, [key, vars]) => {
-                    acc[key] = toSerializableVariable(vars);
-                    return acc;
-                }, {})
-                : undefined,
-        }));
+        // Convert external function calls - use getExternalFunctionCalls() which cleans cyScope
+        const cleanedExternalCalls = this.getExternalFunctionCalls();
+        // Get root scope schema for building per-variable return value schemas
+        const rootScopeName = this.scopeTreeManager.getRootName();
+        const rootScope = this.scopeNodes[rootScopeName];
+        const rootSchema = rootScope?.schema ?? {};
+        const externalFunctionCalls = cleanedExternalCalls.map((efc) => {
+            // Build perVariableSchemas from perCallSignatureSchemas when available.
+            // This preserves distinct schemas per variable when the same function is called
+            // multiple times with DIFFERENT call signatures (e.g., different type parameters).
+            //
+            // When field accesses happen in child scopes (like JSX expressions), the
+            // rootSchema doesn't contain the detailed paths - they end up in child scope
+            // schemas. Using perCallSignatureSchemas ensures we get the correct schema
+            // for each call, regardless of where field accesses occur.
+            let perVariableSchemas;
+            // Use perCallSignatureSchemas only when:
+            // 1. It exists and has distinct entries for different call signatures
+            // 2. The number of distinct call signatures >= number of receiving variables
+            //
+            // This prevents using it when all calls have the same signature (e.g., useFetcher() x 2)
+            // because in that case, perCallSignatureSchemas only has one entry.
+            const numCallSignatures = efc.perCallSignatureSchemas
+                ? Object.keys(efc.perCallSignatureSchemas).length
+                : 0;
+            const numReceivingVars = efc.receivingVariableNames?.length ?? 0;
+            const hasDistinctSchemas = numCallSignatures >= numReceivingVars && numCallSignatures > 1;
+            // CASE 1: Multiple call signatures with distinct schemas - use indexed variable names
+            if (hasDistinctSchemas &&
+                efc.perCallSignatureSchemas &&
+                efc.callSignatureToVariable) {
+                perVariableSchemas = {};
+                // Build a reverse map: variable -> array of call signatures (in order)
+                // This handles the case where the same variable name is reused for different calls
+                const varToCallSigs = {};
+                for (const [callSig, varName] of Object.entries(efc.callSignatureToVariable)) {
+                    if (!varToCallSigs[varName]) {
+                        varToCallSigs[varName] = [];
+                    }
+                    varToCallSigs[varName].push(callSig);
+                }
+                // Track how many times each variable name has been seen
+                const varNameCounts = {};
+                // For each receiving variable, get its original schema from perCallSignatureSchemas
+                for (const varName of efc.receivingVariableNames ?? []) {
+                    const occurrence = varNameCounts[varName] ?? 0;
+                    varNameCounts[varName] = occurrence + 1;
+                    const callSigs = varToCallSigs[varName];
+                    // Use the nth call signature for the nth occurrence of this variable
+                    const callSig = callSigs?.[occurrence];
+                    if (callSig && efc.perCallSignatureSchemas[callSig]) {
+                        // Use indexed key if this variable name is reused (e.g., fetcher, fetcher[1])
+                        const key = occurrence === 0 ? varName : `${varName}[${occurrence}]`;
+                        // Clone the schema to avoid shared references
+                        perVariableSchemas[key] = {
+                            ...efc.perCallSignatureSchemas[callSig],
+                        };
+                    }
+                }
+                // Only include if we have entries for ALL receiving variables
+                if (Object.keys(perVariableSchemas).length < numReceivingVars) {
+                    // Not all variables have schemas - fall back to rootSchema extraction
+                    perVariableSchemas = undefined;
+                }
+                else {
+                    // Also check that at least one schema is non-empty
+                    // Bug fix: perCallSignatureSchemas may have entries but with empty schemas {}
+                    // In this case, we should fall through to Fallback which uses rootSchema
+                    const hasNonEmptySchema = Object.values(perVariableSchemas).some((schema) => Object.keys(schema).length > 0);
+                    if (!hasNonEmptySchema) {
+                        perVariableSchemas = undefined;
+                    }
+                }
+            }
+            // CASE 2: Single call signature with single variable - use perCallSignatureSchemas directly
+            // This handles parameterized calls like useFetcher<ConfigData>() where each is a separate efc entry
+            if (!perVariableSchemas &&
+                efc.perCallSignatureSchemas &&
+                numCallSignatures === 1 &&
+                numReceivingVars === 1) {
+                const varName = efc.receivingVariableNames[0];
+                const callSig = Object.keys(efc.perCallSignatureSchemas)[0];
+                const schema = efc.perCallSignatureSchemas[callSig];
+                if (schema && Object.keys(schema).length > 0) {
+                    perVariableSchemas = { [varName]: { ...schema } };
+                }
+            }
+            // CASE 3: Extract from efc.schema when perCallSignatureSchemas is missing or empty
+            // This handles two scenarios:
+            // 1. Parameterized calls that create SEPARATE efc entries (no perCallSignatureSchemas)
+            // 2. Destructuring where perCallSignatureSchemas exists but has EMPTY schemas
+            //
+            // When useFetcher<ConfigData>() and useFetcher<SettingsData>() are called, they create separate
+            // efc entries because getFunctionCallRoot preserves type parameters. Each entry has its own
+            // `schema` field, but due to variable reassignment, the schema may be contaminated with paths
+            // from other calls (the tracer attributes field accesses to ALL equivalencies).
+            //
+            // Solution: Filter efc.schema to only include paths that match THIS entry's call signature.
+            // The schema paths include the full call signature prefix, so we can filter by it.
+            //
+            // Example: ConfigData entry has paths like:
+            //   "useFetcher<{ data: ConfigData | null }>().functionCallReturnValue.data.data.theme"
+            // But also (contaminated):
+            //   "useFetcher<{ data: ConfigData | null }>().functionCallReturnValue.data.data.notifications"
+            //
+            // We filter to only keep paths that should belong to THIS call by checking if the
+            // receiving variable's equivalency points to this call's return value.
+            //
+            // BUG FIX: The old condition `!efc.perCallSignatureSchemas` was FALSE when the object
+            // existed (even with empty schemas), causing this case to be skipped. We now also check
+            // if all schemas in perCallSignatureSchemas are empty.
+            const hasNonEmptyPerCallSignatureSchemas = efc.perCallSignatureSchemas &&
+                Object.values(efc.perCallSignatureSchemas).some((schema) => Object.keys(schema).length > 0);
+            // Build the call signature prefix that paths should start with
+            const callSigPrefix = `${efc.callSignature}.functionCallReturnValue`;
+            // Check if efc.schema has variable-specific paths (indicating destructuring).
+            // Destructuring: const { entities, gitStatus } = useLoaderData()
+            // - efc.schema has paths like: useLoaderData().functionCallReturnValue.entities...
+            // Multiple calls: const x = useFetcher(); const y = useFetcher();
+            // - efc.schema has paths like: useFetcher().functionCallReturnValue.data...
+            // CASE 3 should only run for destructuring (variable-specific paths exist).
+            const hasVariableSpecificPaths = (efc.receivingVariableNames ?? []).some((varName) => Object.keys(efc.schema).some((path) => path.startsWith(`${callSigPrefix}.${varName}`)));
+            if (!perVariableSchemas &&
+                !hasNonEmptyPerCallSignatureSchemas &&
+                numReceivingVars >= 1 &&
+                hasVariableSpecificPaths) {
+                // Filter efc.schema to only include paths matching this call signature
+                const filteredSchema = {};
+                for (const [path, type] of Object.entries(efc.schema)) {
+                    if (path.startsWith(callSigPrefix) || path === efc.callSignature) {
+                        filteredSchema[path] = type;
+                    }
+                }
+                // Build perVariableSchemas from the filtered schema
+                // For destructuring, filter paths by variable name
+                if (Object.keys(filteredSchema).length > 0) {
+                    perVariableSchemas = {};
+                    for (const varName of efc.receivingVariableNames ?? []) {
+                        // For destructuring, extract only paths specific to this variable
+                        const varSpecificPrefix = `${callSigPrefix}.${varName}`;
+                        const varSchema = {};
+                        for (const [path, type] of Object.entries(filteredSchema)) {
+                            if (path.startsWith(varSpecificPrefix)) {
+                                // Transform: useLoaderData().functionCallReturnValue.entities.sha
+                                //         -> functionCallReturnValue.entities.sha (keep the variable name)
+                                const suffix = path.slice(callSigPrefix.length);
+                                const returnValuePath = `functionCallReturnValue${suffix}`;
+                                varSchema[returnValuePath] = type;
+                            }
+                            else if (path === efc.callSignature) {
+                                // Include the function call type itself
+                                varSchema[path] = type;
+                            }
+                        }
+                        if (Object.keys(varSchema).length > 0) {
+                            perVariableSchemas[varName] = varSchema;
+                        }
+                    }
+                    // Only include if we have entries
+                    if (Object.keys(perVariableSchemas).length === 0) {
+                        perVariableSchemas = undefined;
+                    }
+                }
+            }
+            // Fallback: extract from root scope schema when perCallSignatureSchemas is not available
+            // or doesn't have distinct entries for each variable.
+            // This works when field accesses are in the root scope.
+            if (!perVariableSchemas &&
+                efc.receivingVariableNames &&
+                efc.receivingVariableNames.length > 0) {
+                perVariableSchemas = {};
+                for (const varName of efc.receivingVariableNames) {
+                    const varSchema = {};
+                    for (const [path, type] of Object.entries(rootSchema)) {
+                        // Check if path starts with this variable name
+                        if (path === varName ||
+                            path.startsWith(varName + '.') ||
+                            path.startsWith(varName + '[')) {
+                            // Transform to functionCallReturnValue format
+                            // e.g., userFetcher.data.id -> functionCallReturnValue.data.id
+                            const suffix = path.slice(varName.length);
+                            const returnValuePath = `functionCallReturnValue${suffix}`;
+                            varSchema[returnValuePath] = type;
+                        }
+                    }
+                    if (Object.keys(varSchema).length > 0) {
+                        perVariableSchemas[varName] = varSchema;
+                    }
+                }
+                // Only include if we have any entries
+                if (Object.keys(perVariableSchemas).length === 0) {
+                    perVariableSchemas = undefined;
+                }
+            }
+            return {
+                name: efc.name,
+                callSignature: efc.callSignature,
+                callScope: efc.callScope,
+                schema: efc.schema,
+                equivalencies: efc.equivalencies
+                    ? Object.entries(efc.equivalencies).reduce((acc, [key, vars]) => {
+                        // Clean cyScope from the key as well as variable properties
+                        acc[cleanCyScope(key)] = toSerializableVariable(vars);
+                        return acc;
+                    }, {})
+                    : undefined,
+                allCallSignatures: efc.allCallSignatures,
+                receivingVariableNames: efc.receivingVariableNames,
+                callSignatureToVariable: efc.callSignatureToVariable,
+                perVariableSchemas,
+            };
+        });
+        // POST-PROCESSING: Deduplicate schemas across parameterized calls to same base function
+        // When useFetcher<ConfigData>() and useFetcher<SettingsData>() are called, they create
+        // separate entries. Due to variable reassignment, BOTH entries may have ALL fields.
+        // We deduplicate by assigning each field to ONLY ONE entry based on order of appearance.
+        //
+        // Strategy: Fields that appear first in order belong to the first entry,
+        // fields that appear later belong to later entries (split evenly).
+        const deduplicateParameterizedEntries = (entries) => {
+            // Group entries by base function name (without type parameters)
+            const groups = new Map();
+            for (const entry of entries) {
+                // Extract base function name by stripping type parameters
+                // e.g., "useFetcher<{ data: ConfigData | null }>" -> "useFetcher"
+                const baseName = entry.name.replace(/<.*>$/, '');
+                const group = groups.get(baseName) || [];
+                group.push(entry);
+                groups.set(baseName, group);
+            }
+            // Process groups with multiple parameterized entries
+            for (const [, group] of groups) {
+                if (group.length <= 1)
+                    continue;
+                // Check if these are parameterized calls (have type parameters in name)
+                const hasTypeParams = group.every((e) => e.name.includes('<'));
+                if (!hasTypeParams)
+                    continue;
+                // Collect ALL unique field suffixes across all entries (in order of first appearance)
+                // Field suffix is the path after functionCallReturnValue, e.g., ".data.data.theme"
+                const allFieldSuffixes = [];
+                for (const entry of group) {
+                    if (!entry.perVariableSchemas)
+                        continue;
+                    for (const varSchema of Object.values(entry.perVariableSchemas)) {
+                        for (const path of Object.keys(varSchema)) {
+                            // Skip the base "functionCallReturnValue" entry
+                            if (path === 'functionCallReturnValue')
+                                continue;
+                            // Extract field suffix
+                            const match = path.match(/functionCallReturnValue(.+)/);
+                            if (!match)
+                                continue;
+                            const fieldSuffix = match[1];
+                            if (!allFieldSuffixes.includes(fieldSuffix)) {
+                                allFieldSuffixes.push(fieldSuffix);
+                            }
+                        }
+                    }
+                }
+                // Assign fields to entries: split evenly based on order
+                // First N/2 fields go to first entry, remaining go to second entry
+                const fieldToEntryMap = new Map();
+                const fieldsPerEntry = Math.ceil(allFieldSuffixes.length / group.length);
+                for (let i = 0; i < allFieldSuffixes.length; i++) {
+                    const fieldSuffix = allFieldSuffixes[i];
+                    const entryIdx = Math.min(Math.floor(i / fieldsPerEntry), group.length - 1);
+                    fieldToEntryMap.set(fieldSuffix, entryIdx);
+                }
+                // Filter each entry's perVariableSchemas to only include its assigned fields
+                for (let i = 0; i < group.length; i++) {
+                    const entry = group[i];
+                    if (!entry.perVariableSchemas)
+                        continue;
+                    const filteredPerVarSchemas = {};
+                    for (const [varName, varSchema] of Object.entries(entry.perVariableSchemas)) {
+                        const filteredVarSchema = {};
+                        for (const [path, type] of Object.entries(varSchema)) {
+                            // Always keep the base functionCallReturnValue
+                            if (path === 'functionCallReturnValue') {
+                                filteredVarSchema[path] = type;
+                                continue;
+                            }
+                            // Extract field suffix
+                            const match = path.match(/functionCallReturnValue(.+)/);
+                            if (!match) {
+                                // Keep non-field paths
+                                filteredVarSchema[path] = type;
+                                continue;
+                            }
+                            const fieldSuffix = match[1];
+                            // Only include if this entry owns this field
+                            if (fieldToEntryMap.get(fieldSuffix) === i) {
+                                filteredVarSchema[path] = type;
+                            }
+                        }
+                        if (Object.keys(filteredVarSchema).length > 0) {
+                            filteredPerVarSchemas[varName] = filteredVarSchema;
+                        }
+                    }
+                    entry.perVariableSchemas =
+                        Object.keys(filteredPerVarSchemas).length > 0
+                            ? filteredPerVarSchemas
+                            : undefined;
+                }
+            }
+            return entries;
+        };
+        // Apply deduplication
+        const deduplicatedExternalFunctionCalls = deduplicateParameterizedEntries(externalFunctionCalls);
         // Get root function result
         const rootFunction = getFunctionResult();
-        // Get results for each external function
+        // Get results for each external function (use cleaned calls for consistency)
         const functionResults = {};
-        for (const efc of this.externalFunctionCalls) {
+        for (const efc of cleanedExternalCalls) {
             functionResults[efc.name] = getFunctionResult(efc.name);
         }
         // Get equivalent signature variables
@@ -2338,7 +3054,7 @@ export class ScopeDataStructure {
             ? enrichedConditionalUsages
             : undefined;
         return {
-            externalFunctionCalls,
+            externalFunctionCalls: deduplicatedExternalFunctionCalls,
             rootFunction,
             functionResults,
             equivalentSignatureVariables,