@codeyam/codeyam-cli 0.1.0-staging.b8b17a5 → 0.1.0-staging.ba3f279

package/codeyam-cli/src/utils/__tests__/editorAudit.test.js

@@ -1,6 +1,6 @@
 import Database from 'better-sqlite3';
 import { Kysely, SqliteDialect } from 'kysely';
-import { isComponent, classifyGlossaryEntries, computeAudit, filterGlossaryByChangeStatus, resolveAuditSessionScope, queryScenarioCounts, queryIncompleteEntities, queryMiscategorizedScenarios, isOnlyIncompleteEntities, isAutoRemediable, } from "../editorAudit.js";
+import { isComponent, classifyGlossaryEntries, computeAudit, filterGlossaryByChangeStatus, resolveAuditSessionScope, queryScenarioCounts, queryPageScenarioCounts, queryIncompleteEntities, queryMiscategorizedScenarios, queryUnassociatedScenarios, isOnlyIncompleteEntities, isOnlyPreExistingIncomplete, isAutoRemediable, identifyScenariosNeedingRecapture, detectDuplicateNames, aggregateClientErrorsByComponent, determineTargetedAnalysisPaths, shouldAutoRecapture, } from "../editorAudit.js";
 describe('editorAudit', () => {
     describe('isComponent', () => {
         it('should return true for JSX.Element return type', () => {
@@ -29,6 +29,16 @@ describe('editorAudit', () => {
         it('should return false when returnType is empty string', () => {
             expect(isComponent({ returnType: '' })).toBe(false);
         });
+        it('should return true for page files (index.tsx) even without returnType', () => {
+            expect(isComponent({ filePath: 'app/(tabs)/index.tsx' })).toBe(true);
+        });
+        it('should return true for page.tsx files even without returnType', () => {
+            expect(isComponent({ filePath: 'app/dashboard/page.tsx' })).toBe(true);
+        });
+        it('should return false for non-page files without returnType', () => {
+            expect(isComponent({ filePath: 'app/hooks/useCounter.ts' })).toBe(false);
+            expect(isComponent({ filePath: 'lib/storage.ts' })).toBe(false);
+        });
     });
     describe('classifyGlossaryEntries', () => {
         it('should classify entries with JSX return types as components', () => {
@@ -1006,6 +1016,158 @@ describe('editorAudit', () => {
             expect(counts).toEqual({ ArticleCard: 1, ArticleRow: 1 });
         });
     });
+    // ── queryPageScenarioCounts ──────────────────────────────────────────
+    describe('queryPageScenarioCounts', () => {
+        let db;
+        let rawDb;
+        const projectId = 'test-project-id';
+        beforeEach(async () => {
+            rawDb = new Database(':memory:');
+            db = new Kysely({ dialect: new SqliteDialect({ database: rawDb }) });
+            await db.schema
+                .createTable('editor_scenarios')
+                .addColumn('id', 'varchar', (col) => col.primaryKey())
+                .addColumn('project_id', 'varchar', (col) => col.notNull())
+                .addColumn('name', 'varchar', (col) => col.notNull())
+                .addColumn('description', 'text')
+                .addColumn('component_name', 'varchar')
+                .addColumn('component_path', 'varchar')
+                .addColumn('page_file_path', 'varchar')
+                .addColumn('url', 'varchar')
+                .addColumn('type', 'varchar')
+                .addColumn('screenshot_path', 'varchar')
+                .addColumn('viewport_width', 'integer')
+                .addColumn('viewport_height', 'integer')
+                .addColumn('dimension', 'varchar')
+                .addColumn('created_at', 'datetime')
+                .addColumn('updated_at', 'datetime')
+                .execute();
+        });
+        afterEach(async () => {
+            await db.destroy();
+        });
+        it('should count app-level scenarios by page_file_path', async () => {
+            // App-level scenario: has page_file_path but no component_name
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'Library - Default',
+                component_name: null,
+                page_file_path: 'app/library/page.tsx',
+                created_at: '2026-03-12 13:00:00',
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-2',
+                project_id: projectId,
+                name: 'Library - Empty',
+                component_name: null,
+                page_file_path: 'app/library/page.tsx',
+                created_at: '2026-03-12 13:05:00',
+            })
+                .execute();
+            const counts = await queryPageScenarioCounts(db, projectId, null);
+            expect(counts).toEqual({ 'app/library/page.tsx': 2 });
+        });
+        it('should not count component scenarios (those have component_name)', async () => {
+            // Component scenario — should NOT appear in page counts
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'ArticleRow - Default',
+                component_name: 'ArticleRow',
+                page_file_path: null,
+                created_at: '2026-03-12 13:00:00',
+            })
+                .execute();
+            const counts = await queryPageScenarioCounts(db, projectId, null);
+            expect(counts).toEqual({});
+        });
+        it('should respect featureStartedAt filter', async () => {
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'Library - Old',
+                component_name: null,
+                page_file_path: 'app/library/page.tsx',
+                created_at: '2026-03-12 13:00:00',
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-2',
+                project_id: projectId,
+                name: 'Library - New',
+                component_name: null,
+                page_file_path: 'app/library/page.tsx',
+                created_at: '2026-03-12 15:00:00',
+            })
+                .execute();
+            const counts = await queryPageScenarioCounts(db, projectId, '2026-03-12T14:01:31.291Z');
+            expect(counts).toEqual({ 'app/library/page.tsx': 1 });
+        });
+        it('should count re-registered page scenarios via updated_at', async () => {
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'Library - Default',
+                component_name: null,
+                page_file_path: 'app/library/page.tsx',
+                created_at: '2026-03-12 13:00:00',
+                updated_at: '2026-03-12 15:00:00',
+            })
+                .execute();
+            const counts = await queryPageScenarioCounts(db, projectId, '2026-03-12T14:01:31.291Z');
+            expect(counts).toEqual({ 'app/library/page.tsx': 1 });
+        });
+        it('should group counts by page_file_path across multiple pages', async () => {
+            await db
+                .insertInto('editor_scenarios')
+                .values([
+                {
+                    id: 'sc-1',
+                    project_id: projectId,
+                    name: 'Library - Default',
+                    component_name: null,
+                    page_file_path: 'app/library/page.tsx',
+                    created_at: '2026-03-12 13:00:00',
+                },
+                {
+                    id: 'sc-2',
+                    project_id: projectId,
+                    name: 'Library - Rich',
+                    component_name: null,
+                    page_file_path: 'app/library/page.tsx',
+                    created_at: '2026-03-12 13:00:00',
+                },
+                {
+                    id: 'sc-3',
+                    project_id: projectId,
+                    name: 'Collections - Default',
+                    component_name: null,
+                    page_file_path: 'app/library/collections/page.tsx',
+                    created_at: '2026-03-12 13:00:00',
+                },
+            ])
+                .execute();
+            const counts = await queryPageScenarioCounts(db, projectId, null);
+            expect(counts).toEqual({
+                'app/library/page.tsx': 2,
+                'app/library/collections/page.tsx': 1,
+            });
+        });
+    });
     // ── Audit + entity completeness integration ─────────────────────────
     describe('audit should catch incomplete entities (bug reproduction)', () => {
         let db;
@@ -1314,8 +1476,146 @@ describe('editorAudit', () => {
             expect(auditResult.summary.incompleteEntities).toBeUndefined();
         });
     });
-    // ── queryMiscategorizedScenarios ─────────────────────────────────────
-    describe('queryMiscategorizedScenarios', () => {
+    // ── filterToIncompleteFilePaths ──────────────────────────────────────
+    describe('filterToIncompleteFilePaths', () => {
+        // analyze-imports processes ALL file paths (~120 files) even when only
+        // a few need analysis. This function filters to files that have no
+        // entity with an analysis record.
+        let db;
+        let rawDb;
+        const projectId = 'test-project-id';
+        beforeEach(async () => {
+            rawDb = new Database(':memory:');
+            db = new Kysely({ dialect: new SqliteDialect({ database: rawDb }) });
+            await db.schema
+                .createTable('analyses')
+                .addColumn('id', 'varchar', (col) => col.primaryKey())
+                .addColumn('entity_sha', 'varchar')
+                .addColumn('entity_name', 'varchar')
+                .addColumn('project_id', 'varchar')
+                .execute();
+            await db.schema
+                .createTable('entities')
+                .addColumn('sha', 'varchar', (col) => col.primaryKey())
+                .addColumn('name', 'varchar')
+                .addColumn('entity_type', 'varchar')
+                .addColumn('file_path', 'varchar')
+                .execute();
+        });
+        afterEach(async () => {
+            await db.destroy();
+        });
+        it('should exclude files that have an entity with an analysis', async () => {
+            const { filterToIncompleteFilePaths } = require('../editorAudit');
+            // Entity with analysis — skip
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-header',
+                name: 'Header',
+                entity_type: 'visual',
+                file_path: 'app/components/Header.tsx',
+            })
+                .execute();
+            await db
+                .insertInto('analyses')
+                .values({
+                id: 'a-1',
+                entity_sha: 'sha-header',
+                entity_name: 'Header',
+                project_id: projectId,
+            })
+                .execute();
+            // Entity without analysis — needs analysis
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-rule',
+                name: 'RuleBuilder',
+                entity_type: 'visual',
+                file_path: 'app/components/RuleBuilder.tsx',
+            })
+                .execute();
+            const allFilePaths = [
+                'app/components/Header.tsx',
+                'app/components/RuleBuilder.tsx',
+                'app/components/Footer.tsx', // no entity — needs analysis
+            ];
+            const result = await filterToIncompleteFilePaths(db, projectId, allFilePaths);
+            expect(result).toContain('app/components/RuleBuilder.tsx');
+            expect(result).toContain('app/components/Footer.tsx');
+            expect(result).not.toContain('app/components/Header.tsx');
+        });
+        it('should return all file paths when no entities exist yet', async () => {
+            const { filterToIncompleteFilePaths } = require('../editorAudit');
+            const filePaths = ['app/Foo.tsx', 'app/Bar.tsx'];
+            const result = await filterToIncompleteFilePaths(db, projectId, filePaths);
+            expect(result).toEqual(filePaths);
+        });
+        it('should return empty when all files have analyzed entities', async () => {
+            const { filterToIncompleteFilePaths } = require('../editorAudit');
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-a',
+                name: 'CompA',
+                entity_type: 'visual',
+                file_path: 'app/CompA.tsx',
+            })
+                .execute();
+            await db
+                .insertInto('analyses')
+                .values({
+                id: 'a-1',
+                entity_sha: 'sha-a',
+                entity_name: 'CompA',
+                project_id: projectId,
+            })
+                .execute();
+            const result = await filterToIncompleteFilePaths(db, projectId, [
+                'app/CompA.tsx',
+            ]);
+            expect(result).toEqual([]);
+        });
+        it('should skip files with analysis even without scenarios', async () => {
+            const { filterToIncompleteFilePaths } = require('../editorAudit');
+            // Entity with analysis but NO scenarios — still complete
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-util',
+                name: 'utils',
+                entity_type: 'library',
+                file_path: 'app/lib/utils.ts',
+            })
+                .execute();
+            await db
+                .insertInto('analyses')
+                .values({
+                id: 'a-1',
+                entity_sha: 'sha-util',
+                entity_name: 'utils',
+                project_id: projectId,
+            })
+                .execute();
+            const result = await filterToIncompleteFilePaths(db, projectId, [
+                'app/lib/utils.ts',
+            ]);
+            expect(result).toEqual([]);
+        });
+    });
+    // ── phantom entity SHAs ─────────────────────────────────────────────
+    describe('queryIncompleteEntities with phantom entity SHAs', () => {
+        // Root cause of the Margo/reader step-blocking bug:
+        // Scenarios registered without component_path got a phantom entity_sha
+        // computed from component_name alone. These SHAs have NO entity record
+        // in the entities table and NO analyses. syncScenarioEntityShas can't
+        // fix them (it skips scenarios without component_path). So they remain
+        // "incomplete" forever, blocking step progression.
+        //
+        // Fix: queryIncompleteEntities should not report scenarios whose
+        // entity_sha has no entity record — these are orphaned data, not
+        // fixable by running analyze-imports.
         let db;
         let rawDb;
         const projectId = 'test-project-id';
@@ -1336,94 +1636,229 @@ describe('editorAudit', () => {
                 .addColumn('created_at', 'datetime')
                 .addColumn('updated_at', 'datetime')
                 .execute();
+            await db.schema
+                .createTable('analyses')
+                .addColumn('id', 'varchar', (col) => col.primaryKey())
+                .addColumn('entity_sha', 'varchar')
+                .addColumn('entity_name', 'varchar')
+                .addColumn('project_id', 'varchar')
+                .execute();
+            await db.schema
+                .createTable('entities')
+                .addColumn('sha', 'varchar', (col) => col.primaryKey())
+                .addColumn('name', 'varchar')
+                .addColumn('entity_type', 'varchar')
+                .addColumn('file_path', 'varchar')
+                .execute();
         });
         afterEach(async () => {
             await db.destroy();
         });
-        it('should return empty when all component scenarios use isolation routes', async () => {
+        it('should not report scenarios with phantom entity SHAs (no entity record exists)', async () => {
+            // Real entity — has an entity record, analyses, and scenarios. Complete.
             await db
-                .insertInto('editor_scenarios')
+                .insertInto('entities')
                 .values({
-                id: 'sc-1',
-                project_id: projectId,
-                name: 'LibraryCard - Default',
-                component_name: 'LibraryCard',
-                url: '/isolated-components/LibraryCard?s=Default',
-                created_at: '2026-03-17 12:00:00',
+                sha: 'sha-real',
+                name: 'RuleBuilder',
+                entity_type: 'visual',
+                file_path: 'app/components/RuleBuilder.tsx',
             })
                 .execute();
-            const result = await queryMiscategorizedScenarios(db, projectId, null);
-            expect(result).toEqual([]);
-        });
-        it('should flag component scenarios that use non-isolation URLs', async () => {
-            // This is the bug: "Full Library Page" registered as component_name=LibraryPage
-            // but url=/library — it's pointing at the real page, not an isolation route
             await db
-                .insertInto('editor_scenarios')
+                .insertInto('analyses')
                 .values({
-                id: 'sc-1',
+                id: 'a-1',
+                entity_sha: 'sha-real',
+                entity_name: 'RuleBuilder',
                 project_id: projectId,
-                name: 'Full Library Page',
-                component_name: 'LibraryPage',
-                url: '/library',
-                created_at: '2026-03-17 12:41:40',
             })
                 .execute();
             await db
                 .insertInto('editor_scenarios')
                 .values({
-                id: 'sc-2',
+                id: 'sc-good',
                 project_id: projectId,
-                name: 'Empty Library Page',
-                component_name: 'LibraryPage',
-                url: '/library',
-                created_at: '2026-03-17 12:41:51',
+                name: 'RuleBuilder - Empty',
+                component_name: 'RuleBuilder',
+                component_path: 'app/components/RuleBuilder.tsx',
+                entity_sha: 'sha-real',
+                created_at: '2026-03-16 23:00:00',
             })
                 .execute();
-            const result = await queryMiscategorizedScenarios(db, projectId, null);
-            expect(result).toEqual([
-                {
-                    componentName: 'LibraryPage',
-                    scenarioNames: ['Full Library Page', 'Empty Library Page'],
-                    url: '/library',
-                },
-            ]);
-        });
-        it('should not flag page-level scenarios (no component_name)', async () => {
-            // App-level scenarios have no component_name — they're fine with real URLs
+            // Phantom entity — scenario points to a SHA that doesn't exist
+            // in the entities table (registered without component_path).
+            // No entity record, no analyses, unfixable by analyze-imports.
             await db
                 .insertInto('editor_scenarios')
                 .values({
-                id: 'sc-1',
+                id: 'sc-phantom',
                 project_id: projectId,
-                name: 'Library with Articles',
-                url: '/',
-                created_at: '2026-03-17 12:25:14',
+                name: 'Empty',
+                component_name: 'RuleBuilder',
+                component_path: null,
+                entity_sha: 'sha-phantom-no-entity-record',
+                created_at: '2026-03-16 22:00:00',
             })
                 .execute();
-            const result = await queryMiscategorizedScenarios(db, projectId, null);
-            expect(result).toEqual([]);
+            const incomplete = await queryIncompleteEntities(db, projectId, null);
+            // Should NOT report phantom SHAs as incomplete — they can't be fixed
+            // by running analyze-imports (no entity record exists to resolve).
+            expect(incomplete).toHaveLength(0);
         });
-        it('should group miscategorized scenarios by component and URL', async () => {
-            // Two different components both misusing real URLs
+        it('should still report real incomplete entities (entity exists but no analysis)', async () => {
+            // Real entity without analysis — this IS a legitimate incomplete entity
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-noanalysis',
+                name: 'Footer',
+                entity_type: 'visual',
+                file_path: 'app/components/Footer.tsx',
+            })
+                .execute();
             await db
                 .insertInto('editor_scenarios')
                 .values({
                 id: 'sc-1',
                 project_id: projectId,
-                name: 'Full Library Page',
-                component_name: 'LibraryPage',
-                url: '/library',
-                created_at: '2026-03-17 12:41:40',
+                name: 'Footer - Default',
+                component_name: 'Footer',
+                component_path: 'app/components/Footer.tsx',
+                entity_sha: 'sha-noanalysis',
+                created_at: '2026-03-16 23:00:00',
             })
                 .execute();
+            // Phantom scenario (shouldn't affect results)
             await db
                 .insertInto('editor_scenarios')
                 .values({
-                id: 'sc-2',
+                id: 'sc-phantom',
                 project_id: projectId,
-                name: 'Dashboard - Full',
-                component_name: 'Dashboard',
+                name: 'Footer - Alt',
+                component_name: 'Footer',
+                component_path: null,
+                entity_sha: 'sha-phantom-does-not-exist',
+                created_at: '2026-03-16 22:00:00',
+            })
+                .execute();
+            const incomplete = await queryIncompleteEntities(db, projectId, null);
+            // Should report Footer (real entity, no analysis) but NOT the phantom
+            expect(incomplete).toHaveLength(1);
+            expect(incomplete[0].name).toBe('Footer');
+            expect(incomplete[0].entitySha).toBe('sha-noanalysis');
+        });
+    });
+    // ── queryMiscategorizedScenarios ─────────────────────────────────────
+    describe('queryMiscategorizedScenarios', () => {
+        let db;
+        let rawDb;
+        const projectId = 'test-project-id';
+        beforeEach(async () => {
+            rawDb = new Database(':memory:');
+            db = new Kysely({ dialect: new SqliteDialect({ database: rawDb }) });
+            await db.schema
+                .createTable('editor_scenarios')
+                .addColumn('id', 'varchar', (col) => col.primaryKey())
+                .addColumn('project_id', 'varchar', (col) => col.notNull())
+                .addColumn('name', 'varchar', (col) => col.notNull())
+                .addColumn('component_name', 'varchar')
+                .addColumn('component_path', 'varchar')
+                .addColumn('entity_sha', 'varchar')
+                .addColumn('display_name', 'varchar')
+                .addColumn('page_file_path', 'varchar')
+                .addColumn('url', 'varchar')
+                .addColumn('created_at', 'datetime')
+                .addColumn('updated_at', 'datetime')
+                .execute();
+        });
+        afterEach(async () => {
+            await db.destroy();
+        });
+        it('should return empty when all component scenarios use isolation routes', async () => {
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'LibraryCard - Default',
+                component_name: 'LibraryCard',
+                url: '/isolated-components/LibraryCard?s=Default',
+                created_at: '2026-03-17 12:00:00',
+            })
+                .execute();
+            const result = await queryMiscategorizedScenarios(db, projectId, null);
+            expect(result).toEqual([]);
+        });
+        it('should flag component scenarios that use non-isolation URLs', async () => {
+            // This is the bug: "Full Library Page" registered as component_name=LibraryPage
+            // but url=/library — it's pointing at the real page, not an isolation route
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'Full Library Page',
+                component_name: 'LibraryPage',
+                url: '/library',
+                created_at: '2026-03-17 12:41:40',
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-2',
+                project_id: projectId,
+                name: 'Empty Library Page',
+                component_name: 'LibraryPage',
+                url: '/library',
+                created_at: '2026-03-17 12:41:51',
+            })
+                .execute();
+            const result = await queryMiscategorizedScenarios(db, projectId, null);
+            expect(result).toEqual([
+                {
+                    componentName: 'LibraryPage',
+                    scenarioNames: ['Full Library Page', 'Empty Library Page'],
+                    url: '/library',
+                },
+            ]);
+        });
+        it('should not flag page-level scenarios (no component_name)', async () => {
+            // App-level scenarios have no component_name — they're fine with real URLs
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'Library with Articles',
+                url: '/',
+                created_at: '2026-03-17 12:25:14',
+            })
+                .execute();
+            const result = await queryMiscategorizedScenarios(db, projectId, null);
+            expect(result).toEqual([]);
+        });
+        it('should group miscategorized scenarios by component and URL', async () => {
+            // Two different components both misusing real URLs
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'Full Library Page',
+                component_name: 'LibraryPage',
+                url: '/library',
+                created_at: '2026-03-17 12:41:40',
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-2',
+                project_id: projectId,
+                name: 'Dashboard - Full',
+                component_name: 'Dashboard',
                 url: '/dashboard',
                 created_at: '2026-03-17 12:50:00',
             })
@@ -1562,10 +1997,31 @@ describe('editorAudit', () => {
                 allPassing: false,
             })).toBe(true);
         });
+        it('should return false when there are also runner errors', () => {
+            // functionsRunnerError means the test runner crashed — a real failure
+            // that cannot be fixed by entity SHA backfill or analyze-imports.
+            // If this returns true, checkAuditGate would attempt a useless backfill
+            // instead of reporting the runner error, and isOnlyPreExistingIncomplete
+            // could let the gate pass entirely.
+            expect(isOnlyIncompleteEntities({
+                componentsMissing: 0,
+                componentsWithErrors: 0,
+                functionsFailing: 0,
+                functionsRunnerError: 2,
+                functionsNameMismatch: 0,
+                functionsMissing: 0,
+                missingFromGlossary: 0,
+                incompleteEntities: 1,
+                allPassing: false,
+            })).toBe(false);
+        });
     });
     // ── isAutoRemediable ─────────────────────────────────────────────────
     describe('isAutoRemediable', () => {
-        it('should return true on first attempt when only incomplete entities', () => {
+        // isAutoRemediable always returns false — the audit never triggers
+        // full analyze-imports inline. It takes minutes on large projects.
+        // Only lightweight backfill is acceptable during audit.
+        it('should return false even on first attempt with only incomplete entities', () => {
             const result = isAutoRemediable({
                 componentsMissing: 0,
                 componentsWithErrors: 0,
@@ -1577,11 +2033,9 @@ describe('editorAudit', () => {
                 incompleteEntities: 3,
                 allPassing: false,
             }, false);
-            expect(result).toBe(true);
+            expect(result).toBe(false);
         });
-        it('should return false on second attempt (already tried once)', () => {
-            // This is the key fix: if we already tried analyze-imports and
-            // entities are STILL incomplete, don't try again — report the failure
+        it('should return false on second attempt', () => {
             const result = isAutoRemediable({
                 componentsMissing: 0,
                 componentsWithErrors: 0,
@@ -1721,7 +2175,12 @@ describe('editorAudit', () => {
                 .execute();
             const result = await queryIncompleteEntities(db, projectId, null);
             expect(result).toEqual([
-                { entitySha: 'sha-chips', name: 'CollectionChips', scenarioCount: 2 },
+                {
+                    entitySha: 'sha-chips',
+                    name: 'CollectionChips',
+                    scenarioCount: 2,
+                    preExisting: false,
+                },
             ]);
         });
         it('should only return entities without analyses, not those with analyses', async () => {
@@ -1778,10 +2237,15 @@ describe('editorAudit', () => {
                 .execute();
             const result = await queryIncompleteEntities(db, projectId, null);
             expect(result).toEqual([
-                { entitySha: 'sha-picker', name: 'CollectionPicker', scenarioCount: 1 },
+                {
+                    entitySha: 'sha-picker',
+                    name: 'CollectionPicker',
+                    scenarioCount: 1,
+                    preExisting: false,
+                },
             ]);
         });
-        it('should scope to session when featureStartedAt is provided', async () => {
+        it('should return both pre-session and in-session entities with preExisting flags', async () => {
             // Entity without analysis, scenario created BEFORE session
             await db
                 .insertInto('entities')
@@ -1825,12 +2289,24 @@ describe('editorAudit', () => {
             })
                 .execute();
             const result = await queryIncompleteEntities(db, projectId, '2026-03-16T23:07:12.698Z');
-            // Only NewComponent should be flagged (created in session)
-            expect(result).toEqual([
-                { entitySha: 'sha-new', name: 'NewComponent', scenarioCount: 1 },
-            ]);
+            // Both should be returned — OldComponent is preExisting, NewComponent is not
+            expect(result).toEqual(expect.arrayContaining([
+                {
+                    entitySha: 'sha-old',
+                    name: 'OldComponent',
+                    scenarioCount: 1,
+                    preExisting: true,
+                },
+                {
+                    entitySha: 'sha-new',
+                    name: 'NewComponent',
+                    scenarioCount: 1,
+                    preExisting: false,
+                },
+            ]));
+            expect(result).toHaveLength(2);
         });
-        it('should include scenarios updated in session even if created before', async () => {
+        it('should flag preExisting: false when scenario was updated in session even if created before', async () => {
             await db
                 .insertInto('entities')
                 .values({
@@ -1858,6 +2334,7 @@ describe('editorAudit', () => {
                     entitySha: 'sha-updated',
                     name: 'UpdatedComponent',
                     scenarioCount: 1,
+                    preExisting: false,
                 },
             ]);
         });
@@ -1925,6 +2402,60 @@ describe('editorAudit', () => {
             const result = await queryIncompleteEntities(db, projectId, null);
             expect(result).toEqual([]);
         });
+        it('should flag entity when sibling has analyses but different filePath (extracted component)', async () => {
+            // Old entity version WITH analysis at ORIGINAL file path
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-card-v1',
+                name: 'TaskCard',
+                entity_type: 'visual',
+                file_path: 'app/page.tsx',
+            })
+                .execute();
+            await db
+                .insertInto('analyses')
+                .values({
+                id: 'a-card-v1',
+                entity_sha: 'sha-card-v1',
+                entity_name: 'TaskCard',
+                project_id: projectId,
+            })
+                .execute();
+            // New entity version WITHOUT analysis at EXTRACTED file path
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-card-v2',
+                name: 'TaskCard',
+                entity_type: 'visual',
+                file_path: 'app/components/TaskCard.tsx',
+            })
+                .execute();
+            // Scenario points to the new version (synced by syncScenarioEntityShas)
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-card',
+                project_id: projectId,
+                name: 'TaskCard - Default',
+                component_name: 'TaskCard',
+                entity_sha: 'sha-card-v2',
+                created_at: '2026-03-16 23:00:00',
+            })
+                .execute();
+            // SHOULD flag as incomplete — sibling has analyses but at a different filePath,
+            // so getAllEntities() won't inherit (it matches by name+filePath)
+            const result = await queryIncompleteEntities(db, projectId, null);
+            expect(result).toEqual([
+                {
+                    entitySha: 'sha-card-v2',
+                    name: 'TaskCard',
+                    scenarioCount: 1,
+                    preExisting: false,
+                },
+            ]);
+        });
         it('should still flag entities when no sibling version has analyses', async () => {
             // Only one version, no analyses
             await db
@@ -1954,11 +2485,15 @@ describe('editorAudit', () => {
                     entitySha: 'sha-icon',
                     name: 'ExternalLinkIcon',
                     scenarioCount: 1,
+                    preExisting: false,
                 },
             ]);
         });
-        it('should use entity name from entities table, falling back to component_name', async () => {
-            // Scenario has entity_sha but entity record doesn't exist
+        it('should skip phantom SHAs (entity_sha with no entity record)', async () => {
+            // Scenario has entity_sha but entity record doesn't exist.
+            // These are "phantom SHAs" created when scenarios were registered
+            // without component_path — they can never be fixed by analyze-imports
+            // and should not block audit progression.
             await db
                 .insertInto('editor_scenarios')
                 .values({
@@ -1971,10 +2506,1519 @@ describe('editorAudit', () => {
             })
                 .execute();
             const result = await queryIncompleteEntities(db, projectId, null);
+            // Phantom SHAs are excluded — not reportable as incomplete
+            expect(result).toEqual([]);
+        });
+        it('should detect incomplete entity whose scenario predates the session', async () => {
+            // Entity with no analyses, scenario created BEFORE session
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-preexisting',
+                name: 'PreExistingComponent',
+                entity_type: 'visual',
+                file_path: 'src/PreExistingComponent.tsx',
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-preexisting',
+                project_id: projectId,
+                name: 'PreExistingComponent - Default',
+                component_name: 'PreExistingComponent',
+                entity_sha: 'sha-preexisting',
+                created_at: '2026-03-16 20:00:00',
+                updated_at: '2026-03-16 20:00:00',
+            })
+                .execute();
+            // Session started well after scenario was created/updated
+            const result = await queryIncompleteEntities(db, projectId, '2026-03-16T23:07:12.698Z');
+            // Should still be detected — the old time filter would have excluded it
+            expect(result).toEqual([
+                {
+                    entitySha: 'sha-preexisting',
+                    name: 'PreExistingComponent',
+                    scenarioCount: 1,
+                    preExisting: true,
+                },
+            ]);
+        });
+        it('should flag preExisting: true when all scenarios predate the session', async () => {
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-old-entity',
+                name: 'OldEntity',
+                entity_type: 'visual',
+                file_path: 'src/OldEntity.tsx',
+            })
+                .execute();
+            // Two scenarios, both before session
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-old-1',
+                project_id: projectId,
+                name: 'OldEntity - Default',
+                component_name: 'OldEntity',
+                entity_sha: 'sha-old-entity',
+                created_at: '2026-03-16 19:00:00',
+                updated_at: '2026-03-16 19:00:00',
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-old-2',
+                project_id: projectId,
+                name: 'OldEntity - Hover',
+                component_name: 'OldEntity',
+                entity_sha: 'sha-old-entity',
+                created_at: '2026-03-16 19:30:00',
+                updated_at: '2026-03-16 19:30:00',
+            })
+                .execute();
+            const result = await queryIncompleteEntities(db, projectId, '2026-03-16T23:07:12.698Z');
+            expect(result).toEqual([
+                {
+                    entitySha: 'sha-old-entity',
+                    name: 'OldEntity',
+                    scenarioCount: 2,
+                    preExisting: true,
+                },
+            ]);
+        });
+        it('should flag preExisting: false when scenario is from the current session', async () => {
+            await db
+                .insertInto('entities')
+                .values({
+                sha: 'sha-session-entity',
+                name: 'SessionEntity',
+                entity_type: 'visual',
+                file_path: 'src/SessionEntity.tsx',
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-session',
+                project_id: projectId,
+                name: 'SessionEntity - Default',
+                component_name: 'SessionEntity',
+                entity_sha: 'sha-session-entity',
+                created_at: '2026-03-16 23:30:00',
+                updated_at: '2026-03-16 23:30:00',
+            })
+                .execute();
+            const result = await queryIncompleteEntities(db, projectId, '2026-03-16T23:07:12.698Z');
             expect(result).toEqual([
-                { entitySha: 'sha-ghost', name: 'GhostComponent', scenarioCount: 1 },
+                {
+                    entitySha: 'sha-session-entity',
+                    name: 'SessionEntity',
+                    scenarioCount: 1,
+                    preExisting: false,
+                },
             ]);
         });
     });
+    // ── identifyScenariosNeedingRecapture ──────────────────────────────
+    describe('identifyScenariosNeedingRecapture', () => {
+        // Reproduces the Margo bug: Feature 1 built app-level popup scenarios,
+        // Feature 2 edited LibraryView (used by App), but app-level scenarios
+        // were never flagged for recapture because the audit only checked
+        // component scenario existence — not whether app-level scenarios are stale.
+        //
+        // Each scenario's entityName is resolved by the caller via
+        // entity_sha → entities.name (the default export for app-level scenarios).
+        it('should flag app-level scenario when its entity is impacted by transitive dependency change', () => {
+            // LibraryView was edited → App is impacted (imports LibraryView)
+            // App-level scenario "Library - Rich Library" has entity_sha pointing to App
+            // It was NOT recaptured during Feature 2 → should be flagged
+            const entityChangeStatus = {
+                LibraryView: { status: 'edited' },
+                App: {
+                    status: 'impacted',
+                    impactedBy: [
+                        {
+                            name: 'LibraryView',
+                            filePath: 'src/components/LibraryView.tsx',
+                            changeType: 'edited',
+                        },
+                    ],
+                },
+            };
+            const result = identifyScenariosNeedingRecapture({
+                scenarios: [
+                    {
+                        name: 'Library - Rich Library',
+                        entityName: 'App', // resolved from entity_sha → entities.name
+                        updatedInSession: false,
+                    },
+                ],
+                entityChangeStatus,
+            });
+            expect(result).toHaveLength(1);
+            expect(result[0].scenarioName).toBe('Library - Rich Library');
+            expect(result[0].entityName).toBe('App');
+            expect(result[0].status.status).toBe('impacted');
+        });
+        it('should flag component scenario when its entity is directly edited and not recaptured', () => {
+            const entityChangeStatus = {
+                LibraryView: { status: 'edited' },
+            };
+            const result = identifyScenariosNeedingRecapture({
+                scenarios: [
+                    {
+                        name: 'LibraryView - Empty',
+                        entityName: 'LibraryView',
+                        updatedInSession: false,
+                    },
+                ],
+                entityChangeStatus,
+            });
+            expect(result).toHaveLength(1);
+            expect(result[0].scenarioName).toBe('LibraryView - Empty');
+            expect(result[0].entityName).toBe('LibraryView');
+            expect(result[0].status.status).toBe('edited');
+        });
+        it('should NOT flag scenario that was already recaptured in the current session', () => {
+            const entityChangeStatus = {
+                App: {
+                    status: 'impacted',
+                    impactedBy: [
+                        {
+                            name: 'LibraryView',
+                            filePath: 'src/components/LibraryView.tsx',
+                            changeType: 'edited',
+                        },
+                    ],
+                },
+            };
+            const result = identifyScenariosNeedingRecapture({
+                scenarios: [
+                    {
+                        name: 'App - Default',
+                        entityName: 'App',
+                        updatedInSession: true, // re-registered during Feature 2
+                    },
+                ],
+                entityChangeStatus,
+            });
+            expect(result).toHaveLength(0);
+        });
+        it('should NOT flag scenario whose entity has no change status', () => {
+            const entityChangeStatus = {
+                LibraryView: { status: 'edited' },
+            };
+            const result = identifyScenariosNeedingRecapture({
+                scenarios: [
+                    {
+                        name: 'WelcomeScreen - Default',
+                        entityName: 'WelcomeScreen',
+                        updatedInSession: false,
+                    },
+                ],
+                entityChangeStatus,
+            });
+            expect(result).toHaveLength(0);
+        });
+        it('should return empty array when entityChangeStatus is undefined', () => {
+            const result = identifyScenariosNeedingRecapture({
+                scenarios: [
+                    {
+                        name: 'Library - Rich Library',
+                        entityName: 'App',
+                        updatedInSession: false,
+                    },
+                ],
+                entityChangeStatus: undefined,
+            });
+            expect(result).toHaveLength(0);
+        });
+        it('should return empty array when entityChangeStatus is empty', () => {
+            const result = identifyScenariosNeedingRecapture({
+                scenarios: [
+                    {
+                        name: 'Library - Rich Library',
+                        entityName: 'App',
+                        updatedInSession: false,
+                    },
+                ],
+                entityChangeStatus: {},
+            });
+            expect(result).toHaveLength(0);
+        });
+        it('should flag multiple app-level scenarios sharing the same impacted entity', () => {
+            const entityChangeStatus = {
+                LibraryView: { status: 'edited' },
+                App: {
+                    status: 'impacted',
+                    impactedBy: [
+                        {
+                            name: 'LibraryView',
+                            filePath: 'src/components/LibraryView.tsx',
+                            changeType: 'edited',
+                        },
+                    ],
+                },
+            };
+            const result = identifyScenariosNeedingRecapture({
+                scenarios: [
+                    {
+                        name: 'Library - Empty',
+                        entityName: 'App',
+                        updatedInSession: false,
+                    },
+                    {
+                        name: 'Library - Rich Library',
+                        entityName: 'App',
+                        updatedInSession: false,
+                    },
+                    {
+                        name: 'First Article Saved',
+                        entityName: 'App',
+                        updatedInSession: false,
+                    },
+                ],
+                entityChangeStatus,
+            });
+            expect(result).toHaveLength(3);
+            expect(result.map((r) => r.scenarioName).sort()).toEqual([
+                'First Article Saved',
+                'Library - Empty',
+                'Library - Rich Library',
+            ]);
+            expect(result.every((r) => r.entityName === 'App')).toBe(true);
+        });
+        it('should skip scenarios with null entityName (no entity_sha set)', () => {
+            const entityChangeStatus = {
+                App: { status: 'edited' },
+            };
+            const result = identifyScenariosNeedingRecapture({
+                scenarios: [
+                    {
+                        name: 'Mystery Scenario',
+                        entityName: null, // no entity_sha → no entity name
+                        updatedInSession: false,
+                    },
+                ],
+                entityChangeStatus,
+            });
+            expect(result).toHaveLength(0);
+        });
+        it('should NOT flag scenarios for new entities (they need creation, not recapture)', () => {
+            // "new" entities are being seen for the first time. Their scenarios need
+            // initial creation, not recapture of old screenshots. Flagging them as
+            // "needs_recapture" sends the wrong remediation signal to Claude.
+            const entityChangeStatus = {
+                NewComponent: { status: 'new' },
+            };
+            const result = identifyScenariosNeedingRecapture({
+                scenarios: [
+                    {
+                        name: 'NewComponent - Default',
+                        entityName: 'NewComponent',
+                        updatedInSession: false,
+                    },
+                ],
+                entityChangeStatus,
+            });
+            expect(result).toHaveLength(0);
+        });
+    });
+    // ── detectDuplicateNames ──────────────────────────────────────────
+    describe('detectDuplicateNames', () => {
+        it('should return empty map when no duplicates exist', () => {
+            const entries = [
+                { name: 'Header', filePath: 'app/components/Header.tsx' },
+                { name: 'Footer', filePath: 'app/components/Footer.tsx' },
+                { name: 'Sidebar', filePath: 'app/components/Sidebar.tsx' },
+            ];
+            const result = detectDuplicateNames(entries);
+            expect(result.size).toBe(0);
+        });
+        it('should group entries that share a name', () => {
+            const entries = [
+                { name: 'Page', filePath: 'app/isolated-components/Foo/page.tsx' },
+                { name: 'Page', filePath: 'app/isolated-components/Bar/page.tsx' },
+                { name: 'Page', filePath: 'app/isolated-components/Baz/page.tsx' },
+                { name: 'Header', filePath: 'app/components/Header.tsx' },
+            ];
+            const result = detectDuplicateNames(entries);
+            expect(result.size).toBe(1);
+            expect(result.has('Page')).toBe(true);
+            const pageGroup = result.get('Page');
+            expect(pageGroup).toHaveLength(3);
+            expect(pageGroup.map((e) => e.filePath)).toEqual([
+                'app/isolated-components/Foo/page.tsx',
+                'app/isolated-components/Bar/page.tsx',
+                'app/isolated-components/Baz/page.tsx',
+            ]);
+        });
+        it('should exclude single-occurrence names', () => {
+            const entries = [
+                { name: 'Page', filePath: 'app/isolated-components/Foo/page.tsx' },
+                { name: 'Page', filePath: 'app/isolated-components/Bar/page.tsx' },
+                { name: 'Header', filePath: 'app/components/Header.tsx' },
+                { name: 'Footer', filePath: 'app/components/Footer.tsx' },
+            ];
+            const result = detectDuplicateNames(entries);
+            expect(result.size).toBe(1);
+            expect(result.has('Header')).toBe(false);
+            expect(result.has('Footer')).toBe(false);
+        });
+        it('should handle multiple duplicate groups', () => {
+            const entries = [
+                { name: 'Page', filePath: 'app/isolated-components/A/page.tsx' },
+                { name: 'Page', filePath: 'app/isolated-components/B/page.tsx' },
+                { name: 'Layout', filePath: 'app/isolated-components/A/layout.tsx' },
+                { name: 'Layout', filePath: 'app/isolated-components/B/layout.tsx' },
+                { name: 'Unique', filePath: 'app/components/Unique.tsx' },
+            ];
+            const result = detectDuplicateNames(entries);
+            expect(result.size).toBe(2);
+            expect(result.has('Page')).toBe(true);
+            expect(result.has('Layout')).toBe(true);
+            expect(result.get('Page')).toHaveLength(2);
+            expect(result.get('Layout')).toHaveLength(2);
+        });
+        it('should return empty map for empty input', () => {
+            const result = detectDuplicateNames([]);
+            expect(result.size).toBe(0);
+        });
+    });
+    // ── computeAudit: impacted components with stale scenarios ──────────
+    describe('computeAudit — impacted components with stale scenarios', () => {
+        it('should mark impacted component as needs_recapture when it has total scenarios but none in session', () => {
+            // Library page has 3 scenarios from Feature 1 (totalScenarioCounts),
+            // 0 in the current session (scenarioCounts), and is "impacted" in entityChangeStatus.
+            // It should NOT be marked "missing" — it needs recapture, not new scenarios.
+            const result = computeAudit({
+                components: [
+                    {
+                        name: 'Library',
+                        filePath: 'app/library/page.tsx',
+                        returnType: 'JSX.Element',
+                    },
+                    {
+                        name: 'ArticleTable',
+                        filePath: 'app/components/ArticleTable.tsx',
+                        returnType: 'JSX.Element',
+                    },
+                ],
+                functions: [],
+                scenarioCounts: { ArticleTable: 2 },
+                testFileExistence: {},
+                totalScenarioCounts: { Library: 3 },
+                entityChangeStatus: {
+                    Library: { status: 'impacted' },
+                    ArticleTable: { status: 'edited' },
+                },
+            });
+            // Library: impacted + has total scenarios but 0 in session → needs_recapture
+            expect(result.components[0].status).toBe('needs_recapture');
+            expect(result.components[0].scenarioCount).toBe(3);
+            // ArticleTable: edited + has session scenarios → ok
+            expect(result.components[1].status).toBe('ok');
+            // needs_recapture should NOT count as missing
+            expect(result.summary.componentsMissing).toBe(0);
+            expect(result.summary.componentsNeedingRecapture).toBe(1);
+            // should NOT fail the audit (scenariosNeedingRecapture handles it)
+            expect(result.summary.allPassing).toBe(true);
+        });
+        it('should still mark component as missing when impacted but has zero total scenarios', () => {
+            // New page added to glossary but never had scenarios — truly missing
+            const result = computeAudit({
+                components: [
+                    {
+                        name: 'NewPage',
+                        filePath: 'app/new/page.tsx',
+                        returnType: 'JSX.Element',
+                    },
+                ],
+                functions: [],
+                scenarioCounts: {},
+                testFileExistence: {},
+                totalScenarioCounts: {},
+                entityChangeStatus: {
+                    NewPage: { status: 'impacted' },
+                },
+            });
+            expect(result.components[0].status).toBe('missing');
+            expect(result.summary.componentsMissing).toBe(1);
+        });
+        it('should use needs_recapture for edited entities with existing scenarios from prior sessions', () => {
+            // Edited entities that already have scenarios from prior sessions
+            // need recapture, not re-registration. The code changed, but the
+            // scenarios exist — they just need fresh screenshots.
+            const result = computeAudit({
+                components: [
+                    {
+                        name: 'EditedComp',
+                        filePath: 'app/components/Edited.tsx',
+                        returnType: 'JSX.Element',
+                    },
+                ],
+                functions: [],
+                scenarioCounts: {},
+                testFileExistence: {},
+                totalScenarioCounts: { EditedComp: 2 },
+                entityChangeStatus: {
+                    EditedComp: { status: 'edited' },
+                },
+            });
+            expect(result.components[0].status).toBe('needs_recapture');
+            expect(result.summary.componentsMissing).toBe(0);
+            expect(result.summary.componentsNeedingRecapture).toBe(1);
+        });
+        it('should still mark as missing when new entity has zero total scenarios', () => {
+            // Truly new component with no scenarios ever — needs scenarios created
+            const result = computeAudit({
+                components: [
+                    {
+                        name: 'BrandNew',
+                        filePath: 'app/components/BrandNew.tsx',
+                        returnType: 'JSX.Element',
+                    },
+                ],
+                functions: [],
+                scenarioCounts: {},
+                testFileExistence: {},
+                totalScenarioCounts: {},
+                entityChangeStatus: {
+                    BrandNew: { status: 'new' },
+                },
+            });
+            expect(result.components[0].status).toBe('missing');
+            expect(result.summary.componentsMissing).toBe(1);
+        });
+        it('should not count needs_recapture components as componentsOk', () => {
+            // A needs_recapture component is not "ok" — it needs action. Counting it
+            // in componentsOk is misleading: if totalComponents=2, componentsOk=2,
+            // and componentsNeedingRecapture=1, the numbers don't add up (2+1 > 2).
+            const result = computeAudit({
+                components: [
+                    { name: 'Library', filePath: 'app/library/page.tsx' },
+                    { name: 'DrinkCard', filePath: 'app/components/DrinkCard.tsx' },
+                ],
+                functions: [],
+                scenarioCounts: { DrinkCard: 2 },
+                testFileExistence: {},
+                totalScenarioCounts: { Library: 3 },
+                entityChangeStatus: { Library: { status: 'impacted' } },
+            });
+            expect(result.components[0].status).toBe('needs_recapture');
+            expect(result.components[1].status).toBe('ok');
+            // needs_recapture is not "ok" — should be counted separately
+            expect(result.summary.componentsOk).toBe(1);
+            expect(result.summary.componentsNeedingRecapture).toBe(1);
+            expect(result.summary.totalComponents).toBe(2);
+        });
+    });
+    // ── queryUnassociatedScenarios ──────────────────────────────────────
+    describe('queryUnassociatedScenarios', () => {
+        let db;
+        let rawDb;
+        const projectId = 'test-project-id';
+        beforeEach(async () => {
+            rawDb = new Database(':memory:');
+            db = new Kysely({ dialect: new SqliteDialect({ database: rawDb }) });
+            await db.schema
+                .createTable('editor_scenarios')
+                .addColumn('id', 'varchar', (col) => col.primaryKey())
+                .addColumn('project_id', 'varchar', (col) => col.notNull())
+                .addColumn('name', 'varchar', (col) => col.notNull())
+                .addColumn('component_name', 'varchar')
+                .addColumn('component_path', 'varchar')
+                .addColumn('entity_sha', 'varchar')
+                .addColumn('display_name', 'varchar')
+                .addColumn('page_file_path', 'varchar')
+                .addColumn('url', 'varchar')
+                .addColumn('type', 'varchar')
+                .addColumn('created_at', 'datetime')
+                .addColumn('updated_at', 'datetime')
+                .execute();
+        });
+        afterEach(async () => {
+            await db.destroy();
+        });
+        it('should return empty when all scenarios have entity_sha', async () => {
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'Header - Default',
+                component_name: 'Header',
+                component_path: 'src/components/Header.tsx',
+                entity_sha: 'sha-header',
+                created_at: '2026-03-16 23:00:00',
+                updated_at: '2026-03-16 23:00:00',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, null);
+            expect(result).toEqual([]);
+        });
+        it('should find component scenarios with NULL entity_sha', async () => {
+            // This reproduces the Margo testapp bug: subagent registered scenarios
+            // but entity records didn't exist yet, so entity_sha was never set
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'SearchBar - Default',
+                component_name: 'SearchBar',
+                component_path: 'src/components/SearchBar.tsx',
+                entity_sha: null,
+                created_at: '2026-03-20 18:45:00',
+                updated_at: '2026-03-20 18:45:00',
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-2',
+                project_id: projectId,
+                name: 'SearchBar - With Results',
+                component_name: 'SearchBar',
+                component_path: 'src/components/SearchBar.tsx',
+                entity_sha: null,
+                created_at: '2026-03-20 18:45:05',
+                updated_at: '2026-03-20 18:45:05',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, null);
+            expect(result).toHaveLength(1);
+            expect(result[0].name).toBe('SearchBar');
+            expect(result[0].filePath).toBe('src/components/SearchBar.tsx');
+            expect(result[0].scenarioCount).toBe(2);
+            expect(result[0].scenarioNames).toEqual(expect.arrayContaining([
+                'SearchBar - Default',
+                'SearchBar - With Results',
+            ]));
+        });
+        it('should find page scenarios with NULL entity_sha', async () => {
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'Full Page — Rich Library',
+                component_name: null,
+                component_path: null,
+                page_file_path: 'src/library/LibraryApp.tsx',
+                entity_sha: null,
+                created_at: '2026-03-20 18:50:00',
+                updated_at: '2026-03-20 18:50:00',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, null);
+            expect(result).toHaveLength(1);
+            expect(result[0].name).toBe('LibraryApp');
+            expect(result[0].filePath).toBe('src/library/LibraryApp.tsx');
+            expect(result[0].scenarioCount).toBe(1);
+        });
+        it('should ignore scenarios without any file path (orphans without component_path or page_file_path)', async () => {
+            // Scenarios with no file path at all can't be associated — they're not
+            // actionable, so don't report them as unassociated
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'Some Orphan',
+                component_name: null,
+                component_path: null,
+                page_file_path: null,
+                entity_sha: null,
+                created_at: '2026-03-20 18:50:00',
+                updated_at: '2026-03-20 18:50:00',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, null);
+            expect(result).toEqual([]);
+        });
+        it('should group multiple components separately', async () => {
+            // Two different components both missing entity_sha
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'FullPageHeader - Default',
+                component_name: 'FullPageHeader',
+                component_path: 'src/components/FullPageHeader.tsx',
+                entity_sha: null,
+                created_at: '2026-03-20 18:45:00',
+                updated_at: '2026-03-20 18:45:00',
+            })
+                .execute();
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-2',
+                project_id: projectId,
+                name: 'SaveConfirmation - Visible',
+                component_name: 'SaveConfirmation',
+                component_path: 'src/components/SaveConfirmation.tsx',
+                entity_sha: null,
+                created_at: '2026-03-20 19:00:00',
+                updated_at: '2026-03-20 19:00:00',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, null);
+            expect(result).toHaveLength(2);
+            const names = result.map((r) => r.name).sort();
+            expect(names).toEqual(['FullPageHeader', 'SaveConfirmation']);
+        });
+        it('should only include scenarios from the specified project', async () => {
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: 'other-project',
+                name: 'SearchBar - Default',
+                component_name: 'SearchBar',
+                component_path: 'src/components/SearchBar.tsx',
+                entity_sha: null,
+                created_at: '2026-03-20 18:45:00',
+                updated_at: '2026-03-20 18:45:00',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, null);
+            expect(result).toEqual([]);
+        });
+        it('should scope to feature session when featureStartedAt is provided', async () => {
+            // Pre-existing unassociated scenario (before session)
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-old',
+                project_id: projectId,
+                name: 'OldComponent - Default',
+                component_name: 'OldComponent',
+                component_path: 'src/components/OldComponent.tsx',
+                entity_sha: null,
+                created_at: '2026-03-19 10:00:00',
+                updated_at: '2026-03-19 10:00:00',
+            })
+                .execute();
+            // New unassociated scenario (during session)
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-new',
+                project_id: projectId,
+                name: 'NewComponent - Default',
+                component_name: 'NewComponent',
+                component_path: 'src/components/NewComponent.tsx',
+                entity_sha: null,
+                created_at: '2026-03-20 18:45:00',
+                updated_at: '2026-03-20 18:45:00',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, '2026-03-20T18:00:00.000Z');
+            // Should only find the session-scoped one
+            expect(result).toHaveLength(1);
+            expect(result[0].name).toBe('NewComponent');
+        });
+        it('should include re-registered scenarios (updated_at in session) even if created before', async () => {
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'SearchBar - Default',
+                component_name: 'SearchBar',
+                component_path: 'src/components/SearchBar.tsx',
+                entity_sha: null,
+                created_at: '2026-03-19 10:00:00',
+                updated_at: '2026-03-20 18:45:00', // re-registered during session
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, '2026-03-20T18:00:00.000Z');
+            expect(result).toHaveLength(1);
+            expect(result[0].name).toBe('SearchBar');
+        });
+        it('should not include scenarios with entity_sha set (even if stale)', async () => {
+            // This scenario has an entity_sha — even if it's stale, that's a
+            // different problem (handled by queryIncompleteEntities)
+            await db
+                .insertInto('editor_scenarios')
+                .values({
+                id: 'sc-1',
+                project_id: projectId,
+                name: 'Header - Default',
+                component_name: 'Header',
+                component_path: 'src/components/Header.tsx',
+                entity_sha: 'sha-old-version',
+                created_at: '2026-03-20 18:45:00',
+                updated_at: '2026-03-20 18:45:00',
+            })
+                .execute();
+            const result = await queryUnassociatedScenarios(db, projectId, null);
+            expect(result).toEqual([]);
+        });
+    });
+    // ── isAutoRemediable with unassociatedScenarios ────────────────────
+    describe('isAutoRemediable always returns false (no inline full analysis)', () => {
+        // Full analyze-imports takes minutes on large projects. The audit should
+        // never trigger it — only the lightweight backfill path is acceptable.
+        it('should return false for unassociatedScenarios only', () => {
+            expect(isAutoRemediable({ unassociatedScenarios: 3 }, false)).toBe(false);
+        });
+        it('should return false for incompleteEntities + unassociatedScenarios', () => {
+            expect(isAutoRemediable({ incompleteEntities: 1, unassociatedScenarios: 2 }, false)).toBe(false);
+        });
+        it('should return false even with no other failures', () => {
+            expect(isAutoRemediable({ unassociatedScenarios: 2 }, false)).toBe(false);
+        });
+        it('should return false when already attempted', () => {
+            expect(isAutoRemediable({ unassociatedScenarios: 3 }, true)).toBe(false);
+        });
+    });
+    describe('suggestedTestFile for functions without testFile', () => {
+        it('should suggest conventional .test.ts path when testFile is undefined', () => {
+            const result = computeAudit({
+                components: [],
+                functions: [
+                    { name: 'useLibraryShell', filePath: 'app/library/context.tsx' },
+                ],
+                scenarioCounts: {},
+                testFileExistence: {},
+            });
+            expect(result.functions[0].suggestedTestFile).toBe('app/library/context.test.ts');
+            expect(result.functions[0].status).toBe('missing');
+        });
+        it('should suggest .test.ts for .ts files', () => {
+            const result = computeAudit({
+                components: [],
+                functions: [{ name: 'calculatePrice', filePath: 'app/lib/pricing.ts' }],
+                scenarioCounts: {},
+                testFileExistence: {},
+            });
+            expect(result.functions[0].suggestedTestFile).toBe('app/lib/pricing.test.ts');
+        });
+        it('should not set suggestedTestFile when testFile is already specified', () => {
+            const result = computeAudit({
+                components: [],
+                functions: [
+                    {
+                        name: 'calculatePrice',
+                        filePath: 'app/lib/pricing.ts',
+                        testFile: 'app/lib/pricing.test.ts',
+                    },
+                ],
+                scenarioCounts: {},
+                testFileExistence: { 'app/lib/pricing.test.ts': true },
+            });
+            expect(result.functions[0].suggestedTestFile).toBeUndefined();
+        });
+    });
+    describe('hint for function audit entries', () => {
+        it('should include a hint for name_mismatch functions explaining the fix', () => {
+            // Claude sees "name mismatch" with no guidance on what it means or how
+            // to fix it. The hint should explain that a top-level describe block
+            // matching the function name is required for the CodeYam UI.
+            const result = computeAudit({
+                components: [],
+                functions: [
+                    {
+                        name: 'useDrinks',
+                        filePath: 'app/hooks/useDrinks.ts',
+                        testFile: 'app/hooks/useDrinks.test.ts',
+                    },
+                ],
+                scenarioCounts: {},
+                testFileExistence: { 'app/hooks/useDrinks.test.ts': true },
+                testResults: {
+                    'app/hooks/useDrinks.test.ts': {
+                        passing: true,
+                        hasEntityNameDescribe: false,
+                    },
+                },
+            });
+            expect(result.functions[0].status).toBe('name_mismatch');
+            expect(result.functions[0].hint).toBeDefined();
+            expect(result.functions[0].hint).toContain('describe');
+            expect(result.functions[0].hint).toContain('useDrinks');
+        });
+        it('should include a hint for runner_error functions showing the error', () => {
+            // When the test runner crashes, Claude needs to see WHY it crashed
+            // to fix the underlying issue. Without this, Claude loops re-running audit.
+            const result = computeAudit({
+                components: [],
+                functions: [
+                    {
+                        name: 'getTimeAgo',
+                        filePath: 'src/lib/format.ts',
+                        testFile: 'src/lib/format.test.ts',
+                    },
+                ],
+                scenarioCounts: {},
+                testFileExistence: { 'src/lib/format.test.ts': true },
+                testResults: {
+                    'src/lib/format.test.ts': {
+                        passing: false,
+                        hasEntityNameDescribe: false,
+                        errorMessage: 'Cannot find module "@/lib/format"',
+                    },
+                },
+            });
+            expect(result.functions[0].status).toBe('runner_error');
+            expect(result.functions[0].hint).toBeDefined();
+            expect(result.functions[0].hint).toContain('Cannot find module');
+        });
+    });
+    describe('hint for missing components', () => {
+        it('should hint that layout files need app-level scenarios', () => {
+            const result = computeAudit({
+                components: [
+                    { name: 'LibraryLayout', filePath: 'app/library/layout.tsx' },
+                ],
+                functions: [],
+                scenarioCounts: {},
+                testFileExistence: {},
+            });
+            expect(result.components[0].hint).toContain('layout');
+            expect(result.components[0].hint).toContain('pageFilePath');
+        });
+        it('should hint that page files need app-level scenarios', () => {
+            const result = computeAudit({
+                components: [
+                    { name: 'InboxPage', filePath: 'app/library/inbox/page.tsx' },
+                ],
+                functions: [],
+                scenarioCounts: {},
+                testFileExistence: {},
+            });
+            expect(result.components[0].hint).toContain('page');
+            expect(result.components[0].hint).toContain('pageFilePath');
+        });
+        it('should hint that regular components need isolation routes', () => {
+            const result = computeAudit({
+                components: [
+                    { name: 'DrinkCard', filePath: 'app/components/DrinkCard.tsx' },
+                ],
+                functions: [],
+                scenarioCounts: {},
+                testFileExistence: {},
+            });
+            expect(result.components[0].hint).toContain('isolated-components');
+        });
+        it('should not set hint when component has scenarios', () => {
+            const result = computeAudit({
+                components: [
+                    { name: 'DrinkCard', filePath: 'app/components/DrinkCard.tsx' },
+                ],
+                functions: [],
+                scenarioCounts: { DrinkCard: 2 },
+                testFileExistence: {},
+            });
+            expect(result.components[0].hint).toBeUndefined();
+        });
+        it('should provide a hint for needs_recapture components', () => {
+            // Components with needs_recapture status need guidance on what to do.
+            // Without a hint, Claude has no instructions for fixing the issue.
+            const result = computeAudit({
+                components: [{ name: 'Library', filePath: 'app/library/page.tsx' }],
+                functions: [],
+                scenarioCounts: {},
+                testFileExistence: {},
+                totalScenarioCounts: { Library: 3 },
+                entityChangeStatus: { Library: { status: 'impacted' } },
+            });
+            expect(result.components[0].status).toBe('needs_recapture');
+            expect(result.components[0].hint).toBeDefined();
+            expect(result.components[0].hint).toContain('recapture');
+        });
+    });
+    describe('formatIncompleteEntityGuidance', () => {
+        it('should include the entity name and scenario count', () => {
+            const { formatIncompleteEntityGuidance } = require('../editorAudit');
+            const result = formatIncompleteEntityGuidance({
+                entitySha: 'abc123',
+                name: 'RuleBuilder',
+                scenarioCount: 5,
+                preExisting: false,
+            });
+            expect(result).toContain('RuleBuilder');
+            expect(result).toContain('5');
+        });
+        it('should tell Claude the exact fix command', () => {
+            const { formatIncompleteEntityGuidance } = require('../editorAudit');
+            const result = formatIncompleteEntityGuidance({
+                entitySha: 'abc123',
+                name: 'RuleBuilder',
+                scenarioCount: 5,
+                preExisting: false,
+            });
+            expect(result).toContain('codeyam editor analyze-imports');
+        });
+        it('should flag pre-existing issues as non-blocking', () => {
+            const { formatIncompleteEntityGuidance } = require('../editorAudit');
+            const result = formatIncompleteEntityGuidance({
+                entitySha: 'abc123',
+                name: 'RuleBuilder',
+                scenarioCount: 5,
+                preExisting: true,
+            });
+            expect(result).toContain('pre-existing');
+        });
+        it('should explain what incomplete means', () => {
+            const { formatIncompleteEntityGuidance } = require('../editorAudit');
+            const result = formatIncompleteEntityGuidance({
+                entitySha: 'abc123',
+                name: 'RuleBuilder',
+                scenarioCount: 5,
+                preExisting: false,
+            });
+            // Should explain the root cause, not just the symptom
+            expect(result).toMatch(/scenario.*without.*import graph|import graph.*not.*built/i);
+        });
+    });
+    describe('formatManualAnalysisGuidance', () => {
+        it('should include entity name, scenario count, and error message', () => {
+            const { formatManualAnalysisGuidance } = require('../editorAudit');
+            const result = formatManualAnalysisGuidance({
+                name: 'Header',
+                filePath: 'src/components/Header.tsx',
+                scenarioCount: 3,
+                error: 'TypeScript parsing error: unexpected token',
+            });
+            expect(result).toContain('Header');
+            expect(result).toContain('3 scenario(s)');
+            expect(result).toContain('TypeScript parsing error');
+        });
+        it('should include MANUAL ANALYSIS REQUIRED header', () => {
+            const { formatManualAnalysisGuidance } = require('../editorAudit');
+            const result = formatManualAnalysisGuidance({
+                name: 'Header',
+                filePath: 'src/components/Header.tsx',
+                scenarioCount: 2,
+                error: 'Parse error',
+            });
+            expect(result).toContain('MANUAL ANALYSIS REQUIRED');
+        });
+        it('should tell Claude to read the source file', () => {
+            const { formatManualAnalysisGuidance } = require('../editorAudit');
+            const result = formatManualAnalysisGuidance({
+                name: 'Header',
+                filePath: 'src/components/Header.tsx',
+                scenarioCount: 2,
+                error: 'Parse error',
+            });
+            expect(result).toContain('Read src/components/Header.tsx');
+        });
+        it('should include the manual-entity command', () => {
+            const { formatManualAnalysisGuidance } = require('../editorAudit');
+            const result = formatManualAnalysisGuidance({
+                name: 'Header',
+                filePath: 'src/components/Header.tsx',
+                scenarioCount: 2,
+                error: 'Parse error',
+            });
+            expect(result).toContain('codeyam editor manual-entity');
+        });
+        it('should tell Claude to check glossary for imports', () => {
+            const { formatManualAnalysisGuidance } = require('../editorAudit');
+            const result = formatManualAnalysisGuidance({
+                name: 'Header',
+                filePath: 'src/components/Header.tsx',
+                scenarioCount: 2,
+                error: 'Parse error',
+            });
+            expect(result).toContain('glossary');
+        });
+    });
+    describe('getIncompleteEntityFilePaths', () => {
+        // The audit should auto-fix incomplete entities by running analysis on
+        // just their specific file paths, not all 117+ files. This function
+        // resolves entity SHAs to file paths for targeted analysis.
+        let db;
+        let rawDb;
+        beforeEach(async () => {
+            rawDb = new Database(':memory:');
+            db = new Kysely({ dialect: new SqliteDialect({ database: rawDb }) });
+            await db.schema
+                .createTable('entities')
+                .addColumn('sha', 'varchar', (col) => col.primaryKey())
+                .addColumn('name', 'varchar')
+                .addColumn('file_path', 'varchar')
+                .addColumn('project_id', 'varchar')
+                .addColumn('entity_type', 'varchar')
+                .execute();
+        });
+        afterEach(() => {
+            rawDb.close();
+        });
+        it('should resolve entity SHAs to file paths from the entities table', async () => {
+            const { getIncompleteEntityFilePaths } = require('../editorAudit');
+            await db
+                .insertInto('entities')
+                .values([
+                {
+                    sha: 'sha-rule',
+                    name: 'RuleBuilder',
+                    file_path: 'app/components/RuleBuilder.tsx',
+                    project_id: 'p1',
+                    entity_type: 'component',
+                },
+                {
+                    sha: 'sha-row',
+                    name: 'ArticleTableRow',
+                    file_path: 'app/components/ArticleTableRow.tsx',
+                    project_id: 'p1',
+                    entity_type: 'component',
+                },
+            ])
+                .execute();
+            const result = await getIncompleteEntityFilePaths(db, [
+                {
+                    entitySha: 'sha-rule',
+                    name: 'RuleBuilder',
+                    scenarioCount: 5,
+                    preExisting: false,
+                },
+                {
+                    entitySha: 'sha-row',
+                    name: 'ArticleTableRow',
+                    scenarioCount: 2,
+                    preExisting: false,
+                },
+            ]);
+            expect(result).toContain('app/components/RuleBuilder.tsx');
+            expect(result).toContain('app/components/ArticleTableRow.tsx');
+            expect(result).toHaveLength(2);
+        });
+        it('should skip entities whose SHA is not in the entities table', async () => {
+            const { getIncompleteEntityFilePaths } = require('../editorAudit');
+            const result = await getIncompleteEntityFilePaths(db, [
+                {
+                    entitySha: 'nonexistent-sha',
+                    name: 'Ghost',
+                    scenarioCount: 1,
+                    preExisting: false,
+                },
+            ]);
+            expect(result).toHaveLength(0);
+        });
+        it('should deduplicate file paths', async () => {
+            const { getIncompleteEntityFilePaths } = require('../editorAudit');
+            await db
+                .insertInto('entities')
+                .values([
+                {
+                    sha: 'sha-v1',
+                    name: 'Foo',
+                    file_path: 'app/Foo.tsx',
+                    project_id: 'p1',
+                    entity_type: 'component',
+                },
+                {
+                    sha: 'sha-v2',
+                    name: 'Foo',
+                    file_path: 'app/Foo.tsx',
+                    project_id: 'p1',
+                    entity_type: 'component',
+                },
+            ])
+                .execute();
+            const result = await getIncompleteEntityFilePaths(db, [
+                {
+                    entitySha: 'sha-v1',
+                    name: 'Foo',
+                    scenarioCount: 3,
+                    preExisting: false,
+                },
+                {
+                    entitySha: 'sha-v2',
+                    name: 'Foo',
+                    scenarioCount: 1,
+                    preExisting: false,
+                },
+            ]);
+            expect(result).toEqual(['app/Foo.tsx']);
+        });
+    });
+    describe('isAutoRemediable never triggers full analysis', () => {
+        // The audit must NEVER run handleAnalyzeImports inline — it takes minutes
+        // for large projects. Auto-remediation should only do the lightweight
+        // entity SHA backfill. isAutoRemediable is now always false; the callers
+        // use needsBackfillOnly for the fast path instead.
+        it('should always return false regardless of summary state', () => {
+            expect(isAutoRemediable({ incompleteEntities: 5 }, false)).toBe(false);
+            expect(isAutoRemediable({ unassociatedScenarios: 3 }, false)).toBe(false);
+            expect(isAutoRemediable({ incompleteEntities: 1, unassociatedScenarios: 2 }, false)).toBe(false);
+        });
+    });
+    // ── isOnlyPreExistingIncomplete ─────────────────────────────────────
+    describe('isOnlyPreExistingIncomplete', () => {
+        it('should return true when all incomplete entities are pre-existing and no other failures', () => {
+            expect(isOnlyPreExistingIncomplete({
+                incompleteEntities: 2,
+                preExistingIncompleteEntities: 2,
+                componentsMissing: 0,
+                componentsWithErrors: 0,
+                functionsFailing: 0,
+                functionsNameMismatch: 0,
+                functionsMissing: 0,
+                missingFromGlossary: 0,
+                miscategorizedScenarios: 0,
+                scenariosNeedingRecapture: 0,
+            }, [
+                {
+                    entitySha: 'a',
+                    name: 'RuleBuilder',
+                    scenarioCount: 5,
+                    preExisting: true,
+                },
+                {
+                    entitySha: 'b',
+                    name: 'ArticleTableRow',
+                    scenarioCount: 2,
+                    preExisting: true,
+                },
+            ])).toBe(true);
+        });
+        it('should return false when there are runner errors even if all incompletes are pre-existing', () => {
+            // Safety net: runner errors (crashed test runner) must NEVER bypass the gate.
+            // Without this test, a regression removing functionsRunnerError from
+            // isOnlyIncompleteEntities would silently let broken test infrastructure through.
+            expect(isOnlyPreExistingIncomplete({
+                incompleteEntities: 1,
+                preExistingIncompleteEntities: 1,
+                componentsMissing: 0,
+                componentsWithErrors: 0,
+                functionsFailing: 0,
+                functionsRunnerError: 1,
+                functionsNameMismatch: 0,
+                functionsMissing: 0,
+                missingFromGlossary: 0,
+            }, [
+                {
+                    entitySha: 'a',
+                    name: 'OldComponent',
+                    scenarioCount: 1,
+                    preExisting: true,
+                },
+            ])).toBe(false);
+        });
+        it('should return false when some incomplete entities are NOT pre-existing', () => {
+            expect(isOnlyPreExistingIncomplete({
+                incompleteEntities: 2,
+                preExistingIncompleteEntities: 1,
+                componentsMissing: 0,
+                componentsWithErrors: 0,
+                functionsFailing: 0,
+                functionsNameMismatch: 0,
+                functionsMissing: 0,
+                missingFromGlossary: 0,
+                miscategorizedScenarios: 0,
+                scenariosNeedingRecapture: 0,
+            }, [
+                {
+                    entitySha: 'a',
+                    name: 'RuleBuilder',
+                    scenarioCount: 5,
+                    preExisting: true,
+                },
+                {
+                    entitySha: 'b',
+                    name: 'NewComponent',
+                    scenarioCount: 1,
+                    preExisting: false,
+                },
+            ])).toBe(false);
+        });
+        it('should return false when there are other failures besides incomplete entities', () => {
+            expect(isOnlyPreExistingIncomplete({
+                incompleteEntities: 2,
+                preExistingIncompleteEntities: 2,
+                componentsMissing: 1,
+            }, [
+                {
+                    entitySha: 'a',
+                    name: 'RuleBuilder',
+                    scenarioCount: 5,
+                    preExisting: true,
+                },
+                {
+                    entitySha: 'b',
+                    name: 'ArticleTableRow',
+                    scenarioCount: 2,
+                    preExisting: true,
+                },
+            ])).toBe(false);
+        });
+        it('should return false when incomplete entities array is empty', () => {
+            expect(isOnlyPreExistingIncomplete({ incompleteEntities: 0 }, [])).toBe(false);
+        });
+        it('should return false when incomplete entities array is missing', () => {
+            expect(isOnlyPreExistingIncomplete({ incompleteEntities: 2, preExistingIncompleteEntities: 2 }, undefined)).toBe(false);
+        });
+    });
+    describe('isOnlyIncompleteEntities with unassociatedScenarios', () => {
+        it('should return true when only unassociatedScenarios present', () => {
+            expect(isOnlyIncompleteEntities({ unassociatedScenarios: 5 })).toBe(true);
+        });
+        it('should return false when unassociatedScenarios present with other failures', () => {
+            expect(isOnlyIncompleteEntities({
+                unassociatedScenarios: 5,
+                functionsMissing: 1,
+            })).toBe(false);
+        });
+    });
+    // ── aggregateClientErrorsByComponent ─────────────────────────────────
+    describe('aggregateClientErrorsByComponent', () => {
+        it('should attribute errors to component using componentName from metadata', () => {
+            const result = aggregateClientErrorsByComponent({
+                'scenario-1': {
+                    scenarioName: 'DrinkCard - Default',
+                    errors: ['TypeError: Cannot read property "price"'],
+                },
+            }, [
+                {
+                    name: 'DrinkCard - Default',
+                    componentName: 'DrinkCard',
+                },
+            ]);
+            expect(result['DrinkCard']).toEqual([
+                'TypeError: Cannot read property "price"',
+            ]);
+        });
+        it('should attribute app-level scenario errors using pageFilePath', () => {
+            // App-level scenarios have componentName=null. The old approach
+            // parsed the scenario name "Full Page with Library" and got
+            // "Full Page with Library" as the component — which matches nothing.
+            // With metadata, we derive the entity name from pageFilePath.
+            const result = aggregateClientErrorsByComponent({
+                'scenario-1': {
+                    scenarioName: 'Full Page with Library',
+                    errors: ['TypeError: Cannot read property "title"'],
+                },
+            }, [
+                {
+                    name: 'Full Page with Library',
+                    componentName: null,
+                    pageFilePath: 'app/library/page.tsx',
+                },
+            ]);
+            // Should be keyed by the canonical entity name from scenarioEntityName()
+            expect(result['Library']).toEqual([
+                'TypeError: Cannot read property "title"',
+            ]);
+        });
+        it('should fall back to scenario name parsing when no metadata match exists', () => {
+            // If the scenario is not in the metadata list (e.g., metadata not yet loaded),
+            // fall back to the "ComponentName - Variant" convention
+            const result = aggregateClientErrorsByComponent({
+                'scenario-1': {
+                    scenarioName: 'Header - Dark Mode',
+                    errors: ['ReferenceError: theme is not defined'],
+                },
+            }, []);
+            expect(result['Header']).toEqual([
+                'ReferenceError: theme is not defined',
+            ]);
+        });
+        it('should handle non-route file paths via scenarioEntityName', () => {
+            // Non-route files (src/...) are treated as app entry points by
+            // scenarioEntityName → buildRoutePattern returns '/' → 'Home'.
+            // When a url is available, it provides a better entity name.
+            const result = aggregateClientErrorsByComponent({
+                'scenario-1': {
+                    scenarioName: 'LibraryApp - Rich',
+                    errors: ['Error: fetch failed'],
+                },
+            }, [
+                {
+                    name: 'LibraryApp - Rich',
+                    componentName: null,
+                    pageFilePath: 'src/library/LibraryApp.tsx',
+                    url: '/library',
+                },
+            ]);
+            // scenarioEntityName uses url fallback when pageFilePath is a non-route file
+            // pageFilePath 'src/...' → buildRoutePattern → '/' → routeDisplayName → 'Home'
+            // But componentName takes priority, and with url '/library' as final fallback
+            // scenarioEntityName({ pageFilePath: 'src/library/LibraryApp.tsx' }) → 'Home'
+            // because pageFilePath is checked before url
+            expect(result['Home']).toEqual(['Error: fetch failed']);
+        });
+        it('should skip scenarios with no errors', () => {
+            const result = aggregateClientErrorsByComponent({
+                'scenario-1': {
+                    scenarioName: 'DrinkCard - Default',
+                    errors: [],
+                },
+            }, [
+                {
+                    name: 'DrinkCard - Default',
+                    componentName: 'DrinkCard',
+                },
+            ]);
+            expect(result).toEqual({});
+        });
+        it('should aggregate errors from multiple scenarios for same component', () => {
+            const result = aggregateClientErrorsByComponent({
+                'scenario-1': {
+                    scenarioName: 'DrinkCard - Default',
+                    errors: ['Error A'],
+                },
+                'scenario-2': {
+                    scenarioName: 'DrinkCard - Hover',
+                    errors: ['Error B', 'Error C'],
+                },
+            }, [
+                { name: 'DrinkCard - Default', componentName: 'DrinkCard' },
+                { name: 'DrinkCard - Hover', componentName: 'DrinkCard' },
+            ]);
+            expect(result['DrinkCard']).toEqual(['Error A', 'Error B', 'Error C']);
+        });
+        it('should use capitalized display name for page file paths, not lowercase directory', () => {
+            // aggregateClientErrorsByComponent must produce keys matching scenarioEntityName().
+            // scenarioEntityName({ pageFilePath: 'app/library/page.tsx' }) returns 'Library',
+            // so the key must be 'Library' — not 'library' (the raw directory name).
+            // computeAudit checks clientErrors[glossaryEntryName], so a lowercase key
+            // will never match, silently dropping all client errors for page-level scenarios.
+            const result = aggregateClientErrorsByComponent({
+                'sc-1': {
+                    scenarioName: 'Library - Default',
+                    errors: ['TypeError: fetch failed'],
+                },
+            }, [
+                {
+                    name: 'Library - Default',
+                    componentName: null,
+                    pageFilePath: 'app/library/page.tsx',
+                },
+            ]);
+            expect(result).toHaveProperty('Library');
+            expect(result['Library']).toEqual(['TypeError: fetch failed']);
+        });
+        it('should use "Home" for root page app/page.tsx, not "app"', () => {
+            // Root page: scenarioEntityName returns 'Home', not 'app'.
+            // Custom path parsing incorrectly pops the parent dir ('app').
+            const result = aggregateClientErrorsByComponent({
+                'sc-1': {
+                    scenarioName: 'Home - Default',
+                    errors: ['ReferenceError: window is not defined'],
+                },
+            }, [
+                {
+                    name: 'Home - Default',
+                    componentName: null,
+                    pageFilePath: 'app/page.tsx',
+                },
+            ]);
+            expect(result).toHaveProperty('Home');
+            expect(result['Home']).toEqual(['ReferenceError: window is not defined']);
+        });
+    });
+    // ── determineTargetedAnalysisPaths ──────────────────────────────────
+    describe('determineTargetedAnalysisPaths', () => {
+        it('should return unique file paths from unassociated scenarios', () => {
+            const result = determineTargetedAnalysisPaths({
+                unassociatedScenarios: [
+                    { filePath: 'app/components/CreateFromFiltersButton.tsx' },
+                    { filePath: 'app/components/StaleDismissedBanner.tsx' },
+                ],
+                incompleteEntities: [],
+            });
+            expect(result).toEqual([
+                'app/components/CreateFromFiltersButton.tsx',
+                'app/components/StaleDismissedBanner.tsx',
+            ]);
+        });
+        it('should include file paths from incomplete entities', () => {
+            const result = determineTargetedAnalysisPaths({
+                unassociatedScenarios: [{ filePath: 'app/components/TaskCard.tsx' }],
+                incompleteEntities: [{ filePath: 'app/components/Dashboard.tsx' }],
+            });
+            expect(result).toEqual([
+                'app/components/TaskCard.tsx',
+                'app/components/Dashboard.tsx',
+            ]);
+        });
+        it('should deduplicate file paths across both sources', () => {
+            const result = determineTargetedAnalysisPaths({
+                unassociatedScenarios: [{ filePath: 'app/components/TaskCard.tsx' }],
+                incompleteEntities: [{ filePath: 'app/components/TaskCard.tsx' }],
+            });
+            expect(result).toEqual(['app/components/TaskCard.tsx']);
+        });
+        it('should return empty array when no issues', () => {
+            const result = determineTargetedAnalysisPaths({
+                unassociatedScenarios: [],
+                incompleteEntities: [],
+            });
+            expect(result).toEqual([]);
+        });
+        it('should filter out entries with empty file paths', () => {
+            const result = determineTargetedAnalysisPaths({
+                unassociatedScenarios: [{ filePath: '' }],
+                incompleteEntities: [],
+            });
+            expect(result).toEqual([]);
+        });
+        it('should handle incomplete entities with undefined filePath', () => {
+            const result = determineTargetedAnalysisPaths({
+                unassociatedScenarios: [{ filePath: 'app/components/Good.tsx' }],
+                incompleteEntities: [
+                    {
+                    /* no filePath at all */
+                    },
+                    { filePath: undefined },
+                    { filePath: 'app/components/AlsoGood.tsx' },
+                ],
+            });
+            expect(result).toEqual([
+                'app/components/Good.tsx',
+                'app/components/AlsoGood.tsx',
+            ]);
+        });
+    });
+    // ── shouldAutoRecapture ─────────────────────────────────────────────
+    describe('shouldAutoRecapture', () => {
+        it('should return true when fix flag is set and stale scenarios exist', () => {
+            expect(shouldAutoRecapture({
+                fix: true,
+                scenariosNeedingRecapture: [
+                    {
+                        scenarioName: 'Default',
+                        entityName: 'TaskCard',
+                        status: { status: 'edited' },
+                    },
+                ],
+            })).toBe(true);
+        });
+        it('should return false when fix flag is not set', () => {
+            expect(shouldAutoRecapture({
+                fix: false,
+                scenariosNeedingRecapture: [
+                    {
+                        scenarioName: 'Default',
+                        entityName: 'TaskCard',
+                        status: { status: 'edited' },
+                    },
+                ],
+            })).toBe(false);
+        });
+        it('should return false when fix is set but no stale scenarios', () => {
+            expect(shouldAutoRecapture({
+                fix: true,
+                scenariosNeedingRecapture: [],
+            })).toBe(false);
+        });
+        it('should return false when both are falsy', () => {
+            expect(shouldAutoRecapture({
+                fix: false,
+                scenariosNeedingRecapture: [],
+            })).toBe(false);
+        });
+    });
 });
 //# sourceMappingURL=editorAudit.test.js.map