@codeyam/codeyam-cli 0.1.0-staging.2ea44f6 → 0.1.0-staging.30dc541

package/codeyam-cli/src/utils/__tests__/editorSessionFilter.test.js

@@ -0,0 +1,66 @@
+/**
+ * Test for session scenario filtering — ensures re-registered scenarios
+ * (old created_at, new updated_at) are included in session results.
+ *
+ * Bug: editor.tsx loader filters session scenarios using only created_at,
+ * but re-registered scenarios keep their original created_at and only
+ * update updated_at. This causes popup/app scenarios from a previous
+ * session to vanish from Working Session Results when re-registered.
+ *
+ * The utility isRowInFeatureSession handles this correctly by checking
+ * both created_at and updated_at, but editor.tsx wasn't using it.
+ */
+import { isRowInFeatureSession, convertIsoToSqliteTimestamp, } from "../editorScenarios.js";
+describe('session scenario filtering for re-registered scenarios', () => {
+    // Simulate a working session that started at 14:00
+    const featureStartedAt = '2026-03-12T14:00:00.000Z';
+    const sqliteTimestamp = convertIsoToSqliteTimestamp(featureStartedAt);
+    // Scenario rows as they'd appear in the database
+    const freshScenario = {
+        id: 'fresh-1',
+        name: 'Library Page - With Articles',
+        url: '/Library.html',
+        created_at: '2026-03-12 14:15:00', // Created in THIS session
+        updated_at: '2026-03-12 14:15:00',
+    };
+    const reregisteredPopupScenario = {
+        id: 'popup-1',
+        name: 'Library - Rich Collection',
+        url: '/popup.html',
+        created_at: '2026-03-11 10:00:00', // Created in PREVIOUS session
+        updated_at: '2026-03-12 14:20:00', // Re-registered in THIS session
+    };
+    const oldScenario = {
+        id: 'old-1',
+        name: 'Library - Empty State',
+        url: '/Library.html',
+        created_at: '2026-03-11 09:00:00', // Old
+        updated_at: '2026-03-11 09:00:00', // Never re-registered
+    };
+    const allRows = [freshScenario, reregisteredPopupScenario, oldScenario];
+    it('BUG: created_at-only filter excludes re-registered scenarios', () => {
+        // This is the buggy filter from editor.tsx line 180-181:
+        // (row) => (row as any).created_at >= sqliteTimestamp
+        const createdAtOnlyFilter = allRows.filter((row) => row.created_at >= sqliteTimestamp);
+        // Only the fresh scenario passes — the re-registered popup is EXCLUDED
+        expect(createdAtOnlyFilter.map((r) => r.name)).toEqual([
+            'Library Page - With Articles',
+        ]);
+        // The popup scenario is missing! This is why popup scenarios don't show
+        // in Working Session Results despite being re-registered in this session.
+        expect(createdAtOnlyFilter.find((r) => r.id === 'popup-1')).toBeUndefined();
+    });
+    it('FIX: isRowInFeatureSession includes re-registered scenarios', () => {
+        // The correct filter uses isRowInFeatureSession which checks both
+        // created_at AND updated_at
+        const correctFilter = allRows.filter((row) => isRowInFeatureSession(row, sqliteTimestamp));
+        // Both the fresh scenario AND the re-registered popup are included
+        expect(correctFilter.map((r) => r.name)).toEqual([
+            'Library Page - With Articles',
+            'Library - Rich Collection',
+        ]);
+        // The old scenario (never re-registered) is correctly excluded
+        expect(correctFilter.find((r) => r.id === 'old-1')).toBeUndefined();
+    });
+});
+//# sourceMappingURL=editorSessionFilter.test.js.map

package/codeyam-cli/src/utils/__tests__/editorSessionFilter.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"editorSessionFilter.test.js","sourceRoot":"","sources":["../../../../../src/utils/__tests__/editorSessionFilter.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;GAWG;AAEH,OAAO,EACL,qBAAqB,EACrB,2BAA2B,GAC5B,MAAM,oBAAoB,CAAC;AAE5B,QAAQ,CAAC,wDAAwD,EAAE,GAAG,EAAE;IACtE,mDAAmD;IACnD,MAAM,gBAAgB,GAAG,0BAA0B,CAAC;IACpD,MAAM,eAAe,GAAG,2BAA2B,CAAC,gBAAgB,CAAC,CAAC;IAEtE,iDAAiD;IACjD,MAAM,aAAa,GAAG;QACpB,EAAE,EAAE,SAAS;QACb,IAAI,EAAE,8BAA8B;QACpC,GAAG,EAAE,eAAe;QACpB,UAAU,EAAE,qBAAqB,EAAE,0BAA0B;QAC7D,UAAU,EAAE,qBAAqB;KAClC,CAAC;IAEF,MAAM,yBAAyB,GAAG;QAChC,EAAE,EAAE,SAAS;QACb,IAAI,EAAE,2BAA2B;QACjC,GAAG,EAAE,aAAa;QAClB,UAAU,EAAE,qBAAqB,EAAE,8BAA8B;QACjE,UAAU,EAAE,qBAAqB,EAAE,gCAAgC;KACpE,CAAC;IAEF,MAAM,WAAW,GAAG;QAClB,EAAE,EAAE,OAAO;QACX,IAAI,EAAE,uBAAuB;QAC7B,GAAG,EAAE,eAAe;QACpB,UAAU,EAAE,qBAAqB,EAAE,MAAM;QACzC,UAAU,EAAE,qBAAqB,EAAE,sBAAsB;KAC1D,CAAC;IAEF,MAAM,OAAO,GAAG,CAAC,aAAa,EAAE,yBAAyB,EAAE,WAAW,CAAC,CAAC;IAExE,EAAE,CAAC,8DAA8D,EAAE,GAAG,EAAE;QACtE,yDAAyD;QACzD,sDAAsD;QACtD,MAAM,mBAAmB,GAAG,OAAO,CAAC,MAAM,CACxC,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,UAAU,IAAI,eAAe,CAC3C,CAAC;QAEF,uEAAuE;QACvE,MAAM,CAAC,mBAAmB,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC;YACrD,8BAA8B;SAC/B,CAAC,CAAC;QACH,wEAAwE;QACxE,0EAA0E;QAC1E,MAAM,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,SAAS,CAAC,CAAC,CAAC,aAAa,EAAE,CAAC;IAC9E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6DAA6D,EAAE,GAAG,EAAE;QACrE,kEAAkE;QAClE,4BAA4B;QAC5B,MAAM,aAAa,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC,GAAG,EAAE,EAAE,CAC3C,qBAAqB,CAAC,GAAG,EAAE,eAAe,CAAC,CAC5C,CAAC;QAEF,mEAAmE;QACnE,MAAM,CAAC,aAAa,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC;YAC/C,8BAA8B;YAC9B,2BAA2B;SAC5B,CAAC,CAAC;QACH,+DAA+D;QAC/D,MAAM,CAAC,aAAa,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,OAAO,CAAC,CAAC,CAAC,aAAa,EAAE,CAAC;IACtE,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/codeyam-cli/src/utils/__tests__/editorShouldRevalidate.test.js

@@ -0,0 +1,53 @@
+import { editorShouldRevalidate } from "../editorShouldRevalidate.js";
+// Minimal mock for ShouldRevalidateFunctionArgs
+function makeArgs(currentPath, nextPath, formMethod) {
+    return {
+        currentUrl: new URL(`http://localhost${currentPath}`),
+        nextUrl: new URL(`http://localhost${nextPath}`),
+        currentParams: {},
+        nextParams: {},
+        formMethod: formMethod || null,
+        formAction: null,
+        formEncType: null,
+        formData: undefined,
+        actionResult: undefined,
+        defaultShouldRevalidate: true,
+    };
+}
+describe('editorShouldRevalidate', () => {
+    it('should skip loader for editor → editor/entity navigation', () => {
+        expect(editorShouldRevalidate(makeArgs('/editor', '/editor/entity/abc123'))).toBe(false);
+    });
+    it('should skip loader for editor/entity → editor navigation', () => {
+        expect(editorShouldRevalidate(makeArgs('/editor/entity/abc123', '/editor'))).toBe(false);
+    });
+    it('should skip loader for entity → different entity navigation', () => {
+        expect(editorShouldRevalidate(makeArgs('/editor/entity/abc', '/editor/entity/def'))).toBe(false);
+    });
+    it('should allow revalidation on same-URL (SSE refresh)', () => {
+        expect(editorShouldRevalidate(makeArgs('/editor/entity/abc', '/editor/entity/abc'))).toBe(true);
+    });
+    it('should allow revalidation on form submission', () => {
+        expect(editorShouldRevalidate(makeArgs('/editor', '/editor/entity/abc', 'POST'))).toBe(true);
+    });
+    it('should allow revalidation for non-editor routes', () => {
+        expect(editorShouldRevalidate(makeArgs('/entity/sha/tab', '/editor'))).toBe(true);
+    });
+    // Path-based tab navigation
+    it('should skip loader for tab change (build → structure)', () => {
+        expect(editorShouldRevalidate(makeArgs('/editor/build', '/editor/structure'))).toBe(false);
+    });
+    it('should skip loader for tab change (editor → build)', () => {
+        expect(editorShouldRevalidate(makeArgs('/editor', '/editor/build'))).toBe(false);
+    });
+    it('should skip loader for tab change on entity (entity → entity/build)', () => {
+        expect(editorShouldRevalidate(makeArgs('/editor/entity/abc', '/editor/entity/abc/build'))).toBe(false);
+    });
+    it('should skip loader for tab change on entity (entity/build → entity/journal)', () => {
+        expect(editorShouldRevalidate(makeArgs('/editor/entity/abc/build', '/editor/entity/abc/journal'))).toBe(false);
+    });
+    it('should allow revalidation on same tab URL (SSE refresh)', () => {
+        expect(editorShouldRevalidate(makeArgs('/editor/build', '/editor/build'))).toBe(true);
+    });
+});
+//# sourceMappingURL=editorShouldRevalidate.test.js.map

package/codeyam-cli/src/utils/__tests__/editorShouldRevalidate.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"editorShouldRevalidate.test.js","sourceRoot":"","sources":["../../../../../src/utils/__tests__/editorShouldRevalidate.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,sBAAsB,EAAE,MAAM,2BAA2B,CAAC;AAEnE,gDAAgD;AAChD,SAAS,QAAQ,CAAC,WAAmB,EAAE,QAAgB,EAAE,UAAmB;IAC1E,OAAO;QACL,UAAU,EAAE,IAAI,GAAG,CAAC,mBAAmB,WAAW,EAAE,CAAC;QACrD,OAAO,EAAE,IAAI,GAAG,CAAC,mBAAmB,QAAQ,EAAE,CAAC;QAC/C,aAAa,EAAE,EAAE;QACjB,UAAU,EAAE,EAAE;QACd,UAAU,EAAE,UAAU,IAAI,IAAI;QAC9B,UAAU,EAAE,IAAI;QAChB,WAAW,EAAE,IAAI;QACjB,QAAQ,EAAE,SAAS;QACnB,YAAY,EAAE,SAAS;QACvB,uBAAuB,EAAE,IAAI;KACvB,CAAC;AACX,CAAC;AAED,QAAQ,CAAC,wBAAwB,EAAE,GAAG,EAAE;IACtC,EAAE,CAAC,0DAA0D,EAAE,GAAG,EAAE;QAClE,MAAM,CACJ,sBAAsB,CAAC,QAAQ,CAAC,SAAS,EAAE,uBAAuB,CAAC,CAAC,CACrE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAChB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0DAA0D,EAAE,GAAG,EAAE;QAClE,MAAM,CACJ,sBAAsB,CAAC,QAAQ,CAAC,uBAAuB,EAAE,SAAS,CAAC,CAAC,CACrE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAChB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6DAA6D,EAAE,GAAG,EAAE;QACrE,MAAM,CACJ,sBAAsB,CACpB,QAAQ,CAAC,oBAAoB,EAAE,oBAAoB,CAAC,CACrD,CACF,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAChB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qDAAqD,EAAE,GAAG,EAAE;QAC7D,MAAM,CACJ,sBAAsB,CACpB,QAAQ,CAAC,oBAAoB,EAAE,oBAAoB,CAAC,CACrD,CACF,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACf,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8CAA8C,EAAE,GAAG,EAAE;QACtD,MAAM,CACJ,sBAAsB,CAAC,QAAQ,CAAC,SAAS,EAAE,oBAAoB,EAAE,MAAM,CAAC,CAAC,CAC1E,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACf,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iDAAiD,EAAE,GAAG,EAAE;QACzD,MAAM,CAAC,sBAAsB,CAAC,QAAQ,CAAC,iBAAiB,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,CACzE,IAAI,CACL,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,4BAA4B;IAC5B,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;QAC/D,MAAM,CACJ,sBAAsB,CAAC,QAAQ,CAAC,eAAe,EAAE,mBAAmB,CAAC,CAAC,CACvE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAChB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC5D,MAAM,CAAC,sBAAsB,CAAC,QAAQ,CAAC,SAAS,EAAE,eAAe,CAAC,CAAC,CAAC,CAAC,IAAI,CACvE,KAAK,CACN,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qEAAqE,EAAE,GAAG,EAAE;QAC7E,MAAM,CACJ,sBAAsB,CACpB,QAAQ,CAAC,oBAAoB,EAAE,0BAA0B,CAAC,CAC3D,CACF,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAChB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6EAA6E,EAAE,GAAG,EAAE;QACrF,MAAM,CACJ,sBAAsB,CACpB,QAAQ,CAAC,0BAA0B,EAAE,4BAA4B,CAAC,CACnE,CACF,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAChB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yDAAyD,EAAE,GAAG,EAAE;QACjE,MAAM,CACJ,sBAAsB,CAAC,QAAQ,CAAC,eAAe,EAAE,eAAe,CAAC,CAAC,CACnE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACf,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}