@codeyam/codeyam-cli 0.1.0-staging.28f73cf → 0.1.0-staging.323686

package/analyzer-template/packages/ai/src/lib/dataStructure/equivalencyManagers/frameworks/ReactFrameworkManager.ts

@@ -17,6 +17,12 @@ interface UseStateInfo {
 export class ReactFrameworkManager implements EquivalencyManager {
   private useStateInfos: UseStateInfo[] = [];
   private useCallbackEquivalents: Record<string, string> = {};
+  // Track variables used as ref props - they should be typed as 'null'
+  // Format: { scopeNodeName -> Set of variable paths }
+  private refVariables: Map<string, Set<string>> = new Map();
+  // Track ref variable source paths for updating external function call schemas in finalize
+  // Format: { functionCallName -> Set of source paths (e.g., 'useAutoAnimate().functionCallReturnValue[]') }
+  private refVariableSources: Map<string, Set<string>> = new Map();
 
   postProcess(scopeNode: ScopeNode, scopeDataStructure: ScopeDataStructure) {
     this.handleUseState(scopeNode, scopeDataStructure);
@@ -139,7 +145,27 @@ export class ReactFrameworkManager implements EquivalencyManager {
     'main',
   ]);
 
-  finalize(_scopeNode: ScopeNode, _scopeDataStructure: ScopeDataStructure) {}
+  finalize(scopeNode: ScopeNode, scopeDataStructure: ScopeDataStructure) {
+    // Set all tracked ref variables to 'null' type
+    // This ensures mock data generation uses null instead of placeholder strings
+    const refVarsForScope = this.refVariables.get(scopeNode.name);
+    if (refVarsForScope) {
+      for (const refVar of refVarsForScope) {
+        scopeNode.schema[refVar] = 'null';
+      }
+    }
+
+    // Update external function call schemas with ref source paths
+    // This runs AFTER schema building is complete, so the null values won't be overwritten
+    for (const efc of scopeDataStructure.externalFunctionCalls) {
+      const refSourcePaths = this.refVariableSources.get(efc.name);
+      if (refSourcePaths) {
+        for (const sourcePath of refSourcePaths) {
+          efc.schema[sourcePath] = 'null';
+        }
+      }
+    }
+  }
 
   private findUseStateInfo(useStateCall: string) {
     return this.useStateInfos.find(
@@ -213,10 +239,18 @@ export class ReactFrameworkManager implements EquivalencyManager {
             });
           }
 
+          // Get the initial value path (what signature[0] is equivalent to)
+          const initialValuePath = equivalentValues[0].schemaPath;
+          const initialValueScopeName = equivalentValues[0].scopeNodeName;
+
+          // Note: Callback scope tracing (for useState(() => { return prop; }))
+          // is handled in getEquivalentSignatureVariables() where the full
+          // equivalency database is available for deep tracing.
+
           scopeDataStructure.addEquivalency(
             relevantUseStateInfo.value,
-            equivalentValues[0].schemaPath,
-            scopeNode.name,
+            initialValuePath,
+            initialValueScopeName,
             scopeNode,
             'useState value equivalency',
           );
@@ -251,9 +285,9 @@ export class ReactFrameworkManager implements EquivalencyManager {
               equivalentPathParts[0].replace(existingFunctionName, ''),
             ...equivalentPathParts.slice(1),
           ]);
-          for (const equivalentValue of scopeNode.equivalencies[
-            equivalentPath
-          ]) {
+          const equivalenciesToReroute =
+            scopeNode.equivalencies[equivalentPath] ?? [];
+          for (const equivalentValue of equivalenciesToReroute) {
             scopeDataStructure.removeEquivalency(
               equivalentPath,
               equivalentValue,
@@ -273,7 +307,9 @@ export class ReactFrameworkManager implements EquivalencyManager {
           equivalentPath = newEquivalentPath;
         }
 
-        for (const equivalentValue of scopeNode.equivalencies[equivalentPath]) {
+        const equivalenciesToModify =
+          scopeNode.equivalencies[equivalentPath] ?? [];
+        for (const equivalentValue of equivalenciesToModify) {
           if (equivalentValue.scopeNodeName === useCallbackScopeInfoName) {
             modifiedEquivalencies = true;
             equivalentValue.scopeNodeName =
@@ -380,90 +416,126 @@ export class ReactFrameworkManager implements EquivalencyManager {
     let propagated = false;
     const functionCallSignature = getFunctionCallSignature(subPathParts);
 
-    const relevantUseStateInfo = this.findUseStateInfo(functionCallSignature);
+    let relevantUseStateInfo = this.findUseStateInfo(functionCallSignature);
+
+    // If we didn't find a useState call directly, check if the function being called
+    // is a setter variable (e.g., setWorkouts from useState)
+    if (!relevantUseStateInfo && functionCallSignature) {
+      // Extract the function name from the call (e.g., "setWorkouts" from "setWorkouts(data || [])")
+      const fnName = functionCallSignature.split('(')[0];
+      relevantUseStateInfo = this.useStateInfos.find(
+        (info) => info.setter === fnName,
+      );
+    }
 
     if (relevantUseStateInfo) {
       const pathParts = scopeDataStructure.splitPath(path);
-      if (pathParts.length < 3) return false;
 
-      const basePath = scopeDataStructure.joinPathParts([
-        ...pathParts.slice(0, 2),
-        pathParts[2],
-      ]);
+      // Check if this is a direct setter variable call (e.g., setWorkouts(data).signature[0])
+      // rather than a useState path (e.g., useState<X>().functionCallReturnValue[1].signature[0])
+      const fnName = functionCallSignature?.split('(')[0];
+      const isDirectSetterCall = fnName === relevantUseStateInfo.setter;
+
+      if (isDirectSetterCall && pathParts.length === 2) {
+        // Handle direct setter calls like setWorkouts(data || []).signature[0] = data
+        const lastPart = pathParts[1];
+        if (lastPart === 'signature[0]') {
+          // Get the value being passed to the setter from the equivalency
+          const originScopeInfoName =
+            equivalencyValueChain[0]?.currentPath?.scopeNodeName;
+          if (!originScopeInfoName) return propagated;
+
+          const originScope =
+            scopeDataStructure.getScopeOrFunctionCallInfo(originScopeInfoName);
+          const setterCallEquiv = originScope?.equivalencies?.[path];
+          if (!setterCallEquiv || setterCallEquiv.length === 0)
+            return propagated;
+
+          const argumentPath = setterCallEquiv[0].schemaPath;
+          const argumentScopeName = setterCallEquiv[0].scopeNodeName;
+
+          // Create equivalency: useState<X>().functionCallReturnValue[0] = argumentPath
+          propagated = true;
+          const valuePath = `${relevantUseStateInfo.useStateCall}.functionCallReturnValue[0]`;
+          const useStateScopeInfo =
+            scopeDataStructure.getScopeOrFunctionCallInfo(
+              relevantUseStateInfo.scopeNodeName,
+            ) as ScopeNode;
 
-      const expectedSetterBasePath = scopeDataStructure.joinPathParts([
-        functionCallSignature,
-        'functionCallReturnValue[1]',
-      ]);
+          scopeDataStructure.addEquivalency(
+            valuePath,
+            argumentPath,
+            argumentScopeName,
+            useStateScopeInfo,
+            'useState setter call equivalency (direct)',
+            equivalencyValueChain,
+            traceId,
+          );
+        }
+      } else if (pathParts.length >= 3) {
+        // Original logic for useState path patterns
+        const basePath = scopeDataStructure.joinPathParts([
+          ...pathParts.slice(0, 2),
+          pathParts[2],
+        ]);
 
-      // if (traceId) {
-      //   console.info(
-      //     'Debug Propagation: useState base path',
-      //     JSON.stringify(
-      //       {
-      //         traceId,
-      //         basePath,
-      //         expectedValueBasePath,
-      //         expectedSetterBasePath,
-      //       },
-      //       null,
-      //       2,
-      //     ),
-      //   );
-      // }
-
-      if (basePath === expectedSetterBasePath) {
-        const originScopeInfoName =
-          equivalencyValueChain[0].currentPath?.scopeNodeName;
-        const setterScope =
-          scopeDataStructure.getScopeOrFunctionCallInfo(originScopeInfoName);
-        const setterEquivalencyPath = Object.keys(
-          setterScope.equivalencies,
-        ).find((p) => {
-          if (!p.startsWith(relevantUseStateInfo.setter)) return false;
-          const pParts = scopeDataStructure.splitPath(p);
-
-          const valid = pathParts
-            .slice(3)
-            .reverse()
-            .every((part, index) => [...pParts].reverse()[index] === part);
-
-          // if (p.includes('.title') && valid)
-          //   console.info({ p, pParts, pathParts: pathParts.slice(3) });
-
-          return valid;
-        });
-
-        if (!setterEquivalencyPath) return;
-
-        const setterEquivalencyPathParts = scopeDataStructure.splitPath(
-          setterEquivalencyPath,
-        );
-        const setterEquivalentVariable =
-          setterScope.equivalencies[setterEquivalencyPath][0].schemaPath;
+        const expectedSetterBasePath = scopeDataStructure.joinPathParts([
+          functionCallSignature,
+          'functionCallReturnValue[1]',
+        ]);
 
-        if (setterEquivalentVariable === expectedSetterBasePath) return;
+        if (basePath === expectedSetterBasePath) {
+          const originScopeInfoName =
+            equivalencyValueChain[0].currentPath?.scopeNodeName;
+          const setterScope =
+            scopeDataStructure.getScopeOrFunctionCallInfo(originScopeInfoName);
+          const setterEquivalencyPath = Object.keys(
+            setterScope.equivalencies,
+          ).find((p) => {
+            if (!p.startsWith(relevantUseStateInfo.setter)) return false;
+            const pParts = scopeDataStructure.splitPath(p);
+
+            const valid = pathParts
+              .slice(3)
+              .reverse()
+              .every((part, index) => [...pParts].reverse()[index] === part);
+
+            return valid;
+          });
+
+          if (!setterEquivalencyPath) return propagated;
+
+          const setterEquivalencyPathParts = scopeDataStructure.splitPath(
+            setterEquivalencyPath,
+          );
+          const setterEquivalentVariable =
+            setterScope.equivalencies[setterEquivalencyPath][0].schemaPath;
 
-        propagated = true;
-        const valuePath = `${functionCallSignature}.functionCallReturnValue[0]`;
-        const useStateScopeInfo = scopeDataStructure.getScopeOrFunctionCallInfo(
-          relevantUseStateInfo.scopeNodeName,
-        ) as ScopeNode;
+          if (setterEquivalentVariable === expectedSetterBasePath)
+            return propagated;
 
-        const fullValuePath = scopeDataStructure.joinPathParts([
-          valuePath,
-          ...setterEquivalencyPathParts.slice(2),
-        ]);
+          propagated = true;
+          const valuePath = `${functionCallSignature}.functionCallReturnValue[0]`;
+          const useStateScopeInfo =
+            scopeDataStructure.getScopeOrFunctionCallInfo(
+              relevantUseStateInfo.scopeNodeName,
+            ) as ScopeNode;
+
+          const fullValuePath = scopeDataStructure.joinPathParts([
+            valuePath,
+            ...setterEquivalencyPathParts.slice(2),
+          ]);
 
-        scopeDataStructure.addEquivalency(
-          fullValuePath,
-          setterEquivalentVariable,
-          originScopeInfoName,
-          useStateScopeInfo,
-          'useState setter call equivalency',
-          equivalencyValueChain,
-          traceId,
-        );
+          scopeDataStructure.addEquivalency(
+            fullValuePath,
+            setterEquivalentVariable,
+            originScopeInfoName,
+            useStateScopeInfo,
+            'useState setter call equivalency',
+            equivalencyValueChain,
+            traceId,
+          );
+        }
       }
     }
 
@@ -562,6 +634,102 @@ export class ReactFrameworkManager implements EquivalencyManager {
     for (const [equivalentPath, equivalentValues] of Object.entries(
       scopeNode.equivalencies,
     )) {
+      // Check if the equivalency KEY (e.g., "div().signature[0].ref") ends with .ref
+      // If so, the VALUE (e.g., "parent") should be marked as null
+      const equivalentPathParts = scopeDataStructure.splitPath(equivalentPath);
+      const pathLength = equivalentPathParts.length;
+
+      if (pathLength >= 2) {
+        const secondToLast = equivalentPathParts[pathLength - 2];
+        const last = equivalentPathParts[pathLength - 1];
+
+        if (secondToLast === 'signature[0]' && last === 'ref') {
+          // This is a ref prop usage like div().signature[0].ref -> parent
+          for (const equivalentValue of equivalentValues) {
+            propagated = true;
+
+            // Track this variable as a ref - we'll set its type to 'null' in finalize()
+            // after the schema is built (setting directly here would be overwritten)
+            // IMPORTANT: The ref variable might be defined in a parent scope, not the
+            // current scope. We need to find where the variable is actually defined by
+            // walking up the scope tree.
+            const varName = equivalentValue.schemaPath;
+            let targetScope: ScopeNode | null = scopeNode;
+
+            // Walk up the scope tree to find where this variable is defined
+            while (targetScope) {
+              // Check if this scope has the variable in its schema or equivalencies
+              const hasVariable =
+                varName in (targetScope.schema || {}) ||
+                varName in (targetScope.equivalencies || {});
+
+              if (hasVariable) {
+                if (!this.refVariables.has(targetScope.name)) {
+                  this.refVariables.set(targetScope.name, new Set());
+                }
+                this.refVariables.get(targetScope.name)!.add(varName);
+
+                // IMPORTANT: Also update the source of the ref variable in the external
+                // function call's schema. This ensures dataForMocks produces [null]
+                // instead of ["string"] for hooks like useAutoAnimate.
+                const varEquivalencies = targetScope.equivalencies?.[varName];
+                if (varEquivalencies) {
+                  for (const varEquivalency of varEquivalencies) {
+                    const sourcePath = varEquivalency.schemaPath;
+                    // Check if this comes from an external function call
+                    // (contains functionCallReturnValue which indicates it's a hook/function return)
+                    if (sourcePath.includes('functionCallReturnValue')) {
+                      // Store the source path for later - we'll update the external function
+                      // call's schema in finalize() which runs AFTER schema building is complete.
+                      // Setting it here would be overwritten by later schema building.
+                      for (const efc of scopeDataStructure.externalFunctionCalls) {
+                        if (sourcePath.startsWith(efc.name)) {
+                          if (!this.refVariableSources.has(efc.name)) {
+                            this.refVariableSources.set(efc.name, new Set());
+                          }
+                          // Store both the specific indexed path and the generic [] path
+                          this.refVariableSources
+                            .get(efc.name)!
+                            .add(sourcePath);
+                          const genericPath = sourcePath.replace(
+                            /\[\d+\]/g,
+                            '[]',
+                          );
+                          if (genericPath !== sourcePath) {
+                            this.refVariableSources
+                              .get(efc.name)!
+                              .add(genericPath);
+                          }
+                        }
+                      }
+                    }
+                  }
+                }
+              }
+
+              // Move up to parent scope
+              if (targetScope.tree && targetScope.tree.length > 0) {
+                const parentScopeName =
+                  targetScope.tree[targetScope.tree.length - 1];
+                targetScope = scopeDataStructure.getScopeOrFunctionCallInfo(
+                  parentScopeName,
+                ) as ScopeNode | null;
+              } else {
+                targetScope = null;
+              }
+            }
+
+            scopeDataStructure.removeEquivalency(
+              equivalentPath,
+              equivalentValue,
+              scopeNode,
+            );
+          }
+          continue;
+        }
+      }
+
+      // Original logic for checking the value side
       for (const equivalentValue of equivalentValues) {
         const equivalentValueParts = scopeDataStructure.splitPath(
           equivalentValue.schemaPath,

package/analyzer-template/packages/ai/src/lib/dataStructure/helpers/cleanKnownObjectFunctions.ts

@@ -35,6 +35,29 @@ const getParts = (path: string): string[] => {
   return parts;
 };
 
+/**
+ * Clear the module-level cache.
+ * Call this between entity analyses to prevent unbounded memory growth.
+ */
+export function clearCleanKnownObjectFunctionsCache(): {
+  count: number;
+  estimatedBytes: number;
+} {
+  let totalBytes = 0;
+  for (const [key, value] of partsCache) {
+    // Key is a string, value is string[] - estimate UTF-16 encoding (2 bytes per char)
+    totalBytes += key.length * 2;
+    for (const part of value) {
+      totalBytes += part.length * 2;
+    }
+    // Add overhead for array and Map entry (~50 bytes per entry)
+    totalBytes += 50;
+  }
+  const count = partsCache.size;
+  partsCache.clear();
+  return { count, estimatedBytes: totalBytes };
+}
+
 /** pre-compute the prototype-method sets once per module load */
 const protoMethodSets: Record<PrimitiveKind, Set<string>> = {
   array: new Set(
@@ -64,6 +87,14 @@ const protoMethodSets: Record<PrimitiveKind, Set<string>> = {
   ),
 };
 
+/** Built-in properties (not methods) that should be removed from primitives.
+ * These are properties that exist on the prototype and shouldn't appear
+ * as schema entries (they cause malformed mock data structures). */
+const protoPropertySets: Partial<Record<PrimitiveKind, Set<string>>> = {
+  array: new Set(['length']),
+  string: new Set(['length']),
+};
+
 /**
  * Extract primitive kind from a type string, handling union types.
  * E.g., "number | undefined" -> "number", "string | null" -> "string"
@@ -118,11 +149,21 @@ function scrub(
       const rootKind = rootTable.get(prefix);
       if (!rootKind) continue;
 
-      const rawMethod = keyParts[cut].split('(')[0];
+      const rawToken = keyParts[cut];
+      const rawMethod = rawToken.split('(')[0];
+
+      // Check if it's a prototype method (e.g., map, filter, toString)
       if (protoMethodSets[rootKind].has(rawMethod)) {
         onRemove(keyPath);
         break;
       }
+
+      // Check if it's a built-in property (e.g., length on arrays/strings)
+      const propertySet = protoPropertySets[rootKind];
+      if (propertySet && propertySet.has(rawToken)) {
+        onRemove(keyPath);
+        break;
+      }
     }
   }
 }