@codeyam/codeyam-cli 0.1.0-staging.1 → 0.1.0-staging.28f73cf

package/analyzer-template/packages/ai/src/lib/getConditionalUsagesFromCode.ts

@@ -259,8 +259,16 @@ function getLiteralValue(expr: ts.Expression): string | undefined {
 /**
  * Format conditional usages into a string for the LLM prompt
  */
+/**
+ * Interface for conditional usages that may have source tracing information.
+ * This is a superset of ConditionalUsage that includes optional sourceDataPath.
+ */
+interface EnrichedConditionalUsageInput extends ConditionalUsage {
+  sourceDataPath?: string;
+}
+
 export function formatConditionalUsagesForPrompt(
-  conditionalUsages: Record<string, ConditionalUsage[]>,
+  conditionalUsages: Record<string, EnrichedConditionalUsageInput[]>,
 ): string {
   const entries = Object.entries(conditionalUsages);
   if (entries.length === 0) {
@@ -270,7 +278,7 @@ export function formatConditionalUsagesForPrompt(
   const lines: string[] = [
     '\n## Static Analysis: Attributes Used in Conditionals',
     '',
-    'The following attributes were found to be used in conditional statements, making them potential key attributes:',
+    'The following attributes were found to be used in conditional statements, making them very likely key attributes:',
     '',
   ];
 
@@ -281,20 +289,30 @@ export function formatConditionalUsagesForPrompt(
       .flatMap((u) => u.comparedValues || []);
     const uniqueValues = [...new Set(allComparedValues)];
 
-    let description = `- "${path}": `;
+    // Get the source data path if available (traced back to data source)
+    const sourceDataPath = usages.find((u) => u.sourceDataPath)?.sourceDataPath;
+
+    let description = `- "${path}"`;
+
+    // If we have a source data path, show that the local variable derives from a data source
+    if (sourceDataPath) {
+      description += `\n    - Source: "${sourceDataPath}"`;
+    }
+
+    description += '\n    - ';
 
     if (uniqueTypes.includes('switch')) {
-      description += 'used as switch discriminant';
+      description += 'Used as switch discriminant';
       if (uniqueValues.length > 0) {
         description += ` with cases: ${uniqueValues.map((v) => `"${v}"`).join(', ')}`;
       }
     } else if (uniqueTypes.includes('comparison')) {
-      description += 'used in comparison';
+      description += 'Used in comparison';
       if (uniqueValues.length > 0) {
         description += ` against values: ${uniqueValues.map((v) => `"${v}"`).join(', ')}`;
       }
     } else {
-      description += 'used in truthiness check (presence/absence matters)';
+      description += 'Used in truthiness check (presence/absence matters)';
     }
 
     lines.push(description);
@@ -304,6 +322,9 @@ export function formatConditionalUsagesForPrompt(
   lines.push(
     'Consider these attributes as candidates for key attributes, especially those with specific comparison values.',
   );
+  lines.push(
+    'When a local variable derives from a data source, the data source is the key attribute.',
+  );
 
   return lines.join('\n');
 }

package/analyzer-template/packages/ai/src/lib/getLLMCallStats.ts

@@ -2,13 +2,6 @@ import OpenAI from 'openai';
 import { getLLMCallCost } from './getLLMCallCost';
 import { AI, LlmCallStats } from './types';
 
-/**
- * It looks like this function can be massively simplified, and I (AG) think
- * that we aren't using openrouter anymore. But, until this is figured out, it
- * might not be worth refactoring and messing something subtle up. Ideally
- * whatever implicit functionality is in here can be represented in the new
- * `getLLMCallStats` such that this get replaced by it.
- */
 export function getLLMCallStats({
   chatRequest,
   chatCompletion,
@@ -28,13 +21,6 @@ export function getLLMCallStats({
       error: JSON.stringify(chatCompletion.error),
     };
   }
-  if (!chatRequest.model) {
-    // this was previously used to indicate openrouter calls, but we aren't
-    // doing that anymore and anyway it was a pretty obscure way to indicate
-    // that state of affairs. if we bring multi-provider back, we will want
-    // to rewrite a fair bit of this.
-    return null;
-  }
 
   const usage = chatCompletion.usage || {
     prompt_tokens: 0,

package/analyzer-template/packages/ai/src/lib/modelInfo.ts

@@ -27,6 +27,14 @@ export interface ModelInfo {
 
 export const MODEL_INFO: Record<AI.Model, ModelInfo> = {
   // OpenAI models - served directly by OpenAI
+  [AI.Model.OPENAI_GPT5_1]: {
+    id: AI.Model.OPENAI_GPT5_1,
+    provider: OPENAI_PROVIDER,
+    apiModelName: 'gpt-5.1',
+    maxCompletionTokens: 128000,
+    pricing: { input: 1.25, output: 10.0 },
+    reasoningEffort: 'none',
+  },
   [AI.Model.OPENAI_GPT5]: {
     id: AI.Model.OPENAI_GPT5,
     provider: OPENAI_PROVIDER,
@@ -175,6 +183,13 @@ export const MODEL_INFO: Record<AI.Model, ModelInfo> = {
     maxCompletionTokens: 200000,
     pricing: { input: 3.0, output: 15.0 },
   },
+  [AI.Model.ANTHROPIC_CLAUDE_4_5_OPUS]: {
+    id: AI.Model.ANTHROPIC_CLAUDE_4_5_OPUS,
+    provider: ANTHROPIC_PROVIDER,
+    apiModelName: 'claude-opus-4-5',
+    maxCompletionTokens: 200000,
+    pricing: { input: 5.0, output: 25.0 },
+  },
 
   // Deprecated models (kept for backward compatibility)
   [AI.Model.PHIND_CODELLAMA]: {

package/analyzer-template/packages/ai/src/lib/promptGenerators/gatherAttributesMap.ts

@@ -5,9 +5,44 @@ import {
   splitOutsideParenthesesAndArrays,
 } from '../splitOutsideParentheses';
 
+/**
+ * Checks if a bracket-only path is a valid string key access (not just an index).
+ * Valid: ['*'], ['someKey'] - string key access
+ * Invalid: [0], [1] - numeric index only (meaningless without parent path)
+ */
+function isValidBracketStringKey(attribute: string): boolean {
+  // Match ['string'] or ["string"] patterns
+  return /^\[['"][^'"]+['"]\]$/.test(attribute);
+}
+
+/**
+ * Extracts the string key from a bracket notation like ['*'] or ["key"]
+ * Returns the key without quotes and brackets, e.g., '*' or 'key'
+ */
+function extractBracketStringKey(attribute: string): string | null {
+  const match = attribute.match(/^\[['"]([^'"]+)['"]\]$/);
+  return match ? match[1] : null;
+}
+
+/**
+ * Normalizes a path by extracting string keys from bracket notation.
+ * If the path is a single bracket string key like ['*'], returns the key ('*').
+ * Otherwise returns the path unchanged.
+ */
+function normalizePathForInternalUse(path: string): string {
+  const extracted = extractBracketStringKey(path);
+  return extracted !== null ? extracted : path;
+}
+
 function validAttribute(attribute: string) {
-  if (!attribute || attribute.length === 0 || attribute.startsWith('['))
-    return false;
+  if (!attribute || attribute.length === 0) return false;
+
+  // Allow string-key bracket access like ['*'] or ['someKey']
+  // These are valid data paths from objects with dynamic/special keys
+  if (attribute.startsWith('[')) {
+    return isValidBracketStringKey(attribute);
+  }
+
   const attributeParts = splitOutsideParenthesesAndArrays(attribute);
   if (
     attributeParts.some((part) =>
@@ -153,8 +188,11 @@ export function gatherAttributesMap(
           // Fall through to normal processing for other return value properties
         }
 
-        const relativePath = joinParenthesesAndArrays(pathParts.slice(2));
-        if (!validAttribute(relativePath)) continue;
+        const rawRelativePath = joinParenthesesAndArrays(pathParts.slice(2));
+        if (!validAttribute(rawRelativePath)) continue;
+
+        // Normalize the path for internal use (e.g., ['*'] -> '*')
+        const relativePath = normalizePathForInternalUse(rawRelativePath);
 
         attributesMap[relativePath] = returnValueDataStructure[path];
         associationMap[reverse ? relativePath : path] = reverse

package/analyzer-template/packages/ai/src/lib/promptGenerators/generateChangesEntityDocumentationGenerator.ts

@@ -4,44 +4,19 @@ export default function generateChangesEntityDocumentationGenerator(
   entity: Entity,
   previousDocumentation: string,
 ) {
-  return `A function recently changed. Here is the current documentation for that function:
+  return `## Task
+Review if the existing documentation is still accurate after code changes. If accurate, respond "No changes needed". Otherwise, provide updated documentation.
 
-"""
+## Current Documentation
 ${previousDocumentation}
-"""  
 
-and here is the new code for ${entity.name}:
-  
-"""
+## Updated Code
+\`\`\`typescript
 ${entity.code}
-"""
-
-If the existing documentation is still accurate please respond with "No changes needed". 
-
-Otherwise, please update the documentation to reflect the changes in the code. Using these instructions:
-
-- Start with an overview that describes the overall intent of the code. Be concise in your language. Immediately start with the intent of the code. Here is an example Overview:
-
-\`\`\` Overview
-Displays details about a specific Git commit. It shows the commit message, author, date, and provides a link to the commit on GitHub. Users can copy the commit SHA to their clipboard, with a visual indication of the copy action.
 \`\`\`
 
-Note that it does not mention the name of the function but dives directly into what the code does in concise language followed by a small amount of detail.
-
-- Next, specify the inputs (with details about types, how the input is used, and examples) and expected outputs (with details about types and examples).
-
-- Finally, provide examples of how the code can be used with clear inputs and outputs for each example. Provide diverse examples (there's no need to include repetitive examples). 
-
-Write the documentation as markdown. Be concise. Use bullets when possible. No one wants to read long paragraphs of text. 
-
-Provide no other text than the documentation in proper markdown using the headers below.
-
-## Overview
-
-## Inputs
-
-## Output
+## Overview Example
+Good: "Displays details about a specific Git commit. Shows the commit message, author, date, and provides a link to GitHub."
 
-## Examples
-`;
+Bad: "The CommitDetails function takes a commit object..." (mentions the function name)`;
 }

package/analyzer-template/packages/ai/src/lib/promptGenerators/generateChangesEntityScenarioDataGenerator.ts

@@ -52,77 +52,69 @@ export default function generateChangesEntityScenarioDataGenerator(
   defaultScenarioData?: ScenarioData,
   incompleteResponse?: string,
 ) {
-  return `${
-    incompleteResponse
-      ? `## Incomplete Response
-
-Here is the incomplete response. Please use this and the following data to complete the response, only returning the missing data.
-
-Just pick up where this response left off. It will be improper json but we will combine the responses into proper json.
-
-\`\`\` START INCOMPLETE RESPONSE \`\`\`
+  const incompleteSection = incompleteResponse
+    ? `## Incomplete Response
+Continue from where this left off (combine for valid JSON):
+\`\`\`
 ${incompleteResponse}
-\`\`\` END INCOMPLETE RESPONSE \`\`\`
+\`\`\`
 
 `
-      : ''
-  }## Scenario
-  
-This scenario needs mock data to support it. Here are the keyAttributeInstructions for generating this scenario:
-\`\`\`
-${JSON.stringify(
-  {
-    name: scenario.name,
-    description: scenario.description,
-    keyAttributeInstructions: scenario.metadata.keyAttributeInstructions,
-  },
-  null,
-  2,
-)}
-\`\`\`
+    : '';
 
-## Existing Scenario
-  
-Here are the "keyAttributeInstructions" and data for this scenario before this more recent code change. Please maintain the existing data as effectively as possible while fulfilling the new data structure and "keyAttributeInstructions".
-\`\`\`
-${JSON.stringify(
-  {
-    name: existingScenario.name,
-    data: filterData(structure, existingScenario.metadata.data),
-  },
-  null,
-  2,
-)}
-\`\`\`
-${
-  defaultScenarioData
-    ? `
-## Default Scenario
+  const scenarioJson = JSON.stringify(
+    {
+      name: scenario.name,
+      description: scenario.description,
+      keyAttributeInstructions: scenario.metadata.keyAttributeInstructions,
+    },
+    null,
+    2,
+  );
 
-Data for the default scenario. Do not modify it. The data you are generating will be merged into it to create the full data.
-\`\`\`
+  const existingJson = JSON.stringify(
+    {
+      name: existingScenario.name,
+      data: filterData(structure, existingScenario.metadata.data),
+    },
+    null,
+    2,
+  );
+
+  const defaultSection = defaultScenarioData
+    ? `
+## Default Scenario Data (merge base, do not modify)
+\`\`\`json
 ${JSON.stringify(defaultScenarioData.data, null, 2)}
 \`\`\`
 `
-    : ''
-}
-${
-  structure.dataForMocks
-    ? `The mockData structure (for the default scenario provide robust values for the entire structure):
-\`\`\`
+    : '';
+
+  const mockDataSection = structure.dataForMocks
+    ? `## mockData Structure
+\`\`\`json
 ${JSON.stringify(structure.dataForMocks, null, 2)}
-\`\`\`
-`
-    : 'There is no mockData for this file. Return {} for the mockData.'
-}
-    
-${
-  structure.arguments
-    ? `The argumentsData structure (for the default scenario provide robust values for the entire structure):
-\`\`\`
+\`\`\``
+    : '## mockData Structure\nNone—return `{}` for mockData.';
+
+  const argumentsSection = structure.arguments
+    ? `## argumentsData Structure
+\`\`\`json
 ${JSON.stringify(structure.arguments, null, 2)}
+\`\`\``
+    : '## argumentsData Structure\nNone—return `[]` for argumentsData.';
+
+  return `${incompleteSection}## Scenario (new instructions)
+\`\`\`json
+${scenarioJson}
 \`\`\`
-`
-    : 'There is no argumentsData for this file. Return [] for the argumentsData.'
-}`;
+
+## Existing Scenario (preserve where possible)
+\`\`\`json
+${existingJson}
+\`\`\`
+${defaultSection}
+${mockDataSection}
+
+${argumentsSection}`;
 }

package/analyzer-template/packages/ai/src/lib/promptGenerators/generateChangesEntityScenariosGenerator.ts

@@ -41,7 +41,7 @@ export default function generateChangesEntityScenariosGenerator({
     const filePath = (attr as any).filePath;
     const entityName = (attr as any).originalEntityName;
 
-    if (!filePath || !entityName) continue; // Skip if missing required fields
+    if (!filePath || !entityName) continue;
 
     if (!relevantDependentKeyAttributes[filePath]) {
       relevantDependentKeyAttributes[filePath] = {};
@@ -52,128 +52,112 @@ export default function generateChangesEntityScenariosGenerator({
     relevantDependentKeyAttributes[filePath][entityName].push(attr);
   }
 
-  return `Added Key Attributes:
-
-\`\`\`
-${
-  addedKeyAttributes && addedKeyAttributes.length > 0
-    ? JSON.stringify(
-        addedKeyAttributes.map((ka) => ({
-          dataStructurePath: ka.dataStructurePath, // Full path in mockData
-          localVariable: ka.internalPath, // Local variable name
-          description: ka.description,
-          validValueOptions: ka.validValueOptions,
-        })),
-        null,
-        2,
-      )
-    : 'None'
-}
-\`\`\`
-
-Removed Key Attributes:
-
-\`\`\`
-${removedKeyAttributes && removedKeyAttributes.length > 0 ? JSON.stringify(removedKeyAttributes, null, 2) : 'None'}
-\`\`\`
-
-${
-  changedDataStructureFields.length > 0
-    ? `Changed Data Structure Fields:
-
-The following fields in the data structure have changed (type changed, added, or removed):
-
-\`\`\`
+  const formatKeyAttrs = (attrs: Analysis['metadata']['keyAttributes']) =>
+    attrs.map((ka) => ({
+      dataStructurePath: ka.dataStructurePath,
+      localVariable: ka.internalPath,
+      description: ka.description,
+      validValueOptions: ka.validValueOptions,
+    }));
+
+  const addedSection =
+    addedKeyAttributes?.length > 0
+      ? JSON.stringify(formatKeyAttrs(addedKeyAttributes), null, 2)
+      : 'None';
+
+  const removedSection =
+    removedKeyAttributes?.length > 0
+      ? JSON.stringify(removedKeyAttributes, null, 2)
+      : 'None';
+
+  const changedFieldsSection =
+    changedDataStructureFields.length > 0
+      ? `
+## Changed Data Structure Fields
+Fields that changed type, were added, or removed:
+\`\`\`json
 ${JSON.stringify(changedDataStructureFields, null, 2)}
 \`\`\`
 
-**IMPORTANT**: For scenarios that reference these changed fields in their keyAttributeInstructions, you MUST regenerate those specific instructions to match the new data structure. For example:
-- If "stats.visualEntities" changed from an array to a number, update keyAttributeInstructions from "Array of 10 objects" to "10 (count of visual entities)"
-- If a field was removed, remove it from keyAttributeInstructions
-- If a field was added, you may add it to keyAttributeInstructions if relevant for the scenario
-
-Fields that did NOT change can retain their existing keyAttributeInstructions.
-
+**Update keyAttributeInstructions for affected scenarios** (e.g., if "stats.visualEntities" changed from array to number).
 `
-    : ''
-}
-Existing Key Attributes:
-
-\`\`\`
+      : '';
+
+  const existingScenariosJson = JSON.stringify(
+    existingScenarios
+      .filter((s) => (error ? !!s.metadata.error : !s.metadata.error))
+      .map((s) => ({
+        name: s.name,
+        description: s.description,
+        keyAttributeInstructions: s.metadata.keyAttributeInstructions,
+        playwrightInstructions: s.metadata.playwrightInstructions,
+      })),
+    null,
+    2,
+  );
+
+  const diffSection = commitDiff
+    ? `
+## Code Change (Diff)
+\`\`\`diff
+${commitDiff}
+\`\`\``
+    : '';
+
+  const dependencySection =
+    !error &&
+    relevantDependentKeyAttributes &&
+    Object.keys(relevantDependentKeyAttributes).length > 0
+      ? `
+## Dependency Key Attributes
+\`\`\`json
 ${JSON.stringify(
-  keyAttributes.map((ka) => ({
-    dataStructurePath: ka.dataStructurePath, // Full path in mockData
-    localVariable: ka.internalPath, // Local variable name
-    description: ka.description,
-    validValueOptions: ka.validValueOptions,
-  })),
+  Object.keys(relevantDependentKeyAttributes).reduce((acc: any, path) => {
+    acc[path] = Object.keys(relevantDependentKeyAttributes[path]).reduce(
+      (entityAcc: any, entityName) => {
+        entityAcc[entityName] = relevantDependentKeyAttributes[path][
+          entityName
+        ].map((ka: any) => ({
+          dataStructurePath: ka.dataStructurePath,
+          localVariable: ka.path || ka.internalPath,
+          description: ka.description,
+          validValueOptions: ka.validValueOptions,
+        }));
+        return entityAcc;
+      },
+      {},
+    );
+    return acc;
+  }, {}),
   null,
   2,
 )}
-\`\`\`
-
-Existing Scenarios:
+\`\`\``
+      : '';
 
+  return `## Added Key Attributes
+\`\`\`json
+${addedSection}
 \`\`\`
-${JSON.stringify(
-  existingScenarios
-    .filter((s) => (error ? !!s.metadata.error : !s.metadata.error))
-    .map((s) => ({
-      name: s.name,
-      description: s.description,
-      keyAttributeInstructions: s.metadata.keyAttributeInstructions,
-      playwrightInstructions: s.metadata.playwrightInstructions,
-    })),
-  null,
-  2,
-)}
-\`\`\`
-
-${
-  commitDiff
-    ? `
-Code Change:
 
+## Removed Key Attributes
+\`\`\`json
+${removedSection}
 \`\`\`
-${commitDiff}
+${changedFieldsSection}
+## Current Key Attributes
+\`\`\`json
+${JSON.stringify(formatKeyAttrs(keyAttributes), null, 2)}
 \`\`\`
-`
-    : ''
-}
-Function Code:
 
+## Existing Scenarios
+\`\`\`json
+${existingScenariosJson}
 \`\`\`
-${entity.code}
-\`\`\`
+${diffSection}
 
-${
-  !error &&
-  relevantDependentKeyAttributes &&
-  Object.keys(relevantDependentKeyAttributes).length > 0
-    ? `Key Attributes for Dependencies:
-\`\`\`
-${JSON.stringify(
-  Object.keys(relevantDependentKeyAttributes).reduce((acc: any, path) => {
-    acc[path] = Object.keys(
-      (relevantDependentKeyAttributes as any)[path],
-    ).reduce((entityAcc: any, entityName) => {
-      entityAcc[entityName] = (relevantDependentKeyAttributes as any)[path][
-        entityName
-      ].map((ka: any) => ({
-        dataStructurePath: ka.dataStructurePath, // Full path in mockData
-        localVariable: ka.path || ka.internalPath, // Local variable name
-        description: ka.description,
-        validValueOptions: ka.validValueOptions,
-      }));
-      return entityAcc;
-    }, {});
-    return acc;
-  }, {}),
-  null,
-  2,
-)}
-\`\`\``
-    : ''
-}
-`;
+## Current Code
+\`\`\`typescript
+${entity.code}
+\`\`\`${dependencySection}`;
 }

package/analyzer-template/packages/ai/src/lib/promptGenerators/generateEntityDocumentationGenerator.ts

@@ -1,35 +1,16 @@
 import { Entity } from '~codeyam/types';
 
 export default function generateEntityDocumentationGenerator(entity: Entity) {
-  return `Here is the code for ${entity.name}:
-  
-"""
-${entity.code}
-"""
-
-What does this code do? Please create documentation for this code. 
-
-- Start with an overview that describes the overall intent of the code. Be concise in your language. Immediately start with the intent of the code. Here is an example Overview:
+  return `## Task
+Document the following code.
 
-\`\`\` Overview
-Displays details about a specific Git commit. It shows the commit message, author, date, and provides a link to the commit on GitHub. Users can copy the commit SHA to their clipboard, with a visual indication of the copy action.
+## Code
+\`\`\`typescript
+${entity.code}
 \`\`\`
 
-Note that it does not mention the name of the function but dives directly into what the code does in concise language followed by a small amount of detail.
-
-- Next, specify the inputs (with details about types, how the input is used, and examples) and expected outputs (with details about types and examples).
-
-- Finally, provide examples of how the code can be used with clear inputs and outputs for each example. Provide diverse examples (there's no need to include repetitive examples). 
-
-Write the documentation as markdown. Be concise. Use bullets when possible. No one wants to read long paragraphs of text. 
-
-Provide no other text than the documentation in proper markdown using the headers below.
-
-## Overview
-
-## Inputs
-
-## Output
+## Overview Example
+Good: "Displays details about a specific Git commit. Shows the commit message, author, date, and provides a link to GitHub. Users can copy the commit SHA to clipboard."
 
-## Examples`;
+Bad: "The CommitDetails function takes a commit object..." (mentions the function name)`;
 }