@codewalla_india/openspec 1.3.1 → 1.3.3

package/dist/commands/validate.js

@@ -1,10 +1,11 @@
 import ora from 'ora';
 import path from 'path';
-import { trackEvent } from '../telemetry/index.js';
 import { Validator } from '../core/validation/validator.js';
+import { VALIDATION_MESSAGES } from '../core/validation/constants.js';
 import { resolveRootForCommand, toRootOutput, withStoreFlag, isStoreSelectedRoot, } from '../core/root-selection.js';
 import { isInteractive, resolveNoInteractive } from '../utils/interactive.js';
-import { getActiveChangeIds, getSpecIds } from '../utils/item-discovery.js';
+import { getSpecIds } from '../utils/item-discovery.js';
+import { getAvailableChanges } from './workflow/shared.js';
 import { nearestMatches } from '../utils/match.js';
 export class ValidateCommand {
     async execute(itemName, options = {}) {
@@ -43,6 +44,17 @@ export class ValidateCommand {
             return v;
         return undefined;
     }
+    /**
+     * Resolve change IDs by directory existence within the resolved root — the
+     * same rule `openspec status`/`instructions` use (`getAvailableChanges`) —
+     * rather than requiring `proposal.md`. This lets `validate` resolve a
+     * scaffolded or still-authoring change that the sibling commands already
+     * resolve (#1182). Sorted to preserve the prior `getActiveChangeIds` ordering.
+     */
+    async listChangeIds(root) {
+        const ids = await getAvailableChanges(root.path, root.changesDir);
+        return ids.sort();
+    }
     async runInteractiveSelector(root, opts) {
         const { select } = await import('@inquirer/prompts');
         const choice = await select({
@@ -61,7 +73,7 @@ export class ValidateCommand {
         if (choice === 'specs')
             return this.runBulkValidation(root, { changes: false, specs: true }, opts);
         // one
-        const [changes, specs] = await Promise.all([getActiveChangeIds(root.path), getSpecIds(root.path)]);
+        const [changes, specs] = await Promise.all([this.listChangeIds(root), getSpecIds(root.path)]);
         const items = [];
         items.push(...changes.map(id => ({ name: `change/${id}`, value: { type: 'change', id } })));
         items.push(...specs.map(id => ({ name: `spec/${id}`, value: { type: 'spec', id } })));
@@ -82,7 +94,7 @@ export class ValidateCommand {
         console.error('Or run in an interactive terminal.');
     }
     async validateDirectItem(root, itemName, opts) {
-        const [changes, specs] = await Promise.all([getActiveChangeIds(root.path), getSpecIds(root.path)]);
+        const [changes, specs] = await Promise.all([this.listChangeIds(root), getSpecIds(root.path)]);
         const isChange = changes.includes(itemName);
         const isSpec = specs.includes(itemName);
         const type = opts.typeOverride ?? (isChange ? 'change' : isSpec ? 'spec' : undefined);
@@ -133,10 +145,13 @@ export class ValidateCommand {
         if (type === 'change') {
             const changeDir = path.join(root.changesDir, id);
             const start = Date.now();
-            const report = await validator.validateChangeDeltaSpecs(changeDir);
+            const report = await validator.validateChangeDeltaSpecs(changeDir, {
+                mainSpecsDir: root.specsDir,
+                projectRoot: root.path,
+            });
             const durationMs = Date.now() - start;
             this.printReport('change', id, report, durationMs, opts.json, root);
-            trackEvent('change_validated', { valid: report.valid, issue_count: report.issues.length, strict: opts.strict, duration_ms: durationMs });
+            // Non-zero exit if invalid (keeps enriched output test semantics)
             process.exitCode = report.valid ? 0 : 1;
             return;
         }
@@ -145,7 +160,6 @@ export class ValidateCommand {
         const report = await validator.validateSpec(file);
         const durationMs = Date.now() - start;
         this.printReport('spec', id, report, durationMs, opts.json, root);
-        trackEvent('spec_validated', { valid: report.valid, issue_count: report.issues.length, strict: opts.strict, duration_ms: durationMs });
         process.exitCode = report.valid ? 0 : 1;
     }
     printReport(type, id, report, durationMs, json, root) {
@@ -164,12 +178,26 @@ export class ValidateCommand {
                 const prefix = issue.level === 'ERROR' ? '✗' : issue.level === 'WARNING' ? '⚠' : 'ℹ';
                 console.error(`${prefix} [${label}] ${issue.path}: ${issue.message}`);
             }
-            this.printNextSteps(type, id, root);
+            this.printNextSteps(type, id, root, report.issues);
         }
     }
-    printNextSteps(type, id, root) {
+    printNextSteps(type, id, root, issues = []) {
         const bullets = [];
-        if (type === 'change') {
+        // The delta-authoring bullets contradict a marker-related error ("add
+        // deltas" vs "remove skip_specs or the files"), so branch on the exact
+        // marker messages - the generic no-deltas guidance also mentions
+        // skip_specs, which must not trigger this.
+        const conflictIssue = issues.some(i => i.message.includes(VALIDATION_MESSAGES.CHANGE_SKIP_SPECS_CONFLICT));
+        const invalidMarkerIssue = issues.some(i => i.message.includes(VALIDATION_MESSAGES.CHANGE_SKIP_SPECS_INVALID_METADATA));
+        if (type === 'change' && conflictIssue) {
+            bullets.push('- This change declares skip_specs (no spec deltas): delete the files under specs/, or remove skip_specs from .openspec.yaml if requirements do change');
+            bullets.push('- skip_specs is only honored when .openspec.yaml is valid change metadata (schema: <name> naming a known schema is required)');
+        }
+        else if (type === 'change' && invalidMarkerIssue) {
+            bullets.push('- Fix .openspec.yaml so the skip_specs marker can be honored (schema: <name> naming a known schema is required)');
+            bullets.push('- Or remove skip_specs from .openspec.yaml and add delta specs instead');
+        }
+        else if (type === 'change') {
             bullets.push('- Ensure change has deltas in specs/: use headers ## ADDED/MODIFIED/REMOVED/RENAMED Requirements');
             bullets.push('- Each requirement MUST include at least one #### Scenario: block');
             bullets.push(`- Debug parsed deltas: ${withStoreFlag(root, `openspec show ${id} --json --deltas-only`)}`);
@@ -185,7 +213,7 @@ export class ValidateCommand {
     async runBulkValidation(root, scope, opts) {
         const spinner = !opts.json && !opts.noInteractive ? ora('Validating...').start() : undefined;
         const [changeIds, specIds] = await Promise.all([
-            scope.changes ? getActiveChangeIds(root.path) : Promise.resolve([]),
+            scope.changes ? this.listChangeIds(root) : Promise.resolve([]),
             scope.specs ? getSpecIds(root.path) : Promise.resolve([]),
         ]);
         const DEFAULT_CONCURRENCY = 6;
@@ -197,7 +225,10 @@ export class ValidateCommand {
             queue.push(async () => {
                 const start = Date.now();
                 const changeDir = path.join(root.changesDir, id);
-                const report = await validator.validateChangeDeltaSpecs(changeDir);
+                const report = await validator.validateChangeDeltaSpecs(changeDir, {
+                    mainSpecsDir: root.specsDir,
+                    projectRoot: root.path,
+                });
                 const durationMs = Date.now() - start;
                 return { id, type: 'change', valid: report.valid, issues: report.issues, durationMs };
             });
@@ -295,14 +326,6 @@ export class ValidateCommand {
                 console.log(`Details: openspec validate ${firstFailure.id} --type ${firstFailure.type}${storeFlag}`);
             }
         }
-        trackEvent('bulk_validation_run', {
-            total: summary.totals.items,
-            passed: summary.totals.passed,
-            failed: summary.totals.failed,
-            scope_changes: scope.changes,
-            scope_specs: scope.specs,
-            strict: opts.strict,
-        });
         process.exitCode = failed > 0 ? 1 : 0;
     }
 }

package/dist/commands/workflow/index.d.ts

@@ -5,8 +5,8 @@
  */
 export { statusCommand } from './status.js';
 export type { StatusOptions } from './status.js';
-export { instructionsCommand, applyInstructionsCommand, modifyInstructionsCommand } from './instructions.js';
-export type { InstructionsOptions, ModifyInstructionsOptions } from './instructions.js';
+export { instructionsCommand, applyInstructionsCommand, archiveInstructionsCommand, } from './instructions.js';
+export type { InstructionsOptions } from './instructions.js';
 export { templatesCommand } from './templates.js';
 export type { TemplatesOptions } from './templates.js';
 export { schemasCommand } from './schemas.js';

package/dist/commands/workflow/index.js

@@ -4,7 +4,7 @@
  * Commands for the artifact-driven workflow: status, instructions, templates, schemas, new change.
  */
 export { statusCommand } from './status.js';
-export { instructionsCommand, applyInstructionsCommand, modifyInstructionsCommand } from './instructions.js';
+export { instructionsCommand, applyInstructionsCommand, archiveInstructionsCommand, } from './instructions.js';
 export { templatesCommand } from './templates.js';
 export { schemasCommand } from './schemas.js';
 export { newChangeCommand } from './new-change.js';

package/dist/commands/workflow/instructions.d.ts

@@ -4,11 +4,11 @@
  * Generates enriched instructions for creating artifacts or applying tasks.
  * Includes both artifact instructions and apply instructions.
  */
-import { type ArtifactInstructions, type ArtifactPathSummary } from '../../core/artifact-graph/index.js';
+import { type ArtifactInstructions } from '../../core/artifact-graph/index.js';
 import { type PlanningHome } from '../../core/planning-home.js';
 import { type ReferenceIndexEntry } from '../../core/references.js';
 import { type ProjectConfig } from '../../core/project-config.js';
-import { type ApplyInstructions } from './shared.js';
+import { type ApplyInstructions, type ArchiveInstructions } from './shared.js';
 export interface InstructionsOptions {
     change?: string;
     schema?: string;
@@ -22,29 +22,8 @@ export interface ApplyInstructionsOptions {
     store?: string;
     storePath?: string;
     json?: boolean;
-    recordComprehensionPass?: boolean;
-    score?: number;
-    attempt?: number;
-    questionCount?: number;
-}
-export interface ModifyInstructionsOptions extends InstructionsOptions {
-    artifact?: string;
-    workflowInput?: string;
-    workflowInputFile?: string;
-    editor?: string;
-}
-export interface ModifyInstructions {
-    changeName: string;
-    schemaName: string;
-    sourceArtifact: string;
-    modifyInput?: string;
-    downstreamArtifacts: string[];
-    artifactsToUpdate: string[];
-    changeRoot: string;
-    artifactPaths: Record<string, ArtifactPathSummary>;
-    phase: 'pre_apply';
-    instruction: string;
 }
+export type ArchiveInstructionsOptions = ApplyInstructionsOptions;
 export declare function instructionsCommand(artifactId: string | undefined, options: InstructionsOptions): Promise<void>;
 export declare function printInstructionsText(instructions: ArtifactInstructions, isBlocked: boolean): void;
 export interface GenerateApplyInstructionsOptions {
@@ -60,6 +39,7 @@ export interface GenerateApplyInstructionsOptions {
 export declare function generateApplyInstructions(projectRoot: string, changeName: string, schemaName?: string, options?: GenerateApplyInstructionsOptions): Promise<ApplyInstructions>;
 export declare function applyInstructionsCommand(options: ApplyInstructionsOptions): Promise<void>;
 export declare function printApplyInstructionsText(instructions: ApplyInstructions): void;
-export declare function modifyInstructionsCommand(options: ModifyInstructionsOptions): Promise<void>;
-export declare function printModifyInstructionsText(instructions: ModifyInstructions): void;
+export declare function generateArchiveInstructions(changeName: string, projectConfig: ProjectConfig | null): ArchiveInstructions;
+export declare function archiveInstructionsCommand(options: ArchiveInstructionsOptions): Promise<void>;
+export declare function printArchiveInstructionsText(instructions: ArchiveInstructions): void;
 //# sourceMappingURL=instructions.d.ts.map