@codesys/mcp-toolkit 1.0.5 → 1.0.7

package/direct-codesys-mcp.js

@@ -0,0 +1,150 @@
+#!/usr/bin/env node
+const { exec } = require('child_process');
+const path = require('path');
+const fs = require('fs');
+const os = require('os');
+const { McpServer } = require('@modelcontextprotocol/sdk/server/mcp.js');
+const { StdioServerTransport } = require('@modelcontextprotocol/sdk/server/stdio.js');
+const { z } = require('zod');
+
+console.error("Starting standalone CODESYS MCP server...");
+
+// Create a simple MCP server
+const server = new McpServer({
+  name: "Standalone CODESYS MCP Server",
+  version: "1.0.0",
+  capabilities: { resources: {}, tools: {} }
+});
+
+// Direct implementation of executeCodesysScript
+async function executeCodesysScript(scriptContent, codesysExePath, codesysProfileName) {
+  // Validate inputs
+  if (!codesysExePath) throw new Error('CODESYS executable path was not provided');
+  if (!codesysProfileName) throw new Error('CODESYS profile name was not provided');
+  
+  console.error(`DIRECT: Using CODESYS Path: ${codesysExePath}`);
+  console.error(`DIRECT: Using CODESYS Profile: ${codesysProfileName}`);
+  
+  // Create temp script file
+  const tempDir = os.tmpdir();
+  const tempFileName = `codesys_script_${Date.now()}_${Math.random().toString(36).slice(2, 9)}.py`;
+  const tempFilePath = path.join(tempDir, tempFileName);
+  
+  let output = '';
+  let success = false;
+  
+  try {
+    // Write script to temp file
+    fs.writeFileSync(tempFilePath, scriptContent, 'latin1');
+    console.error(`DIRECT: Wrote script to: ${tempFilePath}`);
+    
+    // Build command with proper quoting
+    const commandWithArgs = `"${codesysExePath}" --profile="${codesysProfileName}" --noUI --runscript="${tempFilePath}"`;
+    console.error(`DIRECT: Command: ${commandWithArgs}`);
+    
+    // Execute using exec
+    success = await new Promise((resolve) => {
+      exec(commandWithArgs, (error, stdout, stderr) => {
+        if (stdout) output += stdout;
+        if (stderr) output += stderr;
+        
+        console.error(`DIRECT: stdout: ${stdout.slice(0, 200)}${stdout.length > 200 ? '...' : ''}`);
+        if (stderr) console.error(`DIRECT: stderr: ${stderr}`);
+        
+        if (error) {
+          console.error(`DIRECT: Error: ${error.message}`);
+          resolve(false);
+        } else {
+          resolve(true);
+        }
+      });
+    });
+    
+    // Check for success/error markers in output
+    if (output.includes('SCRIPT_SUCCESS')) {
+      success = true;
+    } else if (output.includes('SCRIPT_ERROR')) {
+      success = false;
+    }
+    
+  } catch (err) {
+    console.error(`DIRECT: Exception: ${err.message}`);
+    output += `\nError: ${err.message}`;
+    success = false;
+  } finally {
+    // Clean up temp file
+    try {
+      fs.unlinkSync(tempFilePath);
+      console.error(`DIRECT: Deleted temp file: ${tempFilePath}`);
+    } catch (err) {
+      console.error(`DIRECT: Failed to delete temp file: ${err.message}`);
+    }
+  }
+  
+  return { success, output };
+}
+
+// Implement a basic check_status tool
+server.tool("check_status", {}, async () => {
+  try {
+    const codesysPath = process.argv[2] || "C:\\Program Files\\CODESYS 3.5.21.0\\CODESYS\\Common\\CODESYS.exe";
+    const profileName = process.argv[3] || "CODESYS V3.5 SP21";
+    
+    console.error(`DIRECT: Check Status with ${codesysPath} and ${profileName}`);
+    
+    const scriptContent = `
+import sys, scriptengine as script_engine, os
+try:
+    print("Python script running")
+    print("Checking CODESYS status...")
+    scripting_ok = True
+    primary_project = script_engine.projects.primary
+    print("Primary project: " + str(primary_project))
+    print("SCRIPT_SUCCESS: Status check completed")
+    sys.exit(0)
+except Exception as e:
+    print("Error: " + str(e))
+    print("SCRIPT_ERROR: " + str(e))
+    sys.exit(1)
+`;
+    
+    const result = await executeCodesysScript(scriptContent, codesysPath, profileName);
+    return { 
+      content: [{ type: "text", text: `Status check ${result.success ? 'succeeded' : 'failed'}.\nOutput:\n${result.output}` }], 
+      isError: !result.success 
+    };
+  } catch (err) {
+    console.error(`DIRECT: Tool error: ${err.message}`);
+    return { content: [{ type: "text", text: `Error: ${err.message}` }], isError: true };
+  }
+});
+
+// Start the server
+async function startServer() {
+  try {
+    const transport = new StdioServerTransport();
+    console.error("DIRECT: Connecting server via stdio...");
+    await server.connect(transport);
+    console.error("DIRECT: Server connected and listening");
+  } catch (error) {
+    console.error("DIRECT: Failed to start server:", error);
+    process.exit(1);
+  }
+}
+
+// Show args
+console.error(`DIRECT: Args: ${JSON.stringify(process.argv)}`);
+
+// Start the server
+startServer();
+
+// Handle shutdown
+process.on('SIGINT', () => {
+  console.error('\nDIRECT: SIGINT received, shutting down...');
+  process.exit(0);
+});
+
+process.on('SIGTERM', () => {
+  console.error('\nDIRECT: SIGTERM received, shutting down...');
+  process.exit(0);
+});

package/dist/bin.js

@@ -18,13 +18,22 @@ commander_1.program
     .option('-p, --codesys-profile <profile>', 'CODESYS profile name', 'CODESYS V3.5 SP21')
     .parse(process.argv);
 const options = commander_1.program.opts();
-// Log startup message for debugging
+// Enhanced logging for debugging purposes
+console.error(`========================================`);
 console.error(`Starting CODESYS MCP Server v${version}`);
-console.error(`Using CODESYS path: ${options.codesysPath}`);
-console.error(`Using CODESYS profile: ${options.codesysProfile}`);
-// Pass command line arguments to the CODESYS executable path and profile
+console.error(`CODESYS path: ${options.codesysPath}`);
+console.error(`CODESYS profile: ${options.codesysProfile}`);
+console.error(`Using Node.js ${process.version}`);
+console.error(`Current directory: ${process.cwd()}`);
+console.error(`========================================`);
+// Pass properly sanitized command line arguments
+const codesysPath = options.codesysPath.trim();
+const codesysProfile = options.codesysProfile.trim();
 // The server.js file expects these as positional parameters
-process.argv[2] = options.codesysPath;
-process.argv[3] = options.codesysProfile;
+process.argv[2] = codesysPath;
+process.argv[3] = codesysProfile;
+// Also set them as environment variables as a backup mechanism
+process.env.CODESYS_PATH = codesysPath;
+process.env.CODESYS_PROFILE = codesysProfile;
 // Import and start the server
 import('./server.js');

package/dist/codesys_interop.js

@@ -84,44 +84,41 @@ function executeCodesysScript(scriptContent, codesysExePath, codesysProfileName)
             // Fix: Use shell:true but ensure proper quoting for paths with spaces
             const commandWithArgs = `"${codesysExePath}" --profile="${codesysProfileName}" --noUI --runscript="${tempFilePath}"`;
             process.stderr.write(`Executing: ${commandWithArgs}\n`); // Log the command
-            // Spawn the CODESYS process with shell:true for compatibility with CODESYS argument parsing
-            const codesysProcess = (0, child_process_1.spawn)(commandWithArgs, {
-                stdio: ['ignore', 'pipe', 'pipe'], // Ignore stdin, pipe stdout and stderr
-                shell: true // Keep shell:true but with properly quoted paths
-            });
-            // Capture stdout
-            codesysProcess.stdout.on('data', (data) => {
-                const chunk = data.toString();
-                // console.error('CODESYS stdout:', chunk); // Optional: Original debug log
-                output += chunk;
-            });
-            // Capture stderr
-            codesysProcess.stderr.on('data', (data) => {
-                const chunk = data.toString();
-                process.stderr.write(`CODESYS stderr: ${chunk}\n`); // Use process.stderr
-                output += chunk; // Include stderr in the output for debugging
-            });
-            // Wait for the process to exit with a timeout
-            const exitCode = yield new Promise((resolve, reject) => {
-                // Add timeout handling
-                const timeoutMs = 30000; // 30 seconds
-                const timeout = setTimeout(() => {
-                    process.stderr.write(`TIMEOUT: CODESYS process did not complete in ${timeoutMs}ms\n`);
-                    // Force resolve with 0 to proceed with parsing output collected so far
-                    codesysProcess.kill();
-                    resolve(0);
-                }, timeoutMs);
-                codesysProcess.on('close', (code) => {
-                    clearTimeout(timeout);
-                    resolve(code !== null && code !== void 0 ? code : 0);
+            // CONFIRMED WORKING APPROACH: Use simple exec() with complete quoting
+            // This approach is tested and works with the CODESYS executable
+            const execResult = yield new Promise((resolve) => {
+                process.stderr.write(`EXECUTING COMMAND: ${commandWithArgs}\n`);
+                // Execute command using exec which handles Windows command paths better
+                const childProcess = (0, child_process_1.exec)(commandWithArgs, { timeout: 30000 }, (error, stdout, stderr) => {
+                    var _a;
+                    let combinedOutput = "";
+                    if (stdout)
+                        combinedOutput += stdout;
+                    if (stderr)
+                        combinedOutput += stderr;
+                    // Log results for debugging
+                    if (stdout)
+                        process.stderr.write(`CODESYS stdout: ${stdout.length > 100 ? stdout.substring(0, 100) + '...' : stdout}\n`);
+                    if (stderr)
+                        process.stderr.write(`CODESYS stderr: ${stderr}\n`);
+                    if (error) {
+                        process.stderr.write(`CODESYS exec error: ${error.message}\n`);
+                        resolve({ code: (_a = error.code) !== null && _a !== void 0 ? _a : 1, output: combinedOutput });
+                    }
+                    else {
+                        resolve({ code: 0, output: combinedOutput });
+                    }
                 });
-                codesysProcess.on('error', (err) => {
-                    clearTimeout(timeout);
-                    // Error starting the process itself (e.g., command not found)
-                    process.stderr.write(`Failed to start CODESYS process: ${err.message}\n`); // Use process.stderr
-                    reject(err);
+                // Safety cleanup for timeout case
+                childProcess.on('timeout', () => {
+                    process.stderr.write(`TIMEOUT: CODESYS process timed out after 30 seconds\n`);
+                    childProcess.kill();
+                    resolve({ code: 0, output: output + "\nTIMEOUT: CODESYS process timed out" });
                 });
             });
+            // Add exec results to our output and get the exit code
+            output += execResult.output;
+            const exitCode = execResult.code;
             process.stderr.write(`CODESYS process exited with code: ${exitCode}\n`); // Use process.stderr
             // Determine success based on exit code and output markers
             // Note: CODESYS scripting might return exit code 0 even if the script had logical errors.