@codesys/mcp-toolkit 1.0.4 → 1.0.6

package/dist/codesys_interop.js

@@ -81,51 +81,41 @@ function executeCodesysScript(scriptContent, codesysExePath, codesysProfileName)
             process.stderr.write(`Temporary script written to: ${tempFilePath} with latin1 encoding and LF line endings\n`); // Use process.stderr
             // Add --additionalfolder argument
             const additionalFolderPath = "C:\\Program Files\\CODESYS 3.5.21.0\\CODESYS\\AdditionalFolders\\Default"; // Assuming Default instance
-            // Fix: Use shell:false and pass command and arguments separately to properly handle paths with spaces
-            const command = codesysExePath;
-            const args = [
-                `--profile=${codesysProfileName}`,
-                '--noUI',
-                `--runscript=${tempFilePath}`
-            ];
-            process.stderr.write(`Executing: ${command} ${args.join(' ')}\n`); // Log the command
-            // Spawn the CODESYS process using shell:false for proper path handling with spaces
-            const codesysProcess = (0, child_process_1.spawn)(command, args, {
-                stdio: ['ignore', 'pipe', 'pipe'], // Ignore stdin, pipe stdout and stderr
-                shell: false // Don't use shell to avoid issues with paths containing spaces
-            });
-            // Capture stdout
-            codesysProcess.stdout.on('data', (data) => {
-                const chunk = data.toString();
-                // console.error('CODESYS stdout:', chunk); // Optional: Original debug log
-                output += chunk;
-            });
-            // Capture stderr
-            codesysProcess.stderr.on('data', (data) => {
-                const chunk = data.toString();
-                process.stderr.write(`CODESYS stderr: ${chunk}\n`); // Use process.stderr
-                output += chunk; // Include stderr in the output for debugging
-            });
-            // Wait for the process to exit with a timeout
+            // Fix: Use shell:true but ensure proper quoting for paths with spaces
+            const commandWithArgs = `"${codesysExePath}" --profile="${codesysProfileName}" --noUI --runscript="${tempFilePath}"`;
+            process.stderr.write(`Executing: ${commandWithArgs}\n`); // Log the command
+            // Use exec instead of spawn - more reliable for command line processing
             const exitCode = yield new Promise((resolve, reject) => {
-                // Add timeout handling
                 const timeoutMs = 30000; // 30 seconds
-                const timeout = setTimeout(() => {
+                let timeoutHandle = null;
+                // Start the command using exec
+                const childProcess = (0, child_process_1.exec)(commandWithArgs, (error, stdout, stderr) => {
+                    var _a;
+                    if (timeoutHandle)
+                        clearTimeout(timeoutHandle);
+                    // Save all output
+                    if (stdout)
+                        output += stdout;
+                    if (stderr) {
+                        process.stderr.write(`CODESYS stderr: ${stderr}\n`);
+                        output += stderr;
+                    }
+                    if (error) {
+                        // Command failed
+                        process.stderr.write(`CODESYS process error: ${error.message}\n`);
+                        resolve((_a = error.code) !== null && _a !== void 0 ? _a : 1); // Return error code
+                    }
+                    else {
+                        // Command succeeded
+                        resolve(0);
+                    }
+                });
+                // Set a timeout
+                timeoutHandle = setTimeout(() => {
                     process.stderr.write(`TIMEOUT: CODESYS process did not complete in ${timeoutMs}ms\n`);
-                    // Force resolve with 0 to proceed with parsing output collected so far
-                    codesysProcess.kill();
-                    resolve(0);
+                    childProcess.kill();
+                    resolve(0); // Continue processing with what we have
                 }, timeoutMs);
-                codesysProcess.on('close', (code) => {
-                    clearTimeout(timeout);
-                    resolve(code !== null && code !== void 0 ? code : 0);
-                });
-                codesysProcess.on('error', (err) => {
-                    clearTimeout(timeout);
-                    // Error starting the process itself (e.g., command not found)
-                    process.stderr.write(`Failed to start CODESYS process: ${err.message}\n`); // Use process.stderr
-                    reject(err);
-                });
             });
             process.stderr.write(`CODESYS process exited with code: ${exitCode}\n`); // Use process.stderr
             // Determine success based on exit code and output markers

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codesys/mcp-toolkit",
-  "version": "1.0.4",
+  "version": "1.0.6",
   "main": "dist/server.js",
   "bin": {
     "codesys-mcp-toolkit": "./dist/bin.js"

package/test-direct.js

@@ -0,0 +1,40 @@
+const { spawn } = require('child_process');
+
+// Paths
+const codesysPath = "C:\\Program Files\\CODESYS 3.5.21.0\\CODESYS\\Common\\CODESYS.exe";
+const profileName = "CODESYS V3.5 SP21";
+
+// Log what we're doing
+console.log(`Testing direct spawn of CODESYS\n`);
+
+// Create a test Python script
+const fs = require('fs');
+const os = require('os');
+const path = require('path');
+const tempFile = path.join(os.tmpdir(), 'direct_test.py');
+fs.writeFileSync(tempFile, 'print("DIRECT TEST SUCCESS")\n');
+
+console.log(`Script file: ${tempFile}`);
+console.log(`CODESYS path: ${codesysPath}`);
+
+// Method 1: Using spawn with shell:true and proper quotes
+const command = `"${codesysPath}" --profile="${profileName}" --noUI --runscript="${tempFile}"`;
+console.log(`\nExecuting command: ${command}`);
+
+try {
+    // Use exec instead of spawn for simpler testing
+    require('child_process').exec(command, (error, stdout, stderr) => {
+        console.log("\n--- RESULTS ---");
+        if (error) {
+            console.log(`Error: ${error.message}`);
+            return;
+        }
+        if (stderr) {
+            console.log(`stderr: ${stderr}`);
+        }
+        console.log(`stdout: ${stdout}`);
+        console.log("--- END RESULTS ---");
+    });
+} catch (err) {
+    console.log(`Caught error: ${err.message}`);
+}