@codemirror/view 6.43.3 → 6.43.5

package/CHANGELOG.md

@@ -1,3 +1,21 @@
+## 6.43.5 (2026-07-04)
+
+### Bug fixes
+
+Fix an issue what would cause `domAtPos` to return positions on the wrong side of widgets.
+
+Fix an issue that could cause the DOM cursor to be drawn on the wrong side of a collapsing decoration.
+
+Don't return off-by-one coordinate positions at the edge of right-to-left text node in Safari.
+
+Don't abort momentum scrolling on iOS by stabilizing the scroll position.
+
+## 6.43.4 (2026-06-27)
+
+### Bug fixes
+
+Fix a regression in DOM document updates that could corrupt the tile tree and cause crashes.
+
 ## 6.43.3 (2026-06-25)
 
 ### Bug fixes

package/dist/index.cjs

@@ -514,8 +514,11 @@ function scanFor(node, off, targetNode, targetOff, dir) {
 function maxOffset(node) {
     return node.nodeType == 3 ? node.nodeValue.length : node.childNodes.length;
 }
-function flattenRect(rect, left) {
-    let x = left ? rect.left : rect.right;
+function flattenRect(rect, toLeft) {
+    let { left, right } = rect;
+    if (left == right)
+        return rect;
+    let x = toLeft ? left : right;
     return { left: x, right: x, top: rect.top, bottom: rect.bottom };
 }
 function windowRect(win) {
@@ -1780,7 +1783,7 @@ class Tile {
         return this.posBefore(tile) + tile.length;
     }
     covers(side) { return true; }
-    coordsIn(pos, side) { return null; }
+    coordsIn(pos, side, rtl) { return null; }
     domPosFor(off, side) {
         let index = domIndex(this.dom);
         let after = this.length ? off > 0 : side > 0;
@@ -1976,7 +1979,7 @@ class LineTile extends CompositeTile {
                     if (child.isComposite()) {
                         scan(child, pos - off);
                     }
-                    else if ((!after || after.isHidden && (side > 0 || forCoords && onSameLine(after, child))) &&
+                    else if ((!after || after.isHidden && (side > 0 && !(after.flags & 32 /* TileFlag.After */) || forCoords && onSameLine(after, child))) &&
                         (end > pos || (child.flags & 32 /* TileFlag.After */))) {
                         after = child;
                         afterOff = pos - off;
@@ -1993,11 +1996,11 @@ class LineTile extends CompositeTile {
         let target = ((side < 0 ? before : after) || before || after);
         return target ? { tile: target, offset: target == before ? beforeOff : afterOff } : null;
     }
-    coordsIn(pos, side) {
+    coordsIn(pos, side, rtl) {
         let found = this.resolveInline(pos, side, true);
         if (!found)
             return fallbackRect(this);
-        return found.tile.coordsIn(Math.max(0, found.offset), side);
+        return found.tile.coordsIn(Math.max(0, found.offset), side, rtl);
     }
     domIn(pos, side) {
         let found = this.resolveInline(pos, side);
@@ -2061,7 +2064,7 @@ class TextTile extends Tile {
     }
     isText() { return true; }
     toString() { return JSON.stringify(this.text); }
-    coordsIn(pos, side) {
+    coordsIn(pos, side, rtl) {
         let length = this.dom.nodeValue.length;
         if (pos > length)
             pos = length;
@@ -2071,7 +2074,7 @@ class TextTile extends Tile {
                 if (pos) {
                     from--;
                     flatten = 1;
-                } // FIXME this is wrong in RTL text
+                }
                 else if (to < length) {
                     to++;
                     flatten = -1;
@@ -2090,7 +2093,7 @@ class TextTile extends Tile {
         let rect = rects[(flatten ? flatten < 0 : side >= 0) ? 0 : rects.length - 1];
         if (browser.safari && !flatten && rect.width == 0)
             rect = Array.prototype.find.call(rects, r => r.width) || rect;
-        return flatten ? flattenRect(rect, flatten < 0) : rect || null;
+        return rtl == null ? rect : flattenRect(rect, (flatten ? flatten > 0 : side < 0) == rtl);
     }
     static of(text, dom) {
         let tile = new TextTile(dom || document.createTextNode(text), text);
@@ -2166,7 +2169,10 @@ class WidgetBufferTile extends Tile {
     }
     get isHidden() { return true; }
     get overrideDOMText() { return state.Text.empty; }
-    coordsIn(pos) { return this.dom.getBoundingClientRect(); }
+    coordsIn(pos, side, rtl) {
+        let rect = this.dom.getBoundingClientRect();
+        return rtl == null ? rect : flattenRect(rect, (side > 0) == rtl);
+    }
 }
 // Represents a position in the tile tree.
 class TilePointer {
@@ -2528,8 +2534,8 @@ class TileCache {
     find(cls, test, type = 2 /* Reused.DOM */) {
         let i = cls.bucket;
         let bucket = this.buckets[i], off = this.index[i];
-        for (let j = bucket.length - 1; j >= 0; j--) {
-            // Look at the most recently added items first (last-in, first-out)
+        for (let j = 0; j < bucket.length; j++) {
+            // Look at the most oldest items first (first-in, first-out)
             let index = (j + off) % bucket.length, tile = bucket[index];
             if ((!test || test(tile)) && !this.reused.has(tile)) {
                 bucket.splice(index, 1);
@@ -2783,6 +2789,7 @@ class TileUpdate {
                     }
                     pendingLineAttrs = null;
                 }
+                markCount = active.length;
             }
         });
         this.openWidget = openEnd > markCount;
@@ -3194,7 +3201,7 @@ class DocView {
     domAtPos(pos, side) {
         let { tile, offset } = this.tile.resolveBlock(pos, side);
         if (tile.isWidget())
-            return tile.domPosFor(pos, side);
+            return tile.domPosFor(offset, side);
         return tile.domIn(offset, side);
     }
     inlineDOMNearPos(pos, side) {
@@ -3231,14 +3238,16 @@ class DocView {
             after = null;
         return before && side < 0 || !after ? before.domIn(beforeOff, side) : after.domIn(afterOff, side);
     }
-    coordsAt(pos, side) {
+    // Get the coord of the element at the given side of the given
+    // position. If rtl is given, flatten it using that text direction.
+    coordsAt(pos, side, rtl) {
         let { tile, offset } = this.tile.resolveBlock(pos, side);
         if (tile.isWidget()) {
             if (tile.widget instanceof BlockGapWidget)
                 return null;
             return tile.coordsInWidget(offset, side, true);
         }
-        return tile.coordsIn(offset, side);
+        return tile.coordsIn(offset, side, rtl);
     }
     lineAt(pos, side) {
         let { tile } = this.tile.resolveBlock(pos, side);
@@ -3412,7 +3421,6 @@ class DocView {
         this.blockWrappers = this.view.state.facet(blockWrappers).map(v => typeof v == "function" ? v(this.view) : v);
     }
     scrollIntoView(target) {
-        var _a;
         if (target.isSnapshot) {
             let ref = this.view.viewState.lineBlockAt(target.range.head);
             this.view.scrollDOM.scrollTop = ref.top - target.yMargin;
@@ -3429,7 +3437,7 @@ class DocView {
             }
         }
         let { range } = target;
-        let rect = this.coordsAt(range.head, (_a = range.assoc) !== null && _a !== void 0 ? _a : (range.empty ? 0 : range.head > range.anchor ? -1 : 1)), other;
+        let rect = this.coordsAt(range.head, range.assoc || (range.head > range.anchor ? -1 : 1)), other;
         if (!rect)
             return;
         if (!range.empty && (other = this.coordsAt(range.anchor, range.anchor > range.head ? -1 : 1)))
@@ -4471,6 +4479,7 @@ class InputState {
         this.view = view;
         this.lastKeyCode = 0;
         this.lastKeyTime = 0;
+        this.touchActive = false;
         this.lastTouchTime = 0;
         this.lastTouchX = 0;
         this.lastTouchY = 0;
@@ -4482,6 +4491,10 @@ class InputState {
         // (after which we retroactively handle them and reset the DOM) to
         // avoid messing up the virtual keyboard state.
         this.pendingIOSKey = undefined;
+        // Set to a time stap by scroll events when touch isn't active on
+        // iOS, to work around an issue where Safari will abort the scroll
+        // momentum if we set scrollTop
+        this.lastIOSMomentumScroll = 0;
         // When enabled (>-1), tab presses are not given to key handlers,
         // leaving the browser's default behavior. If >0, the mode expires
         // at that timestamp, and any other keypress clears it.
@@ -4912,8 +4925,11 @@ function doPaste(view, input) {
     });
 }
 observers.scroll = view => {
-    view.inputState.lastScrollTop = view.scrollDOM.scrollTop;
-    view.inputState.lastScrollLeft = view.scrollDOM.scrollLeft;
+    let iState = view.inputState;
+    iState.lastScrollTop = view.scrollDOM.scrollTop;
+    iState.lastScrollLeft = view.scrollDOM.scrollLeft;
+    if (browser.ios && !iState.touchActive)
+        iState.lastIOSMomentumScroll = Date.now();
 };
 observers.wheel = observers.mousewheel = view => {
     view.inputState.lastWheelEvent = Date.now();
@@ -4926,6 +4942,7 @@ handlers.keydown = (view, event) => {
 };
 observers.touchstart = (view, e) => {
     let iState = view.inputState, touch = e.targetTouches[0];
+    iState.touchActive = true;
     iState.lastTouchTime = Date.now();
     if (touch) {
         iState.lastTouchX = touch.clientX;
@@ -4936,6 +4953,9 @@ observers.touchstart = (view, e) => {
 observers.touchmove = view => {
     view.inputState.setSelectionOrigin("select.pointer");
 };
+observers.touchend = (view, e) => {
+    view.inputState.touchActive = false;
+};
 handlers.mousedown = (view, event) => {
     view.observer.flush();
     if (view.inputState.lastTouchTime > Date.now() - 2000)
@@ -8198,6 +8218,7 @@ class EditorView {
                                 this.viewState.lineBlockAt(scrollAnchorPos).top;
                             let diff = (newAnchorHeight - scrollAnchorHeight) / this.scaleY;
                             if ((diff > 1 || diff < -1) &&
+                                !(browser.ios && this.inputState.lastIOSMomentumScroll > Date.now() - 100) &&
                                 (scroll == this.scrollDOM || this.hasFocus ||
                                     Math.max(this.inputState.lastWheelEvent, this.inputState.lastTouchTime) > Date.now() - 100)) {
                                 scrollOffset = scrollOffset + diff;
@@ -8489,12 +8510,9 @@ class EditorView {
     */
     coordsAtPos(pos, side = 1) {
         this.readMeasured();
-        let rect = this.docView.coordsAt(pos, side);
-        if (!rect || rect.left == rect.right)
-            return rect;
         let line = this.state.doc.lineAt(pos), order = this.bidiSpans(line);
         let span = order[BidiSpan.find(order, pos - line.from, -1, side)];
-        return flattenRect(rect, (span.dir == exports.Direction.LTR) == (side > 0));
+        return this.docView.coordsAt(pos, side, span.dir == exports.Direction.RTL);
     }
     /**
     Return the rectangle around a given character. If `pos` does not

package/dist/index.js

@@ -511,8 +511,11 @@ function scanFor(node, off, targetNode, targetOff, dir) {
 function maxOffset(node) {
     return node.nodeType == 3 ? node.nodeValue.length : node.childNodes.length;
 }
-function flattenRect(rect, left) {
-    let x = left ? rect.left : rect.right;
+function flattenRect(rect, toLeft) {
+    let { left, right } = rect;
+    if (left == right)
+        return rect;
+    let x = toLeft ? left : right;
     return { left: x, right: x, top: rect.top, bottom: rect.bottom };
 }
 function windowRect(win) {
@@ -1776,7 +1779,7 @@ class Tile {
         return this.posBefore(tile) + tile.length;
     }
     covers(side) { return true; }
-    coordsIn(pos, side) { return null; }
+    coordsIn(pos, side, rtl) { return null; }
     domPosFor(off, side) {
         let index = domIndex(this.dom);
         let after = this.length ? off > 0 : side > 0;
@@ -1972,7 +1975,7 @@ class LineTile extends CompositeTile {
                     if (child.isComposite()) {
                         scan(child, pos - off);
                     }
-                    else if ((!after || after.isHidden && (side > 0 || forCoords && onSameLine(after, child))) &&
+                    else if ((!after || after.isHidden && (side > 0 && !(after.flags & 32 /* TileFlag.After */) || forCoords && onSameLine(after, child))) &&
                         (end > pos || (child.flags & 32 /* TileFlag.After */))) {
                         after = child;
                         afterOff = pos - off;
@@ -1989,11 +1992,11 @@ class LineTile extends CompositeTile {
         let target = ((side < 0 ? before : after) || before || after);
         return target ? { tile: target, offset: target == before ? beforeOff : afterOff } : null;
     }
-    coordsIn(pos, side) {
+    coordsIn(pos, side, rtl) {
         let found = this.resolveInline(pos, side, true);
         if (!found)
             return fallbackRect(this);
-        return found.tile.coordsIn(Math.max(0, found.offset), side);
+        return found.tile.coordsIn(Math.max(0, found.offset), side, rtl);
     }
     domIn(pos, side) {
         let found = this.resolveInline(pos, side);
@@ -2057,7 +2060,7 @@ class TextTile extends Tile {
     }
     isText() { return true; }
     toString() { return JSON.stringify(this.text); }
-    coordsIn(pos, side) {
+    coordsIn(pos, side, rtl) {
         let length = this.dom.nodeValue.length;
         if (pos > length)
             pos = length;
@@ -2067,7 +2070,7 @@ class TextTile extends Tile {
                 if (pos) {
                     from--;
                     flatten = 1;
-                } // FIXME this is wrong in RTL text
+                }
                 else if (to < length) {
                     to++;
                     flatten = -1;
@@ -2086,7 +2089,7 @@ class TextTile extends Tile {
         let rect = rects[(flatten ? flatten < 0 : side >= 0) ? 0 : rects.length - 1];
         if (browser.safari && !flatten && rect.width == 0)
             rect = Array.prototype.find.call(rects, r => r.width) || rect;
-        return flatten ? flattenRect(rect, flatten < 0) : rect || null;
+        return rtl == null ? rect : flattenRect(rect, (flatten ? flatten > 0 : side < 0) == rtl);
     }
     static of(text, dom) {
         let tile = new TextTile(dom || document.createTextNode(text), text);
@@ -2162,7 +2165,10 @@ class WidgetBufferTile extends Tile {
     }
     get isHidden() { return true; }
     get overrideDOMText() { return Text.empty; }
-    coordsIn(pos) { return this.dom.getBoundingClientRect(); }
+    coordsIn(pos, side, rtl) {
+        let rect = this.dom.getBoundingClientRect();
+        return rtl == null ? rect : flattenRect(rect, (side > 0) == rtl);
+    }
 }
 // Represents a position in the tile tree.
 class TilePointer {
@@ -2524,8 +2530,8 @@ class TileCache {
     find(cls, test, type = 2 /* Reused.DOM */) {
         let i = cls.bucket;
         let bucket = this.buckets[i], off = this.index[i];
-        for (let j = bucket.length - 1; j >= 0; j--) {
-            // Look at the most recently added items first (last-in, first-out)
+        for (let j = 0; j < bucket.length; j++) {
+            // Look at the most oldest items first (first-in, first-out)
             let index = (j + off) % bucket.length, tile = bucket[index];
             if ((!test || test(tile)) && !this.reused.has(tile)) {
                 bucket.splice(index, 1);
@@ -2779,6 +2785,7 @@ class TileUpdate {
                     }
                     pendingLineAttrs = null;
                 }
+                markCount = active.length;
             }
         });
         this.openWidget = openEnd > markCount;
@@ -3190,7 +3197,7 @@ class DocView {
     domAtPos(pos, side) {
         let { tile, offset } = this.tile.resolveBlock(pos, side);
         if (tile.isWidget())
-            return tile.domPosFor(pos, side);
+            return tile.domPosFor(offset, side);
         return tile.domIn(offset, side);
     }
     inlineDOMNearPos(pos, side) {
@@ -3227,14 +3234,16 @@ class DocView {
             after = null;
         return before && side < 0 || !after ? before.domIn(beforeOff, side) : after.domIn(afterOff, side);
     }
-    coordsAt(pos, side) {
+    // Get the coord of the element at the given side of the given
+    // position. If rtl is given, flatten it using that text direction.
+    coordsAt(pos, side, rtl) {
         let { tile, offset } = this.tile.resolveBlock(pos, side);
         if (tile.isWidget()) {
             if (tile.widget instanceof BlockGapWidget)
                 return null;
             return tile.coordsInWidget(offset, side, true);
         }
-        return tile.coordsIn(offset, side);
+        return tile.coordsIn(offset, side, rtl);
     }
     lineAt(pos, side) {
         let { tile } = this.tile.resolveBlock(pos, side);
@@ -3408,7 +3417,6 @@ class DocView {
         this.blockWrappers = this.view.state.facet(blockWrappers).map(v => typeof v == "function" ? v(this.view) : v);
     }
     scrollIntoView(target) {
-        var _a;
         if (target.isSnapshot) {
             let ref = this.view.viewState.lineBlockAt(target.range.head);
             this.view.scrollDOM.scrollTop = ref.top - target.yMargin;
@@ -3425,7 +3433,7 @@ class DocView {
             }
         }
         let { range } = target;
-        let rect = this.coordsAt(range.head, (_a = range.assoc) !== null && _a !== void 0 ? _a : (range.empty ? 0 : range.head > range.anchor ? -1 : 1)), other;
+        let rect = this.coordsAt(range.head, range.assoc || (range.head > range.anchor ? -1 : 1)), other;
         if (!rect)
             return;
         if (!range.empty && (other = this.coordsAt(range.anchor, range.anchor > range.head ? -1 : 1)))
@@ -4467,6 +4475,7 @@ class InputState {
         this.view = view;
         this.lastKeyCode = 0;
         this.lastKeyTime = 0;
+        this.touchActive = false;
         this.lastTouchTime = 0;
         this.lastTouchX = 0;
         this.lastTouchY = 0;
@@ -4478,6 +4487,10 @@ class InputState {
         // (after which we retroactively handle them and reset the DOM) to
         // avoid messing up the virtual keyboard state.
         this.pendingIOSKey = undefined;
+        // Set to a time stap by scroll events when touch isn't active on
+        // iOS, to work around an issue where Safari will abort the scroll
+        // momentum if we set scrollTop
+        this.lastIOSMomentumScroll = 0;
         // When enabled (>-1), tab presses are not given to key handlers,
         // leaving the browser's default behavior. If >0, the mode expires
         // at that timestamp, and any other keypress clears it.
@@ -4908,8 +4921,11 @@ function doPaste(view, input) {
     });
 }
 observers.scroll = view => {
-    view.inputState.lastScrollTop = view.scrollDOM.scrollTop;
-    view.inputState.lastScrollLeft = view.scrollDOM.scrollLeft;
+    let iState = view.inputState;
+    iState.lastScrollTop = view.scrollDOM.scrollTop;
+    iState.lastScrollLeft = view.scrollDOM.scrollLeft;
+    if (browser.ios && !iState.touchActive)
+        iState.lastIOSMomentumScroll = Date.now();
 };
 observers.wheel = observers.mousewheel = view => {
     view.inputState.lastWheelEvent = Date.now();
@@ -4922,6 +4938,7 @@ handlers.keydown = (view, event) => {
 };
 observers.touchstart = (view, e) => {
     let iState = view.inputState, touch = e.targetTouches[0];
+    iState.touchActive = true;
     iState.lastTouchTime = Date.now();
     if (touch) {
         iState.lastTouchX = touch.clientX;
@@ -4932,6 +4949,9 @@ observers.touchstart = (view, e) => {
 observers.touchmove = view => {
     view.inputState.setSelectionOrigin("select.pointer");
 };
+observers.touchend = (view, e) => {
+    view.inputState.touchActive = false;
+};
 handlers.mousedown = (view, event) => {
     view.observer.flush();
     if (view.inputState.lastTouchTime > Date.now() - 2000)
@@ -8193,6 +8213,7 @@ class EditorView {
                                 this.viewState.lineBlockAt(scrollAnchorPos).top;
                             let diff = (newAnchorHeight - scrollAnchorHeight) / this.scaleY;
                             if ((diff > 1 || diff < -1) &&
+                                !(browser.ios && this.inputState.lastIOSMomentumScroll > Date.now() - 100) &&
                                 (scroll == this.scrollDOM || this.hasFocus ||
                                     Math.max(this.inputState.lastWheelEvent, this.inputState.lastTouchTime) > Date.now() - 100)) {
                                 scrollOffset = scrollOffset + diff;
@@ -8484,12 +8505,9 @@ class EditorView {
     */
     coordsAtPos(pos, side = 1) {
         this.readMeasured();
-        let rect = this.docView.coordsAt(pos, side);
-        if (!rect || rect.left == rect.right)
-            return rect;
         let line = this.state.doc.lineAt(pos), order = this.bidiSpans(line);
         let span = order[BidiSpan.find(order, pos - line.from, -1, side)];
-        return flattenRect(rect, (span.dir == Direction.LTR) == (side > 0));
+        return this.docView.coordsAt(pos, side, span.dir == Direction.RTL);
     }
     /**
     Return the rectangle around a given character. If `pos` does not

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codemirror/view",
-  "version": "6.43.3",
+  "version": "6.43.5",
   "description": "DOM view component for the CodeMirror code editor",
   "scripts": {
     "test": "cm-runtests",