@codemirror/view 6.43.1 → 6.43.3

package/CHANGELOG.md

@@ -1,3 +1,21 @@
+## 6.43.3 (2026-06-25)
+
+### Bug fixes
+
+Fix a bug in the content DOM update code that could corrupt the editor state.
+
+## 6.43.2 (2026-06-23)
+
+### Bug fixes
+
+Fix using select-all from the native context menu on Chrome Android.
+
+On iOS when autocapitalize is enabled, ignore the shift modifier on virtual keyboard Enter or Backspace presses.
+
+Work around an issue where Chrome Android scrolled the editor up when tapping an empty line to focus it.
+
+Create undirectional selection ranges for double and triple clicks.
+
 ## 6.43.1 (2026-06-09)
 
 ### Bug fixes

package/dist/index.cjs

@@ -2785,8 +2785,9 @@ class TileUpdate {
                 }
             }
         });
-        b.addLineStartIfNotCovered(pendingLineAttrs);
         this.openWidget = openEnd > markCount;
+        if (!this.openWidget)
+            b.addLineStartIfNotCovered(pendingLineAttrs);
         this.openMarks = openEnd;
     }
     forward(from, to, side = 1) {
@@ -3611,7 +3612,7 @@ function groupAt(state$1, pos, bias = 1) {
             break;
         to = next;
     }
-    return state.EditorSelection.range(from + line.from, to + line.from);
+    return state.EditorSelection.undirectionalRange(from + line.from, to + line.from);
 }
 function posAtCoordsImprecise(view, contentRect, block, x, y) {
     let into = Math.round((x - contentRect.left) * view.defaultCharacterWidth);
@@ -3748,8 +3749,12 @@ function skipAtomsForSelection(atoms, sel) {
         else {
             let from = skipAtomicRanges(atoms, range.from, -1);
             let to = skipAtomicRanges(atoms, range.to, 1);
-            if (from != range.from || to != range.to)
-                updated = state.EditorSelection.range(range.from == range.anchor ? from : to, range.from == range.head ? from : to);
+            if (from != range.from || to != range.to) {
+                if (range.undirectional)
+                    updated = state.EditorSelection.undirectionalRange(range.from, range.to);
+                else
+                    updated = state.EditorSelection.range(range.from == range.anchor ? from : to, range.from == range.head ? from : to);
+            }
         }
         if (updated) {
             if (!ranges)
@@ -4155,7 +4160,8 @@ class DOMChange {
             // Chrome will put the selection *inside* them, confusing
             // posFromDOM
             let vp = view.viewport;
-            if ((browser.ios || browser.chrome) && curSel.main.empty && head != anchor &&
+            if ((browser.ios || browser.chrome) && head != anchor &&
+                Math.min(head, anchor) <= curSel.main.from && Math.max(head, anchor) >= curSel.main.to &&
                 (vp.from > 0 || vp.to < view.state.doc.length)) {
                 let from = Math.min(head, anchor), to = Math.max(head, anchor);
                 let offFrom = vp.from - from, offTo = vp.to - to;
@@ -4476,13 +4482,11 @@ class InputState {
         // (after which we retroactively handle them and reset the DOM) to
         // avoid messing up the virtual keyboard state.
         this.pendingIOSKey = undefined;
-        /**
-        When enabled (>-1), tab presses are not given to key handlers,
-        leaving the browser's default behavior. If >0, the mode expires
-        at that timestamp, and any other keypress clears it.
-        Esc enables temporary tab focus mode for two seconds when not
-        otherwise handled.
-        */
+        // When enabled (>-1), tab presses are not given to key handlers,
+        // leaving the browser's default behavior. If >0, the mode expires
+        // at that timestamp, and any other keypress clears it.
+        // Esc enables temporary tab focus mode for two seconds when not
+        // otherwise handled.
         this.tabFocusMode = -1;
         this.lastSelectionOrigin = null;
         this.lastSelectionTime = 0;
@@ -4590,11 +4594,16 @@ class InputState {
         // state. So we let it go through, and then, in
         // applyDOMChange, notify key handlers of it and reset to
         // the state they produce.
-        let pending;
-        if (browser.ios && !event.synthetic && !event.altKey && !event.metaKey && !event.shiftKey &&
-            ((pending = PendingKeys.find(key => key.keyCode == event.keyCode)) && !event.ctrlKey ||
+        if (browser.ios && !event.synthetic && !event.altKey && !event.metaKey &&
+            (PendingKeys.some(key => key.keyCode == event.keyCode) && !event.ctrlKey ||
                 EmacsyPendingKeys.indexOf(event.key) > -1 && event.ctrlKey)) {
-            this.pendingIOSKey = pending || event;
+            let mods = { ctrlKey: event.ctrlKey, altKey: event.altKey, metaKey: event.metaKey, shiftKey: event.shiftKey };
+            // On iOS with autocapitalize, drop the shift modifier for these
+            // keys, since it will be set at the start of every sentence.
+            if (mods.shiftKey && browser.ios && !/^(off|none)$/.test(this.view.contentDOM.autocapitalize) &&
+                iosVirtualKeyboardOpen(this.view.win))
+                mods.shiftKey = false;
+            this.pendingIOSKey = { key: event.key, keyCode: event.keyCode, mods };
             setTimeout(() => this.flushIOSKey(), 250);
             return true;
         }
@@ -4610,7 +4619,7 @@ class InputState {
         if (key.key == "Enter" && change && change.from < change.to && /^\S+$/.test(change.insert.toString()))
             return false;
         this.pendingIOSKey = undefined;
-        return dispatchKey(this.view.contentDOM, key.key, key.keyCode, key instanceof KeyboardEvent ? key : undefined);
+        return dispatchKey(this.view.contentDOM, key.key, key.keyCode, key.mods);
     }
     ignoreDuringComposition(event) {
         if (!/^key/.test(event.type) || event.synthetic)
@@ -4648,6 +4657,11 @@ class InputState {
             this.mouseSelection.destroy();
     }
 }
+function iosVirtualKeyboardOpen(win) {
+    if (!win.visualViewport)
+        return false;
+    return win.visualViewport.height * win.visualViewport.scale / win.document.documentElement.clientHeight < 0.85;
+}
 function bindHandler(plugin, handler) {
     return (view, event) => {
         try {
@@ -4967,7 +4981,7 @@ function rangeForClick(view, pos, bias, type) {
         let from = visual ? visual.posAtStart : line.from, to = visual ? visual.posAtEnd : line.to;
         if (to < view.state.doc.length && to == line.to)
             to++;
-        return state.EditorSelection.range(from, to);
+        return state.EditorSelection.undirectionalRange(from, to);
     }
 }
 const BadMouseDetail = browser.ie && browser.ie_version <= 11;
@@ -5025,7 +5039,7 @@ handlers.dragstart = (view, event) => {
         if (tile && tile.isWidget()) {
             let from = tile.posAtStart, to = from + tile.length;
             if (from >= range.to || to <= range.from)
-                range = state.EditorSelection.range(from, to);
+                range = state.EditorSelection.undirectionalRange(from, to);
         }
     }
     let { inputState } = view;
@@ -7651,7 +7665,6 @@ class EditContextManager {
         for (let event in this.handlers)
             context.addEventListener(event, this.handlers[event]);
         this.measureReq = { read: view => {
-                this.editContext.updateControlBounds(view.contentDOM.getBoundingClientRect());
                 let sel = getSelection(view.root);
                 if (sel && sel.rangeCount)
                     this.editContext.updateSelectionBounds(sel.getRangeAt(0).getBoundingClientRect());

package/dist/index.js

@@ -2781,8 +2781,9 @@ class TileUpdate {
                 }
             }
         });
-        b.addLineStartIfNotCovered(pendingLineAttrs);
         this.openWidget = openEnd > markCount;
+        if (!this.openWidget)
+            b.addLineStartIfNotCovered(pendingLineAttrs);
         this.openMarks = openEnd;
     }
     forward(from, to, side = 1) {
@@ -3607,7 +3608,7 @@ function groupAt(state, pos, bias = 1) {
             break;
         to = next;
     }
-    return EditorSelection.range(from + line.from, to + line.from);
+    return EditorSelection.undirectionalRange(from + line.from, to + line.from);
 }
 function posAtCoordsImprecise(view, contentRect, block, x, y) {
     let into = Math.round((x - contentRect.left) * view.defaultCharacterWidth);
@@ -3744,8 +3745,12 @@ function skipAtomsForSelection(atoms, sel) {
         else {
             let from = skipAtomicRanges(atoms, range.from, -1);
             let to = skipAtomicRanges(atoms, range.to, 1);
-            if (from != range.from || to != range.to)
-                updated = EditorSelection.range(range.from == range.anchor ? from : to, range.from == range.head ? from : to);
+            if (from != range.from || to != range.to) {
+                if (range.undirectional)
+                    updated = EditorSelection.undirectionalRange(range.from, range.to);
+                else
+                    updated = EditorSelection.range(range.from == range.anchor ? from : to, range.from == range.head ? from : to);
+            }
         }
         if (updated) {
             if (!ranges)
@@ -4151,7 +4156,8 @@ class DOMChange {
             // Chrome will put the selection *inside* them, confusing
             // posFromDOM
             let vp = view.viewport;
-            if ((browser.ios || browser.chrome) && curSel.main.empty && head != anchor &&
+            if ((browser.ios || browser.chrome) && head != anchor &&
+                Math.min(head, anchor) <= curSel.main.from && Math.max(head, anchor) >= curSel.main.to &&
                 (vp.from > 0 || vp.to < view.state.doc.length)) {
                 let from = Math.min(head, anchor), to = Math.max(head, anchor);
                 let offFrom = vp.from - from, offTo = vp.to - to;
@@ -4472,13 +4478,11 @@ class InputState {
         // (after which we retroactively handle them and reset the DOM) to
         // avoid messing up the virtual keyboard state.
         this.pendingIOSKey = undefined;
-        /**
-        When enabled (>-1), tab presses are not given to key handlers,
-        leaving the browser's default behavior. If >0, the mode expires
-        at that timestamp, and any other keypress clears it.
-        Esc enables temporary tab focus mode for two seconds when not
-        otherwise handled.
-        */
+        // When enabled (>-1), tab presses are not given to key handlers,
+        // leaving the browser's default behavior. If >0, the mode expires
+        // at that timestamp, and any other keypress clears it.
+        // Esc enables temporary tab focus mode for two seconds when not
+        // otherwise handled.
         this.tabFocusMode = -1;
         this.lastSelectionOrigin = null;
         this.lastSelectionTime = 0;
@@ -4586,11 +4590,16 @@ class InputState {
         // state. So we let it go through, and then, in
         // applyDOMChange, notify key handlers of it and reset to
         // the state they produce.
-        let pending;
-        if (browser.ios && !event.synthetic && !event.altKey && !event.metaKey && !event.shiftKey &&
-            ((pending = PendingKeys.find(key => key.keyCode == event.keyCode)) && !event.ctrlKey ||
+        if (browser.ios && !event.synthetic && !event.altKey && !event.metaKey &&
+            (PendingKeys.some(key => key.keyCode == event.keyCode) && !event.ctrlKey ||
                 EmacsyPendingKeys.indexOf(event.key) > -1 && event.ctrlKey)) {
-            this.pendingIOSKey = pending || event;
+            let mods = { ctrlKey: event.ctrlKey, altKey: event.altKey, metaKey: event.metaKey, shiftKey: event.shiftKey };
+            // On iOS with autocapitalize, drop the shift modifier for these
+            // keys, since it will be set at the start of every sentence.
+            if (mods.shiftKey && browser.ios && !/^(off|none)$/.test(this.view.contentDOM.autocapitalize) &&
+                iosVirtualKeyboardOpen(this.view.win))
+                mods.shiftKey = false;
+            this.pendingIOSKey = { key: event.key, keyCode: event.keyCode, mods };
             setTimeout(() => this.flushIOSKey(), 250);
             return true;
         }
@@ -4606,7 +4615,7 @@ class InputState {
         if (key.key == "Enter" && change && change.from < change.to && /^\S+$/.test(change.insert.toString()))
             return false;
         this.pendingIOSKey = undefined;
-        return dispatchKey(this.view.contentDOM, key.key, key.keyCode, key instanceof KeyboardEvent ? key : undefined);
+        return dispatchKey(this.view.contentDOM, key.key, key.keyCode, key.mods);
     }
     ignoreDuringComposition(event) {
         if (!/^key/.test(event.type) || event.synthetic)
@@ -4644,6 +4653,11 @@ class InputState {
             this.mouseSelection.destroy();
     }
 }
+function iosVirtualKeyboardOpen(win) {
+    if (!win.visualViewport)
+        return false;
+    return win.visualViewport.height * win.visualViewport.scale / win.document.documentElement.clientHeight < 0.85;
+}
 function bindHandler(plugin, handler) {
     return (view, event) => {
         try {
@@ -4963,7 +4977,7 @@ function rangeForClick(view, pos, bias, type) {
         let from = visual ? visual.posAtStart : line.from, to = visual ? visual.posAtEnd : line.to;
         if (to < view.state.doc.length && to == line.to)
             to++;
-        return EditorSelection.range(from, to);
+        return EditorSelection.undirectionalRange(from, to);
     }
 }
 const BadMouseDetail = browser.ie && browser.ie_version <= 11;
@@ -5021,7 +5035,7 @@ handlers.dragstart = (view, event) => {
         if (tile && tile.isWidget()) {
             let from = tile.posAtStart, to = from + tile.length;
             if (from >= range.to || to <= range.from)
-                range = EditorSelection.range(from, to);
+                range = EditorSelection.undirectionalRange(from, to);
         }
     }
     let { inputState } = view;
@@ -7646,7 +7660,6 @@ class EditContextManager {
         for (let event in this.handlers)
             context.addEventListener(event, this.handlers[event]);
         this.measureReq = { read: view => {
-                this.editContext.updateControlBounds(view.contentDOM.getBoundingClientRect());
                 let sel = getSelection(view.root);
                 if (sel && sel.rangeCount)
                     this.editContext.updateSelectionBounds(sel.getRangeAt(0).getBoundingClientRect());

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codemirror/view",
-  "version": "6.43.1",
+  "version": "6.43.3",
   "description": "DOM view component for the CodeMirror code editor",
   "scripts": {
     "test": "cm-runtests",
@@ -26,7 +26,7 @@
   "sideEffects": false,
   "license": "MIT",
   "dependencies": {
-    "@codemirror/state": "^6.6.0",
+    "@codemirror/state": "^6.7.0",
     "crelt": "^1.0.6",
     "style-mod": "^4.1.0",
     "w3c-keyname": "^2.2.4"