@codemirror/view 6.39.10 → 6.39.12

package/CHANGELOG.md

@@ -1,3 +1,19 @@
+## 6.39.12 (2026-01-30)
+
+### Bug fixes
+
+Fix a bug where the visual selection drawn by `drawSelection` could fail to update properly in some circumstances.
+
+Fix a bug where PageUp/PageDown near the edge of the viewport might completely skip to the start/end of the document.
+
+Fix a regression that caused mark decorations to be split on text node chunk boundaries again.
+
+## 6.39.11 (2026-01-14)
+
+### Bug fixes
+
+Avoid handling copy events for parent editors.
+
 ## 6.39.10 (2026-01-13)
 
 ### Bug fixes

package/dist/index.cjs

@@ -2266,7 +2266,7 @@ class TileBuilder {
         this.flushBuffer();
         let parent = this.ensureMarks(marks, openStart);
         let prev = parent.lastChild;
-        if (prev && prev.isText() && !(prev.flags & 8 /* TileFlag.Composition */)) {
+        if (prev && prev.isText() && !(prev.flags & 8 /* TileFlag.Composition */) && prev.length + text.length < 512 /* C.Chunk */) {
             this.cache.reused.set(prev, 2 /* Reused.DOM */);
             let tile = parent.children[parent.children.length - 1] = new TextTile(prev.dom, prev.text + text);
             tile.parent = parent;
@@ -2760,7 +2760,7 @@ class TileUpdate {
                     }
                     else {
                         b.ensureLine(pendingLineAttrs);
-                        b.addText(chars, active, openStart);
+                        b.addText(chars, active, pos == from ? openStart : active.length);
                         pos += chars.length;
                     }
                     pendingLineAttrs = null;
@@ -3674,11 +3674,8 @@ function moveVertically(view, start, forward, distance) {
     }
     let resolvedGoal = rect.left + goal;
     let dist = distance !== null && distance !== void 0 ? distance : (view.viewState.heightOracle.textHeight >> 1);
-    for (let extra = 0;; extra += 10) {
-        let curY = startY + (dist + extra) * dir;
-        let pos = posAtCoords(view, { x: resolvedGoal, y: curY }, false, dir);
-        return state.EditorSelection.cursor(pos.pos, pos.assoc, undefined, goal);
-    }
+    let pos = posAtCoords(view, { x: resolvedGoal, y: startY + dist * dir }, false, dir);
+    return state.EditorSelection.cursor(pos.pos, pos.assoc, undefined, goal);
 }
 function skipAtomicRanges(atoms, pos, bias) {
     for (;;) {
@@ -3744,7 +3741,9 @@ function posAtCoords(view, coords, precise, scanY) {
         if (scanY == null)
             break;
         if (block.type == exports.BlockType.Text) {
-            // Check whether we aren't landing the top/bottom padding of the line
+            if (scanY < 0 ? block.to < view.viewport.from : block.from > view.viewport.to)
+                break;
+            // Check whether we aren't landing on the top/bottom padding of the line
             let rect = view.docView.coordsAt(scanY < 0 ? block.from : block.to, scanY);
             if (rect && (scanY < 0 ? rect.top <= yOffset + docTop : rect.bottom >= yOffset + docTop))
                 break;
@@ -4088,7 +4087,7 @@ function applyDOMChange(view, domChange) {
                 insert: state.Text.of(domChange.text.slice(diff.from, diff.toB).split(LineBreakPlaceholder)) };
         }
     }
-    else if (newSel && (!view.hasFocus && view.state.facet(editable) || newSel.main.eq(sel))) {
+    else if (newSel && (!view.hasFocus && view.state.facet(editable) || sameSelPos(newSel, sel))) {
         newSel = null;
     }
     if (!change && !newSel)
@@ -4140,7 +4139,7 @@ function applyDOMChange(view, domChange) {
     if (change) {
         return applyDOMChangeInner(view, change, newSel, lastKey);
     }
-    else if (newSel && !newSel.main.eq(sel)) {
+    else if (newSel && !sameSelPos(newSel, sel)) {
         let scrollIntoView = false, userEvent = "select";
         if (view.inputState.lastSelectionTime > Date.now() - 50) {
             if (view.inputState.lastSelectionOrigin == "select")
@@ -4311,6 +4310,9 @@ function selectionFromPoints(points, base) {
     let anchor = points[0].pos, head = points.length == 2 ? points[1].pos : anchor;
     return anchor > -1 && head > -1 ? state.EditorSelection.single(anchor + base, head + base) : null;
 }
+function sameSelPos(selection, range) {
+    return range.head == selection.main.head && range.anchor == selection.main.anchor;
+}
 
 class InputState {
     setSelectionOrigin(origin) {
@@ -4993,6 +4995,14 @@ function copiedRange(state) {
 }
 let lastLinewiseCopy = null;
 handlers.copy = handlers.cut = (view, event) => {
+    // If the DOM selection is outside this editor, don't intercept.
+    // This happens when a parent editor (like ProseMirror) selects content that
+    // spans multiple elements including this CodeMirror. The copy event may
+    // bubble through CodeMirror (e.g. when CodeMirror is the first or the last
+    // element in the selection), but we should let the parent handle it.
+    let domSel = getSelection(view.root);
+    if (domSel && !hasSelection(view.contentDOM, domSel))
+        return false;
     let { text, ranges, linewise } = copiedRange(view.state);
     if (!text && !linewise)
         return false;
@@ -7226,7 +7236,7 @@ class DOMObserver {
         let handled = applyDOMChange(this.view, domChange);
         // The view wasn't updated but DOM/selection changes were seen. Reset the view.
         if (this.view.state == startState &&
-            (domChange.domChanged || domChange.newSel && !domChange.newSel.main.eq(this.view.state.selection.main)))
+            (domChange.domChanged || domChange.newSel && !sameSelPos(this.view.state.selection, domChange.newSel.main)))
             this.view.update([]);
         return handled;
     }
@@ -7390,7 +7400,7 @@ class EditContextManager {
             // Edit contexts sometimes fire empty changes
             if (!diff) {
                 let newSel = state.EditorSelection.single(this.toEditorPos(e.selectionStart), this.toEditorPos(e.selectionEnd));
-                if (!newSel.main.eq(main))
+                if (!sameSelPos(newSel, main))
                     view.dispatch({ selection: newSel, userEvent: "select" });
                 return;
             }
@@ -9090,7 +9100,7 @@ function rectanglesForRange(view, className, range) {
         return pieces(top).concat(between).concat(pieces(bottom));
     }
     function piece(left, top, right, bottom) {
-        return new RectangleMarker(className, left - base.left, top - base.top, right - left, bottom - top);
+        return new RectangleMarker(className, left - base.left, top - base.top, Math.max(0, right - left), bottom - top);
     }
     function pieces({ top, bottom, horizontal }) {
         let pieces = [];

package/dist/index.js

@@ -2262,7 +2262,7 @@ class TileBuilder {
         this.flushBuffer();
         let parent = this.ensureMarks(marks, openStart);
         let prev = parent.lastChild;
-        if (prev && prev.isText() && !(prev.flags & 8 /* TileFlag.Composition */)) {
+        if (prev && prev.isText() && !(prev.flags & 8 /* TileFlag.Composition */) && prev.length + text.length < 512 /* C.Chunk */) {
             this.cache.reused.set(prev, 2 /* Reused.DOM */);
             let tile = parent.children[parent.children.length - 1] = new TextTile(prev.dom, prev.text + text);
             tile.parent = parent;
@@ -2756,7 +2756,7 @@ class TileUpdate {
                     }
                     else {
                         b.ensureLine(pendingLineAttrs);
-                        b.addText(chars, active, openStart);
+                        b.addText(chars, active, pos == from ? openStart : active.length);
                         pos += chars.length;
                     }
                     pendingLineAttrs = null;
@@ -3670,11 +3670,8 @@ function moveVertically(view, start, forward, distance) {
     }
     let resolvedGoal = rect.left + goal;
     let dist = distance !== null && distance !== void 0 ? distance : (view.viewState.heightOracle.textHeight >> 1);
-    for (let extra = 0;; extra += 10) {
-        let curY = startY + (dist + extra) * dir;
-        let pos = posAtCoords(view, { x: resolvedGoal, y: curY }, false, dir);
-        return EditorSelection.cursor(pos.pos, pos.assoc, undefined, goal);
-    }
+    let pos = posAtCoords(view, { x: resolvedGoal, y: startY + dist * dir }, false, dir);
+    return EditorSelection.cursor(pos.pos, pos.assoc, undefined, goal);
 }
 function skipAtomicRanges(atoms, pos, bias) {
     for (;;) {
@@ -3740,7 +3737,9 @@ function posAtCoords(view, coords, precise, scanY) {
         if (scanY == null)
             break;
         if (block.type == BlockType.Text) {
-            // Check whether we aren't landing the top/bottom padding of the line
+            if (scanY < 0 ? block.to < view.viewport.from : block.from > view.viewport.to)
+                break;
+            // Check whether we aren't landing on the top/bottom padding of the line
             let rect = view.docView.coordsAt(scanY < 0 ? block.from : block.to, scanY);
             if (rect && (scanY < 0 ? rect.top <= yOffset + docTop : rect.bottom >= yOffset + docTop))
                 break;
@@ -4084,7 +4083,7 @@ function applyDOMChange(view, domChange) {
                 insert: Text.of(domChange.text.slice(diff.from, diff.toB).split(LineBreakPlaceholder)) };
         }
     }
-    else if (newSel && (!view.hasFocus && view.state.facet(editable) || newSel.main.eq(sel))) {
+    else if (newSel && (!view.hasFocus && view.state.facet(editable) || sameSelPos(newSel, sel))) {
         newSel = null;
     }
     if (!change && !newSel)
@@ -4136,7 +4135,7 @@ function applyDOMChange(view, domChange) {
     if (change) {
         return applyDOMChangeInner(view, change, newSel, lastKey);
     }
-    else if (newSel && !newSel.main.eq(sel)) {
+    else if (newSel && !sameSelPos(newSel, sel)) {
         let scrollIntoView = false, userEvent = "select";
         if (view.inputState.lastSelectionTime > Date.now() - 50) {
             if (view.inputState.lastSelectionOrigin == "select")
@@ -4307,6 +4306,9 @@ function selectionFromPoints(points, base) {
     let anchor = points[0].pos, head = points.length == 2 ? points[1].pos : anchor;
     return anchor > -1 && head > -1 ? EditorSelection.single(anchor + base, head + base) : null;
 }
+function sameSelPos(selection, range) {
+    return range.head == selection.main.head && range.anchor == selection.main.anchor;
+}
 
 class InputState {
     setSelectionOrigin(origin) {
@@ -4989,6 +4991,14 @@ function copiedRange(state) {
 }
 let lastLinewiseCopy = null;
 handlers.copy = handlers.cut = (view, event) => {
+    // If the DOM selection is outside this editor, don't intercept.
+    // This happens when a parent editor (like ProseMirror) selects content that
+    // spans multiple elements including this CodeMirror. The copy event may
+    // bubble through CodeMirror (e.g. when CodeMirror is the first or the last
+    // element in the selection), but we should let the parent handle it.
+    let domSel = getSelection(view.root);
+    if (domSel && !hasSelection(view.contentDOM, domSel))
+        return false;
     let { text, ranges, linewise } = copiedRange(view.state);
     if (!text && !linewise)
         return false;
@@ -7221,7 +7231,7 @@ class DOMObserver {
         let handled = applyDOMChange(this.view, domChange);
         // The view wasn't updated but DOM/selection changes were seen. Reset the view.
         if (this.view.state == startState &&
-            (domChange.domChanged || domChange.newSel && !domChange.newSel.main.eq(this.view.state.selection.main)))
+            (domChange.domChanged || domChange.newSel && !sameSelPos(this.view.state.selection, domChange.newSel.main)))
             this.view.update([]);
         return handled;
     }
@@ -7385,7 +7395,7 @@ class EditContextManager {
             // Edit contexts sometimes fire empty changes
             if (!diff) {
                 let newSel = EditorSelection.single(this.toEditorPos(e.selectionStart), this.toEditorPos(e.selectionEnd));
-                if (!newSel.main.eq(main))
+                if (!sameSelPos(newSel, main))
                     view.dispatch({ selection: newSel, userEvent: "select" });
                 return;
             }
@@ -9085,7 +9095,7 @@ function rectanglesForRange(view, className, range) {
         return pieces(top).concat(between).concat(pieces(bottom));
     }
     function piece(left, top, right, bottom) {
-        return new RectangleMarker(className, left - base.left, top - base.top, right - left, bottom - top);
+        return new RectangleMarker(className, left - base.left, top - base.top, Math.max(0, right - left), bottom - top);
     }
     function pieces({ top, bottom, horizontal }) {
         let pieces = [];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codemirror/view",
-  "version": "6.39.10",
+  "version": "6.39.12",
   "description": "DOM view component for the CodeMirror code editor",
   "scripts": {
     "test": "cm-runtests",