@codemirror/view 6.28.1 → 6.28.3

package/CHANGELOG.md

@@ -1,3 +1,19 @@
+## 6.28.3 (2024-07-01)
+
+### Bug fixes
+
+Fix an issue causing the IME interface to appear in the wrong spot on Chrome Windows.
+
+## 6.28.2 (2024-06-21)
+
+### Bug fixes
+
+Only use `EditContext` on Chrome versions that support passing it an inverted selection range.
+
+Fix an issue that prevented non-inclusive block widgets from having their `updateDOM` method called when changed.
+
+Re-enable `EditContext` use on Chrome 126 and up.
+
 ## 6.28.1 (2024-06-12)
 
 ### Bug fixes

package/dist/index.cjs

@@ -1297,7 +1297,10 @@ class LineView extends ContentView {
         }
         return rect;
     }
-    become(_other) { return false; }
+    become(other) {
+        return other instanceof LineView && this.children.length == 0 && other.children.length == 0 &&
+            attrsEq(this.attrs, other.attrs) && this.breakAfter == other.breakAfter;
+    }
     covers() { return true; }
     static find(docView, pos) {
         for (let i = 0, off = 0; i < docView.children.length; i++) {
@@ -6639,7 +6642,9 @@ class DOMObserver {
             else
                 this.flush();
         });
-        if (window.EditContext && view.constructor.EDIT_CONTEXT === true) {
+        if (window.EditContext && view.constructor.EDIT_CONTEXT !== false &&
+            // Chrome <126 doesn't support inverted selections in edit context (#1392)
+            !(browser.chrome && browser.chrome_version < 126)) {
             this.editContext = new EditContextManager(view);
             if (view.state.facet(editable))
                 view.contentDOM.editContext = this.editContext.editContext;
@@ -7115,7 +7120,7 @@ class EditContextManager {
             let rects = [], prev = null;
             for (let i = this.toEditorPos(e.rangeStart), end = this.toEditorPos(e.rangeEnd); i < end; i++) {
                 let rect = view.coordsForChar(i);
-                prev = (rect && new DOMRect(rect.left, rect.right, rect.right - rect.left, rect.bottom - rect.top))
+                prev = (rect && new DOMRect(rect.left, rect.top, rect.right - rect.left, rect.bottom - rect.top))
                     || prev || new DOMRect;
                 rects.push(prev);
             }

package/dist/index.js

@@ -1295,7 +1295,10 @@ class LineView extends ContentView {
         }
         return rect;
     }
-    become(_other) { return false; }
+    become(other) {
+        return other instanceof LineView && this.children.length == 0 && other.children.length == 0 &&
+            attrsEq(this.attrs, other.attrs) && this.breakAfter == other.breakAfter;
+    }
     covers() { return true; }
     static find(docView, pos) {
         for (let i = 0, off = 0; i < docView.children.length; i++) {
@@ -6634,7 +6637,9 @@ class DOMObserver {
             else
                 this.flush();
         });
-        if (window.EditContext && view.constructor.EDIT_CONTEXT === true) {
+        if (window.EditContext && view.constructor.EDIT_CONTEXT !== false &&
+            // Chrome <126 doesn't support inverted selections in edit context (#1392)
+            !(browser.chrome && browser.chrome_version < 126)) {
             this.editContext = new EditContextManager(view);
             if (view.state.facet(editable))
                 view.contentDOM.editContext = this.editContext.editContext;
@@ -7110,7 +7115,7 @@ class EditContextManager {
             let rects = [], prev = null;
             for (let i = this.toEditorPos(e.rangeStart), end = this.toEditorPos(e.rangeEnd); i < end; i++) {
                 let rect = view.coordsForChar(i);
-                prev = (rect && new DOMRect(rect.left, rect.right, rect.right - rect.left, rect.bottom - rect.top))
+                prev = (rect && new DOMRect(rect.left, rect.top, rect.right - rect.left, rect.bottom - rect.top))
                     || prev || new DOMRect;
                 rects.push(prev);
             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codemirror/view",
-  "version": "6.28.1",
+  "version": "6.28.3",
   "description": "DOM view component for the CodeMirror code editor",
   "scripts": {
     "test": "cm-runtests",