@codemirror/view 6.28.0 → 6.28.2

package/CHANGELOG.md

@@ -1,3 +1,21 @@
+## 6.28.2 (2024-06-21)
+
+### Bug fixes
+
+Only use `EditContext` on Chrome versions that support passing it an inverted selection range.
+
+Fix an issue that prevented non-inclusive block widgets from having their `updateDOM` method called when changed.
+
+Re-enable `EditContext` use on Chrome 126 and up.
+
+## 6.28.1 (2024-06-12)
+
+### Bug fixes
+
+Disable `EditContext` by default again, to work around a regression where Chrome's implementation doesn't support inverted selections.
+
+Make sure `EditorView.editable` is respected when `EditContext` is used.
+
 ## 6.28.0 (2024-06-10)
 
 ### Bug fixes

package/dist/index.cjs

@@ -1297,7 +1297,10 @@ class LineView extends ContentView {
         }
         return rect;
     }
-    become(_other) { return false; }
+    become(other) {
+        return other instanceof LineView && this.children.length == 0 && other.children.length == 0 &&
+            attrsEq(this.attrs, other.attrs) && this.breakAfter == other.breakAfter;
+    }
     covers() { return true; }
     static find(docView, pos) {
         for (let i = 0, off = 0; i < docView.children.length; i++) {
@@ -6639,9 +6642,12 @@ class DOMObserver {
             else
                 this.flush();
         });
-        if (window.EditContext && view.constructor.EDIT_CONTEXT !== false) {
+        if (window.EditContext && view.constructor.EDIT_CONTEXT !== false &&
+            // Chrome <126 doesn't support inverted selections in edit context (#1392)
+            !(browser.chrome && browser.chrome_version < 126)) {
             this.editContext = new EditContextManager(view);
-            view.contentDOM.editContext = this.editContext.editContext;
+            if (view.state.facet(editable))
+                view.contentDOM.editContext = this.editContext.editContext;
         }
         if (useCharData)
             this.onCharData = (event) => {
@@ -7005,8 +7011,11 @@ class DOMObserver {
         win.document.removeEventListener("selectionchange", this.onSelectionChange);
     }
     update(update) {
-        if (this.editContext)
+        if (this.editContext) {
             this.editContext.update(update);
+            if (update.startState.facet(editable) != update.state.facet(editable))
+                update.view.contentDOM.editContext = update.state.facet(editable) ? this.editContext.editContext : null;
+        }
     }
     destroy() {
         var _a, _b, _c;

package/dist/index.js

@@ -1295,7 +1295,10 @@ class LineView extends ContentView {
         }
         return rect;
     }
-    become(_other) { return false; }
+    become(other) {
+        return other instanceof LineView && this.children.length == 0 && other.children.length == 0 &&
+            attrsEq(this.attrs, other.attrs) && this.breakAfter == other.breakAfter;
+    }
     covers() { return true; }
     static find(docView, pos) {
         for (let i = 0, off = 0; i < docView.children.length; i++) {
@@ -6634,9 +6637,12 @@ class DOMObserver {
             else
                 this.flush();
         });
-        if (window.EditContext && view.constructor.EDIT_CONTEXT !== false) {
+        if (window.EditContext && view.constructor.EDIT_CONTEXT !== false &&
+            // Chrome <126 doesn't support inverted selections in edit context (#1392)
+            !(browser.chrome && browser.chrome_version < 126)) {
             this.editContext = new EditContextManager(view);
-            view.contentDOM.editContext = this.editContext.editContext;
+            if (view.state.facet(editable))
+                view.contentDOM.editContext = this.editContext.editContext;
         }
         if (useCharData)
             this.onCharData = (event) => {
@@ -7000,8 +7006,11 @@ class DOMObserver {
         win.document.removeEventListener("selectionchange", this.onSelectionChange);
     }
     update(update) {
-        if (this.editContext)
+        if (this.editContext) {
             this.editContext.update(update);
+            if (update.startState.facet(editable) != update.state.facet(editable))
+                update.view.contentDOM.editContext = update.state.facet(editable) ? this.editContext.editContext : null;
+        }
     }
     destroy() {
         var _a, _b, _c;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codemirror/view",
-  "version": "6.28.0",
+  "version": "6.28.2",
   "description": "DOM view component for the CodeMirror code editor",
   "scripts": {
     "test": "cm-runtests",