@codemirror/view 6.20.0 → 6.20.1

package/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 6.20.1 (2023-09-22)
+
+### Bug fixes
+
+Fix a crash in plugin event handlers after dynamic reconfiguration.
+
+Fix an issue where, on Chrome, tooltips would no longer use fixed positioning.
+
 ## 6.20.0 (2023-09-20)
 
 ### Bug fixes

package/dist/index.cjs

@@ -5335,9 +5335,9 @@ class ViewState {
         if (domRect.width && domRect.height) {
             let scaleX = domRect.width / dom.offsetWidth;
             let scaleY = domRect.height / dom.offsetHeight;
-            if (scaleX > 0.995 && scaleX < 1.005)
+            if (scaleX > 0.995 && scaleX < 1.005 || !isFinite(scaleX))
                 scaleX = 1;
-            if (scaleY > 0.995 && scaleY < 1.005)
+            if (scaleY > 0.995 && scaleY < 1.005 || !isFinite(scaleY))
                 scaleY = 1;
             if (this.scaleX != scaleX || this.scaleY != scaleY) {
                 this.scaleX = scaleX;
@@ -7084,7 +7084,6 @@ class EditorView {
                     plugin.destroy(this);
             this.plugins = newPlugins;
             this.pluginMap.clear();
-            this.inputState.ensureHandlers(this.plugins);
         }
         else {
             for (let p of this.plugins)
@@ -7092,6 +7091,8 @@ class EditorView {
         }
         for (let i = 0; i < this.plugins.length; i++)
             this.plugins[i].update(this);
+        if (prevSpecs != specs)
+            this.inputState.ensureHandlers(this.plugins);
     }
     /**
     @internal
@@ -9189,13 +9190,13 @@ const tooltipPlugin = ViewPlugin.fromClass(class {
     readMeasure() {
         let editor = this.view.dom.getBoundingClientRect();
         let scaleX = 1, scaleY = 1, makeAbsolute = false;
-        if (this.position == "fixed") {
-            let views = this.manager.tooltipViews;
-            // When the dialog's offset parent isn't the body, we are
-            // probably in a transformed container, and should use absolute
-            // positioning instead, since fixed positioning inside a
-            // transform works in a very broken way.
-            makeAbsolute = views.length > 0 && views[0].dom.offsetParent != this.container.ownerDocument.body;
+        if (this.position == "fixed" && this.manager.tooltipViews.length) {
+            // When the dialog's offset parent isn't the body (Firefox) or
+            // null (Webkit), we are probably in a transformed container,
+            // and should use absolute positioning instead, since fixed
+            // positioning inside a transform works in a very broken way.
+            let { offsetParent } = this.manager.tooltipViews[0].dom;
+            makeAbsolute = !!(offsetParent && offsetParent != this.container.ownerDocument.body);
         }
         if (makeAbsolute || this.position == "absolute") {
             if (this.parent) {

package/dist/index.js

@@ -5330,9 +5330,9 @@ class ViewState {
         if (domRect.width && domRect.height) {
             let scaleX = domRect.width / dom.offsetWidth;
             let scaleY = domRect.height / dom.offsetHeight;
-            if (scaleX > 0.995 && scaleX < 1.005)
+            if (scaleX > 0.995 && scaleX < 1.005 || !isFinite(scaleX))
                 scaleX = 1;
-            if (scaleY > 0.995 && scaleY < 1.005)
+            if (scaleY > 0.995 && scaleY < 1.005 || !isFinite(scaleY))
                 scaleY = 1;
             if (this.scaleX != scaleX || this.scaleY != scaleY) {
                 this.scaleX = scaleX;
@@ -7079,7 +7079,6 @@ class EditorView {
                     plugin.destroy(this);
             this.plugins = newPlugins;
             this.pluginMap.clear();
-            this.inputState.ensureHandlers(this.plugins);
         }
         else {
             for (let p of this.plugins)
@@ -7087,6 +7086,8 @@ class EditorView {
         }
         for (let i = 0; i < this.plugins.length; i++)
             this.plugins[i].update(this);
+        if (prevSpecs != specs)
+            this.inputState.ensureHandlers(this.plugins);
     }
     /**
     @internal
@@ -9184,13 +9185,13 @@ const tooltipPlugin = /*@__PURE__*/ViewPlugin.fromClass(class {
     readMeasure() {
         let editor = this.view.dom.getBoundingClientRect();
         let scaleX = 1, scaleY = 1, makeAbsolute = false;
-        if (this.position == "fixed") {
-            let views = this.manager.tooltipViews;
-            // When the dialog's offset parent isn't the body, we are
-            // probably in a transformed container, and should use absolute
-            // positioning instead, since fixed positioning inside a
-            // transform works in a very broken way.
-            makeAbsolute = views.length > 0 && views[0].dom.offsetParent != this.container.ownerDocument.body;
+        if (this.position == "fixed" && this.manager.tooltipViews.length) {
+            // When the dialog's offset parent isn't the body (Firefox) or
+            // null (Webkit), we are probably in a transformed container,
+            // and should use absolute positioning instead, since fixed
+            // positioning inside a transform works in a very broken way.
+            let { offsetParent } = this.manager.tooltipViews[0].dom;
+            makeAbsolute = !!(offsetParent && offsetParent != this.container.ownerDocument.body);
         }
         if (makeAbsolute || this.position == "absolute") {
             if (this.parent) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codemirror/view",
-  "version": "6.20.0",
+  "version": "6.20.1",
   "description": "DOM view component for the CodeMirror code editor",
   "scripts": {
     "test": "cm-runtests",