@codemirror/view 0.19.14 → 0.19.15

package/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 0.19.15 (2021-11-09)
+
+### Bug fixes
+
+Fix a bug where the editor would think it was invisible when the document body was given screen height and scroll behavior.
+
+Fix selection reading inside a shadow root on iOS.
+
 ## 0.19.14 (2021-11-07)
 
 ### Bug fixes

package/dist/index.cjs

@@ -252,19 +252,6 @@ function dispatchKey(elt, name, code) {
     elt.dispatchEvent(up);
     return down.defaultPrevented || up.defaultPrevented;
 }
-let _plainTextSupported = null;
-function contentEditablePlainTextSupported() {
-    if (_plainTextSupported == null) {
-        _plainTextSupported = false;
-        let dummy = document.createElement("div");
-        try {
-            dummy.contentEditable = "plaintext-only";
-            _plainTextSupported = dummy.contentEditable == "plaintext-only";
-        }
-        catch (_) { }
-    }
-    return _plainTextSupported;
-}
 function getRoot(node) {
     while (node) {
         if (node && (node.nodeType == 9 || node.nodeType == 11 && node.host))
@@ -4402,18 +4389,20 @@ function visiblePixelRange(dom, paddingTop) {
     let rect = dom.getBoundingClientRect();
     let left = Math.max(0, rect.left), right = Math.min(innerWidth, rect.right);
     let top = Math.max(0, rect.top), bottom = Math.min(innerHeight, rect.bottom);
-    for (let parent = dom.parentNode; parent;) { // (Cast to any because TypeScript is useless with Node types)
+    let body = dom.ownerDocument.body;
+    for (let parent = dom.parentNode; parent && parent != body;) {
         if (parent.nodeType == 1) {
-            let style = window.getComputedStyle(parent);
-            if ((parent.scrollHeight > parent.clientHeight || parent.scrollWidth > parent.clientWidth) &&
+            let elt = parent;
+            let style = window.getComputedStyle(elt);
+            if ((elt.scrollHeight > elt.clientHeight || elt.scrollWidth > elt.clientWidth) &&
                 style.overflow != "visible") {
-                let parentRect = parent.getBoundingClientRect();
+                let parentRect = elt.getBoundingClientRect();
                 left = Math.max(left, parentRect.left);
                 right = Math.min(right, parentRect.right);
                 top = Math.max(top, parentRect.top);
                 bottom = Math.min(bottom, parentRect.bottom);
             }
-            parent = style.position == "absolute" || style.position == "fixed" ? parent.offsetParent : parent.parentNode;
+            parent = style.position == "absolute" || style.position == "fixed" ? elt.offsetParent : elt.parentNode;
         }
         else if (parent.nodeType == 11) { // Shadow root
             parent = parent.host;
@@ -4943,7 +4932,10 @@ const baseTheme = buildTheme("." + baseThemeID, {
         wordWrap: "normal",
         boxSizing: "border-box",
         padding: "4px 0",
-        outline: "none"
+        outline: "none",
+        "&[contenteditable=true]": {
+            WebkitUserModify: "read-write-plaintext-only",
+        }
     },
     ".cm-lineWrapping": {
         whiteSpace: "pre-wrap",
@@ -5925,7 +5917,7 @@ class EditorView {
             autocorrect: "off",
             autocapitalize: "off",
             translate: "no",
-            contenteditable: !this.state.facet(editable) ? "false" : contentEditablePlainTextSupported() ? "plaintext-only" : "true",
+            contenteditable: !this.state.facet(editable) ? "false" : "true",
             class: "cm-content",
             style: `${browser.tabSize}: ${this.state.tabSize}`,
             role: "textbox",

package/dist/index.js

@@ -249,19 +249,6 @@ function dispatchKey(elt, name, code) {
     elt.dispatchEvent(up);
     return down.defaultPrevented || up.defaultPrevented;
 }
-let _plainTextSupported = null;
-function contentEditablePlainTextSupported() {
-    if (_plainTextSupported == null) {
-        _plainTextSupported = false;
-        let dummy = document.createElement("div");
-        try {
-            dummy.contentEditable = "plaintext-only";
-            _plainTextSupported = dummy.contentEditable == "plaintext-only";
-        }
-        catch (_) { }
-    }
-    return _plainTextSupported;
-}
 function getRoot(node) {
     while (node) {
         if (node && (node.nodeType == 9 || node.nodeType == 11 && node.host))
@@ -4396,18 +4383,20 @@ function visiblePixelRange(dom, paddingTop) {
     let rect = dom.getBoundingClientRect();
     let left = Math.max(0, rect.left), right = Math.min(innerWidth, rect.right);
     let top = Math.max(0, rect.top), bottom = Math.min(innerHeight, rect.bottom);
-    for (let parent = dom.parentNode; parent;) { // (Cast to any because TypeScript is useless with Node types)
+    let body = dom.ownerDocument.body;
+    for (let parent = dom.parentNode; parent && parent != body;) {
         if (parent.nodeType == 1) {
-            let style = window.getComputedStyle(parent);
-            if ((parent.scrollHeight > parent.clientHeight || parent.scrollWidth > parent.clientWidth) &&
+            let elt = parent;
+            let style = window.getComputedStyle(elt);
+            if ((elt.scrollHeight > elt.clientHeight || elt.scrollWidth > elt.clientWidth) &&
                 style.overflow != "visible") {
-                let parentRect = parent.getBoundingClientRect();
+                let parentRect = elt.getBoundingClientRect();
                 left = Math.max(left, parentRect.left);
                 right = Math.min(right, parentRect.right);
                 top = Math.max(top, parentRect.top);
                 bottom = Math.min(bottom, parentRect.bottom);
             }
-            parent = style.position == "absolute" || style.position == "fixed" ? parent.offsetParent : parent.parentNode;
+            parent = style.position == "absolute" || style.position == "fixed" ? elt.offsetParent : elt.parentNode;
         }
         else if (parent.nodeType == 11) { // Shadow root
             parent = parent.host;
@@ -4937,7 +4926,10 @@ const baseTheme = /*@__PURE__*/buildTheme("." + baseThemeID, {
         wordWrap: "normal",
         boxSizing: "border-box",
         padding: "4px 0",
-        outline: "none"
+        outline: "none",
+        "&[contenteditable=true]": {
+            WebkitUserModify: "read-write-plaintext-only",
+        }
     },
     ".cm-lineWrapping": {
         whiteSpace: "pre-wrap",
@@ -5919,7 +5911,7 @@ class EditorView {
             autocorrect: "off",
             autocapitalize: "off",
             translate: "no",
-            contenteditable: !this.state.facet(editable) ? "false" : contentEditablePlainTextSupported() ? "plaintext-only" : "true",
+            contenteditable: !this.state.facet(editable) ? "false" : "true",
             class: "cm-content",
             style: `${browser.tabSize}: ${this.state.tabSize}`,
             role: "textbox",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codemirror/view",
-  "version": "0.19.14",
+  "version": "0.19.15",
   "description": "DOM view component for the CodeMirror code editor",
   "scripts": {
     "test": "cm-runtests",