@codemirror/autocomplete 6.8.0 → 6.8.1

package/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 6.8.1 (2023-06-23)
+
+### Bug fixes
+
+`acceptCompletion` now returns false (allowing other handlers to take effect) when the completion popup is open but disabled.
+
 ## 6.8.0 (2023-06-12)
 
 ### New features

package/dist/index.cjs

@@ -731,9 +731,10 @@ function sortOptions(active, state) {
     let result = [], prev = null;
     let compare = state.facet(completionConfig).compareCompletions;
     for (let opt of options.sort((a, b) => (b.score - a.score) || compare(a.completion, b.completion))) {
-        if (!prev || prev.label != opt.completion.label || prev.detail != opt.completion.detail ||
-            (prev.type != null && opt.completion.type != null && prev.type != opt.completion.type) ||
-            prev.apply != opt.completion.apply)
+        let cur = opt.completion;
+        if (!prev || prev.label != cur.label || prev.detail != cur.detail ||
+            (prev.type != null && cur.type != null && prev.type != cur.type) ||
+            prev.apply != cur.apply || prev.boost != cur.boost)
             result.push(opt);
         else if (score(opt.completion) > score(prev))
             result[result.length - 1] = opt;
@@ -977,12 +978,10 @@ Accept the current completion.
 */
 const acceptCompletion = (view) => {
     let cState = view.state.field(completionState, false);
-    if (view.state.readOnly || !cState || !cState.open || cState.open.selected < 0 ||
+    if (view.state.readOnly || !cState || !cState.open || cState.open.selected < 0 || cState.open.disabled ||
         Date.now() - cState.open.timestamp < view.state.facet(completionConfig).interactionDelay)
         return false;
-    if (!cState.open.disabled)
-        return applyCompletion(view, cState.open.options[cState.open.selected]);
-    return true;
+    return applyCompletion(view, cState.open.options[cState.open.selected]);
 };
 /**
 Explicitly start autocompletion.

package/dist/index.js

@@ -727,9 +727,10 @@ function sortOptions(active, state) {
     let result = [], prev = null;
     let compare = state.facet(completionConfig).compareCompletions;
     for (let opt of options.sort((a, b) => (b.score - a.score) || compare(a.completion, b.completion))) {
-        if (!prev || prev.label != opt.completion.label || prev.detail != opt.completion.detail ||
-            (prev.type != null && opt.completion.type != null && prev.type != opt.completion.type) ||
-            prev.apply != opt.completion.apply)
+        let cur = opt.completion;
+        if (!prev || prev.label != cur.label || prev.detail != cur.detail ||
+            (prev.type != null && cur.type != null && prev.type != cur.type) ||
+            prev.apply != cur.apply || prev.boost != cur.boost)
             result.push(opt);
         else if (score(opt.completion) > score(prev))
             result[result.length - 1] = opt;
@@ -973,12 +974,10 @@ Accept the current completion.
 */
 const acceptCompletion = (view) => {
     let cState = view.state.field(completionState, false);
-    if (view.state.readOnly || !cState || !cState.open || cState.open.selected < 0 ||
+    if (view.state.readOnly || !cState || !cState.open || cState.open.selected < 0 || cState.open.disabled ||
         Date.now() - cState.open.timestamp < view.state.facet(completionConfig).interactionDelay)
         return false;
-    if (!cState.open.disabled)
-        return applyCompletion(view, cState.open.options[cState.open.selected]);
-    return true;
+    return applyCompletion(view, cState.open.options[cState.open.selected]);
 };
 /**
 Explicitly start autocompletion.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codemirror/autocomplete",
-  "version": "6.8.0",
+  "version": "6.8.1",
   "description": "Autocompletion for the CodeMirror code editor",
   "scripts": {
     "test": "cm-runtests",