@codemem/server 0.32.3 → 0.33.0-alpha.2

package/dist/index.js

@@ -1,6 +1,6 @@
 import { existsSync, readFileSync } from "node:fs";
 import { dirname, join } from "node:path";
-import { CODEMEM_CONFIG_ENV_OVERRIDES, DEFAULT_TIME_WINDOW_S, LEGACY_SHARED_REVIEW_SCOPE_ID, LOCAL_DEFAULT_SCOPE_ID, LOCAL_SYNC_CAPABILITY, MemoryStore, SYNC_SCOPE_QUERY_PARAM, VERSION, VERSION as VERSION$1, addSyncScopeToBoundary, analyzeProjectScopeMappingChangeGuardrails, applyReplicationOps, buildBaseUrl, buildFilterClausesWithContext, buildRawEventEnvelopeFromHook, canonicalMemoryKind, canonicalWorkspaceIdentity, cleanupNonces, coordinatorArchiveGroupAction, coordinatorCreateGroupAction, coordinatorCreateInviteAction, coordinatorCreateScopeAction, coordinatorDisableDeviceAction, coordinatorEnableDeviceAction, coordinatorGrantScopeMembershipAction, coordinatorImportInviteAction, coordinatorListBootstrapGrantsAction, coordinatorListDevicesAction, coordinatorListGroupsAction, coordinatorListJoinRequestsAction, coordinatorListScopeMembershipsAction, coordinatorListScopesAction, coordinatorRemoveDeviceAction, coordinatorRenameDeviceAction, coordinatorRenameGroupAction, coordinatorReviewJoinRequestAction, coordinatorRevokeBootstrapGrantAction, coordinatorRevokeScopeMembershipAction, coordinatorStatusSnapshot, coordinatorUnarchiveGroupAction, coordinatorUpdateScopeAction, createCoordinatorReciprocalApproval, defaultSpaceScopeIdForGroup, deleteProjectScopeSettingsMapping, ensureDeviceIdentity, extractReplicationOps, filterReplicationOpsForSyncWithStatus, fingerprintPublicKey, formatHostPort, fromJson, getCodememConfigPath, getCodememEnvOverrides, getCoordinatorGroupPreference, getSemanticIndexDiagnostics, getSyncResetState, isSummaryLikeMemory, listCoordinatorJoinRequests, listInboundScopeRejections, listMaintenanceJobs, listObserverProviderOptions, listProjectScopeCandidates, listProjectScopeInventory, listProjectScopeSettingsMappings, listSharingDomainSettingsScopes, loadMemorySnapshotPageForPeer, loadReplicationOpsForPeer, lookupCoordinatorPeers, mergeAddresses, negotiateSyncCapability, normalizeAddress, normalizeSyncCapability, parseStrictInteger, parseSyncScopeRequest, personalScopeGrantStatusForPeer, probeAvailableCredentials, readCodememConfigFile, readCoordinatorSyncConfig, reassignProjectScopeInventoryProject, recordNonce, rejectInboundScopeFailures, requestJson, resolveDbPath, runSyncPass, schema, stripJsonComments, stripPrivateObj, stripTrailingCommas, summarizeInboundScopeRejections, syncScopeResetRequiredPayload, updatePeerAddresses, upsertCoordinatorGroupPreference, upsertProjectScopeSettingsMapping, verifySignature, writeCodememConfigFile } from "@codemem/core";
+import { CODEMEM_CONFIG_ENV_OVERRIDES, DEFAULT_TIME_WINDOW_S, LEGACY_SHARED_REVIEW_SCOPE_ID, LOCAL_DEFAULT_SCOPE_ID, LOCAL_SYNC_CAPABILITY, MemoryStore, SYNC_CAPABILITY_HEADER, SYNC_SCOPE_QUERY_PARAM, VERSION, VERSION as VERSION$1, addSyncScopeToBoundary, analyzeProjectScopeMappingChangeGuardrails, applyReplicationOps, buildBaseUrl, buildFilterClausesWithContext, buildRawEventEnvelopeFromHook, canonicalMemoryKind, canonicalWorkspaceIdentity, cleanupNonces, coordinatorArchiveGroupAction, coordinatorCreateGroupAction, coordinatorCreateInviteAction, coordinatorCreateScopeAction, coordinatorDisableDeviceAction, coordinatorEnableDeviceAction, coordinatorGrantScopeMembershipAction, coordinatorImportInviteAction, coordinatorListBootstrapGrantsAction, coordinatorListDevicesAction, coordinatorListGroupsAction, coordinatorListJoinRequestsAction, coordinatorListScopeMembershipsAction, coordinatorListScopesAction, coordinatorRemoveDeviceAction, coordinatorRenameDeviceAction, coordinatorRenameGroupAction, coordinatorReviewJoinRequestAction, coordinatorRevokeBootstrapGrantAction, coordinatorRevokeScopeMembershipAction, coordinatorStatusSnapshot, coordinatorUnarchiveGroupAction, coordinatorUpdateScopeAction, createCoordinatorReciprocalApproval, defaultSpaceScopeIdForGroup, deleteProjectScopeSettingsMapping, ensureDeviceIdentity, extractReplicationOps, filterReplicationOpsForSyncWithStatus, fingerprintPublicKey, formatHostPort, fromJson, getCodememConfigPath, getCodememEnvOverrides, getCoordinatorGroupPreference, getSemanticIndexDiagnostics, getSyncResetState, isScopedSyncCapability, isSummaryLikeMemory, listAuthorizedScopesForPeer, listCoordinatorJoinRequests, listInboundScopeRejections, listMaintenanceJobs, listObserverProviderOptions, listPerPeerScopeSyncState, listProjectScopeCandidates, listProjectScopeInventory, listProjectScopeSettingsMappings, listSharingDomainSettingsScopes, loadMemorySnapshotPageForPeer, loadReplicationOpsForPeer, lookupCoordinatorPeers, mergeAddresses, negotiateSyncCapability, normalizeAddress, normalizeSyncCapability, parseStrictInteger, parseSyncScopeRequest, personalScopeGrantStatusForPeer, probeAvailableCredentials, readCodememConfigFile, readCoordinatorSyncConfig, reassignProjectScopeInventoryProject, recordNonce, rejectInboundScopeFailures, requestJson, resolveDbPath, runSyncPass, schema, stripJsonComments, stripPrivateObj, stripTrailingCommas, summarizeInboundScopeRejections, syncScopeResetRequiredPayload, updatePeerAddresses, upsertCoordinatorGroupPreference, upsertProjectScopeSettingsMapping, verifySignature, writeCodememConfigFile } from "@codemem/core";
 import { serveStatic } from "@hono/node-server/serve-static";
 import { Hono } from "hono";
 import { createMiddleware } from "hono/factory";
@@ -2258,8 +2258,18 @@ function peerAuthorizedScopes(store, peerDeviceId) {
 }
 function ensureLocalActorRecord(store) {
 	const d = drizzle(store.db, { schema });
-	if (d.select({ actor_id: schema.actors.actor_id }).from(schema.actors).where(eq(schema.actors.actor_id, store.actorId)).get()) return;
 	const now = (/* @__PURE__ */ new Date()).toISOString();
+	d.update(schema.actors).set({
+		is_local: 0,
+		updated_at: now
+	}).where(and(eq(schema.actors.is_local, 1), ne(schema.actors.actor_id, store.actorId))).run();
+	if (d.select({ actor_id: schema.actors.actor_id }).from(schema.actors).where(eq(schema.actors.actor_id, store.actorId)).get()) {
+		d.update(schema.actors).set({
+			is_local: 1,
+			updated_at: now
+		}).where(eq(schema.actors.actor_id, store.actorId)).run();
+		return;
+	}
 	d.insert(schema.actors).values({
 		actor_id: store.actorId,
 		display_name: store.actorDisplayName,
@@ -2335,13 +2345,25 @@ function redactCoordinatorStatus(coordinator, showDiag) {
 		discovered_devices: discovered
 	};
 }
+function detailForNotConfiguredReason(reason) {
+	switch (reason) {
+		case "coordinator_url_missing": return "Configure a coordinator URL before pairing with discovered peers.";
+		case "coordinator_groups_empty": return "Join a coordinator team before pairing with discovered peers.";
+		case "sync_disabled": return "Enable sync on this device before pairing with discovered peers.";
+	}
+}
 async function acceptDiscoveredPeer(store, input) {
 	const config = readCoordinatorSyncConfig();
-	if (!config.syncEnabled || !config.syncCoordinatorUrl || config.syncCoordinatorGroups.length === 0) return {
+	let notConfiguredReason = null;
+	if (!config.syncCoordinatorUrl) notConfiguredReason = "coordinator_url_missing";
+	else if (config.syncCoordinatorGroups.length === 0) notConfiguredReason = "coordinator_groups_empty";
+	else if (!config.syncEnabled) notConfiguredReason = "sync_disabled";
+	if (notConfiguredReason) return {
 		ok: false,
 		status: 400,
 		error: "coordinator_not_configured",
-		detail: "Coordinator must be configured before accepting discovered peers."
+		reason: notConfiguredReason,
+		detail: detailForNotConfiguredReason(notConfiguredReason)
 	};
 	const discovered = await lookupCoordinatorPeers(store, config);
 	const inputFingerprint = String(input.fingerprint ?? "").trim();
@@ -2536,7 +2558,7 @@ function claimedLocalActorScopeStatus(store, row) {
 * When showDiag is false, sensitive fields (fingerprint, last_error, addresses)
 * are redacted.
 */
-function mapPeerRow(store, row, showDiag, recentOpsByPeer, scopeRejectionsByPeer) {
+function mapPeerRow(store, row, showDiag, recentOpsByPeer, scopeRejectionsByPeer, localDeviceId) {
 	const peerId = String(row.peer_device_id ?? "");
 	const recentOps = recentOpsByPeer?.get(peerId) ?? {
 		in: 0,
@@ -2544,6 +2566,10 @@ function mapPeerRow(store, row, showDiag, recentOpsByPeer, scopeRejectionsByPeer
 	};
 	const scopeRejections = scopeRejectionsByPeer?.get(peerId);
 	const addresses = safeJsonList(row.addresses_json);
+	const perScopeSync = listPerPeerScopeSyncState(store.db, {
+		localDeviceId: localDeviceId ?? null,
+		peerDeviceId: peerId
+	});
 	return {
 		peer_device_id: row.peer_device_id,
 		name: row.name,
@@ -2560,6 +2586,7 @@ function mapPeerRow(store, row, showDiag, recentOpsByPeer, scopeRejectionsByPeer
 		actor_id: row.actor_id ?? null,
 		actor_display_name: row.actor_display_name ?? null,
 		authorized_scopes: peerAuthorizedScopes(store, peerId),
+		per_scope_sync: perScopeSync,
 		project_scope: { ...currentProjectScope(row, readPeerProjectFilters(store, String(row.peer_device_id ?? ""))) },
 		recent_ops: {
 			in: recentOps.in,
@@ -2901,6 +2928,20 @@ var PEERS_QUERY = `
 	ORDER BY name, peer_device_id
 `;
 /**
+* Compute the negotiated sync capability for a request by combining the
+* server's local capability with the value the caller advertised in the
+* `X-Codemem-Sync-Capability` header. Routes use this to decide whether to
+* honor scoped-sync wire features such as explicit `scope_id` parameters
+* and `/v1/status` `authorized_scopes` enumeration.
+*
+* Unsigned headers are fine here: the server is computing what it is
+* willing to do, not granting access. Per-scope authorization is enforced
+* separately via the membership cache when a scope_id is actually used.
+*/
+function negotiatedSyncCapability(c) {
+	return negotiateSyncCapability(LOCAL_SYNC_CAPABILITY, normalizeSyncCapability(c.req.header(SYNC_CAPABILITY_HEADER) ?? null));
+}
+/**
 * Peer-to-peer sync protocol routes (/v1/*).
 *
 * These are mounted on the sync listener (0.0.0.0:7337) and are
@@ -2955,13 +2996,19 @@ function syncProtocolRoutes(getStore, opts = {}) {
 			try {
 				const [deviceId, fingerprint] = ensureDeviceIdentity(store.db, { keysDir: syncKeysDir() });
 				const syncReset = getSyncResetState(store.db);
-				return c.json({
+				const authorizedScopes = isScopedSyncCapability(negotiatedSyncCapability(c)) ? listAuthorizedScopesForPeer(store.db, {
+					localDeviceId: deviceId,
+					peerDeviceId: auth.deviceId
+				}) : null;
+				const response = {
 					device_id: deviceId,
 					protocol_version: SYNC_PROTOCOL_VERSION,
 					fingerprint,
 					sync_reset: addSyncScopeToBoundary(syncReset, null),
 					sync_capability: LOCAL_SYNC_CAPABILITY
-				});
+				};
+				if (authorizedScopes !== null) response.authorized_scopes = authorizedScopes;
+				return c.json(response);
 			} catch {
 				return c.json({ error: "internal_error" }, 500);
 			}
@@ -2977,8 +3024,15 @@ function syncProtocolRoutes(getStore, opts = {}) {
 		const peerDeviceId = auth.deviceId;
 		try {
 			const rawScopeId = c.req.query(SYNC_SCOPE_QUERY_PARAM);
-			const scopeRequest = parseSyncScopeRequest(rawScopeId, rawScopeId !== void 0);
-			if (!scopeRequest.ok) return c.json(syncScopeResetRequiredPayload(getSyncResetState(store.db), scopeRequest.reason, LOCAL_SYNC_CAPABILITY), 409);
+			const negotiated = negotiatedSyncCapability(c);
+			const [localDeviceId] = ensureDeviceIdentity(store.db, { keysDir: syncKeysDir() });
+			const scopeRequest = parseSyncScopeRequest(rawScopeId, rawScopeId !== void 0, {
+				db: store.db,
+				localDeviceId,
+				negotiatedCapability: negotiated,
+				peerDeviceId
+			});
+			if (!scopeRequest.ok) return c.json(syncScopeResetRequiredPayload(getSyncResetState(store.db), scopeRequest.reason, LOCAL_SYNC_CAPABILITY, null), 409);
 			const since = c.req.query("since") ?? null;
 			const rawLimit = Number.parseInt(c.req.query("limit") ?? "200", 10);
 			const rawGeneration = c.req.query("generation");
@@ -2986,14 +3040,14 @@ function syncProtocolRoutes(getStore, opts = {}) {
 			const snapshotId = c.req.query("snapshot_id") ?? null;
 			const baselineCursor = c.req.query("baseline_cursor") ?? null;
 			const limit = Number.isFinite(rawLimit) ? Math.max(1, Math.min(rawLimit, 1e3)) : 200;
-			const [localDeviceId] = ensureDeviceIdentity(store.db, { keysDir: syncKeysDir() });
 			const result = loadReplicationOpsForPeer(store.db, {
 				since,
 				limit,
 				deviceId: localDeviceId,
 				generation: Number.isFinite(generation) ? generation : null,
 				snapshotId,
-				baselineCursor
+				baselineCursor,
+				scopeId: scopeRequest.mode === "scoped" ? scopeRequest.scope_id : void 0
 			});
 			if (result.reset_required) return c.json({
 				error: "reset_required",
@@ -3052,8 +3106,15 @@ function syncProtocolRoutes(getStore, opts = {}) {
 			if (limited) return limited;
 			try {
 				const rawScopeId = c.req.query(SYNC_SCOPE_QUERY_PARAM);
-				const scopeRequest = parseSyncScopeRequest(rawScopeId, rawScopeId !== void 0);
-				if (!scopeRequest.ok) return c.json(syncScopeResetRequiredPayload(getSyncResetState(store.db), scopeRequest.reason, LOCAL_SYNC_CAPABILITY), 409);
+				const negotiated = negotiatedSyncCapability(c);
+				const [localDeviceId] = ensureDeviceIdentity(store.db, { keysDir: syncKeysDir() });
+				const scopeRequest = parseSyncScopeRequest(rawScopeId, rawScopeId !== void 0, {
+					db: store.db,
+					localDeviceId,
+					negotiatedCapability: negotiated,
+					peerDeviceId: auth.deviceId
+				});
+				if (!scopeRequest.ok) return c.json(syncScopeResetRequiredPayload(getSyncResetState(store.db), scopeRequest.reason, LOCAL_SYNC_CAPABILITY, null), 409);
 				const rawGeneration = c.req.query("generation");
 				const generation = rawGeneration != null && rawGeneration.trim().length > 0 ? Number.parseInt(rawGeneration, 10) : null;
 				const snapshotId = c.req.query("snapshot_id") ?? null;
@@ -3069,7 +3130,8 @@ function syncProtocolRoutes(getStore, opts = {}) {
 					baselineCursor,
 					pageToken,
 					limit,
-					peerDeviceId: auth.deviceId
+					peerDeviceId: auth.deviceId,
+					scopeId: scopeRequest.mode === "scoped" ? scopeRequest.scope_id : void 0
 				});
 				return c.json({
 					scope_id: scopeRequest.scope_id,
@@ -3107,8 +3169,15 @@ function syncProtocolRoutes(getStore, opts = {}) {
 		} catch {
 			return c.json({ error: "invalid_json" }, 400);
 		}
-		const scopeRequest = parseSyncScopeRequest(body.scope_id, Object.hasOwn(body, "scope_id"));
-		if (!scopeRequest.ok) return c.json(syncScopeResetRequiredPayload(getSyncResetState(store.db), scopeRequest.reason, LOCAL_SYNC_CAPABILITY), 409);
+		const negotiated = negotiateSyncCapability(LOCAL_SYNC_CAPABILITY, normalizeSyncCapability(body.sync_capability));
+		const [localDeviceId] = ensureDeviceIdentity(store.db, { keysDir: syncKeysDir() });
+		const scopeRequest = parseSyncScopeRequest(body.scope_id, Object.hasOwn(body, "scope_id"), {
+			db: store.db,
+			localDeviceId,
+			negotiatedCapability: negotiated,
+			peerDeviceId
+		});
+		if (!scopeRequest.ok) return c.json(syncScopeResetRequiredPayload(getSyncResetState(store.db), scopeRequest.reason, LOCAL_SYNC_CAPABILITY, null), 409);
 		if (!Array.isArray(body.ops)) return c.json({ error: "invalid_ops" }, 400);
 		if (body.ops.length > MAX_SYNC_OPS) return c.json({ error: "too_many_ops" }, 413);
 		const normalizedOps = extractReplicationOps(body);
@@ -3117,11 +3186,9 @@ function syncProtocolRoutes(getStore, opts = {}) {
 			reason: "device_id_mismatch",
 			op_id: op.op_id
 		}, 400);
-		const [localDeviceId] = ensureDeviceIdentity(store.db, { keysDir: syncKeysDir() });
-		const negotiatedCapability = negotiateSyncCapability(LOCAL_SYNC_CAPABILITY, normalizeSyncCapability(body.sync_capability));
 		const filtered = filterOpsForPeer(store, peerDeviceId, localDeviceId, normalizedOps, { applyScopeFilter: false });
 		const rejected = rejectInboundScopeFailures(store.db, normalizedOps, localDeviceId, {
-			enabled: negotiatedCapability !== "unsupported",
+			enabled: negotiated !== "unsupported",
 			peerDeviceId
 		});
 		if (rejected) return c.json({
@@ -3245,7 +3312,7 @@ function syncRoutes(getStore, getSyncRuntimeStatus) {
 			const recentOpsByPeer = traceSync("recentPeerOps", () => recentPeerOps(store));
 			const scopeRejectionsByPeer = traceSync("recentScopeRejectionsByPeer", () => recentScopeRejectionsByPeer(store));
 			const peersItems = peerRows.map((row) => {
-				const peer = mapPeerRow(store, row, showDiag, recentOpsByPeer, scopeRejectionsByPeer);
+				const peer = mapPeerRow(store, row, showDiag, recentOpsByPeer, scopeRejectionsByPeer, deviceRow?.device_id ?? null);
 				peer.status = peerStatus(peer);
 				return peer;
 			});
@@ -3331,7 +3398,8 @@ function syncRoutes(getStore, getSyncRuntimeStatus) {
 			const rows = store.db.prepare(PEERS_QUERY).all();
 			const recentOpsByPeer = recentPeerOps(store);
 			const scopeRejectionsByPeer = recentScopeRejectionsByPeer(store);
-			const peers = rows.map((row) => mapPeerRow(store, row, showDiag, recentOpsByPeer, scopeRejectionsByPeer));
+			const localDeviceId = drizzle(store.db, { schema }).select({ device_id: schema.syncDevice.device_id }).from(schema.syncDevice).limit(1).get()?.device_id ?? null;
+			const peers = rows.map((row) => mapPeerRow(store, row, showDiag, recentOpsByPeer, scopeRejectionsByPeer, localDeviceId));
 			return c.json({
 				items: peers,
 				redacted: !showDiag
@@ -3881,7 +3949,8 @@ function syncRoutes(getStore, getSyncRuntimeStatus) {
 			});
 			if (!result.ok) return c.json({
 				error: result.error,
-				detail: result.detail
+				detail: result.detail,
+				...result.reason ? { reason: result.reason } : {}
 			}, { status: result.status });
 			return c.json({
 				ok: true,
@@ -4981,7 +5050,8 @@ function syncRoutes(getStore, getSyncRuntimeStatus) {
 			if (result.ok) return c.json(result);
 			return c.json({
 				error: result.error,
-				detail: result.detail
+				detail: result.detail,
+				...result.reason ? { reason: result.reason } : {}
 			}, result.status);
 		} catch (error) {
 			return c.json({