@codemcp/agentskills-cli 0.0.7 → 1.0.0

package/dist/__tests__/install-agentskills-mcp.test.js

@@ -0,0 +1,848 @@
+/**
+ * Tests for auto-install agentskills-mcp server feature
+ *
+ * TDD RED PHASE - Tests written before implementation
+ * These tests define the expected behavior of automatically installing
+ * the @codemcp/agentskills-mcp server when running install command.
+ *
+ * Task: agent-skills-2.3.19
+ * Phase: TDD RED - Writing failing tests
+ */
+import { describe, it, expect, beforeEach, vi, afterEach } from "vitest";
+import { installCommand } from "../commands/install.js";
+import { PackageConfigManager, SkillInstaller, MCPConfigManager, MCPDependencyChecker } from "@codemcp/agentskills-core";
+// Mock fs module
+vi.mock("fs", () => ({
+    promises: {
+        mkdir: vi.fn().mockResolvedValue(undefined),
+        access: vi.fn().mockResolvedValue(undefined),
+        readFile: vi.fn(),
+        writeFile: vi.fn(),
+        stat: vi.fn(),
+        rm: vi.fn()
+    }
+}));
+// Mock inquirer
+vi.mock("inquirer", () => ({
+    default: {
+        prompt: vi.fn()
+    }
+}));
+// Mock all dependencies
+vi.mock("@codemcp/agentskills-core", async () => {
+    const actualCore = await vi.importActual("@codemcp/agentskills-core");
+    return {
+        ...actualCore,
+        PackageConfigManager: vi.fn(),
+        SkillInstaller: vi.fn(),
+        MCPConfigManager: vi.fn(),
+        MCPDependencyChecker: vi.fn()
+    };
+});
+vi.mock("ora", () => ({
+    default: vi.fn(() => ({
+        start: vi.fn().mockReturnThis(),
+        stop: vi.fn().mockReturnThis(),
+        succeed: vi.fn().mockReturnThis(),
+        fail: vi.fn().mockReturnThis()
+    }))
+}));
+describe("Install Command - Auto-install agentskills-mcp Server", () => {
+    let mockConfigManager;
+    let mockInstaller;
+    let mockMCPConfigManager;
+    let mockMCPDependencyChecker;
+    let consoleLogSpy;
+    let consoleErrorSpy;
+    let processExitSpy;
+    let processCwdSpy;
+    beforeEach(() => {
+        // Setup mocks
+        mockConfigManager = {
+            loadConfig: vi.fn()
+        };
+        mockInstaller = {
+            install: vi.fn(),
+            generateLockFile: vi.fn(),
+            loadInstalledSkills: vi.fn()
+        };
+        mockMCPConfigManager = {
+            isServerConfigured: vi.fn(),
+            addServer: vi.fn()
+        };
+        mockMCPDependencyChecker = {
+            collectDependencies: vi.fn(),
+            checkDependencies: vi.fn()
+        };
+        vi.mocked(PackageConfigManager).mockImplementation(() => mockConfigManager);
+        vi.mocked(SkillInstaller).mockImplementation(() => mockInstaller);
+        vi.mocked(MCPConfigManager).mockImplementation(() => mockMCPConfigManager);
+        vi.mocked(MCPDependencyChecker).mockImplementation(() => mockMCPDependencyChecker);
+        // Setup spies
+        consoleLogSpy = vi.spyOn(console, "log").mockImplementation(() => { });
+        consoleErrorSpy = vi.spyOn(console, "error").mockImplementation(() => { });
+        processExitSpy = vi
+            .spyOn(process, "exit")
+            .mockImplementation((() => { }));
+        processCwdSpy = vi.spyOn(process, "cwd").mockReturnValue("/test/project");
+        // Default mock implementations
+        mockConfigManager.loadConfig.mockResolvedValue({
+            skills: {},
+            config: {
+                skillsDirectory: ".agentskills/skills",
+                autoDiscover: [],
+                maxSkillSize: 5000,
+                logLevel: "info"
+            },
+            source: {
+                type: "file",
+                path: "/test/project/package.json"
+            }
+        });
+    });
+    afterEach(() => {
+        vi.clearAllMocks();
+        consoleLogSpy.mockRestore();
+        consoleErrorSpy.mockRestore();
+        processExitSpy.mockRestore();
+        processCwdSpy.mockRestore();
+    });
+    describe("First install - agentskills server not configured", () => {
+        it("should add agentskills server after successful skill installation", async () => {
+            // Setup
+            const config = {
+                skills: {
+                    "test-skill": "github:user/test-skill#v1.0.0"
+                },
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            const checkResult = {
+                allConfigured: true,
+                missing: [],
+                configured: []
+            };
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockMCPConfigManager.isServerConfigured.mockResolvedValue(false); // agentskills NOT configured
+            mockInstaller.install.mockResolvedValue({
+                success: true,
+                name: "test-skill",
+                spec: "github:user/test-skill#v1.0.0",
+                resolvedVersion: "1.0.0",
+                integrity: "sha512-abc123",
+                installPath: "/test/.agentskills/skills/test-skill"
+            });
+            mockInstaller.loadInstalledSkills.mockResolvedValue([
+                {
+                    metadata: { name: "test-skill", description: "Test skill" },
+                    body: "Skill content"
+                }
+            ]);
+            mockMCPDependencyChecker.collectDependencies.mockReturnValue([]);
+            mockMCPDependencyChecker.checkDependencies.mockResolvedValue(checkResult);
+            // Execute
+            await installCommand({ cwd: "/test/project", agent: "claude" });
+            // Verify agentskills server was added
+            expect(mockMCPConfigManager.isServerConfigured).toHaveBeenCalledWith("claude-desktop", "agentskills", "/test/project");
+            expect(mockMCPConfigManager.addServer).toHaveBeenCalledWith("claude-desktop", "agentskills", {
+                command: "npx",
+                args: ["-y", "@codemcp/agentskills-mcp"],
+                env: {}
+            }, "/test/project");
+            expect(processExitSpy).toHaveBeenCalledWith(0);
+        });
+        it("should show success message when agentskills server is added", async () => {
+            // Setup
+            const config = {
+                skills: {
+                    "test-skill": "github:user/test-skill#v1.0.0"
+                },
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            const checkResult = {
+                allConfigured: true,
+                missing: [],
+                configured: []
+            };
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockMCPConfigManager.isServerConfigured.mockResolvedValue(false);
+            mockInstaller.install.mockResolvedValue({
+                success: true,
+                name: "test-skill",
+                spec: "github:user/test-skill#v1.0.0",
+                resolvedVersion: "1.0.0",
+                integrity: "sha512-abc123",
+                installPath: "/test/.agentskills/skills/test-skill"
+            });
+            mockInstaller.loadInstalledSkills.mockResolvedValue([
+                {
+                    metadata: { name: "test-skill", description: "Test skill" },
+                    body: "Skill content"
+                }
+            ]);
+            mockMCPDependencyChecker.collectDependencies.mockReturnValue([]);
+            mockMCPDependencyChecker.checkDependencies.mockResolvedValue(checkResult);
+            // Execute
+            await installCommand({ cwd: "/test/project", agent: "claude" });
+            // Verify success message
+            expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining("agentskills"));
+            expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringMatching(/added|configured/i));
+        });
+        it("should use process.cwd() as working directory when server runs", async () => {
+            // Setup
+            const config = {
+                skills: {
+                    "test-skill": "github:user/test-skill#v1.0.0"
+                },
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            const checkResult = {
+                allConfigured: true,
+                missing: [],
+                configured: []
+            };
+            processCwdSpy.mockReturnValue("/custom/working/directory");
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockMCPConfigManager.isServerConfigured.mockResolvedValue(false);
+            mockInstaller.install.mockResolvedValue({
+                success: true,
+                name: "test-skill",
+                spec: "github:user/test-skill#v1.0.0",
+                resolvedVersion: "1.0.0",
+                integrity: "sha512-abc123",
+                installPath: "/test/.agentskills/skills/test-skill"
+            });
+            mockInstaller.loadInstalledSkills.mockResolvedValue([
+                {
+                    metadata: { name: "test-skill", description: "Test skill" },
+                    body: "Skill content"
+                }
+            ]);
+            mockMCPDependencyChecker.collectDependencies.mockReturnValue([]);
+            mockMCPDependencyChecker.checkDependencies.mockResolvedValue(checkResult);
+            // Execute with explicit cwd
+            await installCommand({
+                cwd: "/custom/working/directory",
+                agent: "claude"
+            });
+            // Verify server config without cwd (working directory inherited)
+            expect(mockMCPConfigManager.addServer).toHaveBeenCalledWith("claude-desktop", "agentskills", expect.objectContaining({
+                command: "npx",
+                args: ["-y", "@codemcp/agentskills-mcp"],
+                env: {}
+            }), "/custom/working/directory");
+        });
+        it("should work with --with-mcp flag", async () => {
+            // Setup
+            const config = {
+                skills: {
+                    "test-skill": "github:user/test-skill#v1.0.0"
+                },
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            const checkResult = {
+                allConfigured: true,
+                missing: [],
+                configured: []
+            };
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockMCPConfigManager.isServerConfigured.mockResolvedValue(false);
+            mockInstaller.install.mockResolvedValue({
+                success: true,
+                name: "test-skill",
+                spec: "github:user/test-skill#v1.0.0",
+                resolvedVersion: "1.0.0",
+                integrity: "sha512-abc123",
+                installPath: "/test/.agentskills/skills/test-skill"
+            });
+            mockInstaller.loadInstalledSkills.mockResolvedValue([
+                {
+                    metadata: { name: "test-skill", description: "Test skill" },
+                    body: "Skill content"
+                }
+            ]);
+            mockMCPDependencyChecker.collectDependencies.mockReturnValue([]);
+            mockMCPDependencyChecker.checkDependencies.mockResolvedValue(checkResult);
+            // Execute with --with-mcp
+            await installCommand({
+                cwd: "/test/project",
+                withMcp: true,
+                agent: "claude"
+            });
+            // Verify agentskills server was added
+            expect(mockMCPConfigManager.addServer).toHaveBeenCalledWith("claude-desktop", "agentskills", expect.objectContaining({
+                command: "npx",
+                args: ["-y", "@codemcp/agentskills-mcp"]
+            }), "/test/project");
+        });
+    });
+    describe("Subsequent install - agentskills server already configured", () => {
+        it("should skip adding agentskills server when already configured", async () => {
+            // Setup
+            const config = {
+                skills: {
+                    "test-skill": "github:user/test-skill#v1.0.0"
+                },
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            const checkResult = {
+                allConfigured: true,
+                missing: [],
+                configured: []
+            };
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockMCPConfigManager.isServerConfigured.mockResolvedValue(true); // ALREADY configured
+            mockInstaller.install.mockResolvedValue({
+                success: true,
+                name: "test-skill",
+                spec: "github:user/test-skill#v1.0.0",
+                resolvedVersion: "1.0.0",
+                integrity: "sha512-abc123",
+                installPath: "/test/.agentskills/skills/test-skill"
+            });
+            mockInstaller.loadInstalledSkills.mockResolvedValue([
+                {
+                    metadata: { name: "test-skill", description: "Test skill" },
+                    body: "Skill content"
+                }
+            ]);
+            mockMCPDependencyChecker.collectDependencies.mockReturnValue([]);
+            mockMCPDependencyChecker.checkDependencies.mockResolvedValue(checkResult);
+            // Execute
+            await installCommand({ cwd: "/test/project", agent: "claude" });
+            // Verify agentskills server was NOT added
+            expect(mockMCPConfigManager.isServerConfigured, "/test/project").toHaveBeenCalledWith("claude-desktop", "agentskills", "/test/project");
+            expect(mockMCPConfigManager.addServer).not.toHaveBeenCalled();
+            expect(processExitSpy).toHaveBeenCalledWith(0);
+        });
+        it("should not show message when skipping already configured server", async () => {
+            // Setup
+            const config = {
+                skills: {
+                    "test-skill": "github:user/test-skill#v1.0.0"
+                },
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            const checkResult = {
+                allConfigured: true,
+                missing: [],
+                configured: []
+            };
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockMCPConfigManager.isServerConfigured.mockResolvedValue(true);
+            mockInstaller.install.mockResolvedValue({
+                success: true,
+                name: "test-skill",
+                spec: "github:user/test-skill#v1.0.0",
+                resolvedVersion: "1.0.0",
+                integrity: "sha512-abc123",
+                installPath: "/test/.agentskills/skills/test-skill"
+            });
+            mockInstaller.loadInstalledSkills.mockResolvedValue([
+                {
+                    metadata: { name: "test-skill", description: "Test skill" },
+                    body: "Skill content"
+                }
+            ]);
+            mockMCPDependencyChecker.collectDependencies.mockReturnValue([]);
+            mockMCPDependencyChecker.checkDependencies.mockResolvedValue(checkResult);
+            consoleLogSpy.mockClear(); // Clear previous calls
+            // Execute
+            await installCommand({ cwd: "/test/project", agent: "claude" });
+            // Verify NO message about agentskills MCP server (silently skip)
+            const agentskillsMCPMessages = consoleLogSpy.mock.calls.filter((call) => call.some((arg) => {
+                const str = String(arg).toLowerCase();
+                return (str.includes("agentskills") &&
+                    (str.includes("mcp") ||
+                        str.includes("server") ||
+                        str.includes("added") ||
+                        str.includes("configured")));
+            }));
+            expect(agentskillsMCPMessages.length).toBe(0);
+        });
+    });
+    describe("Works with all MCP client types", () => {
+        it("should add agentskills server for claude-desktop client", async () => {
+            // Setup
+            const config = {
+                skills: {
+                    "test-skill": "github:user/test-skill#v1.0.0"
+                },
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            const checkResult = {
+                allConfigured: true,
+                missing: [],
+                configured: []
+            };
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockMCPConfigManager.isServerConfigured.mockResolvedValue(false);
+            mockInstaller.install.mockResolvedValue({
+                success: true,
+                name: "test-skill",
+                spec: "github:user/test-skill#v1.0.0",
+                resolvedVersion: "1.0.0",
+                integrity: "sha512-abc123",
+                installPath: "/test/.agentskills/skills/test-skill"
+            });
+            mockInstaller.loadInstalledSkills.mockResolvedValue([
+                {
+                    metadata: { name: "test-skill", description: "Test skill" },
+                    body: "Skill content"
+                }
+            ]);
+            mockMCPDependencyChecker.collectDependencies.mockReturnValue([]);
+            mockMCPDependencyChecker.checkDependencies.mockResolvedValue(checkResult);
+            // Execute
+            await installCommand({ cwd: "/test/project", agent: "claude" });
+            // Verify
+            expect(mockMCPConfigManager.addServer).toHaveBeenCalledWith("claude-desktop", "agentskills", expect.any(Object), "/test/project");
+        });
+        it("should add agentskills server for cline client", async () => {
+            // Setup
+            const config = {
+                skills: {
+                    "test-skill": "github:user/test-skill#v1.0.0"
+                },
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            const checkResult = {
+                allConfigured: true,
+                missing: [],
+                configured: []
+            };
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockMCPConfigManager.isServerConfigured.mockResolvedValue(false);
+            mockInstaller.install.mockResolvedValue({
+                success: true,
+                name: "test-skill",
+                spec: "github:user/test-skill#v1.0.0",
+                resolvedVersion: "1.0.0",
+                integrity: "sha512-abc123",
+                installPath: "/test/.agentskills/skills/test-skill"
+            });
+            mockInstaller.loadInstalledSkills.mockResolvedValue([
+                {
+                    metadata: { name: "test-skill", description: "Test skill" },
+                    body: "Skill content"
+                }
+            ]);
+            mockMCPDependencyChecker.collectDependencies.mockReturnValue([]);
+            mockMCPDependencyChecker.checkDependencies.mockResolvedValue(checkResult);
+            // Execute with cline agent
+            await installCommand({ cwd: "/test/project", agent: "cline" });
+            // Verify
+            expect(mockMCPConfigManager.addServer).toHaveBeenCalledWith("cline", "agentskills", expect.any(Object), "/test/project");
+        });
+        it("should add agentskills server for zed client", async () => {
+            // Setup
+            const config = {
+                skills: {
+                    "test-skill": "github:user/test-skill#v1.0.0"
+                },
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            const checkResult = {
+                allConfigured: true,
+                missing: [],
+                configured: []
+            };
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockMCPConfigManager.isServerConfigured.mockResolvedValue(false);
+            mockInstaller.install.mockResolvedValue({
+                success: true,
+                name: "test-skill",
+                spec: "github:user/test-skill#v1.0.0",
+                resolvedVersion: "1.0.0",
+                integrity: "sha512-abc123",
+                installPath: "/test/.agentskills/skills/test-skill"
+            });
+            mockInstaller.loadInstalledSkills.mockResolvedValue([
+                {
+                    metadata: { name: "test-skill", description: "Test skill" },
+                    body: "Skill content"
+                }
+            ]);
+            mockMCPDependencyChecker.collectDependencies.mockReturnValue([]);
+            mockMCPDependencyChecker.checkDependencies.mockResolvedValue(checkResult);
+            // Execute with zed agent
+            await installCommand({ cwd: "/test/project", agent: "zed" });
+            // Verify
+            expect(mockMCPConfigManager.addServer).toHaveBeenCalledWith("zed", "agentskills", expect.any(Object), "/test/project");
+        });
+    });
+    describe("Handle no agent specified", () => {
+        it("should skip MCP configuration when no agent is specified", async () => {
+            // Setup
+            const config = {
+                skills: {
+                    "test-skill": "github:user/test-skill#v1.0.0"
+                },
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockInstaller.install.mockResolvedValue({
+                success: true,
+                name: "test-skill",
+                spec: "github:user/test-skill#v1.0.0",
+                resolvedVersion: "1.0.0",
+                integrity: "sha512-abc123",
+                installPath: "/test/.agentskills/skills/test-skill"
+            });
+            mockInstaller.generateLockFile.mockResolvedValue(undefined);
+            mockInstaller.loadInstalledSkills.mockResolvedValue([]);
+            mockMCPDependencyChecker.collectDependencies.mockReturnValue([]);
+            // Execute without agent parameter
+            await installCommand({ cwd: "/test/project" });
+            // Verify graceful skip - no MCP operations
+            expect(mockMCPConfigManager.isServerConfigured).not.toHaveBeenCalled();
+            expect(mockMCPConfigManager.addServer).not.toHaveBeenCalled();
+            expect(processExitSpy).toHaveBeenCalledWith(0); // Still successful
+        });
+        it("should not show error when no agent is specified", async () => {
+            // Setup
+            const config = {
+                skills: {
+                    "test-skill": "github:user/test-skill#v1.0.0"
+                },
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockInstaller.install.mockResolvedValue({
+                success: true,
+                name: "test-skill",
+                spec: "github:user/test-skill#v1.0.0",
+                resolvedVersion: "1.0.0",
+                integrity: "sha512-abc123",
+                installPath: "/test/.agentskills/skills/test-skill"
+            });
+            mockInstaller.generateLockFile.mockResolvedValue(undefined);
+            mockInstaller.loadInstalledSkills.mockResolvedValue([]);
+            mockMCPDependencyChecker.collectDependencies.mockReturnValue([]);
+            // Execute without agent parameter
+            await installCommand({ cwd: "/test/project" });
+            // Verify no error
+            expect(consoleErrorSpy).not.toHaveBeenCalledWith(expect.stringContaining("agentskills"));
+        });
+    });
+    describe("Handle addServer errors gracefully", () => {
+        it("should not fail installation if addServer throws error", async () => {
+            // Setup
+            const config = {
+                skills: {
+                    "test-skill": "github:user/test-skill#v1.0.0"
+                },
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            const checkResult = {
+                allConfigured: true,
+                missing: [],
+                configured: []
+            };
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockMCPConfigManager.isServerConfigured.mockResolvedValue(false);
+            mockMCPConfigManager.addServer.mockRejectedValue(new Error("Failed to write config"));
+            mockInstaller.install.mockResolvedValue({
+                success: true,
+                name: "test-skill",
+                spec: "github:user/test-skill#v1.0.0",
+                resolvedVersion: "1.0.0",
+                integrity: "sha512-abc123",
+                installPath: "/test/.agentskills/skills/test-skill"
+            });
+            mockInstaller.loadInstalledSkills.mockResolvedValue([
+                {
+                    metadata: { name: "test-skill", description: "Test skill" },
+                    body: "Skill content"
+                }
+            ]);
+            mockMCPDependencyChecker.collectDependencies.mockReturnValue([]);
+            mockMCPDependencyChecker.checkDependencies.mockResolvedValue(checkResult);
+            // Execute
+            await installCommand({ cwd: "/test/project", agent: "claude" });
+            // Verify installation still succeeds
+            expect(processExitSpy).toHaveBeenCalledWith(0);
+        });
+        it("should log warning when addServer fails", async () => {
+            // Setup
+            const config = {
+                skills: {
+                    "test-skill": "github:user/test-skill#v1.0.0"
+                },
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            const checkResult = {
+                allConfigured: true,
+                missing: [],
+                configured: []
+            };
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockMCPConfigManager.isServerConfigured.mockResolvedValue(false);
+            mockMCPConfigManager.addServer.mockRejectedValue(new Error("Failed to write config"));
+            mockInstaller.install.mockResolvedValue({
+                success: true,
+                name: "test-skill",
+                spec: "github:user/test-skill#v1.0.0",
+                resolvedVersion: "1.0.0",
+                integrity: "sha512-abc123",
+                installPath: "/test/.agentskills/skills/test-skill"
+            });
+            mockInstaller.loadInstalledSkills.mockResolvedValue([
+                {
+                    metadata: { name: "test-skill", description: "Test skill" },
+                    body: "Skill content"
+                }
+            ]);
+            mockMCPDependencyChecker.collectDependencies.mockReturnValue([]);
+            mockMCPDependencyChecker.checkDependencies.mockResolvedValue(checkResult);
+            // Execute
+            await installCommand({ cwd: "/test/project", agent: "claude" });
+            // Verify warning was logged
+            expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringMatching(/warning|failed|could not/i));
+        });
+    });
+    describe("Server config format", () => {
+        it("should auto-install even when no skills configured", async () => {
+            // Setup: Config with NO skills
+            const config = {
+                skills: {}, // Empty skills object
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockMCPConfigManager.isServerConfigured.mockResolvedValue(false);
+            // Execute
+            await installCommand({ cwd: "/test/project", agent: "claude" });
+            // Verify agentskills server was added even though no skills
+            expect(mockMCPConfigManager.isServerConfigured, "/test/project").toHaveBeenCalledWith("claude-desktop", "agentskills", "/test/project");
+            expect(mockMCPConfigManager.addServer).toHaveBeenCalledWith("claude-desktop", "agentskills", {
+                command: "npx",
+                args: ["-y", "@codemcp/agentskills-mcp"],
+                env: {}
+            }, "/test/project");
+            // Should exit with 0 (no skills to install message, but still success)
+            expect(processExitSpy).toHaveBeenCalledWith(0);
+        });
+        it("should use correct command format with npx", async () => {
+            // Setup
+            const config = {
+                skills: {
+                    "test-skill": "github:user/test-skill#v1.0.0"
+                },
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            const checkResult = {
+                allConfigured: true,
+                missing: [],
+                configured: []
+            };
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockMCPConfigManager.isServerConfigured.mockResolvedValue(false);
+            mockInstaller.install.mockResolvedValue({
+                success: true,
+                name: "test-skill",
+                spec: "github:user/test-skill#v1.0.0",
+                resolvedVersion: "1.0.0",
+                integrity: "sha512-abc123",
+                installPath: "/test/.agentskills/skills/test-skill"
+            });
+            mockInstaller.loadInstalledSkills.mockResolvedValue([
+                {
+                    metadata: { name: "test-skill", description: "Test skill" },
+                    body: "Skill content"
+                }
+            ]);
+            mockMCPDependencyChecker.collectDependencies.mockReturnValue([]);
+            mockMCPDependencyChecker.checkDependencies.mockResolvedValue(checkResult);
+            // Execute
+            await installCommand({ cwd: "/test/project", agent: "claude" });
+            // Verify exact format
+            expect(mockMCPConfigManager.addServer).toHaveBeenCalledWith("claude-desktop", "agentskills", {
+                command: "npx",
+                args: ["-y", "@codemcp/agentskills-mcp"],
+                env: {}
+            }, "/test/project");
+        });
+        it("should include empty env object in config", async () => {
+            // Setup
+            const config = {
+                skills: {
+                    "test-skill": "github:user/test-skill#v1.0.0"
+                },
+                config: {
+                    skillsDirectory: ".agentskills/skills",
+                    autoDiscover: [],
+                    maxSkillSize: 5000,
+                    logLevel: "info"
+                },
+                source: {
+                    type: "file",
+                    path: "/test/project/package.json"
+                }
+            };
+            const checkResult = {
+                allConfigured: true,
+                missing: [],
+                configured: []
+            };
+            mockConfigManager.loadConfig.mockResolvedValue(config);
+            mockMCPConfigManager.isServerConfigured.mockResolvedValue(false);
+            mockInstaller.install.mockResolvedValue({
+                success: true,
+                name: "test-skill",
+                spec: "github:user/test-skill#v1.0.0",
+                resolvedVersion: "1.0.0",
+                integrity: "sha512-abc123",
+                installPath: "/test/.agentskills/skills/test-skill"
+            });
+            mockInstaller.loadInstalledSkills.mockResolvedValue([
+                {
+                    metadata: { name: "test-skill", description: "Test skill" },
+                    body: "Skill content"
+                }
+            ]);
+            mockMCPDependencyChecker.collectDependencies.mockReturnValue([]);
+            mockMCPDependencyChecker.checkDependencies.mockResolvedValue(checkResult);
+            // Execute
+            await installCommand({ cwd: "/test/project", agent: "claude" });
+            // Verify env is empty object
+            expect(mockMCPConfigManager.addServer).toHaveBeenCalledWith("claude-desktop", "agentskills", expect.objectContaining({
+                env: {}
+            }), "/test/project");
+        });
+    });
+});
+//# sourceMappingURL=install-agentskills-mcp.test.js.map