@codemcp/ade-harnesses 0.2.0 → 0.2.3

package/src/writers/cline.spec.ts

@@ -1,212 +0,0 @@
-import { describe, it, expect, beforeEach, afterEach } from "vitest";
-import { mkdtemp, rm, readFile } from "node:fs/promises";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import type {
-  AutonomyProfile,
-  LogicalConfig,
-  PermissionPolicy
-} from "@codemcp/ade-core";
-import { clineWriter } from "./cline.js";
-
-function autonomyPolicy(profile: AutonomyProfile): PermissionPolicy {
-  switch (profile) {
-    case "rigid":
-      return {
-        profile,
-        capabilities: {
-          read: "ask",
-          edit_write: "ask",
-          search_list: "ask",
-          bash_safe: "ask",
-          bash_unsafe: "ask",
-          web: "ask",
-          task_agent: "ask"
-        }
-      };
-    case "sensible-defaults":
-      return {
-        profile,
-        capabilities: {
-          read: "allow",
-          edit_write: "allow",
-          search_list: "allow",
-          bash_safe: "allow",
-          bash_unsafe: "ask",
-          web: "ask",
-          task_agent: "allow"
-        }
-      };
-    case "max-autonomy":
-      return {
-        profile,
-        capabilities: {
-          read: "allow",
-          edit_write: "allow",
-          search_list: "allow",
-          bash_safe: "allow",
-          bash_unsafe: "allow",
-          web: "ask",
-          task_agent: "allow"
-        }
-      };
-  }
-}
-
-describe("clineWriter", () => {
-  let dir: string;
-
-  beforeEach(async () => {
-    dir = await mkdtemp(join(tmpdir(), "ade-harness-cline-"));
-  });
-
-  afterEach(async () => {
-    await rm(dir, { recursive: true, force: true });
-  });
-
-  it("has correct metadata", () => {
-    expect(clineWriter.id).toBe("cline");
-    expect(clineWriter.label).toBe("Cline");
-  });
-
-  it("writes cline_mcp_settings.json with MCP servers", async () => {
-    const config: LogicalConfig = {
-      mcp_servers: [
-        {
-          ref: "workflows",
-          command: "npx",
-          args: ["-y", "@codemcp/workflows"],
-          env: {}
-        }
-      ],
-      instructions: [],
-      cli_actions: [],
-      knowledge_sources: [],
-      skills: [],
-      git_hooks: [],
-      setup_notes: []
-    };
-
-    await clineWriter.install(config, dir);
-
-    const raw = await readFile(join(dir, "cline_mcp_settings.json"), "utf-8");
-    const parsed = JSON.parse(raw);
-    expect(parsed.mcpServers["workflows"]).toEqual({
-      command: "npx",
-      args: ["-y", "@codemcp/workflows"],
-      alwaysAllow: ["*"]
-    });
-  });
-
-  it("forwards explicit MCP approvals unchanged from provisioning", async () => {
-    const config: LogicalConfig = {
-      mcp_servers: [
-        {
-          ref: "workflows",
-          command: "npx",
-          args: ["-y", "@codemcp/workflows"],
-          env: {},
-          allowedTools: ["whats_next", "proceed_to_phase"]
-        }
-      ],
-      instructions: [],
-      cli_actions: [],
-      knowledge_sources: [],
-      skills: [],
-      git_hooks: [],
-      setup_notes: []
-    };
-
-    await clineWriter.install(config, dir);
-
-    const raw = await readFile(join(dir, "cline_mcp_settings.json"), "utf-8");
-    const parsed = JSON.parse(raw);
-    expect(parsed.mcpServers["workflows"]).toEqual({
-      command: "npx",
-      args: ["-y", "@codemcp/workflows"],
-      alwaysAllow: ["whats_next", "proceed_to_phase"]
-    });
-  });
-
-  it("writes .clinerules with instructions", async () => {
-    const config: LogicalConfig = {
-      mcp_servers: [],
-      instructions: ["Follow TDD."],
-      cli_actions: [],
-      knowledge_sources: [],
-      skills: [],
-      git_hooks: [],
-      setup_notes: []
-    };
-
-    await clineWriter.install(config, dir);
-
-    const content = await readFile(join(dir, ".clinerules"), "utf-8");
-    expect(content).toContain("Follow TDD.");
-  });
-
-  it("does not invent built-in auto-approval settings for autonomy profiles", async () => {
-    const rigidRoot = join(dir, "rigid");
-    const sensibleRoot = join(dir, "sensible");
-    const maxRoot = join(dir, "max");
-
-    const rigidConfig: LogicalConfig = {
-      mcp_servers: [
-        {
-          ref: "workflows",
-          command: "npx",
-          args: ["-y", "@codemcp/workflows"],
-          env: {}
-        }
-      ],
-      instructions: ["Use approvals for risky actions."],
-      cli_actions: [],
-      knowledge_sources: [],
-      skills: [],
-      git_hooks: [],
-      setup_notes: [],
-      permission_policy: autonomyPolicy("rigid")
-    };
-
-    const sensibleConfig: LogicalConfig = {
-      ...rigidConfig,
-      permission_policy: autonomyPolicy("sensible-defaults")
-    };
-
-    const maxConfig: LogicalConfig = {
-      ...rigidConfig,
-      permission_policy: autonomyPolicy("max-autonomy")
-    };
-
-    await clineWriter.install(rigidConfig, rigidRoot);
-    await clineWriter.install(sensibleConfig, sensibleRoot);
-    await clineWriter.install(maxConfig, maxRoot);
-
-    const rigidSettings = JSON.parse(
-      await readFile(join(rigidRoot, "cline_mcp_settings.json"), "utf-8")
-    );
-    const sensibleSettings = JSON.parse(
-      await readFile(join(sensibleRoot, "cline_mcp_settings.json"), "utf-8")
-    );
-    const maxSettings = JSON.parse(
-      await readFile(join(maxRoot, "cline_mcp_settings.json"), "utf-8")
-    );
-    const maxRules = await readFile(join(maxRoot, ".clinerules"), "utf-8");
-
-    expect(rigidSettings).toEqual(sensibleSettings);
-    expect(sensibleSettings).toEqual(maxSettings);
-    expect(maxSettings).toEqual({
-      mcpServers: {
-        workflows: {
-          command: "npx",
-          args: ["-y", "@codemcp/workflows"],
-          alwaysAllow: ["*"]
-        }
-      }
-    });
-    expect(maxRules).toContain("Use approvals for risky actions.");
-    expect(maxRules).not.toContain("browser_action");
-    expect(maxRules).not.toContain("execute_command");
-    expect(maxRules).not.toContain("web");
-  });
-});

package/src/writers/cline.ts

@@ -1,24 +0,0 @@
-import { join } from "node:path";
-import type { LogicalConfig } from "@codemcp/ade-core";
-import type { HarnessWriter } from "../types.js";
-import {
-  writeMcpServers,
-  alwaysAllowEntry,
-  writeRulesFile,
-  writeGitHooks
-} from "../util.js";
-
-export const clineWriter: HarnessWriter = {
-  id: "cline",
-  label: "Cline",
-  description: "VS Code AI agent — cline_mcp_settings.json + .clinerules",
-  async install(config: LogicalConfig, projectRoot: string) {
-    await writeMcpServers(config.mcp_servers, {
-      path: join(projectRoot, "cline_mcp_settings.json"),
-      transform: alwaysAllowEntry
-    });
-
-    await writeRulesFile(config.instructions, join(projectRoot, ".clinerules"));
-    await writeGitHooks(config.git_hooks, projectRoot);
-  }
-};

package/src/writers/copilot.spec.ts

@@ -1,258 +0,0 @@
-import { describe, it, expect, beforeEach, afterEach } from "vitest";
-import { mkdtemp, rm, readFile } from "node:fs/promises";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import type {
-  AutonomyProfile,
-  LogicalConfig,
-  PermissionPolicy
-} from "@codemcp/ade-core";
-import { copilotWriter } from "./copilot.js";
-
-function autonomyPolicy(profile: AutonomyProfile): PermissionPolicy {
-  switch (profile) {
-    case "rigid":
-      return {
-        profile,
-        capabilities: {
-          read: "ask",
-          edit_write: "ask",
-          search_list: "ask",
-          bash_safe: "ask",
-          bash_unsafe: "ask",
-          web: "ask",
-          task_agent: "ask"
-        }
-      };
-    case "sensible-defaults":
-      return {
-        profile,
-        capabilities: {
-          read: "allow",
-          edit_write: "allow",
-          search_list: "allow",
-          bash_safe: "allow",
-          bash_unsafe: "ask",
-          web: "ask",
-          task_agent: "allow"
-        }
-      };
-    case "max-autonomy":
-      return {
-        profile,
-        capabilities: {
-          read: "allow",
-          edit_write: "allow",
-          search_list: "allow",
-          bash_safe: "allow",
-          bash_unsafe: "allow",
-          web: "ask",
-          task_agent: "allow"
-        }
-      };
-  }
-}
-
-describe("copilotWriter", () => {
-  let dir: string;
-
-  beforeEach(async () => {
-    dir = await mkdtemp(join(tmpdir(), "ade-harness-copilot-"));
-  });
-
-  afterEach(async () => {
-    await rm(dir, { recursive: true, force: true });
-  });
-
-  it("has correct metadata", () => {
-    expect(copilotWriter.id).toBe("copilot");
-    expect(copilotWriter.label).toBe("GitHub Copilot");
-  });
-
-  it("writes .vscode/mcp.json with 'servers' key and type field", async () => {
-    const config: LogicalConfig = {
-      mcp_servers: [
-        {
-          ref: "workflows",
-          command: "npx",
-          args: ["-y", "@codemcp/workflows"],
-          env: {}
-        }
-      ],
-      instructions: [],
-      cli_actions: [],
-      knowledge_sources: [],
-      skills: [],
-      git_hooks: [],
-      setup_notes: []
-    };
-
-    await copilotWriter.install(config, dir);
-
-    const raw = await readFile(join(dir, ".vscode", "mcp.json"), "utf-8");
-    const parsed = JSON.parse(raw);
-    // Copilot uses "servers", not "mcpServers"
-    expect(parsed.servers["workflows"]).toEqual({
-      type: "stdio",
-      command: "npx",
-      args: ["-y", "@codemcp/workflows"]
-    });
-  });
-
-  it("does not write copilot-instructions.md (prefers agent definition)", async () => {
-    const config: LogicalConfig = {
-      mcp_servers: [],
-      instructions: ["Follow TDD."],
-      cli_actions: [],
-      knowledge_sources: [],
-      skills: [],
-      git_hooks: [],
-      setup_notes: []
-    };
-
-    await copilotWriter.install(config, dir);
-
-    await expect(
-      readFile(join(dir, ".github", "copilot-instructions.md"), "utf-8")
-    ).rejects.toThrow();
-  });
-
-  it("writes dedicated .github/agents/ade.agent.md with agent definition", async () => {
-    const config: LogicalConfig = {
-      mcp_servers: [
-        {
-          ref: "workflows",
-          command: "npx",
-          args: ["-y", "@codemcp/workflows"],
-          env: {}
-        }
-      ],
-      instructions: ["Follow TDD."],
-      cli_actions: [],
-      knowledge_sources: [],
-      skills: [],
-      git_hooks: [],
-      setup_notes: []
-    };
-
-    await copilotWriter.install(config, dir);
-
-    const content = await readFile(
-      join(dir, ".github", "agents", "ade.agent.md"),
-      "utf-8"
-    );
-    expect(content).toContain("name: ade");
-    expect(content).toContain("tools:");
-    expect(content).toContain("  - workflows/*");
-    expect(content).toContain("mcp-servers:");
-    expect(content).toContain("  workflows:");
-    expect(content).toContain("    type: stdio");
-    expect(content).toContain('    command: "npx"');
-    expect(content).toContain('    args: ["-y","@codemcp/workflows"]');
-    expect(content).toContain('    tools: ["*"]');
-    expect(content).toContain("  - read");
-    expect(content).toContain("  - edit");
-    expect(content).toContain("  - search");
-    expect(content).toContain("  - execute");
-    expect(content).toContain("  - agent");
-    expect(content).toContain("  - web");
-    expect(content).not.toContain("runCommands");
-    expect(content).not.toContain("runTasks");
-    expect(content).not.toContain("fetch");
-    expect(content).not.toContain("githubRepo");
-    expect(content).toContain("Follow TDD.");
-  });
-
-  it("derives the tools allowlist from autonomy while keeping web access approval-gated", async () => {
-    const rigidRoot = join(dir, "rigid");
-    const sensibleRoot = join(dir, "sensible");
-    const maxRoot = join(dir, "max");
-
-    const rigidConfig: LogicalConfig = {
-      mcp_servers: [
-        {
-          ref: "workflows",
-          command: "npx",
-          args: ["-y", "@codemcp/workflows"],
-          env: {}
-        }
-      ],
-      instructions: [],
-      cli_actions: [],
-      knowledge_sources: [],
-      skills: [],
-      git_hooks: [],
-      setup_notes: [],
-      permission_policy: autonomyPolicy("rigid")
-    };
-
-    const sensibleConfig: LogicalConfig = {
-      ...rigidConfig,
-      mcp_servers: [
-        {
-          ref: "workflows",
-          command: "npx",
-          args: ["-y", "@codemcp/workflows"],
-          env: {},
-          allowedTools: ["whats_next", "proceed_to_phase"]
-        }
-      ],
-      permission_policy: autonomyPolicy("sensible-defaults")
-    };
-
-    const maxConfig: LogicalConfig = {
-      ...rigidConfig,
-      permission_policy: autonomyPolicy("max-autonomy")
-    };
-
-    await copilotWriter.install(rigidConfig, rigidRoot);
-    await copilotWriter.install(sensibleConfig, sensibleRoot);
-    await copilotWriter.install(maxConfig, maxRoot);
-
-    const rigidAgent = await readFile(
-      join(rigidRoot, ".github", "agents", "ade.agent.md"),
-      "utf-8"
-    );
-    const sensibleAgent = await readFile(
-      join(sensibleRoot, ".github", "agents", "ade.agent.md"),
-      "utf-8"
-    );
-    const maxAgent = await readFile(
-      join(maxRoot, ".github", "agents", "ade.agent.md"),
-      "utf-8"
-    );
-
-    expect(rigidAgent).not.toContain("  - server/workflows/*");
-    expect(rigidAgent).toContain("  - workflows/*");
-    expect(rigidAgent).not.toContain("  - read");
-    expect(rigidAgent).not.toContain("  - edit");
-    expect(rigidAgent).not.toContain("  - search");
-    expect(rigidAgent).not.toContain("  - execute");
-    expect(rigidAgent).not.toContain("  - agent");
-    expect(rigidAgent).not.toContain("  - web");
-
-    expect(sensibleAgent).toContain("  - read");
-    expect(sensibleAgent).toContain("  - edit");
-    expect(sensibleAgent).toContain("  - search");
-    expect(sensibleAgent).toContain("  - agent");
-    expect(sensibleAgent).not.toContain("  - execute");
-    expect(sensibleAgent).not.toContain("  - todo");
-    expect(sensibleAgent).not.toContain("  - web");
-    expect(sensibleAgent).toContain("  - workflows/whats_next");
-    expect(sensibleAgent).toContain("  - workflows/proceed_to_phase");
-    expect(sensibleAgent).not.toContain("  - workflows/*");
-    expect(sensibleAgent).toContain(
-      '    tools: ["whats_next","proceed_to_phase"]'
-    );
-
-    expect(maxAgent).toContain("  - read");
-    expect(maxAgent).toContain("  - edit");
-    expect(maxAgent).toContain("  - search");
-    expect(maxAgent).toContain("  - execute");
-    expect(maxAgent).toContain("  - agent");
-    expect(maxAgent).toContain("  - todo");
-    expect(maxAgent).not.toContain("  - web");
-    expect(maxAgent).toContain("  - workflows/*");
-    expect(maxAgent).toContain("mcp-servers:");
-  });
-});

package/src/writers/copilot.ts

@@ -1,105 +0,0 @@
-import { join } from "node:path";
-import type { LogicalConfig, McpServerEntry } from "@codemcp/ade-core";
-import type { HarnessWriter } from "../types.js";
-import {
-  writeMcpServers,
-  stdioEntry,
-  writeAgentMd,
-  writeGitHooks
-} from "../util.js";
-import {
-  allowsCapability,
-  hasPermissionPolicy,
-  keepsWebOnAsk
-} from "../permission-policy.js";
-
-export const copilotWriter: HarnessWriter = {
-  id: "copilot",
-  label: "GitHub Copilot",
-  description: "VS Code + CLI — .vscode/mcp.json + .github/agents/ade.agent.md",
-  async install(config: LogicalConfig, projectRoot: string) {
-    await writeMcpServers(config.mcp_servers, {
-      path: join(projectRoot, ".vscode", "mcp.json"),
-      key: "servers",
-      transform: stdioEntry
-    });
-
-    const tools = [
-      ...getBuiltInTools(config),
-      ...getForwardedMcpTools(config.mcp_servers)
-    ];
-
-    await writeAgentMd(config, {
-      path: join(projectRoot, ".github", "agents", "ade.agent.md"),
-      extraFrontmatter: [
-        "tools:",
-        ...tools.map((t) => `  - ${t}`),
-        ...renderCopilotAgentMcpServers(config.mcp_servers)
-      ]
-    });
-    await writeGitHooks(config.git_hooks, projectRoot);
-  }
-};
-
-function getBuiltInTools(config: LogicalConfig): string[] {
-  if (!hasPermissionPolicy(config)) {
-    return ["read", "edit", "search", "execute", "agent", "web"];
-  }
-
-  return [
-    ...(allowsCapability(config, "read") ? ["read"] : []),
-    ...(allowsCapability(config, "edit_write") ? ["edit"] : []),
-    ...(allowsCapability(config, "search_list") ? ["search"] : []),
-    ...(allowsCapability(config, "bash_unsafe") ? ["execute"] : []),
-    ...(allowsCapability(config, "task_agent") ? ["agent"] : []),
-    ...(allowsCapability(config, "task_agent") &&
-    allowsCapability(config, "bash_unsafe")
-      ? ["todo"]
-      : []),
-    ...(!keepsWebOnAsk(config) && allowsCapability(config, "web")
-      ? ["web"]
-      : [])
-  ];
-}
-
-function getForwardedMcpTools(servers: McpServerEntry[]): string[] {
-  return servers.flatMap((server) => {
-    const allowedTools = server.allowedTools ?? ["*"];
-    if (allowedTools.includes("*")) {
-      return [`${server.ref}/*`];
-    }
-
-    return allowedTools.map((tool) => `${server.ref}/${tool}`);
-  });
-}
-
-function renderCopilotAgentMcpServers(servers: McpServerEntry[]): string[] {
-  if (servers.length === 0) {
-    return [];
-  }
-
-  const lines = ["mcp-servers:"];
-
-  for (const server of servers) {
-    lines.push(`  ${formatYamlKey(server.ref)}:`);
-    lines.push("    type: stdio");
-    lines.push(`    command: ${JSON.stringify(server.command)}`);
-    lines.push(`    args: ${JSON.stringify(server.args)}`);
-    lines.push(`    tools: ${JSON.stringify(server.allowedTools ?? ["*"])}`);
-
-    if (Object.keys(server.env).length > 0) {
-      lines.push("    env:");
-      for (const [key, value] of Object.entries(server.env)) {
-        lines.push(`      ${formatYamlKey(key)}: ${JSON.stringify(value)}`);
-      }
-    }
-  }
-
-  return lines;
-}
-
-function formatYamlKey(value: string): string {
-  return /^[A-Za-z_][A-Za-z0-9_-]*$/.test(value)
-    ? value
-    : JSON.stringify(value);
-}