@codemcp/ade-harnesses 0.0.2 → 0.1.0

package/src/writers/kiro.spec.ts

@@ -0,0 +1,228 @@
+import { describe, it, expect, beforeEach, afterEach } from "vitest";
+import { mkdtemp, rm, readFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import type {
+  AutonomyProfile,
+  LogicalConfig,
+  PermissionPolicy
+} from "@codemcp/ade-core";
+import { kiroWriter } from "./kiro.js";
+
+function autonomyPolicy(profile: AutonomyProfile): PermissionPolicy {
+  switch (profile) {
+    case "rigid":
+      return {
+        profile,
+        capabilities: {
+          read: "ask",
+          edit_write: "ask",
+          search_list: "ask",
+          bash_safe: "ask",
+          bash_unsafe: "ask",
+          web: "ask",
+          task_agent: "ask"
+        }
+      };
+    case "sensible-defaults":
+      return {
+        profile,
+        capabilities: {
+          read: "allow",
+          edit_write: "allow",
+          search_list: "allow",
+          bash_safe: "allow",
+          bash_unsafe: "ask",
+          web: "ask",
+          task_agent: "allow"
+        }
+      };
+    case "max-autonomy":
+      return {
+        profile,
+        capabilities: {
+          read: "allow",
+          edit_write: "allow",
+          search_list: "allow",
+          bash_safe: "allow",
+          bash_unsafe: "allow",
+          web: "ask",
+          task_agent: "allow"
+        }
+      };
+  }
+}
+
+describe("kiroWriter", () => {
+  let dir: string;
+
+  beforeEach(async () => {
+    dir = await mkdtemp(join(tmpdir(), "ade-harness-kiro-"));
+  });
+
+  afterEach(async () => {
+    await rm(dir, { recursive: true, force: true });
+  });
+
+  it("has correct metadata", () => {
+    expect(kiroWriter.id).toBe("kiro");
+    expect(kiroWriter.label).toBe("Kiro");
+    expect(kiroWriter.description).toContain(".kiro/agents/ade.json");
+  });
+
+  it("writes a JSON Kiro agent with documented built-in tool selectors", async () => {
+    const config: LogicalConfig = {
+      mcp_servers: [
+        {
+          ref: "workflows",
+          command: "npx",
+          args: ["-y", "@codemcp/workflows"],
+          env: {}
+        }
+      ],
+      instructions: ["Use project workflows."],
+      cli_actions: [],
+      knowledge_sources: [],
+      skills: [],
+      git_hooks: [],
+      setup_notes: []
+    };
+
+    await kiroWriter.install(config, dir);
+
+    const raw = await readFile(
+      join(dir, ".kiro", "agents", "ade.json"),
+      "utf-8"
+    );
+    const content = JSON.parse(raw);
+
+    expect(content.name).toBe("ade");
+    expect(content.mcpServers.workflows).toEqual({
+      command: "npx",
+      args: ["-y", "@codemcp/workflows"],
+      autoApprove: ["*"]
+    });
+    expect(content.tools).toEqual([
+      "read",
+      "write",
+      "shell",
+      "spec",
+      "@workflows/*"
+    ]);
+    expect(content.allowedTools).toEqual([
+      "read",
+      "write",
+      "shell",
+      "spec",
+      "@workflows/*"
+    ]);
+    expect(content.useLegacyMcpJson).toBe(true);
+    expect(content.tools).not.toContain("@workflows");
+    expect(content.prompt).toContain("Use project workflows.");
+  });
+
+  it("writes Kiro MCP settings and forwards provisioning trust via autoApprove", async () => {
+    const config: LogicalConfig = {
+      mcp_servers: [
+        {
+          ref: "workflows",
+          command: "npx",
+          args: ["-y", "@codemcp/workflows"],
+          env: { NODE_ENV: "test" },
+          allowedTools: ["use_skill", "whats_next"]
+        }
+      ],
+      instructions: [],
+      cli_actions: [],
+      knowledge_sources: [],
+      skills: [],
+      git_hooks: [],
+      setup_notes: []
+    };
+
+    await kiroWriter.install(config, dir);
+
+    const raw = await readFile(
+      join(dir, ".kiro", "settings", "mcp.json"),
+      "utf-8"
+    );
+    const parsed = JSON.parse(raw);
+
+    expect(parsed.mcpServers.workflows).toEqual({
+      command: "npx",
+      args: ["-y", "@codemcp/workflows"],
+      env: { NODE_ENV: "test" },
+      autoApprove: ["use_skill", "whats_next"]
+    });
+  });
+
+  it("maps autonomy only to built-in selectors and keeps web approval-gated", async () => {
+    const rigidRoot = join(dir, "rigid");
+    const maxRoot = join(dir, "max");
+
+    const baseConfig = {
+      mcp_servers: [
+        {
+          ref: "workflows",
+          command: "npx",
+          args: ["-y", "@codemcp/workflows"],
+          env: {},
+          allowedTools: ["*"]
+        }
+      ],
+      instructions: [],
+      cli_actions: [],
+      knowledge_sources: [],
+      skills: [],
+      git_hooks: [],
+      setup_notes: []
+    } satisfies LogicalConfig;
+
+    const rigidConfig: LogicalConfig = {
+      ...baseConfig,
+      permission_policy: autonomyPolicy("rigid")
+    };
+
+    const maxConfig: LogicalConfig = {
+      ...baseConfig,
+      permission_policy: autonomyPolicy("max-autonomy")
+    };
+
+    await kiroWriter.install(rigidConfig, rigidRoot);
+    await kiroWriter.install(maxConfig, maxRoot);
+
+    const rigidAgent = JSON.parse(
+      await readFile(join(rigidRoot, ".kiro", "agents", "ade.json"), "utf-8")
+    );
+    const maxAgent = JSON.parse(
+      await readFile(join(maxRoot, ".kiro", "agents", "ade.json"), "utf-8")
+    );
+    const rigidMcp = JSON.parse(
+      await readFile(join(rigidRoot, ".kiro", "settings", "mcp.json"), "utf-8")
+    );
+    const maxMcp = JSON.parse(
+      await readFile(join(maxRoot, ".kiro", "settings", "mcp.json"), "utf-8")
+    );
+
+    expect(rigidAgent.tools).toContain("read");
+    expect(rigidAgent.tools).toContain("spec");
+    expect(rigidAgent.tools).toContain("@workflows/*");
+    expect(rigidAgent.allowedTools).toContain("@workflows/*");
+    expect(rigidAgent.mcpServers.workflows.autoApprove).toEqual(["*"]);
+    expect(rigidAgent.tools).not.toContain("write");
+    expect(rigidAgent.tools).not.toContain("shell");
+    expect(rigidAgent.tools).not.toContain("web");
+
+    expect(maxAgent.tools).toContain("read");
+    expect(maxAgent.tools).toContain("write");
+    expect(maxAgent.tools).toContain("shell");
+    expect(maxAgent.tools).toContain("spec");
+    expect(maxAgent.tools).toContain("@workflows/*");
+    expect(maxAgent.allowedTools).toContain("@workflows/*");
+    expect(maxAgent.mcpServers.workflows.autoApprove).toEqual(["*"]);
+    expect(maxAgent.tools).not.toContain("web");
+
+    expect(rigidMcp.mcpServers.workflows.autoApprove).toEqual(["*"]);
+    expect(maxMcp.mcpServers.workflows.autoApprove).toEqual(["*"]);
+  });
+});

package/src/writers/kiro.ts

@@ -1,52 +1,89 @@
 import { join } from "node:path";
-import type { LogicalConfig } from "@codemcp/ade-core";
+import type { LogicalConfig, McpServerEntry } from "@codemcp/ade-core";
 import type { HarnessWriter } from "../types.js";
-import { standardEntry, writeJson, writeGitHooks } from "../util.js";
+import {
+  standardEntry,
+  writeGitHooks,
+  writeJson,
+  writeMcpServers
+} from "../util.js";
+import {
+  allowsCapability,
+  getCapabilityDecision,
+  hasPermissionPolicy
+} from "../permission-policy.js";
 
 export const kiroWriter: HarnessWriter = {
   id: "kiro",
   label: "Kiro",
-  description: "AWS AI IDE — .kiro/agents/ade.json",
+  description: "AWS AI IDE — .kiro/agents/ade.json + .kiro/settings/mcp.json",
   async install(config: LogicalConfig, projectRoot: string) {
-    const servers = config.mcp_servers;
-    if (servers.length > 0 || config.instructions.length > 0) {
-      const mcpServers: Record<string, unknown> = {};
-      for (const s of servers) {
-        mcpServers[s.ref] = standardEntry(s);
-      }
+    await writeMcpServers(config.mcp_servers, {
+      path: join(projectRoot, ".kiro", "settings", "mcp.json"),
+      transform: (server) => ({
+        ...standardEntry(server),
+        autoApprove: server.allowedTools ?? ["*"]
+      })
+    });
 
-      const tools: string[] = [
-        "execute_bash",
-        "fs_read",
-        "fs_write",
-        "knowledge",
-        "thinking",
-        ...Object.keys(mcpServers).map((n) => `@${n}`)
-      ];
-
-      const allowedTools: string[] = [];
-      for (const s of servers) {
-        const explicit = s.allowedTools;
-        if (explicit && !explicit.includes("*")) {
-          for (const tool of explicit) {
-            allowedTools.push(`@${s.ref}/${tool}`);
-          }
-        } else {
-          allowedTools.push(`@${s.ref}/*`);
-        }
-      }
+    await writeJson(join(projectRoot, ".kiro", "agents", "ade.json"), {
+      name: "ade",
+      description:
+        "ADE — Agentic Development Environment agent with project conventions and tools.",
+      prompt:
+        config.instructions.join("\n\n") ||
+        "ADE — Agentic Development Environment agent.",
+      mcpServers: getKiroAgentMcpServers(config.mcp_servers),
+      tools: getKiroTools(config),
+      allowedTools: getKiroAllowedTools(config),
+      useLegacyMcpJson: true
+    });
 
-      await writeJson(join(projectRoot, ".kiro", "agents", "ade.json"), {
-        name: "ade",
-        prompt:
-          config.instructions.length > 0
-            ? config.instructions.join("\n\n")
-            : "ADE — Agentic Development Environment agent",
-        mcpServers,
-        tools,
-        allowedTools
-      });
-    }
     await writeGitHooks(config.git_hooks, projectRoot);
   }
 };
+
+function getKiroTools(config: LogicalConfig): string[] {
+  const mcpTools = getKiroForwardedMcpTools(config.mcp_servers);
+
+  if (!hasPermissionPolicy(config)) {
+    return ["read", "write", "shell", "spec", ...mcpTools];
+  }
+
+  return [
+    ...(getCapabilityDecision(config, "read") !== "deny" ? ["read"] : []),
+    ...(allowsCapability(config, "edit_write") ? ["write"] : []),
+    ...(allowsCapability(config, "bash_unsafe") ? ["shell"] : []),
+    "spec",
+    ...mcpTools
+  ];
+}
+
+function getKiroAllowedTools(config: LogicalConfig): string[] {
+  return getKiroTools(config);
+}
+
+function getKiroForwardedMcpTools(servers: McpServerEntry[]): string[] {
+  return servers.flatMap((server) => {
+    const allowedTools = server.allowedTools ?? ["*"];
+    if (allowedTools.includes("*")) {
+      return [`@${server.ref}/*`];
+    }
+
+    return allowedTools.map((tool) => `@${server.ref}/${tool}`);
+  });
+}
+
+function getKiroAgentMcpServers(
+  servers: McpServerEntry[]
+): Record<string, Record<string, unknown>> {
+  return Object.fromEntries(
+    servers.map((server) => [
+      server.ref,
+      {
+        ...standardEntry(server),
+        autoApprove: server.allowedTools ?? ["*"]
+      }
+    ])
+  );
+}

package/src/writers/opencode.spec.ts

@@ -0,0 +1,258 @@
+import { describe, it, expect, beforeEach, afterEach } from "vitest";
+import { mkdtemp, mkdir, rm, readFile, writeFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import type {
+  AutonomyProfile,
+  LogicalConfig,
+  PermissionPolicy
+} from "@codemcp/ade-core";
+import { parse as parseYaml } from "yaml";
+import { opencodeWriter } from "./opencode.js";
+
+function autonomyPolicy(profile: AutonomyProfile): PermissionPolicy {
+  switch (profile) {
+    case "rigid":
+      return {
+        profile,
+        capabilities: {
+          read: "ask",
+          edit_write: "ask",
+          search_list: "ask",
+          bash_safe: "ask",
+          bash_unsafe: "ask",
+          web: "ask",
+          task_agent: "ask"
+        }
+      };
+    case "sensible-defaults":
+      return {
+        profile,
+        capabilities: {
+          read: "allow",
+          edit_write: "allow",
+          search_list: "allow",
+          bash_safe: "allow",
+          bash_unsafe: "ask",
+          web: "ask",
+          task_agent: "allow"
+        }
+      };
+    case "max-autonomy":
+      return {
+        profile,
+        capabilities: {
+          read: "allow",
+          edit_write: "allow",
+          search_list: "allow",
+          bash_safe: "allow",
+          bash_unsafe: "allow",
+          web: "ask",
+          task_agent: "allow"
+        }
+      };
+  }
+}
+
+describe("opencodeWriter", () => {
+  let dir: string;
+
+  beforeEach(async () => {
+    dir = await mkdtemp(join(tmpdir(), "ade-harness-opencode-"));
+  });
+
+  afterEach(async () => {
+    await rm(dir, { recursive: true, force: true });
+  });
+
+  it("writes OpenCode permissions to the ADE agent frontmatter using the documented schema", async () => {
+    const rigidRoot = join(dir, "rigid");
+    const defaultsRoot = join(dir, "defaults");
+    const maxRoot = join(dir, "max");
+
+    const baseConfig = {
+      mcp_servers: [],
+      instructions: ["Follow project rules."],
+      cli_actions: [],
+      knowledge_sources: [],
+      skills: [],
+      git_hooks: [],
+      setup_notes: []
+    } satisfies LogicalConfig;
+
+    const rigidConfig = {
+      ...baseConfig,
+      permission_policy: autonomyPolicy("rigid")
+    } as LogicalConfig;
+
+    const maxConfig = {
+      ...baseConfig,
+      permission_policy: autonomyPolicy("max-autonomy")
+    } as LogicalConfig;
+
+    const defaultsConfig = {
+      ...baseConfig,
+      permission_policy: autonomyPolicy("sensible-defaults")
+    } as LogicalConfig;
+
+    await opencodeWriter.install(rigidConfig, rigidRoot);
+    await opencodeWriter.install(defaultsConfig, defaultsRoot);
+    await opencodeWriter.install(maxConfig, maxRoot);
+
+    const rigidAgent = await readFile(
+      join(rigidRoot, ".opencode", "agents", "ade.md"),
+      "utf-8"
+    );
+    const defaultsAgent = await readFile(
+      join(defaultsRoot, ".opencode", "agents", "ade.md"),
+      "utf-8"
+    );
+    const maxAgent = await readFile(
+      join(maxRoot, ".opencode", "agents", "ade.md"),
+      "utf-8"
+    );
+    const rigidFrontmatter = parseFrontmatter(rigidAgent);
+    const defaultsFrontmatter = parseFrontmatter(defaultsAgent);
+    const maxFrontmatter = parseFrontmatter(maxAgent);
+
+    await expect(
+      readFile(join(rigidRoot, "opencode.json"), "utf-8")
+    ).rejects.toThrow();
+    await expect(
+      readFile(join(defaultsRoot, "opencode.json"), "utf-8")
+    ).rejects.toThrow();
+    await expect(
+      readFile(join(maxRoot, "opencode.json"), "utf-8")
+    ).rejects.toThrow();
+
+    expect(rigidAgent).toContain("permission:");
+    expect(rigidAgent).toContain('"*": "ask"');
+    expect(rigidAgent).toContain('webfetch: "ask"');
+    expect(rigidAgent).toContain('websearch: "ask"');
+    expect(rigidAgent).toContain('codesearch: "ask"');
+    expect(rigidFrontmatter.permission).toMatchObject({
+      "*": "ask",
+      webfetch: "ask",
+      websearch: "ask",
+      codesearch: "ask"
+    });
+
+    expect(defaultsAgent).toContain('edit: "allow"');
+    expect(defaultsAgent).toContain('glob: "allow"');
+    expect(defaultsAgent).toContain('grep: "allow"');
+    expect(defaultsAgent).toContain('list: "allow"');
+    expect(defaultsAgent).toContain('lsp: "allow"');
+    expect(defaultsAgent).toContain('task: "allow"');
+    expect(defaultsAgent).toContain('skill: "deny"');
+    expect(defaultsAgent).toContain('todoread: "deny"');
+    expect(defaultsAgent).toContain('todowrite: "deny"');
+    expect(defaultsAgent).toContain('webfetch: "ask"');
+    expect(defaultsAgent).toContain('websearch: "ask"');
+    expect(defaultsAgent).toContain('codesearch: "ask"');
+    expect(defaultsAgent).toContain('external_directory: "deny"');
+    expect(defaultsAgent).toContain('doom_loop: "deny"');
+    expect(defaultsAgent).toContain('"grep *": "allow"');
+    expect(defaultsAgent).toContain('"cp *": "ask"');
+    expect(defaultsAgent).toContain('"rm *": "deny"');
+    expect(defaultsFrontmatter.permission).toMatchObject({
+      edit: "allow",
+      glob: "allow",
+      grep: "allow",
+      list: "allow",
+      lsp: "allow",
+      task: "allow",
+      skill: "deny",
+      todoread: "deny",
+      todowrite: "deny",
+      webfetch: "ask",
+      websearch: "ask",
+      codesearch: "ask",
+      external_directory: "deny",
+      doom_loop: "deny"
+    });
+    const defaultsPermission = defaultsFrontmatter.permission as {
+      bash: Record<string, string>;
+    };
+    expect(defaultsPermission.bash["grep *"]).toBe("allow");
+    expect(defaultsPermission.bash["cp *"]).toBe("ask");
+    expect(defaultsPermission.bash["rm *"]).toBe("deny");
+
+    expect(maxAgent).toContain('"*": "allow"');
+    expect(maxAgent).toContain('webfetch: "ask"');
+    expect(maxAgent).toContain('websearch: "ask"');
+    expect(maxAgent).toContain('codesearch: "ask"');
+    expect(maxFrontmatter.permission).toMatchObject({
+      "*": "allow",
+      webfetch: "ask",
+      websearch: "ask",
+      codesearch: "ask"
+    });
+    expect(rigidAgent).not.toContain("tools:");
+  });
+
+  it("keeps MCP servers in project config and writes documented environment fields", async () => {
+    const projectRoot = join(dir, "mcp");
+    const config = {
+      mcp_servers: [
+        {
+          ref: "workflows",
+          command: "npx",
+          args: ["@codemcp/workflows-server@latest"],
+          env: { FOO: "bar" },
+          allowedTools: ["whats_next"]
+        }
+      ],
+      instructions: ["Follow project rules."],
+      cli_actions: [],
+      knowledge_sources: [],
+      skills: [],
+      git_hooks: [],
+      setup_notes: [],
+      permission_policy: autonomyPolicy("rigid")
+    } as LogicalConfig;
+
+    await mkdir(projectRoot, { recursive: true });
+    await writeFile(
+      join(projectRoot, "opencode.json"),
+      JSON.stringify(
+        {
+          $schema: "https://opencode.ai/config.json",
+          permission: { read: "allow" }
+        },
+        null,
+        2
+      ) + "\n",
+      "utf-8"
+    );
+
+    await opencodeWriter.install(config, projectRoot);
+
+    const projectJson = JSON.parse(
+      await readFile(join(projectRoot, "opencode.json"), "utf-8")
+    );
+    const agent = await readFile(
+      join(projectRoot, ".opencode", "agents", "ade.md"),
+      "utf-8"
+    );
+
+    expect(projectJson.permission).toEqual({ read: "allow" });
+    expect(projectJson.mcp).toEqual({
+      workflows: {
+        type: "local",
+        command: ["npx", "@codemcp/workflows-server@latest"],
+        environment: { FOO: "bar" }
+      }
+    });
+    expect(agent).toContain("permission:");
+    expect(agent).not.toContain("mcp_servers:");
+  });
+});
+
+function parseFrontmatter(content: string) {
+  const match = content.match(/^---\n([\s\S]*?)\n---/);
+  if (!match) {
+    throw new Error("Expected frontmatter in agent markdown");
+  }
+
+  return parseYaml(match[1]) as Record<string, unknown>;
+}

package/src/writers/opencode.ts

@@ -1,7 +1,8 @@
 import { join } from "node:path";
-import type { LogicalConfig } from "@codemcp/ade-core";
+import type { LogicalConfig, PermissionRule } from "@codemcp/ade-core";
 import type { HarnessWriter } from "../types.js";
-import { writeMcpServers, writeAgentMd, writeGitHooks } from "../util.js";
+import { writeAgentMd, writeGitHooks, writeMcpServers } from "../util.js";
+import { getHarnessPermissionRules } from "../permission-policy.js";
 
 export const opencodeWriter: HarnessWriter = {
   id: "opencode",
@@ -14,41 +15,53 @@ export const opencodeWriter: HarnessWriter = {
       transform: (s) => ({
         type: "local",
         command: [s.command, ...s.args],
-        ...(Object.keys(s.env).length > 0 ? { env: s.env } : {})
+        ...(Object.keys(s.env).length > 0 ? { environment: s.env } : {})
       }),
       defaults: { $schema: "https://opencode.ai/config.json" }
     });
 
-    const servers = config.mcp_servers;
-    const extraFm: string[] = [
-      "tools:",
-      "  read: true",
-      "  edit: approve",
-      "  bash: approve"
-    ];
-
-    if (servers.length > 0) {
-      extraFm.push("mcp_servers:");
-      for (const s of servers) {
-        extraFm.push(`  ${s.ref}:`);
-        extraFm.push(
-          `    command: [${[s.command, ...s.args].map((a) => `"${a}"`).join(", ")}]`
-        );
-        if (Object.keys(s.env).length > 0) {
-          extraFm.push("    env:");
-          for (const [k, v] of Object.entries(s.env)) {
-            extraFm.push(`      ${k}: "${v}"`);
-          }
-        }
-      }
-    }
+    const permission = getHarnessPermissionRules(config);
 
     await writeAgentMd(config, {
       path: join(projectRoot, ".opencode", "agents", "ade.md"),
-      extraFrontmatter: extraFm,
+      extraFrontmatter: permission
+        ? renderYamlMapping("permission", permission)
+        : undefined,
       fallbackBody:
         "ADE — Agentic Development Environment agent with project conventions and tools."
     });
     await writeGitHooks(config.git_hooks, projectRoot);
   }
 };
+
+function renderYamlMapping(
+  key: string,
+  value: Record<string, PermissionRule>,
+  indent = 0
+): string[] {
+  const prefix = " ".repeat(indent);
+  const lines = [`${prefix}${formatYamlKey(key)}:`];
+
+  for (const [childKey, childValue] of Object.entries(value)) {
+    if (
+      typeof childValue === "object" &&
+      childValue !== null &&
+      !Array.isArray(childValue)
+    ) {
+      lines.push(...renderYamlMapping(childKey, childValue, indent + 2));
+      continue;
+    }
+
+    lines.push(
+      `${" ".repeat(indent + 2)}${formatYamlKey(childKey)}: ${JSON.stringify(childValue)}`
+    );
+  }
+
+  return lines;
+}
+
+function formatYamlKey(value: string): string {
+  return /^[A-Za-z_][A-Za-z0-9_-]*$/.test(value)
+    ? value
+    : JSON.stringify(value);
+}