@codemcp/ade-cli 0.2.0 → 0.2.2

package/src/commands/install.integration.spec.ts

@@ -1,123 +0,0 @@
-import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
-import { mkdtemp, rm, readFile } from "node:fs/promises";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-
-// Mock only the TUI — everything else is real
-vi.mock("@clack/prompts", () => ({
-  intro: vi.fn(),
-  outro: vi.fn(),
-  log: { info: vi.fn(), warn: vi.fn(), error: vi.fn() },
-  select: vi.fn(),
-  multiselect: vi.fn(),
-  isCancel: vi.fn().mockReturnValue(false),
-  cancel: vi.fn(),
-  spinner: vi.fn().mockReturnValue({ start: vi.fn(), stop: vi.fn() })
-}));
-
-import * as clack from "@clack/prompts";
-import { runSetup } from "./setup.js";
-import { runInstall } from "./install.js";
-import { getDefaultCatalog } from "../../../core/src/catalog/index.js";
-
-describe("install integration (real temp dir)", () => {
-  let dir: string;
-
-  beforeEach(async () => {
-    vi.clearAllMocks();
-    dir = await mkdtemp(join(tmpdir(), "ade-install-"));
-  });
-
-  afterEach(async () => {
-    await rm(dir, { recursive: true, force: true });
-  });
-
-  it("applies lock file to regenerate agent files without re-resolving", async () => {
-    const catalog = getDefaultCatalog();
-
-    // Step 1: Run setup to create config.yaml + config.lock.yaml
-    vi.mocked(clack.select)
-      .mockResolvedValueOnce("codemcp-workflows") // process
-      .mockResolvedValueOnce("__skip__"); // architecture
-    vi.mocked(clack.multiselect)
-      .mockResolvedValueOnce([]) // practices: none
-      .mockResolvedValueOnce(["claude-code"]); // harnesses
-    await runSetup(dir, catalog);
-
-    // Step 2: Delete agent output files to simulate a fresh clone
-    await rm(join(dir, ".mcp.json"));
-    await rm(join(dir, ".claude"), { recursive: true, force: true });
-
-    // Step 3: Run install — should regenerate from config.lock.yaml
-    await runInstall(dir, ["claude-code"]);
-
-    // Agent files should be back
-    const agentMd = await readFile(
-      join(dir, ".claude", "agents", "ade.md"),
-      "utf-8"
-    );
-    expect(agentMd).toContain("Call whats_next()");
-
-    const mcpJson = JSON.parse(await readFile(join(dir, ".mcp.json"), "utf-8"));
-    expect(mcpJson.mcpServers["workflows"]).toMatchObject({
-      command: "npx",
-      args: ["@codemcp/workflows-server@latest"]
-    });
-  });
-
-  it("does not modify the lock file", async () => {
-    const catalog = getDefaultCatalog();
-
-    // Setup first
-    vi.mocked(clack.select)
-      .mockResolvedValueOnce("codemcp-workflows") // process
-      .mockResolvedValueOnce("__skip__"); // architecture
-    vi.mocked(clack.multiselect)
-      .mockResolvedValueOnce([]) // practices: none
-      .mockResolvedValueOnce(["claude-code"]); // harnesses
-    await runSetup(dir, catalog);
-
-    const lockRawBefore = await readFile(
-      join(dir, "config.lock.yaml"),
-      "utf-8"
-    );
-
-    // Re-install
-    await runInstall(dir, ["claude-code"]);
-
-    const lockRawAfter = await readFile(join(dir, "config.lock.yaml"), "utf-8");
-    // Lock file should be byte-identical (install doesn't rewrite it)
-    expect(lockRawAfter).toBe(lockRawBefore);
-  });
-
-  it("fails when no config.lock.yaml exists", async () => {
-    await expect(runInstall(dir, ["claude-code"])).rejects.toThrow(
-      /config\.lock\.yaml not found/i
-    );
-  });
-
-  it("works with native-agents-md option", async () => {
-    const catalog = getDefaultCatalog();
-
-    // Setup with native-agents-md
-    vi.mocked(clack.select)
-      .mockResolvedValueOnce("native-agents-md") // process
-      .mockResolvedValueOnce("__skip__"); // architecture
-    vi.mocked(clack.multiselect)
-      .mockResolvedValueOnce([]) // practices: none
-      .mockResolvedValueOnce(["claude-code"]); // harnesses
-    await runSetup(dir, catalog);
-
-    // Delete agent output
-    await rm(join(dir, ".claude"), { recursive: true, force: true });
-
-    // Re-install
-    await runInstall(dir, ["claude-code"]);
-
-    const agentMd = await readFile(
-      join(dir, ".claude", "agents", "ade.md"),
-      "utf-8"
-    );
-    expect(agentMd).toContain("AGENTS.md");
-  });
-});

package/src/commands/install.spec.ts

@@ -1,169 +0,0 @@
-import { describe, it, expect, vi, beforeEach } from "vitest";
-import type { LogicalConfig } from "@codemcp/ade-core";
-
-// ── Mocks ────────────────────────────────────────────────────────────────────
-
-vi.mock("@clack/prompts", () => ({
-  intro: vi.fn(),
-  outro: vi.fn(),
-  log: { info: vi.fn(), warn: vi.fn(), error: vi.fn() }
-}));
-
-const mockLogical: LogicalConfig = {
-  mcp_servers: [],
-  instructions: ["test instruction"],
-  cli_actions: [],
-  knowledge_sources: [],
-  skills: [],
-  git_hooks: [],
-  setup_notes: []
-};
-
-vi.mock("@codemcp/ade-core", async (importOriginal) => {
-  const actual = (await importOriginal()) as typeof import("@codemcp/ade-core");
-  return {
-    ...actual,
-    readLockFile: vi.fn()
-  };
-});
-
-const mockInstall = vi.fn().mockResolvedValue(undefined);
-
-vi.mock("@codemcp/ade-harnesses", () => ({
-  getHarnessWriter: vi.fn().mockImplementation((id: string) => {
-    if (id === "universal" || id === "claude-code" || id === "cursor") {
-      return { id, install: mockInstall };
-    }
-    return undefined;
-  }),
-  getHarnessIds: vi
-    .fn()
-    .mockReturnValue([
-      "universal",
-      "claude-code",
-      "cursor",
-      "copilot",
-      "windsurf",
-      "cline",
-      "roo-code",
-      "kiro",
-      "opencode"
-    ]),
-  installSkills: vi.fn().mockResolvedValue(undefined),
-  writeInlineSkills: vi.fn().mockResolvedValue([])
-}));
-
-import * as clack from "@clack/prompts";
-import { readLockFile } from "@codemcp/ade-core";
-import { runInstall } from "./install.js";
-
-// ── Tests ────────────────────────────────────────────────────────────────────
-
-describe("runInstall", () => {
-  beforeEach(async () => {
-    vi.clearAllMocks();
-    // Re-set the default implementation after clearAllMocks
-    const { getHarnessWriter } = await import("@codemcp/ade-harnesses");
-    vi.mocked(getHarnessWriter).mockImplementation((id: string) => {
-      if (id === "universal" || id === "claude-code" || id === "cursor") {
-        return {
-          id,
-          label: id,
-          description: "test",
-          install: mockInstall
-        };
-      }
-      return undefined;
-    });
-  });
-
-  it("reads config.lock.yaml and applies logical config", async () => {
-    vi.mocked(readLockFile).mockResolvedValueOnce({
-      version: 1,
-      generated_at: "2024-01-01T00:00:00.000Z",
-      choices: { process: "codemcp-workflows" },
-      logical_config: mockLogical
-    });
-
-    await runInstall("/tmp/project");
-
-    expect(readLockFile).toHaveBeenCalledWith("/tmp/project");
-  });
-
-  it("defaults to universal harness when none specified", async () => {
-    vi.mocked(readLockFile).mockResolvedValueOnce({
-      version: 1,
-      generated_at: "2024-01-01T00:00:00.000Z",
-      choices: { process: "codemcp-workflows" },
-      logical_config: mockLogical
-    });
-
-    await runInstall("/tmp/project");
-
-    expect(mockInstall).toHaveBeenCalledWith(mockLogical, "/tmp/project");
-  });
-
-  it("uses harnesses from lock file when present", async () => {
-    vi.mocked(readLockFile).mockResolvedValueOnce({
-      version: 1,
-      generated_at: "2024-01-01T00:00:00.000Z",
-      choices: { process: "codemcp-workflows" },
-      harnesses: ["claude-code", "cursor"],
-      logical_config: mockLogical
-    });
-
-    await runInstall("/tmp/project");
-
-    expect(mockInstall).toHaveBeenCalledTimes(2);
-  });
-
-  it("uses explicit harness ids when provided", async () => {
-    vi.mocked(readLockFile).mockResolvedValueOnce({
-      version: 1,
-      generated_at: "2024-01-01T00:00:00.000Z",
-      choices: { process: "codemcp-workflows" },
-      harnesses: ["claude-code"],
-      logical_config: mockLogical
-    });
-
-    await runInstall("/tmp/project", ["cursor"]);
-
-    // Explicit takes priority over lock file
-    expect(mockInstall).toHaveBeenCalledTimes(1);
-  });
-
-  it("throws when config.lock.yaml is missing", async () => {
-    vi.mocked(readLockFile).mockResolvedValueOnce(null);
-
-    await expect(runInstall("/tmp/project")).rejects.toThrow(
-      /config\.lock\.yaml not found/i
-    );
-  });
-
-  it("throws when harness id is unknown", async () => {
-    vi.mocked(readLockFile).mockResolvedValueOnce({
-      version: 1,
-      generated_at: "2024-01-01T00:00:00.000Z",
-      choices: { process: "codemcp-workflows" },
-      logical_config: mockLogical
-    });
-
-    await expect(runInstall("/tmp/project", ["unknown-agent"])).rejects.toThrow(
-      /unknown harness/i
-    );
-  });
-
-  it("shows intro and outro messages", async () => {
-    vi.mocked(readLockFile).mockResolvedValueOnce({
-      version: 1,
-      generated_at: "2024-01-01T00:00:00.000Z",
-      choices: { process: "codemcp-workflows" },
-      logical_config: mockLogical
-    });
-
-    await runInstall("/tmp/project");
-
-    expect(clack.intro).toHaveBeenCalled();
-    expect(clack.outro).toHaveBeenCalled();
-  });
-});

package/src/commands/install.ts

@@ -1,63 +0,0 @@
-import * as clack from "@clack/prompts";
-import { readLockFile } from "@codemcp/ade-core";
-import {
-  getHarnessWriter,
-  getHarnessIds,
-  installSkills,
-  writeInlineSkills
-} from "@codemcp/ade-harnesses";
-
-export async function runInstall(
-  projectRoot: string,
-  harnessIds?: string[]
-): Promise<void> {
-  clack.intro("ade install");
-
-  const lockFile = await readLockFile(projectRoot);
-  if (!lockFile) {
-    throw new Error("config.lock.yaml not found. Run `ade setup` first.");
-  }
-
-  // Determine which harnesses to install for:
-  // 1. --harness flag (comma-separated)
-  // 2. harnesses saved in the lock file
-  // 3. default: universal
-  const ids = harnessIds ?? lockFile.harnesses ?? ["universal"];
-
-  const validIds = getHarnessIds();
-  for (const id of ids) {
-    if (!validIds.includes(id)) {
-      throw new Error(
-        `Unknown harness "${id}". Available: ${validIds.join(", ")}`
-      );
-    }
-  }
-
-  const logicalConfig = lockFile.logical_config;
-
-  for (const id of ids) {
-    const writer = getHarnessWriter(id);
-    if (writer) {
-      await writer.install(logicalConfig, projectRoot);
-    }
-  }
-
-  const modifiedSkills = await writeInlineSkills(logicalConfig, projectRoot);
-  if (modifiedSkills.length > 0) {
-    clack.log.warn(
-      `The following skills have been locally modified and will NOT be updated:\n` +
-        modifiedSkills.map((s) => `  - ${s}`).join("\n") +
-        `\n\nTo use the latest defaults, remove .ade/skills/ and re-run install.`
-    );
-  }
-
-  await installSkills(logicalConfig.skills, projectRoot);
-
-  if (logicalConfig.knowledge_sources.length > 0) {
-    clack.log.info(
-      "Knowledge sources configured. Initialize them separately:\n  npx @codemcp/knowledge init"
-    );
-  }
-
-  clack.outro("Install complete!");
-}

package/src/commands/knowledge.integration.spec.ts

@@ -1,129 +0,0 @@
-import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
-import { mkdtemp, rm, readFile } from "node:fs/promises";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-
-vi.mock("@clack/prompts", () => ({
-  intro: vi.fn(),
-  outro: vi.fn(),
-  select: vi.fn(),
-  multiselect: vi.fn(),
-  confirm: vi.fn(),
-  isCancel: vi.fn().mockReturnValue(false),
-  cancel: vi.fn(),
-  log: { info: vi.fn(), warn: vi.fn() },
-  spinner: vi.fn().mockReturnValue({ start: vi.fn(), stop: vi.fn() })
-}));
-
-import * as clack from "@clack/prompts";
-import { runSetup } from "./setup.js";
-import { readLockFile } from "@codemcp/ade-core";
-import { getDefaultCatalog } from "../../../core/src/catalog/index.js";
-
-describe("knowledge integration", () => {
-  let dir: string;
-
-  beforeEach(async () => {
-    vi.clearAllMocks();
-    dir = await mkdtemp(join(tmpdir(), "ade-knowledge-"));
-  });
-
-  afterEach(async () => {
-    await rm(dir, { recursive: true, force: true });
-  });
-
-  it(
-    "records knowledge sources in lock file when tanstack is selected",
-    { timeout: 60_000 },
-    async () => {
-      const catalog = getDefaultCatalog();
-
-      vi.mocked(clack.select)
-        .mockResolvedValueOnce("codemcp-workflows") // process
-        .mockResolvedValueOnce("tanstack"); // architecture
-
-      vi.mocked(clack.multiselect)
-        .mockResolvedValueOnce([]) // practices: none
-        .mockResolvedValueOnce([]) // backpressure: none
-        .mockResolvedValueOnce([
-          "tanstack-router-docs",
-          "tanstack-query-docs",
-          "tanstack-form-docs",
-          "tanstack-table-docs"
-        ])
-        .mockResolvedValueOnce(["claude-code"]); // harnesses
-
-      await runSetup(dir, catalog);
-
-      // Lock file should contain knowledge_sources
-      const lock = await readLockFile(dir);
-      expect(lock!.logical_config.knowledge_sources).toHaveLength(4);
-      expect(lock!.logical_config.knowledge_sources.map((s) => s.name)).toEqual(
-        expect.arrayContaining([
-          "tanstack-router-docs",
-          "tanstack-query-docs",
-          "tanstack-form-docs",
-          "tanstack-table-docs"
-        ])
-      );
-
-      // MCP server entry for knowledge should be in .mcp.json
-      const mcpJson = JSON.parse(
-        await readFile(join(dir, ".mcp.json"), "utf-8")
-      );
-      expect(mcpJson.mcpServers["knowledge"]).toMatchObject({
-        command: "npx",
-        args: ["-y", "@codemcp/knowledge-server"]
-      });
-
-      // Knowledge init is deferred — user should see a hint
-      expect(clack.log.info).toHaveBeenCalledWith(
-        expect.stringContaining("npx @codemcp/knowledge init")
-      );
-    }
-  );
-
-  it(
-    "excludes deselected docsets from lock file",
-    { timeout: 60_000 },
-    async () => {
-      const catalog = getDefaultCatalog();
-
-      vi.mocked(clack.select)
-        .mockResolvedValueOnce("codemcp-workflows") // process
-        .mockResolvedValueOnce("tanstack"); // architecture
-
-      vi.mocked(clack.multiselect)
-        .mockResolvedValueOnce([]) // practices: none
-        .mockResolvedValueOnce([]) // backpressure: none
-        .mockResolvedValueOnce(["tanstack-router-docs", "tanstack-query-docs"])
-        .mockResolvedValueOnce(["claude-code"]); // harnesses
-
-      await runSetup(dir, catalog);
-
-      // Lock file should only have the 2 selected sources
-      const lock = await readLockFile(dir);
-      expect(lock!.logical_config.knowledge_sources).toHaveLength(2);
-      expect(lock!.logical_config.knowledge_sources.map((s) => s.name)).toEqual(
-        expect.arrayContaining(["tanstack-router-docs", "tanstack-query-docs"])
-      );
-    }
-  );
-
-  it("does not show knowledge hint when no docsets are implied", async () => {
-    const catalog = getDefaultCatalog();
-
-    vi.mocked(clack.select)
-      .mockResolvedValueOnce("native-agents-md") // process
-      .mockResolvedValueOnce("__skip__"); // architecture: skip
-    vi.mocked(clack.multiselect)
-      .mockResolvedValueOnce(["tdd-london"]) // practices: no docsets
-      .mockResolvedValueOnce(["claude-code"]); // harnesses
-
-    await runSetup(dir, catalog);
-
-    expect(clack.log.info).not.toHaveBeenCalledWith(
-      expect.stringContaining("npx @codemcp/knowledge init")
-    );
-  });
-});

package/src/commands/setup.integration.spec.ts

@@ -1,148 +0,0 @@
-import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
-import { mkdtemp, rm } from "node:fs/promises";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-
-// Mock only the TUI — everything else (catalog, registry, resolver, config I/O) is real
-vi.mock("@clack/prompts", () => ({
-  intro: vi.fn(),
-  outro: vi.fn(),
-  select: vi.fn(),
-  multiselect: vi.fn(),
-  confirm: vi.fn(),
-  isCancel: vi.fn().mockReturnValue(false),
-  cancel: vi.fn(),
-  spinner: vi.fn().mockReturnValue({ start: vi.fn(), stop: vi.fn() })
-}));
-
-import * as clack from "@clack/prompts";
-import { runSetup } from "./setup.js";
-import { readUserConfig, readLockFile } from "@codemcp/ade-core";
-import { getDefaultCatalog } from "../../../core/src/catalog/index.js";
-
-describe("setup integration (real temp dir)", () => {
-  let dir: string;
-
-  beforeEach(async () => {
-    vi.clearAllMocks();
-    dir = await mkdtemp(join(tmpdir(), "ade-setup-"));
-  });
-
-  afterEach(async () => {
-    await rm(dir, { recursive: true, force: true });
-  });
-
-  it("writes config.yaml and config.lock.yaml for codemcp-workflows", async () => {
-    const catalog = getDefaultCatalog();
-
-    vi.mocked(clack.select)
-      .mockResolvedValueOnce("codemcp-workflows") // process
-      .mockResolvedValueOnce("__skip__"); // architecture
-    vi.mocked(clack.multiselect)
-      .mockResolvedValueOnce([]) // practices: none
-      .mockResolvedValueOnce(["claude-code"]); // harnesses
-
-    await runSetup(dir, catalog);
-
-    // ── config.yaml ──────────────────────────────────────────────────────
-    const config = await readUserConfig(dir);
-    expect(config).not.toBeNull();
-    expect(config!.choices).toEqual({ process: "codemcp-workflows" });
-
-    // ── config.lock.yaml ─────────────────────────────────────────────────
-    const lock = await readLockFile(dir);
-    expect(lock).not.toBeNull();
-    expect(lock!.version).toBe(1);
-    expect(lock!.choices).toEqual({ process: "codemcp-workflows" });
-    expect(lock!.generated_at).toBeTruthy();
-
-    // LogicalConfig was produced by the real resolver with real writers
-    const lc = lock!.logical_config;
-    expect(lc.mcp_servers).toHaveLength(1);
-    expect(lc.mcp_servers[0].ref).toBe("workflows");
-    expect(lc.instructions.length).toBeGreaterThan(0);
-
-    // ── Agent output: .mcp.json ─────────────────────────────────────────
-    const { readFile } = await import("node:fs/promises");
-    const mcpJson = JSON.parse(await readFile(join(dir, ".mcp.json"), "utf-8"));
-    expect(mcpJson.mcpServers["workflows"]).toMatchObject({
-      command: "npx",
-      args: ["@codemcp/workflows-server@latest"]
-    });
-
-    // ── Agent output: .claude/agents/ade.md ────────────────────────────
-    const agentMd = await readFile(
-      join(dir, ".claude", "agents", "ade.md"),
-      "utf-8"
-    );
-    expect(agentMd).toContain("Call whats_next()");
-  });
-
-  it("writes config.yaml, lock, and AGENTS.md for native-agents-md", async () => {
-    const catalog = getDefaultCatalog();
-
-    vi.mocked(clack.select)
-      .mockResolvedValueOnce("native-agents-md") // process
-      .mockResolvedValueOnce("__skip__"); // architecture
-    vi.mocked(clack.multiselect)
-      .mockResolvedValueOnce([]) // practices: none
-      .mockResolvedValueOnce(["claude-code"]); // harnesses
-
-    await runSetup(dir, catalog);
-
-    const config = await readUserConfig(dir);
-    expect(config!.choices).toEqual({ process: "native-agents-md" });
-
-    const lock = await readLockFile(dir);
-    expect(lock!.choices).toEqual({ process: "native-agents-md" });
-    expect(lock!.logical_config.instructions.length).toBeGreaterThan(0);
-
-    // Agent output: .claude/agents/ade.md is written with instruction text
-    const { readFile } = await import("node:fs/promises");
-    const agentMd = await readFile(
-      join(dir, ".claude", "agents", "ade.md"),
-      "utf-8"
-    );
-    expect(agentMd).toContain("AGENTS.md");
-  });
-
-  it("does not write any files when user cancels", async () => {
-    const catalog = getDefaultCatalog();
-    const cancelSymbol = Symbol("cancel");
-
-    vi.mocked(clack.select).mockResolvedValueOnce(cancelSymbol);
-    vi.mocked(clack.isCancel).mockReturnValue(true);
-
-    await runSetup(dir, catalog);
-
-    const config = await readUserConfig(dir);
-    expect(config).toBeNull();
-
-    const lock = await readLockFile(dir);
-    expect(lock).toBeNull();
-  });
-
-  it("produces valid YAML that roundtrips through read", async () => {
-    const catalog = getDefaultCatalog();
-
-    vi.mocked(clack.select)
-      .mockResolvedValueOnce("codemcp-workflows") // process
-      .mockResolvedValueOnce("__skip__"); // architecture
-    vi.mocked(clack.multiselect)
-      .mockResolvedValueOnce([]) // practices: none
-      .mockResolvedValueOnce(["claude-code"]); // harnesses
-
-    await runSetup(dir, catalog);
-
-    // Read the raw file and re-parse to ensure valid YAML
-    const { readFile } = await import("node:fs/promises");
-    const rawConfig = await readFile(join(dir, "config.yaml"), "utf-8");
-    const rawLock = await readFile(join(dir, "config.lock.yaml"), "utf-8");
-
-    // Both files should be non-empty valid YAML (not "undefined" or empty)
-    expect(rawConfig.length).toBeGreaterThan(0);
-    expect(rawLock.length).toBeGreaterThan(0);
-    expect(rawConfig).toContain("codemcp-workflows");
-    expect(rawLock).toContain("codemcp-workflows");
-  });
-});