@codemcp/ade-cli 0.0.2

package/src/commands/knowledge.integration.spec.ts

@@ -0,0 +1,129 @@
+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
+import { mkdtemp, rm, readFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+vi.mock("@clack/prompts", () => ({
+  intro: vi.fn(),
+  outro: vi.fn(),
+  select: vi.fn(),
+  multiselect: vi.fn(),
+  confirm: vi.fn(),
+  isCancel: vi.fn().mockReturnValue(false),
+  cancel: vi.fn(),
+  log: { info: vi.fn(), warn: vi.fn() },
+  spinner: vi.fn().mockReturnValue({ start: vi.fn(), stop: vi.fn() })
+}));
+
+import * as clack from "@clack/prompts";
+import { runSetup } from "./setup.js";
+import { readLockFile } from "@codemcp/ade-core";
+import { getDefaultCatalog } from "../../../core/src/catalog/index.js";
+
+describe("knowledge integration", () => {
+  let dir: string;
+
+  beforeEach(async () => {
+    vi.clearAllMocks();
+    dir = await mkdtemp(join(tmpdir(), "ade-knowledge-"));
+  });
+
+  afterEach(async () => {
+    await rm(dir, { recursive: true, force: true });
+  });
+
+  it(
+    "records knowledge sources in lock file when tanstack is selected",
+    { timeout: 60_000 },
+    async () => {
+      const catalog = getDefaultCatalog();
+
+      vi.mocked(clack.select)
+        .mockResolvedValueOnce("codemcp-workflows") // process
+        .mockResolvedValueOnce("tanstack"); // architecture
+
+      vi.mocked(clack.multiselect)
+        .mockResolvedValueOnce([]) // practices: none
+        .mockResolvedValueOnce([]) // backpressure: none
+        .mockResolvedValueOnce([
+          "tanstack-router-docs",
+          "tanstack-query-docs",
+          "tanstack-form-docs",
+          "tanstack-table-docs"
+        ])
+        .mockResolvedValueOnce(["claude-code"]); // harnesses
+
+      await runSetup(dir, catalog);
+
+      // Lock file should contain knowledge_sources
+      const lock = await readLockFile(dir);
+      expect(lock!.logical_config.knowledge_sources).toHaveLength(4);
+      expect(lock!.logical_config.knowledge_sources.map((s) => s.name)).toEqual(
+        expect.arrayContaining([
+          "tanstack-router-docs",
+          "tanstack-query-docs",
+          "tanstack-form-docs",
+          "tanstack-table-docs"
+        ])
+      );
+
+      // MCP server entry for knowledge should be in .mcp.json
+      const mcpJson = JSON.parse(
+        await readFile(join(dir, ".mcp.json"), "utf-8")
+      );
+      expect(mcpJson.mcpServers["knowledge"]).toMatchObject({
+        command: "npx",
+        args: ["-y", "@codemcp/knowledge-server"]
+      });
+
+      // Knowledge init is deferred — user should see a hint
+      expect(clack.log.info).toHaveBeenCalledWith(
+        expect.stringContaining("npx @codemcp/knowledge init")
+      );
+    }
+  );
+
+  it(
+    "excludes deselected docsets from lock file",
+    { timeout: 60_000 },
+    async () => {
+      const catalog = getDefaultCatalog();
+
+      vi.mocked(clack.select)
+        .mockResolvedValueOnce("codemcp-workflows") // process
+        .mockResolvedValueOnce("tanstack"); // architecture
+
+      vi.mocked(clack.multiselect)
+        .mockResolvedValueOnce([]) // practices: none
+        .mockResolvedValueOnce([]) // backpressure: none
+        .mockResolvedValueOnce(["tanstack-router-docs", "tanstack-query-docs"])
+        .mockResolvedValueOnce(["claude-code"]); // harnesses
+
+      await runSetup(dir, catalog);
+
+      // Lock file should only have the 2 selected sources
+      const lock = await readLockFile(dir);
+      expect(lock!.logical_config.knowledge_sources).toHaveLength(2);
+      expect(lock!.logical_config.knowledge_sources.map((s) => s.name)).toEqual(
+        expect.arrayContaining(["tanstack-router-docs", "tanstack-query-docs"])
+      );
+    }
+  );
+
+  it("does not show knowledge hint when no docsets are implied", async () => {
+    const catalog = getDefaultCatalog();
+
+    vi.mocked(clack.select)
+      .mockResolvedValueOnce("native-agents-md") // process
+      .mockResolvedValueOnce("__skip__"); // architecture: skip
+    vi.mocked(clack.multiselect)
+      .mockResolvedValueOnce(["tdd-london"]) // practices: no docsets
+      .mockResolvedValueOnce(["claude-code"]); // harnesses
+
+    await runSetup(dir, catalog);
+
+    expect(clack.log.info).not.toHaveBeenCalledWith(
+      expect.stringContaining("npx @codemcp/knowledge init")
+    );
+  });
+});

package/src/commands/setup.integration.spec.ts

@@ -0,0 +1,148 @@
+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
+import { mkdtemp, rm } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+// Mock only the TUI — everything else (catalog, registry, resolver, config I/O) is real
+vi.mock("@clack/prompts", () => ({
+  intro: vi.fn(),
+  outro: vi.fn(),
+  select: vi.fn(),
+  multiselect: vi.fn(),
+  confirm: vi.fn(),
+  isCancel: vi.fn().mockReturnValue(false),
+  cancel: vi.fn(),
+  spinner: vi.fn().mockReturnValue({ start: vi.fn(), stop: vi.fn() })
+}));
+
+import * as clack from "@clack/prompts";
+import { runSetup } from "./setup.js";
+import { readUserConfig, readLockFile } from "@codemcp/ade-core";
+import { getDefaultCatalog } from "../../../core/src/catalog/index.js";
+
+describe("setup integration (real temp dir)", () => {
+  let dir: string;
+
+  beforeEach(async () => {
+    vi.clearAllMocks();
+    dir = await mkdtemp(join(tmpdir(), "ade-setup-"));
+  });
+
+  afterEach(async () => {
+    await rm(dir, { recursive: true, force: true });
+  });
+
+  it("writes config.yaml and config.lock.yaml for codemcp-workflows", async () => {
+    const catalog = getDefaultCatalog();
+
+    vi.mocked(clack.select)
+      .mockResolvedValueOnce("codemcp-workflows") // process
+      .mockResolvedValueOnce("__skip__"); // architecture
+    vi.mocked(clack.multiselect)
+      .mockResolvedValueOnce([]) // practices: none
+      .mockResolvedValueOnce(["claude-code"]); // harnesses
+
+    await runSetup(dir, catalog);
+
+    // ── config.yaml ──────────────────────────────────────────────────────
+    const config = await readUserConfig(dir);
+    expect(config).not.toBeNull();
+    expect(config!.choices).toEqual({ process: "codemcp-workflows" });
+
+    // ── config.lock.yaml ─────────────────────────────────────────────────
+    const lock = await readLockFile(dir);
+    expect(lock).not.toBeNull();
+    expect(lock!.version).toBe(1);
+    expect(lock!.choices).toEqual({ process: "codemcp-workflows" });
+    expect(lock!.generated_at).toBeTruthy();
+
+    // LogicalConfig was produced by the real resolver with real writers
+    const lc = lock!.logical_config;
+    expect(lc.mcp_servers).toHaveLength(1);
+    expect(lc.mcp_servers[0].ref).toBe("workflows");
+    expect(lc.instructions.length).toBeGreaterThan(0);
+
+    // ── Agent output: .mcp.json ─────────────────────────────────────────
+    const { readFile } = await import("node:fs/promises");
+    const mcpJson = JSON.parse(await readFile(join(dir, ".mcp.json"), "utf-8"));
+    expect(mcpJson.mcpServers["workflows"]).toMatchObject({
+      command: "npx",
+      args: ["@codemcp/workflows-server@latest"]
+    });
+
+    // ── Agent output: .claude/agents/ade.md ────────────────────────────
+    const agentMd = await readFile(
+      join(dir, ".claude", "agents", "ade.md"),
+      "utf-8"
+    );
+    expect(agentMd).toContain("Call whats_next()");
+  });
+
+  it("writes config.yaml, lock, and AGENTS.md for native-agents-md", async () => {
+    const catalog = getDefaultCatalog();
+
+    vi.mocked(clack.select)
+      .mockResolvedValueOnce("native-agents-md") // process
+      .mockResolvedValueOnce("__skip__"); // architecture
+    vi.mocked(clack.multiselect)
+      .mockResolvedValueOnce([]) // practices: none
+      .mockResolvedValueOnce(["claude-code"]); // harnesses
+
+    await runSetup(dir, catalog);
+
+    const config = await readUserConfig(dir);
+    expect(config!.choices).toEqual({ process: "native-agents-md" });
+
+    const lock = await readLockFile(dir);
+    expect(lock!.choices).toEqual({ process: "native-agents-md" });
+    expect(lock!.logical_config.instructions.length).toBeGreaterThan(0);
+
+    // Agent output: .claude/agents/ade.md is written with instruction text
+    const { readFile } = await import("node:fs/promises");
+    const agentMd = await readFile(
+      join(dir, ".claude", "agents", "ade.md"),
+      "utf-8"
+    );
+    expect(agentMd).toContain("AGENTS.md");
+  });
+
+  it("does not write any files when user cancels", async () => {
+    const catalog = getDefaultCatalog();
+    const cancelSymbol = Symbol("cancel");
+
+    vi.mocked(clack.select).mockResolvedValueOnce(cancelSymbol);
+    vi.mocked(clack.isCancel).mockReturnValue(true);
+
+    await runSetup(dir, catalog);
+
+    const config = await readUserConfig(dir);
+    expect(config).toBeNull();
+
+    const lock = await readLockFile(dir);
+    expect(lock).toBeNull();
+  });
+
+  it("produces valid YAML that roundtrips through read", async () => {
+    const catalog = getDefaultCatalog();
+
+    vi.mocked(clack.select)
+      .mockResolvedValueOnce("codemcp-workflows") // process
+      .mockResolvedValueOnce("__skip__"); // architecture
+    vi.mocked(clack.multiselect)
+      .mockResolvedValueOnce([]) // practices: none
+      .mockResolvedValueOnce(["claude-code"]); // harnesses
+
+    await runSetup(dir, catalog);
+
+    // Read the raw file and re-parse to ensure valid YAML
+    const { readFile } = await import("node:fs/promises");
+    const rawConfig = await readFile(join(dir, "config.yaml"), "utf-8");
+    const rawLock = await readFile(join(dir, "config.lock.yaml"), "utf-8");
+
+    // Both files should be non-empty valid YAML (not "undefined" or empty)
+    expect(rawConfig.length).toBeGreaterThan(0);
+    expect(rawLock.length).toBeGreaterThan(0);
+    expect(rawConfig).toContain("codemcp-workflows");
+    expect(rawLock).toContain("codemcp-workflows");
+  });
+});